DDS-Java 1.0 (Java 5 Language PSM for DDS) — Spec Coverage

Source: internal/standards/cache/omg/dds-java-psm-1.0.pdf (44 pages, OMG formal/2013-11-02, November 2013) — OMG DDS-Java 1.0

Item-by-item audit against the PDF following internal/spec-coverage/PROCESS.md. Page numbers without a further note are PDF pages of this PDF (PDF page = printed page + 10; the cover is PDF page 1, the preface, printed iii and iv, is on PDF pages 9 and 10). Every normative sentence of §1 to §9 and of the annexes, every row of Table 7.1, Table 7.2, Table 8.1 and Table 8.2, every factory method §7.3.1 gives the ServiceEnvironment, and every default of the DataReader.Selector is an item of its own. §2 requires all programming interfaces of the conformance levels of [DDS]; by §3 [DDS] is version 1.2 (internal/standards/cache/omg/dds-1.2.pdf, PDF page = printed page + 12). The operations of the DCPS classes ([DDS] 1.2 §7.1.2, p. 25–107) and the built-in topics (§7.1.5, p. 147–150) are therefore one item each under §2; §7.3.7.1 requires one class per status of [DDS] ([DDS] 1.2 §7.1.4.1, p. 132–133, IDL p. 159–161) and §7.3.5.1 one interface per policy ([DDS] 1.2 §7.1.3, p. 108–120), one item per class; §7.3.5.2 one interface per entity QoS ([DDS] 1.2 IDL, p. 167–169), one item per QoS. Operations that differ only by _w_timestamp, and pairs of set_ and get_, are one item. done is used only where code and a test cover the requirement; a cited Java test names file and test method as file::method, a Rust test names the test function as file::module::name. A repository reference names the file and the symbol, no line number. A requirement on a name, a package or a signature counts as covered by a test when the test compiles against exactly that name; a property that compiling does not reveal (abstract, final, a parent class) needs a test that checks it. Every statement about behaviour is read from the code and the tests. The tests written in the second pass were only compiled on the Mac; they run on the Linux test host. Where code implements a requirement but no test checks it, the item is open and the note names the place in the code.

Context: DDS-Java 1.0 is spread over these parts of ZeroDDS:

crates/java-omgdds/java/ — the Maven module org.zerodds:omgdds (crates/java-omgdds/java/pom.xml, Java 17, profile java8 for Java 8) with the classes under org.omg.dds.core, org.omg.dds.core.policy, org.omg.dds.core.status, org.omg.dds.domain, org.omg.dds.topic, org.omg.dds.pub and org.omg.dds.sub, the implementation under org.zerodds.* and the JUnit 5 tests under src/test/java. The binding is a stack of its own in Java. It does not call the C API (crates/zerodds-c-api) and loads no native library (no JNI, no FFM; grep -rn "loadLibrary\|java.lang.foreign" crates/java-omgdds/java/src finds nothing). Samples reach the readers in the same process through org.zerodds.internal.InProcessBus; with -Dzerodds.rtps.enable=true or ZERODDS_RTPS=1 also through the RTPS stack in Java under org.zerodds.rtps (DdsWireBridge.enabled).
crates/idl-java/runtime/ — the annotations org.zerodds.types.Key, Id, Optional, MustUnderstand, External, Nested, Shared, Extensibility and the interface org.omg.dds.topic.TopicType; the POM compiles them into the same JAR through build-helper-maven-plugin.
runtime/java/ — the codec org.zerodds.wire.Writer/Reader that org.zerodds.cdr.ReflectionTypeSupport and the generated types use; the POM compiles it into the JAR as well.
The Java code generator: zerodds-idlc generate --lang java (tools/idlc/src/generate.rs, tools/idlc/src/java_support.rs) through crates/lang-rules (adapter/java.rs, emit/java.rs). It generates the topic types inside a class ZdTypes and, per type, a ZdTypeSupports.Support_<tag> that implements org.zerodds.cdr.TopicTypeSupport<T>.

The mapping of IDL to Java by IDL4 to Java is in idl4-java-1.0.en.md, the architecture of the module in zerodds-java-omgdds-1.0.en.md, the XCDR2 contract org.zerodds.cdr.TopicTypeSupport in zerodds-xcdr2-java-1.0.en.md, the endpoint API in zerodds-endpoint-java-1.0.en.md. This document covers the DDS API in Java by DDS-Java 1.0 and the rules DDS-Java itself sets for the types (§8, §9). org.omg.dds.rpc under runtime/java/ belongs to DDS-RPC 1.0 and is not covered by this document; neither is the RTPS stack under org.zerodds.rtps.

By §2 the PDF, the JAR omgdds.jar and the OMG source files are normative, and JAR and sources prevail in a conflict. The archive (cover page, Annex B) is in the cache (internal/standards/cache/omg/dds-java-psm-1.0-omgdds_src.zip); every file under org/omg/dds of the module equals the sources except EntityQos.java (an added @SuppressWarnings); CoreApiShapeTest checks this on every run against the SHA-256 of the source files (src/test/resources/omgdds-srcjava.sha256).

Open items: none.

§1 Scope

§1 PSM for DCPS only, without DLRL

Spec: §1, p. 11 — “This specification defines a platform-specific model (PSM) for the OMG Data Distribution Service for Real-Time Systems (DDS). It specifies an API only for the Data-Centric Publish-Subscribe (DCPS) portion of that specification; it does not address the Data Local Reconstruction Layer (DLRL).”

Repo: —

Tests: —

Status: n/a (informative) — Scope statement of the specification, no requirement that can be met. crates/java-omgdds/java/src/main/java/org/omg/dds contains the packages core, domain, pub, sub, topic and type; there is no dlrl package. DLRL belongs to DLRL 1.2 (tools/idlc/src/dlrl.rs). ### §1 Scope: the APIs of [DDS-XTypes]

Spec: §1, p. 11 — “In addition, it encompasses (a) the DDS APIs introduced by [DDS-XTypes] […]”

Repo: —

Tests: —

Status: n/a (informative) — Reference to §2 (Extensible and Dynamic Types level) and §7.8. The packages org.omg.dds.type, org.omg.dds.type.dynamic, org.omg.dds.type.typeobject and org.omg.dds.type.builtin exist in the code; the requirements are in the item “§2 Stufe Extensible and Dynamic Types”. ### §1 Scope: an API for QoS libraries and profiles by [DDS-CCM]

Spec: §1, p. 11 — “[…] and (b) an API to specifying QoS libraries and profiles such as were specified by [DDS-CCM].”

Repo: —

Tests: —

Status: n/a (informative) — Reference to §2 and §7.3.5.4. The API is org.omg.dds.core.QosProvider, the implementation is org.zerodds.core.qos.QosProviderImpl; the requirements are in the item “§2 XML-QoS-Profile”. ### §1 Java Type Representation without a description in another language

Spec: §1, p. 11 — “This specification also defines a means of publishing and subscribing Java objects with DDS-the Java Type Representation-without first describing the types of those objects in another language, such as XML or OMG IDL.”

Repo: —

Tests: —

Status: n/a (informative) — Reference to §8. Implemented by org.zerodds.cdr.ReflectionTypeSupport and TypeSupportResolver.resolve (a class without generated code is mapped by reflection); the check is in the item “§2 At least one Type Representation”.

§2 Conformance

§2 PDF, JAR and source files normative, JAR and sources prevail in a conflict

Spec: §2, p. 11; cover page, p. 1 — “This specification consists of this document as well as a Java jar library file and the source files that generated it, identified on the cover page (all are normative). In the event of a conflict between them, the latter shall prevail.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantOmgApiTest.java::everyExceptionOfTheBindingIsADdsObjectWithAnEnvironment, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantOmgApiTest.java::theExceptionsHaveTheSerialVersionUidOfTheOmgSource, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreApiShapeTest.java::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource

Status: done — DDSException implements DDSObject (org/omg/dds/core/DDSException.java), as the OMG source does; the seven exception classes in org.zerodds.core return the default environment from getEnvironment. The serialVersionUID of six exception classes is that of the OMG source. ParticipantOmgApiTest checks DDSObject and the serialVersionUID. CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource compares every file of org/omg/dds with the SHA-256 of the OMG source (line ends as LF), without a deviation; EntityQos.java, too, is the file of the OMG source. (commit 7f102b80f83) ### §2 Conformance parallels the levels of [DDS]

Spec: §2, p. 11; [DDS] 1.2 §2, p. 14–15 (dds-1.2.pdf) — “Conformance to this specification parallels conformance to the DDS specification itself and consists of the same conformance levels. For example, an implementation may conform to the DDS Minimum Profile with respect to this PSM, meaning that all of the programming interfaces identified by the DDS specification as pertaining to that conformance level must be implemented in this PSM.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase), crates/java-omgdds/README.md

Status: done — The conformance levels of Clause 2 are named in crates/java-omgdds/README.md: the Minimum, Content-Subscription, Persistence and Ownership Profiles and Extensible and Dynamic Types, without the Object Model Profile (DLRL); ConformanceClaimTest checks the statement. The interfaces of these levels are evidenced one by one in the items of this document: Entity (set_qos with IMMUTABLE_POLICY and INCONSISTENT_POLICY, listener propagation, StatusCondition), DomainParticipant (ignore_*, closeContainedEntities), the assignability of types, coherent sets, liveliness and the wait operations also towards peers in other processes. What is open in single operations is its own open item. (commit 2de26533680) ### §2 Object Model Profile (DLRL) excluded

Spec: §2, p. 11 — “The one exception to this rule is the Object Model Profile, which includes in part the Data Local Reconstruction Layer (DLRL); DLRL is outside of the scope of this PSM.”

Repo: —

Tests: —

Status: n/a (informative) — Delimitation by the specification. The Object Model Profile comprises DLRL (not in the code) and access_scope = GROUP of PRESENTATION; the PRESENTATION policy exists as org.omg.dds.core.policy.Presentation, its effect was not examined here. ### §2 Extensible and Dynamic Types conformance level

Spec: §2, p. 11 — “In addition to the conformance levels defined in the DDS specification itself, this PSM recognizes and implements the Extensible and Dynamic Types conformance level for DDS defined by the Extensible and Dynamic Topic Types for DDS specification [DDS-XTypes].”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicType.java (DynamicType), crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicData.java (DynamicData), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataImpl.java (DynamicDataImpl), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataTypeSupport.java (DynamicDataTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeObjectRegistry.java (TypeObjectRegistry), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/TypeConsistencyEnforcementImpl.java (TypeConsistencyEnforcementImpl), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeAssignability.java (TypeAssignability), crates/java-omgdds/java/src/main/java/org/zerodds/internal/InProcessBus.java (InProcessBus.registerReader), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.acceptsType), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.acceptsRemoteWriter), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.acceptsRemoteReader), crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/TypeObjectToDynamic.java (TypeObjectToDynamic.of), crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/TypeObjects.java (TypeObjects.dynamicTypeOf)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aWriterAndAReaderOnTheTopicOfADynamicTypeMoveDynamicData, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::enumerationsStructuresCollectionsAndMapsFollowTable81, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::sedpCarriesTheTypeInformationAndTheTypeNames, crates/java-omgdds/java/src/test/java/org/omg/dds/QosCompatibilityTest.java::differentTypeNamesDoNotConnect, crates/java-omgdds/java/src/test/java/org/omg/dds/TypeCoercionTest.java::anAppendedMemberIsAssignableInBothDirections, crates/java-omgdds/java/src/test/java/org/omg/dds/TypeCoercionTest.java::aMemberOfTheSameIdAndAnotherTypeIsNotAssignable, crates/java-omgdds/java/src/test/java/org/omg/dds/TypeCoercionTest.java::differentExtensibilityIsNotAssignable, crates/java-omgdds/java/src/test/java/org/omg/dds/TypeCoercionTest.java::aDerivedTypeIsDeclaredAsItsBase, crates/java-omgdds/java/src/test/java/org/omg/dds/TypeCoercionTest.java::anAssignableReaderTakesTheSamplesOfAnotherTypeName, crates/java-omgdds/java/src/test/java/org/omg/dds/TypeCoercionTest.java::anExactReaderDoesNotTakeThem, crates/java-omgdds/java/src/test/java/org/omg/dds/TypeCoercionTest.java::anAssignableReaderDoesNotTakeAClashingType, crates/java-omgdds/java/src/test/java/org/omg/dds/TypeCoercionTest.java::aDeclaredReaderTakesADerivedType, crates/java-omgdds/java/src/test/java/org/omg/dds/WireEntityBehaviourTest.java::anAssignableReaderTakesARemoteWriterOfAnotherTypeNameByItsTypeObject, crates/java-omgdds/java/src/test/java/org/omg/dds/WireEntityBehaviourTest.java::anExactReaderDoesNotTakeThatRemoteWriter, crates/java-omgdds/java/src/test/java/org/omg/dds/WireEntityBehaviourTest.java::aWriterTakesARemoteReaderOfAnotherTypeNameThatAllowsCoercionAndHasAnAssignableType

Status: done — The type consistency acts when a reader and a writer are matched. EXACT_TYPE_TYPE_CONSISTENCY and EXACT_NAME_TYPE_CONSISTENCY need the same type name (InProcessBus keeps a channel per domain, topic name and type name). A reader with ASSIGNABLE_TYPE_CONSISTENCY takes writers of another type name on the same topic when TypeAssignability.assignableFrom (the rules of XTypes 1.3 §7.2.4.4: aliases resolved, same primitives, character width of strings, equal array bounds, elements “strongly assignable”, enumerations with equal names and values, structures by member ids and names, key, optional and must-understand rules, for APPENDABLE and FINAL the members at the same position) finds the type of the writer assignable; with DECLARED_TYPE_CONSISTENCY it takes only writers whose type names its own as a base type (TypeAssignability.declared). In the same process InProcessBus passes the samples on over links (Link). Over RTPS the reader decides from the TypeObject (PID 0x0072) the writer announces (TypeObjectToDynamic); the writer takes a reader of another type name that announces ALLOW_TYPE_COERCION in SEDP (ASSIGNABLE and DECLARED are written so, EXACT as DISALLOW) and whose TypeObject is assignable from its type. A peer without an announced TypeObject cannot be judged and is not connected. @ignore_literal_names and the per-label rules of unions belong to XTypes 1.3 §7.2.4.4 and are not evaluated. (commit 178c642cbc7) ### §2 XML QoS profiles: operations in full or UnsupportedOperationException

Spec: §2, p. 11 — “This PSM furthermore defines methods to create Entities and to set their QoS based on the XML QoS libraries and profiles defined by the DDS for Lightweight CCM specification. Implementations that support these XML QoS profiles shall implement these operations fully; other implementations shall throw java.lang.UnsupportedOperationException.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/QosProvider.java (QosProvider), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosProviderImpl.java (QosProviderImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.setQos)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::theQosOfEveryEntityKindCarriesTheValuesOfTheDocument, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::theWriterAndReaderQosCarryTheValuesOfTheDocumentAndKeepTheDefaultsOfWhatItLeavesOut, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::aProfileInheritsFromItsBaseAndOverridesFieldByField, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::anotherSchemeIsUnsupported, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::entitySetQosWithAnUriAndAProfileAppliesTheQosOfThatProfile

Status: done — QosProviderImpl reads DDS-XML 1.0 libraries (dds-xml_qos_definitions.xsd) from file:// URIs: <qos_library>, <qos_profile name base_name>, seven entity QoS elements, the 22 policy elements of the schema file with its literals (RELIABLE_RELIABILITY_QOS), durations as <sec>/<nanosec> with DURATION_INFINITY, LENGTH_UNLIMITED, base64 for octet sequences, a partition as <name><element>. Inheritance through base_name at profile and element level; a cycle, a base defined later and a missing base are IllegalArgumentException. Every other URI scheme raises UnsupportedOperationException. Unknown elements, fields, literals and malformed values are IllegalArgumentException; nothing is passed over silently. Entity.setQos(String, String) calls the provider through EntityBase.setQos with the first argument as the URI. The earlier reader expected a wrapper element per entity element and Java enum names and so did not read a DDS-XML document. Tested in QosProviderTest (all entity kinds, inheritance, error cases, other scheme, setQos(uri, profile) on all six entities). (commit a68b0889e7a) ### §2 At least one Type Representation of [DDS-XTypes] or §8

Spec: §2, p. 11 — “Finally, any conformant implementation must support at least one of the OMG-specified Type Representations defined by [DDS-XTypes] and/or in the Java Type Representation section of this specification (Clause 8).”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeSupportResolver.java (TypeSupportResolver.resolve), tools/idlc/src/java_support.rs (source)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::pointMatchesV2, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theKindsOfTable81RoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::singleArgFactoryReflectsTypedBean

Status: done — The Java Type Representation is implemented: TypeSupportResolver.resolve maps a class without generated code through ReflectionTypeSupport. pointMatchesV2 compares the encoded bytes of a bean with the wire vector (01 00 00 00 FE FF FF FF) and decodes back; theKindsOfTable81RoundTrip round-trips BigInteger, BigDecimal, enum, Set and List; singleArgFactoryReflectsTypedBean writes and reads a bean through topic, writer and reader. The IDL Type Representation reaches the generated types through tools/idlc/src/java_support.rs. (commit 819bfcb46cb)

§2 Programming interfaces of [DDS] 1.2: Entity

§2 Entity: set_qos and get_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.1, p. 25–26 (dds-1.2.pdf), table Entity — “abstract set_qos (qos_list: QosPolicy []): ReturnCode_t; abstract get_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.getQos), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosRules.java (QosRules.checkChange), crates/java-omgdds/java/src/main/java/org/zerodds/internal/InProcessBus.java (InProcessBus.writerPartitionsChanged), crates/java-omgdds/java/src/main/java/org/zerodds/internal/InProcessBus.java (InProcessBus.readerPartitionsChanged), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.announceQos), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.announceQos), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.WireWriter.updateQos), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.WireReader.updateQos), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.topicQosChanged)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::defaultQosIsTheQosOfWhatIsCreatedNext, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::factoryQosAndDefaultParticipantQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::anEnabledWriterTakesNewValuesOfTheChangeablePolicies, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::anEnabledWriterRefusesAChangeOfAnImmutablePolicyAndKeepsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::settingTheSameValueOfAnImmutablePolicyIsNoChange, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::anEnabledReaderTakesATimeBasedFilterAndRefusesAnotherHistory, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::aDeadlineShorterThanTheMinimumSeparationIsInconsistent, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::anEnabledTopicTakesTopicDataAndRefusesAnotherReliability, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::aPublisherTakesAPartitionAndGroupDataAndRefusesAnotherPresentation, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::aSubscriberTakesAPartitionAndRefusesAnotherPresentation, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::aParticipantAndTheFactoryTakeNewUserDataAndEntityFactory, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::beforeEnableAnyPolicyChangesAndAfterEnableTheImmutableOnesDoNot, crates/java-omgdds/java/src/test/java/org/omg/dds/QosPartitionChangeTest.java::aPublisherThatChangesItsPartitionEndsAndStartsMatches, crates/java-omgdds/java/src/test/java/org/omg/dds/QosPartitionChangeTest.java::aSubscriberThatChangesItsPartitionEndsAndStartsMatches, crates/java-omgdds/java/src/test/java/org/omg/dds/QosPartitionChangeTest.java::aChangeThatKeepsTheOverlapIsNoMatchEvent, crates/java-omgdds/java/src/test/java/org/omg/dds/QosBuiltinUpdateTest.java::aChangedQosOfAWriterAndOfItsPublisherIsANewSampleOnThePublicationTopic, crates/java-omgdds/java/src/test/java/org/omg/dds/QosBuiltinUpdateTest.java::aChangedQosOfAReaderAndOfItsSubscriberIsANewSampleOnTheSubscriptionTopic, crates/java-omgdds/java/src/test/java/org/omg/dds/WireEntityBehaviourTest.java::aChangedQosOfAWriterReachesTheReaderOfAnotherProcessOverSedp, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinQosAnnouncementTest.java::aChangedTopicQosIsANewSampleOfTheTopicInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::aHistoryDepthAboveMaxSamplesPerInstanceIsInconsistent, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::theBuiltinReaderSeesTheUserDataChangeOfAnotherParticipant

Status: done — getQos exists on all six entities. setQos checks through org.zerodds.core.qos.QosRules.checkChange first the consistency of the policies (InconsistentPolicyException, also when an immutable policy changes at the same time) and, after enable, the policies whose column “Changeable” in DDS 1.4 §2.2.3 is “No” (DURABILITY, DURABILITY_SERVICE, PRESENTATION, OWNERSHIP, LIVELINESS, RELIABILITY, DESTINATION_ORDER, HISTORY, RESOURCE_LIMITS, DATA_REPRESENTATION, TYPE_CONSISTENCY_ENFORCEMENT; ImmutablePolicyException); an equal value is no change; with both exceptions the QoS stays as it was. That holds for DataWriter, DataReader, Topic, Publisher, Subscriber, DomainParticipant and DomainParticipantFactory. After a change of DEADLINE or LIVELINESS the periods restart; a changed PARTITION makes writers and readers match again. The changed QoS of a writer, reader, publisher, subscriber, topic or participant is a new sample of the same instance in “DCPSPublication”, “DCPSSubscription”, “DCPSTopic” and “DCPSParticipant”, and writers and readers connected over RTPS announce it again in SEDP (WireWriter.updateQos, WireReader.updateQos); the peer then matches again. The SEDP writers keep only the last announcement of each endpoint and peer (KEEP_LAST 1), so repeated announcements do not fill the history. (commit 447490d2b6d) ### §2 Entity: set_listener and get_listener

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.1, p. 26 (dds-1.2.pdf), table Entity — “abstract set_listener (a_listener: Listener, mask: StatusKind []): ReturnCode_t; abstract get_listener: Listener”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.setListener), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.getListener), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.setListener), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.listenerWants), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/ListenerUp.java (ListenerUp), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.listenerFor)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerPropagationTest.java::aWriterWithoutListenerPassesTheMatchToThePublisherAndThenTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerPropagationTest.java::aReaderListenerSetAtCreationSeesTheMatchOfEnableAndTheSubscriberGetsDataOnReaders, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantSubscriberTest.java::aWriterListenerThatDoesNotTakeAStatusLeavesItToThePublisher, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantSubscriberTest.java::anEmptyMaskTakesNoStatusAndANullMaskTakesAll, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicOfTheSameNameAndAnotherTypeInTheDomainIsInconsistentAndTellsTheTopicListener, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicWithoutListenerPassesInconsistentTopicToTheParticipantListener, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aWriterWithoutListenerPassesOfferedIncompatibleQosToThePublisher, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aWriterWithoutListenerAndAPublisherWithoutOnePassItToTheParticipantListener

Status: done — The listeners of DomainParticipant, Publisher, Subscriber and Topic are called. A status goes to the listener of the entity when that listener has the status in its mask (null = all, empty = none), else to the one of the containing entity: DataWriter to Publisher and DomainParticipant, DataReader to Subscriber and DomainParticipant, Topic to DomainParticipant (ListenerUp, EntityBase.ownListener, DataWriterImpl.listenerFor, TopicImpl.listenerFor). Tests: propagation from the writer to publisher and participant (ListenerPropagationTest), status mask of a writer listener and the empty and null masks (ParticipantSubscriberTest), INCONSISTENT_TOPIC to topic and participant listener (TopicOperationsTest), OFFERED_INCOMPATIBLE_QOS to publisher and participant listener (PublisherOperationsTest). (commit f31b6fa11b5) ### §2 Entity: status mask and listener at creation

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.1, p. 26, §7.1.2.2.1, p. 34–35 (dds-1.2.pdf) — “set_listener (a_listener: Listener, mask: StatusKind [])”; “create_publisher (qos_list: QosPolicy [], a_listener: PublisherListener, mask: StatusKind []): Publisher”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory.createParticipant), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.createPublisher), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher.createDataWriter), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Subscriber.java (Subscriber.createDataReader), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createPublisher), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.createDataWriter)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerPropagationTest.java::aWriterListenerSetAtCreationSeesTheMatchOfEnable, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerPropagationTest.java::aReaderListenerSetAtCreationSeesTheMatchOfEnableAndTheSubscriberGetsDataOnReaders, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createParticipantWithAListenerAndAMaskReachesItFromTheWritersOfTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createPublisherWithAListenerSeesTheMatchOfAWriterCreatedLater, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createSubscriberWithAListenerSeesTheMatchOfAReaderCreatedLater, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createTopicWithAListenerAndAMaskKeepsThem

Status: done — The create* operations with listener and status set set the listener before enable: DomainParticipantImpl.newPublisher, newSubscriber and newTopic, PublisherImpl.createDataWriter, SubscriberImpl.createDataReader; DomainParticipantFactoryImpl.createParticipant sets it before the participant is registered. A SUBSCRIPTION_MATCHED or PUBLICATION_MATCHED of an existing counterpart thus reaches the listener set at creation. Tests: writer and reader with listener and an existing counterpart (ListenerPropagationTest), publisher and subscriber with listener and a writer or reader created later, participant with listener and mask, topic with listener (ParticipantEntityTest). (commit cd8f3d67ea9) ### §2 Entity: enable

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.1, p. 26 (dds-1.2.pdf), table Entity — “enable: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.enable), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.enable), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.enable), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.enable), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.enableIfFactorySays), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.enable), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.enable), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.enableBuiltin)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::aFactoryThatDoesNotAutoEnableCreatesADisabledParticipantWhoseChildrenStayDisabled, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::aWriterOfADisabledPublisherIsDisabledAndEnablingThePublisherEnablesIt, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::aPublisherThatDoesNotAutoEnableLeavesItsWritersToEnable, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::aReaderOfADisabledSubscriberIsDisabledAndEnablingTheSubscriberEnablesIt, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::aSubscriberThatDoesNotAutoEnableLeavesItsReadersToEnable, crates/java-omgdds/java/src/test/java/org/omg/dds/ReentrancyTest.java::concurrentEnableRegistersTheEndpointOnce, crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aNotEnabledWriterRefusesToWrite

Status: done — enable follows DDS 1.4 §2.2.2.1.1.7. An entity whose factory is not enabled is created disabled, and enable on it is PreconditionNotMetException (PublisherImpl.enable, SubscriberImpl.enable, DataWriterImpl.enable, DataReaderImpl.enable). DomainParticipantImpl.enable, PublisherImpl.enable and SubscriberImpl.enable enable the children created so far when ENTITY_FACTORY autoenable_created_entities holds; createDataWriter and createDataReader enable only when the publisher/subscriber is enabled and its autoenable_created_entities holds. The built-in publisher and subscriber are enabled with enableBuiltin. Tests: factory with autoenable = false (participant and children disabled, PreconditionNotMetException, enabling through enable), writer of a disabled publisher, publisher with autoenable = false, the same cases for reader and subscriber (ParticipantEntityTest). (commit cd8f3d67ea9) ### §2 Entity: get_statuscondition

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.1, p. 26 (dds-1.2.pdf), table Entity — “get_statuscondition: StatusCondition”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.getStatusCondition), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.getStatusCondition), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/StatusConditionImpl.java (StatusConditionImpl.getTriggerValue), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aStatusConditionTriggersOnTheStatusItIsEnabledForAndHasItsEntityAsParent, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aStatusIsResetWhenItIsReadAndDataAvailableWhenTheSamplesAreTaken, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::theStatusChangesOfAWriterListThePendingStatusesUntilTheyAreRead, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::anInconsistentTopicTriggersItsStatusCondition

Status: done — getStatusCondition returns a StatusConditionImpl whose trigger value follows the status kinds set by triggerStatus and cleared by reading the respective status. DataReaderImpl sets DATA_AVAILABLE, SAMPLE_REJECTED, SAMPLE_LOST, SUBSCRIPTION_MATCHED, REQUESTED_INCOMPATIBLE_QOS and REQUESTED_DEADLINE_MISSED through triggerStatus, DataWriterImpl PUBLICATION_MATCHED, OFFERED_INCOMPATIBLE_QOS, OFFERED_DEADLINE_MISSED and LIVELINESS_LOST, TopicImpl INCONSISTENT_TOPIC. Tests: wait set with the status condition of a reader (WaitSetTest), reset by reading (ReaderStatusTest), status condition of a writer and of a topic (WriterStatusTest, TopicOperationsTest). (commit d23eff980f3) ### §2 Entity: get_status_changes

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.1, p. 26 (dds-1.2.pdf), table Entity — “get_status_changes: StatusKind []”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.getStatusChanges), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.getStatusChanges), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.triggerStatus)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aStatusIsResetWhenItIsReadAndDataAvailableWhenTheSamplesAreTaken, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::theStatusChangesOfAWriterListThePendingStatusesUntilTheyAreRead, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::aMissedOfferedDeadlineIsCountedWithTheInstanceThatMissedIt, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicOfTheSameNameAndAnotherTypeInTheDomainIsInconsistentAndTellsTheTopicListener

Status: done — EntityBase.getStatusChanges returns the set of triggered status kinds without clearing it; a status is reset when the respective status is read (getStatus, read and take for DATA_AVAILABLE) (EntityBase.clearStatus). Tests: reader after a match, reading the status and take (ReaderStatusTest), writer after a match and reading (WriterStatusTest), topic after INCONSISTENT_TOPIC (TopicOperationsTest). Deadline status: WriterStatusTest::aMissedOfferedDeadlineIsCountedWithTheInstanceThatMissedIt waits with getStatusChanges for OfferedDeadlineMissedStatus. (commit 166d5873d4a) ### §2 Entity: get_instance_handle

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.1, p. 26 (dds-1.2.pdf), table Entity — “get_instance_handle: InstanceHandle_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.getInstanceHandle), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.getInstanceHandle), crates/java-omgdds/java/src/main/java/org/zerodds/core/Values.java (Values.ofUuid), crates/java-omgdds/java/src/main/java/org/zerodds/topic/BuiltinData.java (BuiltinData)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::containsEntityWalksTheContainment, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::theBuiltinReaderOfAParticipantSeesTheEntitiesOfTheDomain, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::getDiscoveredTopicDataCarriesTheTopicQos

Status: done — Each entity holds an immutable handle built from a UUID in the constructor (EntityBase). containsEntityWalksTheContainment passes the handles of publisher, writer, subscriber, reader and topic to containsEntity (all true, nil handle false); the key in the data of the built-in participant topic equals the getInstanceHandle of the other participant, and getDiscoveredTopicData finds a topic by its handle. Uniqueness follows from the UUID and is not checked directly. (commit d23eff980f3)

§2 Programming interfaces of [DDS] 1.2: DomainParticipantFactory

§2 DomainParticipantFactory: create_participant

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.2, p. 45 (dds-1.2.pdf), table DomainParticipantFactory — “create_participant (domain_id: DomainId_t, qos_list: QosPolicy [], a_listener: DomainParticipantListener, mask: StatusKind []): DomainParticipant”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::factoryQosAndDefaultParticipantQos, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::entityFactoryDecidesWhetherWhatIsCreatedIsEnabled, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createParticipantWithAListenerAndAMaskReachesItFromTheWritersOfTheParticipant

Status: done — createParticipant(int, DomainParticipantQos, DomainParticipantListener, Collection) sets listener and status set before the participant is registered with the factory (DomainParticipantFactoryImpl.createParticipant). ParticipantEntityTest::createParticipantWithAListenerAndAMaskReachesItFromTheWritersOfTheParticipant calls the form with listener and mask {PUBLICATION_MATCHED} and checks that PUBLICATION_MATCHED of a writer without a listener of its own reaches the participant listener and SUBSCRIPTION_MATCHED, which is not in the mask, does not. (commit 2e0b194caf5) ### §2 DomainParticipantFactory: a new participant per call

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.2.1, p. 46 (dds-1.2.pdf) — “This operation creates a new DomainParticipant object.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl.createParticipant), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl.register)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantFactoryTest.java::createParticipantCreatesANewParticipantEachCall

Status: done — createParticipant creates a new DomainParticipantImpl on every call and adds it to a list per domain (DomainParticipantFactoryImpl.register). The test creates two participants in the same domain and asserts assertNotSame; the reference to computeIfAbsent in the previous item is outdated. (commit 2e0b194caf5) ### §2 DomainParticipantFactory: delete_participant

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.2, p. 45, §7.1.2.2.2.2, p. 46 (dds-1.2.pdf) — “delete_participant (a_participant: DomainParticipant): ReturnCode_t”; “This operation can only be invoked if all domain entities belonging to the participant have already been deleted. Otherwise the error PRECONDITION_NOT_MET is returned.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCascadeTest.java::participantCloseClosesContainedEntities, crates/java-omgdds/java/src/test/java/org/omg/dds/DurabilityServiceTest.java::transientIsClearedWhenTheParticipantCloses, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::theDataOfADomainSurvivesTheCloseOfAParticipantWhileAnotherOneIsOpen

Status: done — DomainParticipantImpl.close closes the contained entities (§7.2.3), removes the participant from the factory and from the table of all participants of the process and clears the TRANSIENT data of the domain only if no participant of the domain is open afterwards (DomainParticipantFactoryImpl.participantsInDomain, DurabilityService.clearDomain). DomainParticipantFactory has no deleteParticipant operation (OMG API). ParticipantEntityTest::theDataOfADomainSurvivesTheCloseOfAParticipantWhileAnotherOneIsOpen writes TRANSIENT data, closes the writer and one of two participants (data stays), checks lookupParticipant, closes the second (lookupParticipant returns null, a new reader gets nothing). (commit cd8f3d67ea9) ### §2 DomainParticipantFactory: get_instance

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.2, p. 45, §7.1.2.2.2.3, p. 46 (dds-1.2.pdf) — “(static) get_instance: DomainParticipantFactory”; “it will return the same DomainParticipantFactory instance.”

Status: done — ZeroSPI.getParticipantFactory creates the factory with a volatile field and under a lock (ServiceEnvironmentImpl). ParticipantFactoryEnvironmentTest::threadsThatAskForTheFactoryOfANewEnvironmentTogetherGetTheSameOne has eight threads request the factory of a new environment at the same time (CyclicBarrier), 25 rounds, and expects the same object; the earlier tests check assertSame for two calls, assertNotSame between two environments and the NullPointerException for null. (commit 36e8fd3f496) ### §2 DomainParticipantFactory: lookup_participant

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.2, p. 45 (dds-1.2.pdf), table DomainParticipantFactory — “lookup_participant (domain_id: DomainId_t): DomainParticipant”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory.lookupParticipant), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl.lookupParticipant)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::lookupParticipantFindsOneOfTheDomain, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::theDataOfADomainSurvivesTheCloseOfAParticipantWhileAnotherOneIsOpen, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantFactoryEnvironmentTest.java::everyEnvironmentHasItsOwnFactoryAndItsOwnParticipantTable

Status: done — lookupParticipant(int) returns the first participant of the domain from the factory table, otherwise null; after close the participant is removed from the table. Tests: DomainParticipantOperationsTest::lookupParticipantFindsOneOfTheDomain (assertSame, another domain null); ParticipantEntityTest::theDataOfADomainSurvivesTheCloseOfAParticipantWhileAnotherOneIsOpen (null after closing); ParticipantFactoryEnvironmentTest::everyEnvironmentHasItsOwnFactoryAndItsOwnParticipantTable (the factory of another environment does not find the participant). (commit 2e0b194caf5) ### §2 DomainParticipantFactory: set_default_participant_qos and get_default_participant_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.2, p. 45 (dds-1.2.pdf), table DomainParticipantFactory — “set_default_participant_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_participant_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory.setDefaultParticipantQos), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl.setDefaultParticipantQos)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::factoryQosAndDefaultParticipantQos, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::aDefaultQosWhosePoliciesAreNotConsistentIsRefusedAndKeepsTheOldOne

Status: done — getDefaultParticipantQos returns the set value; a participant created afterwards with createParticipant(int) has exactly this QoS (assertEquals on getQos). DDS 1.4 requires a consistency check for set_default_participant_qos; for the policies of a DomainParticipantQos (USER_DATA, ENTITY_FACTORY) §2.2.3 names no rule that makes two values inconsistent, so the check is empty here. The default operations of publisher, subscriber, topic and writer check with QosRules.checkConsistent (ParticipantEntityTest, PublisherOperationsTest). (commit 2e0b194caf5) ### §2 DomainParticipantFactory: get_qos and set_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.2, p. 45 (dds-1.2.pdf), table DomainParticipantFactory — “get_qos (out: qos_list: QosPolicy []): ReturnCode_t; set_qos (qos_list: QosPolicy []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl.autoEnable)

Status: done — getQos and setQos of the factory exist; DomainParticipantFactoryImpl.autoEnable evaluates ENTITY_FACTORY. ParticipantEntityTest::aFactoryThatDoesNotAutoEnableCreatesADisabledParticipantWhoseChildrenStayDisabled sets a factory QoS with autoEnableCreatedEntities = false, creates a participant, expects isEnabled() = false, the refusal of enable on its children with PreconditionNotMetException and the enabled children after enable(); the factory QoS is reset in finally. (commit 2e0b194caf5)

§2 Programming interfaces of [DDS] 1.2: DomainParticipant

§2 DomainParticipant: create_publisher and delete_publisher

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 34–35 (dds-1.2.pdf), table DomainParticipant — “create_publisher (qos_list: QosPolicy [], a_listener: PublisherListener, mask: StatusKind []): Publisher; delete_publisher (a_publisher: Publisher): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.createPublisher), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createPublisher), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.close)

Status: done — createPublisher() has the forms without argument, with PublisherQos and with listener and status set; the listener is set before enable (DomainParticipantImpl.newPublisher). A closed publisher leaves the participant’s list through the close hook (containsEntity returns false afterwards). Tests: PublisherQos of the call and default (DomainParticipantOperationsTest, ParticipantEntityTest), overload with listener (ParticipantEntityTest::createPublisherWithAListenerSeesTheMatchOfAWriterCreatedLater), containsEntity after close (CloseCleanupTest::aClosedPublisherAndSubscriberLeaveTheParticipant), closing the writers (CloseCascadeTest). (commit 28e25c198d1) ### §2 DomainParticipant: create_subscriber and delete_subscriber

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 35 (dds-1.2.pdf), table DomainParticipant — “create_subscriber (qos_list: QosPolicy [], a_listener: SubscriberListener, mask: StatusKind []): Subscriber; delete_subscriber (a_subscriber: Subscriber): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.createSubscriber), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createSubscriber), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.close)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantSubscriberTest.java::closingASubscriberClosesItsReadersAndLeavesTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createSubscriberWithAListenerSeesTheMatchOfAReaderCreatedLater, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCleanupTest.java::aClosedPublisherAndSubscriberLeaveTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aClosedEntityRefusesToCreateContainedEntities

Status: done — createSubscriber() has the forms without argument, with SubscriberQos and with listener and status set; the listener is set before enable (DomainParticipantImpl.newSubscriber). SubscriberImpl.close closes the DataReaders, and the subscriber leaves the participant’s list. Tests: ParticipantSubscriberTest::closingASubscriberClosesItsReadersAndLeavesTheParticipant (reader closed, read throws AlreadyClosedException, containsEntity false, createDataReader throws AlreadyClosedException), ParticipantEntityTest::createSubscriberWithAListenerSeesTheMatchOfAReaderCreatedLater. (commit 28e25c198d1) ### §2 DomainParticipant: create_topic and delete_topic

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 35 (dds-1.2.pdf), table DomainParticipant — “create_topic (topic_name: string, type_name: string, qos_list: QosPolicy [], a_listener: TopicListener, mask: StatusKind []): Topic; delete_topic (a_topic: Topic): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.createTopic), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createTopic), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.close)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTypeSupportRegisteredUnderANameGivesTheTopicItsWritersAndItsAnnouncementThatName, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aClosedTopicIsGoneFromLookupFindAndDiscovery, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::closingAContentFilteredTopicNeedsItsReadersGoneAndRemovesItFromTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::closingAMultiTopicNeedsItsReadersGoneAndFreesTheTopicsOfItsFromClause, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::theDefaultQosOfSubscriberAndTopicIsTheQosOfWhatIsCreatedNext, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createTopicWithAListenerAndAMaskKeepsThem, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCleanupTest.java::aTopicInUseCannotBeClosedUntilItsWritersAndReadersAre, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aWriterAndAReaderOnTheTopicOfADynamicTypeMoveDynamicData

Status: done — createTopic with Class, TypeSupport and DynamicType, with and without TopicQos, listener and status set; the listener is set before enable (DomainParticipantImpl.newTopic). TopicImpl.close throws PreconditionNotMetException while a DataWriter, DataReader, ContentFilteredTopic or MultiTopic uses the topic (TopicImpl.use/release, counted also by ContentFilteredTopicImpl and MultiTopicImpl), and the topic leaves the participant’s list and DCPSTopic through the close hook. Tests: TypeSupport forms (TopicOperationsTest::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass, ::aTypeSupportRegisteredUnderANameGivesTheTopicItsWritersAndItsAnnouncementThatName), a TopicQos passed (ParticipantEntityTest::theDefaultQosOfSubscriberAndTopicIsTheQosOfWhatIsCreatedNext), listener (ParticipantEntityTest::createTopicWithAListenerAndAMaskKeepsThem), close with users and afterwards (CloseCleanupTest, TopicOperationsTest). (commit 36e8fd3f496) ### §2 DomainParticipant: create_contentfilteredtopic and delete_contentfilteredtopic

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 35 (dds-1.2.pdf), table DomainParticipant — “create_contentfilteredtopic (name: string, related_topic: Topic, filter_expression: string, expression_parameters: string []): ContentFilteredTopic; delete_contentfilteredtopic (a_contentfilteredtopic: ContentFilteredTopic): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.createContentFilteredTopic), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createContentFilteredTopic), crates/java-omgdds/java/src/main/java/org/zerodds/topic/ContentFilteredTopicImpl.java (ContentFilteredTopicImpl.setExpressionParameters), crates/java-omgdds/java/src/main/java/org/zerodds/sub/ContentFilter.java (ContentFilter.compile)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::setExpressionParametersFiltersWithTheNewParametersFromThenOn, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::closingAContentFilteredTopicNeedsItsReadersGoneAndRemovesItFromTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicDescriptionIsCloseableAndLeavesTheParticipantWhenTheResourceEnds, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicAndAContentFilteredTopicKnowTheirNameTypeAndParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theContentFilteredTopicOfTheParticipantFiltersTheSamples, crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::expressionParameters, crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::aMalformedExpressionIsRejected

Status: done — ContentFilteredTopicImpl.setExpressionParameters compiles the expression again with ContentFilter.compile and the new parameters; a parameter set the expression cannot take (a missing %n) is refused with IllegalArgumentException and the old one stays. close throws PreconditionNotMetException while a reader reads the topic, releases the related topic and removes the entry from the participant’s list (lookupTopicDescription returns null); a closed topic is AlreadyClosedException for new readers. Tests: TopicOperationsTest::setExpressionParametersFiltersWithTheNewParametersFromThenOn, ::closingAContentFilteredTopicNeedsItsReadersGoneAndRemovesItFromTheParticipant, ::aTopicDescriptionIsCloseableAndLeavesTheParticipantWhenTheResourceEnds, ::aTopicAndAContentFilteredTopicKnowTheirNameTypeAndParticipant (lookupTopicDescription). (commit 36e8fd3f496) ### §2 DomainParticipant: create_multitopic and delete_multitopic

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 35 (dds-1.2.pdf), table DomainParticipant — “create_multitopic (name: string, type_name: string, subscription_expression: string, expression_parameters: string []): MultiTopic; delete_multitopic (a_multitopic: MultiTopic): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.createMultiTopic), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createMultiTopic), crates/java-omgdds/java/src/main/java/org/zerodds/topic/MultiTopicImpl.java (MultiTopicImpl), crates/java-omgdds/java/src/main/java/org/zerodds/topic/MultiTopicEngine.java (MultiTopicEngine)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::closingAMultiTopicNeedsItsReadersGoneAndFreesTheTopicsOfItsFromClause, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicDescriptionIsCloseableAndLeavesTheParticipantWhenTheResourceEnds, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::deleteContainedEntitiesRemovesEveryTopicDescriptionFromTheLookups, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicTest.java::aReaderOnTheMultiTopicReceivesTheMatchingSamples, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicJoinTest.java::theAnnexBExampleJoinsProjectsRenamesAndFilters

Status: done — MultiTopicImpl.close throws PreconditionNotMetException while a reader reads the MultiTopic, releases the topics of the FROM clause (MultiTopicImpl.bind holds them) and removes the entry from the participant’s list; a closed MultiTopic is AlreadyClosedException for new readers. Tests: TopicOperationsTest::closingAMultiTopicNeedsItsReadersGoneAndFreesTheTopicsOfItsFromClause, ::aTopicDescriptionIsCloseableAndLeavesTheParticipantWhenTheResourceEnds, ::deleteContainedEntitiesRemovesEveryTopicDescriptionFromTheLookups. (commit 36e8fd3f496) ### §2 DomainParticipant: find_topic

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 35–36 (dds-1.2.pdf), table DomainParticipant — “find_topic (topic_name: string, timeout: Duration_t): Topic”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.findTopic), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.findTopic), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.awaitTopic)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::findTopicWaitsForATopicAnotherThreadCreatesAndTimesOutOtherwise, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::findTopicReturnsTheTopicAndTimesOutOtherwise

Status: done — findTopic(String, Duration) and findTopic(String, long, TimeUnit) return a topic the participant created, otherwise wait up to the timeout for one that another thread creates, and throw TimeoutException. DDS 1.4 §2.2.2.2.1.11 leaves it to the implementation to make remotely created topics available; there are none here. Tests: TopicOperationsTest::findTopicWaitsForATopicAnotherThreadCreatesAndTimesOutOtherwise (a second thread creates the topic after 200 ms, findTopic with a 30 s bound returns it; an unknown name ends in the TimeoutException after 300 ms, minimum duration 290 ms), DomainParticipantOperationsTest::findTopicReturnsTheTopicAndTimesOutOtherwise. (commit 819bfcb46cb) ### §2 DomainParticipant: lookup_topicdescription

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “lookup_topicdescription (name: string): TopicDescription”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.lookupTopicDescription), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.lookupTopicDescription), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.allTopicDescriptions)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::lookupTopicDescriptionFindsOnlyWhatWasCreated, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicTest.java::theMultiTopicIsATopicDescriptionOfTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::theParticipantCreatesTheFourBuiltinTopics, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicAndAContentFilteredTopicKnowTheirNameTypeAndParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::closingAContentFilteredTopicNeedsItsReadersGoneAndRemovesItFromTheParticipant

Status: done — lookupTopicDescription searches the topics, ContentFilteredTopics and MultiTopics of the participant; closed descriptions are removed from the lists. Tests: topic with assertSame, name and type name and unknown name null (DomainParticipantOperationsTest), MultiTopic (MultiTopicTest), built-in topics (BuiltinTopicsTest), ContentFilteredTopic and null after close (TopicOperationsTest::aTopicAndAContentFilteredTopicKnowTheirNameTypeAndParticipant, ::closingAContentFilteredTopicNeedsItsReadersGoneAndRemovesItFromTheParticipant). (commit 819bfcb46cb) ### §2 DomainParticipant: get_builtin_subscriber

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “get_builtin_subscriber: Subscriber”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.getBuiltinSubscriber), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.getBuiltinSubscriber), crates/java-omgdds/java/src/main/java/org/zerodds/domain/Builtin.java (Builtin), crates/java-omgdds/java/src/main/java/org/zerodds/internal/Ignores.java (Ignores.pairIgnored)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::theBuiltinSubscriberHoldsOneReaderPerBuiltinTopic, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::aBuiltinReaderHasTheEntitiesThatExistedBeforeAndNoneOfItsOwnParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantIgnoreTest.java::theBuiltinReaderOfAParticipantGivesNoDataAboutItsOwnEntities, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::getBuiltinSubscriberIsTheSameObjectEveryTime, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::theBuiltinReaderOfAParticipantSeesTheEntitiesOfTheDomain

Status: done — getBuiltinSubscriber creates once an enabled subscriber with one DataReader each for DCPSParticipant, DCPSPublication, DCPSSubscription and DCPSTopic (DURABILITY TRANSIENT_LOCAL, RELIABILITY RELIABLE, HISTORY KEEP_LAST 1, DDS 1.4 §2.2.5); lookupDataReader(topic name) finds them. The built-in writers offer TRANSIENT_LOCAL (Builtin.writer), so a reader created later gets the entities already known. The built-in readers give no data about entities of their own participant (Ignores.pairIgnored, §2.2.5) and are not announced on DCPSSubscription themselves. Tests: ParticipantDiscoveryTest::theBuiltinSubscriberHoldsOneReaderPerBuiltinTopic, ::aBuiltinReaderHasTheEntitiesThatExistedBeforeAndNoneOfItsOwnParticipant, ParticipantIgnoreTest::theBuiltinReaderOfAParticipantGivesNoDataAboutItsOwnEntities. (commit cd8f3d67ea9) ### §2 DomainParticipant: ignore_participant

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “ignore_participant (handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.ignoreParticipant), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.ignoreParticipant), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.getDiscoveredParticipants), crates/java-omgdds/java/src/main/java/org/zerodds/internal/Ignores.java (Ignores), crates/java-omgdds/java/src/main/java/org/zerodds/internal/InProcessBus.java (InProcessBus.rematchIgnored), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.ignoreParticipant)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantIgnoreTest.java::ignoreParticipantBeforeTheWriterExistsKeepsItsDataAndItsMatchAway, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantIgnoreTest.java::ignoreParticipantAfterTheMatchEndsItAndStopsTheData, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantIgnoreTest.java::anIgnoredParticipantDoesNotIgnoreTheOtherWay, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantWireDiscoveryTest.java::aParticipantOfAnotherProcessIsDiscoveredAndCanBeIgnored, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterWireIgnoreTest.java::ignoreParticipantEndsTheMatchWithItsReadersAndKeepsItEnded, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::discoveryListsTheParticipantsOfTheDomainAndIgnoreHidesOne

Status: done — ignoreParticipant adds the handle to the ignore sets of the participant (Ignores.of(…).ignoreParticipant) and matches the pairs again (InProcessBus.rematchIgnored): no endpoint of the ignored participant is paired with an endpoint of this participant, existing pairs end, and the data does not arrive. For the RTPS path RtpsParticipant.ignoreParticipant adds the GUID prefix and removes matches; a later SEDP announcement does not pair again. getDiscoveredParticipants leaves the handle out, getDiscoveredParticipantData refuses it with PreconditionNotMetException. Tests: ParticipantIgnoreTest::ignoreParticipantBeforeTheWriterExistsKeepsItsDataAndItsMatchAway, ::ignoreParticipantAfterTheMatchEndsItAndStopsTheData, ::anIgnoredParticipantDoesNotIgnoreTheOtherWay; RTPS: WriterWireIgnoreTest::ignoreParticipantEndsTheMatchWithItsReadersAndKeepsItEnded, ParticipantWireDiscoveryTest::aParticipantOfAnotherProcessIsDiscoveredAndCanBeIgnored. The RTPS participant of a process per domain is shared by all participants of the domain, an ignore there holds for all of them. (commit cd8f3d67ea9) ### §2 DomainParticipant: ignore_topic

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “ignore_topic (handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.ignoreTopic), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.ignoreTopic), crates/java-omgdds/java/src/main/java/org/zerodds/internal/Ignores.java (Ignores.Rules.ignoreTopic), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.ignoreTopic)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantIgnoreTest.java::ignoreTopicSeparatesTheTopicOfTheIgnoredHandleFromTheEndpointsOfTheParticipant, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterWireIgnoreTest.java::ignoreTopicEndsTheMatchWithTheReadersOfTheTopic

Status: done — ignoreTopic resolves the topic handle to a topic name (own topics, topics of other participants of the domain, topics known from SEDP) and adds the name: no publication and no subscription of the topic is paired with an endpoint of this participant, existing pairs end. The topic is missing from getDiscoveredTopics, getDiscoveredTopicData refuses the handle with PreconditionNotMetException. RTPS: RtpsParticipant.ignoreTopic. Tests: ParticipantIgnoreTest::ignoreTopicSeparatesTheTopicOfTheIgnoredHandleFromTheEndpointsOfTheParticipant; RTPS: WriterWireIgnoreTest::ignoreTopicEndsTheMatchWithTheReadersOfTheTopic. A handle that belongs to no known topic at the time of the call is only remembered and does not act on matching. (commit cd8f3d67ea9) ### §2 DomainParticipant: ignore_publication

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “ignore_publication (handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.ignorePublication), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.ignorePublication), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.ignoreEndpoint)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantIgnoreTest.java::ignorePublicationStopsTheDataOfOneWriterOnly, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterWireIgnoreTest.java::ignoreEndpointEndsTheMatchWithOneReader

Status: done — ignorePublication adds the writer handle: no sample of this writer reaches a reader of this participant, and the writer is paired with no reader of this participant (an existing pair ends). RTPS: RtpsParticipant.ignoreEndpoint with the endpoint GUID. Tests: ParticipantIgnoreTest::ignorePublicationStopsTheDataOfOneWriterOnly (a second writer of the same participant keeps delivering); RTPS: WriterWireIgnoreTest::ignoreEndpointEndsTheMatchWithOneReader. (commit cd8f3d67ea9) ### §2 DomainParticipant: ignore_subscription

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “ignore_subscription (handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.ignoreSubscription), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.ignoreSubscription), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.ignoreEndpoint)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantIgnoreTest.java::ignoreSubscriptionStopsTheDataToOneReaderOnly, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterWireIgnoreTest.java::ignoreEndpointEndsTheMatchWithOneReader

Status: done — ignoreSubscription adds the reader handle: no writer of this participant pairs with this reader or sends it data (an existing pair ends, getMatchedSubscriptions and PUBLICATION_MATCHED follow). RTPS: RtpsParticipant.ignoreEndpoint. Tests: ParticipantIgnoreTest::ignoreSubscriptionStopsTheDataToOneReaderOnly (a second reader keeps receiving); RTPS: WriterWireIgnoreTest::ignoreEndpointEndsTheMatchWithOneReader. (commit cd8f3d67ea9) ### §2 DomainParticipant: get_domain_id

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “get_domain_id: DomainId_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::getDomainIdIsTheDomainTheParticipantWasCreatedIn

Status: done — getDomainId() returns the domain the participant was created with (field domainId in DomainParticipantImpl). ParticipantEntityTest::getDomainIdIsTheDomainTheParticipantWasCreatedIn creates participants in the domains 1200 and 1201 and compares. (commit 2e0b194caf5) ### §2 DomainParticipant: delete_contained_entities

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “delete_contained_entities: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.closeContainedEntities), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.closeContainedEntities)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::deleteContainedEntitiesRemovesEveryTopicDescriptionFromTheLookups, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::closingAParticipantWithFilteredTopicsMultiTopicsAndReadersDoesNotFail, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::closeContainedEntitiesClosesThemWithoutClosingTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCascadeTest.java::participantCloseClosesContainedEntities

Status: done — closeContainedEntities closes publishers, subscribers, ContentFilteredTopics, MultiTopics, topics and the built-in subscriber and leaves the participant open; the closed entities leave the participant’s lists through close hooks. Tests: TopicOperationsTest::deleteContainedEntitiesRemovesEveryTopicDescriptionFromTheLookups (lookupTopicDescription returns null afterwards, getDiscoveredTopics empty, containsEntity false), DomainParticipantOperationsTest::closeContainedEntitiesClosesThemWithoutClosingTheParticipant, CloseCascadeTest::participantCloseClosesContainedEntities, TopicOperationsTest::closingAParticipantWithFilteredTopicsMultiTopicsAndReadersDoesNotFail. (commit 36e8fd3f496) ### §2 DomainParticipant: assert_liveliness

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “assert_liveliness: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.assertLiveliness), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.assertLiveliness), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.assertLiveliness), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.assertedByParticipant), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.livelinessAsserted)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::assertLivelinessOfTheParticipantRenewsTheWritersWithManualByParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::aWriteOfOneWriterAssertsTheLivelinessOfTheParticipantsOtherManualWriters

Status: done — DomainParticipantImpl.assertLiveliness renews the lease of the participant’s writers with LIVELINESS MANUAL_BY_PARTICIPANT (DataWriterImpl.assertedByParticipant); a write or assertLiveliness of a writer of this kind renews it for the others (PublisherImpl.writerAsserted, DomainParticipantImpl.livelinessAsserted), writers with MANUAL_BY_TOPIC stay untouched. Tests with a lease of 1500 ms and a duration of 3 s: WriterStatusTest::assertLivelinessOfTheParticipantRenewsTheWritersWithManualByParticipant (the MANUAL_BY_PARTICIPANT writer does not lose the lease, the MANUAL_BY_TOPIC writer does), ::aWriteOfOneWriterAssertsTheLivelinessOfTheParticipantsOtherManualWriters. (commit cd8f3d67ea9) ### §2 DomainParticipant: set_default_publisher_qos and get_default_publisher_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “set_default_publisher_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_publisher_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.setDefaultPublisherQos), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.setDefaultPublisherQos), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createPublisher)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::defaultQosIsTheQosOfWhatIsCreatedNext

Status: done — setDefaultPublisherQos checks consistency (QosRules.checkConsistent, INCONSISTENT_POLICY); the policies of a PublisherQos (GROUP_DATA, PARTITION, PRESENTATION, ENTITY_FACTORY) have no rule against each other in DDS 1.4 §2.2.3. The test sets a PublisherQos with PARTITION “mine”, reads it back and checks that createPublisher().getQos() has it. (commit 2e0b194caf5) ### §2 DomainParticipant: set_default_subscriber_qos and get_default_subscriber_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “set_default_subscriber_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_subscriber_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.setDefaultSubscriberQos), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.setDefaultSubscriberQos), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createSubscriber)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::theDefaultQosOfSubscriberAndTopicIsTheQosOfWhatIsCreatedNext, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::defaultQosIsTheQosOfWhatIsCreatedNext

Status: done — DomainParticipantImpl.createSubscriber() takes defaultSubscriberQos. ParticipantEntityTest::theDefaultQosOfSubscriberAndTopicIsTheQosOfWhatIsCreatedNext sets a SubscriberQos with GROUP_DATA, reads it back and checks that createSubscriber().getQos() equals the set QoS. (commit 2e0b194caf5) ### §2 DomainParticipant: set_default_topic_qos and get_default_topic_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “set_default_topic_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_topic_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.setDefaultTopicQos), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.setDefaultTopicQos), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createTopic), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosRules.java (QosRules.checkConsistent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::theDefaultQosOfSubscriberAndTopicIsTheQosOfWhatIsCreatedNext, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::aDefaultQosWhosePoliciesAreNotConsistentIsRefusedAndKeepsTheOldOne

Status: done — createTopic without QoS takes defaultTopicQos; setDefaultTopicQos checks consistency (HISTORY depth against RESOURCE_LIMITS max_samples_per_instance, max_samples against max_samples_per_instance). ParticipantEntityTest::theDefaultQosOfSubscriberAndTopicIsTheQosOfWhatIsCreatedNext sets a TopicQos with RELIABLE and checks that createTopic(…).getQos() has it and that a QoS passed applies; ::aDefaultQosWhosePoliciesAreNotConsistentIsRefusedAndKeepsTheOldOne checks INCONSISTENT_POLICY for both rules and that the old default stays. (commit 2e0b194caf5) ### §2 DomainParticipant: get_discovered_participants

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36 (dds-1.2.pdf), table DomainParticipant — “get_discovered_participants (inout: participant_handles: InstanceHandle_t []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.getDiscoveredParticipants), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.getDiscoveredParticipants), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl.participantsIn), crates/java-omgdds/java/src/main/java/org/zerodds/domain/Builtin.java (Builtin.attachRemote)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::theDiscoveredParticipantsAreTheOtherParticipantsOfTheDomainAndTheirUserData, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::aClosedParticipantIsNotDiscoveredAnyMore, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantFactoryEnvironmentTest.java::everyEnvironmentHasItsOwnFactoryAndItsOwnParticipantTable, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantWireDiscoveryTest.java::aParticipantOfAnotherProcessIsDiscoveredAndCanBeIgnored, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::discoveryListsTheParticipantsOfTheDomainAndIgnoreHidesOne

Status: done — getDiscoveredParticipants returns the handles of the participants of the domain in this process (of all environments, this one included) and of those reported by SPDP (RtpsParticipant, handle from participantGuid), without the ignored ones; a closed participant is missing. Tests: ParticipantDiscoveryTest::theDiscoveredParticipantsAreTheOtherParticipantsOfTheDomainAndTheirUserData, ::aClosedParticipantIsNotDiscoveredAnyMore, ParticipantFactoryEnvironmentTest::everyEnvironmentHasItsOwnFactoryAndItsOwnParticipantTable (participants of two environments), ParticipantWireDiscoveryTest::aParticipantOfAnotherProcessIsDiscoveredAndCanBeIgnored (SPDP), ParticipantIgnoreTest. (commit cd8f3d67ea9) ### §2 DomainParticipant: get_discovered_participant_data

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 36–37 (dds-1.2.pdf), table DomainParticipant — “get_discovered_participant_data (inout: participant_data: ParticipantBuiltinTopicData, participant_handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.getDiscoveredParticipantData), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.getDiscoveredParticipantData)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::theDiscoveredParticipantsAreTheOtherParticipantsOfTheDomainAndTheirUserData, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantIgnoreTest.java::ignoreParticipantBeforeTheWriterExistsKeepsItsDataAndItsMatchAway, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::getDiscoveredParticipantDataCarriesTheUserData, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantWireDiscoveryTest.java::aParticipantOfAnotherProcessIsDiscoveredAndCanBeIgnored

Status: done — getDiscoveredParticipantData returns key and USER_DATA of a participant of the domain from the process or from SPDP; an ignored handle and an unknown handle are PreconditionNotMetException. Tests: ParticipantDiscoveryTest::theDiscoveredParticipantsAreTheOtherParticipantsOfTheDomainAndTheirUserData (non-empty USER_DATA, participant of another domain), ParticipantIgnoreTest::ignoreParticipantBeforeTheWriterExistsKeepsItsDataAndItsMatchAway (ignored handle), BuiltinTopicsTest::getDiscoveredParticipantDataCarriesTheUserData (nil handle), ParticipantWireDiscoveryTest (key of a remote participant). (commit cd8f3d67ea9) ### §2 DomainParticipant: get_discovered_topics

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 37 (dds-1.2.pdf), table DomainParticipant — “get_discovered_topics (inout: topic_handles: InstanceHandle_t []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.getDiscoveredTopics), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.getDiscoveredTopics)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::theTopicsOfOtherParticipantsOfTheDomainAreDiscovered, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::aTopicOfAnIgnoredParticipantIsNotDiscovered, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantIgnoreTest.java::ignoreTopicSeparatesTheTopicOfTheIgnoredHandleFromTheEndpointsOfTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantWireDiscoveryTest.java::aTopicOfAnotherProcessIsDiscoveredAndATypeThatDiffersIsInconsistent, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::getDiscoveredTopicDataCarriesTheTopicQos

Status: done — getDiscoveredTopics returns the handles of the topics of all participants of the domain in this process and of the topics known from SEDP (handle from name and type name), without built-in topics, ignored topics and topics of ignored participants. Tests: ParticipantDiscoveryTest::theTopicsOfOtherParticipantsOfTheDomainAreDiscovered, ::aTopicOfAnIgnoredParticipantIsNotDiscovered, ParticipantIgnoreTest::ignoreTopicSeparatesTheTopicOfTheIgnoredHandleFromTheEndpointsOfTheParticipant, ParticipantWireDiscoveryTest::aTopicOfAnotherProcessIsDiscoveredAndATypeThatDiffersIsInconsistent, BuiltinTopicsTest::getDiscoveredTopicDataCarriesTheTopicQos. (commit cd8f3d67ea9) ### §2 DomainParticipant: get_discovered_topic_data

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 37 (dds-1.2.pdf), table DomainParticipant — “get_discovered_topic_data (inout: topic_data: TopicBuiltinTopicData, topic_handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.getDiscoveredTopicData), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.getDiscoveredTopicData), crates/java-omgdds/java/src/main/java/org/zerodds/domain/Builtin.java (Builtin.topicDataOf)

Status: done — getDiscoveredTopicData looks the handle up among the topics of all participants of the domain in the process and among the topics known from SEDP; an ignored or unknown handle is PreconditionNotMetException. Tests: ParticipantDiscoveryTest::theTopicsOfOtherParticipantsOfTheDomainAreDiscovered (name, type name, RELIABILITY equal to the topic’s value, exception for a participant handle, disappearing after close), ::aTopicOfAnIgnoredParticipantIsNotDiscovered, ParticipantIgnoreTest (ignored topic), ParticipantWireDiscoveryTest (topic from SEDP), BuiltinTopicsTest::getDiscoveredTopicDataCarriesTheTopicQos. (commit cd8f3d67ea9) ### §2 DomainParticipant: contains_entity

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 37 (dds-1.2.pdf), table DomainParticipant — “contains_entity (a_handle: InstanceHandle_t): boolean”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.containsEntity), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.containsEntity)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::containsEntityWalksTheContainment, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::theBuiltinSubscriberHoldsOneReaderPerBuiltinTopic, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCleanupTest.java::aClosedPublisherAndSubscriberLeaveTheParticipant

Status: done — containsEntity searches publishers, subscribers, their DataWriters and DataReaders, topics, the built-in subscriber and its readers recursively; closed entities are no longer contained. Tests: DomainParticipantOperationsTest::containsEntityWalksTheContainment (handles of publisher, writer, subscriber, reader, topic true, nil handle false), ParticipantDiscoveryTest::theBuiltinSubscriberHoldsOneReaderPerBuiltinTopic (built-in readers), CloseCleanupTest::aClosedPublisherAndSubscriberLeaveTheParticipant (false after close). (commit cd8f3d67ea9) ### §2 DomainParticipant: get_current_time

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.1, p. 37 (dds-1.2.pdf), table DomainParticipant — “get_current_time (inout: current_time: Time_t): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::getCurrentTimeFillsTheContainerOrReturnsANewOne

Status: done — getCurrentTime() returns a new immutable Time, getCurrentTime(ModifiableTime) fills the container and returns it (assertSame); both use System.currentTimeMillis(), the source with which DataWriterImpl stamps samples. The test checks both forms with a value above 0 seconds. (commit 819bfcb46cb) ### §2 DomainParticipantListener

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.2.3, p. 47–48 (dds-1.2.pdf) — “The DomainParticipantListener interface extends all other Listener interfaces and has no additional operation beyond the ones defined by the more general listeners.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantListener.java (DomainParticipantListener), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.setListener)

Status: done — DataWriterImpl and DataReaderImpl pass a status without a listener of their own (or without the status in its mask) on to the publisher or subscriber and then to the DomainParticipant (ListenerUp); the entity’s listener gets it first. TopicImpl passes INCONSISTENT_TOPIC to the DomainParticipant. DomainParticipantListener extends PublisherListener and SubscriberListener and carries onInconsistentTopic. Tests: ListenerPropagationTest::aWriterWithoutListenerPassesTheMatchToThePublisherAndThenTheParticipant, PublisherOperationsTest::aWriterWithoutListenerAndAPublisherWithoutOnePassItToTheParticipantListener, TopicOperationsTest::aTopicWithoutListenerPassesInconsistentTopicToTheParticipantListener, ParticipantEntityTest::createParticipantWithAListenerAndAMaskReachesItFromTheWritersOfTheParticipant. (commit f31b6fa11b5)

§2 Programming interfaces of [DDS] 1.2: topic classes

§2 TopicDescription: get_participant

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.3.1, p. 49–50 (dds-1.2.pdf), table TopicDescription — “get_participant: DomainParticipant”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/topic/ContentFilteredTopicImpl.java (ContentFilteredTopicImpl.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/topic/MultiTopicImpl.java (MultiTopicImpl.getParent)

Status: done — TopicDescription.getParent returns the DomainParticipant: TopicImpl holds it, ContentFilteredTopicImpl asks the related topic, MultiTopicImpl holds it. Tests: TopicOperationsTest::aTopicAndAContentFilteredTopicKnowTheirNameTypeAndParticipant (topic and ContentFilteredTopic, assertSame), MultiTopicTest::theMultiTopicCarriesItsExpression (MultiTopic). (commit 819bfcb46cb) ### §2 TopicDescription: get_type_name

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.3.1, p. 49–50 (dds-1.2.pdf), table TopicDescription — “readonly: type_name string; get_type_name: string”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.getTypeName), crates/java-omgdds/java/src/main/java/org/zerodds/topic/ContentFilteredTopicImpl.java (ContentFilteredTopicImpl.getTypeName), crates/java-omgdds/java/src/main/java/org/zerodds/topic/MultiTopicImpl.java (MultiTopicImpl.getTypeName)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicAndAContentFilteredTopicKnowTheirNameTypeAndParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::lookupTopicDescriptionFindsOnlyWhatWasCreated, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aWriterAndAReaderOnTheTopicOfADynamicTypeMoveDynamicData, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicTest.java::theMultiTopicCarriesItsExpression

Status: done — Topic.getTypeName returns the name of the TypeSupport, ContentFilteredTopicImpl.getTypeName that of the related topic. Tests: TopicOperationsTest::aTopicAndAContentFilteredTopicKnowTheirNameTypeAndParticipant (topic and ContentFilteredTopic equal), DomainParticipantOperationsTest::lookupTopicDescriptionFindsOnlyWhatWasCreated (“java::lang::String”), DynamicTopicTest (DynamicType “DynReading”), MultiTopicTest::theMultiTopicCarriesItsExpression. (commit 819bfcb46cb) ### §2 TopicDescription: get_name

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.3.1, p. 49–50 (dds-1.2.pdf), table TopicDescription — “readonly: name string; get_name: string”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.getName), crates/java-omgdds/java/src/main/java/org/zerodds/topic/ContentFilteredTopicImpl.java (ContentFilteredTopicImpl.getName), crates/java-omgdds/java/src/main/java/org/zerodds/topic/MultiTopicImpl.java (MultiTopicImpl.getName)

Status: done — The three implementations return the name given to createTopic, createContentFilteredTopic and createMultiTopic. The tests expect “Chatter” (Topic), “Hot” (ContentFilteredTopic) and “Hot” (MultiTopic). (commit 9267b77a38a) ### §2 Topic: get_inconsistent_topic_status

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.3.2, p. 50 (dds-1.2.pdf), table Topic — “get_inconsistent_topic_status (out: status: InconsistentTopicStatus): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/Topic.java (Topic.getInconsistentTopicStatus), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.getInconsistentTopicStatus), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.onInconsistentTopic), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.checkTopicConsistency), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.remoteEndpointSeen)

Status: done — DomainParticipantImpl.checkTopicConsistency detects when a topic is created a topic of the same name with another type name at another participant of the domain in the process, DomainParticipantImpl.remoteEndpointSeen at an endpoint from SEDP; both sides call TopicImpl.onInconsistentTopic. getInconsistentTopicStatus returns total_count and total_count_change and resets the change. Tests: TopicOperationsTest::aTopicOfTheSameNameAndAnotherTypeInTheDomainIsInconsistentAndTellsTheTopicListener (total_count 1 on both topics, change reset), ::topicsOfTheSameTypeOrInAnotherDomainAreConsistent (no count for the same type, another domain, another name), ParticipantWireDiscoveryTest::aTopicOfAnotherProcessIsDiscoveredAndATypeThatDiffersIsInconsistent (SEDP). (commit cd8f3d67ea9) ### §2 ContentFilteredTopic: filter_expression

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.3.3, p. 51–52 (dds-1.2.pdf), table ContentFilteredTopic — “readonly: filter_expression string”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/topic/ContentFilteredTopicImpl.java (ContentFilteredTopicImpl.getFilterExpression), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createContentFilteredTopic)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theContentFilteredTopicOfTheParticipantFiltersTheSamples

Status: done — createContentFilteredTopic compiles the same expression with ContentFilter.compile into the predicate and returns it from getFilterExpression. The test expects “value > 50” and checks that a reader on the ContentFilteredTopic receives only the sample with value 99.0. The public constructor of ContentFilteredTopicImpl takes the text and the predicate separately (QosLifecycleTest::contentFilteredTopicDropsNonMatching); the agreement holds for the path through the participant. (commit 2e0b194caf5) ### §2 ContentFilteredTopic: get_related_topic

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.3.3, p. 51 (dds-1.2.pdf), table ContentFilteredTopic — “get_related_topic: Topic”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/topic/ContentFilteredTopicImpl.java (ContentFilteredTopicImpl.getRelatedTopic), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.createDataReader)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theContentFilteredTopicOfTheParticipantFiltersTheSamples, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::contentFilteredTopicDropsNonMatching

Status: done — getRelatedTopic returns the topic given to createContentFilteredTopic; SubscriberImpl.createDataReader subscribes through that topic. The first test expects assertEquals(topic, hot.getRelatedTopic()) and that the reader receives only the matching sample from a writer on the related topic; the second checks that non-matching samples are dropped. (commit 2e0b194caf5) ### §2 ContentFilteredTopic: get_expression_parameters and set_expression_parameters

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.3.3, p. 51–52 (dds-1.2.pdf), table ContentFilteredTopic — “get_expression_parameters (out: expression_parameters: string []): ReturnCode_t; set_expression_parameters (expression_parameters: string []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/ContentFilteredTopic.java (ContentFilteredTopic.getExpressionParameters), crates/java-omgdds/java/src/main/java/org/zerodds/topic/ContentFilteredTopicImpl.java (ContentFilteredTopicImpl.setExpressionParameters), crates/java-omgdds/java/src/main/java/org/zerodds/topic/ContentFilteredTopicImpl.java (ContentFilteredTopicImpl.evaluate)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::setExpressionParametersFiltersWithTheNewParametersFromThenOn

Status: done — ContentFilteredTopicImpl.setExpressionParameters compiles the predicate again with ContentFilter.compile(filterExpression, new parameters); evaluate, and with it the readers on the ContentFilteredTopic, use it from the next sample. getExpressionParameters returns the list. Test: TopicOperationsTest::setExpressionParametersFiltersWithTheNewParametersFromThenOn (expression “level > %0”, parameter 10 then 3, expected samples 15 and 5 respectively; an empty parameter set is refused and the old one stays). (commit 36e8fd3f496) ### §2 MultiTopic: subscription_expression and parameters

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.3.4, p. 52–53 (dds-1.2.pdf), table MultiTopic — “readonly: subscription_expression string; get_expression_parameters (out: expression_parameters: string []): ReturnCode_t; set_expression_parameters (expression_parameters: string []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/topic/MultiTopicImpl.java (MultiTopicImpl.getSubscriptionExpression), crates/java-omgdds/java/src/main/java/org/zerodds/topic/MultiTopicImpl.java (MultiTopicImpl.getExpressionParameters), crates/java-omgdds/java/src/main/java/org/zerodds/topic/MultiTopicImpl.java (MultiTopicImpl.setExpressionParameters)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicTest.java::theMultiTopicCarriesItsExpression, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicTest.java::theExpressionParametersAreReplaced, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicJoinTest.java::theWhereClauseUsesTheExpressionParameters

Status: done — MultiTopic exists now (org.omg.dds.topic.MultiTopic, MultiTopicImpl, DomainParticipant.createMultiTopic). The tests check the expression, the parameter list before and after setExpressionParameters, and that a new parameter (“1000” to “2000”) changes the WHERE clause of a reader. (commit fd437c122cf) ### §2 TopicListener: on_inconsistent_topic

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.3.5, p. 53 (dds-1.2.pdf), table TopicListener — “on_inconsistent_topic (the_topic: Topic, status: InconsistentTopicStatus): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicListener.java (TopicListener.onInconsistentTopic), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicAdapter.java (TopicAdapter), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.onInconsistentTopic)

Status: done — TopicImpl.onInconsistentTopic counts, triggers the status and calls the TopicListener with an InconsistentTopicEventImpl outside the topic’s lock: the own listener if it has the status in its mask, else the DomainParticipantListener (ListenerUp.forTopic). Tests: TopicOperationsTest::aTopicOfTheSameNameAndAnotherTypeInTheDomainIsInconsistentAndTellsTheTopicListener (TopicAdapter, source and status of the event), ::aTopicWithoutListenerPassesInconsistentTopicToTheParticipantListener. (commit cd8f3d67ea9) ### §2 TypeSupport: register_type and get_type_name

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.3.6, p. 53–54 (dds-1.2.pdf), table TypeSupport — “register_type (participant: DomainParticipant, type_name: string): ReturnCode_t; get_type_name: string”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/TypeSupport.java (TypeSupport.newTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.newTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeSupportImpl.java (TypeSupportImpl.getTypeName), crates/java-omgdds/java/src/main/java/org/zerodds/internal/RegisteredNameTypeSupport.java (RegisteredNameTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.ZeroSPI.newTypeSupport)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTypeSupportRegisteredUnderANameGivesTheTopicItsWritersAndItsAnnouncementThatName, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass

Status: done — ServiceEnvironmentImpl.ZeroSPI.newTypeSupport creates the codec under the registered name (RegisteredNameTypeSupport.named); Topic.getTypeName, writer, reader, InProcessBus and SEDP thus use one name. Tests: TopicOperationsTest::aTypeSupportRegisteredUnderANameGivesTheTopicItsWritersAndItsAnnouncementThatName (writer and reader of two participants pair under “my::Named” and exchange a sample, the DCPSPublication data carry “my::Named”, a topic of the same name made from the class has “java::lang::String” and does not pair), ::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass. (commit 36e8fd3f496)

§2 Programming interfaces of [DDS] 1.2: Publisher

§2 Publisher: create_datawriter and delete_datawriter

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.1, p. 57 (dds-1.2.pdf), table Publisher — “create_datawriter (a_topic: Topic, qos: QosPolicy [], a_listener: DataWriterListener, mask: StatusKind []): DataWriter; delete_datawriter (a_datawriter: DataWriter): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerPropagationTest.java::aWriterListenerSetAtCreationSeesTheMatchOfEnable, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aDefaultWriterQosThatIsNotConsistentIsRefusedAndTheOldOneStays, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::closeContainedEntitiesClosesTheWritersAndWithdrawsThemFromTheBuiltinTopic, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCleanupTest.java::aClosedWriterAndReaderAreNotListedOrFoundAnyMore, crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::theMatchedEntitiesAreDescribedWithTheirQos, crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aClosedEntityRefusesToCreateContainedEntities

Status: done — createDataWriter has the forms topic, topic with DataWriterQos and topic with DataWriterQos, DataWriterListener and status set; the listener is set before enable, so an existing reader is reported as onPublicationMatched. DataWriterImpl.close removes the writer from PublisherImpl.writers and from DCPSPublication (close hook). createDataWriter refuses an inconsistent DataWriterQos with InconsistentPolicyException. Tests: ListenerPropagationTest::aWriterListenerSetAtCreationSeesTheMatchOfEnable, PublisherOperationsTest::aDefaultWriterQosThatIsNotConsistentIsRefusedAndTheOldOneStays, ::closeContainedEntitiesClosesTheWritersAndWithdrawsThemFromTheBuiltinTopic, CloseCleanupTest::aClosedWriterAndReaderAreNotListedOrFoundAnyMore, PubSubLoopbackTest::singleWriterSingleReaderRoundTrip, BuiltinTopicQosTest::theMatchedEntitiesAreDescribedWithTheirQos. (commit f31b6fa11b5) ### §2 Publisher: lookup_datawriter

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.1, p. 57 (dds-1.2.pdf), table Publisher — “lookup_datawriter (topic_name: string): DataWriter”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher.lookupDataWriter), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.lookupDataWriter)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::lookupDataWriterFindsByNameAndByTopicAndForgetsClosedWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCleanupTest.java::aClosedWriterAndReaderAreNotListedOrFoundAnyMore

Status: done — PublisherImpl.lookupDataWriter(String) and (Topic) search the list of created writers for the topic name and return null if none matches; a closed writer is removed from the list (close hook). Test: PublisherOperationsTest::lookupDataWriterFindsByNameAndByTopicAndForgetsClosedWriters (found by name and by topic, null for an unknown name and another topic, null after close); CloseCleanupTest::aClosedWriterAndReaderAreNotListedOrFoundAnyMore. (commit 28e25c198d1) ### §2 Publisher: suspend_publications and resume_publications

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.1, p. 57 (dds-1.2.pdf), table Publisher — “suspend_publications: ReturnCode_t; resume_publications: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher.suspendPublications), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.suspendPublications), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.resumePublications)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::resumePublicationsNeedsASuspendPublicationsAndTheCallsNest, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::writesWhileSuspendedAreDeliveredAsBefore

Status: done — PublisherImpl.suspendPublications counts (the calls nest), resumePublications without a matching suspendPublications throws PreconditionNotMetException (DDS 1.4 §2.2.2.4.1.9, PSM Table 7.1); suspend is a hint, the writers deliver unchanged. Tests: PublisherOperationsTest::resumePublicationsNeedsASuspendPublicationsAndTheCallsNest (pair, nesting, exception, AlreadyClosedException after close), ::writesWhileSuspendedAreDeliveredAsBefore. (commit cd8f3d67ea9) ### §2 Publisher: begin_coherent_changes and end_coherent_changes

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.1, p. 57 (dds-1.2.pdf), table Publisher — “begin_coherent_changes: ReturnCode_t; end_coherent_changes: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher.beginCoherentChanges), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.beginCoherentChanges), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.endCoherentChanges), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.deferCoherent), crates/java-omgdds/java/src/main/java/org/zerodds/internal/InProcessBus.java (InProcessBus.atomically), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/CoherentHold.java (CoherentHold), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/CoherentSetParameter.java (CoherentSetParameter), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.WireWriter.endCoherentSet)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::endCoherentChangesNeedsABeginAndTheCallsNest, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aCoherentSetIsDeliveredTogetherWhenThePresentationAsksForCoherentAccess, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::withoutCoherentAccessTheSamplesOfASetAreDeliveredAtOnce, crates/java-omgdds/java/src/test/java/org/omg/dds/CoherentSetAtomicityTest.java::aReaderOnAnotherThreadNeverSeesPartOfASet, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/CoherentSetWireTest.java::theParameterValueIsASequenceNumberInTheByteOrderOfTheSubmessage, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/CoherentSetWireTest.java::theEndOfASetIsADataWithoutSerializedDataAndWithoutInlineQos, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/CoherentSetWireTest.java::theSamplesOfASetAreHeldAndReleasedByTheFirstSampleOutsideIt, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/CoherentSetWireTest.java::aSetWithAMissingSampleIsNotReleasedAndSaysSo, crates/java-omgdds/java/src/test/java/org/omg/dds/WireEntityBehaviourTest.java::aCoherentSetOfARemoteWriterReachesACoherentAccessReaderAsAWhole

Status: done — beginCoherentChanges/endCoherentChanges nest (PublisherImpl.coherentDepth), endCoherentChanges without begin throws PreconditionNotMetException. When the PRESENTATION of the publisher has coherent_access, the publisher holds back the deliveries of its writers (PublisherImpl.deferCoherent) and delivers them at the last end in write order as one step (InProcessBus.atomically): every read and take of a reader holds the other side of the same gate, so a reader on another thread sees all samples of a set or none (CoherentSetAtomicityTest; without the gate it fails). Over RTPS the samples of a set carry PID_COHERENT_SET (0x0056) with the sequence number of the first sample of the writer in the set (DDSI-RTPS 2.5 §8.7.6, §9.6.4.2; octets against coherent_set_bytes of the Rust implementation), the end is a DATA without data and without inline QoS (Table 9.22, Example 3). A reader of a subscriber with coherent_access holds the samples of a remote set until it is complete (CoherentHold) and passes them on together; an incomplete set (a sample is missing) is not delivered and is named in the log (§8.7.6). Expected towards Cyclone DDS, Fast DDS and OpenDDS: they read PID 0x0056 and act per §8.7.6; a DATA without data at the end of a set is provided by Table 9.22. Measured is only the ZeroDDS peer. The group set (access_scope GROUP, PID_GROUP_COHERENT_SET, end-coherent-set DATA of all writers of the publisher) is not built; it is in the open item on PRESENTATION. (commit 178c642cbc7) ### §2 Publisher: wait_for_acknowledgments

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.1, p. 57 (dds-1.2.pdf), table Publisher — “wait_for_acknowledgments (max_wait: Duration_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher.waitForAcknowledgments), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.waitForAcknowledgments), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/ReliableWriterState.java (ReliableWriterState.awaitAcknowledged), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.WireWriter.waitForAcknowledgments), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.awaitAcknowledgments)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::waitForAcknowledgmentsReturnsAtOnceForReadersOfTheProcess, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterWireAckTest.java::aSampleTheRemoteReaderAcknowledgedEndsTheWait, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterWireAckTest.java::aSampleNobodyAcknowledgesIsATimeoutException, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterAckStateTest.java::aSampleNobodyAcknowledgedTimesOutAfterTheWait, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterAckStateTest.java::anAckNackThatReachesThePastTheSampleAcknowledgesIt, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterAckStateTest.java::aWaiterIsReleasedByTheAckNackOfAnotherThread, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterAckStateTest.java::everyReaderThatReceivedTheSampleHasToAcknowledgeIt, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterAckStateTest.java::aReaderThatLeavesIsNotWaitedFor

Status: done — PublisherImpl.waitForAcknowledgments waits in turn for the publisher’s enabled writers with a common deadline; DataWriterImpl.awaitAcknowledgments, for a writer with an RTPS connection, waits through RtpsParticipant.WireWriter.waitForAcknowledgments on ReliableWriterState.awaitAcknowledged (the history is empty when every reader has acknowledged by ACKNACK) and throws TimeoutException when the deadline passes. Readers in the same process have the sample when write returns (synchronous delivery). A negative maxWait is IllegalArgumentException, a closed publisher AlreadyClosedException. Tests: PublisherOperationsTest::waitForAcknowledgmentsReturnsAtOnceForReadersOfTheProcess, WriterWireAckTest::aSampleTheRemoteReaderAcknowledgedEndsTheWait and ::aSampleNobodyAcknowledgesIsATimeoutException (publisher and writer form), WriterAckStateTest. (commit cd8f3d67ea9) ### §2 Publisher: get_participant

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.1, p. 57 (dds-1.2.pdf), table Publisher — “get_participant: DomainParticipant”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.getParent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic

Status: done — PublisherImpl.getParent returns the DomainParticipant that DomainParticipantImpl.createPublisher passes at creation; DataWriterImpl.getParent the publisher. Test: PublisherOperationsTest::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic (assertSame). (commit 2e0b194caf5) ### §2 Publisher: delete_contained_entities

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.1, p. 57 (dds-1.2.pdf), table Publisher — “delete_contained_entities: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher.closeContainedEntities), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.closeContainedEntities)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::closeContainedEntitiesClosesTheWritersAndWithdrawsThemFromTheBuiltinTopic, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCleanupTest.java::closeContainedEntitiesEmptiesPublisherAndSubscriber

Status: done — PublisherImpl.closeContainedEntities closes every writer; its close hook removes it from PublisherImpl.writers and withdraws it from DCPSPublication. The publisher stays open and accepts new writers. Tests: PublisherOperationsTest::closeContainedEntitiesClosesTheWritersAndWithdrawsThemFromTheBuiltinTopic (writer closed, lookupDataWriter null, getDataWriters empty, containsEntity false, the built-in reader of another participant sees NOT_ALIVE_NO_WRITERS), CloseCleanupTest::closeContainedEntitiesEmptiesPublisherAndSubscriber. (commit 28e25c198d1) ### §2 Publisher: set_default_datawriter_qos and get_default_datawriter_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.1, p. 57–58 (dds-1.2.pdf), table Publisher — “set_default_datawriter_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_datawriter_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher.setDefaultDataWriterQos), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.getDefaultDataWriterQos), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.setDefaultDataWriterQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosRules.java (QosRules.checkConsistent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::theDefaultWriterQosIsTheQosOfTheWritersCreatedNext, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aDefaultWriterQosThatIsNotConsistentIsRefusedAndTheOldOneStays

Status: done — PublisherImpl.setDefaultDataWriterQos checks consistency (QosRules.checkConsistent) and throws InconsistentPolicyException without changing the default; createDataWriter(Topic) uses the default set, a QoS passed to the call takes precedence, and createDataWriter checks the QoS as well. Tests: PublisherOperationsTest::theDefaultWriterQosIsTheQosOfTheWritersCreatedNext, ::aDefaultWriterQosThatIsNotConsistentIsRefusedAndTheOldOneStays. (commit cd8f3d67ea9) ### §2 Publisher: copy_from_topic_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.1, p. 58 (dds-1.2.pdf), table Publisher — “copy_from_topic_qos (inout: a_datawriter_qos: QosPolicy [], a_topic_qos: QosPolicy []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher.copyFromTopicQos), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.copyFromTopicQos)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::copyFromTopicQosLetsThePoliciesOfTheTopicReplaceThoseOfTheWriter

Status: done — PublisherImpl.copyFromTopicQos takes every policy of the TopicQos that a DataWriter knows into the DataWriterQos and replaces the value of the writer QoS (DDS 1.4 §2.2.2.4.1.17); policies the TopicQos does not have (USER_DATA, OWNERSHIP_STRENGTH) stay those of the writer QoS, the QoS passed is unchanged, and the result is not checked for consistency. Test: PublisherOperationsTest::copyFromTopicQosLetsThePoliciesOfTheTopicReplaceThoseOfTheWriter (DEADLINE 5 s and BEST_EFFORT of the writer become DEADLINE 7 s and RELIABLE of the topic, with a topic holding default values infinite and BEST_EFFORT). (commit cd8f3d67ea9) ### §2 PublisherListener

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.3, p. 71–72 (dds-1.2.pdf) — “PublisherListener: no attributes, no operations (inherits the operations of DataWriterListener)”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aWriterWithoutListenerPassesOfferedIncompatibleQosToThePublisher, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aWriterThatAWriterListenerTakesIsNotPassedUp, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerPropagationTest.java::aWriterWithoutListenerPassesTheMatchToThePublisherAndThenTheParticipant

Status: done — DataWriterImpl.listenerFor passes a status the writer’s listener does not take to the PublisherListener of the PublisherImpl (ListenerUp.forWriter) and then to the one of the DomainParticipant. Tests: PublisherOperationsTest::aWriterWithoutListenerPassesOfferedIncompatibleQosToThePublisher (source of the event the writer, status with total_count 1 and policy Reliability), ::aWriterThatAWriterListenerTakesIsNotPassedUp, ListenerPropagationTest::aWriterWithoutListenerPassesTheMatchToThePublisherAndThenTheParticipant. (commit f31b6fa11b5)

§2 Programming interfaces of [DDS] 1.2: DataWriter

§2 DataWriter: register_instance and register_instance_w_timestamp

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 62 (dds-1.2.pdf), table DataWriter — “register_instance (instance: Data): InstanceHandle_t; register_instance_w_timestamp (instance: Data, timestamp: Time_t): InstanceHandle_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::registerInstanceTakesATimestampAndLookupInstanceFindsTheInstanceByItsKey, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::registerAndLookupInstance

Status: done — registerInstance(T) returns a handle formed by InstanceKey.toHandle; the forms with Time and with long and TimeUnit use the timestamp for the liveliness time (DataWriterImpl.registerInstanceAt). Registering sends nothing to the readers (DDS 1.4 §2.2.2.4.2.5 does not require it). Tests: WriterHandleTest::registerInstanceTakesATimestampAndLookupInstanceFindsTheInstanceByItsKey (all three forms, the same handle when registering again), QosLifecycleTest::registerAndLookupInstance. (commit 56f40fabd6c) ### §2 DataWriter: unregister_instance and unregister_instance_w_timestamp

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 62 (dds-1.2.pdf), table DataWriter — “unregister_instance (instance: Data, handle: InstanceHandle_t): ReturnCode_t; unregister_instance_w_timestamp (instance: Data, handle: InstanceHandle_t, timestamp: Time_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.unregisterInstance), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.unregisterInstance), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.unregisterAtHandle), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.onMessage)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::unregisterByHandleOrBySampleMakesTheReaderSeeNoWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/InstanceHandleTest.java::aWriterDisposesAndUnregistersTheInstancesItRegistered, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::unregisterMarksInstanceNotAliveNoWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::closingOneWriterDoesNotMarkNoWritersWhileAnotherWrites

Status: done — unregisterInstance(InstanceHandle, …) resolves the instance through DataWriterImpl.resolve from the handle or, for HANDLE_NIL, from the sample and uses the key of the registration, which the reader looks up. A handle of an instance other than the sample’s is PreconditionNotMetException, a handle of no instance of the writer (also one already unregistered) IllegalArgumentException (BAD_PARAMETER). Tests: WriterHandleTest::unregisterByHandleOrBySampleMakesTheReaderSeeNoWriters (reader sees NOT_ALIVE_NO_WRITERS for both instances), InstanceHandleTest::aWriterDisposesAndUnregistersTheInstancesItRegistered, QosLifecycleTest::unregisterMarksInstanceNotAliveNoWriters, ::closingOneWriterDoesNotMarkNoWritersWhileAnotherWrites. (commit d70d1f69c5d) ### §2 DataWriter: get_key_value

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 62 (dds-1.2.pdf), table DataWriter — “get_key_value (inout: key_holder: Data, handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.getKeyValue), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getKeyValue)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/InstanceHandleTest.java::getKeyValueReturnsTheInstanceOfTheHandle, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::getKeyValueRefusesAnUnkeyedTypeAndAnUnknownHandle

Status: done — getKeyValue(T, InstanceHandle) and getKeyValue(InstanceHandle) return a copy of the last sample written for the instance, so the key fields are set; a type without a key is PreconditionNotMetException, a handle of no instance of the writer IllegalArgumentException. Tests: InstanceHandleTest::getKeyValueReturnsTheInstanceOfTheHandle (key 2 for the registered handle, lookupInstance returns the handle), WriterHandleTest::getKeyValueRefusesAnUnkeyedTypeAndAnUnknownHandle. (commit 56f40fabd6c) ### §2 DataWriter: lookup_instance

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 62 (dds-1.2.pdf), table DataWriter — “lookup_instance (instance: Data): InstanceHandle_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.lookupInstance), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.lookupInstance)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::registerAndLookupInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::registerInstanceTakesATimestampAndLookupInstanceFindsTheInstanceByItsKey

Status: done — lookupInstance(T) returns the handle of the registered or written instance and InstanceHandle.NIL for an unknown one; the form with ModifiableInstanceHandle fills and returns the handle passed. Tests: QosLifecycleTest::registerAndLookupInstance, WriterHandleTest::registerInstanceTakesATimestampAndLookupInstanceFindsTheInstanceByItsKey (the key names the instance, form with ModifiableInstanceHandle, unknown key returns the nil handle). (commit 56f40fabd6c) ### §2 DataWriter: write and write_w_timestamp

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 62 (dds-1.2.pdf), table DataWriter — “write (data: Data, handle: InstanceHandle_t): ReturnCode_t; write_w_timestamp (data: Data, handle: InstanceHandle_t, source_timestamp: Time_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.write), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.write), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.writeAt)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::everyWriteOverloadCarriesItsSourceTimestampToTheSample, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::anUnkeyedTypeIsWrittenWithTheNilHandle, crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::largeByteArrayGrowsEncoderBuffer, crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::writeOnAClosedWriterThrowsAlreadyClosed, crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aNotEnabledWriterRefusesToWrite

Status: done — DataWriter has six write overloads (without, with Time, with long and TimeUnit, each with and without InstanceHandle); the timestamp is the source timestamp of the sample at the reader. Tests: WriterHandleTest::everyWriteOverloadCarriesItsSourceTimestampToTheSample (five forms, timestamp and instance handle on the sample), ::anUnkeyedTypeIsWrittenWithTheNilHandle, PubSubLoopbackTest::singleWriterSingleReaderRoundTrip, QuickstartApiTest::largeByteArrayGrowsEncoderBuffer, ExceptionMappingTest::writeOnAClosedWriterThrowsAlreadyClosed, ::aNotEnabledWriterRefusesToWrite. (commit 56f40fabd6c) ### §2 DataWriter: write with handle HANDLE_NIL

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2.11, p. 67 (dds-1.2.pdf) — “The special value HANDLE_NIL can be used for the parameter handle. This indicates that the identity of the instance should be automatically deduced from the instance_data (by means of the key).”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/InstanceHandleTest.java::aHandleGivenWithAWriteIsTheHandleOfTheSamplesInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::anUnkeyedTypeIsWrittenWithTheNilHandle

Status: done — write(T, InstanceHandle, …) checks the handle (DataWriterImpl.checkHandle): HANDLE_NIL is allowed, the handle of the sample’s instance too, the handle of another instance of the writer is PreconditionNotMetException, a handle of no instance of the writer IllegalArgumentException (BAD_PARAMETER, §2.2.2.4.2.11). Tests: InstanceHandleTest::aHandleGivenWithAWriteIsTheHandleOfTheSamplesInstance (HANDLE_NIL not checked, registered handle yes, another registered handle PreconditionNotMetException), WriterHandleTest::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed (unknown handle IllegalArgumentException for write and dispose). (commit d70d1f69c5d) ### §2 DataWriter: dispose and dispose_w_timestamp

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 63 (dds-1.2.pdf), table DataWriter — “dispose (data: Data, handle: InstanceHandle_t): ReturnCode_t; dispose_w_timestamp (data: Data, handle: InstanceHandle_t, timestamp: Time_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.dispose), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.dispose), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.disposeAtHandle)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed, crates/java-omgdds/java/src/test/java/org/omg/dds/InstanceHandleTest.java::aWriterDisposesAndUnregistersTheInstancesItRegistered, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::disposeMarksInstanceNotAliveDisposed, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::disposedThenWrittenIsRebornAlive

Status: done — dispose(InstanceHandle, …) and dispose(T, …) set the instance at the reader to NOT_ALIVE_DISPOSED; the handle forms resolve through DataWriterImpl.resolve (handle of the registration or HANDLE_NIL with a sample) and hit the instance the reader finds by the key. Tests: WriterHandleTest::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed (forms with Time and with long and TimeUnit), InstanceHandleTest::aWriterDisposesAndUnregistersTheInstancesItRegistered, QosLifecycleTest::disposeMarksInstanceNotAliveDisposed, ::disposedThenWrittenIsRebornAlive. (commit d70d1f69c5d) ### §2 DataWriter: dispose with handle

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2.13, p. 69 (dds-1.2.pdf) — “The constraints on the values of the handle parameter and the corresponding error behavior are the same specified for the unregister_instance operation (Section 7.1.2.4.2.7).”

Status: done — dispose(InstanceHandle, T, …) reports PreconditionNotMetException for the handle of an instance other than the sample’s and IllegalArgumentException (BAD_PARAMETER) for a handle the writer does not know (DataWriterImpl.resolve); dispose(InstanceHandle, T) uses the handle. Tests: WriterHandleTest::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed, InstanceHandleTest::aWriterDisposesAndUnregistersTheInstancesItRegistered (neither handle nor sample: IllegalArgumentException). (commit d70d1f69c5d) ### §2 DataWriter: wait_for_acknowledgments

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 63 (dds-1.2.pdf), table DataWriter — “wait_for_acknowledgments (max_wait: Duration_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.waitForAcknowledgments), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.waitForAcknowledgments)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterWaitAckTest.java::aWriterWhoseReadersAreInTheProcessIsAcknowledgedWhenWriteReturns, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterWaitAckTest.java::aWriterWithoutReadersHasNothingOutstanding, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterWaitAckTest.java::anArgumentThatIsNotADurationIsRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterWaitAckTest.java::aClosedWriterAndAWriterThatIsNotEnabledRefuseTheWait, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterWireAckTest.java::aSampleTheRemoteReaderAcknowledgedEndsTheWait, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterWireAckTest.java::aSampleNobodyAcknowledgesIsATimeoutException, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterAckStateTest.java::aSampleNobodyAcknowledgedTimesOutAfterTheWait, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterAckStateTest.java::anAckNackThatReachesThePastTheSampleAcknowledgesIt, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterAckStateTest.java::aWaiterIsReleasedByTheAckNackOfAnotherThread, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterAckStateTest.java::everyReaderThatReceivedTheSampleHasToAcknowledgeIt, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/WriterAckStateTest.java::aReaderThatLeavesIsNotWaitedFor

Status: done — DataWriterImpl.waitForAcknowledgments(Duration) and (long, TimeUnit) call awaitAcknowledgments: for readers in the same process the call returns at once, for readers over RTPS it waits for the acknowledgments in ReliableWriterState and throws TimeoutException when maxWait passes; null and a negative wait are IllegalArgumentException, a closed writer AlreadyClosedException, a writer that is not enabled NotEnabledException. Tests: WriterWaitAckTest (four cases), WriterWireAckTest (acknowledgment and timeout over RTPS), WriterAckStateTest (history, ACKNACK, loss of a peer). (commit cd8f3d67ea9) ### §2 DataWriter: get_liveliness_lost_status

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 63 (dds-1.2.pdf), table DataWriter — “get_liveliness_lost_status (out: status: LivelinessLostStatus): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.getLivelinessLostStatus), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getLivelinessLostStatus), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.evaluateLiveliness)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::aWriterThatDoesNotAssertItsLivelinessLosesItOnceAndAssertingRestoresIt, crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::livelinessLostFiresWithoutPolling

Status: done — The lease is monitored (LeaseMonitor, DataWriterImpl.evaluateLiveliness): a writer with MANUAL_BY_TOPIC and a finite lease that does not renew it counts LIVELINESS_LOST once and is not alive afterwards; assertLiveliness makes it alive again. getLivelinessLostStatus returns total_count and total_count_change; the change is reset when the listener is called or when the status is read. Tests: WriterStatusTest::aWriterThatDoesNotAssertItsLivelinessLosesItOnceAndAssertingRestoresIt (listener call, status read, no further count while not alive, a new loss after assertLiveliness), LeaseTest::livelinessLostFiresWithoutPolling. (commit d23eff980f3) ### §2 DataWriter: get_offered_deadline_missed_status

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 63 (dds-1.2.pdf), table DataWriter — “get_offered_deadline_missed_status (out: status: OfferedDeadlineMissedStatus): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.getOfferedDeadlineMissedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getOfferedDeadlineMissedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.evaluateOfferedDeadline)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::aMissedOfferedDeadlineIsCountedWithTheInstanceThatMissedIt, crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::offeredDeadlineMissedFiresWithoutPolling

Status: done — The writer checks DEADLINE per instance (evaluateOfferedDeadline, lease timer); getOfferedDeadlineMissedStatus returns total_count, total_count_change and last_instance_handle. Test: WriterStatusTest::aMissedOfferedDeadlineIsCountedWithTheInstanceThatMissedIt (deadline 30 ms, one write; total_count >= 1, on the first query total_count_change = total_count, last_instance_handle = lookupInstance, on the second query the change = the difference), LeaseTest::offeredDeadlineMissedFiresWithoutPolling. (commit d23eff980f3) ### §2 DataWriter: get_offered_incompatible_qos_status

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 63 (dds-1.2.pdf), table DataWriter — “get_offered_incompatible_qos_status (out: status: OfferedIncompatibleQosStatus): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.getOfferedIncompatibleQosStatus), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getOfferedIncompatibleQosStatus), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.onReaderPresenceChanged)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::anIncompatibleReaderIsCountedWithTheRefusedPolicy, crates/java-omgdds/java/src/test/java/org/omg/dds/QosCompatibilityTest.java::incompatibleReliabilityDoesNotConnect

Status: done — DataWriterImpl.onReaderPresenceChanged compares the QoS requested by the reader with the one offered (QosCompatibility), does not pair on incompatibility and counts OFFERED_INCOMPATIBLE_QOS with the first refusing policy and a count per policy. Tests: WriterStatusTest::anIncompatibleReaderIsCountedWithTheRefusedPolicy (total_count 1, last_policy_class Reliability, exactly one QosPolicyCount for Reliability with count 1, no match, listener status), QosCompatibilityTest::incompatibleReliabilityDoesNotConnect. (commit d23eff980f3) ### §2 DataWriter: get_publication_matched_status

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 63 (dds-1.2.pdf), table DataWriter — “get_publication_matched_status (out: status: PublicationMatchedStatus): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.getPublicationMatchedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getPublicationMatchedStatus)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::thePublicationMatchedStatusCountsAndNamesTheLastSubscription, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::statusIsReadableWithoutAListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::writerListenerFiresOnPublicationMatched

Status: done — DataWriterImpl keeps total_count, current_count and their change values; the change values are reset when read or when the listener is called. Test: WriterStatusTest::thePublicationMatchedStatusCountsAndNamesTheLastSubscription (first reader: 1/1/1/1; reading again: changes 0; second reader came and went: total_count 2, change 1, current_count 1, change 0; last reader gone: current_count 0, change -1, total_count_change 0), ListenerTest::statusIsReadableWithoutAListener, ::writerListenerFiresOnPublicationMatched. (commit cd8f3d67ea9) ### §2 DataWriter: last_subscription_handle of PUBLICATION_MATCHED

Spec: §2, p. 11; [DDS] 1.2 IDL, p. 160 (dds-1.2.pdf) — “struct PublicationMatchedStatus { […] InstanceHandle_t last_subscription_handle; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/PublicationMatchedStatus.java (PublicationMatchedStatus.getLastSubscriptionHandle), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.readPublicationMatchedStatusLocked)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::thePublicationMatchedStatusCountsAndNamesTheLastSubscription

Status: done — DataWriterImpl.onReaderPresenceChanged remembers the handle of the reader that last changed the status (match or loss), and readPublicationMatchedStatusLocked puts it in as last_subscription_handle. Test: WriterStatusTest::thePublicationMatchedStatusCountsAndNamesTheLastSubscription (the handle is the reader’s getInstanceHandle and an element of getMatchedSubscriptions; after the loss it stays that of the reader that left). (commit cd8f3d67ea9) ### §2 DataWriter: get_topic

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 63 (dds-1.2.pdf), table DataWriter — “get_topic: Topic”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.getTopic), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getTopic)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic

Status: done — DataWriterImpl.getTopic returns the topic from the constructor; PublisherImpl.lookupDataWriter uses it. Test: PublisherOperationsTest::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic (assertSame). (commit a2a9a67acb5) ### §2 DataWriter: get_publisher

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 63 (dds-1.2.pdf), table DataWriter — “get_publisher: Publisher”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getParent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic

Status: done — DataWriterImpl.getParent returns the Publisher that PublisherImpl.createDataWriter passes to the constructor. Test: PublisherOperationsTest::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic (assertSame). (commit a2a9a67acb5) ### §2 DataWriter: assert_liveliness

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 63 (dds-1.2.pdf), table DataWriter — “assert_liveliness: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.assertLiveliness), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.assertLiveliness)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::assertLivelinessOfTheWriterKeepsALeaseFromRunningOut, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::aWriterThatDoesNotAssertItsLivelinessLosesItOnceAndAssertingRestoresIt

Status: done — DataWriterImpl.assertLiveliness makes the writer alive and renews the lease; with LIVELINESS MANUAL_BY_PARTICIPANT it renews the lease of all writers of this kind in the participant; on a closed writer it is AlreadyClosedException. Tests: WriterStatusTest::assertLivelinessOfTheWriterKeepsALeaseFromRunningOut (lease 1500 ms, renewed every 20 ms over 3 s: no loss; then a loss), ::aWriterThatDoesNotAssertItsLivelinessLosesItOnceAndAssertingRestoresIt. (commit cd8f3d67ea9) ### §2 DataWriter: get_matched_subscription_data

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 63, §7.1.2.4.2.23, p. 70 (dds-1.2.pdf) — “get_matched_subscription_data (inout: subscription_data: SubscriptionBuiltinTopicData, subscription_handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.getMatchedSubscriptionData), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getMatchedSubscriptionData)

Status: done — The method returns the built-in data of a matched reader (locally from the reader, remotely from the SEDP announcement). The first test expects the topic name “Chatter” and the reader’s UserData and IllegalArgumentException for a handle that is not a matched subscription; the second expects IllegalArgumentException for null. The branch for remote readers has no call in these tests. (commit a2a9a67acb5) ### §2 DataWriter: get_matched_subscriptions

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.2, p. 63 (dds-1.2.pdf), table DataWriter — “get_matched_subscriptions (inout: subscription_handles: InstanceHandle_t []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.getMatchedSubscriptions), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getMatchedSubscriptions)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::theMatchedEntitiesAreDescribedWithTheirQos, crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::cleanupRemovesSubscription, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicJoinTest.java::closingTheReaderEndsTheJoin

Status: done — The method returns the handles of the local matched readers and of the readers over the RTPS path. The tests expect size 1 with a handle that getMatchedSubscriptionData resolves, size 0 after the reader is closed, and size 1 per writer for the readers of a MultiTopic join. The branch for remote readers has no call in these tests. (commit a2a9a67acb5)

§2 Programming interfaces of [DDS] 1.2: DataWriterListener

§2 DataWriterListener: on_liveliness_lost

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.4, p. 72 (dds-1.2.pdf), table DataWriterListener — “on_liveliness_lost (the_writer: DataWriter, status: LivelinessLostStatus): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriterListener.java (DataWriterListener.onLivelinessLost), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.evaluateLiveliness)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::livelinessLostFiresWithoutPolling

Status: done — DataWriterListener declares onLivelinessLost(LivelinessLostEvent); evaluateLiveliness calls it outside the writer’s monitor when the lease of a MANUAL_BY_TOPIC writer expires. The test writes once, asserts no more and expects the callback with total_count >= 1 within 5 s without polling the status. (commit a2a9a67acb5) ### §2 DataWriterListener: on_offered_deadline_missed

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.4, p. 72 (dds-1.2.pdf), table DataWriterListener — “on_offered_deadline_missed (the_writer: DataWriter, status: OfferedDeadlineMissedStatus): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriterListener.java (DataWriterListener.onOfferedDeadlineMissed), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.evaluateOfferedDeadline)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::offeredDeadlineMissedFiresWithoutPolling

Status: done — DataWriterListener declares onOfferedDeadlineMissed(OfferedDeadlineMissedEvent); evaluateOfferedDeadline calls it outside the writer’s monitor. The test writes once with a 30 ms deadline and expects the callback with total_count >= 1 within 5 s without polling the status. (commit a2a9a67acb5) ### §2 DataWriterListener: on_offered_incompatible_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.4, p. 72 (dds-1.2.pdf), table DataWriterListener — “on_offered_incompatible_qos (the_writer: DataWriter, status: OfferedIncompatibleQosStatus): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriterListener.java (DataWriterListener.onOfferedIncompatibleQos), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.onReaderPresenceChanged)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::anIncompatibleReaderIsCountedWithTheRefusedPolicy, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aWriterThatAWriterListenerTakesIsNotPassedUp

Status: done — DataWriterImpl.onReaderPresenceChanged calls onOfferedIncompatibleQos of the listener with the status when the QoS requested by a reader is incompatible. Tests: WriterStatusTest::anIncompatibleReaderIsCountedWithTheRefusedPolicy (DataWriterAdapter overrides onOfferedIncompatibleQos), PublisherOperationsTest::aWriterThatAWriterListenerTakesIsNotPassedUp (only the writer listener is called). (commit d23eff980f3) ### §2 DataWriterListener: on_publication_matched

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.4.4, p. 72 (dds-1.2.pdf), table DataWriterListener — “on_publication_matched (the_writer: DataWriter, status: PublicationMatchedStatus): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriterListener.java (DataWriterListener.onPublicationMatched), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.onReaderPresenceChanged)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::writerListenerFiresOnPublicationMatched

Status: done — DataWriterListener declares onPublicationMatched(PublicationMatchedEvent); onReaderPresenceChanged calls it when a reader appears and disappears. The test expects one call per event (1 after the reader, 2 after its close), current_count 1 and then 0, total_count 1, and the writer itself as the source of the event. (commit a2a9a67acb5)

§2 Programming interfaces of [DDS] 1.2: Subscriber

§2 Subscriber: create_datareader and delete_datareader

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.2, p. 80 (dds-1.2.pdf), table Subscriber — “create_datareader (a_topic: TopicDescription, qos: QosPolicy [], a_listener: DataReaderListener, mask: StatusKind []): DataReader; delete_datareader (a_datareader: DataReader): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Subscriber.java (Subscriber.createDataReader), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.createDataReader), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.close)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerPropagationTest.java::aReaderListenerSetAtCreationSeesTheMatchOfEnableAndTheSubscriberGetsDataOnReaders, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createSubscriberWithAListenerSeesTheMatchOfAReaderCreatedLater, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCleanupTest.java::aClosedWriterAndReaderAreNotListedOrFoundAnyMore, crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theContentFilteredTopicOfTheParticipantFiltersTheSamples, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicTest.java::aReaderOnTheMultiTopicReceivesTheMatchingSamples

Status: done — createDataReader has the forms without argument, with DataReaderQos and with listener and status set for every TopicDescription; the listener is set before enable, so match and replay from enable reach it. DataReaderImpl.close removes the reader from SubscriberImpl.readers and withdraws it from DCPSSubscription (close hook, SubscriberImpl.readerGone). A reader on a ContentFilteredTopic or a MultiTopic holds the description (SubscriberImpl.usedBy). Tests: ListenerPropagationTest::aReaderListenerSetAtCreationSeesTheMatchOfEnableAndTheSubscriberGetsDataOnReaders (reader with listener, existing writer), ParticipantEntityTest::createSubscriberWithAListenerSeesTheMatchOfAReaderCreatedLater, CloseCleanupTest::aClosedWriterAndReaderAreNotListedOrFoundAnyMore, ContentFilterTest, MultiTopicTest. (commit f31b6fa11b5) ### §2 Subscriber: lookup_datareader

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.2, p. 80 (dds-1.2.pdf), table Subscriber — “lookup_datareader (topic_name: string): DataReader”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Subscriber.java (Subscriber.lookupDataReader), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.lookupDataReader)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantSubscriberTest.java::lookupDataReaderFindsByNameByTopicAndByFilteredTopic, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCleanupTest.java::aClosedWriterAndReaderAreNotListedOrFoundAnyMore

Status: done — SubscriberImpl.lookupDataReader(String) and (TopicDescription) search the list of created readers for the name of the reader’s TopicDescription (for a reader on a ContentFilteredTopic its name); a closed reader is removed from the list. Tests: ParticipantSubscriberTest::lookupDataReaderFindsByNameByTopicAndByFilteredTopic (found, null for an unknown name and for the topic under the ContentFilteredTopic, null after close), CloseCleanupTest::aClosedWriterAndReaderAreNotListedOrFoundAnyMore. (commit 28e25c198d1) ### §2 Subscriber: begin_access and end_access

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.2, p. 80–81 (dds-1.2.pdf), table Subscriber — “begin_access: ReturnCode_t; end_access: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Subscriber.java (Subscriber.beginAccess), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.beginAccess), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.endAccess), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.collect), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.checkGroupAccess)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantSubscriberTest.java::endAccessNeedsABeginAccessAndTheCallsNest, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantSubscriberTest.java::withAccessScopeGroupTheSamplesAreAccessedBetweenBeginAndEndAccessOnly, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantSubscriberTest.java::withTheDefaultAccessScopeNoBeginAccessIsNeeded, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantSubscriberTest.java::aReadOfAnotherThreadWaitsForEndAccess

Status: done — SubscriberImpl.beginAccess holds a ReentrantLock of the subscriber, which read and take of the readers take as well; the calls nest, a thread that holds the access reads without waiting, others wait. endAccess without beginAccess is PreconditionNotMetException (DDS 1.4 §2.2.2.5.2.9). With PRESENTATION access_scope GROUP, read and take of the readers and getDataReaders of the subscriber outside begin_access are refused with PreconditionNotMetException (SubscriberImpl.checkGroupAccess); the readers of a MultiTopic join are exempt. Tests: ParticipantSubscriberTest::endAccessNeedsABeginAccessAndTheCallsNest, ::withAccessScopeGroupTheSamplesAreAccessedBetweenBeginAndEndAccessOnly, ::withTheDefaultAccessScopeNoBeginAccessIsNeeded, ::aReadOfAnotherThreadWaitsForEndAccess. (commit cd8f3d67ea9) ### §2 Subscriber: get_datareaders

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.2, p. 81 (dds-1.2.pdf), table Subscriber — “get_datareaders (out: readers: DataReader [], sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Subscriber.java (Subscriber.getDataReaders), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.getDataReaders), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.hasMatchingSample)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantSubscriberTest.java::getDataReadersWithADataStateListsTheReadersThatHoldSuchSamples, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicJoinTest.java::closingTheReaderEndsTheJoin

Status: done — getDataReaders(Collection) returns the subscriber’s readers, getDataReaders(Collection, DataState) those that hold a sample in the chosen sample, view and instance states (DataReaderImpl.hasMatchingSample). Test: ParticipantSubscriberTest::getDataReadersWithADataStateListsTheReadersThatHoldSuchSamples (empty before the write, only the reader of the written topic afterwards, empty after take; both readers without a DataState), MultiTopicJoinTest::closingTheReaderEndsTheJoin. (commit 819bfcb46cb) ### §2 Subscriber: notify_datareaders

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.2, p. 81 (dds-1.2.pdf), table Subscriber — “notify_datareaders: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.notifyDataReaders), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.notifyDataAvailable)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::dataOnReadersGoesToTheSubscriberListenerAndNotifyDataReadersPassesItToTheReadersWithNewData, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::withoutASubscriberListenerTheReadersListenersAreCalledAndDataOnReadersStaysChanged

Status: done — SubscriberImpl.notifyDataReaders calls DataReaderImpl.notifyDataAvailable on every reader. That calls onDataAvailable on the reader listener only when the DATA_AVAILABLE status of the reader is changed (no read/take since the arrival) and does not go through the listener of the subscriber. dataOnReadersGoesToTheSubscriberListener... takes the sample from one of two readers; after notifyDataReaders the other reader counts one call, the first none. The second test checks that a reader gets no call after a read. (commit e1b55167947) ### §2 Subscriber: get_participant

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.2, p. 81 (dds-1.2.pdf), table Subscriber — “get_participant: DomainParticipant”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.getParent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::theParentOfASubscriberIsItsParticipantAndTheParentOfAReaderItsSubscriber

Status: done — SubscriberImpl.getParent returns the DomainParticipant the subscriber was created from. The test expects the creating participant with assertSame. (commit 819bfcb46cb) ### §2 Subscriber: delete_contained_entities

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.2, p. 81 (dds-1.2.pdf), table Subscriber — “delete_contained_entities: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.closeContainedEntities)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::closeContainedEntitiesClosesTheReadersAndWithdrawsThemFromTheBuiltinTopic

Status: done — SubscriberImpl.closeContainedEntities calls close() on every reader; the close hook of the reader removes it from readers and calls Discovery.readerClosed. The operation now checks with ensureOpen that the subscriber is open. The test watches the built-in topic DCPSSubscription from a second participant of the domain: after the call both readers are closed, getDataReaders is empty, lookupDataReader returns null, the subscriber is open, and two samples without data with NOT_ALIVE_NO_WRITERS arrive. (commit e1b55167947) ### §2 Subscriber: set_default_datareader_qos and get_default_datareader_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.2, p. 81 (dds-1.2.pdf), table Subscriber — “set_default_datareader_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_datareader_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.setDefaultDataReaderQos), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.getDefaultDataReaderQos), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.createDataReader)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::theDefaultReaderQosIsWhatCreateDataReaderUses

Status: done — getDefaultDataReaderQos returns the defaults before it is set (HISTORY KEEP_LAST, depth 1). After setDefaultDataReaderQos(q) the reader created with createDataReader(topic) has that QoS (KEEP_ALL). (commit 819bfcb46cb) ### §2 Subscriber: copy_from_topic_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.2, p. 81 (dds-1.2.pdf), table Subscriber — “copy_from_topic_qos (inout: a_datareader_qos: QosPolicy [], a_topic_qos: QosPolicy []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.copyFromTopicQos)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::copyFromTopicQosReplacesThePoliciesTheTopicAndTheReaderShare

Status: done — SubscriberImpl.copyFromTopicQos replaces every policy of the reader QoS that the topic QoS also has (QosPolicy.ForDataReader) with the topic value, even if the reader value differs from the default (DDS 1.4 §2.2.2.5.2.17). Policies only the reader has (UserData) stay, the QoS passed in is unchanged. The test sets HISTORY KEEP_LAST 5 and DURABILITY TRANSIENT_LOCAL on the reader, KEEP_ALL and VOLATILE on the topic, and expects the topic values. (commit e1b55167947) ### §2 SubscriberListener: on_data_on_readers

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.6, p. 104 (dds-1.2.pdf), table SubscriberListener — “on_data_on_readers (the_subscriber: Subscriber): void”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl (EntityBase.getListener)), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/SubscriberListener.java (SubscriberListener.onDataOnReaders)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::dataOnReadersGoesToTheSubscriberListenerAndNotifyDataReadersPassesItToTheReadersWithNewData

Status: done — DataReaderImpl.fireDataAvailable calls onDataOnReaders with a DataOnReadersEventImpl (source: the subscriber) when the subscriber (or the domain participant) has a listener with DATA_ON_READERS, instead of onDataAvailable of the reader. The subscriber has the status flag DATA_ON_READERS (SubscriberImpl.dataOnReadersChanged); calling the listener and read/take on a reader of the subscriber reset it. The test sets a SubscriberAdapter and two reader listeners and expects calls only on the subscriber listener. (commit e1b55167947)

§2 Programming interfaces of [DDS] 1.2: DataReader

§2 DataReader: read

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 86 (dds-1.2.pdf), table DataReader — “read (inout: data_values: Data [], inout: sample_infos: SampleInfo [], max_samples: long, sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.read), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.collectLocked), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.toSample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleIterator.java (SampleIterator)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::readReturnsSamplesWithoutRemoving, crates/java-omgdds/java/src/test/java/org/omg/dds/SampleStateTest.java::readMarksSamplesRead, crates/java-omgdds/java/src/test/java/org/omg/dds/ReadCopyTest.java::readReturnsAFreshCopyNotTheReadersObject, crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::readAndTakeOnAClosedReaderThrowAlreadyClosed, crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theSelectorOfReadAndTakeCarriesTheExpression, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::maxSamplesLimitsReadAndTakeAndUnlimitedIsAcceptedAsAValue, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDataStateSelectsOnSampleViewAndInstanceStates, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderIteratorTest.java::theIteratorWalksTheSamplesInBothDirections, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderIteratorTest.java::readSelectorAndIntFormsReturnTheSameSamplesAsTheListForm, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::destinationOrderBySourceTimestampKeepsTheSamplesOfAnInstanceInTimestampOrder, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::orderedAccessWithScopeTopicReturnsTheSamplesOfAllInstancesInOneOrder

Status: done — read(), read(int), read(Selector) (Sample.Iterator) and read(List), read(List, Selector) (copy into the list) apply maxSamples and the three state sets in collectLocked; read marks the samples READ. With DESTINATION_ORDER BY_SOURCE_TIMESTAMP the samples of an instance are ordered by timestamp (insertOrdered); with PRESENTATION ordered_access and scope TOPIC or GROUP collectLocked returns the samples of all instances in one order by (timestamp, arrival), maxSamples cuts that order. Tested: staying in the reader, READ on the second read, copy, AlreadyClosedException, content filter, read(int), maxSamples, the state sets, the content of the iterator and both orders. (commit e1b55167947) ### §2 DataReader: take

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 86 (dds-1.2.pdf), table DataReader — “take (inout: data_values: Data [], inout: sample_infos: SampleInfo [], max_samples: long, sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.take), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.collectLocked), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.instances)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::readReturnsSamplesWithoutRemoving, crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::readAndTakeOnAClosedReaderThrowAlreadyClosed, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::anInstanceWithoutLiveWritersAndWithoutSamplesIsForgottenByTheReader, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::aDisposedInstanceStaysDisposedWhenItsLastWriterUnregisters, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::maxSamplesLimitsReadAndTakeAndUnlimitedIsAcceptedAsAValue, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::anInstanceHandleLimitsReadAndTakeToThatInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderIteratorTest.java::takeReturnsTheSamplesInTheIteratorAndRemovesThemFromTheReader

Status: done — take in its four forms removes the returned samples from the reader. An instance without live writers and without samples is removed from instances (DataReaderImpl.reclaim, DDS 1.4 §2.2.2.5.1.8); lookupInstance then returns the NIL handle, a later sample is an instance never seen. An instance NOT_ALIVE_DISPOSED stays so when the last writer unregisters. Tested: order, removal, take(int)/maxSamples, state sets, the iterator form and forgetting the instance. (commit e1b55167947) ### §2 DataReader: state masks for read and take

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 86 (dds-1.2.pdf), table DataReader — “sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind []”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.collectLocked), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.dataState), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataStateImpl.java (DataStateImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDataStateSelectsOnSampleViewAndInstanceStates

Status: done — read/take carry the masks through Selector.dataState(Subscriber.DataState); collectLocked filters on sampleStates, viewStates and instanceStates (all without dataState, getDataState() then returns DataStateImpl.any). The test brings eight readers into the same state (instance 1 read, instance 3 disposed, instance 2 untouched) and queries one each with READ, NOT_READ, NOT_NEW, NEW, NOT_ALIVE_DISPOSED, ALIVE and NOT_ALIVE_NO_WRITERS (expected counts derived from the state) and take with READ. (commit e1b55167947) ### §2 DataReader: read_w_condition and take_w_condition

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 86 (dds-1.2.pdf), table DataReader — “read_w_condition (inout: data_values: Data [], inout: sample_infos: SampleInfo [], max_samples: long, a_condition: ReadCondition): ReturnCode_t; take_w_condition (…): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.collectLocked), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.getCondition), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.condition)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::aReadConditionOfTheReaderSelectsItsStatesWithTheSelector, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::aQueryConditionOfTheReaderSelectsByItsExpressionAndTheNextInstanceKeepsIt

Status: done — SelectorImpl.condition(ReadCondition) (a ZeroDDS extension, not in DataReader.Selector) binds a condition of the reader to the selector; getCondition() returns it. collectLocked intersects its state sets and, for a QueryCondition, its expression with the current parameters with the other settings of the selector. A condition of another reader gives PreconditionNotMetException, a closed one AlreadyClosedException. Tested for read and take. (commit e1b55167947) ### §2 DataReader: read_next_sample and take_next_sample

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 86 (dds-1.2.pdf), table DataReader — “read_next_sample (inout: data_value: Data, inout: sample_info: SampleInfo): ReturnCode_t; take_next_sample (inout: data_value: Data, inout: sample_info: SampleInfo): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.readNextSample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.takeNextSample)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::readNextSampleReturnsTheNextSampleNotYetReadAndTakeNextSampleRemovesIt

Status: done — readNextSample and takeNextSample select with a selector with maxSamples(1) and SampleState NOT_READ (DataReaderImpl.nextSampleSelector), copy the result into the passed SampleImpl by copyInto and return false without a sample (the passed sample is then unchanged). The test calls readNextSample three times: two different samples, then false; takeNextSample removes the sample. (commit e1b55167947) ### §2 DataReader: read_instance and take_instance

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 87 (dds-1.2.pdf), table DataReader — “read_instance (…, a_handle: InstanceHandle_t, sample_states, view_states, instance_states): ReturnCode_t; take_instance (…): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::anInstanceHandleLimitsReadAndTakeToThatInstance

Status: done — select().instance(handle) limits read/take to the instance with that handle (comparison in collectLocked). A handle without an instance yields an empty collection (the specification permits BAD_PARAMETER but does not require it). The test reads and takes the two samples of instance 2 of three instances; the samples carry its handle, take removes only these. (commit e1b55167947) ### §2 DataReader: read_next_instance and take_next_instance

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 87 (dds-1.2.pdf), table DataReader — “read_next_instance (…, previous_handle: InstanceHandle_t, sample_states, view_states, instance_states): ReturnCode_t; take_next_instance (…): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::nextInstanceWalksTheInstancesInTheOrderOfTheirHandles, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::nextInstanceSkipsInstancesWithoutSamplesInTheSelectedStates

Status: done — With Selector.nextInstance(true) collectLocked returns the samples of the instance with the smallest handle greater than that of instance(h) (from the smallest without instance) that has matching samples, and only that instance. The handles are ordered by InstanceHandle.compareTo (unsigned, byte by byte). The test writes the keys 3, 1, 2 and walks them as 1, 2, 3, then empty; take takes only the first instance; instances without a sample in the selected state are skipped. (commit e1b55167947) ### §2 DataReader: read_next_instance_w_condition and take_next_instance_w_condition

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 88 (dds-1.2.pdf), table DataReader — “read_next_instance_w_condition (…, previous_handle: InstanceHandle_t, a_condition: ReadCondition): ReturnCode_t; take_next_instance_w_condition (…): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::aQueryConditionOfTheReaderSelectsByItsExpressionAndTheNextInstanceKeepsIt

Status: done — Condition and previous handle combine in one selector: condition(c).instance(h).nextInstance(true). The test reads with a QueryCondition “seq > %0” from instance 1 on and gets the samples of instance 2 with seq 1; changed parameters change the result; take with the condition removes only the selected samples. (commit e1b55167947) ### §2 DataReader: return_loan

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 88 (dds-1.2.pdf), table DataReader — “return_loan (inout: data_values: Data [], inout: sample_infos: SampleInfo []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleIterator.java (SampleIterator.close)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderIteratorTest.java::closeEndsTheLoanAndClosingAgainIsHarmless, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderIteratorTest.java::theIteratorIsReadOnly

Status: done — Sample.Iterator.close() maps return_loan (SampleIterator.close); the call throws nothing, also the second time (Closeable). read and take copy the data (deepCopy), nothing is loaned; the samples stay readable after close. The name returnLoan does not exist in the OMG API (close()). (commit e0f89cfd194) ### §2 DataReader: get_key_value

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 88 (dds-1.2.pdf), table DataReader — “get_key_value (inout: key_holder: Data, handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getKeyValue)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderKeyTest.java::getKeyValueReturnsASampleOfTheInstanceThatHasTheKey, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderKeyTest.java::getKeyValueSetsTheKeyFieldsOfTheHolderAndLeavesTheOthers, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderKeyTest.java::getKeyValueOfAHandleTheReaderDoesNotKnowIsAnIllegalArgument, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderKeyTest.java::getKeyValueOnATopicWithoutAKeyIsPreconditionNotMet

Status: done — The reader keeps one sample per instance (Instance.keyData). For a type of the Java type representation (ReflectionTypeSupport) getKeyValue(keyHolder, handle) sets the key fields of the holder and leaves the others; for a type without writable fields (record, hand-written support) the result is a copy of that sample instead of the holder. An unknown or null handle gives IllegalArgumentException, a type without key PreconditionNotMetException. getKeyValue(InstanceHandle) returns the copy. (commit e1b55167947) ### §2 DataReader: lookup_instance

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 88 (dds-1.2.pdf), table DataReader — “lookup_instance (instance: Data): InstanceHandle_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.lookupInstance)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderKeyTest.java::lookupInstanceIsNilBeforeTheInstanceIsKnownAndTheHandleOfTheSampleAfterwards, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderKeyTest.java::lookupInstanceWithAHandleFillsItAndWithoutOneReturnsANewObject

Status: done — lookupInstance(T) returns the handle of a known instance (equal to Sample.getInstanceHandle()) or the NIL handle, before the first sample and after the instance is forgotten (reclaim). lookupInstance(handle, key) fills the handle passed in, for null it returns a new object; a null key gives IllegalArgumentException. (commit e1b55167947) ### §2 DataReader: create_readcondition

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 88 (dds-1.2.pdf), table DataReader — “create_readcondition (sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind []): ReadCondition”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.createReadCondition), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.hasMatchingSample), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/ReadConditionImpl.java (ReadConditionImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DdsAsyncTest.java::waitForSamplesAsyncFalseOnTimeout, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::aReadConditionIsTrueWhileTheReaderHoldsASampleInItsStates

Status: done — createReadCondition(DataState) returns a ReadConditionImpl with the state sets as of its creation (a copy); the trigger value is true while the reader holds a sample in those three sets (anySample). aReadConditionIsTrueWhileTheReaderHoldsASampleInItsStates checks NOT_READ and READ on a WaitSet: empty false (timeout), true after write (the condition is in the active set), the values swap after read, false after take. The condition is kept by the reader and closed by close/closeContainedEntities. (commit e1b55167947) ### §2 DataReader: create_querycondition

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 88 (dds-1.2.pdf), table DataReader — “create_querycondition (sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind [], query_expression: string, query_parameters: string []): QueryCondition”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.createQueryCondition), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/QueryConditionImpl.java (QueryConditionImpl)

Status: done — Both overloads of createQueryCondition exist. The trigger value is true when one sample is both in the state sets and satisfies the expression (anySample(state, predicate)); a sample without data satisfies no expression. The test (overload with DataState) has a read sample that does not satisfy the expression and an unread one that does: the trigger is false, true after read. (commit e1b55167947) ### §2 DataReader: delete_readcondition

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 88 (dds-1.2.pdf), table DataReader — “delete_readcondition (a_condition: ReadCondition): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.closeContainedEntities), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/ReadConditionImpl.java (ReadConditionImpl.close)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::aClosedConditionIsGoneAndAClosedConditionOnAWaitSetNeverTriggers, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::closeContainedEntitiesClosesTheConditionsOfTheReaderAndNotTheReader, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::closingTheReaderClosesItsConditions

Status: done — The reader keeps its conditions (DataReaderImpl.register); ReadConditionImpl.close removes the condition there and marks it closed, a second close has no effect. getTriggerValue and QueryCondition.setQueryParameters on a closed condition give AlreadyClosedException, a WaitSet skips it. A condition that does not belong to this reader (PRECONDITION_NOT_MET) cannot be expressed by close(); the selector reports it (see the item on read_w_condition). (commit e1b55167947) ### §2 DataReader: get_liveliness_changed_status

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89 (dds-1.2.pdf), table DataReader — “get_liveliness_changed_status (out: status: LivelinessChangedStatus): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getLivelinessChangedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.countLivelinessLocked), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.WireReader.remoteLiveliness), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.WireWriter.assertLiveliness), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.assertOnWire)

Status: done — alive_count, not_alive_count and both change values are computed from the writers in the same process (matchedWriters: PARTITION overlaps, QoS compatible; countLivelinessLocked) and from the connected writers of other processes. A remote writer is alive as long as the time since its last sign is within the lease it announced in SEDP; without an announced liveliness it counts as AUTOMATIC with an infinite lease. Signs are a DATA of the writer, a HEARTBEAT with the L flag (DDSI-RTPS 2.5 §8.3.7.5; DataWriter.assertLiveliness and the assertion at participant level for MANUAL_BY_PARTICIPANT send it to the connected readers) and, for AUTOMATIC, every message of its participant (SPDP). The reader learns when a writer is alive again after its lease ran out (WireReader.setLivelinessListener) and raises onLivelinessChanged. The built-in endpoints of the Writer Liveliness Protocol (DCPSParticipantMessage, §8.4.13) are not built; ZeroDDS does not announce them in SPDP, so a foreign participant does not send them. Expected: Cyclone DDS, Fast DDS and OpenDDS keep AUTOMATIC writers alive through SPDP and evaluate the L flag of the HEARTBEAT; MANUAL_BY_PARTICIPANT of a foreign writer reaches ZeroDDS only through DATA and HEARTBEAT. (commit 16f61d4789d) ### §2 DataReader: last_publication_handle of LIVELINESS_CHANGED

Spec: §2, p. 11; [DDS] 1.2 IDL, p. 159–160 (dds-1.2.pdf) — “struct LivelinessChangedStatus { […] InstanceHandle_t last_publication_handle; };”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getLivelinessChangedStatus), crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/LivelinessChangedStatus.java (LivelinessChangedStatus.getLastPublicationHandle)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::livelinessChangedNamesTheWriterWhoseLivelinessChangedAndCountsTheChanges

Status: done — last_publication_handle of LIVELINESS_CHANGED is the handle of the writer whose liveliness changed last (DataReaderImpl.lastLivelinessHandle, set in countLivelinessLocked when isAlive changes and in onWriterPresenceChanged when a writer goes); getLivelinessChangedStatus and evaluateLiveliness pass it on. The test expects writer.getInstanceHandle() on appearing and on lease expiry. (commit e1b55167947) ### §2 DataReader: get_requested_deadline_missed_status

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89 (dds-1.2.pdf), table DataReader — “get_requested_deadline_missed_status (out: status: RequestedDeadlineMissedStatus): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getRequestedDeadlineMissedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.evaluateDeadline)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::requestedDeadlineMissedIsRaised, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::infiniteDeadlineNeverMisses, crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::requestedDeadlineMissedFiresWithoutPolling, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::requestedDeadlineMissedNamesTheInstanceThatMissedLast, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::theChangeOfRequestedDeadlineMissedStartsAgainWhenTheStatusIsRead

Status: done — Misses are computed per instance from the wall clock (once per elapsed period, from the arrival of the last sample) and reported asynchronously by the reader lease. Tested: total_count and total_count_change, no miss with an infinite period, onRequestedDeadlineMissed, last_instance_handle with two instances (equal to the handle of instance 2, which is waited for) and the change value 0 on the second read (period 1500 ms, the next expiry is far after the read). (commit e1b55167947) ### §2 DataReader: get_requested_incompatible_qos_status

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89 (dds-1.2.pdf), table DataReader — “get_requested_incompatible_qos_status (out: status: RequestedIncompatibleQosStatus): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getRequestedIncompatibleQosStatus), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.onWriterPresenceChanged), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosCompatibility.java (QosCompatibility.incompatiblePolicyWith), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosCompatibility.java (QosCompatibility.incompatiblePoliciesWith)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosCompatibilityTest.java::incompatibleReliabilityDoesNotConnect, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::requestedIncompatibleQosCountsTheRefusingPolicyAndResetsItsChange, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::everyPolicyThatRefusesTheConnectionIsCountedAndOneConnectionIsOneInTotal, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::thePresentationOfTheSubscriberMustBeOfferedByThePublisher, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aWriterThatOffersLessThanRequestedIsReportedToTheListener

Status: done — On connecting, the reader checks the offered QoS with QosCompatibility.incompatiblePoliciesWith: Reliability, Durability, Deadline, Liveliness, Ownership, DestinationOrder, LatencyBudget and PRESENTATION (the policy of the subscriber, requested by the reader, that of the publisher, offered by the writer: lower scope, or coherent/ordered not offered). On incompatibility there is no match and no delivery; one connection counts once in total_count and once in the QosPolicyCount of each refusing policy; last_policy_id is one of them. onRequestedIncompatibleQos is called. Tested: one and three policies, the reset of the change, PRESENTATION, the listener. (commit d17c5f0c379) ### §2 DataReader: get_sample_lost_status

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89 (dds-1.2.pdf), table DataReader — “get_sample_lost_status (out: status: SampleLostStatus): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getSampleLostStatus), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.noteSequence)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/sub/ReaderWireTest.java::aGapInTheSequenceNumbersOfAWriterIsSampleLost, crates/java-omgdds/java/src/test/java/org/zerodds/sub/ReaderWireTest.java::sampleLostIsReportedToTheListener

Status: done — DataReaderImpl.noteSequence compares the sequence number of a sample from the RTPS path (deliverWire) per writer GUID with the last one seen; a gap counts in lostTotal, getSampleLostStatus reports total and change and resets the change, onSampleLost is called. The test delivers sequence numbers 1, 4, 5 of one writer and 10 of a second: total 2, change 2, then 0. The in-process bus loses no samples. (commit e1b55167947) ### §2 DataReader: get_sample_rejected_status

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89 (dds-1.2.pdf), table DataReader — “get_sample_rejected_status (out: status: SampleRejectedStatus): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getSampleRejectedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.onWrite), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.rejectedByLimits)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aSampleBeyondMaxSamplesIsRejectedAndReportedToTheListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderLimitsTest.java::aSampleOfANewInstanceBeyondMaxInstancesIsRejectedWithThatReasonAndInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderLimitsTest.java::aSampleBeyondMaxSamplesPerInstanceIsRejectedWithThatReasonAndInstance

Status: done — DataReaderImpl.rejectedByLimits applies RESOURCE_LIMITS (max_samples, max_instances, max_samples_per_instance), counts total_count, sets reason and instance and fires onSampleRejected. Tested: all three reasons with last_reason and last_instance_handle (the handle of the key derived by hand from the 16 octets), the change value and the listener. (commit e1b55167947) ### §2 DataReader: get_subscription_matched_status

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89 (dds-1.2.pdf), table DataReader — “get_subscription_matched_status (out: status: SubscriptionMatchedStatus): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getSubscriptionMatchedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.onWriterPresenceChanged)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::statusIsReadableWithoutAListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::readerListenerFiresOnMatchAndOnEverySample, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::nonOverlappingPartitionIsNotAMatch, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::subscriptionMatchedNamesTheWriterThatConnectedOrLeftLast, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::aWriterInAnotherPartitionOrWithLessQosThanRequestedIsNotMatched

Status: done — total_count, current_count and both change values are kept as writers connect and disconnect; writers with non-overlapping PARTITION or incompatible QoS do not count; last_publication_handle is the handle of the writer that connected or disconnected last. The tests check counts, changes, listener events and the handles. (commit e1b55167947) ### §2 DataReader: last_publication_handle of SUBSCRIPTION_MATCHED

Spec: §2, p. 11; [DDS] 1.2 IDL, p. 160–161 (dds-1.2.pdf) — “struct SubscriptionMatchedStatus { […] InstanceHandle_t last_publication_handle; };”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.readSubscriptionMatchedStatusLocked)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::subscriptionMatchedNamesTheWriterThatConnectedOrLeftLast

Status: done — readSubscriptionMatchedStatusLocked passes DataReaderImpl.lastMatchedHandle: the handle (WriterPresence.writerHandle) of the writer that connected or disconnected last. The test expects, after the first writer, the second and after closing the first, its getInstanceHandle() each time and checks that getMatchedPublications contains the handles. (commit e1b55167947) ### §2 DataReader: get_topicdescription

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89 (dds-1.2.pdf), table DataReader — “get_topicdescription: TopicDescription”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getTopicDescription), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.describedBy), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.createDataReader)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::theDescriptionOfAReaderIsTheTopicOrTheContentFilteredTopicItWasCreatedWith, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicTest.java::theReaderReportsTheMultiTopicAsItsDescription

Status: done — getTopicDescription returns the description the reader was created with: for a ContentFilteredTopic and a MultiTopic SubscriberImpl.createDataReader sets it through describedBy, otherwise the topic. Topic, ContentFilteredTopic (assertSame) and MultiTopic are tested. (commit a2a9a67acb5) ### §2 DataReader: get_subscriber

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89 (dds-1.2.pdf), table DataReader — “get_subscriber: Subscriber”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getParent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::theParentOfASubscriberIsItsParticipantAndTheParentOfAReaderItsSubscriber

Status: done — DataReaderImpl.getParent returns the Subscriber that created the reader. The test expects it with assertSame. (commit a2a9a67acb5) ### §2 DataReader: delete_contained_entities

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89 (dds-1.2.pdf), table DataReader — “delete_contained_entities: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.closeContainedEntities)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::closeContainedEntitiesClosesTheConditionsOfTheReaderAndNotTheReader

Status: done — DataReaderImpl.closeContainedEntities closes all conditions of the reader created with createReadCondition/createQueryCondition (list conditions); the reader stays open and can create new conditions. The test checks AlreadyClosedException on both conditions, then writing, reading and a new condition. (commit e1b55167947) ### §2 DataReader: wait_for_historical_data

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89 (dds-1.2.pdf), table DataReader — “wait_for_historical_data (max_wait: Duration_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.waitForHistoricalData), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.WireReader.historicalDataReceived)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/sub/ReaderWireTest.java::aReaderThatIsNotOnTheWireWaitsForNoHistoricalData, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderLimitsTest.java::aLateReaderGetsTheHistoricalDataOfATransientLocalWriterBeforeWaitForHistoricalDataReturns, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderWireHistoricalDataTest.java::theCallReturnsOnceTheAnnouncedSamplesHaveArrived, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderWireHistoricalDataTest.java::theCallIsATimeoutExceptionWhileTheWriterAnnouncedNothing

Status: done — In the same process the samples of a TRANSIENT_LOCAL writer go to the reader in enable() (replayTo); both overloads of waitForHistoricalData then return at once, a negative value gives IllegalArgumentException. With an RTPS reader of non-VOLATILE durability the call waits on WireReader.historicalDataReceived: every connected reliable, non-VOLATILE remote writer has announced its last sequence number in a HEARTBEAT, the reader has received up to it, and no received message is still on its way to the reader (deliveriesInFlight). After maxWait a TimeoutException follows. Both RTPS branches are tested with a second RTPS participant. (commit 1d0691890fa) ### §2 DataReader: get_matched_publication_data

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89, §7.1.2.5.3.33, p. 102 (dds-1.2.pdf) — “get_matched_publication_data (inout: publication_data: PublicationBuiltinTopicData, publication_handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getMatchedPublicationData)

Status: done — For a writer in the same process getMatchedPublicationData returns the built-in data of the writer, for a remote writer that of the SEDP announcement; an unknown handle throws IllegalArgumentException. The test with a writer of a second RTPS participant checks the topic name, type name and OwnershipStrength of the SEDP announcement; the test on the local writer checks the topic name, durability, OwnershipStrength and the exception for the NIL handle. (commit 447490d2b6d) ### §2 DataReader: get_matched_publications

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.3, p. 89 (dds-1.2.pdf), table DataReader — “get_matched_publications (inout: publication_handles: InstanceHandle_t []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getMatchedPublications)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::theMatchedEntitiesAreDescribedWithTheirQos, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::subscriptionMatchedNamesTheWriterThatConnectedOrLeftLast, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::aWriterInAnotherPartitionOrWithLessQosThanRequestedIsNotMatched

Status: done — getMatchedPublications returns the handles of the connected writers in the process (matchedWriters with writerHandle()) and of those connected over RTPS (wire.matchedEndpoints). Tested: size 1, use of the element in getMatchedPublicationData, the set shrinks after writer.close(), a writer in another partition and one with incompatible QoS are not in it. Writers over RTPS are untested. (commit e1b55167947)

§2 Programming interfaces of [DDS] 1.2: SampleInfo

§2 SampleInfo: sample_state

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103, §7.1.2.5.1.2, p. 75 (dds-1.2.pdf) — “sample_state: SampleStateKind”; “READ indicates that the DataReader has already accessed that sample by means of read.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.toSample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getSampleState), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getSampleState)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SampleStateTest.java::readMarksSamplesRead

Status: done — toSample returns the state of the sample before the access and then marks it READ in the reader. The test reads the same sample twice and expects NOT_READ the first time and READ the second time. The statement “always NOT_READ” no longer applies. (commit a2a9a67acb5) ### §2 SampleInfo: view_state

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103, §7.1.2.5.1.8, p. 77 (dds-1.2.pdf) — “view_state: ViewStateKind”; “NEW indicates that either this is the first time that the DataReader has ever accessed samples of that instance […] The view_state is therefore the same for all samples in the returned collection that refer to the same instance.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.toSample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.collectLocked), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getViewState)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SampleStateTest.java::viewStateIsNewUntilFirstAccess, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::allSamplesOfAnInstanceInOneCollectionHaveTheSameViewStateAndTheSampleStateOfBeforeTheRead

Status: done — view_state is fixed once per instance when the collection is assembled (Pick.view); NOT_NEW is set only after the collection. The test (KEEP_ALL, two writes, one read): both samples NEW and NOT_READ, NOT_NEW and READ on the second read; an instance reborn after dispose is NEW again. (commit e1b55167947) ### §2 SampleInfo: instance_state

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103 (dds-1.2.pdf), table SampleInfo — “instance_state: InstanceStateKind”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getInstanceState), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.onMessage), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.markState), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/InstanceState.java (InstanceState)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::disposeMarksInstanceNotAliveDisposed, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::unregisterMarksInstanceNotAliveNoWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::disposedThenWrittenIsRebornAlive, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::closingOneWriterDoesNotMarkNoWritersWhileAnotherWrites

Status: done — The reader keeps ALIVE, NOT_ALIVE_DISPOSED and NOT_ALIVE_NO_WRITERS per instance (Instance.state); onMessage sets them on dispose, unregister and write. The tests check NOT_ALIVE_DISPOSED after dispose, NOT_ALIVE_NO_WRITERS after unregister and after the last writer closes (not while a second writer is still writing), and ALIVE after another write. The snapshot property is in the following item. (commit a2a9a67acb5) ### §2 SampleInfo: instance_state as the state at reading

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.1.3, p. 75 (dds-1.2.pdf) — “The instance_state available in the SampleInfo is a snapshot of the instance_state of the instance at the time the collection was obtained (i.e., at the time read or take was called). The instance_state is therefore the same for all samples in the returned collection that refer to the same instance.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SampleStateTest.java::disposeSnapshotsInstanceStateForAllSamples

Status: done — toSample reads instance_state from the state of the instance at the time of read/take, not from the time of arrival. The test (KEEP_ALL) writes two samples, calls dispose and expects NOT_ALIVE_DISPOSED in all three returned samples. The statement “data sample with ALIVE” no longer applies. (commit a2a9a67acb5) ### §2 SampleInfo: disposed_generation_count

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103 (dds-1.2.pdf), table SampleInfo — “disposed_generation_count: long”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getDisposedGenerationCount), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.of)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::anInstanceDisposedAndWrittenAgainCountsADisposedGeneration

Status: done — The instance keeps disposedGeneration; onWrite increments it when the instance changes from NOT_ALIVE_DISPOSED to ALIVE; each sample carries the count as of its arrival and SampleImpl.of passes it on. The test: write, dispose, write gives 0, 0 (sample without data) and 1. (commit e1b55167947) ### §2 SampleInfo: no_writers_generation_count

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103 (dds-1.2.pdf), table SampleInfo — “no_writers_generation_count: long”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getNoWritersGenerationCount), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.of)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::anInstanceWithoutWritersWrittenAgainCountsANoWritersGeneration

Status: done — The instance keeps noWritersGeneration; onWrite increments it when the instance changes from NOT_ALIVE_NO_WRITERS to ALIVE. The test: write, unregister, write gives 0, 0 and 1. (commit e1b55167947) ### §2 SampleInfo: sample_rank

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103 (dds-1.2.pdf), table SampleInfo — “sample_rank: long”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getSampleRank), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.of)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::theRanksAreMeasuredWithinTheSamplesOfOneInstanceInTheCollection, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::anInstanceDisposedAndWrittenAgainCountsADisposedGeneration

Status: done — After the selection collectLocked counts, per sample, the following samples of the same instance in the collection (sample_rank). Tested: two instances with two samples each (1, 0, 1, 0), three samples of one instance (2, 1, 0), a collection cut to one sample (0) and the order across instances with ordered_access. (commit e1b55167947) ### §2 SampleInfo: generation_rank

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103 (dds-1.2.pdf), table SampleInfo — “generation_rank: long”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getGenerationRank), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.of)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::anInstanceDisposedAndWrittenAgainCountsADisposedGeneration, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::anInstanceWithoutWritersWrittenAgainCountsANoWritersGeneration

Status: done — generation_rank is the sum of the generation counts of the last sample of the instance in the collection minus that of the sample (DDS 1.4 §2.2.2.5.1.6). The tests expect 1, 1, 0 for the samples before, at and after the rebirth. (commit e1b55167947) ### §2 SampleInfo: absolute_generation_rank

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103 (dds-1.2.pdf), table SampleInfo — “absolute_generation_rank: long”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getAbsoluteGenerationRank), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.of)

Status: done — absolute_generation_rank is the sum of the generation counts of the instance in the reader (the most recent sample received) minus that of the sample. The first test expects 1, 1, 0; the second that a forgotten and restarted instance has 0 again. (commit e1b55167947) ### §2 SampleInfo: source_timestamp

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103 (dds-1.2.pdf), table SampleInfo — “source_timestamp: Time_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.onWrite), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.deliverWire), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getSourceTimestamp), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsMessage.java (RtpsMessage.decode), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/SerializedSample.java (SerializedSample.sourceTimestampMillis)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::theSourceTimestampIsTheOneTheWriterGave, crates/java-omgdds/java/src/test/java/org/zerodds/sub/ReaderWireTest.java::theSourceTimestampAndTheWriterGuidOfTheDataReachTheSample, crates/java-omgdds/java/src/test/java/org/zerodds/sub/ReaderWireTest.java::theInfoTimestampThatPrecedesADataSubmessageIsItsSourceTimestamp

Status: done — In the process the reader takes the timestamp of the writer (Message.sourceTimestampMillis). Over RTPS RtpsMessage.decode reads the INFO_TS before DATA and DATA_FRAG (Time_t, fraction in 2^-32 s; InvalidateFlag), SerializedSample.sourceTimestampMillis carries it to deliverWire; without INFO_TS the arrival time applies. Tested: both write forms in the process, the value 77000 through deliverWire, the decoding 1700000000 s + 0x80000000/2^32 s = 1700000000500 ms (derived by hand) and the absence (-1). The sending part of the Java participant does not write the timestamp of the application into INFO_TS. (commit e1b55167947) ### §2 SampleInfo: instance_handle

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103 (dds-1.2.pdf), table SampleInfo — “instance_handle: InstanceHandle_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.onWrite), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.toSample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getInstanceHandle), crates/java-omgdds/java/src/main/java/org/zerodds/internal/InstanceKey.java (InstanceKey.toHandle)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::theInstanceHandleOfASampleIsTheOneTheReaderAndTheWriterLookUp, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::aKeyLongerThanSixteenOctetsKeepsItsOwnInstanceHandle

Status: done — InstanceKey.toHandle maps a key of up to 16 octets to these octets (zero padded), a longer one to its MD5 digest (DDSI-RTPS 2.5 §9.6.3.8); two keys that the earlier XOR fold mapped alike have different handles. Tested: the handle of a sample equals Reader.lookupInstance and Writer.lookupInstance, two 17-octet keys with the same fold give different handles. (commit e0f89cfd194) ### §2 SampleInfo: publication_handle

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103 (dds-1.2.pdf), table SampleInfo — “publication_handle: InstanceHandle_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::thePublicationHandleNamesTheWriterThatIsMatchedWithTheReader, crates/java-omgdds/java/src/test/java/org/zerodds/sub/ReaderWireTest.java::theSourceTimestampAndTheWriterGuidOfTheDataReachTheSample, crates/java-omgdds/java/src/test/java/org/zerodds/sub/ReaderWireTest.java::aSampleWithoutAnIdentityHasANilPublicationHandle

Status: done — In the process publication_handle is the handle of the writer (equal to an element of getMatchedPublications). Over RTPS deliverWire forms it from the writer GUID of the DATA (Values.of(guid), as getMatchedPublications names the endpoint GUID); without an identity it is NIL. (commit e1b55167947) ### §2 SampleInfo: valid_data

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.5, p. 103, §7.1.2.5.1.4, p. 76 (dds-1.2.pdf) — “valid_data: boolean”; “If the flag is set to FALSE, the DataSample contains no Data.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.markState), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getData)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicJoinTest.java::disposingAConstituentDisposesTheResultInstance

Status: done — markState creates a sample without data for dispose and unregister; Sample.getData() is then null (§7.7.2). On a MultiTopic reader (a DataReaderImpl) the test reads a sample with getData() == null and NOT_ALIVE_DISPOSED after dispose. The statement that no test checks null no longer applies; the unregister path is not tested on its own. (commit a2a9a67acb5)

§2 Programming interfaces of [DDS] 1.2: DataReaderListener

§2 DataReaderListener: on_data_available

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.7, p. 105 (dds-1.2.pdf), table DataReaderListener — “on_data_available (the_reader: DataReader): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderListener.java (DataReaderListener.onDataAvailable), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.fireDataAvailable)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::readerListenerFiresOnMatchAndOnEverySample, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::clearingTheListenerStopsDelivery, crates/java-omgdds/java/src/test/java/org/omg/dds/ReentrancyTest.java::aCallbackDoesNotHoldTheReaderMonitor, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::withoutASubscriberListenerTheReadersListenersAreCalledAndDataOnReadersStaysChanged, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::aStatusConditionTriggersOnlyOnTheStatusesItIsEnabledFor

Status: done — fireDataAvailable sets DATA_AVAILABLE (triggerStatus) and calls onDataAvailable per arriving sample and per sample without data (dispose, unregister) with the reader as source. If the subscriber (or the domain participant) has a listener with DATA_ON_READERS, the call goes to its onDataOnReaders instead. The tests check the count, the source, no call after setListener(null), that the call does not hold the reader monitor, and that a StatusCondition on DATA_AVAILABLE is true after write and false after take. (commit e1b55167947) ### §2 DataReaderListener: on_sample_rejected

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.7, p. 105 (dds-1.2.pdf), table DataReaderListener — “on_sample_rejected (the_reader: DataReader, status: SampleRejectedStatus): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderListener.java (DataReaderListener.onSampleRejected), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getSampleRejectedStatus)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aSampleBeyondMaxSamplesIsRejectedAndReportedToTheListener

Status: done — DataReaderImpl.onWrite calls rejectedByLimits; a rejected sample counts in SampleRejectedStatusImpl, fireRejectedAndLost calls onSampleRejected outside the monitor. ReaderStatusTest::aSampleBeyondMaxSamplesIsRejectedAndReportedToTheListener uses a reader with max_samples=1: the second write triggers the call with reason REJECTED_BY_SAMPLES_LIMIT, the reader keeps the first sample. (commit a2a9a67acb5) ### §2 DataReaderListener: on_liveliness_changed

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.7, p. 105 (dds-1.2.pdf), table DataReaderListener — “on_liveliness_changed (the_reader: DataReader, status: LivelinessChangedStatus): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderListener.java (DataReaderListener.onLivelinessChanged), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.evaluateLiveliness), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getLivelinessChangedStatus)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::livelinessChangedFiresWithoutPolling

Status: done — DataReaderImpl.evaluateLiveliness hands the status to onLivelinessChanged outside the monitor, triggered by the reader’s lease, without the application polling the status. The test sets a listener, writes once to a MANUAL_BY_TOPIC writer with a 30 ms lease and waits for the callback with getNotAliveCount() >= 1. No test checks the counters alive_count_change and not_alive_count_change. (commit a2a9a67acb5) ### §2 DataReaderListener: on_requested_deadline_missed

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.7, p. 105 (dds-1.2.pdf), table DataReaderListener — “on_requested_deadline_missed (the_reader: DataReader, status: RequestedDeadlineMissedStatus): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderListener.java (DataReaderListener.onRequestedDeadlineMissed), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.fireDeadlineMissed), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getRequestedDeadlineMissedStatus)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::requestedDeadlineMissedFiresWithoutPolling

Status: done — DataReaderImpl.fireDeadlineMissed calls onRequestedDeadlineMissed with the status outside the monitor, triggered by the lease, without the application polling. The test writes one sample with a 30 ms deadline and waits for the callback with getTotalCount() >= 1. The values of last_instance_handle and total_count_change are not checked. (commit a2a9a67acb5) ### §2 DataReaderListener: on_requested_incompatible_qos

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.7, p. 105 (dds-1.2.pdf), table DataReaderListener — “on_requested_incompatible_qos (the_reader: DataReader, status: RequestedIncompatibleQosStatus): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderListener.java (DataReaderListener.onRequestedIncompatibleQos), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.recordRequestedIncompatibleLocked), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getRequestedIncompatibleQosStatus)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aWriterThatOffersLessThanRequestedIsReportedToTheListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::requestedIncompatibleQosCountsTheRefusingPolicyAndResetsItsChange

Status: done — DataReaderImpl.onWriterPresenceChanged calls onRequestedIncompatibleQos outside the monitor when a writer with incompatible QoS appears. The test with a RELIABLE reader and a BEST_EFFORT writer expects one call with getLastPolicyClass() == Reliability.class and no matched writer. (commit a2a9a67acb5) ### §2 DataReaderListener: on_subscription_matched

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.7, p. 105 (dds-1.2.pdf), table DataReaderListener — “on_subscription_matched (the_reader: DataReader, status: SubscriptionMatchedStatus): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderListener.java (DataReaderListener.onSubscriptionMatched), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.onWriterPresenceChanged)

Status: done — DataReaderImpl.onWriterPresenceChanged calls onSubscriptionMatched when a writer appears and disappears, with the reader as source and the status. The first test checks call counts 1 and 2, currentCount 1 and 0, totalCount 1, and that the callback hands over the reader itself. The second checks that a writer in another partition causes no call. (commit a2a9a67acb5) ### §2 DataReaderListener: on_sample_lost

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.7, p. 105 (dds-1.2.pdf), table DataReaderListener — “on_sample_lost (the_reader: DataReader, status: SampleLostStatus): void”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderListener.java (DataReaderListener.onSampleLost), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getSampleLostStatus)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/sub/ReaderWireTest.java::sampleLostIsReportedToTheListener, crates/java-omgdds/java/src/test/java/org/zerodds/sub/ReaderWireTest.java::aGapInTheSequenceNumbersOfAWriterIsSampleLost

Status: done — DataReaderImpl.deliverWire reports the gap in the sequence numbers of a writer to onSampleLost through noteSequence and fireRejectedAndLost (outside the monitor). The test delivers sequence numbers 1 and 3 and expects one call with total 1 and change 1; an older sequence number triggers no further call. (commit e1b55167947)

§2 Programming interfaces of [DDS] 1.2: conditions and WaitSet

§2 Condition: get_trigger_value

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.7, p. 31–32 (dds-1.2.pdf), table Condition — “get_trigger_value: boolean”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Condition.java (Condition.getTriggerValue), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/QueryConditionImpl.java (QueryConditionImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/ReadConditionImpl.java (ReadConditionImpl.getTriggerValue), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/GuardConditionImpl.java (GuardConditionImpl.getTriggerValue), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/StatusConditionImpl.java (StatusConditionImpl.getTriggerValue)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theQueryConditionOfTheReaderTriggersOnAMatchingSample, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::aReadConditionIsTrueWhileTheReaderHoldsASampleInItsStates, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::aQueryConditionNeedsOneSampleThatIsInTheStatesAndSatisfiesTheExpression, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::aStatusConditionTriggersOnlyOnTheStatusesItIsEnabledFor, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionSetFromAnotherThreadEndsABlockedWaitAndIsReported, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aStatusConditionTriggersOnTheStatusItIsEnabledForAndHasItsEntityAsParent

Status: done — ReadConditionImpl.getTriggerValue (state masks, for the QueryCondition also the expression on the same sample), StatusConditionImpl.getTriggerValue (changed status flags of the enabled statuses) and GuardConditionImpl.getTriggerValue are tested. (commit e1b55167947) ### §2 WaitSet: creation without a factory

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.6, p. 30 (dds-1.2.pdf) — “WaitSet has no factory. It is created as an object directly by the natural means in each language binding (e.g., using “new” in C++ or Java).”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/WaitSet.java (WaitSet.newWaitSet), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.newWaitSet)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories, crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theQueryConditionOfTheReaderTriggersOnAMatchingSample

Status: done — WaitSet.newWaitSet(env) creates a WaitSetImpl directly through env.getSPI().newWaitSet(), without an entity factory. The first test checks that the SPI returns an object; the second creates a WaitSet through WaitSet.newWaitSet(reader.getEnvironment()) and attaches and detaches a condition. (commit 5041698cee3) ### §2 WaitSet: attach_condition

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.6, p. 30 (dds-1.2.pdf), table WaitSet — “attach_condition (a_condition: Condition): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/WaitSet.java (WaitSet.attachCondition), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl.attachCondition)

Status: done — WaitSetImpl.attachCondition records the condition (attaching twice has no effect) and registers the wait set with a GuardConditionImpl; status changes and arriving samples wake all wait sets through WaitSetImpl.conditionChanged. Tested: attaching, getConditions, waiting on guard, read and status conditions. (commit 5041698cee3) ### §2 WaitSet: detach_condition

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.6, p. 30 (dds-1.2.pdf), table WaitSet — “detach_condition (a_condition: Condition): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/WaitSet.java (WaitSet.detachCondition), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl.detachCondition)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionIsFalseAtFirstAndTheWaitSetKnowsWhatIsAttached, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::theWaitSetListsWhatIsAttachedAndADetachedConditionDoesNotEndAWait

Status: done — WaitSetImpl.detachCondition removes the condition and unregisters it from the GuardConditionImpl; a condition that is not attached gives PreconditionNotMetException. The test sets a detached guard condition to true: the wait does not end (timeout), after attaching again at once. A closed condition counts as not triggered in the wait set. (commit e1b55167947) ### §2 WaitSet: wait

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.6, p. 30 (dds-1.2.pdf), table WaitSet — “wait (inout: active_conditions: Condition [], timeout: Duration_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/WaitSet.java (WaitSet.waitForConditions), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl.waitForConditions), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl.await), crates/java-omgdds/java/src/main/java/org/zerodds/DdsAsync.java (DdsAsync.awaitSamples)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionSetFromAnotherThreadEndsABlockedWaitAndIsReported, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aSecondThreadWaitingOnTheSameWaitSetIsRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aWaitWithATimeoutEndsInATimeoutException, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aReadConditionFollowsTheStatesOfTheSamplesAndWakesTheWaitSet

Status: done — WaitSetImpl.await waits until an attached condition is true; guard conditions wake through signal, status and read conditions through WaitSetImpl.conditionChanged (from triggerStatus and on arriving samples). A second waiting thread gives PreconditionNotMetException, time running out TimeoutException. Tested: waking by setTriggerValue and by a write from another thread. (commit 5041698cee3) ### §2 WaitSet: result of wait

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.6, p. 30 (dds-1.2.pdf), table WaitSet — “inout: active_conditions: Condition []”

Status: done — WaitSetImpl.await puts all attached conditions with trigger value true into the collection passed in (cleared first). The tests check the size and assertSame on the expected condition, also with two conditions on the wait set of which one is false. (commit 5041698cee3) ### §2 WaitSet: get_conditions

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.6, p. 30 (dds-1.2.pdf), table WaitSet — “get_conditions (inout: attached_conditions: Condition []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/WaitSet.java (WaitSet.getConditions), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl.getConditions)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::theWaitSetListsWhatIsAttachedAndADetachedConditionDoesNotEndAWait, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionIsFalseAtFirstAndTheWaitSetKnowsWhatIsAttached

Status: done — getConditions returns a copy of the attached conditions. The test attaches a ReadCondition and a GuardCondition (two entries), detaches one (one entry, the detached one is missing). (commit e1b55167947) ### §2 GuardCondition: creation without a factory, initial value FALSE

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.8, p. 32 (dds-1.2.pdf) — “GuardCondition has no factory. It is created as an object directly by the natural means in each language binding (e.g., using “new” in C++ or Java). When first created the trigger_value is set to FALSE.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/GuardCondition.java (GuardCondition.newGuardCondition), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/GuardConditionImpl.java (GuardConditionImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionIsFalseAtFirstAndTheWaitSetKnowsWhatIsAttached

Status: done — GuardCondition.newGuardCondition(env) returns a GuardConditionImpl without an entity factory; the test expects getTriggerValue() == false right after creation. (commit 5041698cee3) ### §2 GuardCondition: set_trigger_value

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.8, p. 32 (dds-1.2.pdf), table GuardCondition — “set_trigger_value (value: boolean): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/GuardCondition.java (GuardCondition.setTriggerValue), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/GuardConditionImpl.java (GuardConditionImpl.setTriggerValue)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionSetFromAnotherThreadEndsABlockedWaitAndIsReported, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::theWaitSetListsWhatIsAttachedAndADetachedConditionDoesNotEndAWait

Status: done — GuardConditionImpl.setTriggerValue sets the value and wakes the attached wait sets (WaitSetImpl.attachCondition registers them). The test sets the value from a second thread; the blocked wait ends and reports the condition. (commit 5041698cee3) ### §2 StatusCondition: set_enabled_statuses and get_enabled_statuses

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.9, p. 32 (dds-1.2.pdf), table StatusCondition — “set_enabled_statuses (mask: StatusKind []): ReturnCode_t; get_enabled_statuses: StatusKind []”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/StatusCondition.java (StatusCondition.getEnabledStatuses), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/StatusConditionImpl.java (StatusConditionImpl.setEnabledStatuses), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/StatusConditionImpl.java (StatusConditionImpl.getEnabledStatuses)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::aStatusConditionTriggersOnlyOnTheStatusesItIsEnabledFor, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aStatusConditionTriggersOnTheStatusItIsEnabledForAndHasItsEntityAsParent

Status: done — The default of getEnabledStatuses is the set of all statuses (Status.allStatuses); setEnabledStatuses restricts the trigger value to the chosen statuses. The test: SUBSCRIPTION_MATCHED is changed, false after restricting to DATA_AVAILABLE, true after write, false after take. (commit e1b55167947) ### §2 StatusCondition: get_entity

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.1.9, p. 32 (dds-1.2.pdf), table StatusCondition — “get_entity: Entity”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/StatusCondition.java (StatusCondition.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/StatusConditionImpl.java (StatusConditionImpl.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.getStatusCondition)

Status: done — EntityBase.getStatusCondition().getParent() is the entity; both tests expect the reader with assertSame. (commit d23eff980f3) ### §2 ReadCondition: get_datareader

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.8, p. 106 (dds-1.2.pdf), table ReadCondition — “get_datareader: DataReader”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/ReadCondition.java (ReadCondition.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/ReadConditionImpl.java (ReadConditionImpl.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.createReadCondition)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aReadConditionFollowsTheStatesOfTheSamplesAndWakesTheWaitSet, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::aReadConditionIsTrueWhileTheReaderHoldsASampleInItsStates

Status: done — ReadConditionImpl.getParent returns the reader that created the condition; both tests expect it with assertSame. (commit d23eff980f3) ### §2 ReadCondition: get_sample_state_mask, get_view_state_mask, get_instance_state_mask

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.8, p. 106 (dds-1.2.pdf), table ReadCondition — “get_sample_state_mask: SampleStateKind []; get_view_state_mask: ViewStateKind []; get_instance_state_mask: InstanceStateKind []”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/ReadCondition.java (ReadCondition.getSampleStates), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/ReadConditionImpl.java (ReadConditionImpl.getSampleStates), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/ReadConditionImpl.java (ReadConditionImpl.getViewStates), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/ReadConditionImpl.java (ReadConditionImpl.getInstanceStates)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::aReadConditionIsTrueWhileTheReaderHoldsASampleInItsStates, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aReadConditionFollowsTheStatesOfTheSamplesAndWakesTheWaitSet

Status: done — createReadCondition returns exactly the state sets of the DataState passed in (a copy as of creation); the trigger value follows them: NOT_READ true until the first read, READ afterwards. (commit e1b55167947) ### §2 QueryCondition: get_query_expression

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.9, p. 107 (dds-1.2.pdf), table QueryCondition — “get_query_expression: string”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/QueryCondition.java (QueryCondition.getQueryExpression), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/QueryConditionImpl.java (QueryConditionImpl.getQueryExpression)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::aConditionKnowsTheFilterThatTriggersIt

Status: done — QueryConditionImpl.getQueryExpression returns the expression passed to DataReaderImpl.createQueryCondition. The test creates a condition with "value > %0" and checks that the returned expression is equal. (commit 2e0b194caf5) ### §2 QueryCondition: get_query_parameters and set_query_parameters

Spec: §2, p. 11; [DDS] 1.2 §7.1.2.5.9, p. 107 (dds-1.2.pdf), table QueryCondition — “get_query_parameters (out: query_parameters: string []): ReturnCode_t; set_query_parameters (query_parameters: string []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/QueryCondition.java (QueryCondition.getQueryParameters), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/QueryConditionImpl.java (QueryConditionImpl.setQueryParameters), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.createQueryCondition)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::theQueryParametersAreTheCurrentOnesWhenTheTriggerValueIsEvaluated, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::aQueryConditionNeedsOneSampleThatIsInTheStatesAndSatisfiesTheExpression, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::aQueryConditionOfTheReaderSelectsByItsExpressionAndTheNextInstanceKeepsIt

Status: done — The trigger value of a QueryCondition compiles expression and current parameters on every evaluation (createQueryCondition), so setQueryParameters takes effect at once and wakes wait sets. The test: seq > %0 with 5 and seq 3 false, with 2 true, with 3 false. (commit e1b55167947)

§2 Programming interfaces of [DDS] 1.2: built-in topics

§2 Built-in topics: DCPSParticipant

Spec: §2, p. 11; [DDS] 1.2 §7.1.5, p. 148 (dds-1.2.pdf) — “DCPSParticipant: key BuiltinTopicKey_t; user_data UserDataQosPolicy”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::aBuiltinReaderHasTheEntitiesThatExistedBeforeAndNoneOfItsOwnParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::theDiscoveredParticipantsAreTheOtherParticipantsOfTheDomainAndTheirUserData, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::theBuiltinReaderSeesTheUserDataChangeOfAnotherParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantBuiltinDataTest.java::aParticipantWithUserDataRoundTripsItsKeyAndUserData, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::theBuiltinReaderOfAParticipantSeesTheEntitiesOfTheDomain, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::getDiscoveredParticipantDataCarriesTheUserData

Status: done — ParticipantBuiltinTopicData has getKey and getUserData; BuiltinData.participant fills them from SPDP, BuiltinTopicWire encodes them. A participant with non-empty USER_DATA appears with that value in the reader on DCPSParticipant and in getDiscoveredParticipantData. Tests: ParticipantDiscoveryTest::aBuiltinReaderHasTheEntitiesThatExistedBeforeAndNoneOfItsOwnParticipant (USER_DATA {1, 2} in the reader of the built-in subscriber), ::theDiscoveredParticipantsAreTheOtherParticipantsOfTheDomainAndTheirUserData (getDiscoveredParticipantData), ::theBuiltinReaderSeesTheUserDataChangeOfAnotherParticipant (setQos announces new data), ParticipantBuiltinDataTest::aParticipantWithUserDataRoundTripsItsKeyAndUserData (wire round trip). (commit cd8f3d67ea9) ### §2 Built-in topics: DCPSTopic

Spec: §2, p. 11; [DDS] 1.2 §7.1.5, p. 148 (dds-1.2.pdf) — “DCPSTopic: key, name, type_name, durability, durability_service, deadline, latency_budget, liveliness, reliability, transport_priority, lifespan, destination_order, history, resource_limits, ownership, topic_data”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicBuiltinTopicData.java (TopicBuiltinTopicData), crates/java-omgdds/java/src/main/java/org/zerodds/topic/BuiltinData.java (BuiltinData.topic), crates/java-omgdds/java/src/main/java/org/zerodds/topic/BuiltinTopicWire.java (BuiltinTopicWire.encode)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantBuiltinDataTest.java::aTopicWithEveryPolicyOffItsDefaultRoundTripsTheKeyAndThePolicies, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::theBuiltinReaderOfAParticipantSeesTheEntitiesOfTheDomain, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::getDiscoveredTopicDataCarriesTheTopicQos

Status: done — The interface has all fields of the spec (key, name, type_name, durability, durability_service, deadline, latency_budget, liveliness, reliability, transport_priority, lifespan, destination_order, history, resource_limits, ownership, topic_data), BuiltinData.topic fills them. ParticipantBuiltinDataTest::aTopicWithEveryPolicyOffItsDefaultRoundTripsTheKeyAndThePolicies sets latency_budget 2 s, liveliness MANUAL_BY_PARTICIPANT with lease 6 s, lifespan 20 s, destination_order BY_SOURCE_TIMESTAMP, ownership EXCLUSIVE and reliability RELIABLE with max_blocking_time 3 s, encodes through BuiltinTopicWire and decodes; key, name, type name and each of these policies are checked. BuiltinTopicQosTest::everyBuiltinDataTypeRoundTripsItsQos covers name, durability, durability_service, deadline, history, resource_limits, transport_priority and topic_data. (commit 5041698cee3) ### §2 Built-in topics: DCPSPublication

Spec: §2, p. 11; [DDS] 1.2 §7.1.5, p. 149 (dds-1.2.pdf) — “DCPSPublication: key, participant_key, topic_name, type_name, durability, durability_service, deadline, latency_budget, liveliness, reliability, lifespan, user_data, ownership, ownership_strength, destination_order, presentation, partition, topic_data, group_data”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/PublicationBuiltinTopicData.java (PublicationBuiltinTopicData), crates/java-omgdds/java/src/main/java/org/zerodds/topic/BuiltinData.java (BuiltinData.publication), crates/java-omgdds/java/src/main/java/org/zerodds/topic/BuiltinTopicWire.java (BuiltinTopicWire.encode)

Status: done — All fields of the spec are in the interface and in BuiltinData.publication. The wire test checks parameter IDs and bytes for durability, deadline, latency_budget, liveliness, reliability, lifespan, user_data, ownership, ownership_strength, destination_order, partition, group_data, presentation, topic_name, type_name and both GUIDs; the round trip compares all fields after decoding, the reader test reads differing values from the built-in reader. ParticipantBuiltinDataTest::aPublicationKeepsItsOwnDurabilityServiceAndTheTopicDataOfItsTopic checks durability_service of the writer (history_depth 9, max_samples 80) and topic_data of the topic ({7, 7, 7}) after the round trip. (commit 5041698cee3) ### §2 Built-in topics: DCPSSubscription

Spec: §2, p. 11; [DDS] 1.2 §7.1.5, p. 150 (dds-1.2.pdf) — “DCPSSubscription: key, participant_key, topic_name, type_name, durability, deadline, latency_budget, liveliness, reliability, ownership, destination_order, user_data, time_based_filter, presentation, partition, topic_data, group_data”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/SubscriptionBuiltinTopicData.java (SubscriptionBuiltinTopicData), crates/java-omgdds/java/src/main/java/org/zerodds/topic/BuiltinData.java (BuiltinData.subscription), crates/java-omgdds/java/src/main/java/org/zerodds/topic/BuiltinTopicWire.java (BuiltinTopicWire.encode)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantBuiltinDataTest.java::aSubscriptionWithEveryPolicyOffItsDefaultRoundTripsTheKeysTheTypeAndThePolicies, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::theMatchedEntitiesAreDescribedWithTheirQos, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::sedpOfAnEndpointWithoutQosParametersTakesTheDefaults, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::theBuiltinReaderOfAParticipantSeesTheEntitiesOfTheDomain

Status: done — The interface and BuiltinData.subscription contain all fields of the spec. ParticipantBuiltinDataTest::aSubscriptionWithEveryPolicyOffItsDefaultRoundTripsTheKeysTheTypeAndThePolicies sets deadline 3 s, latency_budget 1 s, ownership EXCLUSIVE, destination_order BY_SOURCE_TIMESTAMP on the reader and group_data, presentation (scope TOPIC, coherent and ordered) and partition on the subscriber and checks after encoding and decoding key, participant_key, topic_name, type_name and each of these policies. BuiltinTopicQosTest::everyBuiltinDataTypeRoundTripsItsQos covers durability, liveliness, reliability, time_based_filter, user_data, partition and topic_data. (commit 5041698cee3)

§3 References

§3.1 [DDS] version 1.2

Spec: §3.1, p. 11 — “[DDS] Data Distribution Service for Real-Time Systems Specification, version 1.2 (OMG document formal/2007-01-01).”

Repo: —

Tests: —

Status: n/a (informative) — Reference. The items under §2 cite [DDS] 1.2 (.agent/spec/dds-1.2.txt). Comments in the Java code cite DDS 1.4 (e.g. ListenerTest: “DDS 1.4 §2.2.4.1”, DataReaderImpl); ZeroDDS itself follows DDS 1.4 (.agent/spec/dds-dcps-1.4.txt). ### §3.1 [DDS-CCM] 1.0 Beta 1

Spec: §3.1, p. 11 — “[DDS-CCM] DDS for Lightweight CCM, version 1.0 Beta 1 (OMG document ptc/2009-02-02).”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosProviderImpl.java (QosProviderImpl)

Tests: —

Status: n/a (informative) — Reference. The Java binding requires nothing of its own from [DDS-CCM]; QosProviderImpl mentions the XML QoS libraries of [DDS-CCM] in its class comment. No comparison with Beta 1 was made. (commit 2e0b194caf5) ### §3.1 [DDS-XTypes] 1.0 Beta 1

Spec: §3.1, p. 11 — “[DDS-XTypes] Extensible and Dynamic Topic Types for DDS, version 1.0 Beta 1 (OMG document ptc/2010-05-12).”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/Extensibility.java (Extensibility.Kind)

Tests: —

Status: n/a (informative) — Reference. Where needed, the comparison is with XTypes 1.3 (.agent/spec/dds-xtypes-1.3.txt). org.omg.dds.type.Extensibility.Kind still names the extensibility EXTENSIBLE_EXTENSIBILITY. ### §3.1 [Java-MAP] IDL to Java 1.3

Spec: §3.1, p. 11 — “[Java-MAP] IDL to Java Language Mapping, Version 1.3 (OMG document formal/2008-01-11)”

Repo: crates/lang-rules/src/adapter/java.rs (adapter::java)

Tests: —

Status: n/a (informative) — Reference. The repository holds IDL4 to Java 1.0 (.agent/spec/idl4-java-1.0.txt, coverage in docs/spec-coverage/idl4-java-1.0.md). For public fields the Java codegen cites “§1.5.10 of the OMG mapping” (crates/lang-rules/src/adapter/java.rs, comment on public fields). ### §3.1 [Java-Lang] The Java Language Specification, Third Edition

Spec: §3.1, p. 12 — “[Java-Lang] The Java Language Specification, Third Edition, published by Addison Wesley in 2005 with ISBN 0321246780”

Repo: crates/java-omgdds/java/pom.xml (properties/profile java8), crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java (PubSubLoopbackTest.Reading)

Tests: —

Status: n/a (informative) — Reference to Java 5. The module compiles with maven.compiler.source 17 and, in the profile java8, with release 8 (crates/java-omgdds/java/pom.xml); the tests need Java 17 (records, e.g. PubSubLoopbackTest.Reading). (commit 5536e2abcac) ### §3.1 [XML] 1.1, Second Edition

Spec: §3.1, p. 12 — “[XML] Extensible Markup Language (XML), version 1.1, Second Edition (W3C recommendation, August 2006).”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosProviderImpl.java (QosProviderImpl)

Tests: —

Status: n/a (informative) — Reference for the XML QoS profiles (§7.3.5.4). The Java binding reads XML: QosProviderImpl parses through javax.xml.parsers.DocumentBuilderFactory with external DTD and schema access disabled. Which XML version applies was not checked. (commit 2e0b194caf5) ### §3.2 [JMS] 1.1 (non-normative)

Spec: §3.2, p. 12 — “The following non-normative references are provided for informational purposes. • [JMS] Java Message Service Specification, version 1.1 (Sun Microsystems, http://java.sun.com/products/jms/ docs.html).”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative.

§4 Terms and Definitions

Spec: §4, p. 12 — “The mandatory portion of the DDS specification used to provide the functionality required for an application to publish and subscribe to the values of data objects.”

Repo: —

Tests: —

Status: n/a (informative) — Term definition. ### §4 Data Distribution Service (DDS)

Spec: §4, p. 12 — “An OMG distributed data communications specification that allows Quality of Service policies to be specified for data timeliness and reliability. It is independent of implementation languages.”

Repo: —

Tests: —

Status: n/a (informative) — Term definition. ### §4 Data Local Reconstruction Layer

Spec: §4, p. 12 — “The optional portion of the DDS specification used to provide the functionality required for an application for direct access to data exchanged at the DCPS layer. This latter builds upon the DCPS layer.”

Repo: —

Tests: —

Status: n/a (informative) — Term definition. ### §4 Java Archive (JAR)

Spec: §4, p. 12 — “A zip file, whose name ends in the suffix .jar, that contains the compiled Java class files and other artifacts that comprise a Java library.”

Repo: —

Tests: —

Status: n/a (informative) — Term definition. ### §4 Java Runtime Environment (JRE)

Spec: §4, p. 12 — “The environment within which Java applications execute. The JRE consists of an executing instance of a JVM, a set of class libraries, and potentially other components.”

Repo: —

Tests: —

Status: n/a (informative) — Term definition. ### §4 Java Virtual Machine (JVM)

Spec: §4, p. 12 — “An abstract computing machine capable of executing interpreted and/or compiled Java byte code. JVM implementations typically take the form of executables that run as processes under operating systems, but this style of implementation is not mandatory.”

Repo: —

Tests: —

Status: n/a (informative) — Term definition. ### §4 Platform-Independent Model (PIM)

Spec: §4, p. 12 — “An abstract definition of a facility, often expressed with the aid of formal or semi-formal modeling languages such as OMG UML, that does not depend on any particular implementation technology.”

Repo: —

Tests: —

Status: n/a (informative) — Term definition. ### §4 Platform-Specific Model (PSM)

Spec: §4, p. 13 — “A concrete definition of a facility, typically based on a corresponding PIM, in which all implementation-specific dependencies have been resolved.”

Repo: —

Tests: —

Status: n/a (informative) — Term definition.

§5 Symbols

§5 No symbols

Spec: §5, p. 13 — “This specification does not define any symbols or abbreviations.”

Repo: —

Tests: —

Status: n/a (informative) — No requirement.

§6 Additional Information

§6.1 No change to other OMG specs

Spec: §6.1, p. 13 — “This specification does not extend or modify any existing OMG specifications.”

Repo: —

Tests: —

Status: n/a (informative) — Statement about the specification. ### §6.2 Dependency on Java SE 5, further constraints by the implementation

Spec: §6.2, p. 13 — “This specification depends on version 5 of the Java Standard Edition platform. Service implementations may impose additional constraints; the nature and scope of these, if any, are unspecified.”

Repo: crates/java-omgdds/java/pom.xml (properties/profile java8)

Tests: —

Status: n/a (informative) — Statement about the specification and permission for further constraints. ZeroDDS compiles with Java 17 or, in the profile java8, with release 8 (crates/java-omgdds/java/pom.xml); Java 5 to 7 is not a target. (commit 5536e2abcac) ### §6.2 Rationale: Java SE instead of Java EE or Java ME

Spec: §6.2, p. 13 — “Design Rationale (non-normative) As of the publication of this specification, Java SE remains the predominant platform for the development and deployment of DDS Java applications.”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative. ### §6.3 Acknowledgements

Spec: §6.3, p. 13 — “The following companies submitted this specification: • Real-Time Innovations, Inc. (RTI) • PrismTech”

Repo: —

Tests: —

Status: n/a (informative) — Acknowledgement.

§7.1 Specification Organization

§7.1 Organized by the modules of [DDS]

Spec: §7.1, p. 15 — “This specification is organized according to the module defined by the DDS specification and the types and operations defined within them.”

Repo: —

Tests: —

Status: n/a (informative) — Organisation of the specification.

§7.2 General Concerns and Conventions

§7.2 Cross-cutting definitions

Spec: §7.2, p. 15 — “This sub clause defines those elements of this specification that cut across multiple DDS modules.”

Repo: —

Tests: —

Status: n/a (informative) — Introduction; the provisions follow in §7.2.1 to §7.2.6. ### §7.2.1 Packages with the prefix org.omg.dds

Spec: §7.2.1, p. 15 — “This PSM is defined in a set of Java packages, the names of each beginning with the prefix org.omg.dds. Each of these contains a Java interface or abstract class for each type in the corresponding DDS module.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/BuiltinTypeSupports.java (BuiltinTypeSupports.KeyedStringTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/BuiltinTypeSupports.java (BuiltinTypeSupports.KeyedBytesTypeSupport), crates/java-omgdds/java/src/main/java/org/omg/dds/type/typeobject/TypeObject.java (TypeObject), crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/TypeObjectModel.java (TypeObjectModel)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/rpc/RpcInheritanceTest.java::ddsObjectCarriesTheOneOperationTheClauseNames, crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::readerListenerFiresOnMatchAndOnEverySample, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreBuiltinKeyedTest.java::keyedStringHasTheDelimitedCdr2Layout, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreBuiltinKeyedTest.java::keyedBytesHasTheDelimitedCdr2Layout, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreBuiltinKeyedTest.java::aTopicOfKeyedStringCarriesTheSamplesOfTwoInstances, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreBuiltinKeyedTest.java::aTopicOfKeyedBytesCarriesTheOctets, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreBuiltinKeyedTest.java::theKeyHashIsTheMd5OfTheBigEndianKey, crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectModelTest.java::everyInterfaceOfThePackageIsImplementedAndAnObjectOfItComesBackOverTheWire, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreApiShapeTest.java::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource

Status: done — The packages org.omg.dds.* contain, for every type of the DDS modules, an interface or abstract class of the OMG source (184 files; CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource compares them with the SHA-256 of the source). KeyedString and KeyedBytes are topic types: TypeSupportResolver.resolve returns BuiltinTypeSupports.KeyedStringTypeSupport and KeyedBytesTypeSupport (XTypes 1.3 Annex E: appendable, @key string key); CoreBuiltinKeyedTest writes and reads one topic each with two instances, the key hash octets are derived from XTypes 1.3 §7.6.8 (MD5 over the key in big-endian, not checked against another implementation). The types of org.omg.dds.type.typeobject are implemented as objects (TypeObjectModel) and reachable through getType() of the built-in data. (commit b4bf3fa978e) ### §7.2.1 One interface or abstract class per type

Spec: §7.2.1, p. 15 — “Each of these contains a Java interface or abstract class for each type in the corresponding DDS module.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity), crates/java-omgdds/java/src/main/java/org/omg/dds/core/DDSObject.java (DDSObject), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/rpc/RpcInheritanceTest.java::thePsmSampleIsAnInterface, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreApiShapeTest.java::everyTypeOfTheOmgApiIsAnInterfaceOrAbstractExceptTheConcreteOnesOfTheOmgSource

Status: done — CoreApiShapeTest checks by reflection for the packages core, core.policy, core.status, core.event, domain, pub, sub, topic, type, type.builtin, type.dynamic and type.typeobject that every public type is an interface, enum, annotation or abstract class. The concrete classes of the OMG source are exempt: ServiceConfigurationException, ServiceInitializationException, the six *Adapter classes, TypeId, TypeKind.Values, DataRepresentation.Id and the MemberId classes. The package org.omg.dds.rpc is not covered. (commit d23eff980f3) ### §7.2.1 Entities, value types, policies and statuses as an interface or abstract class

Spec: §7.2.1, p. 15 — “Each of these contains a Java interface or abstract class for each type in the corresponding DDS module.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Time.java (Time), crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Reliability.java (Reliability)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreApiShapeTest.java::entitiesValueTypesPoliciesAndStatusesAreInterfacesOrAbstractClasses

Status: done — CoreApiShapeTest checks that DomainParticipant, DomainParticipantFactory, Publisher, Subscriber, Topic, DataWriter, DataReader are interfaces or abstract classes, Time, Duration and InstanceHandle abstract classes, QosPolicy and the policies interfaces, LivelinessChangedStatus and PublicationMatchedStatus abstract classes. (commit 5041698cee3) ### §7.2.1 All packages in one JAR omgdds.jar

Spec: §7.2.1, p. 15 — “All of these packages, and the types within them, are packaged into a single JAR file, omgdds.jar (see Annex A: Java JAR Library File).”

Repo: crates/java-omgdds/java/pom.xml

Tests: —

Status: n/a (informative) — Describes the artefact of the OMG (Annex A: omgdds.jar). ZeroDDS builds org.zerodds:omgdds (crates/java-omgdds/java/pom.xml, no finalName, so omgdds-<version>.jar; read from the POM, not built). The JAR holds the classes under org.omg.dds, org.zerodds and, through build-helper-maven-plugin, the sources of crates/idl-java/runtime and runtime/java/src/main/java. Annex A permits shipping the implementation in the same JAR. (commit 5536e2abcac) ### §7.2.1 The service implements the abstract types concretely

Spec: §7.2.1, p. 15 — “All those types that are abstract—including interfaces and abstract classes—are intended to be implemented concretely by the Service implementation.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl), crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/TypeObjectModel.java (TypeObjectModel), crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/TypeObjectBuilder.java (TypeObjectBuilder)

Status: done — ServiceEnvironmentImpl and the classes under org/zerodds (DomainParticipantFactoryImpl, DomainParticipantImpl, PublisherImpl, SubscriberImpl, TopicImpl, DataWriterImpl, DataReaderImpl, SampleImpl, TimeImpl, DurationImpl, InstanceHandleImpl, WaitSetImpl) implement the abstract types. QuickstartApiTest.byteArrayQuickstartRoundTrip creates participant, topic, writer and reader through the environment and reads a Sample back. The 26 interfaces under org/omg/dds/type/typeobject (TypeObject, StructureType, UnionType, …) are implemented by TypeObjectModel, over a TypeObject of XTypes 1.1 Annex B that is taken from the IDL of the annex in idl/typeobject and translated with idlc into an XCDR1 codec; TypeObjectModelTest builds a library with a type of every kind, sends it through the codec and finds objects of all 26 interfaces again. (commit b4bf3fa978e) ### §7.2.1 Additional properties in subtypes of the implementation permitted

Spec: §7.2.1, p. 15 — “In addition, the subtypes defined by the implementation may expose additional implementation-specific properties and operations; however, the nature of these, if any, is undefined.”

Repo: —

Tests: —

Status: n/a (informative) — Permission. The implementation classes live under org.zerodds (e.g. DataReaderImpl.isClosed, the methods of the internal interface InProcessBus.Endpoint). The rule on where extensions go is in the item “§7.2.6 No extensions in org.omg.dds or sub-packages”. ### §7.2.1 Rationale: several packages

Spec: §7.2.1, p. 15 — “Design Rationale (non-normative) This PSM divides the types it defines into multiple packages, rather than colocating them in a single package […]”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative. ### §7.2.2 Accept value types of another implementation

Spec: §7.2.2, p. 15 — “It shall be possible to pass an instance of any value type (see 7.2.3) created by one DDS implementation to a method implemented by another. For example, the method DataWriter.write optionally accepts an argument of type InstanceHandle; this object may have been created by the same DDS implementation that created the DataWriter or by another DDS implementation.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/InstanceHandleImpl.java (InstanceHandleImpl.bytesOf), crates/java-omgdds/java/src/main/java/org/zerodds/internal/InstanceKey.java (InstanceKey.of), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.dispose), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.unregisterInstance), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.resolve)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::aHandleOfAnotherImplementationIsAcceptedEverywhere, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::aNilHandleOfAnotherImplementationIsTheNilHandle, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::aTimeOfAnotherImplementationIsComparedByValue, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::aDurationOfAnotherImplementationIsAccepted, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreForeignValuesTest.java::aTimeOfAnotherImplementationIsTheSourceTimestamp, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreForeignValuesTest.java::aForeignHandleThatNamesNoInstanceOfTheWriterIsABadParameter, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreForeignValuesTest.java::aNilHandleOfAnotherImplementationNamesTheInstanceOfTheSample

Status: done — InstanceHandleImpl.bytesOf accepts an InstanceHandle of another implementation: nil through isNil() gives 16 zero bytes, otherwise the first 16 bytes of the SHA-256 over class name and Java serialization (fallback toString()); equal foreign values give equal bytes, equals and compareTo are total. ModifiableTimeImpl.copyFrom and the writer operations accept foreign values (Time and Duration through getTime/getDuration). DataWriterImpl.resolve and checkHandle test nil through isNil(), a foreign handle without an instance gives IllegalArgumentException (DDS 1.4 §2.2.2.4.2.11: invalid handle, BAD_PARAMETER; aForeignHandleThatNamesNoInstanceOfTheWriterIsABadParameter), a handle of another instance than that of the sample gives PreconditionNotMetException. The foreign classes in the test are written against the abstract classes of the OMG API. (commit 4c28bc52254) ### §7.2.2 Write samples of a foreign DataReader with the own DataWriter

Spec: §7.2.2, p. 15 — “It shall be possible to read or take samples from a DataReader provided by one DDS implementation and immediately write them using a DataWriter provided by another DDS implementation, provided that the samples are of a DDS type compatible with that DataWriter.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.write)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreForeignValuesTest.java::aSampleOfAnotherImplementationIsWrittenWithItsTimestampAndHandle, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreForeignValuesTest.java::aSampleOfAnotherImplementationIsDisposedAndUnregistered

Status: done — CoreForeignValuesTest implements a Sample and a ModifiableInstanceHandle of another implementation and passes getData(), getSourceTimestamp() and getInstanceHandle() to write, dispose and unregisterInstance of a ZeroDDS DataWriter. The reader sees the timestamp in milliseconds from the foreign value (1 700 000 000 123 ms from 1 700 000 000 123 000 000 ns), dispose gives NOT_ALIVE_DISPOSED. A foreign handle that names no instance of the writer gives PreconditionNotMetException. (commit 26684105d79) ### §7.2.2 Copying when passing between implementations

Spec: §7.2.2, p. 15 — “Note that passing an object from one implementation to another may incur a performance cost, as the “receiving” implementation may have to copy the object in question before operating on it.”

Repo: —

Tests: —

Status: n/a (informative) — Note. ### §7.2.2 Foreign concrete types: exception or undefined behaviour permitted

Spec: §7.2.2, p. 16 — “Otherwise, unless elsewhere noted in this specification, a Service implementation may raise an exception or behave in an undefined way if it encounters a concrete type defined by another party.”

Repo: —

Tests: —

Status: n/a (informative) — Permission. ZeroDDS uses it: PublisherImpl.codecOf throws UnsupportedOperationException for a TypeSupport of another implementation, InstanceHandleImpl.bytesOf throws IllegalArgumentException. ### §7.2.3 Types without a PIM factory: abstract class with static factory methods new<ClassName>

Spec: §7.2.3, p. 16 — “These latter types—those without PIM-defined factory construction methods—serve as their own factories. Each is represented as an abstract class with one or more static factory methods. These methods are named according to the convention new in order to resemble constructor invocations and are amenable to use with the Java 5 static import facility.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Time.java (Time.newTime), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Duration.java (Duration.newDuration), crates/java-omgdds/java/src/main/java/org/omg/dds/core/InstanceHandle.java (InstanceHandle.newInstanceHandle), crates/java-omgdds/java/src/main/java/org/omg/dds/core/WaitSet.java (WaitSet.newWaitSet), crates/java-omgdds/java/src/main/java/org/omg/dds/core/GuardCondition.java (GuardCondition.newGuardCondition), crates/java-omgdds/java/src/main/java/org/omg/dds/core/QosProvider.java (QosProvider.newQosProvider), crates/java-omgdds/java/src/main/java/org/omg/dds/type/TypeSupport.java (TypeSupport.newTypeSupport), crates/java-omgdds/java/src/main/java/org/omg/dds/type/builtin/KeyedString.java (KeyedString.newKeyedString), crates/java-omgdds/java/src/main/java/org/omg/dds/type/builtin/KeyedBytes.java (KeyedBytes.newKeyedBytes)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionIsFalseAtFirstAndTheWaitSetKnowsWhatIsAttached, crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theQueryConditionOfTheReaderTriggersOnAMatchingSample, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::theStaticFactoryMethodsOfTheAbstractValueTypesGoThroughTheSpi, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aNewInstanceHandleIsNilAndIsFilledByCopyFrom, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aTypeSupportIsRegisteredUnderTheFullyQualifiedNameOfTheType, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::keyedStringAndKeyedBytesMutatorsReturnTheObject, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aQosProviderOfAnUnsupportedUriSchemeIsRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::aNegativeInstantInAnyUnitIsInvalid

Status: done — The static factory methods go through the SPI: Time.newTime, Duration.newDuration, InstanceHandle.newInstanceHandle, QosProvider.newQosProvider, TypeSupport.newTypeSupport, KeyedString.newKeyedString and KeyedBytes.newKeyedBytes; CoreSpiTest and CoreValuesTest call each and check value and environment. TypeSupport.newTypeSupport(Class, env) in org/omg/dds/type/TypeSupport.java registered the type under type.getClass().getName() (java.lang.Class); the defect was in the OMG source, the file now uses type.getName() (PSM 7.5.1). (commit 7431a7d599c) ### §7.2.3 PIM deletion operations as close on the product

Spec: §7.2.3, p. 16 — “This PSM maps the factory deletion methods of the DDS PIM (e.g., DomainParticipant.delete_publisher) to close methods on the “product” interfaces themselves (e.g., Publisher.close).”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.close), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/topic/ContentFilteredTopicImpl.java (ContentFilteredTopicImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/topic/MultiTopicImpl.java (MultiTopicImpl.close)

Status: done — ContentFilteredTopicImpl.close and MultiTopicImpl.close record the closed state (isClosed); SubscriberImpl.createDataReader refuses a closed description with AlreadyClosedException. A ContentFilteredTopic of another implementation now gives UnsupportedOperationException (before: AlreadyClosedException). (commit 0eb300902f5) ### §7.2.3 Closing closes the contained objects

Spec: §7.2.3, p. 16 — “Closing an Entity implicitly closes all of its contained objects, if any. For example, closing a Publisher also closes all of its contained DataWriters.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.closeContainedEntities)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCascadeTest.java::publisherCloseClosesItsWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCascadeTest.java::participantCloseClosesContainedEntities, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::closeContainedEntitiesClosesThemWithoutClosingTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreCloseTest.java::closingASubscriberClosesItsReaders, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreCloseTest.java::closingTheParticipantClosesTheReadersAndWritersInIt, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreCloseTest.java::aClosedContentFilteredTopicRefusesToCreateAReader, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreCloseTest.java::aClosedMultiTopicRefusesToCreateAReader

Status: done — CoreCloseTest closes a Subscriber and a DomainParticipant and checks with Qos.isClosed that their DataReader objects (and the DataWriter) are closed; ContentFilteredTopic.close and MultiTopic.close act through the closed flag. (commit 0eb300902f5) ### §7.2.3 Rationale: the close pattern

Spec: §7.2.3, p. 16 — “Design Rationale (non-normative) The close destruction design pattern is intended to be familiar to those developers who have used java.io stream APIs and/or [JMS] […]”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative. ### §7.2.3 Recommendation to call close

Spec: §7.2.3, p. 16 — “Users of this PSM are recommended to call close once they are finished using such heavyweight objects.”

Repo: —

Tests: —

Status: n/a (informative) — Recommendation to applications. ### §7.2.3 Automatic closing of objects no longer in use permitted

Spec: §7.2.3, p. 16 — “In addition, implementations may automatically close objects that the JRE deems to be no longer in use—for example, they may call close() in an Object.finalize() override—subject to the following restrictions:”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.retain), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.retain)

Tests: —

Status: n/a (informative) — Permission. ZeroDDS closes nothing automatically: under crates/java-omgdds/java/src/main/java there is neither finalize nor Cleaner (text search; the only hit for WeakReference is GuardConditionImpl, which closes nothing with it). A DataReader that the application drops without close() stays registered at the InProcessBus (read from the code, not measured). (commit 166d5873d4a) ### §7.2.3 An object directly referenced is still in use

Spec: §7.2.3, p. 16 — “• Any object to which the application has a direct reference is still in use.”

Repo: —

Tests: —

Status: n/a (informative) — Restriction on automatic closing, which ZeroDDS does not perform (previous item). ### §7.2.3 An entity with a listener is still in use

Spec: §7.2.3, p. 16 — “• Any entity with a non-null listener is still in use.”

Repo: —

Tests: —

Status: n/a (informative) — Restriction on automatic closing, which ZeroDDS does not perform. ### §7.2.3 An explicitly retained object is still in use

Spec: §7.2.3, p. 16 — “• Any object that has been explicitly retained is still in use.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.retain), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.retain)

Tests: —

Status: n/a (informative) — Restriction on automatic closing, which ZeroDDS does not perform. Entity.retain() exists; EntityBase.retain has no effect because nothing is closed automatically. (commit 166d5873d4a) ### §7.2.3 The creator of an object in use is still in use

Spec: §7.2.3, p. 16 — “• The creator of any object that is still in use is itself still in use.”

Repo: —

Tests: —

Status: n/a (informative) — Restriction on automatic closing, which ZeroDDS does not perform. ### §7.2.4 DataReader and DataWriter operations reentrant

Spec: §7.2.4, p. 16 — “All DataReader and DataWriter operations shall be reentrant.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.enable), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.enable), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.fireDataAvailable)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReentrancyTest.java::aCallbackDoesNotHoldTheReaderMonitor, crates/java-omgdds/java/src/test/java/org/omg/dds/ReentrancyTest.java::aCallbackDoesNotHoldTheWriterMonitor, crates/java-omgdds/java/src/test/java/org/omg/dds/ReentrancyTest.java::concurrentEnableRegistersTheEndpointOnce, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreConcurrencyTest.java::severalThreadsWriteTakeAndRegisterOnOneWriterAndReader, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreConcurrencyTest.java::closingAWriterWhileOthersWriteLeavesOnlyAlreadyClosed

Status: done — CoreConcurrencyTest calls write, registerInstance, take and close from several threads on one DataWriter and DataReader: four writer threads of 50 samples each, two registration threads, one take thread; the sum of the samples taken is 200. A second test closes the writer while four threads write and one thread calls take; only AlreadyClosedException remains. The code is unchanged (the qos field is volatile). (commit ac048fe0dc7) ### §7.2.4 Topic, Publisher, Subscriber and DomainParticipant operations reentrant, except close

Spec: §7.2.4, p. 16 — “All Topic (and other TopicDescription extension interfaces), Publisher, Subscriber, and DomainParticipant operations shall be reentrant with the exception that close may not be called on a given object concurrently with any other call of any method on that object or on any contained object.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreConcurrencyTest.java::severalThreadsCreateEntitiesAndSetTheQosOfOnePublisherAndSubscriber

Status: done — The qos field of PublisherImpl, SubscriberImpl, TopicImpl, DataWriterImpl and DataReaderImpl is volatile. CoreConcurrencyTest creates writer, reader and topic ten times each from eight threads on one publisher, subscriber and participant while setting the QoS of publisher and subscriber; all 240 objects differ, the QoS left over is that of one of the threads. (commit ac048fe0dc7) ### §7.2.4 ServiceEnvironment and DomainParticipantFactory operations reentrant, except DomainParticipantFactory.close

Spec: §7.2.4, p. 16 — “All ServiceEnvironment and DomainParticipantFactory operations shall be reentrant with the exception that DomainParticipantFactory.close may not be called on a given object concurrently with any other call of any method on that object or on any contained object.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.getSPI), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.ZeroSPI.getParticipantFactory), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::severalThreadsGetOneParticipantFactoryOfAnEnvironment

Status: done — ServiceEnvironmentImpl.ZeroSPI.getParticipantFactory creates the factory with double-checked locking (volatile field, synchronized). CoreSpiTest calls DomainParticipantFactory.getInstance(env) in 20 rounds from eight threads started together each and checks that exactly one instance comes back. (commit 7431a7d599c) ### §7.2.4 WaitSet and Condition operations reentrant

Spec: §7.2.4, p. 16 — “All WaitSet and Condition (including Condition extension interfaces) operations shall be reentrant with the exception that their close methods may not be called on a given object concurrently with any other call of any method on that object.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/GuardConditionImpl.java (GuardConditionImpl.setTriggerValue), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/StatusConditionImpl.java (StatusConditionImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/ReadConditionImpl.java (ReadConditionImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionSetFromAnotherThreadEndsABlockedWaitAndIsReported, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aSecondThreadWaitingOnTheSameWaitSetIsRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aStatusConditionTriggersOnTheStatusItIsEnabledForAndHasItsEntityAsParent, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aReadConditionFollowsTheStatesOfTheSamplesAndWakesTheWaitSet, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreConcurrencyTest.java::conditionsAreAttachedAndDetachedWhileAThreadWaits

Status: done — CoreConcurrencyTest attaches and detaches conditions, calls getConditions and StatusCondition.setEnabledStatuses in 100 rounds while another thread waits in waitForConditions; then GuardCondition.setTriggerValue(true) ends the wait and the active set contains the condition. The code is unchanged. (commit fc054ce9926) ### §7.2.4 In a listener call only the entity that raised it

Spec: §7.2.4, p. 17 — “Code within a DDS listener callback may not safely call any method on any DDS Entity but the one on which the status change occurred.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.fireDataAvailable)

Tests: —

Status: n/a (informative) — Restriction on the application code inside the callback; the specification asks nothing of the implementation here. ZeroDDS calls the callbacks without the monitor of the reader or writer (DataReaderImpl.fireDataAvailable), so calls from the callback remain possible; ReentrancyTest.aCallbackDoesNotHoldTheReaderMonitor checks this for close() from another thread. (commit 166d5873d4a) ### §7.2.4 Methods of value types may be non-reentrant

Spec: §7.2.4, p. 17 — “Any method of any value type may be non-reentrant.”

Repo: —

Tests: —

Status: n/a (informative) — Permission. ### §7.2.4 Stronger guarantees permitted

Spec: §7.2.4, p. 17 — “A vendor may choose to provide stronger guarantees than the rules above, but if so, those guarantees are unspecified.”

Repo: —

Tests: —

Status: n/a (informative) — Permission. ### §7.2.4 Rationale: close and listeners

Spec: §7.2.4, p. 17 — “Design Rationale (non-normative) • Objects that are likely to “own” mutexes within their implementation need not permit close invocations currently with other method invocations. […]”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative. ### §7.2.5 Names in camelCase

Spec: §7.2.5, p. 17 — “This PSM maps the underscore-formatted names of the DDS PIM and IDL PSM (such as get_qos) into conventional Java “camel-case” names (such as getQos).”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.registerInstance), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.lookupInstance), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.getRequestedDeadlineMissedStatus), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.getSubscriptionMatchedStatus), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory.createParticipant)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::registerAndLookupInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::requestedDeadlineMissedIsRaised, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::statusIsReadableWithoutAListener

Status: done — The operations under org/omg/dds carry the PIM names in camel case; a search for method names with an underscore finds none. The tests call registerInstance, lookupInstance, getRequestedDeadlineMissedStatus, getSubscriptionMatchedStatus, getPublicationMatchedStatus and createParticipant. (commit c060b572340) ### §7.2.5 Mutators set<PropertyName> return the object

Spec: §7.2.5, p. 17 — “Properties defined by the DDS PIM are expressed as sets of accessor and mutator methods. […] Mutators are named set (for example, the mutator for a property “Foo” would be named setFoo.) They take a single argument—the new value of the property—and return the enclosing object in order to facilitate method chaining.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicData.java (DynamicData.setInt32Value), crates/java-omgdds/java/src/main/java/org/omg/dds/type/builtin/KeyedString.java (KeyedString.setKey), crates/java-omgdds/java/src/main/java/org/omg/dds/type/builtin/KeyedBytes.java (KeyedBytes.setValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/BuiltinTypes.java (BuiltinTypes.KeyedStringImpl), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.setQos), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.setListener)

Status: done — CoreSpiTest chains KeyedString.setKey(..).setValue(..) and KeyedBytes.setKey(..).setValue(..) (both return the object) and checks copy and copyFrom behavior. The void mutators follow the OMG source (Annex B), which deviates from the text of 7.2.5. (commit 5041698cee3) ### §7.2.5 Accessor get<PropertyName>() for unmodifiable values and references

Spec: §7.2.5, p. 17 — “Accessors for properties that are either of unmodifiable objects (such as those of primitive types, primitive box types, or strings) or pointers to the internal state of an object are named get. (For example, the accessor for an integer property “Foo” would be named getFoo.) They take no arguments.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.getDomainId), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/Topic.java (Topic.getName), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.getListener), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.getTopicDescription), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getData)

Status: done — The accessors for strings, numbers and references are named get<PropertyName> and take no argument (DomainParticipant.getDomainId, Topic.getName, DataReader.getListener, Sample.getData; declarations read). ListenerTest.readerListenerFiresOnMatchAndOnEverySample calls getListener, getCurrentCount and getTotalCount, QuickstartApiTest.byteArrayQuickstartRoundTrip calls getData. (commit 5041698cee3) ### §7.2.5 Accessor get<PropertyName>() for policies, statuses, time and samples

Spec: §7.2.5, p. 17 — “Accessors for properties that are either of unmodifiable objects […] are named get.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/History.java (History.getKind), crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/History.java (History.getDepth), crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/SubscriptionMatchedStatus.java (SubscriptionMatchedStatus.getTotalCount), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Time.java (Time.getTime), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getSampleState)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::reliabilityAndHistoryQosDefaults, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::timeFromMillisRoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::statusIsReadableWithoutAListener, crates/java-omgdds/java/src/test/java/org/omg/dds/rpc/RpcInheritanceTest.java::anRpcSampleIsAPsmSample

Status: done — Policies, statuses, Time, Duration, InstanceHandle and Sample have accessors get<PropertyName> (History.getKind, getDepth, SubscriptionMatchedStatus.getTotalCount, getCurrentCountChange, Time.getTime, Sample.getSampleState, getViewState, getInstanceState, getInstanceHandle, getSourceTimestamp). The tests call these accessors and check the values. (commit 5041698cee3) ### §7.2.5 Accessor for mutable properties with a pre-allocated object

Spec: §7.2.5, p. 17 — “Accessors for properties that are of mutable types, and that may change asynchronously after they are retrieved, are named get. They take a pre-allocated object of the property type as their first argument, the contents of which shall be overwritten by the method. To facilitate method chaining, these methods also return a reference to this argument. […] An Entity’s status is an example of a property of this kind.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.getCurrentTime), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.getCurrentTime), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getKeyValue), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getKeyValue), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.getSubscriptionMatchedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/KeyFields.java (KeyFields.copy), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TopicTypeSupport.java (TopicTypeSupport.copyKey)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::getCurrentTimeFillsTheContainerOrReturnsANewOne, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreKeyValueTest.java::aWriterFillsTheKeyFieldsOfTheHolderOnly, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreKeyValueTest.java::aReaderFillsTheKeyFieldsOfTheHolderOnly, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreKeyValueTest.java::aHandleOfNoInstanceIsABadParameter, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreKeyValueTest.java::lookupInstanceFillsTheHandleItIsGiven, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreKeyValueTest.java::theKeyHolderOfABuiltInKeyedTypeKeepsItsValue, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreKeyValueTest.java::aTypeWithoutAKeyHasNoKeyValue, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreForeignValuesTest.java::lookupInstanceFillsAModifiableHandleOfAnotherImplementation

Status: done — DataWriterImpl.getKeyValue(T, InstanceHandle) and DataReaderImpl.getKeyValue(T, InstanceHandle) overwrite only the key fields of keyHolder and return it (TopicTypeSupport.copyKey, default KeyFields.copy through @Key; without a @Key field all fields are copied; KeyedString/KeyedBytes copy key). The reader remembers the first sample with data for each instance (Instance.keySample). A handle without an instance gives IllegalArgumentException. lookupInstance(ModifiableInstanceHandle, T) fills the handle it is given, a foreign one too. (commit f8e64a1ab3d) ### §7.2.6 Extensions through own interfaces from the factory methods permitted

Spec: §7.2.6, p. 17 — “Implementation-specific extensions to the types specified by this PSM are by definition unspecified. However, implementations may provide such a capability by providing extended implementation-specific interfaces and returning instances of these interfaces from the specified factory methods.”

Repo: —

Tests: —

Status: n/a (informative) — Permission. ZeroDDS returns classes under org.zerodds from the factory methods (e.g. DomainParticipantImpl), without public additional interfaces of its own. ### §7.2.6 No extensions in org.omg.dds or its sub-packages

Spec: §7.2.6, p. 17 — “Implementations shall not place their extensions, if any, in any interface or class in the package org.omg.dds or in any other package whose name begins with that prefix.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/DDSException.java (DDSException), runtime/java/src/main/java/org/zerodds/ddsrpc/RequesterImpl.java (RequesterImpl), runtime/java/src/main/java/org/zerodds/ddsrpc/ServerImpl.java (ServerImpl), runtime/java/src/main/java/org/zerodds/ddsrpc/ZeroDdsParticipant.java (ZeroDdsParticipant), runtime/java/src/main/java/org/zerodds/ddsrpc/RequesterImpl.java (RequesterImpl), runtime/java/src/main/java/org/zerodds/ddsrpc/ReplierImpl.java (ReplierImpl), runtime/java/src/main/java/org/zerodds/ddsrpc/ServerImpl.java (ServerImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreApiShapeTest.java::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource, crates/rpc/tests/java_rpc_runtime.rs::the_java_rpc_runtime_and_the_generated_services_run_together, crates/lang-rules/tests/java_psm_mapping.rs::an_interface_under_the_psm_mapping_compiles

Status: done — The files under crates/java-omgdds/java/src/main/java/org/omg/dds are the files of the OMG source, without an exception; CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource checks the set of files and their SHA-256 on every run without the source being in the working tree. The binding puts no class of its own in org.omg.dds. The implementation classes of DDS-RPC (RequesterImpl, ReplierImpl, ServerImpl, ClientParamsImpl, ServiceParamsImpl, RequesterParamsImpl, ReplierParamsImpl, Matching, ZeroDdsParticipant, RawTypeSupport) are in org.zerodds.ddsrpc (runtime/java/src/main/java/org/zerodds/ddsrpc); the name org.zerodds.rpc belongs to the IDL-Java runtime. The interfaces and factory methods in org.omg.dds.rpc (RequesterParams.create, RPCRuntime) call them; the RPC code generator writes extends org.zerodds.ddsrpc.RequesterImpl<…> (interface_java.rs, RPC_IMPL). The tests of the RPC areas (java_rpc_runtime, java_enhanced_codec, type_pair_java, interface_bindings, java_psm_mapping) read the classes from the new path. (commit ed38a660164)

§7.3 Infrastructure Module

§7.3 Two packages `org.omg.dds.core` and `org.omg.dds.core.policy`

Spec: §7.3, p. 18 — “This PSM realizes the Infrastructure Module from the DDS specification with two packages: org.omg.dds.core and org.omg.dds.core.policy. The latter contains all QoS policy classes, since a given QoS policy may apply to multiple DDS Entity types. The former contains all other Infrastructure types, including for example Entity and Condition base interfaces.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/, crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/

Status: done — org.omg.dds.core holds DDSObject, Entity, ServiceEnvironment, InstanceHandle, Time, Duration, Condition, WaitSet, GuardCondition, StatusCondition, EntityQos, QosProvider and the exceptions; org.omg.dds.core.policy holds the policies with PolicyFactory. The statuses are in org.omg.dds.core.status, the events in org.omg.dds.core.event, as in the OMG sources. The tests import and use the types from these packages; RpcInheritanceTest checks the package name of DDSObject. (commit 5041698cee3) ### §7.3 Rationale: two packages, the name “core”

Spec: §7.3, p. 18 — “Design Rationale (non-normative) These two packages have been made distinct from one another for two reasons: […]”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative. ### §7.3.1 ServiceEnvironment as the root of all objects, creation through an internal SPI

Spec: §7.3.1, p. 18 — “A ServiceEnvironment object represents an instantiation of a Service implementation within a JVM. It is the “root” for all other DDS objects and assists in their creation by means of an internal service-provider interface.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.getSPI), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory.getInstance), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.getEnvironment)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentBootstrapBySystemProperty, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::getInstanceRejectsNullEnvironment, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aNewInstanceHandleIsNilAndIsFilledByCopyFrom, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::theInvalidTimeAndANegativeTimeOfTheSpiAreInvalid, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aQosProviderOfAnUnsupportedUriSchemeIsRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aTypeSupportIsRegisteredUnderTheFullyQualifiedNameOfTheType, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::keyedStringAndKeyedBytesMutatorsReturnTheObject, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::everyEntityAnswersWithTheEnvironmentItWasCreatedIn

Status: done — CoreSpiTest calls newInstanceHandle, invalidTime, newQosProvider, newTypeSupport, newKeyedString and newKeyedBytes of the SPI and checks with assertSame(env, x.getEnvironment()) participant, publisher, subscriber, topic, writer, reader, status condition, time and sample of an environment made by new ServiceEnvironmentImpl(). DataWriterImpl and DataReaderImpl take the environment of their parent (before: Values.getDefaultEnvironment()). (commit 26684105d79) ### §7.3.1 All stateful types implement DDSObject (getEnvironment)

Spec: §7.3.1, p. 18 — “All stateful types in this PSM implement an interface DDSObject, through a getServiceEnvironment method on which they can provide access to the ServiceEnvironment from which they are ultimately derived.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/DDSObject.java (DDSObject.getEnvironment)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/rpc/RpcInheritanceTest.java::ddsObjectCarriesTheOneOperationTheClauseNames

Status: done — The operation is named getEnvironment in the OMG sources. DDSObject has exactly this one operation; the test checks name, return type ServiceEnvironment, parameter count 0 and the package org.omg.dds.core. Which types extend the interface is covered by the item “§7.3.1 Entities, factory and value types implement DDSObject”. (commit 5041698cee3) ### §7.3.1 Entities, factory and value types implement DDSObject

Spec: §7.3.1, p. 18 — “All stateful types in this PSM implement an interface DDSObject […]”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.getEnvironment), crates/java-omgdds/java/src/main/java/org/zerodds/core/InstanceHandleImpl.java (InstanceHandleImpl.getEnvironment), crates/java-omgdds/java/src/main/java/org/omg/dds/core/DDSException.java (DDSException)

Status: done — DDSException has implements DDSObject like the OMG source; the concrete exceptions in org.zerodds.core return the environment given at construction or the default environment from getEnvironment(). CoreSpiTest checks assertSame(env, x.getEnvironment()) for participant, publisher, subscriber, topic, writer and reader; CoreExceptionsTest checks it for the exceptions. (commit b1b698778d6) ### §7.3.1 ServiceEnvironment implements DDSObject and returns this

Spec: §7.3.1, p. 18 — “(ServiceEnvironment itself implements this interface; a ServiceEnvironment always returns this from its getServiceEnvironment operation.)”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.getEnvironment)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/rpc/RpcInheritanceTest.java::aServiceEnvironmentReturnsItself

Status: done — ServiceEnvironment implements DDSObject, getEnvironment() is final and returns this. The test checks assignability to DDSObject and that a subclass (RPCRuntime) returns itself. (commit 5041698cee3) ### §7.3.1 Possible without static state, several implementations side by side

Spec: §7.3.1, p. 18 — “The ServiceEnvironment class allows implementations to avoid the presence of static state, if desired. It also allows multiple DDS implementations—or multiple versions of the “same” implementation—to potentially coexist within the same Java run-time environment.”

Repo: —

Tests: —

Status: n/a (informative) — Permission and purpose. ZeroDDS holds static state: ServiceEnvironmentImpl.DEFAULT, InProcessBus.INSTANCE, DurabilityService.INSTANCE, RtpsParticipant.BY_DOMAIN, ReflectionTypeSupport.CACHE. Two ServiceEnvironments in the same JVM therefore share bus and durability data (read from the code, not measured). The DomainParticipantFactory, in contrast, is separate per environment (item “§7.3.1 ServiceEnvironment as root of all objects”). ### §7.3.1 The application’s first step: create a ServiceEnvironment

Spec: §7.3.1, p. 18 — “A DDS application’s first step is to instantiate a ServiceEnvironment, which represents the DDS implementation that it will use. From there, it can create all of its additional DDS objects.”

Repo: —

Tests: —

Status: n/a (informative) — Describes the flow of an application. In ZeroDDS the step is required: DomainParticipantFactory.getInstance(ServiceEnvironment) has no counterpart without an argument in the OMG sources and throws a NullPointerException for null (QuickstartApiTest.getInstanceRejectsNullEnvironment). ### §7.3.1 ServiceEnvironment is abstract

Spec: §7.3.1, p. 18 — “The ServiceEnvironment class is abstract.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::theServiceEnvironmentIsAbstract

Status: done — CoreSpiTest checks Modifier.isAbstract(ServiceEnvironment.class.getModifiers()), that getSPI is abstract and that ServiceEnvironmentImpl is a concrete subclass. (commit 5041698cee3) ### §7.3.1 createInstance looks up the subclass through a system property

Spec: §7.3.1, p. 18 — “To avoid compile-time dependencies on concrete ServiceEnvironment implementations, an application can instantiate a ServiceEnvironment by means of a static createInstance method on the ServiceEnvironment class. This method looks up a concrete ServiceEnvironment subclass using a Java system property containing the name of that subclass.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.IMPLEMENTATION_CLASS_NAME_PROPERTY), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.createInstance)

Status: done — createInstance(ClassLoader) reads the system property org.omg.dds.serviceClassName; createInstance(String, Map, ClassLoader) reads a freely named property and throws ServiceConfigurationException if it is missing or the class cannot be loaded. The file is byte-identical to the OMG source. The first test sets the property to org.zerodds.ServiceEnvironmentImpl and gets a usable environment, the second checks the unknown class; no test covers a missing property. (commit 5041698cee3) ### §7.3.1 Subclass with its own name from the implementation

Spec: §7.3.1, p. 18 — “This subclass must be provided by implementers and will therefore have an implementation-specific name.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentBootstrapBySystemProperty

Status: done — org.zerodds.ServiceEnvironmentImpl extends ServiceEnvironment has a public no-argument constructor and one with Map. The test loads the class by this name through createInstance and uses the result; it does not check the runtime type explicitly. (commit 7d991374fd4) ### §7.3.1 Factory method for DynamicTypeFactory

Spec: §7.3.1, p. 18 — “ServiceEnvironment provides factory methods for the following objects: DynamicTypeFactory, WaitSet, GuardCondition, TypeSupport, Time, Duration, and InstanceHandle.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.getTypeFactory), crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicTypeFactory.java (DynamicTypeFactory.getInstance), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.ZeroSPI.getTypeFactory)

Status: done — ServiceProviderInterface.getTypeFactory returns the DynamicTypeFactoryImpl of the environment, DynamicTypeFactory.getInstance(env) calls it. The first test calls getTypeFactory().getPrimitiveType(INT_32_TYPE), the second creates a sequence type through DynamicTypeFactory.getInstance(ENV). (commit 7d991374fd4) ### §7.3.1 Factory method for WaitSet

Spec: §7.3.1, p. 18 — “ServiceEnvironment provides factory methods for the following objects: […] WaitSet […]”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/WaitSet.java (WaitSet.newWaitSet), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.ZeroSPI.newWaitSet), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl)

Status: done — ServiceProviderInterface.newWaitSet and WaitSet.newWaitSet(env) return a WaitSetImpl. The first test checks that newWaitSet() returns an object; WaitSetTest uses WaitSet.newWaitSet(ENV) and checks attaching, detaching, waiting with a time limit (TimeoutException) and being woken by a condition. (commit fc054ce9926) ### §7.3.1 Factory method for GuardCondition

Spec: §7.3.1, p. 18 — “ServiceEnvironment provides factory methods for the following objects: […] GuardCondition […]”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.newGuardCondition), crates/java-omgdds/java/src/main/java/org/omg/dds/core/GuardCondition.java (GuardCondition.newGuardCondition), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/GuardConditionImpl.java (GuardConditionImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionIsFalseAtFirstAndTheWaitSetKnowsWhatIsAttached, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionSetFromAnotherThreadEndsABlockedWaitAndIsReported

Status: done — ServiceEnvironment.ServiceProviderInterface.newGuardCondition returns a GuardConditionImpl; GuardCondition.newGuardCondition(env) delegates to it. The tests check that the factory returns an object, that the condition is false at first and that setting it from another thread ends a blocked WaitSet. (commit fc054ce9926) ### §7.3.1 Factory method for TypeSupport

Spec: §7.3.1, p. 18 — “ServiceEnvironment provides factory methods for the following objects: […] TypeSupport […]”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.newTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.newTypeSupport), crates/java-omgdds/java/src/main/java/org/omg/dds/type/TypeSupport.java (TypeSupport.newTypeSupport)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aTypeSupportIsRegisteredUnderTheFullyQualifiedNameOfTheType

Status: done — org/omg/dds/type/TypeSupport.newTypeSupport(Class, ServiceEnvironment) calls the source with type.getClass().getName(), which is “java.lang.Class” for every type; ServiceEnvironmentImpl.newTypeSupport reads that name as “no name given” and registers the type under type.getName(). CoreSpiTest creates a TypeSupport through TypeSupport.newTypeSupport and ServiceProviderInterface.newTypeSupport and checks the name ([B for byte[], the given name otherwise). The file is that of the OMG source (CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource). (commit 7431a7d599c) ### §7.3.1 Factory method for Time

Spec: §7.3.1, p. 18 — “ServiceEnvironment provides factory methods for the following objects: […] Time […]”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.newTime), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.invalidTime), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.newTime), crates/java-omgdds/java/src/main/java/org/zerodds/core/TimeImpl.java (TimeImpl.split), crates/java-omgdds/java/src/main/java/org/zerodds/core/TimeImpl.java (TimeImpl.shift)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::timeAndDurationKeepTheirValueAndGetAnEnvironment, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::getCurrentTimeFillsTheContainerOrReturnsANewOne, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::aNegativeInstantInAnyUnitIsInvalid, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::theInvalidTimeEqualsItselfAndOrdersBeforeEveryValidTime, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::addAndSubtractMoveTheInstantAndKeepItNormalised, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::theInvalidTimeAndANegativeTimeOfTheSpiAreInvalid

Status: done — TimeImpl.split returns the invalid instant (seconds -1, nanoseconds 0) for every negative value in every unit; ModifiableTimeImpl.add/subtract compute through TimeImpl.shift with normalization and an invalid result before the epoch. Tests: newTime(-5, u) invalid for all TimeUnit values, invalidTime() invalid, newTime(0, NANOSECONDS) valid. (commit 4c28bc52254) ### §7.3.1 Factory method for Duration

Spec: §7.3.1, p. 18 — “ServiceEnvironment provides factory methods for the following objects: […] Duration […]”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.newDuration), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.infiniteDuration), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.zeroDuration), crates/java-omgdds/java/src/main/java/org/zerodds/core/DurationImpl.java (DurationImpl.of)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::timeAndDurationKeepTheirValueAndGetAnEnvironment, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::durationInfiniteRecognized

Status: done — newDuration(long, TimeUnit), infiniteDuration() and zeroDuration() return DurationImpl objects of the environment; DurationImpl.of maps the magnitude Long.MAX_VALUE to infinite. The tests check newDuration(7, SECONDS) after serialization, isInfinite() and isZero() of the two factories, and getDuration(SECONDS) == Long.MAX_VALUE for infinite. (commit 819bfcb46cb) ### §7.3.1 Factory method for InstanceHandle

Spec: §7.3.1, p. 18 — “ServiceEnvironment provides factory methods for the following objects: […] and InstanceHandle.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.newInstanceHandle), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.nilHandle), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.newInstanceHandle)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::instanceHandleNilDetected, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aNewInstanceHandleIsNilAndIsFilledByCopyFrom

Status: done — CoreSpiTest creates a ModifiableInstanceHandle through newInstanceHandle(), checks isNil(), fills it with copyFrom (value 42 in the fourth byte) and checks equality, not nil and a different object for each call. (commit 819bfcb46cb) ### §7.3.1 Helper functions allStatusKinds and noStatusKinds

Spec: §7.3.1, p. 18 — “It also provides helper functions allStatuses and noStatuses to create special instances of Status objects.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.allStatusKinds), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.noStatusKinds), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.allStatusKinds)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories

Status: done — The helper functions are named allStatusKinds() and noStatusKinds() and sit on the ServiceProviderInterface. allStatusKinds holds the 13 status classes (ServiceEnvironmentImpl.allStatusKinds), noStatusKinds is empty. The test checks size 13 and the empty set; it does not check the membership of the single classes. (commit 7d991374fd4) ### §7.3.2 ReturnCode_t as Java exceptions

Spec: §7.3.2, p. 18 — “The PSM maps the ReturnCode_t type from the DDS PIM into a combination of standard Java exceptions (where their semantics match those expressed in the PIM) and new exception classes defined by this PSM.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/DDSException.java (DDSException), crates/java-omgdds/java/src/main/java/org/zerodds/core/AlreadyClosedException.java (AlreadyClosedException), crates/java-omgdds/java/src/main/java/org/zerodds/core/NotEnabledException.java (NotEnabledException), crates/java-omgdds/java/src/main/java/org/zerodds/core/PreconditionNotMetException.java (PreconditionNotMetException)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::writeOnAClosedWriterThrowsAlreadyClosed, crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aNotEnabledWriterRefusesToWrite, crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aNullArgumentIsABadParameter, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aWaitWithATimeoutEndsInATimeoutException, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::getDiscoveredParticipantDataCarriesTheUserData, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::theServiceProvidesAConcreteClassForEveryTable71ExceptionAndForRetcodeError, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::aSampleTheEncoderRejectsFailsWithRetcodeError, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::anEncodingBeyondTheLimitFailsWithOutOfResources, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::anEnabledWriterRefusesToChangeAnImmutablePolicy, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::aHistoryDepthAboveMaxSamplesPerInstanceIsInconsistent, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::aTopicOfAnotherImplementationIsUnsupported, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::resumePublicationsHasToMatchASuspend

Status: done — The mapping of Table 7.1 through exception classes (org.omg.dds.core.*Exception, concrete classes in org.zerodds.core) has a test for every row: ERROR, UNSUPPORTED, IMMUTABLE_POLICY, INCONSISTENT_POLICY, OUT_OF_RESOURCES, PRECONDITION_NOT_MET, ALREADY_DELETED, NOT_ENABLED, BAD_PARAMETER. ILLEGAL_OPERATION has the class and the reflection test but no operation that raises it (DDS 1.4 names none). TIMEOUT: see the item on RETCODE_TIMEOUT (partial). (commit b1b698778d6) ### §7.3.2 All exceptions unchecked except TimeoutException

Spec: §7.3.2, p. 18 — “With the exception of java.util.concurrent.TimeoutException, all exceptions are unchecked (that is, they extend java.lang.RuntimeException directly or indirectly).”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::everyPsmExceptionIsAnUncheckedDdsException, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::onlyTimeoutExceptionIsChecked, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::ddsExceptionIsADdsObjectAndUnchecked

Status: done — CoreExceptionsTest checks for all seven classes of Table 7.1, DDSException, ServiceConfigurationException and ServiceInitializationException that they extend RuntimeException, and that TimeoutException (java.util.concurrent) is checked and declared by WaitSet.waitForConditions, DataWriter.write and DomainParticipant.findTopic. (commit 7f18142b5e1) ### §7.3.2 Own exceptions based on DDSException in org.omg.dds.core, abstract

Spec: §7.3.2, p. 19 — “The exception classes defined by this PSM extend the base class DDSException. All of the PSM-defined exception classes are defined in the package org.omg.dds.core. All of these classes are abstract so as not to specify the representation of state; implementations shall provide concrete implementations.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/DDSException.java (DDSException), crates/java-omgdds/java/src/main/java/org/omg/dds/core/AlreadyClosedException.java (AlreadyClosedException), crates/java-omgdds/java/src/main/java/org/omg/dds/core/IllegalOperationException.java (IllegalOperationException), crates/java-omgdds/java/src/main/java/org/omg/dds/core/NotEnabledException.java (NotEnabledException), crates/java-omgdds/java/src/main/java/org/omg/dds/core/PreconditionNotMetException.java (PreconditionNotMetException), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ImmutablePolicyException.java (ImmutablePolicyException), crates/java-omgdds/java/src/main/java/org/omg/dds/core/InconsistentPolicyException.java (InconsistentPolicyException), crates/java-omgdds/java/src/main/java/org/omg/dds/core/OutOfResourcesException.java (OutOfResourcesException)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::everyPsmExceptionIsAnUncheckedDdsException, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::everyTable71ExceptionIsAnAbstractDdsExceptionOfOrgOmgDdsCore, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::theExceptionsKeepTheSerialVersionUidOfTheOmgSource

Status: done — CoreExceptionsTest checks by reflection that the seven classes of Table 7.1 are abstract, lie in org.omg.dds.core and extend DDSException directly, that DDSException is abstract and that org.zerodds.core has a concrete class for each. The serialVersionUID of all exceptions of the OMG API now equals the OMG source (before: -1L to -5L on five classes and another value on ServiceInitializationException). (commit b1b698778d6) ### §7.3.2 Table 7.1: RETCODE_OK

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_OK | Normal return; no exception.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — DataWriter.write is void; a successful call returns without an exception. The test writes two samples without an exception and takes both at the reader. (commit f31b6fa11b5) ### §7.3.2 Table 7.1: RETCODE_NO_DATA

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_NO_DATA | An informational state (e.g., a Boolean result) attached to a normal return; no exception.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.take), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.take)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::volatileDoesNotReplayToLateJoiner

Status: done — Without samples take(List) returns an empty list without an exception; there is no ReturnCode.NO_DATA. The test takes at a running reader without data and checks length 0. (commit f31b6fa11b5) ### §7.3.2 Table 7.1: RETCODE_ERROR

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_ERROR | DDSException”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::aSampleTheEncoderRejectsFailsWithRetcodeError, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::theServiceProvidesAConcreteClassForEveryTable71ExceptionAndForRetcodeError

Status: done — org.zerodds.core.ErrorException is the concrete class of DDSException (RETCODE_ERROR). DataWriterImpl.serialize reports an encoder that rejects the sample (XcdrException) as ErrorException with the cause. Tests: the class is concrete with the superclass DDSException; a writer with such a type support throws ErrorException and stays usable. (commit 26684105d79) ### §7.3.2 Table 7.1: RETCODE_BAD_PARAMETER

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_BAD_PARAMETER | java.lang.IllegalArgumentException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/HistoryImpl.java (HistoryImpl.withDepth), crates/java-omgdds/java/src/main/java/org/zerodds/core/InstanceHandleImpl.java (InstanceHandleImpl), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getMatchedSubscriptionData)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::historyDepthMustBeNonNegative, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::instanceHandleRejectsWrongLength, crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aNullArgumentIsABadParameter

Status: done — A negative History depth, a handle of the wrong length and a null handle in getMatchedSubscriptionData throw IllegalArgumentException. The three tests check exactly this exception; further tests check it for invalid filter expressions, type descriptors and MultiTopic expressions (ContentFilterTest, DynamicTypeReflectionTest, MultiTopicTest). (commit f31b6fa11b5) ### §7.3.2 Table 7.1: RETCODE_BAD_PARAMETER for null

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_BAD_PARAMETER | java.lang.IllegalArgumentException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getMatchedSubscriptionData), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getMatchedPublicationData), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory.getInstance), crates/java-omgdds/java/src/main/java/org/zerodds/core/Args.java (Args.require)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aNullArgumentIsABadParameter, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::theMatchedEntitiesAreDescribedWithTheirQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::getInstanceRejectsNullEnvironment, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreForeignValuesTest.java::aForeignHandleThatNamesNoInstanceOfTheWriterIsABadParameter, crates/java-omgdds/java/src/test/java/org/omg/dds/NullArgumentTest.java::aNullArgumentIsIllegalArgumentExceptionAndNeverNullPointerException

Status: done — getMatchedSubscriptionData(null) and getMatchedPublicationData(null) throw IllegalArgumentException. DomainParticipantFactory.getInstance(null) throws NullPointerException (source of the OMG API: env.getSPI()); QuickstartApiTest.getInstanceRejectsNullEnvironment fixes that. A handle that names no instance of the writer is IllegalArgumentException (CoreForeignValuesTest::aForeignHandleThatNamesNoInstanceOfTheWriterIsABadParameter, DDS 1.4 §2.2.2.4.2.11). Every operation of DomainParticipant, Publisher, Subscriber, Topic, DataWriter and DataReader with an object argument throws IllegalArgumentException (Table 7.1: RETCODE_BAD_PARAMETER) for null and no NullPointerException (org.zerodds.core.Args.require at the entry of the operations: names, types, QoS, topics, handles, timestamps, units, conditions, samples). null keeps a meaning where DDS or the PSM gives it one: a listener and a status set of “none”, a key holder or a list that is created, the nil handle in write, dispose and unregisterInstance, null as the selector of read and take. NullArgumentTest calls through reflection every operation of these six interfaces with null for each parameter (109 calls) and demands IllegalArgumentException. (commit eb7377e1f7e) ### §7.3.2 Table 7.1: RETCODE_TIMEOUT

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_TIMEOUT | java.util.concurrent.TimeoutException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl.waitForConditions), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.findTopic), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.waitForAcknowledgments), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.waitForHistoricalData), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.awaitWireHistorySpace), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/RtpsParticipant.java (RtpsParticipant.WireWriter.awaitHistorySpace), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.awaitHistoricalData)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aWaitWithATimeoutEndsInATimeoutException, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::findTopicReturnsTheTopicAndTimesOutOtherwise, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterWireAckTest.java::aSampleNobodyAcknowledgesIsATimeoutException, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterWireAckTest.java::aWriteBeyondMaxSamplesWaitsForAcknowledgmentsAndTimesOut, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderWireHistoricalDataTest.java::theCallIsATimeoutExceptionWhileTheWriterAnnouncedNothing, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::keepAllWithMaxSamplesPerInstanceTimesOutForTransientLocal

Status: done — java.util.concurrent.TimeoutException is thrown by WaitSetImpl.waitForConditions(Duration), DomainParticipantImpl.findTopic, DataWriterImpl.waitForAcknowledgments and PublisherImpl.waitForAcknowledgments (readers in other processes acknowledge with ACKNACK), DataReaderImpl.waitForHistoricalData (RTPS branch) and by write when RESOURCE_LIMITS are reached and max_blocking_time runs out: for a TRANSIENT_LOCAL writer on the samples it keeps, for a reliable KEEP_ALL writer with max_samples on the samples that readers in other processes have not acknowledged yet (WireWriter.awaitHistorySpace). A BEST_EFFORT writer does not wait and reports OutOfResourcesException. (commit 1d0691890fa) ### §7.3.2 Table 7.1: RETCODE_UNSUPPORTED

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_UNSUPPORTED | java.lang.UnsupportedOperationException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosProviderImpl.java (QosProviderImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.createDataReader), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.codecOf)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::aTopicOfAnotherImplementationIsUnsupported, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::aTopicDescriptionOfAnotherImplementationIsUnsupported, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aQosProviderOfAnUnsupportedUriSchemeIsRefused

Status: done — UnsupportedOperationException is tested for a URI scheme other than file (QosProviderImpl), for a topic and a topic description of another implementation (PublisherImpl.codecOf, SubscriberImpl.codecOf) and for a content-filtered topic of another implementation. SubscriberImpl.createDataReader threw AlreadyClosedException for the latter; it is now UnsupportedOperationException. (commit b315020c678) ### §7.3.2 Table 7.1: RETCODE_ALREADY_DELETED

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_ALREADY_DELETED | AlreadyClosedException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.write), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.take), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.createDataWriter), crates/java-omgdds/java/src/main/java/org/zerodds/core/AlreadyClosedException.java (AlreadyClosedException)

Status: done — After close(), write, read, take, createDataWriter, createDataReader, createPublisher and createTopic throw AlreadyClosedException (subclass of org.omg.dds.core.AlreadyClosedException). The tests check the exception for closed writers, readers, publishers, subscribers and participants. (commit f31b6fa11b5) ### §7.3.2 Table 7.1: RETCODE_ILLEGAL_OPERATION

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_ILLEGAL_OPERATION | IllegalOperationException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.suspendPublications), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.endCoherentChanges), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.endAccess)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::resumePublicationsHasToMatchASuspend, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::endCoherentChangesHasToMatchABeginAndTheCallsNest, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::endAccessHasToMatchABeginAccess, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::theServiceProvidesAConcreteClassForEveryTable71ExceptionAndForRetcodeError

Status: done — Per DDS 1.4 2.2.2.4.1.9, 2.2.2.4.1.11 and 2.2.2.5.2.9, resume_publications without suspend_publications, end_coherent_changes without begin_coherent_changes and end_access without begin_access are PRECONDITION_NOT_MET, and suspend_publications and begin_coherent_changes can be nested; the code threw IllegalOperationException. PublisherImpl now counts the depth and throws PreconditionNotMetException, SubscriberImpl.endAccess likewise. ILLEGAL_OPERATION: the class org.zerodds.core.IllegalOperationException and the mapping exist and are tested by reflection; no operation of the binding raises it, DDS 1.4 names none. (commit b315020c678) ### §7.3.2 Table 7.1: RETCODE_NOT_ENABLED

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_NOT_ENABLED | NotEnabledException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.write), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.ensureEnabled), crates/java-omgdds/java/src/main/java/org/zerodds/core/NotEnabledException.java (NotEnabledException)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aNotEnabledWriterRefusesToWrite

Status: done — A DataWriter that is not enabled throws NotEnabledException from write, dispose and unregisterInstance, a DataReader that is not enabled from read and take (DataReaderImpl.ensureEnabled). The test checks write on a writer without enable. dispose, unregisterInstance and the reader are not tested. (commit f31b6fa11b5) ### §7.3.2 Table 7.1: RETCODE_PRECONDITION_NOT_MET

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_PRECONDITION_NOT_MET | PreconditionNotMetException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl.detachCondition), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.getDiscoveredParticipantData), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getKeyValue), crates/java-omgdds/java/src/main/java/org/zerodds/core/PreconditionNotMetException.java (PreconditionNotMetException)

Status: done — PreconditionNotMetException is thrown when a condition is detached from a WaitSet it is not attached to, for getDiscoveredParticipantData with an unknown handle and for getKeyValue on a type without a key. The two tests check the first two cases. (commit 7f18142b5e1) ### §7.3.2 Table 7.1: RETCODE_IMMUTABLE_POLICY

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_IMMUTABLE_POLICY | ImmutablePolicyException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.setQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosRules.java (QosRules.checkChange)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::anEnabledWriterRefusesToChangeAnImmutablePolicy, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::anEnabledWriterAcceptsTheChangeOfAChangeablePolicy, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::anEnabledReaderRefusesImmutableAndAcceptsChangeablePolicies, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::anEnabledTopicRefusesImmutableAndAcceptsChangeablePolicies, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::anEntityThatIsNotEnabledAcceptsAnyChange

Status: done — QosRules.checkChange checks in DataWriterImpl.setQos, DataReaderImpl.setQos and TopicImpl.setQos of an enabled object only the policies with Changeable = No (DDS 1.4 2.2.3; plus DATA_REPRESENTATION and TYPE_CONSISTENCY_ENFORCEMENT per XTypes 1.3): DURABILITY, DURABILITY_SERVICE, PRESENTATION, OWNERSHIP, LIVELINESS, RELIABILITY, DESTINATION_ORDER, HISTORY, RESOURCE_LIMITS. A change of TRANSPORT_PRIORITY, USER_DATA or TIME_BASED_FILTER is accepted. An object that is not enabled accepts any change. PublisherImpl.setQos, SubscriberImpl.setQos and DomainParticipantImpl.setQos check with QosRules.checkChange as well. (commit a9c313e5fcb) ### §7.3.2 Table 7.1: RETCODE_INCONSISTENT_POLICY

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_INCONSISTENT_POLICY | InconsistentPolicyException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/InconsistentPolicyException.java (InconsistentPolicyException), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosRules.java (QosRules.checkConsistent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::aHistoryDepthAboveMaxSamplesPerInstanceIsInconsistent, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::maxSamplesBelowMaxSamplesPerInstanceIsInconsistent, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::aMinimumSeparationAboveTheDeadlinePeriodIsInconsistent, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreQosRulesTest.java::aTopicWithAnInconsistentQosIsRefused

Status: done — QosRules.checkConsistent is called on creation (constructor of TopicImpl, DataWriterImpl, DataReaderImpl) and in setQos and throws InconsistentPolicyException for a History KEEP_LAST depth above max_samples_per_instance, max_samples below max_samples_per_instance and minimum_separation above the deadline period. A limit of LENGTH_UNLIMITED and an infinite deadline period are not compared. Publisher, subscriber and participant QoS contain none of these policies. The tests check creation and setQos for each rule, that the refused QoS does not replace the old one, and the boundary of equality. (commit a9c313e5fcb) ### §7.3.2 Table 7.1: RETCODE_OUT_OF_RESOURCES

Spec: §7.3.2, p. 19, Table 7.1 — “RETCODE_OUT_OF_RESOURCES | OutOfResourcesException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/OutOfResourcesException.java (OutOfResourcesException), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.serialize)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::anEncodingBeyondTheLimitFailsWithOutOfResources

Status: done — DataWriterImpl.serialize(support, data, maxBytes) grows the buffer up to MAX_SAMPLE_BYTES (256 MiB) and above that throws OutOfResourcesException with the BufferOverflowException as cause. The test sets the limit to 1024 bytes: 1000 bytes fit (result length 1000), 2000 bytes give the exception. (commit 26684105d79) ### §7.3.2 Exceptions instead of nil for operations that return an object

Spec: §7.3.2, p. 19 — “In addition, this PSM permits implementations to throw exceptions to indicate errors in operations that in the PIM return an object reference.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.createDataWriter), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createTopic)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aClosedEntityRefusesToCreateContainedEntities

Status: n/a (informative) — A permission, not an obligation. ZeroDDS uses it: create* throws AlreadyClosedException on a closed creator (ExceptionMappingTest.aClosedEntityRefusesToCreateContainedEntities) and IllegalArgumentException for invalid input. (commit f31b6fa11b5) ### §7.3.2 Rationale: fault and contingency

Spec: §7.3.2, p. 19 — “Design Rationale (non-normative) • This PSM uses checked and unchecked exceptions according to the following rationale: […]”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative. ### §7.3.3 Value types implement org.omg.dds.core.Value

Spec: §7.3.3, p. 20 — “All DDS types with value semantics implement the interface org.omg.dds.core.Value. These include QoS, QoS policy, status, time, and other types.”

Repo: —

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::timesAreSerializableAndKeepTheirValue, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::durationsAreSerializableAndKeepTheirValue, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::handlesAreSerializableAndKeepTheirOctets, crates/java-omgdds/java/src/test/java/org/omg/dds/ValueCopyTest.java::timeDurationAndHandlesAreCopiedByValue

Status: done — The normative archive omgdds_src.zip contains no org.omg.dds.core.Value (the files of org/omg/dds/core are listed in Annex B); by §2 the source prevails when text and source conflict, and a new type in org.omg.dds would be an extension under §7.2.6. The types with value semantics (Time, Duration, InstanceHandle, QoS, QoS policy, status) have the properties §7.3.3 attributes to the interface: they are Serializable and Cloneable (clone() returns a copy by value), equals and hashCode follow the state, and copyFrom overwrites the state of the target in the Modifiable types (ValueCopyTest, CoreValuesTest). (commit 265da1a816c) ### §7.3.3 Value extends Cloneable and Serializable

Spec: §7.3.3, p. 20 — “The Value interface extends the standard Java SE interfaces java.lang.Cloneable and java.io.Serializable, allowing objects of implementing types to be copied by value as well as serialized and deserialized using built-in Java mechanisms.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Time.java (Time), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Duration.java (Duration), crates/java-omgdds/java/src/main/java/org/omg/dds/core/InstanceHandle.java (InstanceHandle), crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/QosPolicy.java (QosPolicy), crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/Status.java (Status), crates/java-omgdds/java/src/main/java/org/zerodds/core/TimeImpl.java (TimeImpl.clone), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos.clone)

Status: done — Time, Duration, InstanceHandle, QosPolicy, Status and EntityQos are Serializable (the tests serialize time, duration, policies and a status and compare the value after the return) and their classes in org.zerodds are Cloneable with a public clone(): ValueCopyTest copies time, duration, handle, every policy of the PolicyFactory, the QoS classes and the statuses of entities and checks that the copy is equal but another object and that the copy of a ModifiableTime does not follow later changes of the source. The interfaces of the OMG source themselves do not extend Cloneable (no Value, see the item before). (commit 265da1a816c) ### §7.3.3 copyFrom overwrites the state of the target

Spec: §7.3.3, p. 20 — “It defines a method copyFrom that accepts a source object of the same type as the object itself. This method overwrites the state of the target object (“this”) with the state of the argument object. It is similar to clone but does not require allocating a new object.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ModifiableTime.java (ModifiableTime.copyFrom), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ModifiableInstanceHandle.java (ModifiableInstanceHandle.copyFrom), crates/java-omgdds/java/src/main/java/org/zerodds/core/ModifiableTimeImpl.java (ModifiableTimeImpl.copyFrom), crates/java-omgdds/java/src/main/java/org/zerodds/topic/BuiltinTopicKeyImpl.java (BuiltinTopicKeyImpl.copyFrom)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::copyFromOverwritesTheStateAndCopiesAnInvalidSourceAsInvalid, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::copyFromOverwritesTheOctetsAndAnEarlierCopyKeepsItsValue, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::aBuiltinTopicKeyCopiesItsWordsAndIsBuiltFromAHandleBigEndian, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::aNullHandleIsABadParameter, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::keyedStringAndKeyedBytesMutatorsReturnTheObject, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinDataCopyFromTest.java::copyFromOverwritesTheWholeStateOfThePublicationData, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinDataCopyFromTest.java::copyFromOverwritesTheWholeStateOfTheSubscriptionData, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinDataCopyFromTest.java::copyFromOverwritesTheWholeStateOfTheTopicData, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinDataCopyFromTest.java::copyFromOverwritesTheStateOfTheParticipantData

Status: done — ModifiableTimeImpl.copyFrom copies an invalid source as an invalid time and rejects null with IllegalArgumentException; ModifiableInstanceHandleImpl.copyFrom accepts foreign values. copyFrom of the four built-in topic data types overwrites the whole state of the target, also what only this implementation holds (the TypeInformation and TypeObject octets, which are cleared for a foreign source); BuiltinDataCopyFromTest compares target and source by their serialization as built-in data. Also tested are ModifiableTime (valid, invalid, foreign), ModifiableInstanceHandle, BuiltinTopicKey and KeyedString. (commit ecd51bcff6a) ### §7.3.3 equals and hashCode on time, handle, policies and QoS

Spec: §7.3.3, p. 20 — “Value implementers are also expected to override their inherited implementations of Object.equals and Object.hashCode in order to enforce value semantics.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/InstanceHandleImpl.java (InstanceHandleImpl.equals), crates/java-omgdds/java/src/main/java/org/zerodds/core/TimeImpl.java (TimeImpl.equals), crates/java-omgdds/java/src/main/java/org/zerodds/core/DurationImpl.java (DurationImpl.equals), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos.equals), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/ReliabilityImpl.java (ReliabilityImpl.equals)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::timeAndDurationKeepTheirValueAndGetAnEnvironment, crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::policiesKeepTheirValue, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::factoryQosAndDefaultParticipantQos, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::equalTimesHaveEqualHashCodeAndCompareAsEqual, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::equalDurationsHaveEqualHashCodeAndOrderByLength, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::handlesWithTheSameOctetsAreEqualAndHaveTheSameHashCode, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::equalPoliciesHaveEqualHashCodes, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::equalQosHaveEqualHashCodes

Status: done — CoreValuesTest and CoreStatusPolicyTest check that equal Time, Duration, InstanceHandle, policy and entity QoS objects have equal hashCode (every factory method of PolicyFactory called twice, equal and same hash). equals across implementation boundaries (foreign Time, Duration, handle) is tested as well. The status classes are covered in the item on equals and hashCode of statuses. (commit 819bfcb46cb) ### §7.3.3 equals and hashCode on status

Spec: §7.3.3, p. 20 — “Value implementers are also expected to override their inherited implementations of Object.equals and Object.hashCode in order to enforce value semantics.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/status/OfferedIncompatibleQosStatusImpl.java (OfferedIncompatibleQosStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/PublicationMatchedStatusImpl.java (PublicationMatchedStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/LivelinessChangedStatusImpl.java (LivelinessChangedStatusImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::aStatusKeepsItsCounts, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::everyStatusComparesByItsCountersAndHandles, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::statusesWithoutACounterAreEqualWithinTheirKindOnly, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::theHandleOfAStatusIsComparedByValueNotByIdentity, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::theIncompatiblePoliciesOfAStatusCannotBeChanged

Status: done — All 13 status classes in org.zerodds.core.status override equals and hashCode over counters, handles, policy class and policy sets; getPolicies() of the two incompatible-QoS statuses returns an unmodifiable set. CoreStatusPolicyTest compares for each class equal values (equal, same hash) and one differing value (not equal); handle objects of different identity with the same bytes give equal statuses. (commit 12325622fcf) ### §7.3.3 QoS policies immutable

Spec: §7.3.3, p. 20 — “QoS policy objects are immutable. New policy objects can be created from existing policy objects by using the QoS DSL described in sub clause 7.3.5.3.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PartitionImpl.java (PartitionImpl.getName), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/UserDataImpl.java (UserDataImpl.getValue), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos.withPolicy)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::userDataKeepsACopyOfTheArrayItWasGivenAndHandsOutCopies, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::topicDataAndGroupDataHandOutCopies, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::withValueLeavesTheOriginalUnchanged, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::aPartitionCannotBeChangedThroughItsNames, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::withPolicyLeavesTheOriginalQosUnchanged

Status: done — UserDataImpl, TopicDataImpl and GroupDataImpl copy the array in the constructor and in getValue; PartitionImpl.getName returns an unmodifiable view. CoreStatusPolicyTest checks that a changed source or returned array does not change the value, that withValue/withName/withPolicy leave the original unchanged and that Partition.getName().add gives an UnsupportedOperationException. (commit 12325622fcf) ### §7.3.3 The term value type

Spec: §7.3.3, p. 20, footnote 2 — “The term “value type” refers to any data type for which object identity is considered to be established solely based on the state of the objects of that type.”

Repo: —

Tests: —

Status: n/a (informative) — Definition of a term. ### §7.3.4 Time_t and Duration_t as value types Time and Duration

Spec: §7.3.4, p. 20 — “This PSM maps the DDS Time_t and Duration_t types into the value types Time and Duration respectively.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/TimeImpl.java (TimeImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/DurationImpl.java (DurationImpl), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Time.java (Time), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Duration.java (Duration)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::timeFromMillisRoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::durationInfiniteRecognized, crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::timeAndDurationKeepTheirValueAndGetAnEnvironment

Status: done — Time and Duration are classes in org.omg.dds.core with seconds and nanoseconds, value semantics (equals, hashCode, Comparable, Serializable) and the implementations TimeImpl and DurationImpl. The tests check the conversion from milliseconds, the infinite duration and the value comparison after serialization. The common base Value is covered by the item “§7.3.3 Value types implement org.omg.dds.core.Value”. (commit 819bfcb46cb) ### §7.3.4 Magnitude in units of TimeUnit

Spec: §7.3.4, p. 20 — “These classes can provide their magnitude using a variety of units (expressed using java.util.concurrent.TimeUnit).”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/TimeImpl.java (TimeImpl.getTime), crates/java-omgdds/java/src/main/java/org/zerodds/core/DurationImpl.java (DurationImpl.getDuration)

Status: done — Time.getTime(TimeUnit), Time.getRemainder(TimeUnit, TimeUnit) and Duration.getDuration(TimeUnit) return the magnitude in the chosen unit. One test checks getTime in seconds and milliseconds and getRemainder in nanoseconds; a second checks getDuration(SECONDS) on two policies (5 and 7). (commit 819bfcb46cb) ### §7.3.4 Rationale: names without _t

Spec: §7.3.4, p. 20 — “Design Rationale (non-normative) The names of these types omit the underscore and ‘t’ characters from the ends of their names.”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative. ### §7.3.5 Policies based on org.omg.dds.core.policy.QosPolicy

Spec: §7.3.5, p. 20 — “This PSM represents the former with the base interface org.omg.dds.core.policy.QosPolicy and the latter with the base interface org.omg.dds.core.EntityQos.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/QosPolicy.java (QosPolicy), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos)

Status: done — org.omg.dds.core.policy.QosPolicy is the base of all policy interfaces (Reliability, History, UserData …), with the marker interfaces ForDataReader, ForDataWriter and so on. The tests compile and use the policies through EntityQos<P extends QosPolicy> (get(Reliability.class), withPolicy). (commit 5041698cee3) ### §7.3.5 QoS of an entity based on org.omg.dds.core.EntityQos

Spec: §7.3.5, p. 20 — “[…] and the latter with the base interface org.omg.dds.core.EntityQos.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/EntityQos.java (EntityQos), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderQos.java (DataReaderQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos)

Status: done — org.omg.dds.core.EntityQos is the base of DomainParticipantQos, PublisherQos, SubscriberQos, TopicQos, DataWriterQos and DataReaderQos; QosProfile no longer exists. The tests read policies with get(Class) from reader, topic and writer QoS and compare QoS objects with assertEquals. (commit 7d991374fd4) ### §7.3.5.1 Table 7.2: policy as an interface with Java Bean properties

Spec: §7.3.5.1, p. 21, Table 7.2 — “QoS policy structure containing the state of an instance of that policy. | QoS policy interface extending org.omg.dds.core.policy.QosPolicy. Each policy provides Java Bean-style properties.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Reliability.java (Reliability), crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/History.java (History), crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Durability.java (Durability)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::reliabilityAndHistoryQosDefaults

Status: done — The policies are interfaces extending QosPolicy with Java Bean properties (getKind, getDepth, getMaxBlockingTime, withKind, …); Durability is an interface with getKind and the enum Durability.Kind. The test reads getKind and getDepth on reader, topic and writer QoS. (commit 5041698cee3) ### §7.3.5.1 Table 7.2: policy ID as Class<? extends QosPolicy>

Spec: §7.3.5.1, p. 21, Table 7.2 — “Unique QoS policy ID, represented by an instance of the enumeration QosPolicyId_t. | Java platform provides “Class object,” which uniquely identifies a QoS policy. The id will be represented by an object of Class<? extends QosPolicy> (for example, Class).”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/EntityQos.java (EntityQos.get), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosCompatibility.java (QosCompatibility.incompatiblePolicyWith)

Status: done — The ID of a policy is its Class object: EntityQos is a Map<Class<? extends P>, P> with get(Class), and QosCompatibility.incompatiblePolicyWith returns the refusing policy as a class. The tests read get(Reliability.class) and check Reliability.class as the result of incompatiblePolicyWith. (commit c060b572340) ### §7.3.5.1 Table 7.2: policy name through reflection

Spec: §7.3.5.1, p. 21, Table 7.2 — “Unique QoS policy name, represented by a string property QosPolicy.name. | Java reflection provides the necessary capability to obtain name of a QoSPolicy class.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/QosPolicy.java (QosPolicy)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::thePolicyNameIsTheSimpleNameOfItsClass

Status: done — CoreStatusPolicyTest checks for 22 policy names (UserData, TopicData, GroupData, TransportPriority, Lifespan, Durability, Presentation, Deadline, LatencyBudget, Ownership, OwnershipStrength, Liveliness, TimeBasedFilter, Partition, Reliability, DestinationOrder, History, ResourceLimits, EntityFactory, WriterDataLifecycle, ReaderDataLifecycle, DurabilityService) that Class.getSimpleName() equals the name, the class is a QosPolicy interface and the method of the same name in PolicyFactory (except TopicData, Presentation: no factory method there) returns that type. (commit 5041698cee3) ### §7.3.5.1 PolicyFactory creates new policies

Spec: §7.3.5.1, p. 21 — “The org.omg.dds.core.policy.PolicyFactory interface allows creation of new default-initiated policy objects.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/PolicyFactory.java (PolicyFactory), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.getPolicyFactory)

Status: done — org.omg.dds.core.policy.PolicyFactory creates one object per policy with default values (Reliability(), History(), UserData() …); PolicyFactoryImpl implements it, ServiceProviderInterface.getPolicyFactory and EntityQos.getPolicyFactory return the factory. The test checks that the factory returns Reliability(); the QoS tests create all policies through it. (commit 5041698cee3) ### §7.3.5.1 Defaults of the PolicyFactory unspecified

Spec: §7.3.5.1, p. 21 — “The default state of the newly created policy objects via the PolicyFactory interface is unspecified.”

Repo: —

Tests: —

Status: n/a (informative) — No requirement on the values. ### §7.3.5.1 Rationale: set policies explicitly

Spec: §7.3.5.1, p. 21 — “Design Rationale (non-normative) In general, to ensure portability, programmers are encouraged to explicitly specify policy parameters using the QoS DSL.”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative. ### §7.3.5.1 USER_DATA

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 109 (dds-1.2.pdf) — “USER_DATA | A sequence of octets: “value” | […] The default value is an empty (zero-sized) sequence.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/UserData.java (UserData), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/UserDataImpl.java (UserDataImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/DomainParticipantQosImpl.java (DomainParticipantQosImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/DataWriterQosImpl.java (DataWriterQosImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/DataReaderQosImpl.java (DataReaderQosImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::getDiscoveredParticipantDataCarriesTheUserData, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::aBuiltinReaderSeesTheQosOfTheAnnouncedWriter, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::theMatchedEntitiesAreDescribedWithTheirQos

Status: done — UserData is a policy with getValue() (octet sequence) and withValue(byte[], int, int); it belongs to the DomainParticipant, DataWriter and DataReader QoS and is empty by default. The tests check length 0 at the participant and that the writer’s value {1,2,3} and the reader’s {4} are reported to the other side. (commit 7d991374fd4) ### §7.3.5.1 TOPIC_DATA

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 110 (dds-1.2.pdf) — “TOPIC_DATA | A sequence of octets: “value” | […] The default value is an empty (zero-sized) sequence.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/TopicData.java (TopicData), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/TopicDataImpl.java (TopicDataImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/TopicQosImpl.java (TopicQosImpl)

Status: done — TopicData is a policy with getValue() and withValue(byte[], int, int) in the topic QoS; PolicyFactoryImpl.TopicData and TopicQosImpl.defaults return an empty sequence. The test in BuiltinTopicQosTest sets {5,6,7,8,9} and checks its arrival in the built-in topic data over SEDP; QosTypesTest::theDefaultsOfTopicPublisherAndSubscriberQos checks the default “empty”, QosProviderTest reads TOPIC_DATA from base64. ### §7.3.5.1 GROUP_DATA

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 110 (dds-1.2.pdf) — “GROUP_DATA | A sequence of octets: “value” | […] The default value is an empty (zero-sized) sequence.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/GroupData.java (GroupData), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/GroupDataImpl.java (GroupDataImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/PublisherQosImpl.java (PublisherQosImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/SubscriberQosImpl.java (SubscriberQosImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::aBuiltinReaderSeesTheQosOfTheAnnouncedWriter, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTopicPublisherAndSubscriberQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::thePublisherAndSubscriberQosAnswerPresentationEntityFactoryAndGroupData

Status: done — GroupData is a policy with getValue() and withValue(byte[], int, int) in the publisher and subscriber QoS; PolicyFactoryImpl.GroupData returns an empty sequence. BuiltinTopicQosTest sets {9,8} at the publisher and checks its arrival in the built-in topic data and the SEDP round trip; QosTypesTest::theDefaultsOfTopicPublisherAndSubscriberQos checks the default “empty” on publisher and subscriber QoS, QosTypesTest::thePublisherAndSubscriberQosAnswerPresentationEntityFactoryAndGroupData the set value on both. ### §7.3.5.1 DURABILITY

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 110 (dds-1.2.pdf) — “DURABILITY | A “kind”: VOLATILE, TRANSIENT_LOCAL, TRANSIENT, or PERSISTENT”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Durability.java (Durability), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/DurabilityImpl.java (DurabilityImpl), crates/java-omgdds/java/src/main/java/org/zerodds/internal/DurabilityService.java (DurabilityService), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.retainForDurability), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosCompatibility.java (QosCompatibility), crates/java-omgdds/java/src/main/java/org/zerodds/internal/DurabilityJournal.java (DurabilityJournal)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::transientLocalReplaysToLateJoiner, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::volatileDoesNotReplayToLateJoiner, crates/java-omgdds/java/src/test/java/org/omg/dds/DurabilityServiceTest.java::transientSurvivesTheWriter, crates/java-omgdds/java/src/test/java/org/omg/dds/DurabilityServiceTest.java::transientIsClearedWhenTheParticipantCloses, crates/java-omgdds/java/src/test/java/org/omg/dds/DurabilityServiceTest.java::persistentSurvivesTheWriter, crates/java-omgdds/java/src/test/java/org/omg/dds/DurabilityServiceTest.java::persistentSurvivesTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::durabilityOfferedMustBeAtLeastRequestedInTheOrderVolatileToPersistent, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::aTransientLocalReaderIsRefusedByAVolatileWriter, crates/java-omgdds/java/src/test/java/org/omg/dds/QosPersistentStoreTest.java::persistentSamplesOutliveTheProcess, crates/java-omgdds/java/src/test/java/org/omg/dds/QosPersistentStoreTest.java::transientSamplesAreNotWrittenAndDoNotOutliveTheProcess, crates/java-omgdds/java/src/test/java/org/omg/dds/QosPersistentStoreTest.java::withoutADirectoryPersistentLivesAsLongAsTheProcess, crates/java-omgdds/java/src/test/java/org/omg/dds/QosPersistentStoreTest.java::aDisposedInstanceIsToldDisposedAfterTheRestartUntilItsDelayHasPassed, crates/java-omgdds/java/src/test/java/org/omg/dds/QosPersistentStoreTest.java::aDisposedInstanceWithoutDelayIsForgottenAfterTheRestartAndStaysForgotten, crates/java-omgdds/java/src/test/java/org/omg/dds/QosPersistentStoreTest.java::aRecordThatWasCutOffAtTheEndOfTheJournalIsIgnored

Status: done — Durability is a policy interface with Durability.Kind (VOLATILE, TRANSIENT_LOCAL, TRANSIENT, PERSISTENT). The tests check: TRANSIENT_LOCAL replays to a reader created later, VOLATILE does not, TRANSIENT survives the writer and ends with the participant, PERSISTENT survives writer and participant. The ordering in the match (QosCompatibility, offered >= requested) is checked by QosRequestedOfferedTest::durabilityOfferedMustBeAtLeastRequestedInTheOrderVolatileToPersistent for all 16 pairs, and aTransientLocalReaderIsRefusedByAVolatileWriter checks that the pair does not connect and records REQUESTED_INCOMPATIBLE_QOS. PERSISTENT has permanent storage when the system property zerodds.durability.dir names a directory: org.zerodds.internal.DurabilityJournal writes a journal per (domain, topic, type), DurabilityService replays it on the first access to the topic, checked in QosPersistentStoreTest (restart through DurabilityService.reset, history depth, disposed instance with and without delay, cut-off last record, TRANSIENT is not written). Without the property PERSISTENT lives in the memory of the process like TRANSIENT. (commit d0fb00b1341) ### §7.3.5.1 DURABILITY_SERVICE

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 111 (dds-1.2.pdf) — “DURABILITY_SERVICE | A duration”service_cleanup_delay”, a HistoryQosPolicyKind “history_kind”, and three integers: history_depth, max_samples, max_instances, max_samples_per_instance”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/DurabilityService.java (DurabilityService), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/DurabilityServiceImpl.java (DurabilityServiceImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.DurabilityService), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.retainForDurability), crates/java-omgdds/java/src/main/java/org/zerodds/internal/DurabilityService.java (DurabilityService.retain), crates/java-omgdds/java/src/main/java/org/zerodds/internal/DurabilityService.java (DurabilityService.disposed), crates/java-omgdds/java/src/main/java/org/zerodds/internal/DurabilityService.java (DurabilityService.unregistered)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataWriterQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultOwnershipStrengthAndDurabilityServiceOfTheFactoryAreTheTableValues, crates/java-omgdds/java/src/test/java/org/omg/dds/QosDurabilityServiceTest.java::theHistoryDepthOfThePolicyDecidesWhatALateJoinerGets, crates/java-omgdds/java/src/test/java/org/omg/dds/QosDurabilityServiceTest.java::keepAllInTheStoreKeepsEverySampleUpToTheLimit, crates/java-omgdds/java/src/test/java/org/omg/dds/QosDurabilityServiceTest.java::aSampleBeyondMaxSamplesPerInstanceIsRefusedAndNotDelivered, crates/java-omgdds/java/src/test/java/org/omg/dds/QosDurabilityServiceTest.java::aNewInstanceBeyondMaxInstancesIsRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/QosDurabilityServiceTest.java::maxSamplesBoundsTheSamplesOfAllInstancesTogether, crates/java-omgdds/java/src/test/java/org/omg/dds/QosDurabilityServiceTest.java::aDisposedInstanceStaysInTheStoreForTheCleanupDelayAndIsToldDisposed, crates/java-omgdds/java/src/test/java/org/omg/dds/QosDurabilityServiceTest.java::withNoCleanupDelayADisposedInstanceWithoutWritersIsForgottenAtOnce, crates/java-omgdds/java/src/test/java/org/omg/dds/QosDurabilityServiceTest.java::anInstanceDisposedWhileAWriterStillWritesItIsKeptDisposed, crates/java-omgdds/java/src/test/java/org/omg/dds/QosDurabilityServiceTest.java::aWriteAfterTheDisposeMakesTheInstanceAliveInTheStore

Status: done — DurabilityService is a policy with getServiceCleanupDelay, getHistoryKind, getHistoryDepth, getMaxSamples, getMaxInstances, getMaxSamplesPerInstance and the with… methods in topic and DataWriter QoS. The factory defaults are now delay 0, KEEP_LAST depth 1 and LENGTH_UNLIMITED for the three limits (QosTypesTest::theDefaultsOfTheDataWriterQos). DataWriterImpl.retainForDurability passes writer id, policy and timestamp to org.zerodds.internal.DurabilityService: the history depth and the limits of the store come from this policy, not from the HISTORY of the writer; a sample over a limit raises OutOfResourcesException before it is delivered. service_cleanup_delay decides when the store forgets an instance: after dispose, when no writer writes it any more and the delay has elapsed since both (DDS 1.4 §2.2.3.4); until then it tells a later reader the instance is NOT_ALIVE_DISPOSED. The clock can be replaced in tests (DurabilityService.useClock). Tested in QosDurabilityServiceTest. (commit 3389cd624cf) ### §7.3.5.1 PRESENTATION

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 111–112 (dds-1.2.pdf) — “PRESENTATION | An “access_scope”: INSTANCE, TOPIC, GROUP And two booleans: “coherent_access” “ordered_access””

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Presentation.java (Presentation), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PresentationImpl.java (PresentationImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.Presentation), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/PublisherQos.java (PublisherQos.getPresentation), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/SubscriberQos.java (SubscriberQos.getPresentation), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosCompatibility.java (QosCompatibility.withPresentation), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PresentationImpl.java (PresentationImpl.requestedOfferedContract), crates/java-omgdds/java/src/main/java/org/zerodds/internal/InProcessBus.java (InProcessBus.atomically), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/GroupOrder.java (GroupOrder), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.getDataReaders), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.groupStamp)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::thePublicationWireFormCarriesTheQosOnTheParameterIdsOfTable913, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::presentationOfferedScopeMustBeAtLeastRequestedAndCoherentAndOrderedMustBeOffered, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::aSubscriberThatRequestsTopicScopeDoesNotMatchAPublisherThatOffersInstanceScope, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::aSubscriberAndAPublisherWithTheSamePresentationMatch, crates/java-omgdds/java/src/test/java/org/omg/dds/CoherentSetAtomicityTest.java::aReaderOnAnotherThreadNeverSeesPartOfASet, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::orderedAccessWithScopeTopicReturnsTheSamplesOfAllInstancesInOneOrder, crates/java-omgdds/java/src/test/java/org/omg/dds/WireEntityBehaviourTest.java::aCoherentSetOfARemoteWriterReachesACoherentAccessReaderAsAWhole, crates/java-omgdds/java/src/test/java/org/omg/dds/GroupAccessTest.java::getDataReadersIsAListInTheOrderOfWritingAndAReadGivesOneSample, crates/java-omgdds/java/src/test/java/org/omg/dds/GroupAccessTest.java::samplesOfTwoRemoteWritersOfOnePublisherArriveInTheOrderOfTheGroupSequenceNumber, crates/java-omgdds/java/src/test/java/org/omg/dds/GroupAccessTest.java::aGroupCoherentSetOfTwoRemoteWritersArrivesAsAWholeAfterTheEndMarkers, crates/java-omgdds/java/src/test/java/org/omg/dds/GroupAccessTest.java::aGroupPublisherWithTwoWritersSendsItsSamplesAndSetsToAPeer, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/GroupOrderTest.java::aGroupCoherentSetIsHandedOnTogetherWhenItsEndHasCome, crates/java-omgdds/java/src/test/java/org/zerodds/rtps/GroupOrderTest.java::withTheTimeoutOptionAMissingNumberIsSkippedAndAnIncompleteSetIsNotDelivered

Status: done — Presentation has getAccessScope (INSTANCE, TOPIC, GROUP), isCoherentAccess and isOrderedAccess; default INSTANCE/false/false (PolicyFactoryImpl.Presentation). Compatibility is matched: PresentationImpl.requestedOfferedContract demands an offered scope >= the requested one and, when coherent_access or ordered_access is requested, the same property offered; QosCompatibility includes the PRESENTATION of the publisher and subscriber of the two endpoints in the match (withPresentation), the violation is in REQUESTED_/OFFERED_INCOMPATIBLE_QOS (QosRequestedOfferedTest, all nine scope pairs, coherent, ordered). coherent_access acts: the sets between begin_coherent_changes and end_coherent_changes reach a reader on another thread as a whole and, over RTPS, with PID_COHERENT_SET. ordered_access with access_scope TOPIC puts the samples of all instances of a reader in one order (orderedAccessWithScopeTopicReturnsTheSamplesOfAllInstancesInOneOrder). With access_scope GROUP and ordered_access, get_datareaders is a list in which every reader appears as often as it holds samples, in the order of writing (source timestamp for BY_SOURCE_TIMESTAMP, else arrival over all readers of the process), and read and take return at most one sample (DDS 1.4 §2.2.2.5.2.10, §2.2.2.5.3.8). Over RTPS every sample of a writer of a publisher with GROUP carries PID_GROUP_SEQ_NUM (running over all writers of the publisher), PID_WRITER_GROUP_INFO (GroupDigest_t: the leading four octets of the MD5 over the CDR big-endian sequence of the entity ids of the writers, sorted by their value as little-endian integer, GroupDigest.of) and, in a set, PID_GROUP_COHERENT_SET; every writer sends the End Coherent Set DATA at the end of the set (DDSI-RTPS 2.5 §8.7.5, §8.7.6, §9.3.2.5, §9.6.4.3 to §9.6.4.5). The writers of a publisher with GROUP send HEARTBEATs with the GroupInfoFlag (0x08): currentGSN (the largest group number given out), firstGSN and lastGSN of the writer, and writerSet and secureWriterSet (RtpsMessage.Builder.heartbeatGroup, DDSI-RTPS 2.5 §8.3.7.5, §9.4.5.7, §9.4.2.19); a writer without a sample sends them too (empty range). The option zerodds.rtps.omit-heartbeat-group-digests (Rust: wire.omit_heartbeat_group_digests, default off) leaves out writerSet and secureWriterSet. A reader of a subscriber with GROUP hands on the samples of the writers of a remote publisher in the order of the group number and a group set together when its end has come (GroupOrder). If the number n is missing, it counts as absent per §8.7.5 when a HEARTBEAT reports currentGSN >= n and every counted writer (matched, RELIABLE, of the group by writerSet) says it is none of its own: it delivered a sample with a larger group number, or its HEARTBEAT with currentGSN >= n has a range [firstGSN, lastGSN] that does not hold n; a writer not yet heard from holds the order. A set with a number given up that way is not delivered (§8.7.6). The timeout rule is a named option, off by default: zerodds.rtps.group-timeout-millis (a number that does not arrive within that time is skipped). Tests: GroupOrderTest (the rule, the timeout option off and on, a set) and GroupAccessTest (two writers over RTPS: number 11 belongs to a writer without a matched reader and is given up by the HEARTBEATs of the two matched writers; without a HEARTBEAT of the second writer it stays missing). The group number is assigned and the sample entered in the history of its writer under one lock (PublisherImpl.stampAndWrite); the HEARTBEAT reads currentGSN under the same lock (currentGroupStamp) and so announces only numbers whose change is entered (GroupHeartbeatLockTest). Expected towards Cyclone DDS, Fast DDS and OpenDDS: they read PID_GROUP_SEQ_NUM, PID_GROUP_COHERENT_SET and PID_WRITER_GROUP_INFO per §8.7.5; measured is only the ZeroDDS peer. (commits 95d9d5eee83, 1a2d89d1696, 56280b5d10c, 5d99860e61a) ### §7.3.5.1 DEADLINE

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 112 (dds-1.2.pdf) — “DEADLINE | A duration “period””

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Deadline.java (Deadline), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/DeadlineImpl.java (DeadlineImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.evaluateDeadline), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.evaluateOfferedDeadline), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosCompatibility.java (QosCompatibility)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::requestedDeadlineMissedIsRaised, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::infiniteDeadlineNeverMisses, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::rxoDeadlineCompatibility, crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::requestedDeadlineMissedFiresWithoutPolling, crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::offeredDeadlineMissedFiresWithoutPolling, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::deadlineOfferedPeriodMustNotExceedRequested

Status: done — Deadline.getPeriod defaults to infinite (PolicyFactoryImpl.Deadline). Reader and writer count misses (DataReaderImpl.evaluateDeadline, DataWriterImpl.evaluateOfferedDeadline); the tests check REQUESTED_DEADLINE_MISSED at 50 ms, that infinite never misses, OFFERED_DEADLINE_MISSED, the listener callback without polling, and compatibility (offered <= requested) in rxoDeadlineCompatibility. QosRequestedOfferedTest::deadlineOfferedPeriodMustNotExceedRequested checks compatibility on pairs including the infinite default. ### §7.3.5.1 LATENCY_BUDGET

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 113 (dds-1.2.pdf) — “LATENCY_BUDGET | A duration “duration” | […] The default value of the duration is zero”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/LatencyBudget.java (LatencyBudget), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/LatencyBudgetImpl.java (LatencyBudgetImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.LatencyBudget), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosCompatibility.java (QosCompatibility.incompatiblePolicies)

Status: done — LatencyBudget.getDuration defaults to 0 (PolicyFactoryImpl.LatencyBudget, checked in QosTypesTest::theDefaultsOfTheDataWriterQos); the value 2 s is written on PID_LATENCY_BUDGET and read back in the round trip. QosCompatibility.incompatiblePolicies checks LATENCY_BUDGET (offered <= requested, LatencyBudgetImpl.requestedOfferedContract); QosRequestedOfferedTest::latencyBudgetOfferedMustNotExceedRequested checks longer, equal, shorter and the default. Per DDS 1.4 §2.2.3.7 the policy is a hint; it does not affect delivery. (commit df63a3a7869) ### §7.3.5.1 OWNERSHIP

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 113 (dds-1.2.pdf) — “OWNERSHIP | A “kind” SHARED EXCLUSIVE”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Ownership.java (Ownership), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/OwnershipImpl.java (OwnershipImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.onWrite), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosCompatibility.java (QosCompatibility.incompatiblePolicyWith)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::exclusiveOwnershipArbitratesToHighestStrength, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::sharedOwnershipDeliversFromAllWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::ownershipKindMustMatch, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::ownershipKindsMustBeEqualInBothDirections, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::aSharedReaderAndAnExclusiveWriterDoNotMatchAndBothSideRecordIt

Status: done — Ownership.getKind (SHARED, EXCLUSIVE); the reader arbitrates only when reader and writer are EXCLUSIVE (DataReaderImpl.onWrite). DDS 1.4 §2.2.3.9 requires the same kind: OwnershipImpl.requestedOfferedContract returns 0 for an equal and 1 for a different kind, QosCompatibility reports OWNERSHIP as incompatible in both directions. Tested: QosRequestedOfferedTest::ownershipKindsMustBeEqualInBothDirections through QosCompatibility.isCompatible, aSharedReaderAndAnExclusiveWriterDoNotMatchAndBothSideRecordIt with reader and writer (no sample, REQUESTED_ and OFFERED_INCOMPATIBLE_QOS with Ownership), QosLifecycleTest::ownershipKindMustMatch. (commit df63a3a7869) ### §7.3.5.1 OWNERSHIP_STRENGTH

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 113 (dds-1.2.pdf) — “OWNERSHIP_ STRENGTH | An integer “value””

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/OwnershipStrength.java (OwnershipStrength), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/OwnershipStrengthImpl.java (OwnershipStrengthImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.OwnershipStrength)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::exclusiveOwnershipArbitratesToHighestStrength, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::aBuiltinReaderSeesTheQosOfTheAnnouncedWriter, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataWriterQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultOwnershipStrengthAndDurabilityServiceOfTheFactoryAreTheTableValues

Status: done — OwnershipStrength.getValue; with EXCLUSIVE the reader accepts only samples of the writer with the highest strength (1 against 10), the value 7 travels through built-in topic data. PolicyFactoryImpl.OwnershipStrength() now creates the value 0 (DDS 1.4 §2.2.3, table of the policies); DataWriterQosImpl.defaults takes the 0. Checked in QosTypesTest::theDefaultsOfTheDataWriterQos and theDefaultOwnershipStrengthAndDurabilityServiceOfTheFactoryAreTheTableValues. (commit df63a3a7869) ### §7.3.5.1 LIVELINESS

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 114 (dds-1.2.pdf) — “LIVELINESS | A “kind”: AUTOMATIC, MANUAL_BY_PARTICIPANT, MANUAL_BY_TOPIC and a duration “lease_duration””

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Liveliness.java (Liveliness), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/LivelinessImpl.java (LivelinessImpl), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.evaluateLiveliness), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.evaluateLiveliness), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.assertLiveliness), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.renewManualByParticipant), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.renewLiveliness), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/QosParameters.java (QosParameters.incompatibility)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::livelinessChangedReflectsWriterPresence, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::livelinessRxoKindAndLease, crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::livelinessLostFiresWithoutPolling, crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::livelinessChangedFiresWithoutPolling, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLivelinessTest.java::theParticipantAssertsTheLivelinessOfItsManualByParticipantWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLivelinessTest.java::theParticipantDoesNotAssertTheLivelinessOfAManualByTopicWriter, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLivelinessTest.java::anAssertOnAnyWriterOfTheParticipantAssertsTheManualByParticipantWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLivelinessTest.java::aWriteByAnyWriterOfTheParticipantAssertsTheManualByParticipantWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLivelinessTest.java::theWritersOfAnotherParticipantAreNotAsserted, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLivelinessTest.java::theDefaultLivelinessIsAutomaticWithAnInfiniteLease, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::livelinessOfferedKindMustBeAtLeastRequestedAndTheLeaseNotLonger, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::theWireSideRefusesAnOfferedLivelinessKindBelowTheRequestedOne

Status: done — Liveliness with kind and lease_duration; default AUTOMATIC/infinite (PolicyFactoryImpl.Liveliness, checked in QosLivelinessTest::theDefaultLivelinessIsAutomaticWithAnInfiniteLease). The lease is monitored: the writer reports LIVELINESS_LOST, the reader LIVELINESS_CHANGED, both without a status poll (LeaseTest). Compatibility: offered kind >= requested (AUTOMATIC < MANUAL_BY_PARTICIPANT < MANUAL_BY_TOPIC) and offered lease <= requested (QosRequestedOfferedTest::livelinessOfferedKindMustBeAtLeastRequestedAndTheLeaseNotLonger); the wire side QosParameters.incompatibility compared the kind the wrong way round and is corrected (theWireSideRefusesAnOfferedLivelinessKindBelowTheRequestedOne). DomainParticipantImpl.assertLiveliness now renews all DataWriters of the participant with MANUAL_BY_PARTICIPANT; likewise every write and every assert_liveliness of a writer of the participant renews them (DDS 1.4 §2.2.3.11); a MANUAL_BY_TOPIC writer and the writers of another participant are left alone (QosLivelinessTest). (commit 6fa88c2bd3b) ### §7.3.5.1 TIME_BASED_FILTER

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 115 (dds-1.2.pdf) — “TIME_BASED_ FILTER | A duration”minimum_ separation” | […] default minimum_separation=0”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/TimeBasedFilter.java (TimeBasedFilter), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/TimeBasedFilterImpl.java (TimeBasedFilterImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.TimeBasedFilter), crates/java-omgdds/java/src/main/java/org/zerodds/internal/TimeBasedFilterState.java (TimeBasedFilterState)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosReaderEffectsTest.java::aReaderWithMinimumSeparationTakesOneSamplePerInstanceInThatTime, crates/java-omgdds/java/src/test/java/org/omg/dds/QosReaderEffectsTest.java::theNewestSampleHeldBackIsDeliveredWhenTheSeparationHasPassed, crates/java-omgdds/java/src/test/java/org/omg/dds/QosReaderEffectsTest.java::withoutMinimumSeparationEverySampleIsDelivered, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataReaderQos

Status: done — TimeBasedFilter.getMinimumSeparation defaults to 0; the value 1 s runs through the round trip of the built-in subscription data. DataReaderImpl.onWrite now evaluates minimum_separation per instance (org.zerodds.internal.TimeBasedFilterState): the first sample of an instance is accepted, a further one within the separation is held back, and the newest held-back sample is delivered when the separation has passed (on access and by the reader’s sweep), so that the last change reaches the reader (DDS 1.4 §2.2.3.12). The time is the reception time at the reader. DEADLINE < minimum_separation is InconsistentPolicyException (QosSetQosTest::aDeadlineShorterThanTheMinimumSeparationIsInconsistent). Tested in QosReaderEffectsTest (one instance, several instances, late delivery of the last sample, default 0). (commit 3389cd624cf) ### §7.3.5.1 PARTITION

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 115 (dds-1.2.pdf) — “PARTITION | A list of strings “name””

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Partition.java (Partition), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PartitionImpl.java (PartitionImpl), crates/java-omgdds/java/src/main/java/org/zerodds/rtps/QosParameters.java (QosParameters.partitionsOverlap), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl)

Status: done — Partition.getName (set of names, default "") is part of PublisherQos and SubscriberQos. The tests check separation for A against B, delivery on overlap (A,X against X), wildcards (sensor.* against sensor.temp) and no match reported to the listener. ### §7.3.5.1 RELIABILITY

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 115–116 (dds-1.2.pdf) — “RELIABILITY | A “kind”: RELIABLE, BEST_EFFORT and a duration “max_blocking_time” | […] The default max_blocking_time=100ms.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Reliability.java (Reliability), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/ReliabilityImpl.java (ReliabilityImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosCompatibility.java (QosCompatibility.incompatiblePolicyWith), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.DataWriterReliability), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.awaitResources)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::qosCompatibilityReliableReaderRequiresReliableWriter, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::reliabilityAndHistoryQosDefaults, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::rxoIncompatibleReliabilityDetected, crates/java-omgdds/java/src/test/java/org/omg/dds/QosCompatibilityTest.java::incompatibleReliabilityDoesNotConnect, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aWriterThatOffersLessThanRequestedIsReportedToTheListener, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::reliabilityIsComparedByKindAndNotByMaxBlockingTime, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aWriteToANewInstanceBeyondMaxInstancesTimesOutUntilAnInstanceIsUnregistered, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aBlockedWriteContinuesWhenAnotherThreadFreesTheInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aBestEffortWriterDoesNotWaitAndIsOutOfResources, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataWriterQos

Status: done — Kind (BEST_EFFORT, RELIABLE) and max_blocking_time (default 100 ms, QosTypesTest::theDefaultsOfTheDataWriterQos). ReliabilityImpl.requestedOfferedContract compares the kind only (DDS 1.4 §2.2.3.14): a RELIABLE reader with a longer max_blocking_time than the writer stays compatible (QosRequestedOfferedTest::reliabilityIsComparedByKindAndNotByMaxBlockingTime); a RELIABLE reader against a BEST_EFFORT writer is not connected (CoreTypesTest, QosCompatibilityTest, ReaderStatusTest). When a RESOURCE_LIMITS limit is reached (no free instance, the history for TRANSIENT_LOCAL) DataWriterImpl.write waits at most max_blocking_time and then raises TimeoutException; a BEST_EFFORT writer does not wait and raises OutOfResourcesException (QosResourceLimitsTest). A writer without a limit never waits. (commit 3389cd624cf) ### §7.3.5.1 TRANSPORT_PRIORITY

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 116 (dds-1.2.pdf) — “TRANSPORT_ PRIORITY | An integer “value””

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/TransportPriority.java (TransportPriority), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/TransportPriorityImpl.java (TransportPriorityImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.TransportPriority), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicQos.java (TopicQos.getTransportPriority), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriterQos.java (DataWriterQos.getTransportPriority)

Status: done — TransportPriority.getValue (int, default 0) in TopicQos and DataWriterQos; the test sets 3 on a TopicQos and reads it back after the round trip of the built-in topic data. DDS 1.2 §7.1.3.15 calls the policy a hint; there is no effect on the transport (in the code only read in QosParameters and the built-in data). ### §7.3.5.1 LIFESPAN

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 116 (dds-1.2.pdf) — “LIFESPAN | A duration “duration””

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Lifespan.java (Lifespan), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/LifespanImpl.java (LifespanImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.Lifespan), crates/java-omgdds/java/src/main/java/org/zerodds/internal/InProcessBus.java (InProcessBus.Message.lifespanMillis), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.purgeLocked)

Status: done — Lifespan.getDuration (default infinite); 30 s are written on PID_LIFESPAN and read back in the round trip. The writer carries its validity duration in every message (InProcessBus.Message.lifespanMillis); DataReaderImpl discards a sample whose source timestamp plus duration has passed on arrival and removes expired samples before every access. DataWriterImpl.replayTo does not hand expired samples to a late reader and passes the original source timestamp on in a replay; the same holds for TRANSIENT and PERSISTENT through org.zerodds.internal.DurabilityService. Tested in QosReaderEffectsTest and QosDurabilityServiceTest. (commit 3389cd624cf) ### §7.3.5.1 DESTINATION_ORDER

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 116 (dds-1.2.pdf) — “DESTINATION_ ORDER | A “kind”: BY_ RECEPTION_ TIMESTAMP, BY_SOURCE_ TIMESTAMP”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/DestinationOrder.java (DestinationOrder), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/DestinationOrderImpl.java (DestinationOrderImpl), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.DestinationOrder)

Status: done — DestinationOrder.getKind (BY_RECEPTION_TIMESTAMP, BY_SOURCE_TIMESTAMP; default BY_RECEPTION_TIMESTAMP); BY_SOURCE_TIMESTAMP is written on PID_DESTINATION_ORDER and read back in the round trip. With BY_SOURCE_TIMESTAMP DataReaderImpl orders a sample of an instance whose source timestamp is smaller than the newest one of the instance before the newer ones (DDS 1.4 §2.2.2.5.3.8: the samples of an instance appear in the order of their source timestamps, smaller first); none is lost, equal timestamps stay in arrival order, other instances are untouched, with BY_RECEPTION_TIMESTAMP the source timestamp does not decide. QosCompatibility.incompatiblePolicies checks DESTINATION_ORDER (offered >= requested, BY_RECEPTION_TIMESTAMP < BY_SOURCE_TIMESTAMP). Tested in QosReaderEffectsTest and QosRequestedOfferedTest::destinationOrderOfferedMustBeAtLeastRequested. (commit 3389cd624cf) ### §7.3.5.1 HISTORY

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 117–118 (dds-1.2.pdf) — “HISTORY | A “kind”: KEEP_LAST, KEEP_ALL And an optional integer “depth” | […] KEEP_LAST is the default kind. The default value of depth is 1.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/History.java (History), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/HistoryImpl.java (HistoryImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.onWrite), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.retainCapped), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosRules.java (QosRules.checkConsistent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::historyKeepLastCapsPerInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::historyKeepLastIsPerInstanceNotGlobal, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::transientLocalReplaysToLateJoiner, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::historyDepthMustBeNonNegative, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::reliabilityAndHistoryQosDefaults, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::aWriterIsNotCreatedWithPoliciesThatContradictEachOther, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::theBoundariesOfTheConsistencyRulesAreConsistent, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::aTopicIsNotCreatedWithPoliciesThatContradictEachOther, crates/java-omgdds/java/src/test/java/org/omg/dds/QosDefaultQosTest.java::aDefaultQosThatContradictsItselfIsRefusedAndTheDefaultStays

Status: done — Kind (KEEP_LAST, KEEP_ALL) and depth; default KEEP_LAST/1. The tests check capping per instance in the reader, that the depth is not global, replay by the writer (KEEP_LAST 1, TRANSIENT_LOCAL), the default and rejection of a negative depth; KEEP_ALL is used through readerKeepAll. The rule depth <= max_samples_per_instance (DDS 1.4 §2.2.3.18) and the two rules of RESOURCE_LIMITS and of DURABILITY_SERVICE are checked by QosRules.checkConsistent when a writer, reader or topic is created, in setQos and in setDefault…Qos; a violation is InconsistentPolicyException. The boundary cases (depth equal to the limit, KEEP_ALL without a depth comparison, LENGTH_UNLIMITED) are valid. Tested in QosSetQosTest, QosDefaultQosTest. (commit 8bc25e5d19b) ### §7.3.5.1 Defaults of RELIABILITY and HISTORY

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 116–118 (dds-1.2.pdf) — “RELIABLE […] This is the default value for DataWriters. BEST_EFFORT […] This is the default value for DataReaders and Topics.”; “KEEP_LAST is the default kind. The default value of depth is 1.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.DataWriterReliability), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.DataReaderReliability), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/PolicyFactoryImpl.java (PolicyFactoryImpl.DataReaderHistory), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/DataReaderQosImpl.java (DataReaderQosImpl.defaults), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/DataWriterQosImpl.java (DataWriterQosImpl.defaults), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/TopicQosImpl.java (TopicQosImpl.defaults)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::reliabilityAndHistoryQosDefaults, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataWriterQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataReaderQos

Status: done — Defaults today: RELIABILITY RELIABLE for DataWriterQosImpl.defaults, BEST_EFFORT for DataReaderQosImpl.defaults and TopicQosImpl.defaults, HISTORY KEEP_LAST with depth 1. reliabilityAndHistoryQosDefaults checks these values on reader, topic and writer QoS; SubscriberImpl and PublisherImpl use these defaults for entities without their own QoS. ### §7.3.5.1 RESOURCE_LIMITS

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 118–119 (dds-1.2.pdf) — “RESOURCE_ LIMITS | Three integers: max_samples, max_instances, max_samples_per_instance | […] By default, LENGTH_UNLIMITED.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/ResourceLimits.java (ResourceLimits), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/ResourceLimitsImpl.java (ResourceLimitsImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.rejectedByLimits), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.awaitResources)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aSampleBeyondMaxSamplesIsRejectedAndReportedToTheListener, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aReaderRejectsAnInstanceBeyondMaxInstances, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aKeepAllReaderRejectsASampleBeyondMaxSamplesPerInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::theDefaultLimitsAreUnlimitedAndRejectNothing, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aWriteToANewInstanceBeyondMaxInstancesTimesOutUntilAnInstanceIsUnregistered, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aBlockedWriteContinuesWhenAnotherThreadFreesTheInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aBestEffortWriterDoesNotWaitAndIsOutOfResources, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::keepAllWithMaxSamplesPerInstanceTimesOutForTransientLocal, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::maxSamplesBoundsTheHistoryOfAllInstancesTogether, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::keepLastReplacesTheOldestSampleOfTheInstanceAndNeedsNoNewResource, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::withNoLimitAWriterNeverWaits

Status: done — ResourceLimits with max_samples, max_instances, max_samples_per_instance, default LENGTH_UNLIMITED. The reader rejects samples beyond the three limits (DataReaderImpl.rejectedByLimits, SAMPLE_REJECTED): checked for max_samples (REJECTED_BY_SAMPLES_LIMIT), max_instances (REJECTED_BY_INSTANCES_LIMIT), max_samples_per_instance (REJECTED_BY_SAMPLES_PER_INSTANCE_LIMIT, KEEP_ALL) and the default. A RELIABLE writer waits up to max_blocking_time and then raises TimeoutException (BEST_EFFORT: OutOfResourcesException at once) when a sample would need a new instance beyond max_instances or, for the history kept for TRANSIENT_LOCAL, go beyond max_samples or max_samples_per_instance (DataWriterImpl.awaitResources); unregister and dispose free the resources and wake the waiting writer. With KEEP_LAST the new sample replaces the oldest of the instance and needs no new resource. A VOLATILE writer keeps no samples, only its instances are bounded. The rules against HISTORY are under HISTORY (QosRules). (commit 3389cd624cf) ### §7.3.5.1 ENTITY_FACTORY

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 119 (dds-1.2.pdf) — “ENTITY_ FACTORY | A boolean: “autoenable_ created_ entities” | […] By default, TRUE.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/EntityFactory.java (EntityFactory), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/EntityFactoryImpl.java (EntityFactoryImpl), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.enableIfFactorySays), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl.autoEnable), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.createDataWriter)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::entityFactoryDecidesWhetherWhatIsCreatedIsEnabled, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::factoryQosAndDefaultParticipantQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::aPublisherWithAutoEnableFalseCreatesDisabledWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::aPublisherWithAutoEnableTrueCreatesEnabledWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::theChangeOfTheFactoryPolicyAffectsOnlyTheEntitiesCreatedAfterIt, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::enablingThePublisherEnablesTheWritersItCreatedWhileDisabled, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::enablingThePublisherLeavesTheWritersDisabledWhenItsPolicyIsFalse, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::aWriterCannotBeEnabledBeforeItsPublisher, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::aSubscriberWithAutoEnableFalseCreatesDisabledReaders, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::enablingTheSubscriberEnablesTheReadersItCreatedWhileDisabled, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::theParticipantFactoryDecidesWhetherTheParticipantsItCreatesAreEnabled, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::theParticipantPolicyDecidesWhetherItsPublishersSubscribersAndTopicsAreEnabled

Status: done — EntityFactory.isAutoEnableCreatedEntities, default true. Publisher and subscriber read entity_factory of their QoS: PublisherImpl.createDataWriter and SubscriberImpl.createDataReader enable the new entity only if the publisher or subscriber itself is enabled and the policy says true (DDS 1.4 §2.2.3.20, §2.2.2.1.1.7). enable on a publisher or subscriber enables the children that were disabled so far if the policy says so; enable on a writer or reader whose publisher or subscriber is not enabled raises PreconditionNotMetException. A change of the policy affects only entities created later. For the participant the policy of its factory QoS applies (DomainParticipantFactoryImpl.autoEnable), for publisher, subscriber and topic that of the participant (enableIfFactorySays). Tested in QosEntityFactoryTest. (commit 8bc25e5d19b) ### §7.3.5.1 WRITER_DATA_LIFECYCLE

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 119–120 (dds-1.2.pdf) — “WRITER_DATA_ LIFECYCLE | A boolean: “autodispose_ unregistered_ instances” | […] By default, TRUE.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/WriterDataLifecycle.java (WriterDataLifecycle), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/WriterDataLifecycleImpl.java (WriterDataLifecycleImpl), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.unregisterInstance), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.close), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.unregisterKey)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosWriterDataLifecycleTest.java::theDefaultIsToDisposeWhatIsUnregistered, crates/java-omgdds/java/src/test/java/org/omg/dds/QosWriterDataLifecycleTest.java::unregisterDisposesTheInstanceWhenTheFlagIsTrue, crates/java-omgdds/java/src/test/java/org/omg/dds/QosWriterDataLifecycleTest.java::unregisterOnlyLeavesNoWritersWhenTheFlagIsFalse, crates/java-omgdds/java/src/test/java/org/omg/dds/QosWriterDataLifecycleTest.java::anInstanceDisposedByTheApplicationStaysDisposedWhenItIsUnregistered, crates/java-omgdds/java/src/test/java/org/omg/dds/QosWriterDataLifecycleTest.java::deletingTheWriterDisposesItsInstancesWhenTheFlagIsTrue, crates/java-omgdds/java/src/test/java/org/omg/dds/QosWriterDataLifecycleTest.java::deletingTheWriterOnlyLeavesNoWritersWhenTheFlagIsFalse, crates/java-omgdds/java/src/test/java/org/omg/dds/QosWriterDataLifecycleTest.java::aWriteAfterTheDisposeBringsTheInstanceBackToAlive

Status: done — WriterDataLifecycle (isAutDisposeUnregisteredInstances, default true) in the DataWriter QoS. DataWriterImpl.unregisterKey (used by unregisterInstance, the handle path and close()) publishes DISPOSE first and then UNREGISTER when true, as if the application had called dispose before unregistering (DDS 1.4 §2.2.3.21); with false only UNREGISTER. The reader leaves an instance marked NOT_ALIVE_DISPOSED in that state when the last writer unregisters. With the default the result of an unregister is therefore NOT_ALIVE_DISPOSED, with false NOT_ALIVE_NO_WRITERS; QosLifecycleTest::unregisterMarksInstanceNotAliveNoWriters and closingOneWriterDoesNotMarkNoWritersWhileAnotherWrites now use false, as do DurabilityServiceTest and MultiTopicJoinTest where they expect NO_WRITERS or surviving data. The built-in topics (Builtin.writer) use false and keep reporting NOT_ALIVE_NO_WRITERS. Tested in QosWriterDataLifecycleTest. (commit 3389cd624cf) ### §7.3.5.1 READER_DATA_LIFECYCLE

Spec: §7.3.5.1, p. 21; [DDS] 1.2 §7.1.3, p. 120 (dds-1.2.pdf) — “READER_DATA_ LIFECYCLE | Two durations “autopurge_ nowriter_ samples_delay” and “autopurge_ disposed_ samples_delay” | […] By default, infinite.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/ReaderDataLifecycle.java (ReaderDataLifecycle), crates/java-omgdds/java/src/main/java/org/zerodds/core/policy/ReaderDataLifecycleImpl.java (ReaderDataLifecycleImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.purgeLocked)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosReaderEffectsTest.java::byDefaultAnInstanceWithoutWritersKeepsItsSamplesUntilTheyAreTaken, crates/java-omgdds/java/src/test/java/org/omg/dds/QosReaderEffectsTest.java::aZeroDelayPurgesTheInstanceWithoutWritersWithItsUntakenSamples, crates/java-omgdds/java/src/test/java/org/omg/dds/QosReaderEffectsTest.java::aZeroDelayPurgesTheSamplesOfADisposedInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/QosReaderEffectsTest.java::theDelayOfTheOtherStateDoesNotPurge, crates/java-omgdds/java/src/test/java/org/omg/dds/QosReaderEffectsTest.java::aFiniteDelayPurgesWhenItHasPassedWithoutAnyAccess

Status: done — ReaderDataLifecycle (getAutoPurgeNoWriterSamplesDelay, getAutoPurgeDisposedSamplesDelay, default infinite) in the DataReader QoS. DataReaderImpl.purgeLocked runs before every access and in the reader’s sweep: after autopurge_nowriter_samples_delay since NOT_ALIVE_NO_WRITERS it removes the instance with all untaken samples, after autopurge_disposed_samples_delay since NOT_ALIVE_DISPOSED all samples of the instance (DDS 1.4 §2.2.3.22). Infinite never purges; the delay of one state does not act on the other. Tested in QosReaderEffectsTest (default, delay 0 for both states, delay of the other state, finite delay without access). (commit 3389cd624cf) ### §7.3.5.2 Entity QoS as an interface based on EntityQos, direct access to the policies

Spec: §7.3.5.2, p. 21 — “Each Entity QoS (e.g., DataReaderQos) is an interface extending org.omg.dds.core.EntityQos. These sub-interfaces provide direct access to their policies as in the IDL PSM.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/EntityQos.java (EntityQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriterQos.java (DataWriterQos), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderQos.java (DataReaderQos)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::reliabilityAndHistoryQosDefaults, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::defaultQosIsTheQosOfWhatIsCreatedNext, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataWriterQos

Status: done — Seven interfaces (DomainParticipantFactoryQos, DomainParticipantQos, TopicQos, PublisherQos, SubscriberQos, DataWriterQos, DataReaderQos) extend EntityQos<...> and have one accessor per policy (getReliability, getHistory, getPartition, …). The tests read policies directly (DataReaderQos.getHistory, TopicQos.getReliability, DataWriterQos.getReliability, PublisherQos.getPartition). QosProfile no longer exists. ### §7.3.5.2 DomainParticipantFactoryQos

Spec: §7.3.5.2, p. 21; [DDS] 1.2 IDL, p. 167 (dds-1.2.pdf) — “struct DomainParticipantFactoryQos { EntityFactoryQosPolicy entity_factory; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactoryQos.java (DomainParticipantFactoryQos.getEntityFactory), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/DomainParticipantFactoryQosImpl.java (DomainParticipantFactoryQosImpl), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl.autoEnable)

Status: done — DomainParticipantFactoryQos has getEntityFactory; DomainParticipantFactoryImpl.autoEnable reads the value in create_participant. QosEntityFactoryTest::theParticipantFactoryDecidesWhetherTheParticipantsItCreatesAreEnabled sets a factory QoS with ENTITY_FACTORY false, reads getEntityFactory() back, checks that a created participant is not enabled (DomainParticipantImpl.isEnabled), that enable enables it, and restores the QoS. DomainParticipantFactoryImpl.setQos checks the QoS like every setQos. ### §7.3.5.2 DomainParticipantQos

Spec: §7.3.5.2, p. 21; [DDS] 1.2 IDL, p. 167 (dds-1.2.pdf) — “struct DomainParticipantQos { UserDataQosPolicy user_data; EntityFactoryQosPolicy entity_factory; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantQos.java (DomainParticipantQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/DomainParticipantQosImpl.java (DomainParticipantQosImpl), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.getQos)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::factoryQosAndDefaultParticipantQos, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::entityFactoryDecidesWhetherWhatIsCreatedIsEnabled, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::aParticipantAndTheFactoryTakeNewUserDataAndEntityFactory

Status: done — DomainParticipantQos has getUserData and getEntityFactory; a participant returns its QoS through getQos. factoryQosAndDefaultParticipantQos sets USER_DATA mine as default and checks that createParticipant(...).getQos() equals the QoS set; entityFactoryDecidesWhetherWhatIsCreatedIsEnabled checks the effect of ENTITY_FACTORY false. ### §7.3.5.2 TopicQos

Spec: §7.3.5.2, p. 21; [DDS] 1.2 IDL, p. 167–168 (dds-1.2.pdf) — “struct TopicQos { topic_data; durability; durability_service; deadline; latency_budget; liveliness; reliability; destination_order; history; resource_limits; transport_priority; lifespan; ownership; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicQos.java (TopicQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/TopicQosImpl.java (TopicQosImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::reliabilityAndHistoryQosDefaults, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theTopicQosAnswersWhatItWasGivenForEveryPolicyOfTable72

Status: done — TopicQos has the 13 policies of the IDL (topic_data to ownership) and getRepresentation and getTypeConsistency; TopicQosImpl.defaults sets all of them. Tested are Reliability, Durability, History, ResourceLimits, TransportPriority, Deadline, DurabilityService and TopicData (defaults and the round trip of the built-in topic data) and, with default and changed value, LatencyBudget, Liveliness, DestinationOrder, Lifespan and Ownership in QosTypesTest::theTopicQosAnswersWhatItWasGivenForEveryPolicyOfTable72. ### §7.3.5.2 PublisherQos

Spec: §7.3.5.2, p. 21; [DDS] 1.2 IDL, p. 168 (dds-1.2.pdf) — “struct PublisherQos { PresentationQosPolicy presentation; PartitionQosPolicy partition; GroupDataQosPolicy group_data; EntityFactoryQosPolicy entity_factory; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/PublisherQos.java (PublisherQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/PublisherQosImpl.java (PublisherQosImpl), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::partitionIsolatesNonOverlappingEndpoints, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::partitionMatchesOnOverlap, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::thePublicationWireFormCarriesTheQosOnTheParameterIdsOfTable913, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::thePublisherAndSubscriberQosAnswerPresentationEntityFactoryAndGroupData, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::aPublisherWithAutoEnableFalseCreatesDisabledWriters

Status: done — PublisherQos has getPresentation, getPartition, getGroupData, getEntityFactory. PARTITION affects matching (QosLifecycleTest), GROUP_DATA and PRESENTATION travel through built-in topic data and the wire. ENTITY_FACTORY at the publisher decides whether createDataWriter enables the writer (QosEntityFactoryTest); PRESENTATION takes part in the match of the endpoints (QosRequestedOfferedTest), the effect of coherent_access and ordered_access on delivery is missing (item on PRESENTATION). QosTypesTest::thePublisherAndSubscriberQosAnswerPresentationEntityFactoryAndGroupData checks the accessors with set values. (commit 8bc25e5d19b) ### §7.3.5.2 SubscriberQos

Spec: §7.3.5.2, p. 21; [DDS] 1.2 IDL, p. 169 (dds-1.2.pdf) — “struct SubscriberQos { PresentationQosPolicy presentation; PartitionQosPolicy partition; GroupDataQosPolicy group_data; EntityFactoryQosPolicy entity_factory; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/SubscriberQos.java (SubscriberQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/SubscriberQosImpl.java (SubscriberQosImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::partitionIsolatesNonOverlappingEndpoints, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::partitionWildcardMatches, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::nonOverlappingPartitionIsNotAMatch, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::thePublisherAndSubscriberQosAnswerPresentationEntityFactoryAndGroupData, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::aSubscriberWithAutoEnableFalseCreatesDisabledReaders

Status: done — SubscriberQos has getPresentation, getPartition, getGroupData, getEntityFactory. PARTITION is tested (separation, wildcards, no match reported to the listener, round trip of the subscription data). PRESENTATION, GROUP_DATA and ENTITY_FACTORY at the subscriber are checked by QosTypesTest::thePublisherAndSubscriberQosAnswerPresentationEntityFactoryAndGroupData; SubscriberImpl.createDataReader enables the reader only if entity_factory says so (QosEntityFactoryTest). (commit 8bc25e5d19b) ### §7.3.5.2 DataWriterQos

Spec: §7.3.5.2, p. 21; [DDS] 1.2 IDL, p. 168 (dds-1.2.pdf) — “struct DataWriterQos { durability; durability_service; deadline; latency_budget; liveliness; reliability; destination_order; history; resource_limits; transport_priority; lifespan; user_data; ownership; ownership_strength; writer_data_lifecycle; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriterQos.java (DataWriterQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/DataWriterQosImpl.java (DataWriterQosImpl)

Status: done — DataWriterQos has the 15 policies of the IDL and getRepresentation and getTypeConsistency; DataWriterQosImpl.defaults sets all of them. Tested are Durability, Deadline, LatencyBudget, Liveliness, Reliability, DestinationOrder, History, Lifespan, UserData, Ownership and OwnershipStrength and ResourceLimits, TransportPriority, DurabilityService and WriterDataLifecycle (QosTypesTest::theDataWriterQosAnswersWhatItWasGivenForTheRemainingPolicies, defaults in theDefaultsOfTheDataWriterQos). WRITER_DATA_LIFECYCLE acts on unregister and close (QosWriterDataLifecycleTest). ### §7.3.5.2 DataReaderQos

Spec: §7.3.5.2, p. 21; [DDS] 1.2 IDL, p. 168–169 (dds-1.2.pdf) — “struct DataReaderQos { durability; deadline; latency_budget; liveliness; reliability; destination_order; history; resource_limits; user_data; ownership; time_based_filter; reader_data_lifecycle; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderQos.java (DataReaderQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/DataReaderQosImpl.java (DataReaderQosImpl)

Status: done — DataReaderQos has the 12 policies of the IDL (durability to reader_data_lifecycle) and getRepresentation and getTypeConsistency; DataReaderQosImpl.defaults sets all of them. Tested are Durability, Deadline, Liveliness, Reliability, History, ResourceLimits, Ownership, UserData and TimeBasedFilter and LatencyBudget, DestinationOrder and ReaderDataLifecycle (QosTypesTest::theDataReaderQosAnswersWhatItWasGivenForTheRemainingPolicies, defaults in theDefaultsOfTheDataReaderQos). OwnershipStrength and Partition are not part of the reader QoS. ### §7.3.5.2 Access to the policies through java.util.Map

Spec: §7.3.5.2, p. 21 — “However, the base interface also provides for generic access using the java.util.Map interface. This interface allows applications to look up policies by ID and to iterate over them in a generic way, including vendor-specific extension policies, without introducing compile-time dependencies on vendor-specific APIs.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/EntityQos.java (EntityQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos.get), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos.entrySet), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosCompatibility.java (QosCompatibility.policiesOf)

Status: done — EntityQos<P> extends java.util.Map<Class<? extends P>, P> with get(Class<POLICY>); AbstractEntityQos provides get and an unmodifiable entrySet. reliabilityAndHistoryQosDefaults looks up with reader.get(Reliability.class); rxoDeadlineCompatibility iterates all entries of the QoS through QosCompatibility.policiesOf. ### §7.3.5.2 QoS not directly creatable, only from getQos or QosProvider

Spec: §7.3.5.2, p. 21 — “QoS objects cannot be created directly. They can be either retrieved from an entity (e.g., DataReader) using the getQoS method or looked up using a string identifier using the QoSProvider interface. QoS objects can be cloned from pre-existing state maintained by the Service implementation.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/DataWriterQosImpl.java (DataWriterQosImpl.defaults), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.getDefaultDataWriterQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.getQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosProviderImpl.java (QosProviderImpl)

Status: done — In the OMG API the QoS interfaces have no constructor; the constructors of the *QosImpl are private. QoS from entities and factories (getQos, getDefaultPublisherQos, getDefaultParticipantQos), deriving with withPolicy and the route through QosProvider are tested (QosProviderTest::entitiesAreCreatedFromTheQosOfAProvider, QosDefaultQosTest). The static method *QosImpl.defaults(environment) is public so that the tests (Qos.writer(), Qos.reader()) and QosProviderImpl can create default QoS; it is not a method of the OMG API. ### §7.3.5.2 QoS from entities and QosProvider immutable, changes through the QoS DSL

Spec: §7.3.5.2, p. 21 — “QoS objects as returned by Entities and QoSProvider shall be immutable; applications shall never observe them to change. Applications that wish to modify QoS values must use the “QoS DSL” supported by the QoS and Policy classes.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.getQos)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theMapOfAQosCannotBeChanged, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::withPolicyReturnsAnotherQosAndLeavesTheSourceAsItWas, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::aQosFromAnEntityIsNotChangedByDerivingFromIt

Status: done — AbstractEntityQos copies the policies into a map of its own, entrySet is unmodifiable, AbstractMap.put, remove, clear, putAll, keySet().remove, values().clear and the iterator remove raise UnsupportedOperationException; the policies have final fields, withPolicy creates a new object. Tested for all seven QoS kinds in QosTypesTest::theMapOfAQosCannotBeChanged; that the QoS of an entity stays unchanged after withPolicy and that the original is the same object is checked by withPolicyReturnsAnotherQosAndLeavesTheSourceAsItWas and aQosFromAnEntityIsNotChangedByDerivingFromIt. ### §7.3.5.3 Changes disallowed, new QoS and policies through a fluent DSL

Spec: §7.3.5.3, p. 21 — “Modifying QoS objects and their constituent policies is disallowed but a QoS DSL shall support creation of new QoS objects and policies from the existing objects using Java fluent interface design.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos.withPolicy), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos.withPolicies), crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/PolicyFactory.java (PolicyFactory)

Status: done — The DSL exists: QoS (withPolicy, withPolicies) and policies (withKeepLast, withManualByTopic().withLeaseDuration(...)) return a new object and chain; the values act in behaviour (transientLocalReplaysToLateJoiner, livelinessChangedReflectsWriterPresence). That the original stays unchanged and another object comes back is checked by QosTypesTest::withPolicyReturnsAnotherQosAndLeavesTheSourceAsItWas, everyWithOfAPolicyReturnsANewObjectAndLeavesTheSource and withPoliciesAppliesSeveralPoliciesAtOnce. ### §7.3.5.3 QoS classes with withPolicy and withPolicies

Spec: §7.3.5.3, p. 21 — “QoS classes shall provide withPolicy and withPolicies methods that accept one or more policy objects to create a new QoS object.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/EntityQos.java (EntityQos.withPolicy), crates/java-omgdds/java/src/main/java/org/omg/dds/core/EntityQos.java (EntityQos.withPolicies), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos.withPolicies)

Status: done — EntityQos.withPolicy(P) and withPolicies(P...) exist in EntityQos and AbstractEntityQos; withPolicy is used in many tests. QosTypesTest::withPoliciesAppliesSeveralPoliciesAtOnce checks withPolicies with several policies and with none; aPolicyThatIsNoPolicyOfTheQosIsRefused checks the IllegalArgumentException of AbstractEntityQos.policyKey for a policy that names itself only as a reader policy and is none of the policies of Table 7.2. ### §7.3.5.3 Policy classes with with methods

Spec: §7.3.5.3, p. 21 — “Policy classes shall provide with methods to specify policy parameters and to create new policy objects from the existing ones.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Liveliness.java (Liveliness), crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Reliability.java (Reliability), crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/History.java (History), crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/ResourceLimits.java (ResourceLimits)

Status: done — All policy interfaces have with* methods for their parameters (Liveliness.withKind/withLeaseDuration, Reliability.withMaxBlockingTime, History.withDepth, ResourceLimits.withMaxSamples …). thePublicationWireFormCarriesTheQosOnTheParameterIdsOfTable913 builds policies this way and checks the values byte by byte on the wire; historyDepthMustBeNonNegative checks the value check in withDepth. ### §7.3.5.3 Every with creates a new object, chaining

Spec: §7.3.5.3, p. 21 — “Each with method call will create a new policy object because the target object of the method call is immutable. The with methods shall support method chaining (QoS DSL).”

Status: done — Chaining is tested (two withPolicy in a row; Liveliness().withManualByTopic().withLeaseDuration(...)), and the chained values act. That every with creates a new object and leaves the target unchanged is checked by QosTypesTest::withPolicyReturnsAnotherQosAndLeavesTheSourceAsItWas (assertNotSame, the source keeps its old value) and everyWithOfAPolicyReturnsANewObjectAndLeavesTheSource for Reliability, History, ResourceLimits, Deadline, Partition, UserData, Presentation and Durability; withCallsChainOnePolicyIntoTheNext checks chaining. ### §7.3.5.3 Example pf.ResourceLimits().withMaxSamples(P).withMaxInstances(Q)

Spec: §7.3.5.3, p. 22 — “Example (non-normative) PolicyFactory pf = … // object policy factory reference ResourceLimits rl = pf.ResourceLimits().withMaxSamples(P).withMaxInstances(Q);”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/PolicyFactory.java (PolicyFactory.ResourceLimits)

Status: n/a (informative) — Example (non-normative). The construction is possible with the current API: PolicyFactory.ResourceLimits().withMaxSamples(..).withMaxInstances(..); everyBuiltinDataTypeRoundTripsItsQos calls it. The method is named ResourceLimits() as in the OMG sources. QosTypesTest::withCallsChainOnePolicyIntoTheNext checks the chain with the values 20, 6 and LENGTH_UNLIMITED. ### §7.3.5.3 Rationale: getQos without a copy

Spec: §7.3.5.3, p. 22 — “Design Rationale (non-normative) • The getQos operation can operate maximally efficiently: it need not allocate any memory or perform any copies. […]”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.getQos)

Tests: —

Status: n/a (informative) — Design rationale (non-normative). getQos returns the stored immutable object without a copy; DomainParticipantOperationsTest::factoryQosAndDefaultParticipantQos checks with assertSame that getQos returns the object that was set. ### §7.3.5.4 org.omg.dds.core.QosProvider returns QoS from library and profile

Spec: §7.3.5.4, p. 22 — “The org.omg.dds.core.QosProvider interface allows Entity’s Qos to be obtained from the names of QoS library and profile.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::theQosOfEveryEntityKindCarriesTheValuesOfTheDocument, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::theWriterAndReaderQosCarryTheValuesOfTheDocumentAndKeepTheDefaultsOfWhatItLeavesOut, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::aProfileWithoutAnElementOfAKindHasNoQosOfThatKind, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::theFactoryQosHasItsOwnElement, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::anIdCanNameAnotherProfileOrAnElementOfIt

Status: done — QosProvider (abstract class) has getDomainParticipantFactoryQos, getDomainParticipantQos, getTopicQos, getSubscriberQos, getPublisherQos, getDataReaderQos, getDataWriterQos each without and with id; QosProviderImpl reads the XML library. QosProviderTest writes a library to a file, loads it through QosProvider.newQosProvider(uri, profile, env) and reads the QoS of each entity kind (without and with id), with the values of the document and the defaults for what it leaves out. An id is the name of the element, library::profile or library::profile::name; a profile without an element of the kind or an unknown id is IllegalArgumentException. (commit a68b0889e7a) ### §7.3.5.4 Source as a URI, prefix file:// mandatory

Spec: §7.3.5.4, p. 22 — “The Qos library source is provided as a uniform resource identifier (URI). Conforming implementation must support “file://” prefix. For instance, “file:///path/to/qos/library.””

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosProviderImpl.java (QosProviderImpl.read)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::aFileUriIsReadAndTheProviderIsObtainedFromTheEnvironment, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::anotherSchemeIsUnsupported

Status: done — QosProviderImpl.read accepts the scheme file (Paths.get(URI)) and raises UnsupportedOperationException for every other scheme, also for none. QosProviderTest::aFileUriIsReadAndTheProviderIsObtainedFromTheEnvironment loads a file:///… URI, anotherSchemeIsUnsupported checks http, ftp and data. (commit a68b0889e7a) ### §7.3.5.4 QosProvider from ServiceEnvironment.newQosProvider(uri, profile)

Spec: §7.3.5.4, p. 22 — “An instance of QosProvider is obtained from the ServiceEnvironment. For example, serviceEnv.newQosProvider(String uri, String profile);”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/QosProvider.java (QosProvider.newQosProvider), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.newQosProvider), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::aFileUriIsReadAndTheProviderIsObtainedFromTheEnvironment

Status: done — The call serviceEnv.newQosProvider(uri, profile) of the example exists as QosProvider.newQosProvider(uri, profile, env), which delegates to env.getSPI().newQosProvider(uri, profile) (ServiceProviderInterface, implemented in ServiceEnvironmentImpl); ServiceEnvironment itself has no such method (as in the OMG sources). QosProviderTest::aFileUriIsReadAndTheProviderIsObtainedFromTheEnvironment calls both routes and compares the QoS. ### §7.3.5.4 uri in standard syntax, profile unique within the document

Spec: §7.3.5.4, p. 22 — “The uri parameter uses the standard uri syntax. The profile parameter identifies a uniquely identified profile in the document referred by the uri.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosProviderImpl.java (QosProviderImpl.read), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosProviderImpl.java (QosProviderImpl.selectProfile)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::aUriThatIsNoUriAndAFileThatIsNotThereAreRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::aProfileIsSelectedByQualifiedNameByUniqueNameOrAsTheFirst, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::aProfileNameThatTwoProfilesShareIsNotUnique

Status: done — QosProviderImpl forms new URI(uri) (error: IllegalArgumentException) and selects the profile as library::profile, as a name that is unique in the file or, for null, the first one. An unknown profile is IllegalArgumentException; so is a name two profiles carry, and two profiles of one name in a library are already refused when reading. Tested in QosProviderTest::aUriThatIsNoUriAndAFileThatIsNotThereAreRefused, aProfileIsSelectedByQualifiedNameByUniqueNameOrAsTheFirst, aProfileNameThatTwoProfilesShareIsNotUnique. (commit a68b0889e7a) ### §7.3.5.4 Factories create entities and set defaults from QoS objects or QosProvider

Spec: §7.3.5.4, p. 22 — “Each Entity factory interface DomainParticipantFactory, DomainParticipant, Publisher, and Subscriber provides methods to create new “product” Entities and to set their default QoS based on QoS objects created programmatically or obtained through QosProvider.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher.createDataWriter), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Subscriber.java (Subscriber.createDataReader), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.setDefaultPublisherQos), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory.setDefaultParticipantQos)

Status: done — The factories DomainParticipantFactory, DomainParticipant, Publisher and Subscriber create entities with a QoS and have setDefault…Qos/getDefault…Qos; the default is checked for consistency. Tested in QosDefaultQosTest: setDefaultTopicQos, setDefaultSubscriberQos, setDefaultPublisherQos, Publisher.setDefaultDataWriterQos, Subscriber.setDefaultDataReaderQos, DomainParticipantFactory.setDefaultParticipantQos and the refusal of a self-contradicting default; QosProviderTest::entitiesAreCreatedFromTheQosOfAProvider creates entities from provider QoS. (commit 8bc25e5d19b) ### §7.3.6 All entities extend Entity

Spec: §7.3.6, p. 22 — “As in the DDS PIM, all Entity interfaces extend—directly or indirectly—the interface Entity.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity), crates/java-omgdds/java/src/main/java/org/omg/dds/core/DomainEntity.java (DomainEntity), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Subscriber.java (Subscriber), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/Topic.java (Topic)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCascadeTest.java::publisherCloseClosesItsWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::closeContainedEntitiesClosesThemWithoutClosingTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityBasicsTest.java::everyEntityExtendsEntityAndEveryOneButTheParticipantExtendsDomainEntity

Status: done — DomainParticipant extends Entity; Publisher, Subscriber, DataWriter, DataReader and Topic extend DomainEntity, which extends Entity (read). The test uses Qos.isClosed(Entity<?, ?>) with DomainParticipant, Publisher and DataWriter, which compiles only if they are Entity; no test covers the inheritance of the other three. This is a pure signature requirement. QosEntityBasicsTest::everyEntityExtendsEntityAndEveryOneButTheParticipantExtendsDomainEntity checks the inheritance of all six types with isAssignableFrom. ### §7.3.6 Entity generic over QoS and listener type

Spec: §7.3.6, p. 22 — “In this PSM, this interface is generic; it is parameterized by the Entity’s QoS and listener types. These parameters allow applications to call common operations like getQos or getListener in a type-safe way while still working with Entities polymorphically.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.getQos), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.getListener)

Status: done — Entity<LISTENER extends EventListener, QOS extends EntityQos<?>> with getQos() and getListener(); the sub-interfaces bind the types (Publisher extends DomainEntity<PublisherListener, PublisherQos>). defaultQosIsTheQosOfWhatIsCreatedNext reads createPublisher().getQos() as PublisherQos, clearingTheListenerStopsDelivery reads getListener() of a DataReader; both compile only with the type parameters. ### §7.3.6 Entity extends java.io.Closeable

Spec: §7.3.6, p. 22 — “The Entity interface extends java.io.Closeable interface to support specific new language constructs (e.g., Java 7 try-with-resources) for dealing with all Entities polymorphically.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityBasicsTest.java::entityExtendsCloseable

Status: done — Entity extends Closeable, DDSObject (Entity.java). QosEntityBasicsTest::entityExtendsCloseable checks Closeable.class.isAssignableFrom(Entity.class) and holds publisher, subscriber, topic, DataWriter and DataReader as java.io.Closeable, closes them through it and checks the state with Qos.isClosed. ### §7.3.6 Entities other than DomainParticipant extend DomainEntity with getParent

Spec: §7.3.6, p. 22 — “Also as in the DDS PIM, Entities other than DomainParticipant extend the interface DomainEntity. These Entities provide operations to get the creating parent Entity; in this PSM, this operation is the polymorphic DomainEntity.getParent.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/DomainEntity.java (DomainEntity.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getParent), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.getParent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityBasicsTest.java::theParentOfAnEntityIsTheEntityThatCreatedIt

Status: done — DomainEntity.getParent exists; publisher, subscriber and topic return the participant, DataWriter the publisher, DataReader the subscriber. QosEntityBasicsTest::theParentOfAnEntityIsTheEntityThatCreatedIt checks all five relations with assertSame. ### §7.3.7 Statuses, listeners, conditions and wait sets

Spec: §7.3.7, p. 22 — “This sub clause describes the objects pertaining to the status changes of DDS Entities: the Status types themselves, listeners, conditions, and wait sets.”

Repo: —

Tests: —

Status: n/a (informative) — Introduction without a requirement of its own. ### §7.3.7.1 Every status as an abstract class based on org.omg.dds.core.Status, which extends EventObject

Spec: §7.3.7.1, p. 23 — “This PSM represents each status identified by the DDS PIM as an abstract class extending org.omg.dds.core.Status, which in turn extends java.util.EventObject.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/Status.java (Status), crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/SubscriptionMatchedStatus.java (SubscriptionMatchedStatus), crates/java-omgdds/java/src/main/java/org/omg/dds/core/event/StatusChangedEvent.java (StatusChangedEvent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::aStatusKeepsItsCounts, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityBasicsTest.java::theThirteenStatusKindsAreClassesOfTheStatusBase, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityBasicsTest.java::theEventThatCarriesAStatusIsAnEventObjectWithTheEntityAsSource, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreApiShapeTest.java::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource

Status: done — All 13 statuses are abstract classes with the base org.omg.dds.core.status.Status (QosEntityBasicsTest::theThirteenStatusKindsAreClassesOfTheStatusBase, also Serializable). The text says Status extends EventObject; the source omgdds_src.zip, which prevails under §2 when they conflict, declares Status as abstract class Status implements Serializable, DDSObject without EventObject, and org/omg/dds stays equal to the source (CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource). The java.util.EventObject is carried by StatusChangedEvent: it has getSource() (the entity) and getStatus(); QosEntityBasicsTest::theEventThatCarriesAStatusIsAnEventObjectWithTheEntityAsSource checks that on a PublicationMatchedEvent. (commit 72b36ae5db2) ### §7.3.7.1 Status kinds as Class objects, masks as a Set

Spec: §7.3.7.1, p. 23 — “This PSM represents status kinds using the java.lang.Class instances of the corresponding status classes and status masks as java.util.Sets of such status classes.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.getStatusChanges), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.setListener), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface.allStatusKinds), crates/java-omgdds/java/src/main/java/org/omg/dds/core/StatusCondition.java (StatusCondition.setEnabledStatuses)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aStatusIsResetWhenItIsReadAndDataAvailableWhenTheSamplesAreTaken, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aStatusConditionTriggersOnTheStatusItIsEnabledForAndHasItsEntityAsParent, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories

Status: done — Status kinds are Class<? extends Status>, masks are Set/Collection of them: Entity.getStatusChanges, setListener(listener, statuses), StatusCondition.setEnabledStatuses, allStatusKinds/noStatusKinds. The tests read getStatusChanges().contains(DataAvailableStatus.class), set and read the enabled statuses of a StatusCondition, and check allStatusKinds().size() == 13 and noStatusKinds().isEmpty(). ### §7.3.7.1 Statuses in callbacks reusable, applications copy

Spec: §7.3.7.1, p. 23 — “Status objects passed to listeners in callbacks may be pooled and reused by the implementation. Therefore, applications that wish to retain these objects—or any objects found within them, such as instance handles—for later use outside of the callback are responsible for copying them.”

Repo: —

Tests: —

Status: n/a (informative) — Permission for the implementation and duty of the application; there is no requirement on the code that could be met. ZeroDDS creates a new status object per callback (DataReaderImpl: new RequestedDeadlineMissedStatusImpl(...) among others, read). ### §7.3.7.1 InconsistentTopicStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 132, IDL p. 159 (dds-1.2.pdf) — “struct InconsistentTopicStatus { long total_count; long total_count_change; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/InconsistentTopicStatus.java (InconsistentTopicStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/InconsistentTopicStatusImpl.java (InconsistentTopicStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.getInconsistentTopicStatus), crates/java-omgdds/java/src/main/java/org/zerodds/topic/TopicImpl.java (TopicImpl.onInconsistentTopic)

Status: done — Two topics of the same name and different type names in one domain count INCONSISTENT_TOPIC (TopicImpl.onInconsistentTopic) and call the TopicListener; the test states both. ### §7.3.7.1 SampleLostStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133, IDL p. 159 (dds-1.2.pdf) — “struct SampleLostStatus { long total_count; long total_count_change; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/SampleLostStatus.java (SampleLostStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/SampleLostStatusImpl.java (SampleLostStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.noteSequence), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getSampleLostStatus)

Status: done — DataReaderImpl.noteSequence counts gaps in the sequence numbers per writer; SampleLostStatus reports getTotalCount and getTotalCountChange (reset on read), onSampleLost the event. Both tests deliver samples through deliverWire. (commit e1b55167947) ### §7.3.7.1 SampleRejectedStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133, IDL p. 159 (dds-1.2.pdf) — “struct SampleRejectedStatus { long total_count; long total_count_change; SampleRejectedStatusKind last_reason; InstanceHandle_t last_instance_handle; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/SampleRejectedStatus.java (SampleRejectedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/SampleRejectedStatusImpl.java (SampleRejectedStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.rejectedByLimits)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aSampleBeyondMaxSamplesIsRejectedAndReportedToTheListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderLimitsTest.java::aSampleOfANewInstanceBeyondMaxInstancesIsRejectedWithThatReasonAndInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderLimitsTest.java::aSampleBeyondMaxSamplesPerInstanceIsRejectedWithThatReasonAndInstance

Status: done — ReaderLimitsTest checks the reasons REJECTED_BY_INSTANCES_LIMIT and REJECTED_BY_SAMPLES_PER_INSTANCE_LIMIT with getLastInstanceHandle (derived by hand from the key) and the change value; ReaderStatusTest checks REJECTED_BY_SAMPLES_LIMIT and the listener. (commit e1b55167947) ### §7.3.7.1 LivelinessLostStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133, IDL p. 159 (dds-1.2.pdf) — “struct LivelinessLostStatus { long total_count; long total_count_change; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/LivelinessLostStatus.java (LivelinessLostStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/LivelinessLostStatusImpl.java (LivelinessLostStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getLivelinessLostStatus), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.evaluateLiveliness)

Status: done — DataWriterImpl.getLivelinessLostStatus counts the loss once and resets the change when read; the test checks the counts, the change and the listener. ### §7.3.7.1 LivelinessChangedStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133, IDL p. 159–160 (dds-1.2.pdf) — “struct LivelinessChangedStatus { long alive_count; long not_alive_count; long alive_count_change; long not_alive_count_change; InstanceHandle_t last_publication_handle; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/LivelinessChangedStatus.java (LivelinessChangedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/LivelinessChangedStatusImpl.java (LivelinessChangedStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getLivelinessChangedStatus)

Status: done — DataReaderImpl.getLivelinessChangedStatus and the listener path set lastPublicationHandle to the handle of the writer whose liveliness changed last. ReaderStatusDetailTest checks getLastPublicationHandle, getAliveCountChange (+1, then -1) and getNotAliveCountChange (+1). (commit e1b55167947) ### §7.3.7.1 OfferedDeadlineMissedStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133, IDL p. 160 (dds-1.2.pdf) — “struct OfferedDeadlineMissedStatus { long total_count; long total_count_change; InstanceHandle_t last_instance_handle; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/OfferedDeadlineMissedStatus.java (OfferedDeadlineMissedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/OfferedDeadlineMissedStatusImpl.java (OfferedDeadlineMissedStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getOfferedDeadlineMissedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.evaluateOfferedDeadline)

Status: done — DataWriterImpl.getOfferedDeadlineMissedStatus returns total_count, total_count_change and last_instance_handle; the test checks all three and the listener. ### §7.3.7.1 RequestedDeadlineMissedStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133, IDL p. 160 (dds-1.2.pdf) — “struct RequestedDeadlineMissedStatus { long total_count; long total_count_change; InstanceHandle_t last_instance_handle; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/RequestedDeadlineMissedStatus.java (RequestedDeadlineMissedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/RequestedDeadlineMissedStatusImpl.java (RequestedDeadlineMissedStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getRequestedDeadlineMissedStatus)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::requestedDeadlineMissedIsRaised, crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::requestedDeadlineMissedFiresWithoutPolling, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::requestedDeadlineMissedNamesTheInstanceThatMissedLast, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::theChangeOfRequestedDeadlineMissedStartsAgainWhenTheStatusIsRead

Status: done — ReaderStatusDetailTest checks getLastInstanceHandle with two instances and the change value 0 on the second read. (commit e1b55167947) ### §7.3.7.1 OfferedIncompatibleQosStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133, IDL p. 160 (dds-1.2.pdf) — “struct OfferedIncompatibleQosStatus { long total_count; long total_count_change; QosPolicyId_t last_policy_id; QosPolicyCountSeq policies; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/OfferedIncompatibleQosStatus.java (OfferedIncompatibleQosStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/OfferedIncompatibleQosStatusImpl.java (OfferedIncompatibleQosStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getOfferedIncompatibleQosStatus)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::anIncompatibleReaderIsCountedWithTheRefusedPolicy

Status: done — DataWriterImpl.getOfferedIncompatibleQosStatus counts the refused reader with last_policy_id and the policy list and calls onOfferedIncompatibleQos; the test checks the count, the policy and the listener. ### §7.3.7.1 RequestedIncompatibleQosStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133, IDL p. 160 (dds-1.2.pdf) — “struct RequestedIncompatibleQosStatus { long total_count; long total_count_change; QosPolicyId_t last_policy_id; QosPolicyCountSeq policies; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/RequestedIncompatibleQosStatus.java (RequestedIncompatibleQosStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/RequestedIncompatibleQosStatusImpl.java (RequestedIncompatibleQosStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getRequestedIncompatibleQosStatus)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aWriterThatOffersLessThanRequestedIsReportedToTheListener, crates/java-omgdds/java/src/test/java/org/omg/dds/QosCompatibilityTest.java::incompatibleReliabilityDoesNotConnect, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::requestedIncompatibleQosCountsTheRefusingPolicyAndResetsItsChange, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::everyPolicyThatRefusesTheConnectionIsCountedAndOneConnectionIsOneInTotal, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::thePresentationOfTheSubscriberMustBeOfferedByThePublisher

Status: done — ReaderStatusDetailTest checks getPolicies (one QosPolicyCount per refusing policy with count 1), getTotalCountChange and getLastPolicyClass; ReaderStatusTest the event. (commit d17c5f0c379) ### §7.3.7.1 PublicationMatchedStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133, IDL p. 160 (dds-1.2.pdf) — “struct PublicationMatchedStatus { long total_count; long total_count_change; long current_count; long current_count_change; InstanceHandle_t last_subscription_handle; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/PublicationMatchedStatus.java (PublicationMatchedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/PublicationMatchedStatusImpl.java (PublicationMatchedStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.getPublicationMatchedStatus)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::thePublicationMatchedStatusCountsAndNamesTheLastSubscription

Status: done — DataWriterImpl.readPublicationMatchedStatusLocked returns last_subscription_handle of the reader matched last; the test compares it with getMatchedSubscriptions. ### §7.3.7.1 SubscriptionMatchedStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133, IDL p. 160–161 (dds-1.2.pdf) — “struct SubscriptionMatchedStatus { long total_count; long total_count_change; long current_count; long current_count_change; InstanceHandle_t last_publication_handle; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/SubscriptionMatchedStatus.java (SubscriptionMatchedStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/SubscriptionMatchedStatusImpl.java (SubscriptionMatchedStatusImpl), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getSubscriptionMatchedStatus)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::statusIsReadableWithoutAListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::readerListenerFiresOnMatchAndOnEverySample, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aStatusIsResetWhenItIsReadAndDataAvailableWhenTheSamplesAreTaken, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::subscriptionMatchedNamesTheWriterThatConnectedOrLeftLast

Status: done — DataReaderImpl.getSubscriptionMatchedStatus and the listener path set lastPublicationHandle; ReaderStatusDetailTest checks the handle and getTotalCountChange and getCurrentCountChange (also -1 after a writer closes). (commit e1b55167947) ### §7.3.7.1 DataAvailableStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133 (dds-1.2.pdf) — “DataReader | DATA_AVAILABLE | New information is available.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/DataAvailableStatus.java (DataAvailableStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/DataAvailableStatusImpl.java (DataAvailableStatusImpl), crates/java-omgdds/java/src/main/java/org/omg/dds/core/event/DataAvailableEvent.java (DataAvailableEvent), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.fireDataAvailable)

Status: done — DataAvailableStatus is now a class; DataReaderListener.onDataAvailable receives a DataAvailableEvent with getStatus() and getSource(). ListenerTest checks one call per sample with the reader itself as source; ReaderStatusTest checks that getStatusChanges() contains DataAvailableStatus after a write and no longer after take(). (commit 28e25c198d1) ### §7.3.7.1 DataOnReadersStatus

Spec: §7.3.7.1, p. 23; [DDS] 1.2 §7.1.4.1, p. 133 (dds-1.2.pdf) — “Subscriber | DATA_ON_READERS | New information is available.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/DataOnReadersStatus.java (DataOnReadersStatus), crates/java-omgdds/java/src/main/java/org/zerodds/core/status/DataOnReadersStatusImpl.java (DataOnReadersStatusImpl), crates/java-omgdds/java/src/main/java/org/omg/dds/core/event/DataOnReadersEvent.java (DataOnReadersEvent), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/SubscriberListener.java (SubscriberListener.onDataOnReaders)

Status: done — DataReaderImpl.fireDataAvailable sets the flag DATA_ON_READERS on the subscriber (SubscriberImpl.dataOnReadersChanged) and calls SubscriberListener.onDataOnReaders with a DataOnReadersEvent. Without a listener the flag stays in getStatusChanges() until a reader of the subscriber is read or taken; with a listener it is reset after the call. (commit e1b55167947) ### §7.3.7.2 Listeners extend java.util.EventListener

Spec: §7.3.7.2, p. 23 — “This PSM maps the Listener interface from the DDS PIM to the empty marker interface java.util.EventListener interface defined by the Java SE standard library.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderListener.java (DataReaderListener), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriterListener.java (DataWriterListener), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicListener.java (TopicListener), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/PublisherListener.java (PublisherListener), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/SubscriberListener.java (SubscriberListener), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantListener.java (DomainParticipantListener), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity)

Status: done — TopicListener, PublisherListener, SubscriberListener and DomainParticipantListener are called and pass on statuses they do not take; the three tests check Publisher, Subscriber (DATA_ON_READERS too), Participant and Topic. ### §7.3.7.2 Adapter classes with empty methods, named with “Adapter”

Spec: §7.3.7.2, p. 23 — “For each listener sub-interface (e.g., DataWriterListener), this PSM provides a concrete implementation of that interface in which all methods have empty implementations. These concrete classes are named like the listener interfaces they implement, but with the word “Listener” replaced by “Adapter.””

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderAdapter.java (DataReaderAdapter), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriterAdapter.java (DataWriterAdapter), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicAdapter.java (TopicAdapter), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/PublisherAdapter.java (PublisherAdapter), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/SubscriberAdapter.java (SubscriberAdapter), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantAdapter.java (DomainParticipantAdapter)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicOfTheSameNameAndAnotherTypeInTheDomainIsInconsistentAndTellsTheTopicListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createPublisherWithAListenerSeesTheMatchOfAWriterCreatedLater, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createSubscriberWithAListenerSeesTheMatchOfAReaderCreatedLater, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createParticipantWithAListenerAndAMaskReachesItFromTheWritersOfTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::readerListenerFiresOnMatchAndOnEverySample, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::writerListenerFiresOnPublicationMatched, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantSubscriberTest.java::aWriterListenerThatDoesNotTakeAStatusLeavesItToThePublisher

Status: done — Six adapter classes (DataReaderAdapter, DataWriterAdapter, TopicAdapter, PublisherAdapter, SubscriberAdapter, DomainParticipantAdapter) implement their listener interface with empty methods. The tests override single methods: TopicAdapter (TopicOperationsTest), PublisherAdapter (ParticipantEntityTest, PublisherOperationsTest), SubscriberAdapter (ParticipantEntityTest, ListenerPropagationTest), DomainParticipantAdapter (ParticipantEntityTest, TopicOperationsTest, PublisherOperationsTest), DataReaderAdapter and DataWriterAdapter (ListenerTest, ParticipantSubscriberTest). (commit d23eff980f3) ### §7.3.7.2 Callback without the entity, source through the status

Spec: §7.3.7.2, p. 23 — “In the DDS PIM, each listener callback receives two arguments: the Entity, the status of which has changed, and the new value of that status. In this PSM, the former is unnecessary and is omitted: it is available through the read-only Source property of the status object.”

Status: done — Each callback has exactly one argument, a StatusChangedEvent (extends java.util.EventObject) with getSource() and getStatus(). The tests read the entity through status.getSource() and assertSame it to their own reader or writer. The source is on the event, not on the Status class. (commit d23eff980f3) ### §7.3.7.2 Rationale: listener and adapter

Spec: §7.3.7.2, p. 23 — “Design Rationale (non-normative) The listener + adapter design pattern is consistent with that used in the standard AWT and Swing UI libraries and elsewhere.”

Repo: —

Tests: —

Status: n/a (informative) — Design rationale (non-normative); no requirement that can be met. ### §7.3.7.2 Lower-level listeners generic: TopicListener, DataReaderListener, DataWriterListener

Spec: §7.3.7.2, p. 23 — “The former category includes TopicListener, DataReaderListener, and DataWriterListener. These classes are generic; their type parameters match that of the Entities on which they are set. This convention allows applications to read and write data within the context of a callback in a statically type-safe way.”

Status: done — DataReaderListener, DataWriterListener and TopicListener are parameterized by the data type; the events carry the same parameter. TopicImpl calls onInconsistentTopic (TopicImpl.onInconsistentTopic). Tests: TopicOperationsTest::aTopicOfTheSameNameAndAnotherTypeInTheDomainIsInconsistentAndTellsTheTopicListener (TopicAdapter, getSource() as Topic without a cast), ListenerTest::readerListenerFiresOnMatchAndOnEverySample, ::writerListenerFiresOnPublicationMatched. (commit cd8f3d67ea9) ### §7.3.7.2 Higher-level listeners with the wildcard ?, no inheritance to the lower-level ones

Spec: §7.3.7.2, p. 23 — “The latter category includes PublisherListener, SubscriberListener, and DomainParticipantListener. The Topics, DataReaders, and DataWriters passed to these listeners’ callbacks are parameterized with the generic wildcard ‘?’. Because of this difference between these listeners and those in the former category, there are no inheritance relationships between these categories, unlike in the PIM.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/PublisherListener.java (PublisherListener), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/SubscriberListener.java (SubscriberListener), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantListener.java (DomainParticipantListener)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createPublisherWithAListenerSeesTheMatchOfAWriterCreatedLater, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createSubscriberWithAListenerSeesTheMatchOfAReaderCreatedLater, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::createParticipantWithAListenerAndAMaskReachesItFromTheWritersOfTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aWriterWithoutListenerPassesOfferedIncompatibleQosToThePublisher, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aWriterWithoutListenerAndAPublisherWithoutOnePassItToTheParticipantListener, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicWithoutListenerPassesInconsistentTopicToTheParticipantListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerPropagationTest.java::aReaderListenerSetAtCreationSeesTheMatchOfEnableAndTheSubscriberGetsDataOnReaders

Status: done — PublisherListener, SubscriberListener and DomainParticipantListener take events with a wildcard (e.g. PublicationMatchedEvent<?>); DomainParticipantListener extends PublisherListener and SubscriberListener. The classes PublisherImpl, SubscriberImpl and DomainParticipantImpl store the listener in EntityBase, and DataWriterImpl, DataReaderImpl and TopicImpl call it through ListenerUp. Tests: PublisherAdapter with onPublicationMatched and onOfferedIncompatibleQos (ParticipantEntityTest::createPublisherWithAListenerSeesTheMatchOfAWriterCreatedLater, PublisherOperationsTest::aWriterWithoutListenerPassesOfferedIncompatibleQosToThePublisher), SubscriberAdapter with onSubscriptionMatched (ParticipantEntityTest::createSubscriberWithAListenerSeesTheMatchOfAReaderCreatedLater) and onDataOnReaders (ListenerPropagationTest), DomainParticipantAdapter with onPublicationMatched, onOfferedIncompatibleQos and onInconsistentTopic (ParticipantEntityTest, PublisherOperationsTest, TopicOperationsTest). (commit f31b6fa11b5) ### §7.3.7.3 Conditions based on org.omg.dds.core.Condition

Spec: §7.3.7.3, p. 23 — “Conditions extend the base interface org.omg.dds.core.Condition.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Condition.java (Condition), crates/java-omgdds/java/src/main/java/org/omg/dds/core/GuardCondition.java (GuardCondition), crates/java-omgdds/java/src/main/java/org/omg/dds/core/StatusCondition.java (StatusCondition), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/ReadCondition.java (ReadCondition)

Status: done — org.omg.dds.core.Condition with getTriggerValue; GuardCondition, StatusCondition and ReadCondition extend it. The tests attach all three kinds through attachCondition(Condition) to a WaitSet and read getTriggerValue and the list of active conditions. (commit 5041698cee3) ### §7.3.7.3 StatusCondition generic with getParent

Spec: §7.3.7.3, p. 23 — “The interface StatusCondition, which extends Condition, is a generic interface with a type parameter that is the type of the Entity to which it belongs. This type parameter allows its getParent method to be both polymorphic and type safe.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/StatusCondition.java (StatusCondition), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/StatusConditionImpl.java (StatusConditionImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aStatusConditionTriggersOnTheStatusItIsEnabledForAndHasItsEntityAsParent

Status: done — StatusCondition<ENTITY extends Entity<?, ?>> extends Condition and has ENTITY getParent(). The test types StatusCondition<DataReader<byte[]>> without a cast and checks assertSame(reader, condition.getParent()). It also checks triggering by SUBSCRIPTION_MATCHED and switching off through setEnabledStatuses. (commit d23eff980f3) ### §7.3.7.4 WaitSet based on org.omg.dds.core.WaitSet

Spec: §7.3.7.4, p. 23 — “Wait sets extend the base interface org.omg.dds.core.WaitSet.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/WaitSet.java (WaitSet), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl)

Status: done — org.omg.dds.core.WaitSet is an abstract class with newWaitSet(ServiceEnvironment), attachCondition, detachCondition, getConditions and waitForConditions. The tests check attaching (a second attach has no effect), detaching (PreconditionNotMetException for a condition not attached) and the refusal of a second waiting thread. (commit 5041698cee3) ### §7.3.7.4 wait as waitForConditions

Spec: §7.3.7.4, p. 24 — “Therefore, this PSM maps the DDS PIM wait operation to the more explicit method name waitForConditions.”

Status: done — WaitSet has six overloads of waitForConditions (no arguments, with a list of active conditions, with a timeout as Duration or long/TimeUnit); there is no method named wait. The tests check TimeoutException after 30 ms, blocking without a timeout until a GuardCondition is set, and the triggered condition returned in the passed list. (commit 5041698cee3)

§7.4 Domain Module

§7.4 Package `org.omg.dds.domain`

Spec: §7.4, p. 24 — “This PSM realizes the Domain Module from the DDS specification with the package org.omg.dds.domain. This package contains DomainParticipant, DomainParticipantFactory, and so forth.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/, crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantListener.java (DomainParticipantListener)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — The package org.omg.dds.domain contains DomainParticipant, DomainParticipantFactory, DomainParticipantListener, DomainParticipantAdapter, DomainParticipantQos and DomainParticipantFactoryQos. The test creates a DomainParticipant through DomainParticipantFactory and writes and reads with it. (commit 0840f9ed436) ### §7.4.1 DomainParticipantFactory a singleton per ServiceEnvironment

Spec: §7.4.1, p. 24 — “The DomainParticipantFactory is a per-ServiceEnvironment singleton. An instance of this interface can be obtained by passing that ServiceEnvironment to the factory’s getInstance method.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory.getInstance), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.ZeroSPI.getParticipantFactory), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl)

Status: done — getInstance(ServiceEnvironment) returns env.getSPI().getParticipantFactory(); ZeroSPI holds one DomainParticipantFactoryImpl per environment, created under a lock on first access. Tests: QuickstartApiTest::serviceEnvironmentBootstrapBySystemProperty (assertSame for the same environment, assertNotSame against the factory of another), ::getInstanceRejectsNullEnvironment, ParticipantFactoryEnvironmentTest::threadsThatAskForTheFactoryOfANewEnvironmentTogetherGetTheSameOne (eight threads, 25 rounds). (commit 36e8fd3f496) ### §7.4.1 A factory of its own per ServiceEnvironment

Spec: §7.4.1, p. 24 — “The DomainParticipantFactory is a per-ServiceEnvironment singleton.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.ZeroSPI.getParticipantFactory), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantFactoryImpl.java (DomainParticipantFactoryImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentBootstrapBySystemProperty, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantFactoryEnvironmentTest.java::everyEnvironmentHasItsOwnFactoryAndItsOwnParticipantTable

Status: done — DomainParticipantFactoryImpl is created with its ServiceEnvironment (getEnvironment), keeps its own table of participants (lookupParticipant) and its own default QoS. Tests: QuickstartApiTest::serviceEnvironmentBootstrapBySystemProperty (assertNotSame between the factories of two environments), ParticipantFactoryEnvironmentTest::everyEnvironmentHasItsOwnFactoryAndItsOwnParticipantTable (lookupParticipant of the other factory returns null). The InProcessBus is a shared singleton: the participants of both environments in a domain discover each other (same test). (commit 2e0b194caf5) ### §7.4.2 DomainParticipant as the interface org.omg.dds.domain.DomainParticipant

Spec: §7.4.2, p. 24 — “This PSM represents the DomainParticipant classifier from the DDS PIM with the interface org.omg.dds.domain.DomainParticipant.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant)

Status: done — org.omg.dds.domain.DomainParticipant is now an interface (extends Entity); the implementation is org.zerodds.domain.DomainParticipantImpl. The tests use DomainParticipant only as the interface type the factory returns. (commit 0840f9ed436)

§7.5 Topic Module

§7.5 Packages `org.omg.dds.type` and `org.omg.dds.topic`

Spec: §7.5, p. 24 — “This PSM realizes the Topic Module from the DDS specification with the packages org.omg.dds.type and org.omg.dds.topic.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/, crates/java-omgdds/java/src/main/java/org/omg/dds/type/, crates/java-omgdds/java/src/main/java/org/omg/dds/type/TypeSupport.java (TypeSupport), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/Topic.java (Topic)

Status: done — Both packages exist: org.omg.dds.topic (Topic, TopicDescription, ContentFilteredTopic, MultiTopic, listeners, adapters, built-in data) and org.omg.dds.type (TypeSupport, annotations such as Key, TypeKind, dynamic.*). PubSubLoopbackTest uses Topic; DynamicTopicTest uses org.omg.dds.type.Key, TypeKind and the types from org.omg.dds.type.dynamic. (commit 9267b77a38a) ### §7.5.1 One class per type based on org.omg.dds.type.TypeSupport

Spec: §7.5.1, p. 24 — “As in the DDS PIM, each type to be published or subscribed with DDS is represented by a class extending org.omg.dds.type.TypeSupport.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/TypeSupport.java (TypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeSupportImpl.java (TypeSupportImpl), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicDescription.java (TopicDescription.getTypeSupport), tools/idlc/src/java_support.rs (java_support::support)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicMadeFromAClassHasATypeSupportOfThatClass, tools/idlc/tests/java_typesupport_base.rs::generated_type_supports_extend_the_psm_type_support

Status: done — org.omg.dds.type.TypeSupport is an abstract class (newData, getType, getTypeName); TypeSupportImpl extends it, and TopicImpl holds an instance (getTypeSupport). TopicOperationsTest::aTopicMadeFromAClassHasATypeSupportOfThatClass checks that for a topic made from a class. The Support_<tag> classes of ZdTypeSupports.java that tools/idlc/src/java_support.rs generates extend org.omg.dds.type.TypeSupport<…> (with getEnvironment, newData, getType) and keep implementing org.zerodds.cdr.TopicTypeSupport; java_typesupport_base generates the Java for XCDR1 and XCDR2, compiles it with javac -Xlint:all -Werror against the sources of the binding and runs a program that uses the class through the base class (run on the Linux test host with a JDK). (commit 8aecff4864f) ### §7.5.1 Static operation newTypeSupport with a class and an optional name

Spec: §7.5.1, p. 24 — “Applications obtain instances of these interfaces by calling the static base class operation newTypeSupport, passing this method the Java Class object of the type they wish to support and optionally a name under which that type should be registered.”

Status: done — TypeSupport.newTypeSupport(Class, ServiceEnvironment) and newTypeSupport(Class, String, ServiceEnvironment) lead through env.getSPI().newTypeSupport to a TypeSupportImpl. Tests: TopicOperationsTest::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass (getType, getTypeName, newData, a topic made from it, exchange of a sample), ::aTypeSupportRegisteredUnderANameGivesTheTopicItsWritersAndItsAnnouncementThatName (form with a name). (commit 36e8fd3f496) ### §7.5.1 Without a name, under the fully qualified name of the class

Spec: §7.5.1, p. 24 — “If no such name is provided, the type shall be registered under the fully qualified name of the provided Class.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass

Status: done — In the OMG source newTypeSupport(Class, ServiceEnvironment) passes type.getClass().getName() (“java.lang.Class”) as the name; org/omg/dds stays unchanged because the OMG source is normative. ZeroSPI.newTypeSupport (ServiceEnvironmentImpl) treats “java.lang.Class” for a type other than Class itself as “no name given” and registers under type.getName(), the fully qualified name of the class (§7.5.1). A type an application registers explicitly under “java.lang.Class” is thus not possible. Test: TopicOperationsTest::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass (getTypeName = String.class.getName(), also at the topic). (commit 36e8fd3f496) ### §7.5.1 TypeSupport to createTopic instead of register_type

Spec: §7.5.1, p. 24 — “This PSM instead asks applications to instantiate each TypeSupport object with a name and then provide that TypeSupport itself to the create_topic method.”

Status: done — DomainParticipant.createTopic(String, TypeSupport) and the form with QoS, listener and status set create a TopicImpl that holds the TypeSupport (DomainParticipantImpl.newTopic); there is no register_type operation. Tests: TopicOperationsTest::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass (getTypeName and getTypeSupport of the topic are those of the TypeSupport, writer and reader exchange a sample), ::aTypeSupportRegisteredUnderANameGivesTheTopicItsWritersAndItsAnnouncementThatName. (commit cd8f3d67ea9) ### §7.5.1 Rationale: static type safety

Spec: §7.5.1, p. 24 — “Design Rationale (non-normative) By requiring the application to pass an instance of the generic TypeSupport interface to the createTopic method, this PSM maintains unbroken static type safety all the way from type registration to data publication or reception.”

Repo: —

Tests: —

Status: n/a (informative) — Design rationale (non-normative); no requirement that can be met. ### §7.5.2 Topic adds only the access to INCONSISTENT_TOPIC

Spec: §7.5.2, p. 24 — “The Topic interface adds only a single operation to the set of those it inherits from its TopicDescription and DomainEntity super-types: an accessor for the inconsistent topic status.”

Status: done — Topic extends TopicDescription and DomainEntity and adds getInconsistentTopicStatus; TopicImpl.onInconsistentTopic is called by DomainParticipantImpl.checkTopicConsistency and remoteEndpointSeen. Tests: TopicOperationsTest::aTopicOfTheSameNameAndAnotherTypeInTheDomainIsInconsistentAndTellsTheTopicListener (getInconsistentTopicStatus: total_count 1, change 1 on the first and 0 on the second call), ::topicsOfTheSameTypeOrInAnotherDomainAreConsistent, ParticipantWireDiscoveryTest::aTopicOfAnotherProcessIsDiscoveredAndATypeThatDiffersIsInconsistent. (commit cd8f3d67ea9) ### §7.5.2 Topic generic over the data type

Spec: §7.5.2, p. 24–25 — “Topic—like all TopicDescriptions, and like DataReader and DataWriter—is a generic interface with a type parameter that identifies the type of the data with which it is associated.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/Topic.java (Topic), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicDescription.java (TopicDescription)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — Topic and TopicDescription are parameterized by the data type, like DataReader and DataWriter. The test uses Topic to create DataWriter and DataReader. (commit 9267b77a38a) ### §7.5.2 Type safety from creation to writing and reading

Spec: §7.5.2, p. 25 — “Although Topic provides no type-specific operations, its type parameter preserves type safety from Topic creation (actually all the way from type registration) through data publication and/or subscription.”

Status: done — createTopic(String, Class) returns Topic; Publisher.createDataWriter(Topic) returns DataWriter; Subscriber.createDataReader(TopicDescription) returns DataReader. QuickstartApiTest.singleArgFactoryReflectsTypedBean writes a Temperature object and reads Sample.getData().getCelsius() without a cast. (commit a91e0f632bb) ### §7.5.2 TopicDescription extends java.io.Closeable

Spec: §7.5.2, p. 25 — “TopicDescription interface extends java.io.Closeable to support specific new language constructs (e.g., Java try-with-resources) for dealing with this interface.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicDescription.java (TopicDescription), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/Topic.java (Topic), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/ContentFilteredTopic.java (ContentFilteredTopic), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/MultiTopic.java (MultiTopic)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aTopicDescriptionIsCloseableAndLeavesTheParticipantWhenTheResourceEnds, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::closingAContentFilteredTopicNeedsItsReadersGoneAndRemovesItFromTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::closingAMultiTopicNeedsItsReadersGoneAndFreesTheTopicsOfItsFromClause, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCascadeTest.java::participantCloseClosesContainedEntities

Status: done — TopicDescription extends Closeable and DDSObject; ContentFilteredTopic and MultiTopic close themselves (entry removed from the participant’s list, topics they hold released). Tests: TopicOperationsTest::aTopicDescriptionIsCloseableAndLeavesTheParticipantWhenTheResourceEnds (try-with-resources for a ContentFilteredTopic and a MultiTopic, lookupTopicDescription null afterwards), ::closingAContentFilteredTopicNeedsItsReadersGoneAndRemovesItFromTheParticipant, ::closingAMultiTopicNeedsItsReadersGoneAndFreesTheTopicsOfItsFromClause, CloseCascadeTest::participantCloseClosesContainedEntities. (commit 36e8fd3f496) ### §7.5.3 ContentFilteredTopic and MultiTopic generic

Spec: §7.5.3, p. 25 — “ContentFilteredTopic and MultiTopic are generic interfaces with type parameters that identify the types of the data with which they are associated.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/ContentFilteredTopic.java (ContentFilteredTopic), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/MultiTopic.java (MultiTopic)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theContentFilteredTopicOfTheParticipantFiltersTheSamples, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicTest.java::theMultiTopicCarriesItsExpression

Status: done — ContentFilteredTopic and MultiTopic are interfaces with a type parameter (both extend TopicDescription). ContentFilterTest uses ContentFilteredTopic and checks that a reader on it receives only the sample with value > 50; MultiTopicTest uses MultiTopic with expression and parameters. (commit 9267b77a38a) ### §7.5.3 The type parameter of a ContentFilteredTopic may be a supertype

Spec: §7.5.3, p. 25 — “Note that the type parameter of a ContentFilteredTopic does not need to match that of its related Topic exactly; it can be any supertype. For example, if the user-defined type Bar extends the user-defined type Foo, a ContentFilteredTopic can wrap a Topic.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.createContentFilteredTopic), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/ContentFilteredTopic.java (ContentFilteredTopic.getRelatedTopic), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createContentFilteredTopic)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aContentFilteredTopicOfASupertypeFiltersTheSamplesOfTheSubtypeByTheSupertypeFields

Status: done — createContentFilteredTopic takes Topic<? extends TYPE>, getRelatedTopic returns Topic<? extends TYPE>; the filter evaluates the fields of the supertype on samples of the subtype (ContentFilter uses the class of the sample). Test: TopicOperationsTest::aContentFilteredTopicOfASupertypeFiltersTheSamplesOfTheSubtypeByTheSupertypeFields (ContentFilteredTopic over Topic, Bar extends Foo; the reader receives only the Bar with level > 5, as a Bar with its field label). (commit 9267b77a38a) ### §7.5.4 Data types of the built-in topics in org.omg.dds.topic, accessors only

Spec: §7.5.4, p. 25 — “The data types pertaining to the DDS built-in discovery topics are contained in the package org.omg.dds.topic as well. These types provide only accessors for their state, not mutators, to reflect the read-only (from an application’s point of view) nature of discovery.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/ParticipantBuiltinTopicData.java (ParticipantBuiltinTopicData), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicBuiltinTopicData.java (TopicBuiltinTopicData), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/PublicationBuiltinTopicData.java (PublicationBuiltinTopicData), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/SubscriptionBuiltinTopicData.java (SubscriptionBuiltinTopicData), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/BuiltinTopicKey.java (BuiltinTopicKey)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreApiShapeTest.java::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::theBuiltinReaderOfAParticipantSeesTheEntitiesOfTheDomain, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::getDiscoveredTopicDataCarriesTheTopicQos

Status: done — The four interfaces and BuiltinTopicKey in org.omg.dds.topic have getters for their state and, like the OMG source, copyFrom(src). DDS-Java-PSM 1.0 clause 2 makes the OMG source files normative next to the PDF and decisive on conflict; the interfaces are the files of the OMG source (CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource, SHA-256 per file), so copyFrom belongs to the normative API. Setters exist only in the classes under org.zerodds.topic. The tests read the data as samples of the built-in readers. (commit 7f102b80f83)

§7.6 Publication Module

§7.6 Package `org.omg.dds.pub`

Spec: §7.6, p. 25 — “This PSM realizes the Publication Module from the DDS specification with the package org.omg.dds.pub.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/, crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriterListener.java (DataWriterListener), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/PublisherListener.java (PublisherListener)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — The package org.omg.dds.pub contains Publisher, DataWriter, PublisherListener, DataWriterListener, PublisherAdapter, DataWriterAdapter, PublisherQos and DataWriterQos. The test uses Publisher and DataWriter from this package. (commit a91e0f632bb) ### §7.6 Rationale: the name “pub”

Spec: §7.6, p. 25 — “Design Rationale (non-normative) The term “pub” has been preferred to the longer “publication” for the sake of brevity […]”

Repo: —

Tests: —

Status: n/a (informative) — Design rationale (non-normative); no requirement that can be met. ### §7.6.1 Publisher as the interface org.omg.dds.pub.Publisher

Spec: §7.6.1, p. 25 — “Publishers are represented by instances of the org.omg.dds.pub.Publisher interface.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl)

Status: done — org.omg.dds.pub.Publisher is an interface (extends DomainEntity<PublisherListener, PublisherQos>); PublisherImpl implements it. The tests hold the result of DomainParticipant.createPublisher as a Publisher and use createDataWriter on it. (commit a91e0f632bb) ### §7.6.1 Overload lookupDataWriter(Topic)

Spec: §7.6.1, p. 25 — “In addition to the methods defined for this interface by [DDS], it additionally provides a lookupDataWriter overload that acts on the basis of a Topic object rather than solely on the topic’s name.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::lookupDataWriterFindsByNameAndByTopicAndForgetsClosedWriters

Status: done — Publisher has lookupDataWriter(String topicName) and lookupDataWriter(Topic); PublisherImpl returns the first writer with the topic name, or null (the Topic overload compares the name). Test: PublisherOperationsTest::lookupDataWriterFindsByNameAndByTopicAndForgetsClosedWriters (both overloads for an existing and a missing topic, null after close). (commit a91e0f632bb) ### §7.6.2 DataWriter as the generic interface org.omg.dds.pub.DataWriter

Spec: §7.6.2, p. 25 — “DataWriters are represented by instances of the org.omg.dds.pub.DataWriter interface. This is a generic interface, parameterized by the type of the data samples to be written by a given writer.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — org.omg.dds.pub.DataWriter is now an interface (extends DomainEntity<DataWriterListener, DataWriterQos>), parameterized by the data type; DataWriterImpl implements it. The test uses DataWriter to write. (commit 5eb3cb8ca5b) ### §7.6.2 No FooDataWriter, all type-specific operations on DataWriter

Spec: §7.6.2, p. 25 — “This PSM makes no such distinction: Java’s generic wildcard syntax (DataWriter<?>) makes it possible to express all type-specific DataWriter operations on the DataWriter interface itself; there is no FooDataWriter.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.write), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.registerInstance), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.dispose), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter.lookupInstance), tools/idlc/src/java_support.rs (support)

Status: done — write, registerInstance, unregisterInstance, dispose, getKeyValue and lookupInstance are on DataWriter; there is no FooDataWriter. tools/idlc/src/java_support.rs generates only ZdTypeSupports, no writer per type (read, not covered by a test). The tests write through DataWriter and check registerInstance and lookupInstance (handle not nil, nil for an unknown key). (commit 5eb3cb8ca5b) ### §7.6.2 Timestamps and handles as overloads

Spec: §7.6.2, p. 25–26 — “Java does; therefore, the provision of timestamps and/or instance handles is optional and is handled by means of method overloads. For example, the write method provides the following overloads: one accepting a data sample only, another accepting a sample and an instance handle, and another accepting both of these as well as a timestamp.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::everyWriteOverloadCarriesItsSourceTimestampToTheSample, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::registerInstanceTakesATimestampAndLookupInstanceFindsTheInstanceByItsKey, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed

Status: done — DataWriter has write, registerInstance, unregisterInstance and dispose, each with the overloads sample, sample with Time or long/TimeUnit, sample with InstanceHandle, sample with InstanceHandle and timestamp. DataWriterImpl uses the timestamp in milliseconds as the source timestamp and checks the handle against the sample’s instance. Tests: WriterHandleTest::everyWriteOverloadCarriesItsSourceTimestampToTheSample (timestamp and instance handle on the reader’s sample for five forms), ::registerInstanceTakesATimestampAndLookupInstanceFindsTheInstanceByItsKey, ::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed (forms with Time and long/TimeUnit). (commit d70d1f69c5d) ### §7.6.2 For unkeyed types a nil handle

Spec: §7.6.2, p. 26 — “Users of DataWriters of unkeyed types may choose to call the overloads that accept instance handle arguments; if they do, the handle argument must be a nil handle (as explained in the DDS PIM).”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::anUnkeyedTypeIsWrittenWithTheNilHandle

Status: done — The overloads with InstanceHandle (write, registerInstance, dispose, unregisterInstance) exist; DataWriterImpl.write(T, InstanceHandle, …) allows HANDLE_NIL and deduces the instance from the key (for a type without a key, the one instance). Test: WriterHandleTest::anUnkeyedTypeIsWrittenWithTheNilHandle (byte[] topic, three forms with the nil handle, all three samples at the reader, timestamp of the forms with Time and long/TimeUnit). (commit d70d1f69c5d)

§7.7 Subscription Module

§7.7 Package `org.omg.dds.sub`

Spec: §7.7, p. 26 — “This PSM realizes the Subscription Module from the DDS specification with the package org.omg.dds.sub.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Subscriber.java (Subscriber), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReaderListener.java (DataReaderListener), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/SubscriberListener.java (SubscriberListener), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/ReadCondition.java (ReadCondition), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/QueryCondition.java (QueryCondition)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — The package org.omg.dds.sub contains Subscriber, DataReader, Sample, SubscriberListener, DataReaderListener, ReadCondition and QueryCondition. The test uses Subscriber, DataReader and Sample from this package. The old statement that SubscriberListener and the conditions are missing no longer holds. (commit a91e0f632bb) ### §7.7 Rationale: the name “sub”

Spec: §7.7, p. 26 — “Design Rationale (non-normative) The term “sub” has been preferred to the longer “subscription” for the sake of brevity […]”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative (rationale for the package name). ### §7.7.1 Subscriber as the interface org.omg.dds.sub.Subscriber

Spec: §7.7.1, p. 26 — “Subscribers are represented by instances of the org.omg.dds.sub.Subscriber interface.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Subscriber.java (Subscriber), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — Subscriber is public interface Subscriber; SubscriberImpl implements it. The test holds the result of participant.createSubscriber() in a variable of type Subscriber and creates the reader through it. The old statement (final class with a public constructor) no longer holds. (commit a91e0f632bb) ### §7.7.1 Overload lookupDataReader(TopicDescription)

Spec: §7.7.1, p. 26 — “In addition to the methods defined for this interface by [DDS], it additionally provides a lookupDataReader overload that acts on the basis of a TopicDescription object rather than solely on the topic description’s name.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::lookupDataReaderFindsTheReaderByTopicNameAndByTopicDescription

Status: done — lookupDataReader(String) and lookupDataReader(TopicDescription) find the reader by name and by description, return null for an unknown topic and after the reader is closed; null as description gives IllegalArgumentException. (commit a91e0f632bb) ### §7.7.2 A sample as one object of data and metadata, interface org.omg.dds.sub.Sample

Spec: §7.7.2, p. 26 — “This PSM follows the guidance of the DDS PIM rather than of the IDL PSM: it represents data samples as single objects that incorporate both data and metadata. Each sample is represented by an instance of the org.omg.dds.sub.Sample interface.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/rpc/RpcInheritanceTest.java::thePsmSampleIsAnInterface, crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — Sample<TYPE> is an interface that carries getData and the metadata (getSampleState, getViewState, getInstanceState and others) in one object; SampleImpl implements it. thePsmSampleIsAnInterface checks Sample.class.isInterface() and that it is not final. The second test reads data from the samples that take returns. (commit 9267b77a38a) ### §7.7.2 getData returns the data

Spec: §7.7.2, p. 26 — “It provides its data via a getData method […]”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getData), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getData)

Status: done — byteArrayQuickstartRoundTrip writes "hello".getBytes() and reads it back through Sample.getData(); readReturnsAFreshCopyNotTheReadersObject checks the value getData().value == 42. QuickstartApiTest.getDataAliasesData compares getData() with itself and proves nothing. (commit 9267b77a38a) ### §7.7.2 getData returns null without valid data

Spec: §7.7.2, p. 26 — “if there is no valid data (corresponding to a false value for SampleInfo.valid_data in the IDL PSM), this operation returns null.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getData), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.markState)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicJoinTest.java::disposingAConstituentDisposesTheResultInstance

Status: done — DataReaderImpl.markState adds a sample with null data for NOT_ALIVE_DISPOSED and NOT_ALIVE_NO_WRITERS. The test triggers such a sample in the MultiTopic reader by disposing a constituent topic and checks assertNull(getData()) and NOT_ALIVE_DISPOSED. No test checks getData() == null on a reader of a plain topic, nor for NOT_ALIVE_NO_WRITERS. (commit f31b6fa11b5) ### §7.7.2 Metadata as read-only Java Bean properties

Spec: §7.7.2, p. 26 — “It provides its metadata (corresponding to the other SampleInfo properties in the IDL PSM) as read-only Java-Bean-style properties.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getSampleState), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getViewState), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getInstanceState), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getSourceTimestamp), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getPublicationHandle), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getSampleRank), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.toSample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.of)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SampleStateTest.java::readMarksSamplesRead, crates/java-omgdds/java/src/test/java/org/omg/dds/SampleStateTest.java::viewStateIsNewUntilFirstAccess, crates/java-omgdds/java/src/test/java/org/omg/dds/SampleStateTest.java::disposeSnapshotsInstanceStateForAllSamples, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::anInstanceDisposedAndWrittenAgainCountsADisposedGeneration, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::anInstanceWithoutWritersWrittenAgainCountsANoWritersGeneration, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::theRanksAreMeasuredWithinTheSamplesOfOneInstanceInTheCollection, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::theSourceTimestampIsTheOneTheWriterGave, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::thePublicationHandleNamesTheWriterThatIsMatchedWithTheReader

Status: done — DataReaderImpl.toSample and SampleImpl.of supply disposed_generation_count, no_writers_generation_count, sample_rank, generation_rank and absolute_generation_rank from the counters and the collection (instead of the constants 0 and -1), plus source_timestamp and publication_handle. The tests in ReaderSampleInfoTest check all seven values. (commit e1b55167947) ### §7.7.2 Sample.Iterator extends ListIterator, read-only

Spec: §7.7.2, p. 26 — “The Sample interface also defines a nested interface: Sample.Iterator, an iterator that extends java.util.ListIterator. An iterator of this type provides read-only access to an ordered series of samples of a single type; such iterators are used by the DataReader read and take methods (see below).”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.Iterator), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleIterator.java (SampleIterator.remove), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleIterator.java (SampleIterator.set), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleIterator.java (SampleIterator.add)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderIteratorTest.java::theIteratorIsReadOnly

Status: done — SampleIterator.remove, set and add throw UnsupportedOperationException (DDS-Java-PSM 1.0 §7.7.2). The test calls all three on an iterator from DataReader.read() and checks that the collection is unchanged. (commit e0f89cfd194) ### §7.7.3 DataReader as the generic interface org.omg.dds.sub.DataReader

Spec: §7.7.3, p. 26 — “DataReaders are represented by instances of the org.omg.dds.sub.DataReader interface. This is a generic interface, parameterized by the type of the data samples to be read by a given reader.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — DataReader<TYPE> is public interface DataReader<TYPE>; DataReaderImpl implements it. The test uses DataReader<Reading> and reads Sample<Reading> of the data type Reading. The old statement (final class) no longer holds. (commit 5eb3cb8ca5b) ### §7.7.3 No FooDataReader, all type-specific operations on DataReader

Spec: §7.7.3, p. 26 — “This PSM makes no such distinction: Java’s generic wildcard syntax (DataReader<?>) makes it possible to express all type-specific DataReader operations on the DataReader interface itself; there is no FooDataReader.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.read), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.take), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.lookupInstance), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.getKeyValue), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getKeyValue)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::readReturnsSamplesWithoutRemoving, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderKeyTest.java::getKeyValueReturnsASampleOfTheInstanceThatHasTheKey, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderKeyTest.java::lookupInstanceIsNilBeforeTheInstanceIsKnownAndTheHandleOfTheSampleAfterwards, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::readNextSampleReturnsTheNextSampleNotYetReadAndTakeNextSampleRemovesIt

Status: done — All type-specific operations (read, take, lookupInstance, getKeyValue, readNextSample, takeNextSample) are on DataReader; getKeyValue sets the key fields (see the item on get_key_value) and all are tested. (commit e1b55167947) ### §7.7.3 Two flavours of read and take: loan with Sample.Iterator, copy into an application List

Spec: §7.7.3, p. 26 — “The DataReader interface provides a number of read and take method overloads. In addition to the distinction between read vs. take semantics (as defined in the DDS PIM), these operations come in two “flavors.” One that loans samples from a Service pool and returns a Sample.Iterator and another that deeply copies into an application-provided java.util.List”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.read), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.take), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.toSample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleIterator.java (SampleIterator)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReadCopyTest.java::readReturnsAFreshCopyNotTheReadersObject, crates/java-omgdds/java/src/test/java/org/omg/dds/ReadCopyTest.java::takeReturnsAFreshCopyNotTheReadersObject, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderIteratorTest.java::theIteratorWalksTheSamplesInBothDirections, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderIteratorTest.java::takeReturnsTheSamplesInTheIteratorAndRemovesThemFromTheReader, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderIteratorTest.java::readSelectorAndIntFormsReturnTheSameSamplesAsTheListForm

Status: done — read(), take(), read(int), take(Selector) return a Sample.Iterator: content and order, change of direction, READ after read, removal after take are tested. (commit e1b55167947) ### §7.7.3 returnLoan on the iterator, the iterator is Closeable

Spec: §7.7.3, p. 27 — “Applications that read or take loans must eventually return those loans; this PSM maps the return_loan operation from the DDS PIM to an operation returnLoan on the Sample.Iterator. Moreover, the iterator implements the Java.io.Closeable interface so that try-with-resources construct can be used in Java 7.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.Iterator.close), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleIterator.java (SampleIterator.close)

Status: done — SampleIterator.close no longer throws on the second call (Closeable, Sample.Iterator: close without a loan has no effect); try-with-resources over read() and take() is tested. The OMG API names the operation close; the name returnLoan of the PSM text does not exist there (org.omg.dds is not changed). (commit e0f89cfd194) ### §7.7.3 Copy: list with any number of samples, afterwards the requested number

Spec: §7.7.3, p. 27 — “Applications that read or take copies may provide to the Service destination Lists with any number of Samples already in them (including empty Lists). Regardless of the number of Samples already in the list when the method is called, when it returns, the List shall contain the number of Samples requested by the application (or fewer, if fewer were available).”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.read), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.take), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.read), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.take)

Status: done — read(List), take(List), read(List, Selector), take(List, Selector) and Selector.read(List)/take(List) replace the content of the list with the returned samples (a long list is trimmed, a short one extended); null gives a new list. The number is maxSamples of the selector (DDS-Java-PSM §7.7.3: the number requested), not the length of the list. (commit e1b55167947) ### §7.7.3 Copy may overwrite the samples passed in

Spec: §7.7.3, p. 27 — “The Service implementation may—for example, in order to avoid object allocations—elect to overwrite the contents of any Samples that are passed into it by invocations of these methods.”

Repo: —

Tests: —

Status: n/a (informative) — Permission for the implementation (“may”); it requires nothing. DataReaderImpl.toSample does not overwrite passed samples but creates new ones. ### §7.7.3 DataReader.Selector encapsulates the selection criteria

Spec: §7.7.3, p. 27 — “Instead of overloading several operation variants that accept large numbers of infrequently used parameters, a DataReader.Selector is provided to encapsulate various selection criteria (for example, sets of sample, instance, and view states).”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.Selector), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theSelectorOfReadAndTakeCarriesTheExpression, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::anInstanceHandleLimitsReadAndTakeToThatInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::nextInstanceWalksTheInstancesInTheOrderOfTheirHandles, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDataStateSelectsOnSampleViewAndInstanceStates, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::maxSamplesLimitsReadAndTakeAndUnlimitedIsAcceptedAsAValue

Status: done — Selector.instance, nextInstance, dataState, Content and maxSamples are tested through read(Selector)/take(Selector); nextInstance returns the next instance by handle (also together with instance(h)). (commit e1b55167947) ### §7.7.3 DataReader.select returns a selector with the defaults

Spec: §7.7.3, p. 27 — “DataReader.select method returns a Selector object, which encapsulates the default selection criteria.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.select), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.select)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theSelectorOfReadAndTakeCarriesTheExpression

Status: done — DataReaderImpl.select returns a SelectorImpl bound to the reader. The test calls reader.select().Content(...) and reads from the same reader through selector.read(got). The individual defaults of the selector are in the following items. (commit 5eb3cb8ca5b) ### §7.7.3 Selector default: instanceHandle=null

Spec: §7.7.3, p. 27 — “For portability, the default state of the Selector object is defined as instanceHandle=null, […]”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.getInstance), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.Selector.getInstance)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything

Status: done — select().getInstance() is null; read() with the default selector returns the samples of all instances (three instances, six samples). (commit e1b55167947) ### §7.7.3 Selector default: nextInstance=false

Spec: §7.7.3, p. 27 — “[…] nextInstance=false, […]”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.retrieveNextInstance), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.Selector.retrieveNextInstance)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything

Status: done — select().retrieveNextInstance() is false. (commit e1b55167947) ### §7.7.3 Selector default: dataState=any

Spec: §7.7.3, p. 27 — “[…] dataState=any, […]”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.getDataState), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.sampleStates)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything

Status: done — SelectorImpl.getDataState() returns DataStateImpl.any(environment) (all sample, view and instance states) when not set; the test compares with assertEquals. (commit e0f89cfd194) ### §7.7.3 Selector default: queryExpression=null

Spec: §7.7.3, p. 27 — “[…] queryExpression=null, […]”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.getQueryExpression), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.collectLocked)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything, crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theSelectorOfReadAndTakeCarriesTheExpression

Status: done — select().getQueryExpression() is null and read() without an expression returns all samples; with Content(...) collectLocked filters. (commit e1b55167947) ### §7.7.3 Selector default: maxSamples=unlimited

Spec: §7.7.3, p. 27 — “[…] and maxSamples=unlimited.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.maxSamples), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.getMaxSamples)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::maxSamplesLimitsReadAndTakeAndUnlimitedIsAcceptedAsAValue

Status: done — SelectorImpl.maxSamples accepts ResourceLimits.LENGTH_UNLIMITED and values from 0, other negative values give IllegalArgumentException; getMaxSamples() returns LENGTH_UNLIMITED by default. read(Selector)/take(Selector) limit to the count. (commit e0f89cfd194) ### §7.7.3 Selector as a fluent interface with its own read and take

Spec: §7.7.3, p. 27 — “Selector provides fluent interface to modify the default selection parameters. For convenience, Selector provides read and take methods.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.Selector), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.Selector.read), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.Selector.take)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theSelectorOfReadAndTakeCarriesTheExpression, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::anInstanceHandleLimitsReadAndTakeToThatInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::nextInstanceWalksTheInstancesInTheOrderOfTheirHandles, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theCopyFlavourReplacesWhatTheListHeldAndAllocatesAListForNull

Status: done — The selector is fluent (instance, nextInstance, dataState, Content, maxSamples return it) and has read(), read(List), take(), take(List); chained calls are tested. (commit e1b55167947)

§7.8 Extensible and Dynamic Topic Types Module

§7.8 Types of the TypeObject representation in `org.omg.dds.type.typeobject`

Spec: §7.8, p. 27 — “Types pertaining to TypeObject Type Representations are defined in the package org.omg.dds.type.typeobject.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/typeobject/TypeObject.java (TypeObject), crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/TypeObjectModel.java (TypeObjectModel.of), crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/TypeObjectCodec.java (TypeObjectCodec), crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/TypeObjectBuilder.java (TypeObjectBuilder.build), crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/TypeObjects.java (TypeObjects), crates/java-omgdds/idl/typeobject/dds_xtypes_11_typeobject.idl, crates/java-omgdds/scripts/generate-typeobject.sh

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectTest.java::theMinimalTypeObjectHasTheOctetsAnnexBImplies, crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectTest.java::aJavaClassBecomesAStructureTypeWithItsMembers, crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectTest.java::theTypeIdIsTheLowerHalfOfTheMd5OfTheBigEndianSerialization, crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectTest.java::aChangeOfTheTypeChangesItsId, crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectTest.java::theEncodedTypeObjectIsDecodedToTheSameTypeObject, crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectTest.java::bytesThatAreNoTypeObjectGiveNoType, crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectModelTest.java::everyInterfaceOfThePackageIsImplementedAndAnObjectOfItComesBackOverTheWire, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesTypeObjectConstantsTest.java::memberIdsAreNestedFinalClassesOfIntConstants

Status: done — The package org.omg.dds.type.typeobject equals the OMG source file by file and is implemented. The interfaces mirror the TypeObject library of DDS-XTypes 1.1 Annex B (formal/2012-11-10, in the spec cache .agent/spec/dds-xtypes-1.1.txt); idl/typeobject/dds_xtypes_11_typeobject.idl takes the IDL of the annex in the annotation syntax of IDL 4 (@extensibility instead of @Extensibility(...), @id(<value>), @external instead of @Shared, bitmask instead of the @BitSet enumeration) with four changes that touch no value and no id: the type _TypeId is TypeId in Java; the member annotation is _annotation because annotation is a keyword in IDL 4; Bound is CollectionBound because bound and Bound are one identifier in IDL; MapType, SequenceType and StringType are @mutable like their base CollectionType (the annex says EXTENSIBLE, but the members have ids). The annex gives the enumerator MODULE_ELEMENT the value 22, which STRUCTURE_TYPE_ELEMENT also has; here it is 24. From the IDL scripts/generate-typeobject.sh generates the data types and the codec with idlc (XCDR1) (org/zerodds/typeobject/generated). The TypeId of a constructed type is the lower half of the MD5 of the big-endian serialization of the type (§7.3.4.1.2; the annex leaves open what the own type_id holds while hashing: NO_TYPE here). TypeObjectBuilder writes the TypeObject of a DynamicType (kind, name, extensibility, base type, members with id, key, optional, union labels, enumeration constants, bounds), TypeObjectModel puts the interfaces of the package on a decoded TypeObject, TypeObjectToDynamic maps back to the DynamicType. The interfaces have integers as type ids; the mapping is in TypeObjectModel: primitive types have the TypeId constant of the PSM, constructed ones 0x10000 plus the index in the library. An annotation usage is read but not written (the list of usages is empty); a bit set names no bits; a union has no discriminator type (the annex has no member for it). (commit b4bf3fa978e) ### §7.8 Dynamic Language Binding in org.omg.dds.type.dynamic

Spec: §7.8, p. 27 — “Types pertaining to the Dynamic Language Binding are defined in the package org.omg.dds.type.dynamic.”

Status: done — The package org.omg.dds.type.dynamic contains DynamicType, DynamicTypeMember, DynamicData, both factories and the three descriptors (file by file equal to the OMG sources). DynamicTopicTest creates type and data through these interfaces and moves DynamicData through a writer and reader; DynamicTypeReflectionTest reads DynamicType from classes. The old statement (package missing, org.zerodds.cdr.DynamicType outside) no longer holds. (commit 5041698cee3) ### §7.8 TypeKind in org.omg.dds.type

Spec: §7.8, p. 27 — “The TypeKind enumeration, which pertains to both of the above, is defined in the package org.omg.dds.type.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/TypeKind.java (TypeKind)

Status: done — org.omg.dds.type.TypeKind exists (equal to the OMG source) with the kinds from NO_TYPE to ANNOTATION_TYPE, including the unsigned types, CHAR_32_TYPE, FLOAT_128_TYPE, enumeration, bit set, union and array. The tests compare DynamicType.getKind() with values of this enum. The old text (DynamicType.Kind with twelve values) describes the legacy org.zerodds.cdr.DynamicType. (commit 5041698cee3) ### §7.8 Built-in types in org.omg.dds.type.builtin

Spec: §7.8, p. 27 — “The built-in types are defined in the package org.omg.dds.type.builtin.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/builtin/KeyedString.java (KeyedString), crates/java-omgdds/java/src/main/java/org/omg/dds/type/builtin/KeyedBytes.java (KeyedBytes), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/BuiltinTypes.java (BuiltinTypes), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/BuiltinTypeSupports.java (BuiltinTypeSupports)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedStringIsAModifiableValueType, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedStringCopyFromCloneAndEquals, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedStringSurvivesJavaSerialization, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedBytesIsAModifiableValueType, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedBytesCopyFromCloneAndEquals, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedBytesSurvivesJavaSerialization, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aKeyedStringTopicHasOneInstancePerKey, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aKeyedBytesTopicHasOneInstancePerKey

Status: done — The package org.omg.dds.type.builtin exists with KeyedString and KeyedBytes; BuiltinTypes contains KeyedStringImpl and KeyedBytesImpl, and ServiceEnvironment.getSPI().newKeyedString()/newKeyedBytes() create them. TypesBuiltinTest checks setKey/setValue (the object is returned, the byte array is copied on set and get, the range form of setValue), copyFrom, clone, equals/hashCode and Java serialization, and one writer and one reader on a topic of the type. The TypeSupports of the types are in BuiltinTypeSupports (items on DDS::KeyedString and DDS::KeyedBytes). (commit ec44921ff1d) ### §7.8 Extensions by [DDS-XTypes] within the built-in topic data types

Spec: §7.8, p. 27 — “Extensions by [DDS-XTypes] to types defined by [DDS] (such as the built-in topic data types) are contained within those types.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/PublicationBuiltinTopicData.java (PublicationBuiltinTopicData.getEquivalentTypeName), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/PublicationBuiltinTopicData.java (PublicationBuiltinTopicData.getBaseTypeName), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/PublicationBuiltinTopicData.java (PublicationBuiltinTopicData.getType), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/PublicationBuiltinTopicData.java (PublicationBuiltinTopicData.getRepresentation), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/PublicationBuiltinTopicData.java (PublicationBuiltinTopicData.getTypeConsistency), crates/java-omgdds/java/src/main/java/org/zerodds/topic/PublicationBuiltinTopicDataImpl.java (PublicationBuiltinTopicDataImpl), crates/java-omgdds/java/src/main/java/org/zerodds/topic/BuiltinData.java (BuiltinData.describeType), crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/TypeObjects.java (TypeObjects.decodeOrNull)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::theTypeMembersAreOnTheirParameterIdsAndRoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::theTypeMembersOfTheOtherTwoBuiltinTopicsRoundTripToo, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::sedpCarriesTheTypeInformationAndTheTypeNames, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTopicDataTest.java::thePublicationDataCarriesTheRepresentationAndTheTypeConsistencyOfItsWriter, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTopicDataTest.java::anExactTypeConsistencyForbidsCoercionOnTheWire, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTopicDataTest.java::theSubscriptionDataCarriesTheRepresentationAndTheTypeConsistencyOfItsReader, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTopicDataTest.java::theTopicDataCarriesTheRepresentationAndTheTypeConsistencyOfItsTopic, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTopicDataTest.java::aRemoteEndpointAnnouncesTheRepresentationAndTheTypeConsistencyInSedp, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTopicDataTest.java::anEndpointThatStatesNeitherHasTheDefaultsOfTheEntityQos, crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectTest.java::theBuiltinDataDescribesItsTypeFromTheAnnouncedBytes

Status: done — The data types of the built-in topics (PublicationBuiltinTopicData, SubscriptionBuiltinTopicData, TopicBuiltinTopicData) carry getEquivalentTypeName, getBaseTypeName, getType, getRepresentation and getTypeConsistency. Tested are equivalentTypeName, baseTypeName and the type information octets over wire and SEDP (BuiltinTopicQosTest) and getRepresentation and getTypeConsistency from the QoS of local entities, on the parameter ids 0x0073 and 0x0074 in the serialization of the built-in topic data, after reading back and from a SEDP announcement (TypesBuiltinTopicDataTest); EXACT_TYPE, EXACT_NAME are written as DISALLOW_TYPE_COERCION (0), ASSIGNABLE and DECLARED as ALLOW_TYPE_COERCION (1). getType() returns the TypeObject of XTypes 1.1 (PID 0x0072, @id(0x0072) type): for local entities from the DynamicType of the type support (TypeObjects.announce in BuiltinData.describeType), for remote ones from the announced octets (TypeObjects.decodeOrNull); octets that are no TypeObject give null, and getTypeObjectBytes() keeps them. The mapping between the versions: on the wire XTypes 1.3 holds (the TypeInformation 0x0075 stays what the peers read), the parameter 0x0072 carries the TypeObject of version 1.1 of Annex B, which the Java PSM interfaces mirror. (commit b4bf3fa978e) ### §7.8.1 Parts of the Dynamic Language Binding

Spec: §7.8.1, p. 27 — “The Dynamic Language Binding, as defined by [DDS-XTypes], consists of DynamicType, DynamicTypeMember, DynamicData, their respective factories, and several “descriptor” value types.”

Repo: —

Tests: —

Status: n/a (informative) — Enumeration of the components; the requirements are in §7.8.1.1 to §7.8.1.5. ### §7.8.1.1 DynamicTypeFactory is a per-ServiceEnvironment singleton (DynamicTypeFactory.getInstance(env))

Spec: §7.8.1.1, p. 27 — “This abstract factory is a per-ServiceEnvironment singleton.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicTypeFactory.java (DynamicTypeFactory.getInstance), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.getSPI), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl)

Status: done — DynamicTypeFactory.getInstance(env) returns env.getSPI().getTypeFactory(); ServiceEnvironmentImpl.getSPI creates exactly one SPI with one DynamicTypeFactoryImpl per environment. theFactoryIsASingletonPerServiceEnvironment checks that two calls return the same object, that it is the one of the SPI, that a second ServiceEnvironmentImpl has another factory (with other primitive types) and that this one is stable in turn. (commit a25948e911c) ### §7.8.1.1 No delete_instance on DynamicTypeFactory, the Service manages the life cycle

Spec: §7.8.1.1, p. 27 — “The static delete_instance operations defined in [DDS-XTypes] have been omitted in this PSM; the Service shall manage the life cycles of the factory.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicTypeFactory.java (DynamicTypeFactory), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::thereIsNoDeleteInstanceAndTheServiceManagesTheLifeCycle

Status: done — org.omg.dds.type.dynamic.DynamicTypeFactory and DynamicTypeFactoryImpl have no deleteInstance or similar operation; the life cycle follows the ServiceEnvironment. thereIsNoDeleteInstanceAndTheServiceManagesTheLifeCycle checks both classes by reflection for methods with delete in the name and that getInstance is the only static method of the abstract factory. (commit a25948e911c) ### §7.8.1.2 DynamicTypeSupport omitted

Spec: §7.8.1.2, p. 27 — “The interface DynamicTypeSupport defined by [DDS-XTypes] does not provide any capability beyond what the generic TypeSupport interface provided by this PSM already provides. Therefore, it has been omitted from this PSM.”

Repo: —

Tests: —

Status: n/a (informative) — The spec describes that DynamicTypeSupport is omitted from this PSM; org.omg.dds.type and org.omg.dds.type.dynamic contain no such interface (directory listing read). The passage requires nothing that can be fulfilled. ### §7.8.1.3 DynamicType and DynamicTypeMember as interfaces following the mapping rules of this document

Spec: §7.8.1.3, p. 28 — “These interfaces are expressed in this PSM according to the mapping rules expressed elsewhere in this document.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::enumerationsStructuresCollectionsAndMapsFollowTable81, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aWriterAndAReaderOnTheTopicOfADynamicTypeMoveDynamicData, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::theKeyAnnotationMakesTheTopicKeyed, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::membersAreFoundByIdAndByName, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::addMembersAddsEachDescriptorAndReturnsTheMembersOfTheType, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::annotationsOfATypeAreReadByIndexAndByName, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::annotationsOfAMemberAreAListInTheOrderTheyWereSet

Status: done — DynamicType and DynamicTypeMember are interfaces in org.omg.dds.type.dynamic with getDescriptor, getName, getKind, getMember, getAllMembers, the annotation operations and addMember; DynamicTypeImpl and DynamicTypeMemberImpl implement them. TypesDynamicTypeTest checks getMember(int)/getMember(String) (unknown ones too), getAllMembers(), getAllMembers(int...), getAllMembers(String...), addMembers, getAnnotation(int)/getAnnotation(String), getAllAnnotations, getAnnotations(int...)/getAnnotations(String...), setAnnotation(s) and on DynamicTypeMember getId, getName, getDescriptor, getAnnotations. equals and clone are in the item on §7.8.1.3 equals/clone. The legacy org.zerodds.cdr.DynamicType still exists alongside. (commit a25948e911c) ### §7.8.1.3 Result returned directly instead of an in-out parameter and ReturnCode_t

Spec: §7.8.1.3, p. 28 — “Operations that provide their result as an in-out value in their first parameter and return DDS::ReturnCode_t have been changed such that they instead return their results directly.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicType.java (DynamicType.getDescriptor), crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicType.java (DynamicType.getMember), crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicTypeFactory.java (DynamicTypeFactory.getPrimitiveType), crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicTypeFactory.java (DynamicTypeFactory.createType)

Status: done — The operations of DynamicType, DynamicTypeMember and the factory return their result as the return value (getDescriptor(), getMember(...), createType(...), getPrimitiveType(...)); there is no in-out parameter and no ReturnCode_t. The tests chain these calls, e.g. type.getMember(name).getDescriptor().getType().getKind(). (commit 5041698cee3) ### §7.8.1.3 equals and clone as Object.equals and Object.clone

Spec: §7.8.1.3, p. 28 — “The equals and clone operations on these types have been mapped to overrides of the Java-standard Object.equals and Object.clone, respectively.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeImpl.java (DynamicTypeImpl.clone), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeMemberImpl.java (DynamicTypeMemberImpl), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeImpl.java (DynamicTypeImpl.equals), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeMemberImpl.java (DynamicTypeMemberImpl.equals), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeDescriptorImpl.java (TypeDescriptorImpl.equals), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/MemberDescriptorImpl.java (MemberDescriptorImpl.equals), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/AnnotationDescriptorImpl.java (AnnotationDescriptorImpl.equals)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::twoTypesWithTheSamePropertiesAreEqual, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::membersAreEqualWhenTheirTypeDescriptorAndAnnotationsAre, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::cloneIsAnEqualTypeThatSharesNoMemberWithTheOriginal, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::typeDescriptorsAreEqualWhenAllTheirPropertiesAre

Status: done — DynamicTypeImpl.equals/hashCode compare, after XTypes 1.3 §7.5.2.8.4 (Table 54), the descriptor, the members (by id) and the annotations; DynamicTypeMemberImpl.equals compares, after §7.5.2.6.3, the descriptor, the annotations and the descriptor of the type the member belongs to; the descriptors compare all properties of Tables 50 and 53 and §7.5.2.3.2. DynamicTypeImpl.clone() returns an equal type that shares no member (changes to the copy or the original do not reach the other). The PSM has no clone on DynamicTypeMember. Tested in TypesDynamicTypeTest. (commit a25948e911c) ### §7.8.1.3 DynamicTypeMember as a reference type from DynamicType.addMember

Spec: §7.8.1.3, p. 28 — “DynamicTypeMember is a reference type, and instances of it are obtained from DynamicType.addMember. This change avoids the need to provide an additional factory method for DynamicTypeMember instances.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicType.java (DynamicType.addMember), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeImpl.java (DynamicTypeImpl.addMember), crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicTypeFactory.java (DynamicTypeFactory)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::theKeyAnnotationMakesTheTopicKeyed, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aStructureWithANestedStructureAndAnArray

Status: done — DynamicTypeImpl.addMember(MemberDescriptor) adds the DynamicTypeMember to the type and returns that same object; DynamicTypeFactory has no factory method for members (only newMemberDescriptor). In theKeyAnnotationMakesTheTopicKeyed the test calls setAnnotation(Key) on the member returned by addMember, and the codec of the type is keyed afterwards (isKeyed). This shows that the return value is the member of the type. (commit 7d991374fd4) ### §7.8.1.3 getAnnotations instead of get_annotation_count and get_annotation, list not modifiable

Spec: §7.8.1.3, p. 28 — “On each type, the operations get_annotation_count and get_annotation (by index) have been unified into a single getAnnotations method that returns a list of annotations. The lists returned from these methods shall not be modifiable.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicTypeMember.java (DynamicTypeMember.getAnnotations), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeMemberImpl.java (DynamicTypeMemberImpl.getAnnotations), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeImpl.java (DynamicTypeImpl.getAllAnnotations)

Status: done — DynamicTypeMember.getAnnotations() returns an unmodifiable list (Collections.unmodifiableList over a copy); DynamicType.getAllAnnotations(), getAnnotations(int...) and getAnnotations(String...) return unmodifiable maps. theListsAndMapsOfAnnotationsCannotBeModified checks add/clear/remove/put for UnsupportedOperationException and that the type is unchanged afterwards. DynamicType has getAllAnnotations() and the two getAnnotations forms instead of a single list method. The maps of getAllMembers stay modifiable copies (the specification names only the annotation lists). (commit a25948e911c) ### §7.8.1.3 Additional factory method createType(Class<?>) by §8

Spec: §7.8.1.3, p. 28 — “In addition to the methods specified by [DDS-XTypes], DynamicTypeFactory provides one additional factory method: createType(Class<?>). This method shall inspect the given type reflectively in accordance with the Java Type Representation (see Clause 8) and instantiate an equivalent DynamicType object.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.createType), crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicTypeFactory.java (DynamicTypeFactory), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.getInstance)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::everyJavaPrimitiveHasTheDdsTypeOfTable81, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::enumerationsStructuresCollectionsAndMapsFollowTable81, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::aJavaTypeWithoutAKindIsRefused, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::createTypeReflectsStructure, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::createTypeIsReachedThroughTheImplementationOfTheFactory, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::aDerivedClassIsAStructureWithTheSuperclassAsBaseType, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::theBytesOfADerivedDynamicTypeAreThoseOfTheClass, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreApiShapeTest.java::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource

Status: done — DynamicTypeFactoryImpl.createType(Class<?>) maps a class by the Java Type Representation (Table 8.1, enumeration, structure, union, collections, map, annotations, superclass as base type, only the fields java.io.Serializable assigns) to a DynamicType and rejects classes without a kind with IllegalArgumentException; DynamicTypeReflectionTest and TypesDynamicTypeTest check that. The method is not in org.omg.dds.type.dynamic.DynamicTypeFactory: the source omgdds_src.zip, which prevails under §2 when they conflict, does not have it, and org/omg/dds stays equal to the source (CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource). Access: DynamicTypeFactoryImpl.getInstance(env) returns the same factory as DynamicTypeFactory.getInstance(env) with the type of the implementation (createTypeIsReachedThroughTheImplementationOfTheFactory). The legacy org.zerodds.cdr.DynamicTypeFactory.createType returns the old org.zerodds.cdr.DynamicType. (commit 72b36ae5db2) ### §7.8.1.4 DynamicData as an interface following the mapping rules of this document

Spec: §7.8.1.4, p. 28 — “This interface is expressed in this PSM according to the mapping rules expressed elsewhere in this document.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicData.java (DynamicData), crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicDataFactory.java (DynamicDataFactory.newDynamicData), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataImpl.java (DynamicDataImpl), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataTypeSupport.java (DynamicDataTypeSupport)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aWriterAndAReaderOnTheTopicOfADynamicTypeMoveDynamicData, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aStructureWithANestedStructureAndAnArray, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aUnionIsItsDiscriminatorAndTheSelectedMember, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::everyPrimitiveKindIsReadBackWhatWasSet, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aSmallerSignedKindIsPromotedToTheLargerAccessor, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aValueOutsideTheRangeOfTheMemberIsRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::descriptorsAndMemberIdsFollowTheType, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::membersByNameAreTheMembersById, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::clearingANonOptionalMemberSetsItToItsDefault, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::clearingAnOptionalMemberRemovesIt, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::clearAllValuesClearsEveryMemberAndClearNonkeyValuesKeepsTheKey, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aLoanedStructureIsTheNestedValueAndChangesToItAreChangesToTheSample, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::theLoanIsReturnedOnlyOnceAndOnlyBySampleItCameFrom, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aValueThatDoesNotExistIsNotLoaned, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aLoanedPrimitiveIsWrittenBackOnReturn, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::cloneIsAnEqualSampleThatSharesNoValue

Status: done — DynamicData is an interface in org.omg.dds.type.dynamic; DynamicDataImpl implements it, DynamicDataFactory.newDynamicData creates it. TypesDynamicDataTest checks the accessors for Int16, Int32, Int64, Float32, Float64, Char, Byte, Boolean and String (directly and after encoding/decoding), the promotion to the larger accessor, getDescriptors, getMemberIdByName, getMemberIdAtIndex, clearValue (not optional: default value; optional: removed), clearAllValues, clearNonkeyValues (key values stay), loanValue/returnLoanedValue (after XTypes 1.3 §7.5.2.11.7: without a copy, one loan at a time, null for missing values, PreconditionNotMetException for a foreign return; primitives under MEMBER_ID_INVALID with write-back) and clone. The accessors through writer, reader and codec are checked by DynamicTopicTest. (commit a25948e911c) ### §7.8.1.4 Result returned directly instead of an in-out parameter

Spec: §7.8.1.4, p. 28 — “Operations that provide their result as an in-out value in their first parameter and return DDS::ReturnCode_t have been changed such that they instead return their results directly.”

Status: done — The read accessors of DynamicData return the value (getInt32Value as int, getStringValue as String, getComplexValue as DynamicData); the array forms fill the passed array and return the count. The tests read values from the sample read and compare them. There is no ReturnCode_t and no in-out parameter for the result. (commit d2ca428c7b8) ### §7.8.1.4 equals and clone as Object.equals and Object.clone

Spec: §7.8.1.4, p. 28 — “The equals and clone operations on these types have been mapped to overrides of the Java-standard Object.equals and Object.clone, respectively.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataImpl.java (DynamicDataImpl.clone), crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicData.java (DynamicData), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataImpl.java (DynamicDataImpl.equals), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataImpl.java (DynamicDataImpl.hashCode)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::cloneIsAnEqualSampleThatSharesNoValue, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aClonedArrayValueIsACopy, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::sampleAreEqualWhenTypeAndValuesAreWithoutRegardToTheOrderOfTheMembers, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aNonOptionalMemberOmittedByOneSampleEqualsItsDefaultInTheOther, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::nestedValuesAreComparedByValue, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::samplesWithTheSameFloat128ValueAreEqualWhateverTheScale

Status: done — DynamicDataImpl.clone() copies the values deeply (nested DynamicData, arrays, lists and maps); equals/hashCode compare, after XTypes 1.3 §7.5.2.11.5, the types (equal by value) and the values without regard to the order of the members; a non-optional member that one sample omits equals the default value in the other; BigDecimal is compared by value (1.5 equals 1.50). Tested in TypesDynamicDataTest. (commit a25948e911c) ### §7.8.1.4 No methods for unsigned types, access through same-size or next-larger types

Spec: §7.8.1.4, p. 28 — “Methods dealing with unsigned integer types have been omitted. Applications may access unsigned data using the signed type of the same size (e.g., UInt32 becomes Int32), which preserves bitwise representation but not logical value, or by using the signed type one size up (e.g., UInt32 becomes Int64), which preserves logical value but not representation […]. In the case of UInt64, the “type one size up” is java.math.BigInteger.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicData.java (DynamicData.getInt32Value), crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicData.java (DynamicData.getBigIntegerValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataImpl.java (DynamicDataImpl.getInt64Value), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataTypeSupport.java (DynamicDataTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataImpl.java (DynamicDataImpl.getBigIntegerValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataImpl.java (DynamicDataImpl.setBigIntegerValue)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::anUnsignedKindIsReadAsTheSignedKindOfTheSameSizeAndAsTheOneSizeUp, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::anUnsignedKindIsSetThroughTheOneSizeUpAsALogicalValue, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::unsignedMembersAreEncodedAndDecodedWithTheirFullRange, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aSequenceOfUnsigned64IsReadAsBigIntegers

Status: done — DynamicData has no methods for unsigned types. DynamicDataTypeSupport holds UINT_16 as Short, UINT_32 as Integer, UINT_64 as Long (bit pattern). The accessors follow the kind of the member: accessors of the same size (getInt16Value, getInt32Value, getInt64Value) give the bit pattern, the next larger accessor the logical value (UInt16 as int, UInt32 as long, UInt64 as getBigIntegerValue). The setters take the bit pattern for the same size and, for a larger accessor, the logical value with a range check (IllegalArgumentException). getBigIntegerValues/setBigIntegerValues handle UINT_64 sequences. TypesDynamicDataTest checks this and the encoding/decoding of UINT_16, UINT_32 and UINT_64 (20 octets, 10 00 00 00 FF FF 00 00 FF FF FF FF FF…). Sequences of UINT_16 and UINT_32 can be read through getInt32Values/getInt64Values only as the bit pattern of the same size. (commit a25948e911c) ### §7.8.1.4 Float128 as java.math.BigDecimal

Spec: §7.8.1.4, p. 28 — “The 128-bit Float128 type has been represented using java.math.BigDecimal.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicData.java (DynamicData.getBigDecimalValue), crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/DynamicData.java (DynamicData.setBigDecimalValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicDataTypeSupport.java (DynamicDataTypeSupport)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aFloat128MemberIsABigDecimalOnTheWireAndBack, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aFloat128MemberKeepsADigitStringADoubleCannotHold, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::samplesWithTheSameFloat128ValueAreEqualWhateverTheScale

Status: done — DynamicData has getBigDecimalValue/setBigDecimalValue and ...Values with List<BigDecimal>; DynamicDataTypeSupport writes and reads FLOAT_128_TYPE through Float128.fromBigDecimal and toBigDecimal. TypesDynamicDataTest sets a FLOAT_128 member (1.5: octets 10 00 00 00 and 00…00 80 FF 3F little-endian; 2^100+1, which a double cannot hold; 0; −0.25), encodes, decodes and reads it back. The code generator still maps long double to org.zerodds.wire.Float128 (crates/lang-rules/src/adapter/java.rs), independent of DynamicData. (commit a25948e911c) ### §7.8.1.5 Descriptors immutable, new ones from existing ones

Spec: §7.8.1.5, p. 28 — “This specification defines three descriptor interfaces. The instances of descriptor interfaces are immutable and therefore, provide methods to create new descriptor objects from the existing ones.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeDescriptorImpl.java (TypeDescriptorImpl), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/MemberDescriptorImpl.java (MemberDescriptorImpl), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/AnnotationDescriptorImpl.java (AnnotationDescriptorImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::aTypeDescriptorWithLeavesTheOriginalAsItWas, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::typeDescriptorsAreEqualWhenAllTheirPropertiesAre, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::aMemberDescriptorWithLeavesTheOriginalAsItWas, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::anAnnotationDescriptorWithLeavesTheOriginalAsItWas

Status: done — The with... methods of all three descriptors copy and change the copy. TypeDescriptorImpl.getBound and MemberDescriptorImpl.getLabel return unmodifiable lists; AnnotationDescriptorImpl.getAllValue returns a copy. TypesDynamicTypeTest checks for each descriptor that with... leaves the original unchanged, that the lists cannot be modified and that descriptors are equal by all properties (equals/hashCode). (commit a25948e911c) ### §7.8.1.5 AnnotationDescriptor

Spec: §7.8.1.5, p. 28 — “• AnnotationDescriptor”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/AnnotationDescriptor.java (AnnotationDescriptor), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/AnnotationDescriptorImpl.java (AnnotationDescriptorImpl), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.newAnnotationDescriptor)

Status: done — AnnotationDescriptor exists as an interface, DynamicTypeFactory.newAnnotationDescriptor creates it. The tests use it to build Key and Extensibility (withType, withValue) and check their effect on the codec. (commit 7d991374fd4) ### §7.8.1.5 MemberDescriptor

Spec: §7.8.1.5, p. 28 — “• MemberDescriptor”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/MemberDescriptor.java (MemberDescriptor), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/MemberDescriptorImpl.java (MemberDescriptorImpl), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.newMemberDescriptor)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aUnionIsItsDiscriminatorAndTheSelectedMember, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aStructureWithANestedStructureAndAnArray

Status: done — MemberDescriptor exists as an interface, DynamicTypeFactory.newMemberDescriptor creates it. The tests set withName, withId, withType and withLabel and so create members of a structure and a union that the codec encodes and decodes. (commit 7d991374fd4) ### §7.8.1.5 TypeDescriptor

Spec: §7.8.1.5, p. 28 — “• TypeDescriptor”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/dynamic/TypeDescriptor.java (TypeDescriptor), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeDescriptorImpl.java (TypeDescriptorImpl), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.newTypeDescriptor)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::aTypeDescriptorCarriesTheTypesItNames, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aUnionIsItsDiscriminatorAndTheSelectedMember

Status: done — TypeDescriptor exists as an interface, DynamicTypeFactory.newTypeDescriptor creates it. aTypeDescriptorCarriesTheTypesItNames checks getKind and getElementType after serialization; the union test sets withKind, withName and withDiscriminatorType. (commit 7d991374fd4) ### §7.8.2 Four built-in types of [DDS-XTypes]

Spec: §7.8.2, p. 29 — “[DDS-XTypes] specifies four built-in types: DDS::String, DDS::Bytes, DDS::KeyedString, and DDS::KeyedBytes.”

Repo: —

Tests: —

Status: n/a (informative) — Enumeration of the four built-in types of [DDS-XTypes]; the mappings are in the following items. ### §7.8.2 DDS::String as java.lang.String

Spec: §7.8.2, p. 29 — “• DDS::String is mapped to java.lang.String.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.isValueType), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeSupportResolver.java (TypeSupportResolver.resolve), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/BuiltinTypeSupports.java (BuiltinTypeSupports.StringTypeSupport)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::stringIsTheBuiltInTypeDdsString, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aStringTopicIsDdsStringAndMovesSamples, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aTruncatedOrInconsistentStringIsRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::lookupTopicDescriptionFindsOnlyWhatWasCreated

Status: done — TypeSupportResolver.resolve(String.class) returns BuiltinTypeSupports.StringTypeSupport: type name DDS::String, APPENDABLE (XTypes 1.3 Annex E: struct _String { string value; }), unchanged for String as a member of a structure. For example "hi" is 07 00 00 00 03 00 00 00 68 69 00 (DHEADER 7, length 3, characters, NUL), in big-endian with the words reversed; the string follows the setting of the item on narrow characters (truncation by default, UTF-8 as a named setting). TypesBuiltinTest checks the type name, the octets in both byte orders, the empty string, the refusal of truncated data and of null, and writes and reads a String sample over a topic. DomainParticipantOperationsTest::lookupTopicDescriptionFindsOnlyWhatWasCreated now expects DDS::String instead of java::lang::String. (commit ec44921ff1d) ### §7.8.2 DDS::Bytes as byte[]

Spec: §7.8.2, p. 29 — “• DDS::Bytes is mapped to byte[].”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ByteArrayTypeSupport.java (ByteArrayTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeSupportResolver.java (TypeSupportResolver.resolve)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::typeNameIsDdsBytes, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::encodeFramesTheBytes, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::byteArrayQuickstartRoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::largeByteArrayGrowsEncoderBuffer

Status: done — TypeSupportResolver.resolve(byte[].class) returns ByteArrayTypeSupport with type name DDS::Bytes and APPENDABLE framing (DHEADER, length, octets). typeNameIsDdsBytes and encodeFramesTheBytes check the name and the octets (07 00 00 00 03 00 00 00 01 02 03); the two quickstart tests write and read 5 and 4096 bytes through a Topic<byte[]>. (commit 5041698cee3) ### §7.8.2 byte[] topics as DDS::Bytes: type name and representation

Spec: §7.8.2, p. 29 — “[DDS-XTypes] specifies four built-in types: DDS::String, DDS::Bytes, DDS::KeyedString, and DDS::KeyedBytes. […] • DDS::Bytes is mapped to byte[].”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ByteArrayTypeSupport.java (ByteArrayTypeSupport.getTypeName), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ByteArrayTypeSupport.java (ByteArrayTypeSupport.encode), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ByteArrayTypeSupport.java (ByteArrayTypeSupport.decode)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::typeNameIsDdsBytes, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::encodeFramesTheBytes, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::decodeUnframesTheBytes, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::bigEndianFramingFollowsTheChosenByteOrder, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::truncatedOrInconsistentFramingIsRefused

Status: done — getTypeName() returns DDS::Bytes, getExtensibility() APPENDABLE; encode writes the DHEADER (length + 4), the sequence length and the octets, decode checks both and throws XcdrException on a mismatch. This matches XTypes 1.3 Annex E (@extensibility(APPENDABLE) struct Bytes { ByteSeq value; }). The tests check the name, the octets in little and big endian and the refusal of truncated or inconsistent framing. (commit 5041698cee3) ### §7.8.2 DDS::KeyedString as a modifiable value type

Spec: §7.8.2, p. 29 — “• DDS::KeyedString and DDS::KeyedBytes are mapped to modifiable value type interfaces.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/builtin/KeyedString.java (KeyedString), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/BuiltinTypes.java (BuiltinTypes.KeyedStringImpl), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.newKeyedString), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/BuiltinTypeSupports.java (BuiltinTypeSupports.KeyedStringTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeSupportResolver.java (TypeSupportResolver.resolve), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeSupportImpl.java (TypeSupportImpl.newData)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedStringIsAModifiableValueType, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedStringCopyFromCloneAndEquals, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedStringSurvivesJavaSerialization, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedStringIsTheBuiltInTypeDdsKeyedString, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::theKeyHashOfAKeyedStringIsTheMd5OfItsKeyInBigEndian, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aKeyedStringTopicHasOneInstancePerKey, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aKeyedStringTopicSampleIsANewValueObject, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aTruncatedKeyedStringIsRefused

Status: done — KeyedString and KeyedStringImpl are a modifiable value type (setKey/setValue return the object, copyFrom, clone, equals, hashCode, Java serialization without the environment). TypeSupportResolver.resolve returns BuiltinTypeSupports.KeyedStringTypeSupport for KeyedString and every subclass: type name DDS::KeyedString, APPENDABLE, key as the key. Example: key k, value vv is 0F 00 00 00 02 00 00 00 6B 00 00 00 03 00 00 00 76 76 00 (the length of the second string is 4-aligned). The key hash is the MD5 of the big-endian serialization of the key (an unbounded string has no maximum size ≤ 16 octets; XTypes 1.3 §7.6.8, DDSI-RTPS 2.5 §9.6.3.8): 302cf0a69dae0d4732bd21ea86fec48d for k. TypeSupportImpl.newData creates the sample through the SPI. Tested in TypesBuiltinTest, including a writer and reader with one instance per key. (commit ec44921ff1d) ### §7.8.2 DDS::KeyedBytes as a modifiable value type

Spec: §7.8.2, p. 29 — “• DDS::KeyedString and DDS::KeyedBytes are mapped to modifiable value type interfaces.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/builtin/KeyedBytes.java (KeyedBytes), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/BuiltinTypes.java (BuiltinTypes.KeyedBytesImpl), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.newKeyedBytes), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/BuiltinTypeSupports.java (BuiltinTypeSupports.KeyedBytesTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeSupportResolver.java (TypeSupportResolver.resolve), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/TypeSupportImpl.java (TypeSupportImpl.newData)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedBytesIsAModifiableValueType, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedBytesCopyFromCloneAndEquals, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedBytesSurvivesJavaSerialization, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedBytesIsTheBuiltInTypeDdsKeyedBytes, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::theKeyHashOfKeyedBytesIsTheMd5OfItsKey, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aKeyedBytesTopicHasOneInstancePerKey, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aKeyedBytesTopicSampleIsANewValueObject, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aTruncatedKeyedBytesIsRefused

Status: done — KeyedBytes and KeyedBytesImpl are a modifiable value type (setValue(byte[]) and setValue(byte[], int, int) copy, getValue returns a copy, copyFrom, clone, equals, hashCode, Java serialization). TypeSupportResolver.resolve returns BuiltinTypeSupports.KeyedBytesTypeSupport for KeyedBytes: type name DDS::KeyedBytes, APPENDABLE, key as the key. Example: key k, value 01 02 03 is 0F 00 00 00 02 00 00 00 6B 00 00 00 03 00 00 00 01 02 03. The key hash is the MD5 of the key as for KeyedString. Tested in TypesBuiltinTest, including a writer and reader with one instance per key. (commit ec44921ff1d) ### §7.8.2 DataReader and DataWriter for the built-in types

Spec: §7.8.2, p. 29 — “The generic DataReader and DataWriter interfaces are applicable to the built-in types.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ByteArrayTypeSupport.java (ByteArrayTypeSupport), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/BuiltinTypeSupports.java (BuiltinTypeSupports)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::byteArrayQuickstartRoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aStringTopicIsDdsStringAndMovesSamples, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aKeyedStringTopicHasOneInstancePerKey, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aKeyedBytesTopicHasOneInstancePerKey, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::bytesAreStillTheBuiltInTypeDdsBytes

Status: done — One DataWriter and one DataReader each on a topic of byte[] (DDS::Bytes, ByteArrayTypeSupport), String (DDS::String), KeyedString and KeyedBytes write and read samples: byteArrayQuickstartRoundTrip and the tests aStringTopicIsDdsStringAndMovesSamples, aKeyedStringTopicHasOneInstancePerKey, aKeyedBytesTopicHasOneInstancePerKey in TypesBuiltinTest. (commit ec44921ff1d) ### §7.8.2 Generic createDataReader and createDataWriter for the built-in types

Spec: §7.8.2, p. 29 — “Subscriber and Publisher provide generic createDataReader and createDataWriter methods to create datareader and datawriter for the built-in types, respectively.”

Status: done — Publisher.createDataWriter(Topic<TYPE>) and Subscriber.createDataReader(TopicDescription<TYPE>) are generic; the TypeSupport comes from the topic, which TypeSupportResolver.resolve fills with the built-in TypeSupport for byte[], String, KeyedString and KeyedBytes. The tests use the overloads with the topic only (byteArrayQuickstartRoundTrip, TypesBuiltinTest). (commit ec44921ff1d) ### §7.8.3 Types of TypeObject as value types according to the rules of this document

Spec: §7.8.3, p. 29 — “The types in this package are expressed as modifiable value types according to the mapping rules expressed elsewhere in this document.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/TypeObjectModel.java (TypeObjectModel), crates/java-omgdds/java/src/main/java/org/zerodds/typeobject/generated/ZdTypes.java (ZdTypes)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectModelTest.java::equalStateIsEqualObjects, crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectModelTest.java::theObjectsAreSerializable

Status: done — The interfaces in org.omg.dds.type.typeobject of the OMG source have only read methods (the Javadoc of TypeObject and Member calls the objects immutable); the source prevails under §2, and org/omg/dds stays equal to it. The objects TypeObjectModel returns are value types per §7.3.3: Serializable, with equals and hashCode by state (TypeObjectModelTest::equalStateIsEqualObjects); a TypeObject is changed through the mutable data classes of the codec (ZdTypes.DDS.*: public fields, TypeObjectCodec.encode/decode) and TypeObjectModel.of. The changes of the mapping from §7.8.3 (constants in interfaces, MemberId classes) are tested (TypesTypeObjectConstantsTest). (commit b4bf3fa978e) ### §7.8.3 Top-level constants inside interfaces, e.g. Member.MEMBER_ID_INVALID

Spec: §7.8.3, p. 29 — “• Top-level constants are moved into related interfaces, for example: Member.MEMBER_ID_INVALID.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/typeobject/Member.java (Member.MEMBER_ID_INVALID)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesTypeObjectConstantsTest.java::theConstantsOfTheTopLevelAreMovedIntoTheInterfaces, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesTypeObjectConstantsTest.java::theInterfacesTheConstantsLiveInAreTheOnesOfTheTopLevelTypes

Status: done — Member.MEMBER_ID_INVALID is declared as the int constant 0x0FFFFFFF in the interface Member; the value is the largest of the 28-bit range of member ids (XTypes 1.3 §7.2.2.4.4.4.4) and equals MEMBER_ID_INVALID in crates/types/src/dynamic/descriptor.rs. Further constants in interfaces: CollectionType.UNBOUNDED_COLLECTION (0) and the type ids in TypeId (equal to the TypeKind.Values). TypesTypeObjectConstantsTest reads them. (commit ffbb2d554ca) ### §7.8.3 Member IDs as nested final classes with int constants

Spec: §7.8.3, p. 29 — “Enumerations of member ID values are nested final classes within the interfaces for which they provide the member’s IDs. These classes have constant integer fields, for example: MapType.MemberId.BOUND_MAPTYPE_MEMBER_ID.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/typeobject/MapType.java (MapType.MemberId), crates/java-omgdds/java/src/main/java/org/omg/dds/type/typeobject/Type.java (Type.MemberId)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesTypeObjectConstantsTest.java::memberIdsAreNestedFinalClassesOfIntConstants, crates/java-omgdds/java/src/test/java/org/zerodds/typeobject/TypeObjectTest.java::theMemberIdsAreThoseOfAnnexBOfXTypes11

Status: done — The interfaces in org.omg.dds.type.typeobject each carry a nested final class MemberId with a private constructor and int constants, e.g. MapType.MemberId.BOUND_MAPTYPE_MEMBER_ID = 201. TypesTypeObjectConstantsTest checks for 15 interfaces the names and values of the constants against the OMG source, that the class is final, public and static, has no public constructor, and that the values are exactly the @ID values of the getters of the same interface. TypeObjectTest::theMemberIdsAreThoseOfAnnexBOfXTypes11 compares the values with the enumerations of DDS-XTypes 1.1 Annex B (TypeMemberId 0, 1; StructureTypeMemberId 100, 101; MapTypeMemberId 200, 201; …), which are in the spec cache now; the values agree. The source has in CollectionType.MemberId only ELEMENT_TYPE_COLLECTIONTYPE_MEMBER_ID; the constant ELEMENT_SHARED_COLLECTIONTYPE_MEMBER_ID (101) of the annex is not there, and org/omg/dds stays equal to the source. (commit b4bf3fa978e)

§8.1 General

§8.1 Publish Java objects without code generation and without the Dynamic Language Binding

Spec: §8.1, p. 31 — “The Java Type Representation defined in this clause provides a means for Java developers to publish and subscribe to DDS topics typed by plain Java objects without resorting to code generation or the reflective style of the Dynamic Language Binding.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::singleArgFactoryReflectsTypedBean, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::pointMatchesV2, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — For a class without a generated TypeSupport, TypeSupportResolver.resolve falls back to ReflectionTypeSupport. singleArgFactoryReflectsTypedBean writes and reads a bean with an int and a String field through createDataWriter(Topic)/createDataReader(Topic) without IDL and without the Dynamic Language Binding; pointMatchesV2 and mixedIsByteIdenticalToTypedPath check the octets against the generated path. (commit 819bfcb46cb) ### §8.1 At the same time a language binding, meant for run time

Spec: §8.1, p. 31 — “By its very nature as an expression of the Java programming language, this Type Representation implicitly and simultaneously defines a Language Binding for DDS types. […] Therefore, this Type Representation is intended for the run-time use of implementations of this PSM. While this specification does not preclude Service implementations from using this Type Representation for other purposes […] such uses are non-normative and unspecified.”

Repo: —

Tests: —

Status: n/a (informative) — Classification of the type representation as a language binding for run-time use; the specification requires nothing testable here. ### §8.1 Every Serializable type can be published

Spec: §8.1, p. 31 — “Any Java type that implements Serializable (directly or indirectly) shall be available for publishing and/or subscribing over DDS as defined below.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.introspect), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.fieldsOf), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.refuseJdkType), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JdkValueTypes.java (JdkValueTypes), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JdkSerializedValues.java (JdkSerializedValues), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JdkTopicTypeSupport.java (JdkTopicTypeSupport)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theMembersOfTheBaseClassComeFirst, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theKindsOfTable81RoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::singleArgFactoryReflectsTypedBean, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aSerializableClassOfTheApplicationIsATopicType, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aSerializableClassOfTheJdkIsPublishedInTheFormOfItsKind, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::theTypesOfTable81AreNotRefusedAsTypesOfTheJdk, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aSerializableClassOfTheJdkIsPublishedInTheFormOfItsKind, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::theFormsOfDateAndUuidAreTheirTable81Parts, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::listsAndArraysOfJdkValuesAreSequences, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aJdkClassIsATopicTypeItself, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::theOctetsOfAJdkValueNeverMakeAnotherClass, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aValueTheClassRefusesIsRefusedOnReading

Status: done — ReflectionTypeSupport accepts every class and does not check Serializable; serialVersionUID is static and no member. A Serializable class of the application is published (aSerializableClassOfTheApplicationIsATopicType: octets 04 00 00 00 03 00 00 00 61 62 00), with the rules of the Java Type Representation including the restriction of java.io.Serializable for superclasses. The Serializable classes of the JDK without an entry in Table 8.1 can be published, as the type of a topic, a field, a sequence element or an array component: java.util.Date (int64 milliseconds), UUID (two int64), URI, Locale and Currency (a string each) and java.time.Instant, Duration, Period, LocalDate, LocalTime, LocalDateTime, OffsetDateTime, ZonedDateTime, ZoneOffset, Year, YearMonth, MonthDay as a structure of Table 8.1 types (JdkValueTypes, the fields in the Javadoc of the class); every other concrete Serializable class of the JDK (such as java.util.BitSet) as its Java serialization, a sequence<octet> (JdkSerializedValues; only Java programs read it). Reading never makes another class: the stream may name only the declared class and classes of java.lang and may be at most 1 MiB long, else XcdrException (theOctetsOfAJdkValueNeverMakeAnotherClass); so does a value the class refuses (month 13). A JDK class that is not Serializable or not concrete is rejected when the type is created with an XcdrException that names the class, the field, Table 8.1 and a way out. A DynamicType (createType) and a TypeObject do not know these JDK classes; a type with such a field announces no TypeObject. (commit bf27136ca70) ### §8.1 DDS serialization not equal to the JRE serialization

Spec: §8.1, p. 31 — “Note that the DDS serialization of a type will not generally be the same as the JRE serialization of the same type, even if the type designer’s specification of which data to serialize can be shared between these two mechanisms.”

Repo: —

Tests: —

Status: n/a (informative) — A remark that DDS serialization differs from JRE serialization. ReflectionTypeSupport writes XCDR2 through org.zerodds.wire.Writer and does not consider writeObject, readObject or serialPersistentFields.

§8.2 Default Mappings

§8.2 Table 8.1: `int`, `java.lang.Integer` → INT32

Spec: §8.2, p. 31, Table 8.1 — “INT, JAVA.LANG.INTEGER | INT32”

Status: done — int becomes INT32 (Mixed.i against the Writer path in the first test, octets 01 00 00 00 … in pointMatchesV2); Integer as an element of List<Integer> in the second test. A field of the wrapper type holding null without @Optional throws XcdrException (ReflectionTypeSupport.encodeMember); the wrapper class has no test of its own (read from the code, not measured). (commit 819bfcb46cb) ### §8.2 Table 8.1: short, java.lang.Short → INT16

Spec: §8.2, p. 31, Table 8.1 — “SHORT, JAVA.LANG.SHORT | INT16”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — mixedIsByteIdenticalToTypedPath checks short as INT16 against the Writer path; Short takes the same branch in encodeValue/decodeValue and has no test of its own. (commit 819bfcb46cb) ### §8.2 Table 8.1: long, java.lang.Long → INT64

Spec: §8.2, p. 31, Table 8.1 — “LONG, JAVA.LANG.LONG | INT64”

Status: done — Both tests check long as INT64 (octets against the Writer path, round trip of a negative value in a MUTABLE type); Long takes the same branch and has no test of its own. (commit 819bfcb46cb) ### §8.2 Table 8.1: float, java.lang.Float → FLOAT32

Spec: §8.2, p. 31, Table 8.1 — “FLOAT, JAVA.LANG.FLOAT | FLOAT32”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — mixedIsByteIdenticalToTypedPath checks float (2.5f) as FLOAT32 against the Writer path; Float takes the same branch and has no test of its own. (commit 819bfcb46cb) ### §8.2 Table 8.1: double, java.lang.Double → FLOAT64

Spec: §8.2, p. 31, Table 8.1 — “DOUBLE, JAVA.LANG.DOUBLE | FLOAT64”

Status: done — Both tests check double as FLOAT64; sensorMatchesV8 compares the octets 1F 85 EB 51 B8 1E 09 40 for 3.14. Double takes the same branch and has no test of its own. (commit 819bfcb46cb) ### §8.2 Table 8.1: char, java.lang.Character → CHAR8

Spec: §8.2, p. 31, Table 8.1 — “CHAR, JAVA.LANG.CHARACTER | CHAR8”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue), runtime/java/src/main/java/org/zerodds/wire/Writer.java (Writer.writeChar)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — mixedIsByteIdenticalToTypedPath checks 'Z' as CHAR8 against the Writer path. Character takes the same branch. A character above U+00FF throws WireException.OutOfRange (Writer.writeChar; without @SerializeAs the exception is not converted to XcdrException) (read from the code, not measured). (commit 819bfcb46cb) ### §8.2 Table 8.1: byte, java.lang.Byte → BYTE

Spec: §8.2, p. 31, Table 8.1 — “BYTE, JAVA.LANG.BYTE | BYTE”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — mixedIsByteIdenticalToTypedPath checks (byte) 0xAB as BYTE; Byte takes the same branch and has no test of its own. (commit 819bfcb46cb) ### §8.2 Table 8.1: boolean, java.lang.Boolean → BOOLEAN

Spec: §8.2, p. 31, Table 8.1 — “BOOLEAN, JAVA.LANG.BOOLEAN | BOOLEAN”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — mixedIsByteIdenticalToTypedPath checks true as BOOLEAN; Boolean takes the same branch and has no test of its own. (commit 819bfcb46cb) ### §8.2 Table 8.1: java.lang.String → STRING

Spec: §8.2, p. 31, Table 8.1 — “JAVA.LANG.STRING | STRING”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::stringMatchesV4, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aNarrowStringIsTruncatedToItsLowOctetByDefault

Status: done — stringMatchesV4 checks the octets of "hello" (06 00 00 00 68 65 6C 6C 6F 00), aNarrowStringIsTruncatedToItsLowOctetByDefault those of "été" and "AŁ" (one octet per character, length including the terminator). The default for characters above U+007F is the truncation of §8.5.1, UTF-8 is the named setting zerodds.java.narrow-string=utf8; see the item “§8.5.1 Narrow characters: each Java character truncated to its least-significant byte”. (commit 819bfcb46cb) ### §8.2 Table 8.1: java.util.Map → map

Spec: §8.2, p. 31, Table 8.1 — “java.util.Map | map”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeMap), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.decodeMap)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mapRoundtrips, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aMapIsADheaderACountAndTheEntries, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aMapIsReadIntoTheMapClassTheFieldDeclares

Status: done — mapRoundtrips: Map<String, Integer> goes there and back, the order is kept. aMapIsADheaderACountAndTheEntries checks the octets (DHEADER, count, key/value pairs: 10 00 00 00 01 00 00 00 02 00 00 00 61 00 00 00 01 00 00 00). The field has to be declared with type arguments, otherwise elementClass throws an XcdrException. (commit 4aa407a112d) ### §8.2 Table 8.1: java.lang.Collection and array → sequence

Spec: §8.2, p. 31, Table 8.1 — “java.lang.Collection, array | sequence”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::seqPrimitiveMatchesV5, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::seqStringMatchesV6, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::arrayRoundtrips, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::aSequenceIsWrittenForEveryCollection, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theKindsOfTable81RoundTrip, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aSequenceIsReadIntoTheCollectionTheFieldDeclares, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::emptyCollectionsAreReadIntoTheirClassesToo, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aCollectionTypeNoStandardClassFillsIsRefusedWhenRead

Status: done — List, Set, Queue, Deque, SortedSet, NavigableSet, EnumSet and arrays become sequences; the tests check octets (V-5, V-6) and round trips. When reading, ReflectionTypeSupport.collection builds the class of the field: for an interface or abstract class the first of ArrayList, LinkedHashSet, TreeSet, ArrayDeque, LinkedBlockingDeque that it is (Collection/List ArrayList, Set LinkedHashSet, SortedSet/NavigableSet TreeSet, Queue/Deque ArrayDeque); EnumSet over the element class; a concrete class through its no-argument constructor. A field type that no standard class fills is an XcdrException, not another collection. TypesJavaRepresentationTest::aSequenceIsReadIntoTheCollectionTheFieldDeclares checks class and order for ten field types. (commit f0649c27acc) ### §8.2 Table 8.1: java.lang.Object → Structure

Spec: §8.2, p. 31, Table 8.1 — “java.lang.Object | Structure”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::nestedFinalInline, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::pointMatchesV2

Status: done — A class becomes a structure, nested classes become nested structures; pointMatchesV2 and nestedFinalInline check the octets (FINAL without a DHEADER, 16 bytes for two Point). (commit 819bfcb46cb) ### §8.2 @SerializeAs changes the defaults per type and per field, value() of type TypeKind

Spec: §8.2, p. 32 — “A type designer may modify these defaults on a type-by-type and/or field-by-field basis by applying the annotation org.omg.dds.type.SerializeAs: public @interface SerializeAs { public TypeKind value(); … }”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/SerializeAs.java (SerializeAs), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.ofField), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.introspectUnion)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint32HeldInALongKeepsTheLogicalValue, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aKindTable82DoesNotListForTheTypeIsRefused, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aUnionIsItsDiscriminatorAndTheSelectedMember, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aWideStringIsMarkedWithSerializeAs, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aKindOtherThanStructureOrUnionOnAClassIsRefused

Status: done — org.omg.dds.type.SerializeAs has TypeKind value() (plus collectionElementKind, mapKeyElementKind, bound). On a field it changes the default (JavaRepresentation.ofField; the tests check UInt32, a combination Table 8.2 does not allow and a wide string); on a class STRUCTURE_TYPE or UNION_TYPE applies (introspectUnion; aUnionIsItsDiscriminatorAndTheSelectedMember checks the octets), other kinds on a class are refused by introspectUnion with XcdrException (aKindOtherThanStructureOrUnionOnAClassIsRefused). The annotation on methods has no effect. (commit 4aa407a112d)

§8.3 Metadata

§8.3 IDL metadata as equivalent Java annotations

Spec: §8.3, p. 32 — “The type system metadata represented with built-in annotations in the IDL Type Representation (such as @Key, @ID) shall be represented by equivalent Java annotations unless otherwise noted.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::sensorMatchesV8, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theTypeSystemAnnotationsAreRead, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::onlyTheTypeSystemAnnotationsCount, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::anAnnotationOverridesTheDefault, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::theIdOfAMemberIsItsIdOnTheWireAndAnAbsentOptionalMemberHasNone, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::theAnnotationsAreMembersOfTheDynamicTypeToo, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::annotationsOfAnotherPackageWithTheNamesOfTheTypeSystemAreIgnored

Status: done — @Key (sensorMatchesV8, theTypeSystemAnnotationsAreRead) and @Extensibility (anAnnotationOverridesTheDefault) from org.omg.dds.type are read, foreign annotations of the same name are not. ReflectionTypeSupport.annotation compares the simple name without regard to case, so org.omg.dds.type.ID counts as Id. theIdOfAMemberIsItsIdOnTheWireAndAnAbsentOptionalMemberHasNone checks the octets on a MUTABLE class with @ID(5), @Optional @ID(9) and @MustUnderstand @ID(12): DHEADER, EMHEADERs 0x40000005, 0x40000009 and 0xC000000C (M flag for @MustUnderstand) each with a NEXTINT, no EMHEADER for an absent optional member; theAnnotationsAreMembersOfTheDynamicTypeToo the annotations in createType. @Shared, @Nested, @Verbatim and @Value have no effect on the wire form. (commit f0649c27acc) ### §8.3 Annotations in the package org.omg.dds.type

Spec: §8.3, p. 32 — “These annotations are in the package org.omg.dds.type.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/Key.java (Key), crates/java-omgdds/java/src/main/java/org/omg/dds/type/ID.java (ID), crates/java-omgdds/java/src/main/java/org/omg/dds/type/Optional.java (Optional), crates/java-omgdds/java/src/main/java/org/omg/dds/type/MustUnderstand.java (MustUnderstand), crates/java-omgdds/java/src/main/java/org/omg/dds/type/Extensibility.java (Extensibility), crates/java-omgdds/java/src/main/java/org/omg/dds/type/SerializeAs.java (SerializeAs)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theTypeSystemAnnotationsAreRead, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint32HeldInALongKeepsTheLogicalValue

Status: done — The package org.omg.dds.type contains Key, ID, Optional, MustUnderstand, Extensibility, Shared, Nested, Verbatim, Value, BitBound, BitSet, SerializeAs, UnionDiscriminator, UnionMember. The tests import and use Key, ID, Extensibility and SerializeAs from this package (name requirement). ReflectionTypeSupport.annotation reads them from org.omg.dds.type and from org.zerodds.types. (commit 5041698cee3) ### §8.3 Annotations on classes and fields, no specified behaviour on interfaces and methods

Spec: §8.3, p. 32 — “The annotations in this package logically govern the behavior of concrete classes, not of polymorphic interfaces. As such, they may be applied to classes or to their fields, as appropriate. Interface designers wishing to document the DDS serialization of a type may additionally apply them to interfaces or to property accessor and/or mutator methods; however, they have no specified behavior in such cases.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.introspect)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::anAnnotationOverridesTheDefault, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::sensorMatchesV8

Status: done — introspect reads annotations of the class (@Extensibility, anAnnotationOverridesTheDefault) and of its fields (@Key, sensorMatchesV8). Annotations on methods are not evaluated, which is what the specification leaves open for that case (“no specified behavior”). (commit 819bfcb46cb)

§8.4 Primitive Types

§8.4 Defaults by Table 8.2, changes through `@SerializeAs`

Spec: §8.4, p. 32 — “By default, Java primitive types are mapped to DDS primitive types as defined in Table 8.2. The @SerializeAs annotation may be used to modify these mappings as follows.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint32HeldInALongKeepsTheLogicalValue, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aKindTable82DoesNotListForTheTypeIsRefused

Status: done — The defaults of Table 8.2 apply without an annotation (mixedIsByteIdenticalToTypedPath). @SerializeAs changes them per field (uint32HeldInALongKeepsTheLogicalValue), and JavaRepresentation.check refuses combinations Table 8.2 does not list (aKindTable82DoesNotListForTheTypeIsRefused). (commit 874bc5ac9fe) ### §8.4 Table 8.2: Int32 from int, Integer

Spec: §8.4, p. 32, Table 8.2 — “Int32 | int, java.lang.Integer”

Status: done — int and Integer are the default for Int32 (mixedIsByteIdenticalToTypedPath for int, Integer as a list element in seqPrimitiveMatchesV5); @SerializeAs(INT_32_TYPE) on a long is refused (aKindTable82DoesNotListForTheTypeIsRefused). (commit 874bc5ac9fe) ### §8.4 Table 8.2: UInt32 from int, long, Integer, Long

Spec: §8.4, p. 32, Table 8.2 — “UInt32 | int, long, java.lang.Integer, java.lang.Long”

Status: done — @SerializeAs(UINT_32_TYPE) on long keeps the logical value (4,000,000,000 becomes 00 28 6B EE, 2^32 and −1 are XcdrException); on int the bit pattern stays (−1 becomes FF FF FF FF). check allows Integer and Long, without a test of its own. (commit 874bc5ac9fe) ### §8.4 Table 8.2: Int16 from short, Short

Spec: §8.4, p. 32, Table 8.2 — “Int16 | short, java.lang.Short”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — Default; mixedIsByteIdenticalToTypedPath checks short as Int16 against the Writer path. (commit 819bfcb46cb) ### §8.4 Table 8.2: UInt16 from short, int, Short, Integer

Spec: §8.4, p. 32, Table 8.2 — “UInt16 | short, int, java.lang.Short, java.lang.Integer”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint16IntKeepsTheValueAndShortTheBitPattern

Status: done — @SerializeAs(UINT_16_TYPE): on int the value stays (65535 becomes FF FF, 65536 is XcdrException), on short the bit pattern (−2 becomes FE FF). The test checks the octets and the round trip; check allows Short and Integer, without a test of its own. (commit 874bc5ac9fe) ### §8.4 Table 8.2: Int64 from long, Long

Spec: §8.4, p. 32, Table 8.2 — “Int64 | long, java.lang.Long”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mutableLongRoundtrips, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — Default; mutableLongRoundtrips and mixedIsByteIdenticalToTypedPath check long as Int64. (commit 819bfcb46cb) ### §8.4 Table 8.2: UInt64 from long, Long, BigInteger

Spec: §8.4, p. 32, Table 8.2 — “UInt64 | long, java.lang.Long, java.math.BigInteger”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.encodeKind), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint64TakesABigIntegerOrALong, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theKindsOfTable81RoundTrip, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aBigIntegerWithoutAnnotationIsUInt64AndIsRangeChecked

Status: done — @SerializeAs(UINT_64_TYPE) takes BigInteger (2^64−1 becomes eight FF, 2^64 is XcdrException) or long (bit pattern); without the annotation BigInteger is UInt64. In the default branch ReflectionTypeSupport.encodeValue a BigInteger outside 0 to 2^64−1 is refused with XcdrException and not cut by longValue(). aBigIntegerWithoutAnnotationIsUInt64AndIsRangeChecked checks 2^64−1 (eight FF), 0, 2^63 (00…80), −1, 2^64 and 2^100. (commit f0649c27acc) ### §8.4 Table 8.2: Float32 from float, Float

Spec: §8.4, p. 32, Table 8.2 — “Float32 | float, java.lang.Float”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — Default; mixedIsByteIdenticalToTypedPath checks float as Float32 against the Writer path. (commit 819bfcb46cb) ### §8.4 Table 8.2: Float64 from double, Double

Spec: §8.4, p. 32, Table 8.2 — “Float64 | double, java.lang.Double”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Status: done — Default; sensorMatchesV8 and mixedIsByteIdenticalToTypedPath check double as Float64. (commit 819bfcb46cb) ### §8.4 Table 8.2: Float128 from double, Double, BigDecimal

Spec: §8.4, p. 32, Table 8.2 — “Float128 | double, java.lang.Double, java.math.BigDecimal”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::float128HeldInADouble, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theKindsOfTable81RoundTrip

Status: done — @SerializeAs(FLOAT_128_TYPE) on double: float128HeldInADouble checks the 16 octets for 1.0 (exponent 3FFF) and the round trip. BigDecimal is Float128 without an annotation; theKindsOfTable81RoundTrip checks the round trip of 1.25 (numeric value, not scale), no octets. check allows Double, without a test of its own. (commit 874bc5ac9fe) ### §8.4 Table 8.2: Byte from byte, Byte

Spec: §8.4, p. 32, Table 8.2 — “Byte | byte, java.lang.Byte”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — Default; mixedIsByteIdenticalToTypedPath checks byte as Byte. (commit 819bfcb46cb) ### §8.4 Table 8.2: Boolean from boolean, Boolean

Spec: §8.4, p. 32, Table 8.2 — “Boolean | boolean, java.lang.Boolean”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — Default; mixedIsByteIdenticalToTypedPath checks boolean as Boolean. (commit 819bfcb46cb) ### §8.4 Table 8.2: Char8 from char, Character

Spec: §8.4, p. 32, Table 8.2 — “Char8 | char, java.lang.Character”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — Default; mixedIsByteIdenticalToTypedPath checks char as Char8. (commit 819bfcb46cb) ### §8.4 Table 8.2: Char32 from char, int, Character, Integer

Spec: §8.4, p. 32, Table 8.2 — “Char32 | char, int, java.lang.Character, java.lang.Integer”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.encodeKind)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::char32IsAFourOctetCodePoint

Status: done — @SerializeAs(CHAR_32_TYPE) on int: code point U+1F600 becomes 00 F6 01 00, round trip. check allows char, Character and Integer, without a test of its own; a value above U+10FFFF is XcdrException. (commit 874bc5ac9fe) ### §8.4 Unsigned values: keep the representation or the logical value

Spec: §8.4, p. 33 — “The DDS Type System ([DDS-XTypes]) defines unsigned integer types; the Java type system does not. As a result, this Type Representation must map unsigned values to “equivalent” signed types. Type designers have two choices, reflected in the table above: • Preserve representation […] • Preserve logical value […]”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.encodeKind)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint32HeldInALongKeepsTheLogicalValue, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint32HeldInAnIntKeepsTheBitPattern, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint16IntKeepsTheValueAndShortTheBitPattern, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint64TakesABigIntegerOrALong

Status: done — Both choices are implemented and checked: Java types of the same size keep the bit pattern (int for UInt32, short for UInt16, long for UInt64), larger Java types the logical value (long, int, BigInteger), with XcdrException outside the range. (commit 874bc5ac9fe)

§8.5 Collections

§8.5 Three kinds of collections

Spec: §8.5, p. 33 — “[DDS-XTypes] recognizes three categories of collections: strings (variable-length lists of narrow or wide characters), sequences (variable-length lists of any single element type), and maps (homogeneously typed key-value mappings).”

Repo: —

Tests: —

Status: n/a (informative) — Classification of the three collection categories of XTypes; the specification requires nothing testable here. ### §8.5.1 DDS strings as Java String

Spec: §8.5.1, p. 33 — “DDS strings, whether of narrow or wide characters, are represented by Java String objects.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::stringMatchesV4, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::seqStringMatchesV6, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aWideStringIsMarkedWithSerializeAs

Status: done — A String field becomes a narrow string and back (stringMatchesV4, seqStringMatchesV6); with @SerializeAs(STRING_TYPE, collectionElementKind = CHAR_32_TYPE) a wide one (aWideStringIsMarkedWithSerializeAs: 06 00 00 00 E9 00 74 00 E9 00). (commit 819bfcb46cb) ### §8.5.1 Narrow characters: every Java character truncated to its least-significant byte

Spec: §8.5.1, p. 33 — “• If a string is to be of narrow characters (the default), each Java character shall be truncated to its least-significant byte.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/NarrowStrings.java (NarrowStrings.write), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/NarrowStrings.java (NarrowStrings.read)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::theTwoFormsAgreeOnTheCharactersBelowU0080, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::bothFormsOfANarrowStringAreWrittenByTheSameTypeSupport, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aNarrowStringIsTruncatedToItsLowOctetByDefault, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::theUtf8SettingWritesTheFormOfXTypes13

Status: done — The default is the form of the clause: every character truncated to its least-significant byte (aNarrowStringIsTruncatedToItsLowOctetByDefault: "AŁ" becomes 41 41, "été" becomes E9 74 E9); read back, one character per octet returns. The system property zerodds.java.narrow-string=utf8 selects the UTF-8 form of XTypes 1.3 (§7.2.2.2.1.2.4, §7.4.1.1.2; theUtf8SettingWritesTheFormOfXTypes13: "é" becomes C3 A9, as in the interoperability corpus); on reading a missing NUL and invalid UTF-8 are rejected. bothFormsOfANarrowStringAreWrittenByTheSameTypeSupport writes the same instance of ReflectionTypeSupport one after the other in both forms (E9 and C3 A9). Both forms are the same for characters up to U+007F. Peers that read the strings as UTF-8 (Cyclone DDS, Fast DDS, OpenDDS) need the setting utf8 as soon as a character above U+007F occurs; the same holds for the built-in types DDS::String and DDS::KeyedString. The setting holds per Java process. (commit b1e7b4d0338) ### §8.5.1 Wide characters with @SerializeAs, one DDS character per code point

Spec: §8.5.1, p. 33 — “• If a string is to be of wide characters (in which case it must be so marked with @SerializeAs), each Java code point shall become a single DDS wide character.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.encodeString), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.check), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/NarrowStrings.java (NarrowStrings.write), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/WideStrings.java (WideStrings)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aWideStringIsMarkedWithSerializeAs, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aNarrowStringIsTruncatedToItsLowOctetByDefault, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::char32IsAFourOctetCodePoint, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aCodePointAboveU10000OfAWideStringIsOneCharacter, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::theUtf16SettingWritesTheWstringOfXTypes13, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aWideStringRefusesWhatIsNoCodePoint

Status: done — A string with @SerializeAs(STRING_TYPE, collectionElementKind = CHAR_32_TYPE) is a string of 32-bit characters, one character per code point (WideStrings): the length in octets (4n), then n unsigned 32-bit values without a terminator (aWideStringIsMarkedWithSerializeAs: "été" is 0C 00 00 00 E9 00 00 00 74 00 00 00 E9 00 00 00). aCodePointAboveU10000OfAWideStringIsOneCharacter checks "a𝄞" (U+1D11E, two char): 08 00 00 00 61 00 00 00 1E D1 01 00; a code point above U+FFFF is one character, not a surrogate pair. A value that is no code point is rejected on reading. The system property zerodds.java.wide-string=utf16 selects the wstring of XTypes 1.3 §7.4.1.1.2, a sequence of UTF-16 units in which such a code point is two units (theUtf16SettingWritesTheWstringOfXTypes13: 06 00 00 00 61 00 34 D8 1E DD; interoperability corpus string-adjacent-widths); peers that read a wstring need this setting. Without the annotation the string is narrow (see the item before). (commit b1e7b4d0338) ### §8.5.2 Every java.util.Map as a DDS map, unless marked with @SerializeAs

Spec: §8.5.2, p. 33 — “Any object whose class implements the interface java.util.Map shall be considered a DDS map unless marked otherwise with @SerializeAs.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.decodeMap), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.check), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.decodeMap), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.map)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mapRoundtrips, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::enumerationsStructuresCollectionsAndMapsFollowTable81, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::nestedGenericsAreFollowed, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aMapIsReadIntoTheMapClassTheFieldDeclares, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aMapMarkedAsAMapKeepsItsBound, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aMapIsADheaderACountAndTheEntries

Status: done — A field whose declared type implements Map becomes a DDS map (ReflectionTypeSupport.encodeValue); JavaRepresentation.check allows only Map for MAP_TYPE and refuses every other kind on a Map with XcdrException. When reading, ReflectionTypeSupport.map (also for JavaRepresentation.decodeMap) builds the declared class: Map a LinkedHashMap, SortedMap/NavigableMap a TreeMap, ConcurrentMap a ConcurrentHashMap, EnumMap over the key class, a concrete class through its constructor. aMapIsReadIntoTheMapClassTheFieldDeclares checks seven field types, among them a field with @SerializeAs(MAP_TYPE); aMapMarkedAsAMapKeepsItsBound the bound. (commit f0649c27acc) ### §8.5.3 Every java.util.Collection as a DDS sequence

Spec: §8.5.3, p. 33 — “Any object whose class implements the interface java.util.Collection shall be considered DDS sequences unless marked otherwise with @SerializeAs.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.decodeValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.collection), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.typeOfClass)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theKindsOfTable81RoundTrip, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::aSequenceIsWrittenForEveryCollection, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::enumerationsStructuresCollectionsAndMapsFollowTable81, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aSequenceIsReadIntoTheCollectionTheFieldDeclares, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::emptyCollectionsAreReadIntoTheirClassesToo

Status: done — Every Collection becomes a sequence (encodeValue, branch Collection.class.isAssignableFrom); when reading, ReflectionTypeSupport.collection builds the declared class (see the item on Table 8.1 Collection): ArrayList, LinkedHashSet, TreeSet, ArrayDeque, EnumSet, or the concrete class. aSequenceIsReadIntoTheCollectionTheFieldDeclares checks one field each of Queue, Deque, SortedSet, NavigableSet, TreeSet, EnumSet, LinkedList, Collection, Set and List. createType returns SEQUENCE_TYPE for Collection<String>. (commit f0649c27acc) ### §8.5.3 For a List the order of the list

Spec: §8.5.3, p. 33 — “If the class implements java.util.List, the order of the elements in the sequence shall correspond exactly to the order of the elements in the list.”

Status: done — asList takes the elements of a List in their order and encodeSequence writes them so. seqPrimitiveMatchesV5 compares the bytes for [1,2,3], seqStringMatchesV6 for [“a”,“bc”]; both also check the list read back. (commit 819bfcb46cb) ### §8.5.3 Otherwise the order of the iterator

Spec: §8.5.3, p. 33 — “Otherwise, the order of the elements in the sequence shall correspond to that returned by the collection’s iterator.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.asList), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aSetIsWrittenInTheOrderOfItsIterator

Status: done — asList copies a Collection with new ArrayList<>(collection), i.e. in the order of its iterator. aSetIsWrittenInTheOrderOfItsIterator writes a LinkedHashSet (“b”, “a”) and a TreeSet with the same elements and compares all 46 octets: the first set writes b before a, the second a before b. (commit f0649c27acc) ### §8.5.3 Arrays as DDS sequences

Spec: §8.5.3, p. 33 — “Objects of array types shall be considered DDS sequences unless marked otherwise with @SerializeAs.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::arrayRoundtrips, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::enumerationsStructuresCollectionsAndMapsFollowTable81, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::anArrayOfPrimitivesIsASequenceWithoutAnElementDheader

Status: done — An array type goes through encodeSequence (length, elements) in encodeValue and comes back as an array through listToArray. arrayRoundtrips writes and reads an int[]; anArrayOfPrimitivesIsASequenceWithoutAnElementDheader checks the octets of {1, 2} (02 00 00 00 01 00 00 00 02 00 00 00); createType returns SEQUENCE_TYPE with FLOAT_64_TYPE as element for double[]. (commit 4aa407a112d) ### §8.5.3 Collection or array as a DDS array with @SerializeAs

Spec: §8.5.3, p. 33 — “Any Java collection or array may be designated as a DDS array with @SerializeAs.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.check), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.encodeCollection), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.decodeCollection), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.typeOfClass)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::anArrayHasNoLengthAndASequenceMayNameItsElementKind, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::anArrayOfSeveralDimensionsIsWrittenRowMajor, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::serializeAsChoosesTheKindOfTheMember, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aCollectionMarkedAsAnArrayHasAFixedLengthAndNoLengthWord

Status: done — @SerializeAs(ARRAY_TYPE, bound = ...) on a Java array is tested: int[3] and int[2][3] are written row by row without a length, a wrong number of elements is refused with XcdrException, createType returns ARRAY_TYPE with the bounds. On a Collection, aCollectionMarkedAsAnArrayHasAFixedLengthAndNoLengthWord checks a List<Integer> with bound = {3}: octets 01 00 00 00 02 00 00 00 03 00 00 00 without a length, a list of two or four elements is refused, an ArrayList is read. (commit 4aa407a112d) ### §8.5.3 Rationale: arrays are references

Spec: §8.5.3, p. 33 — “Design Rationale (non-normative) Objects of array types must receive special care, because a Java array—like any Java object—is stored by reference only. […]”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative.

§8.6 Aggregated Types

§8.6 Two kinds: structures and unions

Spec: §8.6, p. 34 — “[DDS-XTypes] recognizes two kinds of aggregated types: structures and unions.”

Repo: —

Tests: —

Status: n/a (informative) — Classification in the specification. ### §8.6 No-argument constructor for non-nested types, also non-public

Spec: §8.6, p. 34 — “Any DDS type that is not a nested type (in the sense of that word defined by [DDS-XTypes], as indicated in this Type Representation by the annotation @Nested) must define a no-argument constructor for use by the Service implementation. Service implementations shall have the capability to invoke this constructor reflectively, even if it is not public.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.instantiate), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.instantiateCanonical)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::pointMatchesV2, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::fieldsAndTheConstructorAreReachedWhateverTheirVisibility

Status: done — instantiate calls getDeclaredConstructor() with setAccessible(true). In pointMatchesV2, Point has a no-argument constructor that is visible only in its package and is read. If the constructor is missing, instantiateCanonical takes the canonical constructor (record Mixed in mixedIsByteIdenticalToTypedPath). @Nested is not evaluated in ReflectionTypeSupport. (commit 4aa407a112d) ### §8.6 Fields of the class in the order of getDeclaredFields

Spec: §8.6, p. 34 — “The fields in the DDS structured type shall correspond to those of the Java class. Their order shall be that returned by the method java.lang.reflect.Class.getDeclaredFields.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::pointMatchesV2, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theMembersOfTheBaseClassComeFirst

Status: done — fieldsOf returns the fields of each class in the order of getDeclaredFields(), those of the superclasses before the class’s own (item for §8.6.1.1). mixedIsByteIdenticalToTypedPath compares eight fields with the fixed order of the Writer, pointMatchesV2 two fields with the bytes of the reference vector. (commit 819bfcb46cb) ### §8.6 Static and transient fields omitted

Spec: §8.6, p. 34 — “Static and/or transient fields shall be omitted.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.fieldsOf)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::staticAndTransientFieldsCarryNoMember

Status: done — fieldsOf skips static, transient and synthetic fields. staticAndTransientFieldsCarryNoMember checks a class with a static, a transient and a normal field: the octets hold only the normal one (05 00 00 00), when reading the transient field keeps the value from the constructor, createType lists only the normal member. (commit f0649c27acc) ### §8.6 Read and set fields regardless of their access level

Spec: §8.6, p. 34 — “Service implementations shall have the capability to get and set the values of fields reflectively regardless of their declared access level (e.g., public, protected, private).”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.fieldsOf), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.get), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.instantiate)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::singleArgFactoryReflectsTypedBean, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::pointMatchesV2, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theKindsOfTable81RoundTrip, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::fieldsAndTheConstructorAreReachedWhateverTheirVisibility

Status: done — fieldsOf calls setAccessible(true) on each field; get and instantiate read and set through Field. singleArgFactoryReflectsTypedBean writes and reads a class with private fields over a topic, pointMatchesV2 one with fields without a modifier, theKindsOfTable81RoundTrip one with public fields, fieldsAndTheConstructorAreReachedWhateverTheirVisibility one with a private, a protected, a package and a public field. (commit 4aa407a112d) ### §8.6 Not required: a SecurityManager prevents access

Spec: §8.6, p. 34 — “Service implementations need not address the following cases: • A Java Security Manager (java.lang.SecurityManager) prevents privileged access to a non-public field or constructor.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.fieldsOf)

Tests: —

Status: n/a (informative) — Exception to the obligation. fieldsOf turns a SecurityException or InaccessibleObjectException raised on access into an XcdrException naming the field. ### §8.6 Not required: final fields

Spec: §8.6, p. 34 — “• A field that is neither static nor transient is declared final, preventing its value from being modified.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.instantiate)

Tests: —

Status: n/a (informative) — Exception to the obligation. instantiate sets fields through Field.set after setAccessible; for a record without a no-argument constructor it takes the canonical constructor (mixedIsByteIdenticalToTypedPath reads a record). ### §8.6 Not required: cycles of references

Spec: §8.6, p. 34 — “• Object references form a cycle. (Cycles are not permitted by the DDS Type System.)”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.reflect)

Tests: —

Status: n/a (informative) — Exception to the obligation. DynamicTypeFactoryImpl.reflect reports a class that contains itself through its fields as IllegalArgumentException; no test. An object graph with a cycle leads to unbounded recursion in encodeStruct (read from the code, not measured). ### §8.6.1 Every class that is neither a collection nor a map as a structure

Spec: §8.6.1, p. 34 — “Every Java class that is not a collection or map shall be considered a structure by default.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::nestedFinalInline

Status: done — A class that is not a primitive, String, enumeration, array, Collection or Map in encodeValue and decodeValue goes through infoOf and encodeStruct as a structure. nestedFinalInline writes and reads a Line of two nested Point values inline (16 bytes, no DHEADER). (commit 819bfcb46cb) ### §8.6.1.1 Class extension as structure inheritance

Spec: §8.6.1.1, p. 34 — “Java class extension shall map to structure inheritance in the DDS Type System [DDS-XTypes], subject to the restrictions documented by the java.io.Serializable interface, such as those pertaining to non-Serializable base types.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.fieldsOf), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.baseTypeNames), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.reflect)

Status: done — fieldsOf puts the fields of the superclasses before the own ones; theMembersOfTheBaseClassComeFirst reads and writes a derived class with the base fields first (12 bytes: the DHEADER of the EXTENSIBLE class, two int32). baseTypeNames returns the names of the superclasses, aLocalWriterDescribesTheBaseTypesOfItsType checks them in the built-in topic data. DynamicTypeFactoryImpl.reflect sets the superclass (below Object) as base type and lists only the own members (aDerivedClassIsAStructureWithTheSuperclassAsBaseType); theBytesOfADerivedDynamicTypeAreThoseOfTheClass compares the octets of DynamicData with those of the class. The restriction of java.io.Serializable holds: in a Serializable class the fields of a superclass that is not Serializable have no member and no base type (ReflectionTypeSupport.serializesFieldsOf); the superclass is initialized by its own constructor on reading. A class that is not Serializable keeps all fields. (commit 2de26533680) ### §8.6.1.2 FINAL when extending Object directly and final, or explicitly

Spec: §8.6.1.2, p. 34 — “• FINAL: If the class extends java.lang.Object directly and is final, or if explicitly indicated.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::extensibilityFollowsTheClassShape, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::pointMatchesV2, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::createTypeReflectsStructure, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::finalCanBeSaidOnAClassThatIsNotFinal

Status: done — defaultExtensibility returns FINAL for a final class that extends Object directly. extensibilityFollowsTheClassShape checks that and that a non-final or derived class is not FINAL; pointMatchesV2 checks the bytes without a DHEADER. Explicit @Extensibility(FINAL_EXTENSIBILITY) on a non-final class is mapped to FINAL by mapExtensibility; finalCanBeSaidOnAClassThatIsNotFinal checks getExtensibility(), the octets without a DHEADER (01 00 00 00 02 00 00 00) and the extensibility annotation in createType. (commit f0649c27acc) ### §8.6.1.2 EXTENSIBLE as the default in all other cases

Spec: §8.6.1.2, p. 34 — “• EXTENSIBLE: In all other cases, by default, or if explicitly indicated.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::extensibilityFollowsTheClassShape, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aClassThatIsNotFinalIsWrittenWithADheader, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::extensibleIsAppendable

Status: done — defaultExtensibility returns ExtensibilityKind.APPENDABLE for every class that is not final or does not extend Object directly (EXTENSIBLE of §8.6.1.2; XTypes 1.3 calls the kind APPENDABLE, XCDR2 writes it with a DHEADER). extensibilityFollowsTheClassShape checks OpenType and DerivedType; aClassThatIsNotFinalIsWrittenWithADheader the octets 08 00 00 00 01 00 00 00 02 00 00 00. (commit f0649c27acc) ### §8.6.1.2 EXTENSIBLE explicitly

Spec: §8.6.1.2, p. 34 — “• EXTENSIBLE: […] or if explicitly indicated.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.mapExtensibility), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeStruct)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::extensibleIsAppendable

Status: done — mapExtensibility maps EXTENSIBLE_EXTENSIBILITY to ExtensibilityKind.APPENDABLE. extensibleIsAppendable sets @Extensibility(EXTENSIBLE_EXTENSIBILITY), checks getExtensibility() and the bytes (DHEADER 8, two int) and reads them back. (commit f0649c27acc) ### §8.6.1.2 MUTABLE only explicitly

Spec: §8.6.1.2, p. 34 — “• MUTABLE: Only if explicitly indicated.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.defaultExtensibility), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.mapExtensibility), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeStruct)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mutableRoundtrips, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mutableLongRoundtrips, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::anAnnotationOverridesTheDefault, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::extensibilityFollowsTheClassShape

Status: done — defaultExtensibility never returns MUTABLE; mapExtensibility returns it for @Extensibility(MUTABLE_EXTENSIBILITY). anAnnotationOverridesTheDefault checks MUTABLE with the annotation, extensibilityFollowsTheClassShape that the default does not yield it; mutableRoundtrips and mutableLongRoundtrips write and read (DHEADER and an EMHEADER per member). (commit 819bfcb46cb) ### §8.6.2 Union through @SerializeAs

Spec: §8.6.2, p. 34 — “Any class may be annotated as a union with @SerializeAs.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.introspectUnion), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeUnion), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.decodeUnion), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.reflect)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aUnionIsItsDiscriminatorAndTheSelectedMember, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aMutableUnionCarriesItsDiscriminatorAsMemberZero, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aDiscriminatorThatSelectsNoMemberIsWrittenAlone, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::aUnionHasItsDiscriminatorTypeAndLabels

Status: done — A class with @SerializeAs(UNION_TYPE) becomes a union: the discriminator, then the selected member. aUnionIsItsDiscriminatorAndTheSelectedMember checks the bytes and the read, aMutableUnionCarriesItsDiscriminatorAsMemberZero the MUTABLE form, and aUnionHasItsDiscriminatorTypeAndLabels the UNION_TYPE description from createType. (commit 819bfcb46cb) ### §8.6.2 Exactly one field with @UnionDiscriminator

Spec: §8.6.2, p. 34 — “• Such a class must annotate exactly one field to be the discriminator with @UnionDiscriminator.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.introspectUnion)

Status: done — introspectUnion requires exactly one field with @UnionDiscriminator; with none or two it throws XcdrException. aMisplacedUnionAnnotationIsRefused checks the classes NoDiscriminator and TwoDiscriminators (and NotAUnion, UnmarkedMember, DuplicateLabel). (commit 819bfcb46cb) ### §8.6.2 The other fields with @UnionMember and the discriminator value

Spec: §8.6.2, p. 34 — “• All other fields that are not transient or static must be annotated with @UnionMember, which shall identify the discriminator value associated with that field.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aMisplacedUnionAnnotationIsRefused, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aUnionIsItsDiscriminatorAndTheSelectedMember, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aDiscriminatorThatSelectsNoMemberIsWrittenAlone

Status: done — introspectUnion requires @UnionMember(discriminatorValue = ...) on every field except the discriminator (static and transient fields are already excluded) and rejects duplicate values. aMisplacedUnionAnnotationIsRefused checks UnmarkedMember and DuplicateLabel; aUnionIsItsDiscriminatorAndTheSelectedMember selects the member by value, aDiscriminatorThatSelectsNoMemberIsWrittenAlone a value with no member. (commit 819bfcb46cb)

§8.7 Enumerations and Bit Sets

§8.7 Java `enum` as a DDS enumeration

Spec: §8.7, p. 35 — “By default, any Java enumeration class will be considered to be a DDS enumeration.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.decodeValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.enumConstant), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.enumeration)

Status: done — A Java enum is written as an enumeration (ordinal as int32) and read through enumConstant; a value outside the constants is an XcdrException. theKindsOfTable81RoundTrip writes and reads Colour.BLUE; createType yields ENUMERATION_TYPE with three members. No test checks the bytes of the enumeration. (commit 819bfcb46cb) ### §8.7 Enumeration annotatable as a bit set, its objects annotated as well

Spec: §8.7, p. 35 — “As in IDL, a type that is syntactically an enumeration may be annotated as a bit set type. In this case, objects of these types must also be annotated in order to be serialized correctly.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.ofField), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.bitBound)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::theDefaultBitBoundIs32AndABitSetFieldNamesItsEnumeration, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aMisplacedBitSetAnnotationIsRefused, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::anEnumSetMarkedBitSetIsAMaskWithTheBitBoundOfItsEnumeration

Status: done — An enumeration with @BitSet (and @BitBound, default 32) is a bit set type; ofField requires @BitSet on the member too and refuses a member of the bit set type without the annotation with XcdrException. theDefaultBitBoundIs32AndABitSetFieldNamesItsEnumeration writes a member Wide one (four octets, bit of constant C); aMisplacedBitSetAnnotationIsRefused checks UnannotatedBitSetMember. (commit 874bc5ac9fe) ### §8.7 EnumSet and java.util.BitSet with @BitSet as a bit set

Spec: §8.7, p. 35 — “A type member of type java.util.EnumSet or java.util.BitSet will be serialized as a bit set if marked with @BitSet.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::anEnumSetMarkedBitSetIsAMaskWithTheBitBoundOfItsEnumeration, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::theDefaultBitBoundIs32AndABitSetFieldNamesItsEnumeration, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aBitWithoutAConstantIsRefusedOnDecode, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aCollectionOfBitSetValuesIsASequenceOfBitSets

Status: done — A member of type EnumSet or java.util.BitSet with @BitSet is written as a bit set. anEnumSetMarkedBitSetIsAMaskWithTheBitBoundOfItsEnumeration checks one octet 0x05 for READ and EXEC, theDefaultBitBoundIs32AndABitSetFieldNamesItsEnumeration a java.util.BitSet with elementType (0x0a in four octets), aBitWithoutAConstantIsRefusedOnDecode bits without a constant. bits refuses more than 64 bits with XcdrException. (commit 874bc5ac9fe)

§8.8 Modules

§8.8 Segments of the package name as modules

Spec: §8.8, p. 35 — “Each segment of a Java type’s package name shall correspond to a module in the DDS Type System [DDS-XTypes]. For example, a class com.acme.project.TheClass would be in the nested modules com::acme::project.”

Status: done — introspect forms the type name from the class name with :: instead of . and $. thePackageOfAClassIsTheModulesOfTheTypeName checks com::acme::project::TypesTheClass for a class in the package com.acme.project (as a topic and on the TypeSupport) and org::zerodds::cdr::TypesJavaRepresentationTest::Skipped for a nested class; aLocalWriterDescribesTheBaseTypesOfItsType the name of a nested superclass in getBaseTypeName. String has the name DDS::String (item on DDS::String). (commit f0649c27acc)

§8.9 Annotations

§8.9 Java annotation types not mapped by default

Spec: §8.9, p. 35 — “This Type Representation ignores Java annotation types by default.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.annotation), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.introspect), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.reflect)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::onlyTheTypeSystemAnnotationsCount, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::anAnnotationTypeIsRepresentedOnlyWhenMarked, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::annotationsOfAnotherPackageWithTheNamesOfTheTypeSystemAreIgnored, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::anIdAndAMustUnderstandOfAnotherPackageDoNotReachTheEmheader, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::anOptionalOfAnotherPackageDoesNotMakeAMemberOptional

Status: done — annotation recognizes only annotations from org.omg.dds.type (and org.zerodds.types); foreign annotations with the same simple name do not count. onlyTheTypeSystemAnnotationsCount uses ForeignKey and ForeignId; the new tests use annotations Key, ID, Optional, MustUnderstand and Extensibility from the package org.zerodds.cdr.foreign, with the same simple names: a foreign Key does not make the type keyed, a foreign Extensibility("MUTABLE") does not make the class MUTABLE, a foreign ID(77) does not change the member id, a foreign MustUnderstand does not set the M flag, a foreign Optional does not make a member optional. anAnnotationTypeIsRepresentedOnlyWhenMarked checks that createType refuses an unmarked annotation type. (commit f0649c27acc) ### §8.9 Annotations in the type system only with @SerializeAs

Spec: §8.9, p. 35 — “Java annotations that are intended to be represented explicitly within the DDS Type System must be so annotated with @SerializeAs.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.reflectAnnotationType)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::anAnnotationTypeIsRepresentedOnlyWhenMarked

Status: done — reflectAnnotationType maps an annotation type only with @SerializeAs(ANNOTATION_TYPE), with one member per element and its default value. The test checks ANNOTATION_TYPE, the member kinds STRING_TYPE and INT_32_TYPE, the default “none” and the rejection of the unmarked type. (commit 36094b9d871)

§9.1 Type Mapping

§9.1 Type system by [DDS-XTypes], other aspects by its Plain Language Binding

Spec: §9.1, p. 37 — “The type system for DDS topic types is defined by the Extensible and Dynamic Topic Types for DDS specification [DDS-XTypes]. This sub clause defines the set of rules to be used in order to map abstract DDS topic types into Java types that can be used by application programmers. Those aspects of the DDS Type System that are not addressed below are as specified in the Plain Language Binding as defined by [DDS- XTypes] (which in turn is defined in terms of an IDL-to-Java mapping [Java-MAP]).”

Repo: crates/lang-rules/src/adapter/java.rs (JavaMapping)

Tests: —

Status: n/a (informative) — Names the sources of the rules. The Java generator has two mappings: --java-mapping psm (default, Clause 9) and --java-mapping omg (IDL to Java, public fields); see the items for §9.1.1 and §9.1.2. (commit 5e078003c16) ### §9.1.1 Aggregation types as a final Java class

Spec: §9.1.1, p. 37 — “DDS aggregation types shall be mapped to a final Java class.”

Repo: crates/lang-rules/src/adapter/java.rs (data_class), crates/lang-rules/src/adapter/java.rs (encapsulate)

Tests: crates/lang-rules/tests/java_psm_mapping.rs::an_aggregate_is_a_final_class_with_private_state_and_bean_accessors, crates/lang-rules/tests/java_psm_mapping.rs::the_psm_types_and_codec_compile_without_a_warning

Status: done — Both mappings generate public static final class per structure. Under JavaMapping::Psm the test checks public static final class Point { and Track { in the generated text; the_psm_types_and_codec_compile_without_a_warning compiles the output with javac. The default of idlc generate --lang java is psm, Clause 9 (the_java_mapping_defaults_to_psm_and_omg_is_selectable); --java-mapping omg selects IDL to Java. (commit 5e078003c16) ### §9.1.1 Attributes encapsulated

Spec: §9.1.1, p. 37 — “Contained attributes shall be encapsulated.”

Repo: crates/lang-rules/src/adapter/java.rs (encapsulate), crates/lang-rules/src/adapter/java.rs (field)

Status: done — Under JavaMapping::Psm every member is a private field with accessors. The first test checks private int x; and that public int x; is absent; the second that the codec accesses through getX()/setX(...) and no direct field access remains. Under omg (--java-mapping omg) the fields stay public. (commit 5e078003c16) ### §9.1.1 Java Bean accessors

Spec: §9.1.1, p. 37 — “Java Bean style accessors shall be provided.”

Repo: crates/lang-rules/src/adapter/java.rs (encapsulate), crates/lang-rules/src/adapter/java.rs (getter_name), crates/lang-rules/src/adapter/java.rs (setter_name), crates/lang-rules/src/adapter/java.rs (boolean_getter_name)

Status: done — Under JavaMapping::Psm the generator writes getX() and setX(int v), for boolean also isOn(), and for a union getDiscriminator()/setDiscriminator. The tests check the generated text; the_psm_types_and_codec_compile_without_a_warning compiles it. Under omg there are no accessors. (commit 5e078003c16) ### §9.1.1 Special rules for boolean properties permitted

Spec: §9.1.1, p. 37 — “Special mapping rules for boolean properties are allowed.”

Repo: crates/lang-rules/src/adapter/java.rs (boolean_getter_name)

Tests: crates/lang-rules/tests/java_psm_mapping.rs::an_aggregate_is_a_final_class_with_private_state_and_bean_accessors

Status: n/a (informative) — A permission. The generator uses it: isOn() and getOn() for a boolean member, checked in the test for §9.1.1. (commit 5e078003c16) ### §9.1.1 Internal state private

Spec: §9.1.1, p. 37 — “The representation of internal state shall be private.”

Repo: crates/lang-rules/src/adapter/java.rs (encapsulate), crates/lang-rules/src/adapter/java.rs (field)

Status: done — Under JavaMapping::Psm the fields and the discriminator of a union are private (private int x;, private int _d;); the tests check the text, and that public int x; is absent. (commit 5e078003c16) ### §9.1.2 Unbounded sequences as Collection<E>, encapsulated, with Java Bean accessors

Spec: §9.1.2, p. 37 — “Unbounded DDS sequences are mapped to Collection interface. The state is encapsulated and getters/setters are provided through bean style property accessors.”

Repo: crates/lang-rules/src/adapter/java.rs (type_at), crates/lang-rules/src/adapter/java.rs (encapsulate)

Tests: crates/lang-rules/tests/java_psm_mapping.rs::an_unbounded_sequence_is_a_collection_and_a_bounded_one_an_array, crates/lang-rules/tests/java_psm_mapping.rs::the_codec_reads_and_writes_through_the_accessors

Status: done — Under JavaMapping::Psm sequence<long> becomes a private java.util.Collection<java.lang.Integer> with getSamples() and setSamples(...); nested sequences are Collection<Collection<String>>. The test checks the text, the second test the codec through Sequences; omg (--java-mapping omg) still maps to T[]. (commit 5e078003c16) ### §9.1.2 Bounded sequences as Java arrays

Spec: §9.1.2, p. 37 — “Bounded sequences and arrays are mapped to Java arrays.”

Repo: crates/lang-rules/src/adapter/java.rs (type_at)

Status: done — Under JavaMapping::Psm sequence<long, 4> stays private int[] bounded;; type_at chooses Collection only for Bound::Unbounded. The test checks the text, the codec trims with Sequences.first(v, 4). (commit 5e078003c16) ### §9.1.2 Arrays as Java arrays

Spec: §9.1.2, p. 37 — “Bounded sequences and arrays are mapped to Java arrays.”

Repo: crates/lang-rules/src/adapter/java.rs (type_at)

Tests: crates/lang-rules/src/adapter/java.rs::tests::a_sequence_and_an_array_are_both_java_arrays, crates/lang-rules/tests/java_psm_mapping.rs::an_unbounded_sequence_is_a_collection_and_a_bounded_one_an_array

Status: done — type_at, branch TypeKind::Array: long a[3] becomes int[], long g[2][3] becomes int[][]. a_sequence_and_an_array_are_both_java_arrays checks that under omg; under psm the second test checks private ZdTypes.demo.Point[] vicinity; and an array of sequences as Collection<Integer>[]. (commit 5e078003c16)

§9.2 Example

§9.2 Example `Point` and `RadarTrack`

Spec: §9.2, p. 38–39 — “Example (non-normative) […] public final class Point { Point(); Point(int x, int y, java.lang.Integer z); int getX(); void setX(int32 v); […] }; public class final RadarTrack { […] java.util.Collection getPlot(); […] };”

Repo: —

Tests: —

Status: n/a (informative) — Example. It is not compilable Java (int32, public class final, Collection<byte>, };). idlc generate --lang java --java-mapping psm generates final classes with private fields, Bean accessors and Collection<E> for unbounded sequences. (commit 5e078003c16)

Annex A Java JAR Library File

Annex A JAR `omgdds.jar` with all classes of the PSM

Spec: Annex A, p. 41 — “In addition to this document, this specification includes a Java Archive (JAR) library, omgdds.jar. This library contains compiled Java *.class files for all of the classes and interfaces specified by this PSM.”

Repo: —

Tests: —

Status: n/a (informative) — Describes the artefact of the OMG. crates/java-omgdds/java/pom.xml builds the JAR org.zerodds:omgdds with the classes under org/omg/dds, whose sources equal the OMG sources except for 11 of 184 files (see the Annex A and B items). ### Annex A Compile against omgdds.jar, run against any implementation

Spec: Annex A, p. 41 — “This library comprises the compile-time portion of this specification: users shall be able to compile their PSM-compliant code against this library and then deploy the result against any conformant implementation.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::singleArgFactoryReflectsTypedBean, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesPsmApiTest.java::ddsExceptionIsADdsObjectAsInTheOmgSource, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesPsmApiTest.java::noClassOfTheApiPackageRefersToTheImplementation, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesPsmApiTest.java::theExceptionsAreAbstractAndHaveTheSerialVersionUidOfTheOmgSource

Status: done — org/omg/dds/core/DDSException.java implements DDSObject like the OMG source; the seven exception classes in org.zerodds.core answer getEnvironment() (the default environment of the implementation). A comparison of the files under org/omg/dds with .agent/omg-java/srcJava gives files equal byte by byte except EntityQos (additional @SuppressWarnings and a comment) and three files with other line endings (DomainParticipantFactory, DataWriter, DataReader). TypesPsmApiTest checks DDSObject on DDSException, the serialVersionUID values and abstract classes of the ten exceptions and that no class in org.omg.dds (without rpc) refers to org/zerodds, so it can run against another implementation. The tests of the module are themselves clients of the classes of org.omg.dds. (commit 63098240e0c) ### Annex A omgdds next to the implementation or in one library

Spec: Annex A, p. 41 — “Distributors of binary implementations of this PSM may elect to distribute the omgdds library alongside their implementation libraries or to package both the contents of omgdds.jar and their implementation into a single library.”

Repo: crates/java-omgdds/java/pom.xml

Tests: —

Status: n/a (informative) — A permission for the distributor. ZeroDDS packs the classes of org/omg/dds and the implementation in one JAR (org.zerodds:omgdds, crates/java-omgdds/java/pom.xml). (commit 5536e2abcac)

Annex B Java Source Code

Annex B Sources in `omgdds_src.zip`, normative for interfaces and comments

Spec: Annex B, p. 43 — “In addition to this document, this specification includes the Java source code to all of the classes and interfaces specified by this PSM in the zip archive omgdds_src.zip. This source code, in the directory srcJava within the archive, corresponds to the binary distribution found in the library omgdds.jar and is also normative with respect to both its programming interfaces and its embedded documentation comments.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesPsmApiTest.java::theExceptionsAreAbstractAndHaveTheSerialVersionUidOfTheOmgSource, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesPsmApiTest.java::ddsExceptionIsADdsObjectAsInTheOmgSource, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreApiShapeTest.java::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource

Status: done — The ten exception classes under org/omg/dds/core are the files of the OMG sources (comments, serialVersionUID, DDSException implements DDSObject). All 184 files under org/omg/dds equal the source character by character (line ends read as LF), comments included: type/TypeSupport.java and core/EntityQos.java are the files of the source (the mapping of the name java.lang.Class to the name of the class is in ServiceEnvironmentImpl.newTypeSupport; the warning “possible heap pollution” on EntityQos.withPolicies(P...) is switched off by the compile options of the module: -Xlint:all,-unchecked,-options -Werror for the main sources in pom.xml). CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource compares the files on every run with the SHA-256 of the source (src/test/resources/omgdds-srcjava.sha256, from omgdds_src.zip) and demands that none differs. TypesPsmApiTest checks the serialVersionUID values and that ServiceConfigurationException and ServiceInitializationException are plain RuntimeExceptions in the source. (commit 53910e766ac) ### Annex B Examples, build.xml and project files non-normative

Spec: Annex B, p. 43 — “For the convenience of both implementers and application developers, the archive contains additional files that are neither API source code nor documentation. These file are non-normative and include: […]”

Repo: —

Tests: —

Status: n/a (informative) — Non-normative.

Audit-Status

447 done / 0 partial / 0 open / 0 blocked / 79 n/a (informative).

Open items: none.

DDS-Java 1.0 (Java 5 Language PSM for DDS) — Spec-Coverage

Quelle: internal/standards/cache/omg/dds-java-psm-1.0.pdf (44 Seiten, OMG formal/2013-11-02, November 2013) — OMG DDS-Java 1.0

Audit Item für Item gegen die PDF nach internal/spec-coverage/PROCESS.md. Seitenangaben ohne weiteren Zusatz sind PDF-Seiten dieser PDF (PDF-Seite = gedruckte Seite + 10; die Titelseite ist PDF-Seite 1, das Vorwort gedruckt iii und iv auf PDF-Seite 9 und 10). Jeder normative Satz von §1 bis §9 und der Annexe, jede Zeile von Table 7.1, Table 7.2, Table 8.1 und Table 8.2, jede Factory-Methode, die §7.3.1 dem ServiceEnvironment gibt, und jede Vorgabe des DataReader.Selector ist ein eigenes Item. §2 verlangt alle Programmierschnittstellen der Konformitätsstufen von [DDS]; [DDS] ist nach §3 die Version 1.2 (internal/standards/cache/omg/dds-1.2.pdf, PDF-Seite = gedruckte Seite + 12). Die Operationen der Klassen von DCPS ([DDS] 1.2 §7.1.2, S. 25–107) und die eingebauten Topics (§7.1.5, S. 147–150) sind deshalb je ein Item unter §2; §7.3.7.1 verlangt je Status von [DDS] eine Klasse ([DDS] 1.2 §7.1.4.1, S. 132–133, IDL S. 159–161) und §7.3.5.1 je Policy eine Schnittstelle ([DDS] 1.2 §7.1.3, S. 108–120), je Klasse ein Item; §7.3.5.2 je Entity-QoS eine Schnittstelle ([DDS] 1.2 IDL, S. 167–169), je QoS ein Item. Operationen, die sich nur durch _w_timestamp unterscheiden, und Paare aus set_ und get_ sind ein Item. done steht nur, wo Code und Test die Anforderung abdecken; ein zitierter Test in Java nennt Datei und Testmethode als datei::methode, ein Test in Rust die Testfunktion als datei::modul::name. Eine Fundstelle im Repo nennt Datei und Symbol, keine Zeilennummer. Eine Anforderung an einen Namen, ein Paket oder eine Signatur gilt als durch einen Test abgedeckt, wenn der Test gegen genau diesen Namen übersetzt wird; eine Eigenschaft, die beim Übersetzen nicht auffällt (abstract, final, eine Elternklasse), braucht einen Test, der sie prüft. Jede Aussage über Verhalten ist aus dem Code und den Tests gelesen. Die Tests, die der zweite Durchgang geschrieben hat, wurden auf dem Mac nur übersetzt; sie laufen auf dem Linux-Testhost. Wo Code eine Anforderung abbildet, aber kein Test sie prüft, ist das Item open und die Notiz nennt die Codestelle.

Kontext: DDS-Java 1.0 ist in ZeroDDS über diese Teile verteilt:

crates/java-omgdds/java/ — das Maven-Modul org.zerodds:omgdds (crates/java-omgdds/java/pom.xml, Java 17, Profil java8 für Java 8) mit den Klassen unter org.omg.dds.core, org.omg.dds.core.policy, org.omg.dds.core.status, org.omg.dds.domain, org.omg.dds.topic, org.omg.dds.pub und org.omg.dds.sub, der Implementierung unter org.zerodds.* und den JUnit-5-Tests unter src/test/java. Die Bindung ist ein eigener Stack in Java. Sie ruft das C-API (crates/zerodds-c-api) nicht auf und lädt keine native Bibliothek (kein JNI, keine FFM; grep -rn "loadLibrary\|java.lang.foreign" crates/java-omgdds/java/src findet nichts). Samples gehen im selben Prozess über org.zerodds.internal.InProcessBus an die Reader; mit -Dzerodds.rtps.enable=true oder ZERODDS_RTPS=1 zusätzlich über den RTPS-Stack in Java unter org.zerodds.rtps (DdsWireBridge.enabled).
crates/idl-java/runtime/ — die Annotationen org.zerodds.types.Key, Id, Optional, MustUnderstand, External, Nested, Shared, Extensibility und die Schnittstelle org.omg.dds.topic.TopicType; das POM übersetzt sie über build-helper-maven-plugin in dieselbe JAR.
runtime/java/ — der Codec org.zerodds.wire.Writer/Reader, den org.zerodds.cdr.ReflectionTypeSupport und die erzeugten Typen benutzen; das POM übersetzt ihn ebenfalls in die JAR.
Der Java-Codegen: zerodds-idlc generate --lang java (tools/idlc/src/generate.rs, tools/idlc/src/java_support.rs) über crates/lang-rules (adapter/java.rs, emit/java.rs). Er erzeugt die Topic-Typen in einer Klasse ZdTypes und je Typ eine ZdTypeSupports.Support_<tag>, die org.zerodds.cdr.TopicTypeSupport<T> implementiert.

Die Abbildung von IDL auf Java nach IDL4 to Java steht in idl4-java-1.0.md, die Architektur des Moduls in zerodds-java-omgdds-1.0.md, der XCDR2-Vertrag org.zerodds.cdr.TopicTypeSupport in zerodds-xcdr2-java-1.0.md, die Endpoint-API in zerodds-endpoint-java-1.0.md. Hier stehen die DDS-API in Java nach DDS-Java 1.0 und die Regeln, die DDS-Java selbst an die Typen stellt (§8, §9). org.omg.dds.rpc unter runtime/java/ gehört zu DDS-RPC 1.0 und ist nicht Gegenstand dieses Dokuments; ebenso der RTPS-Stack unter org.zerodds.rtps.

Nach §2 sind die PDF, die JAR omgdds.jar und die Quelldateien der OMG normativ, bei einem Widerspruch gelten JAR und Quellen. Das Archiv (Titelseite, Annex B) liegt im Cache (internal/standards/cache/omg/dds-java-psm-1.0-omgdds_src.zip); alle Dateien unter org/omg/dds des Moduls außer EntityQos.java (zusätzliches @SuppressWarnings) stimmen mit den Quellen überein; CoreApiShapeTest prüft das bei jedem Lauf gegen die SHA-256 der Quelldateien (src/test/resources/omgdds-srcjava.sha256).

Offene Punkte: keine.

§1 Scope

§1 PSM nur für DCPS, ohne DLRL

Spec: §1, S. 11 — “This specification defines a platform-specific model (PSM) for the OMG Data Distribution Service for Real-Time Systems (DDS). It specifies an API only for the Data-Centric Publish-Subscribe (DCPS) portion of that specification; it does not address the Data Local Reconstruction Layer (DLRL).”

Repo: —

Tests: —

Status: n/a (informative) — Umfang der Spec, keine erfüllbare Anforderung. Unter crates/java-omgdds/java/src/main/java/org/omg/dds liegen die Pakete core, domain, pub, sub, topic und type; ein Paket dlrl gibt es nicht. DLRL gehört zu DLRL 1.2 (tools/idlc/src/dlrl.rs). ### §1 Umfang: die APIs von [DDS-XTypes]

Spec: §1, S. 11 — “In addition, it encompasses (a) the DDS APIs introduced by [DDS-XTypes] […]”

Repo: —

Tests: —

Status: n/a (informative) — Verweis auf §2 (Stufe Extensible and Dynamic Types) und §7.8. Die Pakete org.omg.dds.type, org.omg.dds.type.dynamic, org.omg.dds.type.typeobject und org.omg.dds.type.builtin sind im Code vorhanden; die Anforderungen stehen im Item „§2 Stufe Extensible and Dynamic Types“. ### §1 Umfang: eine API für QoS-Bibliotheken und -Profile nach [DDS-CCM]

Spec: §1, S. 11 — “[…] and (b) an API to specifying QoS libraries and profiles such as were specified by [DDS-CCM].”

Repo: —

Tests: —

Status: n/a (informative) — Verweis auf §2 und §7.3.5.4. Die API ist org.omg.dds.core.QosProvider, die Implementierung org.zerodds.core.qos.QosProviderImpl; die Anforderungen stehen im Item „§2 XML-QoS-Profile“. ### §1 Java Type Representation ohne Beschreibung in einer anderen Sprache

Spec: §1, S. 11 — “This specification also defines a means of publishing and subscribing Java objects with DDS-the Java Type Representation-without first describing the types of those objects in another language, such as XML or OMG IDL.”

Repo: —

Tests: —

Status: n/a (informative) — Verweis auf §8. Umgesetzt durch org.zerodds.cdr.ReflectionTypeSupport und TypeSupportResolver.resolve (Klasse ohne generierten Code wird per Reflexion abgebildet); die Prüfung steht im Item „§2 Mindestens eine Type Representation“.

§2 Conformance

§2 PDF, JAR und Quelldateien normativ, bei Widerspruch JAR und Quellen

Spec: §2, S. 11; Titelseite, S. 1 — “This specification consists of this document as well as a Java jar library file and the source files that generated it, identified on the cover page (all are normative). In the event of a conflict between them, the latter shall prevail.”

Status: done — DDSException implementiert DDSObject (org/omg/dds/core/DDSException.java), wie die OMG-Quelle; die sieben Ausnahmeklassen in org.zerodds.core liefern mit getEnvironment die Standardumgebung. Die serialVersionUID von sechs Ausnahmeklassen ist die der OMG-Quelle. ParticipantOmgApiTest prüft DDSObject und die serialVersionUID. CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource vergleicht jede Datei von org/omg/dds mit dem SHA-256 der OMG-Quelle (Zeilenenden als LF), ohne Abweichung; auch EntityQos.java ist die Datei der OMG-Quelle. (Commit 7f102b80f83) ### §2 Konformität parallel zu den Stufen von [DDS]

Spec: §2, S. 11; [DDS] 1.2 §2, S. 14–15 (dds-1.2.pdf) — “Conformance to this specification parallels conformance to the DDS specification itself and consists of the same conformance levels. For example, an implementation may conform to the DDS Minimum Profile with respect to this PSM, meaning that all of the programming interfaces identified by the DDS specification as pertaining to that conformance level must be implemented in this PSM.”

Status: done — Die Konformitätsstufen von Klausel 2 sind in crates/java-omgdds/README.md genannt: Minimum, Content-Subscription, Persistence und Ownership Profile sowie Extensible and Dynamic Types, ohne das Object Model Profile (DLRL); ConformanceClaimTest prüft die Aussage. Die Schnittstellen dieser Stufen sind in den Items dieses Dokuments einzeln belegt: Entity (set_qos mit IMMUTABLE_POLICY und INCONSISTENT_POLICY, Listener-Weitergabe, StatusCondition), DomainParticipant (ignore_*, closeContainedEntities), die Zuweisbarkeit der Typen, die Coherent Sets, die Lebendigkeit und die Wartefunktionen auch gegenüber Peers in anderen Prozessen. Was in einzelnen Operationen offen ist, steht als eigenes offenes Item. (Commit 2de26533680) ### §2 Object Model Profile (DLRL) ausgenommen

Spec: §2, S. 11 — “The one exception to this rule is the Object Model Profile, which includes in part the Data Local Reconstruction Layer (DLRL); DLRL is outside of the scope of this PSM.”

Repo: —

Tests: —

Status: n/a (informative) — Abgrenzung durch die Spec. Das Object Model Profile umfasst DLRL (im Code nicht vorhanden) und access_scope = GROUP von PRESENTATION; die Policy PRESENTATION gibt es als org.omg.dds.core.policy.Presentation, ihre Wirkung wurde hier nicht geprüft. ### §2 Stufe Extensible and Dynamic Types

Spec: §2, S. 11 — “In addition to the conformance levels defined in the DDS specification itself, this PSM recognizes and implements the Extensible and Dynamic Types conformance level for DDS defined by the Extensible and Dynamic Topic Types for DDS specification [DDS-XTypes].”

Status: done — Die Typkonsistenz wirkt beim Abgleich von Reader und Writer. EXACT_TYPE_TYPE_CONSISTENCY und EXACT_NAME_TYPE_CONSISTENCY verlangen denselben Typnamen (InProcessBus führt je Domäne, Topicname und Typname einen Kanal). Ein Reader mit ASSIGNABLE_TYPE_CONSISTENCY nimmt Writer eines anderen Typnamens am selben Topic, wenn TypeAssignability.assignableFrom (die Regeln von XTypes 1.3 §7.2.4.4: Alias aufgelöst, gleiche Primitive, Zeichenbreite bei Strings, Array-Grenzen gleich, Elemente „stark zuweisbar“, Enumerationen mit gleichen Namen und Werten, Strukturen nach Member-IDs und -Namen, Key-, Optional- und Must-Understand-Regeln, bei APPENDABLE und FINAL die Member an gleicher Stelle) den Typ des Writers als zuweisbar ausweist; mit DECLARED_TYPE_CONSISTENCY nimmt er nur Writer, deren Typ den seinen als Basistyp nennt (TypeAssignability.declared). Im selben Prozess gibt InProcessBus die Samples über Verbindungen (Link) weiter. Über RTPS entscheidet der Reader aus dem TypeObject (PID 0x0072), das der Writer ankündigt (TypeObjectToDynamic); der Writer nimmt einen Reader anderen Typnamens, der in SEDP ALLOW_TYPE_COERCION ankündigt (ASSIGNABLE und DECLARED werden so geschrieben, EXACT als DISALLOW) und dessen TypeObject von seinem Typ aus zuweisbar ist. Ohne angekündigtes TypeObject lässt sich ein Peer nicht beurteilen und wird nicht verbunden. @ignore_literal_names und die Regeln der Union-Etiketten je Etikett gehören zu XTypes 1.3 §7.2.4.4 und sind nicht ausgewertet. (Commit 178c642cbc7) ### §2 XML-QoS-Profile: Operationen vollständig oder UnsupportedOperationException

Spec: §2, S. 11 — “This PSM furthermore defines methods to create Entities and to set their QoS based on the XML QoS libraries and profiles defined by the DDS for Lightweight CCM specification. Implementations that support these XML QoS profiles shall implement these operations fully; other implementations shall throw java.lang.UnsupportedOperationException.”

Status: done — QosProviderImpl liest DDS-XML-1.0-Bibliotheken (dds-xml_qos_definitions.xsd) von file://-URIs: <qos_library>, <qos_profile name base_name>, sieben Entity-QoS-Elemente, die 22 Policy-Elemente der Schema-Datei mit deren Literalen (RELIABLE_RELIABILITY_QOS), Dauer als <sec>/<nanosec> mit DURATION_INFINITY, LENGTH_UNLIMITED, base64 für Octet-Folgen, Partition als <name><element>. Vererbung über base_name auf Profil- und auf Element-Ebene, Zyklus, später definierte Basis und fehlende Basis sind IllegalArgumentException. Jedes andere URI-Schema löst UnsupportedOperationException aus. Unbekannte Elemente, Felder, Literale und fehlerhafte Werte sind IllegalArgumentException, nichts wird ohne Meldung übergangen. Entity.setQos(String, String) ruft den Provider über EntityBase.setQos mit dem ersten Argument als URI. Der frühere Leser erwartete ein Wurzelelement je Entity-Element und Java-Enum-Namen und las damit kein DDS-XML-Dokument. Getestet in QosProviderTest (alle Entity-Arten, Vererbung, Fehlerfälle, anderes Schema, setQos(uri, profile) an allen sechs Entitäten). (Commit a68b0889e7a) ### §2 Mindestens eine Type Representation von [DDS-XTypes] oder §8

Spec: §2, S. 11 — “Finally, any conformant implementation must support at least one of the OMG-specified Type Representations defined by [DDS-XTypes] and/or in the Java Type Representation section of this specification (Clause 8).”

Status: done — Die Java Type Representation ist umgesetzt: TypeSupportResolver.resolve bildet eine Klasse ohne generierten Code über ReflectionTypeSupport ab. pointMatchesV2 vergleicht die kodierten Bytes einer Bean mit dem Wire-Vektor (01 00 00 00 FE FF FF FF) und dekodiert zurück; theKindsOfTable81RoundTrip prüft BigInteger, BigDecimal, Enum, Set und List im Rundlauf; singleArgFactoryReflectsTypedBean schreibt und liest eine Bean über Topic, Writer und Reader. Die IDL Type Representation kommt über tools/idlc/src/java_support.rs in die erzeugten Typen. (Commit 819bfcb46cb)

§2 Programmierschnittstellen von [DDS] 1.2: Entity

§2 Entity: set_qos und get_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.1, S. 25–26 (dds-1.2.pdf), Tabelle Entity — “abstract set_qos (qos_list: QosPolicy []): ReturnCode_t; abstract get_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Status: done — getQos ist an allen sechs Entitäten vorhanden. setQos prüft über org.zerodds.core.qos.QosRules.checkChange zuerst die Verträglichkeit der Policies (InconsistentPolicyException, auch wenn zugleich eine unveränderliche Policy geändert wird) und nach enable die Policies, deren Spalte „Changeable“ in DDS 1.4 §2.2.3 „No“ ist (DURABILITY, DURABILITY_SERVICE, PRESENTATION, OWNERSHIP, LIVELINESS, RELIABILITY, DESTINATION_ORDER, HISTORY, RESOURCE_LIMITS, DATA_REPRESENTATION, TYPE_CONSISTENCY_ENFORCEMENT; ImmutablePolicyException); ein gleicher Wert ist keine Änderung; bei beiden Ausnahmen bleibt die QoS unverändert. Das gilt für DataWriter, DataReader, Topic, Publisher, Subscriber, DomainParticipant und DomainParticipantFactory. Nach einer Änderung von DEADLINE oder LIVELINESS laufen die Fristen neu an; eine geänderte PARTITION lässt Writer und Reader neu matchen. Die geänderte QoS eines Writers, Readers, Publishers, Subscribers, Topics oder Participants ist ein neues Sample derselben Instanz in „DCPSPublication“, „DCPSSubscription“, „DCPSTopic“ und „DCPSParticipant“, und Writer und Reader, die über RTPS verbunden sind, kündigen sie erneut in SEDP an (WireWriter.updateQos, WireReader.updateQos); der Peer gleicht danach neu ab. Die SEDP-Writer halten je Endpunkt und Peer nur die letzte Ankündigung (KEEP_LAST 1), sodass erneute Ankündigungen die Historie nicht füllen. (Commit 447490d2b6d) ### §2 Entity: set_listener und get_listener

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.1, S. 26 (dds-1.2.pdf), Tabelle Entity — “abstract set_listener (a_listener: Listener, mask: StatusKind []): ReturnCode_t; abstract get_listener: Listener”

Status: done — Die Listener von DomainParticipant, Publisher, Subscriber und Topic werden aufgerufen. Ein Status geht an den Listener der Entität, wenn dieser den Status in seiner Maske hat (null = alle, leer = keine), sonst an den der enthaltenden Entität: DataWriter an Publisher und DomainParticipant, DataReader an Subscriber und DomainParticipant, Topic an DomainParticipant (ListenerUp, EntityBase.ownListener, DataWriterImpl.listenerFor, TopicImpl.listenerFor). Tests: Weitergabe vom Writer zu Publisher und Participant (ListenerPropagationTest), Statusmaske eines Writer-Listeners und leere und null-Maske (ParticipantSubscriberTest), INCONSISTENT_TOPIC an Topic- und Participant-Listener (TopicOperationsTest), OFFERED_INCOMPATIBLE_QOS an Publisher- und Participant-Listener (PublisherOperationsTest). (Commit f31b6fa11b5) ### §2 Entity: Statusmaske und Listener beim Erzeugen

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.1, S. 26, §7.1.2.2.1, S. 34–35 (dds-1.2.pdf) — “set_listener (a_listener: Listener, mask: StatusKind [])”; “create_publisher (qos_list: QosPolicy [], a_listener: PublisherListener, mask: StatusKind []): Publisher”

Status: done — Die create*-Operationen mit Listener und Statusmenge setzen den Listener vor enable: DomainParticipantImpl.newPublisher, newSubscriber und newTopic, PublisherImpl.createDataWriter, SubscriberImpl.createDataReader; DomainParticipantFactoryImpl.createParticipant setzt ihn vor dem Eintragen des Participants. Ein SUBSCRIPTION_MATCHED oder PUBLICATION_MATCHED einer vorhandenen Gegenstelle erreicht damit den beim Erzeugen gesetzten Listener. Tests: Writer und Reader mit Listener bei vorhandener Gegenstelle (ListenerPropagationTest), Publisher und Subscriber mit Listener und später erzeugtem Writer oder Reader, Participant mit Listener und Maske, Topic mit Listener (ParticipantEntityTest). (Commit cd8f3d67ea9) ### §2 Entity: enable

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.1, S. 26 (dds-1.2.pdf), Tabelle Entity — “enable: ReturnCode_t”

Status: done — enable folgt DDS 1.4 §2.2.2.1.1.7. Eine Entität, deren Factory nicht aktiviert ist, wird deaktiviert angelegt, und enable auf ihr ist PreconditionNotMetException (PublisherImpl.enable, SubscriberImpl.enable, DataWriterImpl.enable, DataReaderImpl.enable). DomainParticipantImpl.enable, PublisherImpl.enable und SubscriberImpl.enable aktivieren die bisher erzeugten Kinder, wenn ENTITY_FACTORY autoenable_created_entities gilt; createDataWriter und createDataReader aktivieren nur bei aktiviertem Publisher/Subscriber und dessen autoenable_created_entities. Der eingebaute Publisher und Subscriber werden mit enableBuiltin aktiviert. Tests: Factory mit autoenable = false (Participant und Kinder deaktiviert, PreconditionNotMetException, Aktivierung durch enable), Writer eines deaktivierten Publishers, Publisher mit autoenable = false, dieselben Fälle für Reader und Subscriber (ParticipantEntityTest). (Commit cd8f3d67ea9) ### §2 Entity: get_statuscondition

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.1, S. 26 (dds-1.2.pdf), Tabelle Entity — “get_statuscondition: StatusCondition”

Status: done — getStatusCondition liefert eine StatusConditionImpl, deren Trigger-Wert aus den von triggerStatus gesetzten und vom Lesen des jeweiligen Status gelöschten Statusarten folgt. DataReaderImpl setzt DATA_AVAILABLE, SAMPLE_REJECTED, SAMPLE_LOST, SUBSCRIPTION_MATCHED, REQUESTED_INCOMPATIBLE_QOS und REQUESTED_DEADLINE_MISSED über triggerStatus, DataWriterImpl PUBLICATION_MATCHED, OFFERED_INCOMPATIBLE_QOS, OFFERED_DEADLINE_MISSED und LIVELINESS_LOST, TopicImpl INCONSISTENT_TOPIC. Tests: WaitSet mit StatusCondition eines Readers (WaitSetTest), Reset durch Lesen (ReaderStatusTest), StatusCondition eines Writers und eines Topics (WriterStatusTest, TopicOperationsTest). (Commit d23eff980f3) ### §2 Entity: get_status_changes

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.1, S. 26 (dds-1.2.pdf), Tabelle Entity — “get_status_changes: StatusKind []”

Status: done — EntityBase.getStatusChanges liefert die Menge der ausgelösten Statusarten, ohne sie zu leeren; der Status wird beim Lesen des jeweiligen Status (getStatus, Lesen und Nehmen für DATA_AVAILABLE) zurückgesetzt (EntityBase.clearStatus). Tests: Reader nach Match, Lesen des Status und Take (ReaderStatusTest), Writer nach Match und Lesen (WriterStatusTest), Topic nach INCONSISTENT_TOPIC (TopicOperationsTest). Deadline-Status: WriterStatusTest::aMissedOfferedDeadlineIsCountedWithTheInstanceThatMissedIt wartet mit getStatusChanges auf OfferedDeadlineMissedStatus. (Commit 166d5873d4a) ### §2 Entity: get_instance_handle

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.1, S. 26 (dds-1.2.pdf), Tabelle Entity — “get_instance_handle: InstanceHandle_t”

Status: done — Jede Entität hält einen im Konstruktor aus einer UUID gebildeten, unveränderlichen Handle (EntityBase). containsEntityWalksTheContainment übergibt die Handles von Publisher, Writer, Subscriber, Reader und Topic an containsEntity (alle wahr, Nil-Handle falsch); der Schlüssel in den Daten des eingebauten Participant-Topics ist gleich dem getInstanceHandle des anderen Participants, und getDiscoveredTopicData findet ein Topic über dessen Handle. Die Eindeutigkeit folgt aus der UUID und wird nicht unmittelbar geprüft. (Commit d23eff980f3)

§2 Programmierschnittstellen von [DDS] 1.2: DomainParticipantFactory

§2 DomainParticipantFactory: create_participant

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.2, S. 45 (dds-1.2.pdf), Tabelle DomainParticipantFactory — “create_participant (domain_id: DomainId_t, qos_list: QosPolicy [], a_listener: DomainParticipantListener, mask: StatusKind []): DomainParticipant”

Status: done — createParticipant(int, DomainParticipantQos, DomainParticipantListener, Collection) setzt Listener und Statusmenge vor dem Eintragen des Participants in die Factory (DomainParticipantFactoryImpl.createParticipant). ParticipantEntityTest::createParticipantWithAListenerAndAMaskReachesItFromTheWritersOfTheParticipant ruft die Form mit Listener und Maske {PUBLICATION_MATCHED} und prüft, dass PUBLICATION_MATCHED eines Writers ohne eigenen Listener den Participant-Listener erreicht und SUBSCRIPTION_MATCHED, das nicht in der Maske steht, nicht. (Commit 2e0b194caf5) ### §2 DomainParticipantFactory: ein neuer Participant je Aufruf

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.2.1, S. 46 (dds-1.2.pdf) — “This operation creates a new DomainParticipant object.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantFactoryTest.java::createParticipantCreatesANewParticipantEachCall

Status: done — createParticipant legt je Aufruf ein neues DomainParticipantImpl an und trägt es in eine Liste je Domain ein (DomainParticipantFactoryImpl.register). Der Test erzeugt zwei Participants in derselben Domain und prüft assertNotSame; der Hinweis auf computeIfAbsent im bisherigen Item ist überholt. (Commit 2e0b194caf5) ### §2 DomainParticipantFactory: delete_participant

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.2, S. 45, §7.1.2.2.2.2, S. 46 (dds-1.2.pdf) — “delete_participant (a_participant: DomainParticipant): ReturnCode_t”; “This operation can only be invoked if all domain entities belonging to the participant have already been deleted. Otherwise the error PRECONDITION_NOT_MET is returned.”

Status: done — DomainParticipantImpl.close schließt die enthaltenen Entitäten (§7.2.3), nimmt den Participant aus der Factory und aus der Tabelle aller Participants des Prozesses und räumt die TRANSIENT-Daten der Domain nur, wenn danach kein Participant der Domain mehr offen ist (DomainParticipantFactoryImpl.participantsInDomain, DurabilityService.clearDomain). DomainParticipantFactory hat keine deleteParticipant-Operation (OMG-API). ParticipantEntityTest::theDataOfADomainSurvivesTheCloseOfAParticipantWhileAnotherOneIsOpen schreibt TRANSIENT-Daten, schließt den Writer und einen von zwei Participants (Daten bleiben), prüft lookupParticipant, schließt den zweiten (lookupParticipant liefert null, ein neuer Reader erhält nichts). (Commit cd8f3d67ea9) ### §2 DomainParticipantFactory: get_instance

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.2, S. 45, §7.1.2.2.2.3, S. 46 (dds-1.2.pdf) — “(static) get_instance: DomainParticipantFactory”; “it will return the same DomainParticipantFactory instance.”

Status: done — ZeroSPI.getParticipantFactory legt die Factory mit volatile-Feld und unter Sperre an (ServiceEnvironmentImpl). ParticipantFactoryEnvironmentTest::threadsThatAskForTheFactoryOfANewEnvironmentTogetherGetTheSameOne lässt acht Threads gleichzeitig (CyclicBarrier) die Factory einer neuen Umgebung anfordern, 25 Runden, und erwartet dasselbe Objekt; die bisherigen Tests prüfen assertSame bei zwei Aufrufen, assertNotSame zwischen zwei Umgebungen und die NullPointerException bei null. (Commit 36e8fd3f496) ### §2 DomainParticipantFactory: lookup_participant

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.2, S. 45 (dds-1.2.pdf), Tabelle DomainParticipantFactory — “lookup_participant (domain_id: DomainId_t): DomainParticipant”

Status: done — lookupParticipant(int) liefert den ersten Participant der Domain aus der Tabelle der Factory, sonst null; nach close ist der Participant aus der Tabelle genommen. Tests: DomainParticipantOperationsTest::lookupParticipantFindsOneOfTheDomain (assertSame, andere Domain null); ParticipantEntityTest::theDataOfADomainSurvivesTheCloseOfAParticipantWhileAnotherOneIsOpen (nach dem Schließen null); ParticipantFactoryEnvironmentTest::everyEnvironmentHasItsOwnFactoryAndItsOwnParticipantTable (die Factory einer anderen Umgebung findet den Participant nicht). (Commit 2e0b194caf5) ### §2 DomainParticipantFactory: set_default_participant_qos und get_default_participant_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.2, S. 45 (dds-1.2.pdf), Tabelle DomainParticipantFactory — “set_default_participant_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_participant_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::factoryQosAndDefaultParticipantQos, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::aDefaultQosWhosePoliciesAreNotConsistentIsRefusedAndKeepsTheOldOne

Status: done — getDefaultParticipantQos liefert den gesetzten Wert; ein danach mit createParticipant(int) erzeugter Participant hat genau dieses QoS (assertEquals auf getQos). DDS 1.4 verlangt für set_default_participant_qos die Prüfung auf Konsistenz; für die Policies eines DomainParticipantQos (USER_DATA, ENTITY_FACTORY) nennt §2.2.3 keine Regel, die zwei Werte inkonsistent macht, die Prüfung ist hier also leer. Die Default-Operationen von Publisher, Subscriber, Topic und Writer prüfen mit QosRules.checkConsistent (ParticipantEntityTest, PublisherOperationsTest). (Commit 2e0b194caf5) ### §2 DomainParticipantFactory: get_qos und set_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.2, S. 45 (dds-1.2.pdf), Tabelle DomainParticipantFactory — “get_qos (out: qos_list: QosPolicy []): ReturnCode_t; set_qos (qos_list: QosPolicy []): ReturnCode_t”

Status: done — getQos und setQos der Factory sind vorhanden; DomainParticipantFactoryImpl.autoEnable wertet ENTITY_FACTORY aus. ParticipantEntityTest::aFactoryThatDoesNotAutoEnableCreatesADisabledParticipantWhoseChildrenStayDisabled setzt ein Factory-QoS mit autoEnableCreatedEntities = false, erzeugt einen Participant, erwartet isEnabled() = false, die Ablehnung von enable auf seinen Kindern mit PreconditionNotMetException und nach enable() die aktivierten Kinder; das Factory-QoS wird im finally zurückgesetzt. (Commit 2e0b194caf5)

§2 Programmierschnittstellen von [DDS] 1.2: DomainParticipant

§2 DomainParticipant: create_publisher und delete_publisher

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 34–35 (dds-1.2.pdf), Tabelle DomainParticipant — “create_publisher (qos_list: QosPolicy [], a_listener: PublisherListener, mask: StatusKind []): Publisher; delete_publisher (a_publisher: Publisher): ReturnCode_t”

Status: done — createPublisher() hat die Formen ohne Argument, mit PublisherQos und mit Listener und Statusmenge; der Listener wird vor enable gesetzt (DomainParticipantImpl.newPublisher). Ein geschlossener Publisher verlässt die Liste des Participants über den Close-Hook (containsEntity liefert danach false). Tests: PublisherQos des Aufrufs und Default (DomainParticipantOperationsTest, ParticipantEntityTest), Überladung mit Listener (ParticipantEntityTest::createPublisherWithAListenerSeesTheMatchOfAWriterCreatedLater), containsEntity nach close (CloseCleanupTest::aClosedPublisherAndSubscriberLeaveTheParticipant), Schließen der Writer (CloseCascadeTest). (Commit 28e25c198d1) ### §2 DomainParticipant: create_subscriber und delete_subscriber

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 35 (dds-1.2.pdf), Tabelle DomainParticipant — “create_subscriber (qos_list: QosPolicy [], a_listener: SubscriberListener, mask: StatusKind []): Subscriber; delete_subscriber (a_subscriber: Subscriber): ReturnCode_t”

Status: done — createSubscriber() hat die Formen ohne Argument, mit SubscriberQos und mit Listener und Statusmenge; der Listener wird vor enable gesetzt (DomainParticipantImpl.newSubscriber). SubscriberImpl.close schließt die DataReader, und der Subscriber verlässt die Liste des Participants. Tests: ParticipantSubscriberTest::closingASubscriberClosesItsReadersAndLeavesTheParticipant (Reader geschlossen, read wirft AlreadyClosedException, containsEntity false, createDataReader wirft AlreadyClosedException), ParticipantEntityTest::createSubscriberWithAListenerSeesTheMatchOfAReaderCreatedLater. (Commit 28e25c198d1) ### §2 DomainParticipant: create_topic und delete_topic

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 35 (dds-1.2.pdf), Tabelle DomainParticipant — “create_topic (topic_name: string, type_name: string, qos_list: QosPolicy [], a_listener: TopicListener, mask: StatusKind []): Topic; delete_topic (a_topic: Topic): ReturnCode_t”

Status: done — createTopic mit Class, TypeSupport und DynamicType, mit und ohne TopicQos, Listener und Statusmenge; der Listener wird vor enable gesetzt (DomainParticipantImpl.newTopic). TopicImpl.close wirft PreconditionNotMetException, solange DataWriter, DataReader, ContentFilteredTopic oder MultiTopic das Topic nutzen (TopicImpl.use/release, von ContentFilteredTopicImpl und MultiTopicImpl mitgezählt), und das Topic verlässt über den Close-Hook die Liste des Participants und das DCPSTopic. Tests: TypeSupport-Formen (TopicOperationsTest::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass, ::aTypeSupportRegisteredUnderANameGivesTheTopicItsWritersAndItsAnnouncementThatName), übergebenes TopicQos (ParticipantEntityTest::theDefaultQosOfSubscriberAndTopicIsTheQosOfWhatIsCreatedNext), Listener (ParticipantEntityTest::createTopicWithAListenerAndAMaskKeepsThem), close mit Nutzern und danach (CloseCleanupTest, TopicOperationsTest). (Commit 36e8fd3f496) ### §2 DomainParticipant: create_contentfilteredtopic und delete_contentfilteredtopic

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 35 (dds-1.2.pdf), Tabelle DomainParticipant — “create_contentfilteredtopic (name: string, related_topic: Topic, filter_expression: string, expression_parameters: string []): ContentFilteredTopic; delete_contentfilteredtopic (a_contentfilteredtopic: ContentFilteredTopic): ReturnCode_t”

Status: done — ContentFilteredTopicImpl.setExpressionParameters übersetzt den Ausdruck mit ContentFilter.compile und den neuen Parametern neu; ein Parametersatz, den der Ausdruck nicht aufnimmt (fehlendes %n), wird mit IllegalArgumentException abgelehnt und der alte bleibt. close wirft PreconditionNotMetException, solange ein Reader das Topic liest, gibt das zugehörige Topic frei und entfernt den Eintrag aus der Liste des Participants (lookupTopicDescription liefert null); ein geschlossenes Topic ist für neue Reader AlreadyClosedException. Tests: TopicOperationsTest::setExpressionParametersFiltersWithTheNewParametersFromThenOn, ::closingAContentFilteredTopicNeedsItsReadersGoneAndRemovesItFromTheParticipant, ::aTopicDescriptionIsCloseableAndLeavesTheParticipantWhenTheResourceEnds, ::aTopicAndAContentFilteredTopicKnowTheirNameTypeAndParticipant (lookupTopicDescription). (Commit 36e8fd3f496) ### §2 DomainParticipant: create_multitopic und delete_multitopic

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 35 (dds-1.2.pdf), Tabelle DomainParticipant — “create_multitopic (name: string, type_name: string, subscription_expression: string, expression_parameters: string []): MultiTopic; delete_multitopic (a_multitopic: MultiTopic): ReturnCode_t”

Status: done — MultiTopicImpl.close wirft PreconditionNotMetException, solange ein Reader das MultiTopic liest, gibt die Topics der FROM-Klausel frei (MultiTopicImpl.bind hält sie) und entfernt den Eintrag aus der Liste des Participants; ein geschlossenes MultiTopic ist für neue Reader AlreadyClosedException. Tests: TopicOperationsTest::closingAMultiTopicNeedsItsReadersGoneAndFreesTheTopicsOfItsFromClause, ::aTopicDescriptionIsCloseableAndLeavesTheParticipantWhenTheResourceEnds, ::deleteContainedEntitiesRemovesEveryTopicDescriptionFromTheLookups. (Commit 36e8fd3f496) ### §2 DomainParticipant: find_topic

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 35–36 (dds-1.2.pdf), Tabelle DomainParticipant — “find_topic (topic_name: string, timeout: Duration_t): Topic”

Status: done — findTopic(String, Duration) und findTopic(String, long, TimeUnit) liefern ein vom Participant erzeugtes Topic, warten sonst bis zum Timeout auf eines, das ein anderer Thread erzeugt, und werfen TimeoutException. DDS 1.4 §2.2.2.2.1.11 überlässt der Implementierung, entfernt erzeugte Topics zugänglich zu machen; hier gibt es sie nicht. Tests: TopicOperationsTest::findTopicWaitsForATopicAnotherThreadCreatesAndTimesOutOtherwise (ein zweiter Thread erzeugt das Topic nach 200 ms, findTopic mit 30 s Grenze liefert es; ein unbekannter Name läuft nach 300 ms in die TimeoutException, Mindestdauer 290 ms), DomainParticipantOperationsTest::findTopicReturnsTheTopicAndTimesOutOtherwise. (Commit 819bfcb46cb) ### §2 DomainParticipant: lookup_topicdescription

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “lookup_topicdescription (name: string): TopicDescription”

Status: done — lookupTopicDescription durchsucht Topics, ContentFilteredTopics und MultiTopics des Participants; geschlossene Beschreibungen sind aus den Listen genommen. Tests: Topic mit assertSame, Name und Typname und unbekannter Name null (DomainParticipantOperationsTest), MultiTopic (MultiTopicTest), eingebaute Topics (BuiltinTopicsTest), ContentFilteredTopic und null nach close (TopicOperationsTest::aTopicAndAContentFilteredTopicKnowTheirNameTypeAndParticipant, ::closingAContentFilteredTopicNeedsItsReadersGoneAndRemovesItFromTheParticipant). (Commit 819bfcb46cb) ### §2 DomainParticipant: get_builtin_subscriber

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “get_builtin_subscriber: Subscriber”

Status: done — getBuiltinSubscriber legt einmal einen aktivierten Subscriber mit je einem DataReader für DCPSParticipant, DCPSPublication, DCPSSubscription und DCPSTopic an (DURABILITY TRANSIENT_LOCAL, RELIABILITY RELIABLE, HISTORY KEEP_LAST 1, DDS 1.4 §2.2.5); lookupDataReader(Topicname) findet sie. Die eingebauten Writer bieten TRANSIENT_LOCAL (Builtin.writer), sodass ein später angelegter Reader die bereits bekannten Entitäten erhält. Die eingebauten Reader liefern keine Daten über Entitäten des eigenen Participants (Ignores.pairIgnored, §2.2.5) und werden selbst nicht auf DCPSSubscription angekündigt. Tests: ParticipantDiscoveryTest::theBuiltinSubscriberHoldsOneReaderPerBuiltinTopic, ::aBuiltinReaderHasTheEntitiesThatExistedBeforeAndNoneOfItsOwnParticipant, ParticipantIgnoreTest::theBuiltinReaderOfAParticipantGivesNoDataAboutItsOwnEntities. (Commit cd8f3d67ea9) ### §2 DomainParticipant: ignore_participant

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “ignore_participant (handle: InstanceHandle_t): ReturnCode_t”

Status: done — ignoreParticipant trägt den Handle in die Ignorier-Mengen des Participants ein (Ignores.of(…).ignoreParticipant) und gleicht die Paare neu ab (InProcessBus.rematchIgnored): kein Endpunkt des ignorierten Participants wird mit einem Endpunkt dieses Participants gepaart, bestehende Paarungen enden, und die Daten kommen nicht an. Für den RTPS-Pfad trägt RtpsParticipant.ignoreParticipant das GUID-Präfix ein und entfernt Übereinstimmungen; ein späteres SEDP-Announcement paart nicht neu. getDiscoveredParticipants lässt den Handle aus, getDiscoveredParticipantData lehnt ihn mit PreconditionNotMetException ab. Tests: ParticipantIgnoreTest::ignoreParticipantBeforeTheWriterExistsKeepsItsDataAndItsMatchAway, ::ignoreParticipantAfterTheMatchEndsItAndStopsTheData, ::anIgnoredParticipantDoesNotIgnoreTheOtherWay; RTPS: WriterWireIgnoreTest::ignoreParticipantEndsTheMatchWithItsReadersAndKeepsItEnded, ParticipantWireDiscoveryTest::aParticipantOfAnotherProcessIsDiscoveredAndCanBeIgnored. Der RTPS-Participant eines Prozesses je Domain ist allen Participants der Domain gemeinsam, ein Ignorieren dort gilt für alle. (Commit cd8f3d67ea9) ### §2 DomainParticipant: ignore_topic

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “ignore_topic (handle: InstanceHandle_t): ReturnCode_t”

Status: done — ignoreTopic löst den Topic-Handle in einen Topicnamen auf (eigene Topics, Topics anderer Participants der Domain, aus SEDP bekannte Topics) und trägt den Namen ein: keine Veröffentlichung und kein Abonnement des Topics wird mit einem Endpunkt dieses Participants gepaart, bestehende Paarungen enden. Das Topic fehlt in getDiscoveredTopics, getDiscoveredTopicData lehnt den Handle mit PreconditionNotMetException ab. RTPS: RtpsParticipant.ignoreTopic. Tests: ParticipantIgnoreTest::ignoreTopicSeparatesTheTopicOfTheIgnoredHandleFromTheEndpointsOfTheParticipant; RTPS: WriterWireIgnoreTest::ignoreTopicEndsTheMatchWithTheReadersOfTheTopic. Ein Handle, der zum Zeitpunkt des Aufrufs keinem bekannten Topic gehört, wird nur gemerkt und wirkt nicht auf das Matching. (Commit cd8f3d67ea9) ### §2 DomainParticipant: ignore_publication

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “ignore_publication (handle: InstanceHandle_t): ReturnCode_t”

Status: done — ignorePublication trägt den Writer-Handle ein: kein Sample dieses Writers erreicht einen Reader dieses Participants, und der Writer wird mit keinem Reader dieses Participants gepaart (bestehende Paarung endet). RTPS: RtpsParticipant.ignoreEndpoint mit der Endpunkt-GUID. Tests: ParticipantIgnoreTest::ignorePublicationStopsTheDataOfOneWriterOnly (ein zweiter Writer desselben Participants liefert weiter); RTPS: WriterWireIgnoreTest::ignoreEndpointEndsTheMatchWithOneReader. (Commit cd8f3d67ea9) ### §2 DomainParticipant: ignore_subscription

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “ignore_subscription (handle: InstanceHandle_t): ReturnCode_t”

Status: done — ignoreSubscription trägt den Reader-Handle ein: kein Writer dieses Participants paart sich mit diesem Reader oder sendet ihm Daten (bestehende Paarung endet, getMatchedSubscriptions und PUBLICATION_MATCHED folgen). RTPS: RtpsParticipant.ignoreEndpoint. Tests: ParticipantIgnoreTest::ignoreSubscriptionStopsTheDataToOneReaderOnly (ein zweiter Reader erhält weiter); RTPS: WriterWireIgnoreTest::ignoreEndpointEndsTheMatchWithOneReader. (Commit cd8f3d67ea9) ### §2 DomainParticipant: get_domain_id

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “get_domain_id: DomainId_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::getDomainIdIsTheDomainTheParticipantWasCreatedIn

Status: done — getDomainId() gibt die Domain zurück, mit der der Participant erzeugt wurde (Feld domainId in DomainParticipantImpl). ParticipantEntityTest::getDomainIdIsTheDomainTheParticipantWasCreatedIn erzeugt Participants in den Domains 1200 und 1201 und vergleicht. (Commit 2e0b194caf5) ### §2 DomainParticipant: delete_contained_entities

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “delete_contained_entities: ReturnCode_t”

Status: done — closeContainedEntities schließt Publisher, Subscriber, ContentFilteredTopics, MultiTopics, Topics und den eingebauten Subscriber und lässt den Participant offen; die geschlossenen Entitäten verlassen über Close-Hooks die Listen des Participants. Tests: TopicOperationsTest::deleteContainedEntitiesRemovesEveryTopicDescriptionFromTheLookups (lookupTopicDescription liefert danach null, getDiscoveredTopics leer, containsEntity false), DomainParticipantOperationsTest::closeContainedEntitiesClosesThemWithoutClosingTheParticipant, CloseCascadeTest::participantCloseClosesContainedEntities, TopicOperationsTest::closingAParticipantWithFilteredTopicsMultiTopicsAndReadersDoesNotFail. (Commit 36e8fd3f496) ### §2 DomainParticipant: assert_liveliness

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “assert_liveliness: ReturnCode_t”

Status: done — DomainParticipantImpl.assertLiveliness erneuert die Lease der Writer des Participants mit LIVELINESS MANUAL_BY_PARTICIPANT (DataWriterImpl.assertedByParticipant); ein write oder assertLiveliness eines Writers dieser Art erneuert sie für die übrigen (PublisherImpl.writerAsserted, DomainParticipantImpl.livelinessAsserted), Writer mit MANUAL_BY_TOPIC bleiben unberührt. Tests mit Lease 1500 ms und 3 s Dauer: WriterStatusTest::assertLivelinessOfTheParticipantRenewsTheWritersWithManualByParticipant (der MANUAL_BY_PARTICIPANT-Writer verliert die Lease nicht, der MANUAL_BY_TOPIC-Writer verliert sie), ::aWriteOfOneWriterAssertsTheLivelinessOfTheParticipantsOtherManualWriters. (Commit cd8f3d67ea9) ### §2 DomainParticipant: set_default_publisher_qos und get_default_publisher_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “set_default_publisher_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_publisher_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::defaultQosIsTheQosOfWhatIsCreatedNext

Status: done — setDefaultPublisherQos prüft die Konsistenz (QosRules.checkConsistent, INCONSISTENT_POLICY); die Policies eines PublisherQos (GROUP_DATA, PARTITION, PRESENTATION, ENTITY_FACTORY) haben nach DDS 1.4 §2.2.3 keine Regel gegeneinander. Der Test setzt ein PublisherQos mit PARTITION „mine“, liest es zurück und prüft, dass createPublisher().getQos() es hat. (Commit 2e0b194caf5) ### §2 DomainParticipant: set_default_subscriber_qos und get_default_subscriber_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “set_default_subscriber_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_subscriber_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Status: done — DomainParticipantImpl.createSubscriber() nimmt defaultSubscriberQos. ParticipantEntityTest::theDefaultQosOfSubscriberAndTopicIsTheQosOfWhatIsCreatedNext setzt ein SubscriberQos mit GROUP_DATA, liest es zurück und prüft, dass createSubscriber().getQos() gleich dem gesetzten QoS ist. (Commit 2e0b194caf5) ### §2 DomainParticipant: set_default_topic_qos und get_default_topic_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “set_default_topic_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_topic_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::theDefaultQosOfSubscriberAndTopicIsTheQosOfWhatIsCreatedNext, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantEntityTest.java::aDefaultQosWhosePoliciesAreNotConsistentIsRefusedAndKeepsTheOldOne

Status: done — createTopic ohne QoS nimmt defaultTopicQos; setDefaultTopicQos prüft die Konsistenz (HISTORY depth gegen RESOURCE_LIMITS max_samples_per_instance, max_samples gegen max_samples_per_instance). ParticipantEntityTest::theDefaultQosOfSubscriberAndTopicIsTheQosOfWhatIsCreatedNext setzt ein TopicQos mit RELIABLE und prüft, dass createTopic(…).getQos() es hat und dass ein übergebenes QoS gilt; ::aDefaultQosWhosePoliciesAreNotConsistentIsRefusedAndKeepsTheOldOne prüft INCONSISTENT_POLICY für beide Regeln und dass das alte Default bleibt. (Commit 2e0b194caf5) ### §2 DomainParticipant: get_discovered_participants

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36 (dds-1.2.pdf), Tabelle DomainParticipant — “get_discovered_participants (inout: participant_handles: InstanceHandle_t []): ReturnCode_t”

Status: done — getDiscoveredParticipants liefert die Handles der Participants der Domain in diesem Prozess (aller Umgebungen, eigener eingeschlossen) und der von SPDP gemeldeten (RtpsParticipant, Handle aus participantGuid), ohne die ignorierten; ein geschlossener Participant fehlt. Tests: ParticipantDiscoveryTest::theDiscoveredParticipantsAreTheOtherParticipantsOfTheDomainAndTheirUserData, ::aClosedParticipantIsNotDiscoveredAnyMore, ParticipantFactoryEnvironmentTest::everyEnvironmentHasItsOwnFactoryAndItsOwnParticipantTable (Participants zweier Umgebungen), ParticipantWireDiscoveryTest::aParticipantOfAnotherProcessIsDiscoveredAndCanBeIgnored (SPDP), ParticipantIgnoreTest. (Commit cd8f3d67ea9) ### §2 DomainParticipant: get_discovered_participant_data

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 36–37 (dds-1.2.pdf), Tabelle DomainParticipant — “get_discovered_participant_data (inout: participant_data: ParticipantBuiltinTopicData, participant_handle: InstanceHandle_t): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::theDiscoveredParticipantsAreTheOtherParticipantsOfTheDomainAndTheirUserData, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantIgnoreTest.java::ignoreParticipantBeforeTheWriterExistsKeepsItsDataAndItsMatchAway, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicsTest.java::getDiscoveredParticipantDataCarriesTheUserData, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantWireDiscoveryTest.java::aParticipantOfAnotherProcessIsDiscoveredAndCanBeIgnored

Status: done — getDiscoveredParticipantData liefert Schlüssel und USER_DATA eines Participants der Domain aus dem Prozess oder aus SPDP; ein ignorierter Handle und ein unbekannter Handle sind PreconditionNotMetException. Tests: ParticipantDiscoveryTest::theDiscoveredParticipantsAreTheOtherParticipantsOfTheDomainAndTheirUserData (nicht leeres USER_DATA, Participant einer anderen Domain), ParticipantIgnoreTest::ignoreParticipantBeforeTheWriterExistsKeepsItsDataAndItsMatchAway (ignorierter Handle), BuiltinTopicsTest::getDiscoveredParticipantDataCarriesTheUserData (Nil-Handle), ParticipantWireDiscoveryTest (Schlüssel eines entfernten Participants). (Commit cd8f3d67ea9) ### §2 DomainParticipant: get_discovered_topics

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 37 (dds-1.2.pdf), Tabelle DomainParticipant — “get_discovered_topics (inout: topic_handles: InstanceHandle_t []): ReturnCode_t”

Status: done — getDiscoveredTopics liefert die Handles der Topics aller Participants der Domain in diesem Prozess und der aus SEDP bekannten Topics (Handle aus Name und Typname), ohne eingebaute Topics, ignorierte Topics und Topics ignorierter Participants. Tests: ParticipantDiscoveryTest::theTopicsOfOtherParticipantsOfTheDomainAreDiscovered, ::aTopicOfAnIgnoredParticipantIsNotDiscovered, ParticipantIgnoreTest::ignoreTopicSeparatesTheTopicOfTheIgnoredHandleFromTheEndpointsOfTheParticipant, ParticipantWireDiscoveryTest::aTopicOfAnotherProcessIsDiscoveredAndATypeThatDiffersIsInconsistent, BuiltinTopicsTest::getDiscoveredTopicDataCarriesTheTopicQos. (Commit cd8f3d67ea9) ### §2 DomainParticipant: get_discovered_topic_data

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 37 (dds-1.2.pdf), Tabelle DomainParticipant — “get_discovered_topic_data (inout: topic_data: TopicBuiltinTopicData, topic_handle: InstanceHandle_t): ReturnCode_t”

Status: done — getDiscoveredTopicData sucht den Handle bei den Topics aller Participants der Domain im Prozess und bei den aus SEDP bekannten Topics; ein ignorierter oder unbekannter Handle ist PreconditionNotMetException. Tests: ParticipantDiscoveryTest::theTopicsOfOtherParticipantsOfTheDomainAreDiscovered (Name, Typname, RELIABILITY gleich dem Wert des Topics, Ausnahme für einen Participant-Handle, Verschwinden nach close), ::aTopicOfAnIgnoredParticipantIsNotDiscovered, ParticipantIgnoreTest (ignoriertes Topic), ParticipantWireDiscoveryTest (Topic aus SEDP), BuiltinTopicsTest::getDiscoveredTopicDataCarriesTheTopicQos. (Commit cd8f3d67ea9) ### §2 DomainParticipant: contains_entity

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 37 (dds-1.2.pdf), Tabelle DomainParticipant — “contains_entity (a_handle: InstanceHandle_t): boolean”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::containsEntityWalksTheContainment, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantDiscoveryTest.java::theBuiltinSubscriberHoldsOneReaderPerBuiltinTopic, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCleanupTest.java::aClosedPublisherAndSubscriberLeaveTheParticipant

Status: done — containsEntity durchsucht rekursiv Publisher, Subscriber, deren DataWriter und DataReader, Topics, den eingebauten Subscriber und dessen Reader; geschlossene Entitäten sind nicht mehr enthalten. Tests: DomainParticipantOperationsTest::containsEntityWalksTheContainment (Handles von Publisher, Writer, Subscriber, Reader, Topic wahr, Nil-Handle falsch), ParticipantDiscoveryTest::theBuiltinSubscriberHoldsOneReaderPerBuiltinTopic (eingebaute Reader), CloseCleanupTest::aClosedPublisherAndSubscriberLeaveTheParticipant (nach close falsch). (Commit cd8f3d67ea9) ### §2 DomainParticipant: get_current_time

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.1, S. 37 (dds-1.2.pdf), Tabelle DomainParticipant — “get_current_time (inout: current_time: Time_t): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::getCurrentTimeFillsTheContainerOrReturnsANewOne

Status: done — getCurrentTime() liefert ein neues unveränderliches Time, getCurrentTime(ModifiableTime) füllt den Container und gibt ihn zurück (assertSame); beide nehmen System.currentTimeMillis(), die Quelle, mit der DataWriterImpl Samples stempelt. Der Test prüft beide Formen mit einem Wert größer 0 Sekunden. (Commit 819bfcb46cb) ### §2 DomainParticipantListener

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.2.3, S. 47–48 (dds-1.2.pdf) — “The DomainParticipantListener interface extends all other Listener interfaces and has no additional operation beyond the ones defined by the more general listeners.”

Status: done — DataWriterImpl und DataReaderImpl reichen einen Status ohne eigenen Listener (oder ohne den Status in dessen Maske) an Publisher beziehungsweise Subscriber und dann an den DomainParticipant weiter (ListenerUp); der Listener der Entität bekommt ihn zuerst. TopicImpl reicht INCONSISTENT_TOPIC an den DomainParticipant. DomainParticipantListener erweitert PublisherListener und SubscriberListener und trägt onInconsistentTopic. Tests: ListenerPropagationTest::aWriterWithoutListenerPassesTheMatchToThePublisherAndThenTheParticipant, PublisherOperationsTest::aWriterWithoutListenerAndAPublisherWithoutOnePassItToTheParticipantListener, TopicOperationsTest::aTopicWithoutListenerPassesInconsistentTopicToTheParticipantListener, ParticipantEntityTest::createParticipantWithAListenerAndAMaskReachesItFromTheWritersOfTheParticipant. (Commit f31b6fa11b5)

§2 Programmierschnittstellen von [DDS] 1.2: Topic-Klassen

§2 TopicDescription: get_participant

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.3.1, S. 49–50 (dds-1.2.pdf), Tabelle TopicDescription — “get_participant: DomainParticipant”

Status: done — TopicDescription.getParent liefert den DomainParticipant: TopicImpl hält ihn, ContentFilteredTopicImpl fragt das zugehörige Topic, MultiTopicImpl hält ihn. Tests: TopicOperationsTest::aTopicAndAContentFilteredTopicKnowTheirNameTypeAndParticipant (Topic und ContentFilteredTopic, assertSame), MultiTopicTest::theMultiTopicCarriesItsExpression (MultiTopic). (Commit 819bfcb46cb) ### §2 TopicDescription: get_type_name

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.3.1, S. 49–50 (dds-1.2.pdf), Tabelle TopicDescription — “readonly: type_name string; get_type_name: string”

Status: done — Topic.getTypeName liefert den Namen des TypeSupport, ContentFilteredTopicImpl.getTypeName den des zugehörigen Topics. Tests: TopicOperationsTest::aTopicAndAContentFilteredTopicKnowTheirNameTypeAndParticipant (Topic und ContentFilteredTopic gleich), DomainParticipantOperationsTest::lookupTopicDescriptionFindsOnlyWhatWasCreated („java::lang::String“), DynamicTopicTest (DynamicType „DynReading“), MultiTopicTest::theMultiTopicCarriesItsExpression. (Commit 819bfcb46cb) ### §2 TopicDescription: get_name

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.3.1, S. 49–50 (dds-1.2.pdf), Tabelle TopicDescription — “readonly: name string; get_name: string”

Status: done — Die drei Implementierungen geben den Namen aus createTopic, createContentFilteredTopic und createMultiTopic zurück. Die Tests erwarten “Chatter” (Topic), “Hot” (ContentFilteredTopic) und “Hot” (MultiTopic). (Commit 9267b77a38a) ### §2 Topic: get_inconsistent_topic_status

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.3.2, S. 50 (dds-1.2.pdf), Tabelle Topic — “get_inconsistent_topic_status (out: status: InconsistentTopicStatus): ReturnCode_t”

Status: done — DomainParticipantImpl.checkTopicConsistency erkennt beim Erzeugen eines Topics ein Topic gleichen Namens mit anderem Typnamen bei einem anderen Participant der Domain im Prozess, DomainParticipantImpl.remoteEndpointSeen bei einem Endpunkt aus SEDP; beide Seiten rufen TopicImpl.onInconsistentTopic. getInconsistentTopicStatus liefert total_count und total_count_change und setzt die Änderung zurück. Tests: TopicOperationsTest::aTopicOfTheSameNameAndAnotherTypeInTheDomainIsInconsistentAndTellsTheTopicListener (total_count 1 auf beiden Topics, Änderung zurückgesetzt), ::topicsOfTheSameTypeOrInAnotherDomainAreConsistent (kein Zähler bei gleichem Typ, anderer Domain, anderem Namen), ParticipantWireDiscoveryTest::aTopicOfAnotherProcessIsDiscoveredAndATypeThatDiffersIsInconsistent (SEDP). (Commit cd8f3d67ea9) ### §2 ContentFilteredTopic: filter_expression

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.3.3, S. 51–52 (dds-1.2.pdf), Tabelle ContentFilteredTopic — “readonly: filter_expression string”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theContentFilteredTopicOfTheParticipantFiltersTheSamples

Status: done — createContentFilteredTopic übersetzt denselben Ausdruck mit ContentFilter.compile in das Prädikat und gibt ihn über getFilterExpression zurück. Der Test erwartet “value > 50” und prüft, dass ein Reader auf dem ContentFilteredTopic nur das Sample mit value 99.0 erhält. Der öffentliche Konstruktor von ContentFilteredTopicImpl nimmt Text und Prädikat getrennt (QosLifecycleTest::contentFilteredTopicDropsNonMatching); die Übereinstimmung gilt für den Weg über den Participant. (Commit 2e0b194caf5) ### §2 ContentFilteredTopic: get_related_topic

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.3.3, S. 51 (dds-1.2.pdf), Tabelle ContentFilteredTopic — “get_related_topic: Topic”

Status: done — getRelatedTopic liefert das Topic aus createContentFilteredTopic; SubscriberImpl.createDataReader abonniert über dieses Topic. Der erste Test erwartet assertEquals(topic, hot.getRelatedTopic()) und dass der Reader nur das passende Sample von einem Writer auf dem zugehörigen Topic erhält; der zweite prüft das Verwerfen nicht passender Samples. (Commit 2e0b194caf5) ### §2 ContentFilteredTopic: get_expression_parameters und set_expression_parameters

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.3.3, S. 51–52 (dds-1.2.pdf), Tabelle ContentFilteredTopic — “get_expression_parameters (out: expression_parameters: string []): ReturnCode_t; set_expression_parameters (expression_parameters: string []): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::setExpressionParametersFiltersWithTheNewParametersFromThenOn

Status: done — ContentFilteredTopicImpl.setExpressionParameters übersetzt das Prädikat mit ContentFilter.compile(filterExpression, neueParameter) neu; evaluate und damit die Reader auf dem ContentFilteredTopic nutzen es ab dem nächsten Sample. getExpressionParameters liefert die Liste. Test: TopicOperationsTest::setExpressionParametersFiltersWithTheNewParametersFromThenOn (Ausdruck „level > %0“, Parameter 10 dann 3, erwartete Samples 15 beziehungsweise 5; ein leerer Parametersatz wird abgelehnt und der alte bleibt). (Commit 36e8fd3f496) ### §2 MultiTopic: subscription_expression und Parameter

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.3.4, S. 52–53 (dds-1.2.pdf), Tabelle MultiTopic — “readonly: subscription_expression string; get_expression_parameters (out: expression_parameters: string []): ReturnCode_t; set_expression_parameters (expression_parameters: string []): ReturnCode_t”

Status: done — MultiTopic ist heute vorhanden (org.omg.dds.topic.MultiTopic, MultiTopicImpl, DomainParticipant.createMultiTopic). Die Tests prüfen den Ausdruck, die Parameterliste vor und nach setExpressionParameters und dass ein neuer Parameter (“1000” auf “2000”) die WHERE-Klausel eines Readers ändert. (Commit fd437c122cf) ### §2 TopicListener: on_inconsistent_topic

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.3.5, S. 53 (dds-1.2.pdf), Tabelle TopicListener — “on_inconsistent_topic (the_topic: Topic, status: InconsistentTopicStatus): void”

Status: done — TopicImpl.onInconsistentTopic zählt, löst den Status aus und ruft den TopicListener mit einem InconsistentTopicEventImpl außerhalb der Topic-Sperre: den eigenen Listener, wenn er den Status in der Maske hat, sonst den DomainParticipantListener (ListenerUp.forTopic). Tests: TopicOperationsTest::aTopicOfTheSameNameAndAnotherTypeInTheDomainIsInconsistentAndTellsTheTopicListener (TopicAdapter, Quelle und Status des Events), ::aTopicWithoutListenerPassesInconsistentTopicToTheParticipantListener. (Commit cd8f3d67ea9) ### §2 TypeSupport: register_type und get_type_name

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.3.6, S. 53–54 (dds-1.2.pdf), Tabelle TypeSupport — “register_type (participant: DomainParticipant, type_name: string): ReturnCode_t; get_type_name: string”

Status: done — ServiceEnvironmentImpl.ZeroSPI.newTypeSupport legt den Codec unter dem registrierten Namen an (RegisteredNameTypeSupport.named); Topic.getTypeName, Writer, Reader, InProcessBus und SEDP verwenden damit einen Namen. Tests: TopicOperationsTest::aTypeSupportRegisteredUnderANameGivesTheTopicItsWritersAndItsAnnouncementThatName (Writer und Reader zweier Participants paaren sich unter „my::Named“ und tauschen ein Sample aus, die DCPSPublication-Daten tragen „my::Named“, ein Topic gleichen Namens aus der Klasse hat „java::lang::String“ und paart nicht), ::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass. (Commit 36e8fd3f496)

§2 Programmierschnittstellen von [DDS] 1.2: Publisher

§2 Publisher: create_datawriter und delete_datawriter

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.1, S. 57 (dds-1.2.pdf), Tabelle Publisher — “create_datawriter (a_topic: Topic, qos: QosPolicy [], a_listener: DataWriterListener, mask: StatusKind []): DataWriter; delete_datawriter (a_datawriter: DataWriter): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerPropagationTest.java::aWriterListenerSetAtCreationSeesTheMatchOfEnable, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aDefaultWriterQosThatIsNotConsistentIsRefusedAndTheOldOneStays, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::closeContainedEntitiesClosesTheWritersAndWithdrawsThemFromTheBuiltinTopic, crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCleanupTest.java::aClosedWriterAndReaderAreNotListedOrFoundAnyMore, crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::theMatchedEntitiesAreDescribedWithTheirQos, crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aClosedEntityRefusesToCreateContainedEntities

Status: done — createDataWriter hat die Formen Topic, Topic mit DataWriterQos und Topic mit DataWriterQos, DataWriterListener und Statusmenge; der Listener wird vor enable gesetzt, sodass ein vorhandener Reader als onPublicationMatched gemeldet wird. DataWriterImpl.close nimmt den Writer aus PublisherImpl.writers und aus DCPSPublication (Close-Hook). createDataWriter lehnt ein inkonsistentes DataWriterQos mit InconsistentPolicyException ab. Tests: ListenerPropagationTest::aWriterListenerSetAtCreationSeesTheMatchOfEnable, PublisherOperationsTest::aDefaultWriterQosThatIsNotConsistentIsRefusedAndTheOldOneStays, ::closeContainedEntitiesClosesTheWritersAndWithdrawsThemFromTheBuiltinTopic, CloseCleanupTest::aClosedWriterAndReaderAreNotListedOrFoundAnyMore, PubSubLoopbackTest::singleWriterSingleReaderRoundTrip, BuiltinTopicQosTest::theMatchedEntitiesAreDescribedWithTheirQos. (Commit f31b6fa11b5) ### §2 Publisher: lookup_datawriter

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.1, S. 57 (dds-1.2.pdf), Tabelle Publisher — “lookup_datawriter (topic_name: string): DataWriter”

Status: done — PublisherImpl.lookupDataWriter(String) und (Topic) suchen in der Liste der erzeugten Writer nach dem Topicnamen und liefern null, wenn keiner passt; ein geschlossener Writer ist aus der Liste genommen (Close-Hook). Test: PublisherOperationsTest::lookupDataWriterFindsByNameAndByTopicAndForgetsClosedWriters (Fund über Name und Topic, null für unbekannten Namen und anderes Topic, null nach close); CloseCleanupTest::aClosedWriterAndReaderAreNotListedOrFoundAnyMore. (Commit 28e25c198d1) ### §2 Publisher: suspend_publications und resume_publications

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.1, S. 57 (dds-1.2.pdf), Tabelle Publisher — “suspend_publications: ReturnCode_t; resume_publications: ReturnCode_t”

Status: done — PublisherImpl.suspendPublications zählt (die Aufrufe verschachteln), resumePublications ohne passendes suspendPublications wirft PreconditionNotMetException (DDS 1.4 §2.2.2.4.1.9, PSM Table 7.1); suspend ist ein Hinweis, die Writer liefern unverändert. Tests: PublisherOperationsTest::resumePublicationsNeedsASuspendPublicationsAndTheCallsNest (Paar, Verschachtelung, Ausnahme, AlreadyClosedException nach close), ::writesWhileSuspendedAreDeliveredAsBefore. (Commit cd8f3d67ea9) ### §2 Publisher: begin_coherent_changes und end_coherent_changes

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.1, S. 57 (dds-1.2.pdf), Tabelle Publisher — “begin_coherent_changes: ReturnCode_t; end_coherent_changes: ReturnCode_t”

Status: done — beginCoherentChanges/endCoherentChanges nesten (PublisherImpl.coherentDepth), endCoherentChanges ohne begin wirft PreconditionNotMetException. Hat die PRESENTATION des Publishers coherent_access, hält der Publisher die Zustellungen seiner Writer zurück (PublisherImpl.deferCoherent) und liefert sie beim letzten end in Schreibreihenfolge als einen Schritt (InProcessBus.atomically): jedes read und take eines Readers hält die Gegenseite desselben Tores, sodass ein Leser in einem anderen Thread alle Samples eines Satzes sieht oder keines (CoherentSetAtomicityTest; ohne das Tor schlägt er fehl). Über RTPS tragen die Samples eines Satzes PID_COHERENT_SET (0x0056) mit der Sequenznummer des ersten Samples des Writers im Satz (DDSI-RTPS 2.5 §8.7.6, §9.6.4.2; Oktette gegen coherent_set_bytes der Rust-Implementierung), das Ende ist ein DATA ohne Daten und ohne Inline-QoS (Tabelle 9.22, Beispiel 3). Ein Reader eines Subscribers mit coherent_access hält die Samples eines entfernten Satzes, bis er vollständig ist (CoherentHold), und gibt sie zusammen weiter; ein unvollständiger Satz (ein Sample fehlt) wird nicht zugestellt und im Log genannt (§8.7.6). Erwartung gegenüber Cyclone DDS, Fast DDS und OpenDDS: sie lesen PID 0x0056 und verhalten sich nach §8.7.6; ein DATA ohne Daten am Ende eines Satzes ist nach Tabelle 9.22 vorgesehen. Gemessen ist nur die Gegenstelle in ZeroDDS. Der Gruppen-Satz (access_scope GROUP, PID_GROUP_COHERENT_SET, End-Coherent-Set-DATA aller Writer des Publishers) ist nicht gebaut; er steht im offenen Item zu PRESENTATION. (Commit 178c642cbc7) ### §2 Publisher: wait_for_acknowledgments

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.1, S. 57 (dds-1.2.pdf), Tabelle Publisher — “wait_for_acknowledgments (max_wait: Duration_t): ReturnCode_t”

Status: done — PublisherImpl.waitForAcknowledgments wartet nacheinander auf die aktivierten Writer des Publishers mit einer gemeinsamen Frist; DataWriterImpl.awaitAcknowledgments wartet bei einem Writer mit RTPS-Anbindung über RtpsParticipant.WireWriter.waitForAcknowledgments auf ReliableWriterState.awaitAcknowledged (die Historie ist leer, wenn alle Reader per ACKNACK bestätigt haben) und wirft TimeoutException, wenn die Frist abläuft. Reader im selben Prozess haben das Sample bei der Rückkehr von write (synchrone Zustellung). Ein negatives maxWait ist IllegalArgumentException, ein geschlossener Publisher AlreadyClosedException. Tests: PublisherOperationsTest::waitForAcknowledgmentsReturnsAtOnceForReadersOfTheProcess, WriterWireAckTest::aSampleTheRemoteReaderAcknowledgedEndsTheWait und ::aSampleNobodyAcknowledgesIsATimeoutException (Publisher- und Writer-Form), WriterAckStateTest. (Commit cd8f3d67ea9) ### §2 Publisher: get_participant

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.1, S. 57 (dds-1.2.pdf), Tabelle Publisher — “get_participant: DomainParticipant”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic

Status: done — PublisherImpl.getParent liefert den DomainParticipant, den DomainParticipantImpl.createPublisher beim Erzeugen übergibt; DataWriterImpl.getParent den Publisher. Test: PublisherOperationsTest::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic (assertSame). (Commit 2e0b194caf5) ### §2 Publisher: delete_contained_entities

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.1, S. 57 (dds-1.2.pdf), Tabelle Publisher — “delete_contained_entities: ReturnCode_t”

Status: done — PublisherImpl.closeContainedEntities schließt jeden Writer; dessen Close-Hook nimmt ihn aus PublisherImpl.writers und zieht ihn aus DCPSPublication zurück. Der Publisher bleibt offen und nimmt neue Writer an. Tests: PublisherOperationsTest::closeContainedEntitiesClosesTheWritersAndWithdrawsThemFromTheBuiltinTopic (Writer geschlossen, lookupDataWriter null, getDataWriters leer, containsEntity false, der eingebaute Reader eines anderen Participants sieht NOT_ALIVE_NO_WRITERS), CloseCleanupTest::closeContainedEntitiesEmptiesPublisherAndSubscriber. (Commit 28e25c198d1) ### §2 Publisher: set_default_datawriter_qos und get_default_datawriter_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.1, S. 57–58 (dds-1.2.pdf), Tabelle Publisher — “set_default_datawriter_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_datawriter_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Status: done — PublisherImpl.setDefaultDataWriterQos prüft die Konsistenz (QosRules.checkConsistent) und wirft InconsistentPolicyException, ohne das Default zu ändern; createDataWriter(Topic) verwendet das gesetzte Default, ein dem Aufruf übergebenes QoS hat Vorrang, und createDataWriter prüft das QoS ebenfalls. Tests: PublisherOperationsTest::theDefaultWriterQosIsTheQosOfTheWritersCreatedNext, ::aDefaultWriterQosThatIsNotConsistentIsRefusedAndTheOldOneStays. (Commit cd8f3d67ea9) ### §2 Publisher: copy_from_topic_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.1, S. 58 (dds-1.2.pdf), Tabelle Publisher — “copy_from_topic_qos (inout: a_datawriter_qos: QosPolicy [], a_topic_qos: QosPolicy []): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::copyFromTopicQosLetsThePoliciesOfTheTopicReplaceThoseOfTheWriter

Status: done — PublisherImpl.copyFromTopicQos übernimmt jede Policy des TopicQos, die ein DataWriter kennt, in das DataWriterQos und ersetzt dabei den Wert des Writer-QoS (DDS 1.4 §2.2.2.4.1.17); Policies, die das TopicQos nicht hat (USER_DATA, OWNERSHIP_STRENGTH), bleiben die des Writer-QoS, das übergebene QoS bleibt unverändert, und das Ergebnis wird nicht auf Konsistenz geprüft. Test: PublisherOperationsTest::copyFromTopicQosLetsThePoliciesOfTheTopicReplaceThoseOfTheWriter (DEADLINE 5 s und BEST_EFFORT des Writers werden zu DEADLINE 7 s und RELIABLE des Topics, bei einem Topic mit Default-Werten zu unendlich und BEST_EFFORT). (Commit cd8f3d67ea9) ### §2 PublisherListener

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.3, S. 71–72 (dds-1.2.pdf) — “PublisherListener: no attributes, no operations (inherits the operations of DataWriterListener)”

Status: done — DataWriterImpl.listenerFor reicht einen Status, den der Listener des Writers nicht nimmt, an den PublisherListener des PublisherImpl (ListenerUp.forWriter) und dann an den des DomainParticipant. Tests: PublisherOperationsTest::aWriterWithoutListenerPassesOfferedIncompatibleQosToThePublisher (Quelle des Events der Writer, Status mit total_count 1 und Policy Reliability), ::aWriterThatAWriterListenerTakesIsNotPassedUp, ListenerPropagationTest::aWriterWithoutListenerPassesTheMatchToThePublisherAndThenTheParticipant. (Commit f31b6fa11b5)

§2 Programmierschnittstellen von [DDS] 1.2: DataWriter

§2 DataWriter: register_instance und register_instance_w_timestamp

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 62 (dds-1.2.pdf), Tabelle DataWriter — “register_instance (instance: Data): InstanceHandle_t; register_instance_w_timestamp (instance: Data, timestamp: Time_t): InstanceHandle_t”

Status: done — registerInstance(T) liefert einen von InstanceKey.toHandle gebildeten Handle; die Formen mit Time und mit long und TimeUnit verwenden den Zeitstempel für die Liveliness-Zeit (DataWriterImpl.registerInstanceAt). Das Registrieren sendet nichts an die Reader (DDS 1.4 §2.2.2.4.2.5 verlangt es nicht). Tests: WriterHandleTest::registerInstanceTakesATimestampAndLookupInstanceFindsTheInstanceByItsKey (alle drei Formen, derselbe Handle bei erneutem Registrieren), QosLifecycleTest::registerAndLookupInstance. (Commit 56f40fabd6c) ### §2 DataWriter: unregister_instance und unregister_instance_w_timestamp

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 62 (dds-1.2.pdf), Tabelle DataWriter — “unregister_instance (instance: Data, handle: InstanceHandle_t): ReturnCode_t; unregister_instance_w_timestamp (instance: Data, handle: InstanceHandle_t, timestamp: Time_t): ReturnCode_t”

Status: done — unregisterInstance(InstanceHandle, …) löst die Instanz über DataWriterImpl.resolve aus dem Handle oder, bei HANDLE_NIL, aus dem Sample auf und verwendet den Schlüssel der Registrierung, den der Reader sucht. Ein Handle einer anderen Instanz als der des Samples ist PreconditionNotMetException, ein Handle keiner Instanz des Writers (auch ein bereits abgemeldeter) IllegalArgumentException (BAD_PARAMETER). Tests: WriterHandleTest::unregisterByHandleOrBySampleMakesTheReaderSeeNoWriters (Reader sieht NOT_ALIVE_NO_WRITERS für beide Instanzen), InstanceHandleTest::aWriterDisposesAndUnregistersTheInstancesItRegistered, QosLifecycleTest::unregisterMarksInstanceNotAliveNoWriters, ::closingOneWriterDoesNotMarkNoWritersWhileAnotherWrites. (Commit d70d1f69c5d) ### §2 DataWriter: get_key_value

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 62 (dds-1.2.pdf), Tabelle DataWriter — “get_key_value (inout: key_holder: Data, handle: InstanceHandle_t): ReturnCode_t”

Status: done — getKeyValue(T, InstanceHandle) und getKeyValue(InstanceHandle) liefern eine Kopie des letzten für die Instanz geschriebenen Samples, sodass die Schlüsselfelder gesetzt sind; ein Typ ohne Schlüssel ist PreconditionNotMetException, ein Handle keiner Instanz des Writers IllegalArgumentException. Tests: InstanceHandleTest::getKeyValueReturnsTheInstanceOfTheHandle (Schlüssel 2 zum registrierten Handle, lookupInstance gibt den Handle zurück), WriterHandleTest::getKeyValueRefusesAnUnkeyedTypeAndAnUnknownHandle. (Commit 56f40fabd6c) ### §2 DataWriter: lookup_instance

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 62 (dds-1.2.pdf), Tabelle DataWriter — “lookup_instance (instance: Data): InstanceHandle_t”

Status: done — lookupInstance(T) liefert den Handle der registrierten oder geschriebenen Instanz und InstanceHandle.NIL für eine unbekannte; die Form mit ModifiableInstanceHandle füllt und liefert den übergebenen Handle. Tests: QosLifecycleTest::registerAndLookupInstance, WriterHandleTest::registerInstanceTakesATimestampAndLookupInstanceFindsTheInstanceByItsKey (Schlüssel bestimmt die Instanz, Form mit ModifiableInstanceHandle, unbekannter Schlüssel liefert den Nil-Handle). (Commit 56f40fabd6c) ### §2 DataWriter: write und write_w_timestamp

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 62 (dds-1.2.pdf), Tabelle DataWriter — “write (data: Data, handle: InstanceHandle_t): ReturnCode_t; write_w_timestamp (data: Data, handle: InstanceHandle_t, source_timestamp: Time_t): ReturnCode_t”

Status: done — DataWriter hat sechs write-Überladungen (ohne, mit Time, mit long und TimeUnit, je mit und ohne InstanceHandle); der Zeitstempel ist der Source-Zeitstempel des Samples beim Reader. Tests: WriterHandleTest::everyWriteOverloadCarriesItsSourceTimestampToTheSample (fünf Formen, Zeitstempel und Instanz-Handle am Sample), ::anUnkeyedTypeIsWrittenWithTheNilHandle, PubSubLoopbackTest::singleWriterSingleReaderRoundTrip, QuickstartApiTest::largeByteArrayGrowsEncoderBuffer, ExceptionMappingTest::writeOnAClosedWriterThrowsAlreadyClosed, ::aNotEnabledWriterRefusesToWrite. (Commit 56f40fabd6c) ### §2 DataWriter: write mit Handle HANDLE_NIL

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2.11, S. 67 (dds-1.2.pdf) — “The special value HANDLE_NIL can be used for the parameter handle. This indicates that the identity of the instance should be automatically deduced from the instance_data (by means of the key).”

Status: done — write(T, InstanceHandle, …) prüft den Handle (DataWriterImpl.checkHandle): HANDLE_NIL ist zulässig, der Handle der Instanz des Samples ebenfalls, der Handle einer anderen Instanz des Writers ist PreconditionNotMetException, ein Handle keiner Instanz des Writers IllegalArgumentException (BAD_PARAMETER, §2.2.2.4.2.11). Tests: InstanceHandleTest::aHandleGivenWithAWriteIsTheHandleOfTheSamplesInstance (HANDLE_NIL nicht, registrierter Handle ja, fremder registrierter Handle PreconditionNotMetException), WriterHandleTest::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed (unbekannter Handle IllegalArgumentException bei write und dispose). (Commit d70d1f69c5d) ### §2 DataWriter: dispose und dispose_w_timestamp

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 63 (dds-1.2.pdf), Tabelle DataWriter — “dispose (data: Data, handle: InstanceHandle_t): ReturnCode_t; dispose_w_timestamp (data: Data, handle: InstanceHandle_t, timestamp: Time_t): ReturnCode_t”

Status: done — dispose(InstanceHandle, …) und dispose(T, …) setzen die Instanz beim Reader auf NOT_ALIVE_DISPOSED; die Handle-Formen lösen über DataWriterImpl.resolve auf (Handle der Registrierung oder HANDLE_NIL mit Sample) und treffen die Instanz, die der Reader über den Schlüssel findet. Tests: WriterHandleTest::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed (Formen mit Time und mit long und TimeUnit), InstanceHandleTest::aWriterDisposesAndUnregistersTheInstancesItRegistered, QosLifecycleTest::disposeMarksInstanceNotAliveDisposed, ::disposedThenWrittenIsRebornAlive. (Commit d70d1f69c5d) ### §2 DataWriter: dispose mit Handle

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2.13, S. 69 (dds-1.2.pdf) — “The constraints on the values of the handle parameter and the corresponding error behavior are the same specified for the unregister_instance operation (Section 7.1.2.4.2.7).”

Status: done — dispose(InstanceHandle, T, …) meldet PreconditionNotMetException für den Handle einer anderen Instanz als der des Samples und IllegalArgumentException (BAD_PARAMETER) für einen Handle, den der Writer nicht kennt (DataWriterImpl.resolve); dispose(InstanceHandle, T) verwendet den Handle. Tests: WriterHandleTest::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed, InstanceHandleTest::aWriterDisposesAndUnregistersTheInstancesItRegistered (kein Handle und kein Sample: IllegalArgumentException). (Commit d70d1f69c5d) ### §2 DataWriter: wait_for_acknowledgments

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 63 (dds-1.2.pdf), Tabelle DataWriter — “wait_for_acknowledgments (max_wait: Duration_t): ReturnCode_t”

Status: done — DataWriterImpl.waitForAcknowledgments(Duration) und (long, TimeUnit) rufen awaitAcknowledgments: für Reader im selben Prozess kehrt der Aufruf sofort zurück, für Reader über RTPS wartet er auf die Bestätigungen aus ReliableWriterState und wirft TimeoutException, wenn maxWait abläuft; null und negative Frist sind IllegalArgumentException, ein geschlossener Writer AlreadyClosedException, ein nicht aktivierter NotEnabledException. Tests: WriterWaitAckTest (vier Fälle), WriterWireAckTest (Bestätigung und Timeout über RTPS), WriterAckStateTest (Historie, ACKNACK, Peer-Verlust). (Commit cd8f3d67ea9) ### §2 DataWriter: get_liveliness_lost_status

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 63 (dds-1.2.pdf), Tabelle DataWriter — “get_liveliness_lost_status (out: status: LivelinessLostStatus): ReturnCode_t”

Status: done — Die Lease wird überwacht (LeaseMonitor, DataWriterImpl.evaluateLiveliness): ein Writer mit MANUAL_BY_TOPIC und endlicher Lease, der sie nicht erneuert, zählt LIVELINESS_LOST einmal und ist danach nicht mehr lebendig; assertLiveliness macht ihn wieder lebendig. getLivelinessLostStatus liefert total_count und total_count_change; die Änderung wird beim Rufen des Listeners oder beim Lesen zurückgesetzt. Tests: WriterStatusTest::aWriterThatDoesNotAssertItsLivelinessLosesItOnceAndAssertingRestoresIt (Listener-Aufruf, Status gelesen, kein weiterer Zähler solange nicht lebendig, nach assertLiveliness erneuter Verlust), LeaseTest::livelinessLostFiresWithoutPolling. (Commit d23eff980f3) ### §2 DataWriter: get_offered_deadline_missed_status

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 63 (dds-1.2.pdf), Tabelle DataWriter — “get_offered_deadline_missed_status (out: status: OfferedDeadlineMissedStatus): ReturnCode_t”

Status: done — Der Writer prüft DEADLINE je Instanz (evaluateOfferedDeadline, Lease-Timer); getOfferedDeadlineMissedStatus liefert total_count, total_count_change und last_instance_handle. Test: WriterStatusTest::aMissedOfferedDeadlineIsCountedWithTheInstanceThatMissedIt (Deadline 30 ms, ein Write; total_count >= 1, bei der ersten Abfrage total_count_change = total_count, last_instance_handle = lookupInstance, bei der zweiten Abfrage Änderung = Differenz), LeaseTest::offeredDeadlineMissedFiresWithoutPolling. (Commit d23eff980f3) ### §2 DataWriter: get_offered_incompatible_qos_status

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 63 (dds-1.2.pdf), Tabelle DataWriter — “get_offered_incompatible_qos_status (out: status: OfferedIncompatibleQosStatus): ReturnCode_t”

Status: done — DataWriterImpl.onReaderPresenceChanged vergleicht die vom Reader angefragte mit der angebotenen QoS (QosCompatibility), paart bei Unverträglichkeit nicht und zählt OFFERED_INCOMPATIBLE_QOS mit der ersten verweigernden Policy und einer Zählung je Policy. Tests: WriterStatusTest::anIncompatibleReaderIsCountedWithTheRefusedPolicy (total_count 1, last_policy_class Reliability, genau ein QosPolicyCount für Reliability mit Zähler 1, kein Match, Listener-Status), QosCompatibilityTest::incompatibleReliabilityDoesNotConnect. (Commit d23eff980f3) ### §2 DataWriter: get_publication_matched_status

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 63 (dds-1.2.pdf), Tabelle DataWriter — “get_publication_matched_status (out: status: PublicationMatchedStatus): ReturnCode_t”

Status: done — DataWriterImpl führt total_count, current_count und deren Änderungswerte; die Änderungswerte werden beim Lesen oder beim Rufen des Listeners zurückgesetzt. Test: WriterStatusTest::thePublicationMatchedStatusCountsAndNamesTheLastSubscription (erster Reader: 1/1/1/1; erneutes Lesen: Änderungen 0; zweiter Reader gekommen und gegangen: total_count 2, Änderung 1, current_count 1, Änderung 0; letzter Reader gegangen: current_count 0, Änderung -1, total_count_change 0), ListenerTest::statusIsReadableWithoutAListener, ::writerListenerFiresOnPublicationMatched. (Commit cd8f3d67ea9) ### §2 DataWriter: last_subscription_handle von PUBLICATION_MATCHED

Spec: §2, S. 11; [DDS] 1.2 IDL, S. 160 (dds-1.2.pdf) — “struct PublicationMatchedStatus { […] InstanceHandle_t last_subscription_handle; };”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::thePublicationMatchedStatusCountsAndNamesTheLastSubscription

Status: done — DataWriterImpl.onReaderPresenceChanged merkt den Handle des Readers, der den Status zuletzt änderte (Match oder Verlust), und readPublicationMatchedStatusLocked setzt ihn als last_subscription_handle ein. Test: WriterStatusTest::thePublicationMatchedStatusCountsAndNamesTheLastSubscription (der Handle ist getInstanceHandle des Readers und ein Element von getMatchedSubscriptions; nach dem Verlust bleibt er der des gegangenen Readers). (Commit cd8f3d67ea9) ### §2 DataWriter: get_topic

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 63 (dds-1.2.pdf), Tabelle DataWriter — “get_topic: Topic”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic

Status: done — DataWriterImpl.getTopic liefert das Topic aus dem Konstruktor; PublisherImpl.lookupDataWriter nutzt es. Test: PublisherOperationsTest::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic (assertSame). (Commit a2a9a67acb5) ### §2 DataWriter: get_publisher

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 63 (dds-1.2.pdf), Tabelle DataWriter — “get_publisher: Publisher”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic

Status: done — DataWriterImpl.getParent liefert den Publisher, den PublisherImpl.createDataWriter an den Konstruktor übergibt. Test: PublisherOperationsTest::aPublisherKnowsItsParticipantAndItsWritersTheirPublisherAndTopic (assertSame). (Commit a2a9a67acb5) ### §2 DataWriter: assert_liveliness

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 63 (dds-1.2.pdf), Tabelle DataWriter — “assert_liveliness: ReturnCode_t”

Status: done — DataWriterImpl.assertLiveliness setzt den Writer lebendig und erneuert die Lease; bei LIVELINESS MANUAL_BY_PARTICIPANT erneuert sie die Lease aller Writer dieser Art im Participant; auf einem geschlossenen Writer ist sie AlreadyClosedException. Tests: WriterStatusTest::assertLivelinessOfTheWriterKeepsALeaseFromRunningOut (Lease 1500 ms, alle 20 ms erneuert über 3 s: kein Verlust; danach Verlust), ::aWriterThatDoesNotAssertItsLivelinessLosesItOnceAndAssertingRestoresIt. (Commit cd8f3d67ea9) ### §2 DataWriter: get_matched_subscription_data

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 63, §7.1.2.4.2.23, S. 70 (dds-1.2.pdf) — “get_matched_subscription_data (inout: subscription_data: SubscriptionBuiltinTopicData, subscription_handle: InstanceHandle_t): ReturnCode_t”

Status: done — Die Methode liefert die Builtin-Daten eines verbundenen Readers (lokal aus dem Reader, entfernt aus der SEDP-Ankündigung). Der erste Test erwartet Topicname “Chatter” und das UserData des Readers und IllegalArgumentException für einen Handle, der keine verbundene Subscription ist; der zweite erwartet IllegalArgumentException für null. Der Zweig für entfernte Reader hat in diesen Tests keinen Aufruf. (Commit a2a9a67acb5) ### §2 DataWriter: get_matched_subscriptions

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.2, S. 63 (dds-1.2.pdf), Tabelle DataWriter — “get_matched_subscriptions (inout: subscription_handles: InstanceHandle_t []): ReturnCode_t”

Status: done — Die Methode liefert die Handles der lokalen verbundenen Reader und der Reader über die RTPS-Strecke. Die Tests erwarten Größe 1 mit einem Handle, den getMatchedSubscriptionData auflöst, Größe 0 nach dem Schließen des Readers und Größe 1 je Writer für die Reader eines MultiTopic-Joins. Der Zweig für entfernte Reader hat in diesen Tests keinen Aufruf. (Commit a2a9a67acb5)

§2 Programmierschnittstellen von [DDS] 1.2: DataWriterListener

§2 DataWriterListener: on_liveliness_lost

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.4, S. 72 (dds-1.2.pdf), Tabelle DataWriterListener — “on_liveliness_lost (the_writer: DataWriter, status: LivelinessLostStatus): void”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::livelinessLostFiresWithoutPolling

Status: done — DataWriterListener deklariert onLivelinessLost(LivelinessLostEvent); evaluateLiveliness ruft es außerhalb des Writer-Monitors, wenn die Lease eines MANUAL_BY_TOPIC-Writers abläuft. Der Test schreibt einmal, bestätigt nicht mehr und erwartet innerhalb von 5 s den Callback mit total_count >= 1 ohne Abfrage des Status. (Commit a2a9a67acb5) ### §2 DataWriterListener: on_offered_deadline_missed

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.4, S. 72 (dds-1.2.pdf), Tabelle DataWriterListener — “on_offered_deadline_missed (the_writer: DataWriter, status: OfferedDeadlineMissedStatus): void”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::offeredDeadlineMissedFiresWithoutPolling

Status: done — DataWriterListener deklariert onOfferedDeadlineMissed(OfferedDeadlineMissedEvent); evaluateOfferedDeadline ruft es außerhalb des Writer-Monitors. Der Test schreibt einmal bei 30 ms Deadline und erwartet innerhalb von 5 s den Callback mit total_count >= 1 ohne Abfrage des Status. (Commit a2a9a67acb5) ### §2 DataWriterListener: on_offered_incompatible_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.4, S. 72 (dds-1.2.pdf), Tabelle DataWriterListener — “on_offered_incompatible_qos (the_writer: DataWriter, status: OfferedIncompatibleQosStatus): void”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::anIncompatibleReaderIsCountedWithTheRefusedPolicy, crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::aWriterThatAWriterListenerTakesIsNotPassedUp

Status: done — DataWriterImpl.onReaderPresenceChanged ruft onOfferedIncompatibleQos des Listeners mit dem Status, wenn die vom Reader angefragte QoS unverträglich ist. Tests: WriterStatusTest::anIncompatibleReaderIsCountedWithTheRefusedPolicy (DataWriterAdapter überschreibt onOfferedIncompatibleQos), PublisherOperationsTest::aWriterThatAWriterListenerTakesIsNotPassedUp (nur der Writer-Listener wird gerufen). (Commit d23eff980f3) ### §2 DataWriterListener: on_publication_matched

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.4.4, S. 72 (dds-1.2.pdf), Tabelle DataWriterListener — “on_publication_matched (the_writer: DataWriter, status: PublicationMatchedStatus): void”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::writerListenerFiresOnPublicationMatched

Status: done — DataWriterListener deklariert onPublicationMatched(PublicationMatchedEvent); onReaderPresenceChanged ruft ihn beim Erscheinen und Verschwinden eines Readers. Der Test erwartet einen Aufruf je Ereignis (1 nach dem Reader, 2 nach dessen close), current_count 1 und danach 0, total_count 1 und als Quelle des Events den Writer selbst. (Commit a2a9a67acb5)

§2 Programmierschnittstellen von [DDS] 1.2: Subscriber

§2 Subscriber: create_datareader und delete_datareader

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.2, S. 80 (dds-1.2.pdf), Tabelle Subscriber — “create_datareader (a_topic: TopicDescription, qos: QosPolicy [], a_listener: DataReaderListener, mask: StatusKind []): DataReader; delete_datareader (a_datareader: DataReader): ReturnCode_t”

Status: done — createDataReader hat für jede TopicDescription die Formen ohne Argument, mit DataReaderQos und mit Listener und Statusmenge; der Listener wird vor enable gesetzt, sodass Match und Replay aus enable ihn erreichen. DataReaderImpl.close nimmt den Reader aus SubscriberImpl.readers und zieht ihn aus DCPSSubscription zurück (Close-Hook, SubscriberImpl.readerGone). Ein Reader auf einer ContentFilteredTopic oder einem MultiTopic hält die Beschreibung (SubscriberImpl.usedBy). Tests: ListenerPropagationTest::aReaderListenerSetAtCreationSeesTheMatchOfEnableAndTheSubscriberGetsDataOnReaders (Reader mit Listener, vorhandener Writer), ParticipantEntityTest::createSubscriberWithAListenerSeesTheMatchOfAReaderCreatedLater, CloseCleanupTest::aClosedWriterAndReaderAreNotListedOrFoundAnyMore, ContentFilterTest, MultiTopicTest. (Commit f31b6fa11b5) ### §2 Subscriber: lookup_datareader

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.2, S. 80 (dds-1.2.pdf), Tabelle Subscriber — “lookup_datareader (topic_name: string): DataReader”

Status: done — SubscriberImpl.lookupDataReader(String) und (TopicDescription) suchen in der Liste der erzeugten Reader nach dem Namen der TopicDescription des Readers (bei einem Reader auf einer ContentFilteredTopic deren Name); ein geschlossener Reader ist aus der Liste genommen. Tests: ParticipantSubscriberTest::lookupDataReaderFindsByNameByTopicAndByFilteredTopic (Fund, null für unbekannten Namen und für das Topic unter der ContentFilteredTopic, null nach close), CloseCleanupTest::aClosedWriterAndReaderAreNotListedOrFoundAnyMore. (Commit 28e25c198d1) ### §2 Subscriber: begin_access und end_access

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.2, S. 80–81 (dds-1.2.pdf), Tabelle Subscriber — “begin_access: ReturnCode_t; end_access: ReturnCode_t”

Status: done — SubscriberImpl.beginAccess hält eine ReentrantLock des Subscribers, die read und take der Reader ebenfalls nehmen; die Aufrufe verschachteln, ein Thread, der den Zugriff hält, liest ohne Warten, andere warten. endAccess ohne beginAccess ist PreconditionNotMetException (DDS 1.4 §2.2.2.5.2.9). Mit PRESENTATION access_scope GROUP lehnen read und take der Reader und getDataReaders des Subscribers außerhalb von begin_access mit PreconditionNotMetException ab (SubscriberImpl.checkGroupAccess); die Reader eines MultiTopic-Joins sind ausgenommen. Tests: ParticipantSubscriberTest::endAccessNeedsABeginAccessAndTheCallsNest, ::withAccessScopeGroupTheSamplesAreAccessedBetweenBeginAndEndAccessOnly, ::withTheDefaultAccessScopeNoBeginAccessIsNeeded, ::aReadOfAnotherThreadWaitsForEndAccess. (Commit cd8f3d67ea9) ### §2 Subscriber: get_datareaders

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.2, S. 81 (dds-1.2.pdf), Tabelle Subscriber — “get_datareaders (out: readers: DataReader [], sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind []): ReturnCode_t”

Status: done — getDataReaders(Collection) liefert die Reader des Subscribers, getDataReaders(Collection, DataState) die, die ein Sample in den gewählten Sample-, View- und Instance-Zuständen halten (DataReaderImpl.hasMatchingSample). Test: ParticipantSubscriberTest::getDataReadersWithADataStateListsTheReadersThatHoldSuchSamples (leer vor dem Write, nur der Reader des geschriebenen Topics danach, leer nach take; beide Reader ohne DataState), MultiTopicJoinTest::closingTheReaderEndsTheJoin. (Commit 819bfcb46cb) ### §2 Subscriber: notify_datareaders

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.2, S. 81 (dds-1.2.pdf), Tabelle Subscriber — “notify_datareaders: ReturnCode_t”

Status: done — SubscriberImpl.notifyDataReaders ruft an jedem Reader DataReaderImpl.notifyDataAvailable. Das ruft onDataAvailable des Reader-Listeners nur, wenn der Status DATA_AVAILABLE des Reader geändert ist (seit dem Eintreffen kein read/take) und geht nicht über den Listener des Subscribers. dataOnReadersGoesToTheSubscriberListener... nimmt an einem von zwei Readern ein Sample; nach notifyDataReaders zählt der andere Reader einen Aufruf, der erste keinen. Der zweite Test prüft, dass ein Reader nach read keinen Aufruf erhält. (Commit e1b55167947) ### §2 Subscriber: get_participant

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.2, S. 81 (dds-1.2.pdf), Tabelle Subscriber — “get_participant: DomainParticipant”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.getParent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::theParentOfASubscriberIsItsParticipantAndTheParentOfAReaderItsSubscriber

Status: done — SubscriberImpl.getParent gibt den DomainParticipant zurück, mit dem der Subscriber erzeugt wurde. Der Test erwartet mit assertSame den Participant, der den Subscriber erzeugt hat. (Commit 819bfcb46cb) ### §2 Subscriber: delete_contained_entities

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.2, S. 81 (dds-1.2.pdf), Tabelle Subscriber — “delete_contained_entities: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.closeContainedEntities)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::closeContainedEntitiesClosesTheReadersAndWithdrawsThemFromTheBuiltinTopic

Status: done — SubscriberImpl.closeContainedEntities ruft close() an jedem Reader; der Close-Hook des Readers entfernt ihn aus readers und ruft Discovery.readerClosed auf. Die Operation prüft jetzt mit ensureOpen, ob der Subscriber offen ist. Der Test beobachtet an einem zweiten Participant der Domäne den Built-in-Topic DCPSSubscription: nach dem Aufruf sind beide Reader geschlossen, getDataReaders ist leer, lookupDataReader liefert null, der Subscriber ist offen und es kommen zwei Samples ohne Daten mit NOT_ALIVE_NO_WRITERS. (Commit e1b55167947) ### §2 Subscriber: set_default_datareader_qos und get_default_datareader_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.2, S. 81 (dds-1.2.pdf), Tabelle Subscriber — “set_default_datareader_qos (qos_list: QosPolicy []): ReturnCode_t; get_default_datareader_qos (out: qos_list: QosPolicy []): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::theDefaultReaderQosIsWhatCreateDataReaderUses

Status: done — getDefaultDataReaderQos liefert vor dem Setzen die Standardwerte (HISTORY KEEP_LAST, Tiefe 1). Nach setDefaultDataReaderQos(q) hat der mit createDataReader(topic) erzeugte Reader dieses QoS (KEEP_ALL). (Commit 819bfcb46cb) ### §2 Subscriber: copy_from_topic_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.2, S. 81 (dds-1.2.pdf), Tabelle Subscriber — “copy_from_topic_qos (inout: a_datareader_qos: QosPolicy [], a_topic_qos: QosPolicy []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl.copyFromTopicQos)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::copyFromTopicQosReplacesThePoliciesTheTopicAndTheReaderShare

Status: done — SubscriberImpl.copyFromTopicQos ersetzt jede Policy des Reader-QoS, die das Topic-QoS auch hat (QosPolicy.ForDataReader), durch den Wert des Topic, auch wenn der Reader-Wert vom Standard abweicht (DDS 1.4 §2.2.2.5.2.17). Policies, die nur der Reader hat (UserData), bleiben, das übergebene QoS bleibt unverändert. Der Test setzt am Reader HISTORY KEEP_LAST 5 und DURABILITY TRANSIENT_LOCAL, am Topic KEEP_ALL und VOLATILE und erwartet die Werte des Topic. (Commit e1b55167947) ### §2 SubscriberListener: on_data_on_readers

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.6, S. 104 (dds-1.2.pdf), Tabelle SubscriberListener — “on_data_on_readers (the_subscriber: Subscriber): void”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::dataOnReadersGoesToTheSubscriberListenerAndNotifyDataReadersPassesItToTheReadersWithNewData

Status: done — DataReaderImpl.fireDataAvailable ruft, wenn der Subscriber (oder der DomainParticipant) einen Listener mit DATA_ON_READERS hat, onDataOnReaders mit einem DataOnReadersEventImpl (Quelle: der Subscriber) und nicht onDataAvailable des Readers. Der Subscriber hat das Status-Flag DATA_ON_READERS (SubscriberImpl.dataOnReadersChanged); der Aufruf des Listeners und read/take an einem Reader des Subscribers setzen es zurück. Der Test setzt einen SubscriberAdapter und zwei Reader-Listener und erwartet Aufrufe nur am Subscriber-Listener. (Commit e1b55167947)

§2 Programmierschnittstellen von [DDS] 1.2: DataReader

§2 DataReader: read

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 86 (dds-1.2.pdf), Tabelle DataReader — “read (inout: data_values: Data [], inout: sample_infos: SampleInfo [], max_samples: long, sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind []): ReturnCode_t”

Status: done — read(), read(int), read(Selector) (Sample.Iterator) und read(List), read(List, Selector) (Kopie in die Liste) wenden maxSamples und die drei Zustandsmengen in collectLocked an; read setzt die Samples auf READ. Mit DESTINATION_ORDER BY_SOURCE_TIMESTAMP stehen die Samples einer Instanz nach Zeitstempel geordnet (insertOrdered); mit PRESENTATION ordered_access und Scope TOPIC oder GROUP gibt collectLocked die Samples aller Instanzen in einer Reihenfolge nach (Zeitstempel, Eintreffen) zurück, maxSamples schneidet diese Reihenfolge. Getestet sind das Verbleiben im Reader, READ beim zweiten read, Kopie, AlreadyClosedException, Inhaltsfilter, read(int), maxSamples, die Zustandsmengen, der Inhalt des Iterators und beide Reihenfolgen. (Commit e1b55167947) ### §2 DataReader: take

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 86 (dds-1.2.pdf), Tabelle DataReader — “take (inout: data_values: Data [], inout: sample_infos: SampleInfo [], max_samples: long, sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind []): ReturnCode_t”

Status: done — take in den vier Formen entfernt die gelieferten Samples aus dem Reader. Eine Instanz ohne lebende Writer und ohne Samples wird aus instances entfernt (DataReaderImpl.reclaim, DDS 1.4 §2.2.2.5.1.8); lookupInstance liefert danach den NIL-Handle, ein späteres Sample ist eine nie gesehene Instanz. Eine Instanz NOT_ALIVE_DISPOSED bleibt es, wenn der letzte Writer sich abmeldet. Getestet sind Reihenfolge, Entfernen, take(int)/maxSamples, Zustandsmengen, Iterator-Form und das Vergessen der Instanz. (Commit e1b55167947) ### §2 DataReader: Zustandsmasken bei read und take

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 86 (dds-1.2.pdf), Tabelle DataReader — “sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind []”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDataStateSelectsOnSampleViewAndInstanceStates

Status: done — read/take tragen die Masken über Selector.dataState(Subscriber.DataState); collectLocked filtert nach sampleStates, viewStates und instanceStates (ohne dataState alle, getDataState() liefert dann DataStateImpl.any). Der Test bringt acht Reader in denselben Zustand (Instanz 1 gelesen, Instanz 3 disposed, Instanz 2 unberührt) und fragt je einen mit READ, NOT_READ, NOT_NEW, NEW, NOT_ALIVE_DISPOSED, ALIVE und NOT_ALIVE_NO_WRITERS ab (erwartete Anzahlen aus dem Zustand abgeleitet) sowie take mit READ. (Commit e1b55167947) ### §2 DataReader: read_w_condition und take_w_condition

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 86 (dds-1.2.pdf), Tabelle DataReader — “read_w_condition (inout: data_values: Data [], inout: sample_infos: SampleInfo [], max_samples: long, a_condition: ReadCondition): ReturnCode_t; take_w_condition (…): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.collectLocked), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.getCondition), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl.condition)

Status: done — SelectorImpl.condition(ReadCondition) (Erweiterung von ZeroDDS, nicht in DataReader.Selector) bindet eine Bedingung des Readers an den Selector; getCondition() liefert sie. collectLocked schneidet deren Zustandsmengen und, bei einer QueryCondition, deren Ausdruck mit den aktuellen Parametern mit den übrigen Vorgaben des Selectors. Eine Bedingung eines anderen Readers ergibt PreconditionNotMetException, eine geschlossene AlreadyClosedException. Getestet für read und take. (Commit e1b55167947) ### §2 DataReader: read_next_sample und take_next_sample

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 86 (dds-1.2.pdf), Tabelle DataReader — “read_next_sample (inout: data_value: Data, inout: sample_info: SampleInfo): ReturnCode_t; take_next_sample (inout: data_value: Data, inout: sample_info: SampleInfo): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::readNextSampleReturnsTheNextSampleNotYetReadAndTakeNextSampleRemovesIt

Status: done — readNextSample und takeNextSample wählen mit einem Selector mit maxSamples(1) und SampleState NOT_READ (DataReaderImpl.nextSampleSelector), kopieren das Ergebnis per copyInto in das übergebene SampleImpl und liefern false ohne Sample (das übergebene Sample bleibt dann unverändert). Der Test ruft readNextSample dreimal auf: zwei verschiedene Samples, dann false; takeNextSample entfernt das Sample. (Commit e1b55167947) ### §2 DataReader: read_instance und take_instance

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 87 (dds-1.2.pdf), Tabelle DataReader — “read_instance (…, a_handle: InstanceHandle_t, sample_states, view_states, instance_states): ReturnCode_t; take_instance (…): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::anInstanceHandleLimitsReadAndTakeToThatInstance

Status: done — select().instance(handle) begrenzt read/take auf die Instanz mit diesem Handle (Vergleich in collectLocked). Ein Handle ohne Instanz ergibt eine leere Sammlung (die Spec lässt BAD_PARAMETER zu, verlangt es nicht). Der Test liest und nimmt die zwei Samples der Instanz 2 von drei Instanzen; die Samples tragen deren Handle, take entfernt nur diese. (Commit e1b55167947) ### §2 DataReader: read_next_instance und take_next_instance

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 87 (dds-1.2.pdf), Tabelle DataReader — “read_next_instance (…, previous_handle: InstanceHandle_t, sample_states, view_states, instance_states): ReturnCode_t; take_next_instance (…): ReturnCode_t”

Status: done — Mit Selector.nextInstance(true) liefert collectLocked die Samples der Instanz mit dem kleinsten Handle, der größer als der von instance(h) ist (ohne instance ab dem kleinsten) und die passende Samples hat, und nur dieser Instanz. Die Handles sind nach InstanceHandle.compareTo (vorzeichenlos Byte für Byte) geordnet. Der Test schreibt die Schlüssel 3, 1, 2 und durchläuft sie als 1, 2, 3, danach leer; take nimmt nur die erste Instanz; Instanzen ohne Sample im gewählten Zustand werden übersprungen. (Commit e1b55167947) ### §2 DataReader: read_next_instance_w_condition und take_next_instance_w_condition

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 88 (dds-1.2.pdf), Tabelle DataReader — “read_next_instance_w_condition (…, previous_handle: InstanceHandle_t, a_condition: ReadCondition): ReturnCode_t; take_next_instance_w_condition (…): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::aQueryConditionOfTheReaderSelectsByItsExpressionAndTheNextInstanceKeepsIt

Status: done — Bedingung und vorheriger Handle lassen sich in einem Selector verbinden: condition(c).instance(h).nextInstance(true). Der Test liest mit einer QueryCondition “seq > %0” ab Instanz 1 und erhält die Samples der Instanz 2 mit seq 1; geänderte Parameter ändern das Ergebnis; take mit der Bedingung entfernt nur die gewählten Samples. (Commit e1b55167947) ### §2 DataReader: return_loan

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 88 (dds-1.2.pdf), Tabelle DataReader — “return_loan (inout: data_values: Data [], inout: sample_infos: SampleInfo []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleIterator.java (SampleIterator.close)

Status: done — Sample.Iterator.close() bildet return_loan ab (SampleIterator.close); der Aufruf wirft nichts, auch beim zweiten Mal (Closeable). read und take kopieren die Daten (deepCopy), es wird nichts verliehen; die Samples bleiben nach close lesbar. Der Name returnLoan ist in der OMG-API nicht vorhanden (close()). (Commit e0f89cfd194) ### §2 DataReader: get_key_value

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 88 (dds-1.2.pdf), Tabelle DataReader — “get_key_value (inout: key_holder: Data, handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getKeyValue)

Status: done — Der Reader hält je Instanz ein Sample (Instance.keyData). getKeyValue(keyHolder, handle) setzt bei einem Typ der Java-Typdarstellung (ReflectionTypeSupport) die Schlüsselfelder des Halters und lässt die übrigen; bei einem Typ ohne schreibbare Felder (Record, handgeschriebene Unterstützung) ist das Ergebnis eine Kopie dieses Samples statt des Halters. Ein unbekannter oder null-Handle ergibt IllegalArgumentException, ein Typ ohne Schlüssel PreconditionNotMetException. getKeyValue(InstanceHandle) liefert die Kopie. (Commit e1b55167947) ### §2 DataReader: lookup_instance

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 88 (dds-1.2.pdf), Tabelle DataReader — “lookup_instance (instance: Data): InstanceHandle_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.lookupInstance)

Status: done — lookupInstance(T) liefert den Handle einer bekannten Instanz (gleich Sample.getInstanceHandle()) oder den NIL-Handle, vor dem ersten Sample und nach dem Vergessen der Instanz (reclaim). lookupInstance(handle, key) füllt den übergebenen Handle, bei null liefert es ein neues Objekt; ein null-Schlüssel ergibt IllegalArgumentException. (Commit e1b55167947) ### §2 DataReader: create_readcondition

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 88 (dds-1.2.pdf), Tabelle DataReader — “create_readcondition (sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind []): ReadCondition”

Status: done — createReadCondition(DataState) liefert eine ReadConditionImpl mit den Zustandsmengen zum Zeitpunkt des Erzeugens (Kopie); der Triggerwert ist wahr, solange der Reader ein Sample in diesen drei Mengen hält (anySample). aReadConditionIsTrueWhileTheReaderHoldsASampleInItsStates prüft an einem WaitSet NOT_READ und READ: leer falsch (Timeout), nach write wahr (die Bedingung steht in der aktiven Menge), nach read wechseln die Werte, nach take falsch. Die Bedingung wird im Reader geführt und von close/closeContainedEntities geschlossen. (Commit e1b55167947) ### §2 DataReader: create_querycondition

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 88 (dds-1.2.pdf), Tabelle DataReader — “create_querycondition (sample_states: SampleStateKind [], view_states: ViewStateKind [], instance_states: InstanceStateKind [], query_expression: string, query_parameters: string []): QueryCondition”

Status: done — Beide Überladungen von createQueryCondition sind vorhanden. Der Triggerwert ist wahr, wenn ein Sample sowohl in den Zustandsmengen liegt als auch den Ausdruck erfüllt (anySample(state, predicate)); ein Sample ohne Daten erfüllt keinen Ausdruck. Der Test (Überladung mit DataState) hat ein gelesenes Sample, das den Ausdruck nicht erfüllt, und ein ungelesenes, das ihn erfüllt: Trigger falsch, nach read wahr. (Commit e1b55167947) ### §2 DataReader: delete_readcondition

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 88 (dds-1.2.pdf), Tabelle DataReader — “delete_readcondition (a_condition: ReadCondition): ReturnCode_t”

Status: done — Der Reader führt seine Bedingungen (DataReaderImpl.register); ReadConditionImpl.close entfernt die Bedingung dort und markiert sie als geschlossen, ein zweites close hat keine Wirkung. getTriggerValue und QueryCondition.setQueryParameters an einer geschlossenen Bedingung ergeben AlreadyClosedException, ein WaitSet überspringt sie. Eine Bedingung, die nicht zu diesem Reader gehört (PRECONDITION_NOT_MET), kann close() nicht ausdrücken; der Selector meldet sie (siehe das Item zu read_w_condition). (Commit e1b55167947) ### §2 DataReader: get_liveliness_changed_status

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89 (dds-1.2.pdf), Tabelle DataReader — “get_liveliness_changed_status (out: status: LivelinessChangedStatus): ReturnCode_t”

Status: done — alive_count, not_alive_count und beide Änderungswerte werden aus den Writern im selben Prozess (matchedWriters: PARTITION überlappt, QoS verträglich; countLivelinessLocked) und aus den verbundenen Writern anderer Prozesse berechnet. Ein entfernter Writer lebt, solange die Zeit seit dem letzten Lebenszeichen innerhalb der Lease liegt, die er in SEDP angekündigt hat; ohne angekündigte Lebendigkeit gilt AUTOMATIC mit unendlicher Lease. Lebenszeichen sind ein DATA des Writers, ein HEARTBEAT mit dem L-Flag (DDSI-RTPS 2.5 §8.3.7.5; DataWriter.assertLiveliness und die Zusicherung der Participant-Ebene für MANUAL_BY_PARTICIPANT senden ihn an die verbundenen Reader) und bei AUTOMATIC jede Nachricht seines Participants (SPDP). Der Reader erfährt, wenn ein Writer nach Ablauf der Lease wieder lebt (WireReader.setLivelinessListener), und löst onLivelinessChanged aus. Nicht gebaut sind die eingebauten Endpunkte des Writer Liveliness Protocol (DCPSParticipantMessage, §8.4.13); ZeroDDS kündigt sie in SPDP nicht an, ein fremder Participant schickt sie deshalb nicht. Erwartung: Cyclone DDS, Fast DDS und OpenDDS halten AUTOMATIC-Writer über SPDP am Leben und werten das L-Flag des HEARTBEAT; MANUAL_BY_PARTICIPANT eines fremden Writers erreicht ZeroDDS nur über DATA und HEARTBEAT. (Commit 16f61d4789d) ### §2 DataReader: last_publication_handle von LIVELINESS_CHANGED

Spec: §2, S. 11; [DDS] 1.2 IDL, S. 159–160 (dds-1.2.pdf) — “struct LivelinessChangedStatus { […] InstanceHandle_t last_publication_handle; };”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getLivelinessChangedStatus), crates/java-omgdds/java/src/main/java/org/omg/dds/core/status/LivelinessChangedStatus.java (LivelinessChangedStatus.getLastPublicationHandle)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::livelinessChangedNamesTheWriterWhoseLivelinessChangedAndCountsTheChanges

Status: done — last_publication_handle von LIVELINESS_CHANGED ist der Handle des Writers, dessen Lebendigkeit sich zuletzt geändert hat (DataReaderImpl.lastLivelinessHandle, gesetzt in countLivelinessLocked beim Wechsel von isAlive und in onWriterPresenceChanged beim Verschwinden); getLivelinessChangedStatus und evaluateLiveliness geben ihn weiter. Der Test erwartet bei Erscheinen und bei Ablauf des Lease writer.getInstanceHandle(). (Commit e1b55167947) ### §2 DataReader: get_requested_deadline_missed_status

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89 (dds-1.2.pdf), Tabelle DataReader — “get_requested_deadline_missed_status (out: status: RequestedDeadlineMissedStatus): ReturnCode_t”

Status: done — Die Versäumnisse werden je Instanz aus der Wanduhr berechnet (je abgelaufener Periode einmal, ab dem Eintreffen des letzten Samples) und vom Lease des Readers asynchron gemeldet. Getestet: total_count und total_count_change, Ausbleiben bei unendlicher Periode, onRequestedDeadlineMissed, last_instance_handle bei zwei Instanzen (gleich dem Handle der Instanz 2, auf die gewartet wird) und der Änderungswert 0 beim zweiten Lesen (Periode 1500 ms, der nächste Ablauf liegt weit nach dem Lesen). (Commit e1b55167947) ### §2 DataReader: get_requested_incompatible_qos_status

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89 (dds-1.2.pdf), Tabelle DataReader — “get_requested_incompatible_qos_status (out: status: RequestedIncompatibleQosStatus): ReturnCode_t”

Status: done — Beim Verbinden prüft der Reader die angebotene QoS mit QosCompatibility.incompatiblePoliciesWith: Reliability, Durability, Deadline, Liveliness, Ownership, DestinationOrder, LatencyBudget und PRESENTATION (die Policy des Subscribers, vom Reader gefordert, die des Publishers, vom Writer angeboten: Scope niedriger oder coherent/ordered nicht angeboten). Bei Unverträglichkeit entsteht kein Match und keine Zustellung; eine Verbindung zählt einmal in total_count und je verweigernder Policy einmal im QosPolicyCount; last_policy_id ist eine davon. onRequestedIncompatibleQos wird aufgerufen. Getestet: eine und drei Policies, die Rücksetzung der Änderung, PRESENTATION, der Listener. (Commit d17c5f0c379) ### §2 DataReader: get_sample_lost_status

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89 (dds-1.2.pdf), Tabelle DataReader — “get_sample_lost_status (out: status: SampleLostStatus): ReturnCode_t”

Status: done — DataReaderImpl.noteSequence vergleicht die Sequenznummer eines Samples vom RTPS-Pfad (deliverWire) je Writer-GUID mit der zuletzt gesehenen; eine Lücke zählt in lostTotal, getSampleLostStatus meldet Gesamtzahl und Änderung und setzt die Änderung zurück, onSampleLost wird aufgerufen. Der Test liefert Sequenznummern 1, 4, 5 eines Writers und 10 eines zweiten: Gesamtzahl 2, Änderung 2, danach 0. Der Bus im Prozess verliert keine Samples. (Commit e1b55167947) ### §2 DataReader: get_sample_rejected_status

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89 (dds-1.2.pdf), Tabelle DataReader — “get_sample_rejected_status (out: status: SampleRejectedStatus): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aSampleBeyondMaxSamplesIsRejectedAndReportedToTheListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderLimitsTest.java::aSampleOfANewInstanceBeyondMaxInstancesIsRejectedWithThatReasonAndInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderLimitsTest.java::aSampleBeyondMaxSamplesPerInstanceIsRejectedWithThatReasonAndInstance

Status: done — DataReaderImpl.rejectedByLimits wendet RESOURCE_LIMITS (max_samples, max_instances, max_samples_per_instance) an, zählt total_count, setzt Grund und Instanz und löst onSampleRejected aus. Getestet: alle drei Gründe mit last_reason und last_instance_handle (der Handle des Schlüssels aus den 16 Oktetten von Hand abgeleitet), der Änderungswert und der Listener. (Commit e1b55167947) ### §2 DataReader: get_subscription_matched_status

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89 (dds-1.2.pdf), Tabelle DataReader — “get_subscription_matched_status (out: status: SubscriptionMatchedStatus): ReturnCode_t”

Status: done — total_count, current_count und beide Änderungswerte werden mit dem Verbinden und Lösen von Writern geführt; Writer mit nicht überlappender PARTITION oder unverträglicher QoS zählen nicht; last_publication_handle ist der Handle des zuletzt verbundenen oder gelösten Writers. Die Tests prüfen Zählungen, Änderungen, Listener-Ereignisse und die Handles. (Commit e1b55167947) ### §2 DataReader: last_publication_handle von SUBSCRIPTION_MATCHED

Spec: §2, S. 11; [DDS] 1.2 IDL, S. 160–161 (dds-1.2.pdf) — “struct SubscriptionMatchedStatus { […] InstanceHandle_t last_publication_handle; };”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.readSubscriptionMatchedStatusLocked)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::subscriptionMatchedNamesTheWriterThatConnectedOrLeftLast

Status: done — readSubscriptionMatchedStatusLocked übergibt DataReaderImpl.lastMatchedHandle: den Handle (WriterPresence.writerHandle) des Writers, der zuletzt verbunden oder gelöst wurde. Der Test erwartet nach dem ersten Writer, dem zweiten und nach dem Schließen des ersten jeweils dessen getInstanceHandle() und prüft, dass getMatchedPublications die Handles enthält. (Commit e1b55167947) ### §2 DataReader: get_topicdescription

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89 (dds-1.2.pdf), Tabelle DataReader — “get_topicdescription: TopicDescription”

Status: done — getTopicDescription liefert die Beschreibung, mit der der Reader erzeugt wurde: bei ContentFilteredTopic und MultiTopic setzt SubscriberImpl.createDataReader sie über describedBy, sonst das Topic. Getestet sind Topic, ContentFilteredTopic (assertSame) und MultiTopic. (Commit a2a9a67acb5) ### §2 DataReader: get_subscriber

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89 (dds-1.2.pdf), Tabelle DataReader — “get_subscriber: Subscriber”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getParent)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::theParentOfASubscriberIsItsParticipantAndTheParentOfAReaderItsSubscriber

Status: done — DataReaderImpl.getParent gibt den Subscriber zurück, der den Reader erzeugt hat. Der Test erwartet ihn mit assertSame. (Commit a2a9a67acb5) ### §2 DataReader: delete_contained_entities

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89 (dds-1.2.pdf), Tabelle DataReader — “delete_contained_entities: ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.closeContainedEntities)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::closeContainedEntitiesClosesTheConditionsOfTheReaderAndNotTheReader

Status: done — DataReaderImpl.closeContainedEntities schließt alle mit createReadCondition/createQueryCondition erzeugten Bedingungen des Readers (Liste conditions); der Reader bleibt offen und kann neue Bedingungen erzeugen. Der Test prüft AlreadyClosedException an beiden Bedingungen, danach Schreiben, Lesen und eine neue Bedingung. (Commit e1b55167947) ### §2 DataReader: wait_for_historical_data

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89 (dds-1.2.pdf), Tabelle DataReader — “wait_for_historical_data (max_wait: Duration_t): ReturnCode_t”

Status: done — Im selben Prozess gehen die Samples eines TRANSIENT_LOCAL-Writers in enable() an den Reader (replayTo); beide Überladungen von waitForHistoricalData kehren dann sofort zurück, ein negativer Wert ergibt IllegalArgumentException. Beim RTPS-Reader mit nicht-VOLATILE Durability wartet der Aufruf auf WireReader.historicalDataReceived: jeder verbundene zuverlässige, nicht-VOLATILE entfernte Writer hat per HEARTBEAT seine letzte Sequenznummer gemeldet, der Reader hat bis dahin empfangen, und keine empfangene Nachricht ist noch auf dem Weg zum Reader (deliveriesInFlight). Nach Ablauf von maxWait folgt TimeoutException. Die beiden RTPS-Zweige sind mit einem zweiten RTPS-Teilnehmer getestet. (Commit 1d0691890fa) ### §2 DataReader: get_matched_publication_data

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89, §7.1.2.5.3.33, S. 102 (dds-1.2.pdf) — “get_matched_publication_data (inout: publication_data: PublicationBuiltinTopicData, publication_handle: InstanceHandle_t): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getMatchedPublicationData)

Status: done — Für einen Writer im selben Prozess liefert getMatchedPublicationData die Built-in-Daten des Writers, für einen entfernten Writer die der SEDP-Meldung; ein unbekannter Handle wirft IllegalArgumentException. Der Test mit einem Writer eines zweiten RTPS-Teilnehmers prüft Topic-Name, Typname und OwnershipStrength der SEDP-Meldung; der Test am lokalen Writer prüft Topic-Name, Durability, OwnershipStrength und die Ausnahme für den NIL-Handle. (Commit 447490d2b6d) ### §2 DataReader: get_matched_publications

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.3, S. 89 (dds-1.2.pdf), Tabelle DataReader — “get_matched_publications (inout: publication_handles: InstanceHandle_t []): ReturnCode_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.getMatchedPublications)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::theMatchedEntitiesAreDescribedWithTheirQos, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::subscriptionMatchedNamesTheWriterThatConnectedOrLeftLast, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::aWriterInAnotherPartitionOrWithLessQosThanRequestedIsNotMatched

Status: done — getMatchedPublications liefert die Handles der verbundenen Writer im Prozess (matchedWriters mit writerHandle()) und der über RTPS verbundenen (wire.matchedEndpoints). Getestet: Größe 1, Verwendung des Elements in getMatchedPublicationData, die Menge schrumpft nach writer.close(), ein Writer in anderer Partition und einer mit unverträglicher QoS fehlen darin. Writer über RTPS sind ungetestet. (Commit e1b55167947)

§2 Programmierschnittstellen von [DDS] 1.2: SampleInfo

§2 SampleInfo: sample_state

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103, §7.1.2.5.1.2, S. 75 (dds-1.2.pdf) — “sample_state: SampleStateKind”; “READ indicates that the DataReader has already accessed that sample by means of read.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SampleStateTest.java::readMarksSamplesRead

Status: done — toSample liefert den Zustand des Samples vor dem Zugriff und setzt es danach im Reader auf READ. Der Test liest dasselbe Sample zweimal und erwartet NOT_READ beim ersten, READ beim zweiten Mal. Die Angabe „immer NOT_READ“ gilt nicht mehr. (Commit a2a9a67acb5) ### §2 SampleInfo: view_state

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103, §7.1.2.5.1.8, S. 77 (dds-1.2.pdf) — “view_state: ViewStateKind”; “NEW indicates that either this is the first time that the DataReader has ever accessed samples of that instance […] The view_state is therefore the same for all samples in the returned collection that refer to the same instance.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.toSample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.collectLocked), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getViewState)

Status: done — view_state ist je Instanz einmal beim Zusammenstellen der Sammlung festgehalten (Pick.view); NOT_NEW wird erst nach der Sammlung gesetzt. Der Test (KEEP_ALL, zwei write, ein read): beide Samples NEW und NOT_READ, beim zweiten read NOT_NEW und READ; eine nach dispose neu belebte Instanz ist wieder NEW. (Commit e1b55167947) ### §2 SampleInfo: instance_state

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103 (dds-1.2.pdf), Tabelle SampleInfo — “instance_state: InstanceStateKind”

Status: done — Der Reader führt ALIVE, NOT_ALIVE_DISPOSED und NOT_ALIVE_NO_WRITERS je Instanz (Instance.state); onMessage setzt sie bei dispose, unregister und write. Die Tests prüfen NOT_ALIVE_DISPOSED nach dispose, NOT_ALIVE_NO_WRITERS nach unregister und nach dem Schließen des letzten Writers (nicht, solange ein zweiter Writer schreibt) und ALIVE nach erneutem write. Die Snapshot-Eigenschaft steht im folgenden Item. (Commit a2a9a67acb5) ### §2 SampleInfo: instance_state als Zustand beim Lesen

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.1.3, S. 75 (dds-1.2.pdf) — “The instance_state available in the SampleInfo is a snapshot of the instance_state of the instance at the time the collection was obtained (i.e., at the time read or take was called). The instance_state is therefore the same for all samples in the returned collection that refer to the same instance.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SampleStateTest.java::disposeSnapshotsInstanceStateForAllSamples

Status: done — toSample liest instance_state aus dem Zustand der Instanz zum Zeitpunkt von read/take, nicht aus dem Zeitpunkt des Eintreffens. Der Test (KEEP_ALL) schreibt zwei Samples, ruft dispose auf und erwartet in allen drei gelieferten Samples NOT_ALIVE_DISPOSED. Die Angabe „Daten-Sample mit ALIVE“ gilt nicht mehr. (Commit a2a9a67acb5) ### §2 SampleInfo: disposed_generation_count

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103 (dds-1.2.pdf), Tabelle SampleInfo — “disposed_generation_count: long”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::anInstanceDisposedAndWrittenAgainCountsADisposedGeneration

Status: done — Die Instanz führt disposedGeneration; onWrite erhöht den Zähler, wenn die Instanz von NOT_ALIVE_DISPOSED auf ALIVE wechselt; jedes Sample trägt den Zähler zum Zeitpunkt des Eintreffens und SampleImpl.of gibt ihn weiter. Der Test: write, dispose, write ergibt 0, 0 (Sample ohne Daten) und 1. (Commit e1b55167947) ### §2 SampleInfo: no_writers_generation_count

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103 (dds-1.2.pdf), Tabelle SampleInfo — “no_writers_generation_count: long”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSampleInfoTest.java::anInstanceWithoutWritersWrittenAgainCountsANoWritersGeneration

Status: done — Die Instanz führt noWritersGeneration; onWrite erhöht den Zähler beim Wechsel von NOT_ALIVE_NO_WRITERS auf ALIVE. Der Test: write, unregister, write ergibt 0, 0 und 1. (Commit e1b55167947) ### §2 SampleInfo: sample_rank

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103 (dds-1.2.pdf), Tabelle SampleInfo — “sample_rank: long”

Status: done — collectLocked zählt nach der Auswahl je Sample die folgenden Samples derselben Instanz in der Sammlung (sample_rank). Getestet: zwei Instanzen mit je zwei Samples (1, 0, 1, 0), drei Samples einer Instanz (2, 1, 0), eine auf ein Sample gekürzte Sammlung (0) und die Reihenfolge über Instanzen bei ordered_access. (Commit e1b55167947) ### §2 SampleInfo: generation_rank

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103 (dds-1.2.pdf), Tabelle SampleInfo — “generation_rank: long”

Status: done — generation_rank ist die Summe der Generationszähler des letzten Samples der Instanz in der Sammlung minus die des Samples (DDS 1.4 §2.2.2.5.1.6). Die Tests erwarten 1, 1, 0 für die Samples vor, bei und nach der Wiederbelebung. (Commit e1b55167947) ### §2 SampleInfo: absolute_generation_rank

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103 (dds-1.2.pdf), Tabelle SampleInfo — “absolute_generation_rank: long”

Status: done — absolute_generation_rank ist die Summe der Generationszähler der Instanz im Reader (das jüngste empfangene Sample) minus die des Samples. Der erste Test erwartet 1, 1, 0; der zweite, dass eine vergessene und neu begonnene Instanz wieder 0 hat. (Commit e1b55167947) ### §2 SampleInfo: source_timestamp

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103 (dds-1.2.pdf), Tabelle SampleInfo — “source_timestamp: Time_t”

Status: done — Im Prozess übernimmt der Reader den Zeitstempel des Writers (Message.sourceTimestampMillis). Über RTPS liest RtpsMessage.decode den INFO_TS vor DATA und DATA_FRAG (Time_t, Bruchteil in 2^-32 s; InvalidateFlag), SerializedSample.sourceTimestampMillis trägt ihn bis deliverWire; ohne INFO_TS gilt die Ankunftszeit. Getestet: beide Schreibformen im Prozess, der Wert 77000 über deliverWire, die Dekodierung 1700000000 s + 0x80000000/2^32 s = 1700000000500 ms (von Hand abgeleitet) und das Fehlen (-1). Der sendende Teil des Java-Teilnehmers schreibt den Zeitstempel der Anwendung nicht in INFO_TS. (Commit e1b55167947) ### §2 SampleInfo: instance_handle

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103 (dds-1.2.pdf), Tabelle SampleInfo — “instance_handle: InstanceHandle_t”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.onWrite), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.toSample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getInstanceHandle), crates/java-omgdds/java/src/main/java/org/zerodds/internal/InstanceKey.java (InstanceKey.toHandle)

Status: done — InstanceKey.toHandle bildet einen Schlüssel bis 16 Oktette auf diese Oktette (null aufgefüllt), einen längeren auf seinen MD5-Wert ab (DDSI-RTPS 2.5 §9.6.3.8); zwei Schlüssel, die der frühere XOR-Fold gleich abbildete, haben verschiedene Handles. Getestet: Sample-Handle gleich Reader.lookupInstance und Writer.lookupInstance, zwei 17-Oktett-Schlüssel mit gleichem Fold, die verschiedene Handles ergeben. (Commit e0f89cfd194) ### §2 SampleInfo: publication_handle

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103 (dds-1.2.pdf), Tabelle SampleInfo — “publication_handle: InstanceHandle_t”

Status: done — Im Prozess ist publication_handle der Handle des Writers (gleich einem Element von getMatchedPublications). Über RTPS bildet deliverWire ihn aus der Writer-GUID der DATA (Values.of(guid), wie getMatchedPublications die Endpoint-GUID nennt); ohne Identität ist er NIL. (Commit e1b55167947) ### §2 SampleInfo: valid_data

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.5, S. 103, §7.1.2.5.1.4, S. 76 (dds-1.2.pdf) — “valid_data: boolean”; “If the flag is set to FALSE, the DataSample contains no Data.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicJoinTest.java::disposingAConstituentDisposesTheResultInstance

Status: done — markState legt für dispose und unregister ein Sample ohne Daten an; Sample.getData() ist dann null (§7.7.2). Der Test liest an einem MultiTopic-Reader (ein DataReaderImpl) nach dispose ein Sample mit getData() == null und NOT_ALIVE_DISPOSED. Die Angabe „kein Test prüft null“ gilt nicht mehr; der Pfad für unregister ist nicht eigens getestet. (Commit a2a9a67acb5)

§2 Programmierschnittstellen von [DDS] 1.2: DataReaderListener

§2 DataReaderListener: on_data_available

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.7, S. 105 (dds-1.2.pdf), Tabelle DataReaderListener — “on_data_available (the_reader: DataReader): void”

Status: done — fireDataAvailable setzt DATA_AVAILABLE (triggerStatus) und ruft onDataAvailable je eingetroffenem Sample und je Sample ohne Daten (dispose, unregister) mit dem Reader als Quelle. Hat der Subscriber (oder der DomainParticipant) einen Listener mit DATA_ON_READERS, geht der Aufruf stattdessen an dessen onDataOnReaders. Die Tests prüfen Anzahl, Quelle, das Ausbleiben nach setListener(null), dass der Aufruf den Monitor des Readers nicht hält, und dass eine StatusCondition auf DATA_AVAILABLE nach write wahr und nach take falsch ist. (Commit e1b55167947) ### §2 DataReaderListener: on_sample_rejected

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.7, S. 105 (dds-1.2.pdf), Tabelle DataReaderListener — “on_sample_rejected (the_reader: DataReader, status: SampleRejectedStatus): void”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aSampleBeyondMaxSamplesIsRejectedAndReportedToTheListener

Status: done — DataReaderImpl.onWrite ruft rejectedByLimits; ein abgelehntes Sample zählt in SampleRejectedStatusImpl, fireRejectedAndLost ruft onSampleRejected außerhalb des Monitors. ReaderStatusTest::aSampleBeyondMaxSamplesIsRejectedAndReportedToTheListener nutzt einen Reader mit max_samples=1: das zweite write löst den Aufruf mit Grund REJECTED_BY_SAMPLES_LIMIT aus, der Reader behält das erste Sample. (Commit a2a9a67acb5) ### §2 DataReaderListener: on_liveliness_changed

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.7, S. 105 (dds-1.2.pdf), Tabelle DataReaderListener — “on_liveliness_changed (the_reader: DataReader, status: LivelinessChangedStatus): void”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::livelinessChangedFiresWithoutPolling

Status: done — DataReaderImpl.evaluateLiveliness übergibt den Status außerhalb des Monitors an onLivelinessChanged, ausgelöst vom Lease des Readers, ohne dass die Anwendung den Status abfragt. Der Test setzt einen Listener, schreibt einmal an einen MANUAL_BY_TOPIC-Writer mit 30 ms Lease und wartet auf den Callback mit getNotAliveCount() >= 1. Die Zähler alive_count_change und not_alive_count_change prüft kein Test. (Commit a2a9a67acb5) ### §2 DataReaderListener: on_requested_deadline_missed

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.7, S. 105 (dds-1.2.pdf), Tabelle DataReaderListener — “on_requested_deadline_missed (the_reader: DataReader, status: RequestedDeadlineMissedStatus): void”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::requestedDeadlineMissedFiresWithoutPolling

Status: done — DataReaderImpl.fireDeadlineMissed ruft onRequestedDeadlineMissed mit dem Status außerhalb des Monitors auf, ausgelöst vom Lease, ohne Abfrage durch die Anwendung. Der Test schreibt ein Sample bei 30 ms Deadline und wartet auf den Callback mit getTotalCount() >= 1. Der Wert von last_instance_handle und total_count_change ist nicht geprüft. (Commit a2a9a67acb5) ### §2 DataReaderListener: on_requested_incompatible_qos

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.7, S. 105 (dds-1.2.pdf), Tabelle DataReaderListener — “on_requested_incompatible_qos (the_reader: DataReader, status: RequestedIncompatibleQosStatus): void”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aWriterThatOffersLessThanRequestedIsReportedToTheListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::requestedIncompatibleQosCountsTheRefusingPolicyAndResetsItsChange

Status: done — DataReaderImpl.onWriterPresenceChanged ruft onRequestedIncompatibleQos außerhalb des Monitors, wenn ein Writer mit unverträglicher QoS erscheint. Der Test mit RELIABLE-Reader und BEST_EFFORT-Writer erwartet einen Aufruf mit getLastPolicyClass() == Reliability.class und keinem verbundenen Writer. (Commit a2a9a67acb5) ### §2 DataReaderListener: on_subscription_matched

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.7, S. 105 (dds-1.2.pdf), Tabelle DataReaderListener — “on_subscription_matched (the_reader: DataReader, status: SubscriptionMatchedStatus): void”

Status: done — DataReaderImpl.onWriterPresenceChanged ruft onSubscriptionMatched beim Erscheinen und Verschwinden eines Writers mit dem Reader als Quelle und dem Status. Der erste Test prüft Aufrufzahl 1 bzw. 2, currentCount 1 bzw. 0, totalCount 1 und dass der Callback den eigenen Reader liefert. Der zweite prüft, dass ein Writer einer anderen Partition keinen Aufruf auslöst. (Commit a2a9a67acb5) ### §2 DataReaderListener: on_sample_lost

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.7, S. 105 (dds-1.2.pdf), Tabelle DataReaderListener — “on_sample_lost (the_reader: DataReader, status: SampleLostStatus): void”

Status: done — DataReaderImpl.deliverWire meldet über noteSequence und fireRejectedAndLost die Lücke in den Sequenznummern eines Writers an onSampleLost (außerhalb des Monitors). Der Test liefert die Sequenznummern 1 und 3 und erwartet einen Aufruf mit Gesamtzahl 1 und Änderung 1; eine ältere Sequenznummer löst keinen weiteren aus. (Commit e1b55167947)

§2 Programmierschnittstellen von [DDS] 1.2: Conditions und WaitSet

§2 Condition: get_trigger_value

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.7, S. 31–32 (dds-1.2.pdf), Tabelle Condition — “get_trigger_value: boolean”

Status: done — ReadConditionImpl.getTriggerValue (Zustandsmasken, bei der QueryCondition zusätzlich Ausdruck am selben Sample), StatusConditionImpl.getTriggerValue (geänderte Statusflags der aktivierten Statuses) und GuardConditionImpl.getTriggerValue sind getestet. (Commit e1b55167947) ### §2 WaitSet: Erzeugen ohne Factory

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.6, S. 30 (dds-1.2.pdf) — “WaitSet has no factory. It is created as an object directly by the natural means in each language binding (e.g., using “new” in C++ or Java).”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories, crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theQueryConditionOfTheReaderTriggersOnAMatchingSample

Status: done — WaitSet.newWaitSet(env) erzeugt über env.getSPI().newWaitSet() direkt ein WaitSetImpl, ohne Entity-Factory. Der erste Test prüft, dass der SPI ein Objekt liefert; der zweite erzeugt über WaitSet.newWaitSet(reader.getEnvironment()) ein WaitSet und hängt eine Condition an und ab. (Commit 5041698cee3) ### §2 WaitSet: attach_condition

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.6, S. 30 (dds-1.2.pdf), Tabelle WaitSet — “attach_condition (a_condition: Condition): ReturnCode_t”

Status: done — WaitSetImpl.attachCondition nimmt die Bedingung auf (mehrfaches Anhängen wirkt nicht) und meldet sie bei einer GuardConditionImpl an; Statusänderungen und Sample-Eingang wecken über WaitSetImpl.conditionChanged alle WaitSets. Getestet: Anhängen, getConditions, Warten an Guard-, Read- und StatusCondition. (Commit 5041698cee3) ### §2 WaitSet: detach_condition

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.6, S. 30 (dds-1.2.pdf), Tabelle WaitSet — “detach_condition (a_condition: Condition): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionIsFalseAtFirstAndTheWaitSetKnowsWhatIsAttached, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::theWaitSetListsWhatIsAttachedAndADetachedConditionDoesNotEndAWait

Status: done — WaitSetImpl.detachCondition entfernt die Bedingung und meldet sie bei der GuardConditionImpl ab; eine nicht angehängte Bedingung ergibt PreconditionNotMetException. Der Test setzt eine abgehängte Guard-Bedingung auf wahr: das Warten endet nicht (Timeout), nach erneutem Anhängen sofort. Eine geschlossene Bedingung zählt im WaitSet als nicht ausgelöst. (Commit e1b55167947) ### §2 WaitSet: wait

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.6, S. 30 (dds-1.2.pdf), Tabelle WaitSet — “wait (inout: active_conditions: Condition [], timeout: Duration_t): ReturnCode_t”

Status: done — WaitSetImpl.await wartet, bis eine angehängte Bedingung wahr ist; Guard-Bedingungen wecken über signal, Status- und Read-Bedingungen über WaitSetImpl.conditionChanged (aus triggerStatus und beim Sample-Eingang). Ein zweiter wartender Thread ergibt PreconditionNotMetException, ein Ablauf der Zeit TimeoutException. Getestet: Wecken durch setTriggerValue und durch ein write aus einem anderen Thread. (Commit 5041698cee3) ### §2 WaitSet: Ergebnis von wait

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.6, S. 30 (dds-1.2.pdf), Tabelle WaitSet — “inout: active_conditions: Condition []”

Status: done — WaitSetImpl.await legt alle angehängten Bedingungen mit Triggerwert wahr in die übergebene Sammlung (zuvor geleert). Die Tests prüfen die Größe und assertSame auf die erwartete Bedingung, auch mit zwei Bedingungen am WaitSet, von denen eine falsch ist. (Commit 5041698cee3) ### §2 WaitSet: get_conditions

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.6, S. 30 (dds-1.2.pdf), Tabelle WaitSet — “get_conditions (inout: attached_conditions: Condition []): ReturnCode_t”

Status: done — getConditions liefert eine Kopie der angehängten Bedingungen. Der Test hängt eine ReadCondition und eine GuardCondition an (zwei Einträge), hängt eine ab (ein Eintrag, die abgehängte fehlt). (Commit e1b55167947) ### §2 GuardCondition: Erzeugen ohne Factory, Anfangswert FALSE

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.8, S. 32 (dds-1.2.pdf) — “GuardCondition has no factory. It is created as an object directly by the natural means in each language binding (e.g., using “new” in C++ or Java). When first created the trigger_value is set to FALSE.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionIsFalseAtFirstAndTheWaitSetKnowsWhatIsAttached

Status: done — GuardCondition.newGuardCondition(env) liefert eine GuardConditionImpl ohne Entity-Factory; der Test erwartet getTriggerValue() == false unmittelbar nach dem Erzeugen. (Commit 5041698cee3) ### §2 GuardCondition: set_trigger_value

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.8, S. 32 (dds-1.2.pdf), Tabelle GuardCondition — “set_trigger_value (value: boolean): ReturnCode_t”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionSetFromAnotherThreadEndsABlockedWaitAndIsReported, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderConditionTest.java::theWaitSetListsWhatIsAttachedAndADetachedConditionDoesNotEndAWait

Status: done — GuardConditionImpl.setTriggerValue setzt den Wert und weckt die angehängten WaitSets (WaitSetImpl.attachCondition meldet sie an). Der Test setzt den Wert aus einem zweiten Thread; das blockierte Warten endet und meldet die Bedingung. (Commit 5041698cee3) ### §2 StatusCondition: set_enabled_statuses und get_enabled_statuses

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.9, S. 32 (dds-1.2.pdf), Tabelle StatusCondition — “set_enabled_statuses (mask: StatusKind []): ReturnCode_t; get_enabled_statuses: StatusKind []”

Status: done — Die Voreinstellung von getEnabledStatuses ist die Menge aller Statuses (Status.allStatuses); setEnabledStatuses beschränkt den Triggerwert auf die gewählten Statuses. Der Test: SUBSCRIPTION_MATCHED ist geändert, nach Beschränkung auf DATA_AVAILABLE falsch, nach write wahr, nach take falsch. (Commit e1b55167947) ### §2 StatusCondition: get_entity

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.1.9, S. 32 (dds-1.2.pdf), Tabelle StatusCondition — “get_entity: Entity”

Status: done — EntityBase.getStatusCondition().getParent() ist die Entity; beide Tests erwarten mit assertSame den Reader. (Commit d23eff980f3) ### §2 ReadCondition: get_datareader

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.8, S. 106 (dds-1.2.pdf), Tabelle ReadCondition — “get_datareader: DataReader”

Status: done — ReadConditionImpl.getParent liefert den Reader, der die Bedingung erzeugt hat; beide Tests erwarten ihn mit assertSame. (Commit d23eff980f3) ### §2 ReadCondition: get_sample_state_mask, get_view_state_mask, get_instance_state_mask

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.8, S. 106 (dds-1.2.pdf), Tabelle ReadCondition — “get_sample_state_mask: SampleStateKind []; get_view_state_mask: ViewStateKind []; get_instance_state_mask: InstanceStateKind []”

Status: done — createReadCondition liefert genau die Zustandsmengen des übergebenen DataState (Kopie zum Zeitpunkt des Erzeugens); der Triggerwert folgt ihnen: NOT_READ wahr bis zum ersten read, READ danach. (Commit e1b55167947) ### §2 QueryCondition: get_query_expression

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.9, S. 107 (dds-1.2.pdf), Tabelle QueryCondition — “get_query_expression: string”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::aConditionKnowsTheFilterThatTriggersIt

Status: done — QueryConditionImpl.getQueryExpression liefert den bei DataReaderImpl.createQueryCondition übergebenen Ausdruck. Der Test erzeugt eine Condition mit "value > %0" und prüft Gleichheit des zurückgegebenen Ausdrucks. (Commit 2e0b194caf5) ### §2 QueryCondition: get_query_parameters und set_query_parameters

Spec: §2, S. 11; [DDS] 1.2 §7.1.2.5.9, S. 107 (dds-1.2.pdf), Tabelle QueryCondition — “get_query_parameters (out: query_parameters: string []): ReturnCode_t; set_query_parameters (query_parameters: string []): ReturnCode_t”

Status: done — Der Triggerwert einer QueryCondition übersetzt Ausdruck und aktuelle Parameter bei jeder Auswertung (createQueryCondition), setQueryParameters wirkt also sofort und weckt WaitSets. Der Test: seq > %0 mit 5 und seq 3 falsch, mit 2 wahr, mit 3 falsch. (Commit e1b55167947)

§2 Programmierschnittstellen von [DDS] 1.2: eingebaute Topics

§2 Eingebaute Topics: DCPSParticipant

Spec: §2, S. 11; [DDS] 1.2 §7.1.5, S. 148 (dds-1.2.pdf) — “DCPSParticipant: key BuiltinTopicKey_t; user_data UserDataQosPolicy”

Status: done — ParticipantBuiltinTopicData hat getKey und getUserData; BuiltinData.participant füllt sie aus SPDP, BuiltinTopicWire kodiert sie. Ein Participant mit nicht leerem USER_DATA erscheint mit diesem Wert im Reader auf DCPSParticipant und in getDiscoveredParticipantData. Tests: ParticipantDiscoveryTest::aBuiltinReaderHasTheEntitiesThatExistedBeforeAndNoneOfItsOwnParticipant (USER_DATA {1, 2} im Reader des eingebauten Subscribers), ::theDiscoveredParticipantsAreTheOtherParticipantsOfTheDomainAndTheirUserData (getDiscoveredParticipantData), ::theBuiltinReaderSeesTheUserDataChangeOfAnotherParticipant (setQos meldet neue Daten), ParticipantBuiltinDataTest::aParticipantWithUserDataRoundTripsItsKeyAndUserData (Wire-Rundlauf). (Commit cd8f3d67ea9) ### §2 Eingebaute Topics: DCPSTopic

Spec: §2, S. 11; [DDS] 1.2 §7.1.5, S. 148 (dds-1.2.pdf) — “DCPSTopic: key, name, type_name, durability, durability_service, deadline, latency_budget, liveliness, reliability, transport_priority, lifespan, destination_order, history, resource_limits, ownership, topic_data”

Status: done — Die Schnittstelle hat alle Felder der Spec (key, name, type_name, durability, durability_service, deadline, latency_budget, liveliness, reliability, transport_priority, lifespan, destination_order, history, resource_limits, ownership, topic_data), BuiltinData.topic füllt sie. ParticipantBuiltinDataTest::aTopicWithEveryPolicyOffItsDefaultRoundTripsTheKeyAndThePolicies setzt latency_budget 2 s, liveliness MANUAL_BY_PARTICIPANT mit Lease 6 s, lifespan 20 s, destination_order BY_SOURCE_TIMESTAMP, ownership EXCLUSIVE und reliability RELIABLE mit max_blocking_time 3 s, kodiert über BuiltinTopicWire und dekodiert; geprüft werden Schlüssel, Name, Typname und jede dieser Policies. BuiltinTopicQosTest::everyBuiltinDataTypeRoundTripsItsQos deckt name, durability, durability_service, deadline, history, resource_limits, transport_priority und topic_data ab. (Commit 5041698cee3) ### §2 Eingebaute Topics: DCPSPublication

Spec: §2, S. 11; [DDS] 1.2 §7.1.5, S. 149 (dds-1.2.pdf) — “DCPSPublication: key, participant_key, topic_name, type_name, durability, durability_service, deadline, latency_budget, liveliness, reliability, lifespan, user_data, ownership, ownership_strength, destination_order, presentation, partition, topic_data, group_data”

Status: done — Alle Felder der Spec stehen in der Schnittstelle und in BuiltinData.publication. Der Wire-Test prüft Parameter-IDs und Bytes für durability, deadline, latency_budget, liveliness, reliability, lifespan, user_data, ownership, ownership_strength, destination_order, partition, group_data, presentation, topic_name, type_name und beide GUIDs; der Rundlauf vergleicht alle Felder nach dem Dekodieren, der Reader-Test liest abweichende Werte aus dem eingebauten Reader. ParticipantBuiltinDataTest::aPublicationKeepsItsOwnDurabilityServiceAndTheTopicDataOfItsTopic prüft durability_service des Writers (history_depth 9, max_samples 80) und topic_data des Topics ({7, 7, 7}) nach dem Rundlauf. (Commit 5041698cee3) ### §2 Eingebaute Topics: DCPSSubscription

Spec: §2, S. 11; [DDS] 1.2 §7.1.5, S. 150 (dds-1.2.pdf) — “DCPSSubscription: key, participant_key, topic_name, type_name, durability, deadline, latency_budget, liveliness, reliability, ownership, destination_order, user_data, time_based_filter, presentation, partition, topic_data, group_data”

Status: done — Die Schnittstelle und BuiltinData.subscription enthalten alle Felder der Spec. ParticipantBuiltinDataTest::aSubscriptionWithEveryPolicyOffItsDefaultRoundTripsTheKeysTheTypeAndThePolicies setzt deadline 3 s, latency_budget 1 s, ownership EXCLUSIVE, destination_order BY_SOURCE_TIMESTAMP am Reader und group_data, presentation (Scope TOPIC, coherent und ordered) und partition am Subscriber und prüft nach Kodieren und Dekodieren key, participant_key, topic_name, type_name und jede dieser Policies. BuiltinTopicQosTest::everyBuiltinDataTypeRoundTripsItsQos deckt durability, liveliness, reliability, time_based_filter, user_data, partition und topic_data ab. (Commit 5041698cee3)

§3 References

§3.1 [DDS] Version 1.2

Spec: §3.1, S. 11 — “[DDS] Data Distribution Service for Real-Time Systems Specification, version 1.2 (OMG document formal/2007-01-01).”

Repo: —

Tests: —

Status: n/a (informative) — Verweis. Die Items unter §2 zitieren [DDS] 1.2 (.agent/spec/dds-1.2.txt). Die Kommentare im Java-Code zitieren DDS 1.4 (z. B. ListenerTest: “DDS 1.4 §2.2.4.1”, DataReaderImpl); ZeroDDS selbst folgt DDS 1.4 (.agent/spec/dds-dcps-1.4.txt). ### §3.1 [DDS-CCM] 1.0 Beta 1

Spec: §3.1, S. 11 — “[DDS-CCM] DDS for Lightweight CCM, version 1.0 Beta 1 (OMG document ptc/2009-02-02).”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosProviderImpl.java (QosProviderImpl)

Tests: —

Status: n/a (informative) — Verweis. Die Java-Bindung verlangt von [DDS-CCM] nichts Eigenes; QosProviderImpl erwähnt die XML-QoS-Bibliotheken von [DDS-CCM] im Klassenkommentar. Ein Vergleich mit der Beta 1 wurde nicht durchgeführt. (Commit 2e0b194caf5) ### §3.1 [DDS-XTypes] 1.0 Beta 1

Spec: §3.1, S. 11 — “[DDS-XTypes] Extensible and Dynamic Topic Types for DDS, version 1.0 Beta 1 (OMG document ptc/2010-05-12).”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/Extensibility.java (Extensibility.Kind)

Tests: —

Status: n/a (informative) — Verweis. Verglichen wird, wo nötig, mit XTypes 1.3 (.agent/spec/dds-xtypes-1.3.txt). org.omg.dds.type.Extensibility.Kind benennt die Erweiterbarkeit weiter EXTENSIBLE_EXTENSIBILITY. ### §3.1 [Java-MAP] IDL to Java 1.3

Spec: §3.1, S. 11 — “[Java-MAP] IDL to Java Language Mapping, Version 1.3 (OMG document formal/2008-01-11)”

Repo: crates/lang-rules/src/adapter/java.rs (adapter::java)

Tests: —

Status: n/a (informative) — Verweis. Im Repo liegt IDL4 to Java 1.0 (.agent/spec/idl4-java-1.0.txt, Coverage in docs/spec-coverage/idl4-java-1.0.md). Der Java-Codegen beruft sich für öffentliche Felder auf “§1.5.10 of the OMG mapping” (crates/lang-rules/src/adapter/java.rs, Kommentar zu den öffentlichen Feldern). ### §3.1 [Java-Lang] The Java Language Specification, Third Edition

Spec: §3.1, S. 12 — “[Java-Lang] The Java Language Specification, Third Edition, published by Addison Wesley in 2005 with ISBN 0321246780”

Repo: crates/java-omgdds/java/pom.xml (properties/profile java8), crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java (PubSubLoopbackTest.Reading)

Tests: —

Status: n/a (informative) — Verweis auf Java 5. Das Modul übersetzt mit maven.compiler.source 17 und im Profil java8 mit Release 8 (crates/java-omgdds/java/pom.xml); die Tests brauchen Java 17 (Records, z. B. PubSubLoopbackTest.Reading). (Commit 5536e2abcac) ### §3.1 [XML] 1.1, Second Edition

Spec: §3.1, S. 12 — “[XML] Extensible Markup Language (XML), version 1.1, Second Edition (W3C recommendation, August 2006).”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosProviderImpl.java (QosProviderImpl)

Tests: —

Status: n/a (informative) — Verweis für die XML-QoS-Profile (§7.3.5.4). Die Java-Bindung liest XML: QosProviderImpl parst über javax.xml.parsers.DocumentBuilderFactory mit abgeschaltetem externem DTD- und Schema-Zugriff. Welche XML-Version dabei gilt, wurde nicht geprüft. (Commit 2e0b194caf5) ### §3.2 [JMS] 1.1 (nicht normativ)

Spec: §3.2, S. 12 — “The following non-normative references are provided for informational purposes. • [JMS] Java Message Service Specification, version 1.1 (Sun Microsystems, http://java.sun.com/products/jms/ docs.html).”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ.

§4 Terms and Definitions

Spec: §4, S. 12 — “The mandatory portion of the DDS specification used to provide the functionality required for an application to publish and subscribe to the values of data objects.”

Repo: —

Tests: —

Status: n/a (informative) — Begriff. ### §4 Data Distribution Service (DDS)

Spec: §4, S. 12 — “An OMG distributed data communications specification that allows Quality of Service policies to be specified for data timeliness and reliability. It is independent of implementation languages.”

Repo: —

Tests: —

Status: n/a (informative) — Begriff. ### §4 Data Local Reconstruction Layer

Spec: §4, S. 12 — “The optional portion of the DDS specification used to provide the functionality required for an application for direct access to data exchanged at the DCPS layer. This latter builds upon the DCPS layer.”

Repo: —

Tests: —

Status: n/a (informative) — Begriff. ### §4 Java Archive (JAR)

Spec: §4, S. 12 — “A zip file, whose name ends in the suffix .jar, that contains the compiled Java class files and other artifacts that comprise a Java library.”

Repo: —

Tests: —

Status: n/a (informative) — Begriff. ### §4 Java Runtime Environment (JRE)

Spec: §4, S. 12 — “The environment within which Java applications execute. The JRE consists of an executing instance of a JVM, a set of class libraries, and potentially other components.”

Repo: —

Tests: —

Status: n/a (informative) — Begriff. ### §4 Java Virtual Machine (JVM)

Spec: §4, S. 12 — “An abstract computing machine capable of executing interpreted and/or compiled Java byte code. JVM implementations typically take the form of executables that run as processes under operating systems, but this style of implementation is not mandatory.”

Repo: —

Tests: —

Status: n/a (informative) — Begriff. ### §4 Platform-Independent Model (PIM)

Spec: §4, S. 12 — “An abstract definition of a facility, often expressed with the aid of formal or semi-formal modeling languages such as OMG UML, that does not depend on any particular implementation technology.”

Repo: —

Tests: —

Status: n/a (informative) — Begriff. ### §4 Platform-Specific Model (PSM)

Spec: §4, S. 13 — “A concrete definition of a facility, typically based on a corresponding PIM, in which all implementation-specific dependencies have been resolved.”

Repo: —

Tests: —

Status: n/a (informative) — Begriff.

§5 Symbols

§5 Keine Symbole

Spec: §5, S. 13 — “This specification does not define any symbols or abbreviations.”

Repo: —

Tests: —

Status: n/a (informative) — Keine Anforderung.

§6 Additional Information

§6.1 Keine Änderung anderer OMG-Specs

Spec: §6.1, S. 13 — “This specification does not extend or modify any existing OMG specifications.”

Repo: —

Tests: —

Status: n/a (informative) — Aussage über die Spec. ### §6.2 Abhängigkeit von Java SE 5, weitere Vorgaben der Implementierung

Spec: §6.2, S. 13 — “This specification depends on version 5 of the Java Standard Edition platform. Service implementations may impose additional constraints; the nature and scope of these, if any, are unspecified.”

Repo: crates/java-omgdds/java/pom.xml (properties/profile java8)

Tests: —

Status: n/a (informative) — Aussage über die Spec und Erlaubnis zu weiteren Vorgaben. ZeroDDS übersetzt mit Java 17 oder im Profil java8 mit Release 8 (crates/java-omgdds/java/pom.xml); Java 5 bis 7 ist nicht Ziel. (Commit 5536e2abcac) ### §6.2 Begründung: Java SE statt Java EE oder Java ME

Spec: §6.2, S. 13 — “Design Rationale (non-normative) As of the publication of this specification, Java SE remains the predominant platform for the development and deployment of DDS Java applications.”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ. ### §6.3 Acknowledgements

Spec: §6.3, S. 13 — “The following companies submitted this specification: • Real-Time Innovations, Inc. (RTI) • PrismTech”

Repo: —

Tests: —

Status: n/a (informative) — Danksagung.

§7.1 Specification Organization

§7.1 Gliederung nach den Modulen von [DDS]

Spec: §7.1, S. 15 — “This specification is organized according to the module defined by the DDS specification and the types and operations defined within them.”

Repo: —

Tests: —

Status: n/a (informative) — Gliederung der Spec.

§7.2 General Concerns and Conventions

§7.2 Übergreifende Festlegungen

Spec: §7.2, S. 15 — “This sub clause defines those elements of this specification that cut across multiple DDS modules.”

Repo: —

Tests: —

Status: n/a (informative) — Einleitung; die Festlegungen folgen in §7.2.1 bis §7.2.6. ### §7.2.1 Pakete mit dem Präfix org.omg.dds

Spec: §7.2.1, S. 15 — “This PSM is defined in a set of Java packages, the names of each beginning with the prefix org.omg.dds. Each of these contains a Java interface or abstract class for each type in the corresponding DDS module.”

Status: done — Die Pakete org.omg.dds.* enthalten für jeden Typ der DDS-Module eine Schnittstelle oder abstrakte Klasse der OMG-Quelle (184 Dateien; CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource vergleicht sie mit den SHA-256 der Quelle). KeyedString und KeyedBytes sind Themen-Typen: TypeSupportResolver.resolve liefert BuiltinTypeSupports.KeyedStringTypeSupport und KeyedBytesTypeSupport (XTypes 1.3 Anhang E: appendable, @key string key); CoreBuiltinKeyedTest schreibt und liest je ein Thema mit zwei Instanzen, die KeyHash-Oktette sind aus XTypes 1.3 §7.6.8 abgeleitet (MD5 über den Schlüssel in Big-Endian, nicht gegen eine andere Implementierung geprüft). Die Typen von org.omg.dds.type.typeobject sind als Objekte umgesetzt (TypeObjectModel) und über getType() der Built-in-Daten erreichbar. (Commit b4bf3fa978e) ### §7.2.1 Je Typ eine Schnittstelle oder abstrakte Klasse

Spec: §7.2.1, S. 15 — “Each of these contains a Java interface or abstract class for each type in the corresponding DDS module.”

Status: done — CoreApiShapeTest prüft per Reflexion für die Pakete core, core.policy, core.status, core.event, domain, pub, sub, topic, type, type.builtin, type.dynamic und type.typeobject, dass jeder öffentliche Typ Schnittstelle, Enum, Annotation oder abstrakte Klasse ist. Ausgenommen sind die konkreten Klassen der OMG-Quelle: ServiceConfigurationException, ServiceInitializationException, die sechs *Adapter, TypeId, TypeKind.Values, DataRepresentation.Id und die MemberId-Klassen. Das Paket org.omg.dds.rpc ist nicht erfasst. (Commit d23eff980f3) ### §7.2.1 Entitäten, Werttypen, Policies und Status als Schnittstelle oder abstrakte Klasse

Spec: §7.2.1, S. 15 — “Each of these contains a Java interface or abstract class for each type in the corresponding DDS module.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory), crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader), crates/java-omgdds/java/src/main/java/org/omg/dds/core/Time.java (Time), crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/Reliability.java (Reliability)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreApiShapeTest.java::entitiesValueTypesPoliciesAndStatusesAreInterfacesOrAbstractClasses

Status: done — CoreApiShapeTest prüft, dass DomainParticipant, DomainParticipantFactory, Publisher, Subscriber, Topic, DataWriter, DataReader Schnittstellen oder abstrakte Klassen sind, Time, Duration und InstanceHandle abstrakte Klassen, QosPolicy und die Policies Schnittstellen, LivelinessChangedStatus und PublicationMatchedStatus abstrakte Klassen. (Commit 5041698cee3) ### §7.2.1 Alle Pakete in einer JAR omgdds.jar

Spec: §7.2.1, S. 15 — “All of these packages, and the types within them, are packaged into a single JAR file, omgdds.jar (see Annex A: Java JAR Library File).”

Repo: crates/java-omgdds/java/pom.xml

Tests: —

Status: n/a (informative) — Beschreibt das Artefakt der OMG (Annex A: omgdds.jar). ZeroDDS baut org.zerodds:omgdds (crates/java-omgdds/java/pom.xml, ohne finalName, also omgdds-<Version>.jar; aus der POM gelesen, nicht gebaut). Das JAR enthält die Klassen unter org.omg.dds, org.zerodds und über build-helper-maven-plugin die Quellen aus crates/idl-java/runtime und runtime/java/src/main/java. Annex A erlaubt, die Implementierung im selben JAR auszuliefern. (Commit 5536e2abcac) ### §7.2.1 Abstrakte Typen implementiert der Service konkret

Spec: §7.2.1, S. 15 — “All those types that are abstract—including interfaces and abstract classes—are intended to be implemented concretely by the Service implementation.”

Status: done — ServiceEnvironmentImpl und die Klassen unter org/zerodds (DomainParticipantFactoryImpl, DomainParticipantImpl, PublisherImpl, SubscriberImpl, TopicImpl, DataWriterImpl, DataReaderImpl, SampleImpl, TimeImpl, DurationImpl, InstanceHandleImpl, WaitSetImpl) setzen die abstrakten Typen um. QuickstartApiTest.byteArrayQuickstartRoundTrip erzeugt über die Umgebung Participant, Topic, Writer und Reader und liest ein Sample zurück. Die 26 Schnittstellen unter org/omg/dds/type/typeobject (TypeObject, StructureType, UnionType, …) setzt TypeObjectModel um, über ein TypeObject von XTypes 1.1 Anhang B, das in idl/typeobject aus dem IDL des Anhangs übernommen und mit idlc in einen XCDR1-Codec übersetzt ist; TypeObjectModelTest baut eine Bibliothek mit einem Typ jeder Art, schickt sie durch den Codec und findet Objekte aller 26 Schnittstellen wieder. (Commit b4bf3fa978e) ### §7.2.1 Eigene Eigenschaften in Untertypen der Implementierung erlaubt

Spec: §7.2.1, S. 15 — “In addition, the subtypes defined by the implementation may expose additional implementation-specific properties and operations; however, the nature of these, if any, is undefined.”

Repo: —

Tests: —

Status: n/a (informative) — Erlaubnis. Die Implementierungsklassen liegen unter org.zerodds (z. B. DataReaderImpl.isClosed, die Methoden der internen Schnittstelle InProcessBus.Endpoint). Die Regel zum Ort der Erweiterungen steht im Item „§7.2.6 Keine Erweiterungen in org.omg.dds oder Unterpaketen“. ### §7.2.1 Begründung: mehrere Pakete

Spec: §7.2.1, S. 15 — “Design Rationale (non-normative) This PSM divides the types it defines into multiple packages, rather than colocating them in a single package […]”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ. ### §7.2.2 Werttypen einer anderen Implementierung annehmen

Spec: §7.2.2, S. 15 — “It shall be possible to pass an instance of any value type (see 7.2.3) created by one DDS implementation to a method implemented by another. For example, the method DataWriter.write optionally accepts an argument of type InstanceHandle; this object may have been created by the same DDS implementation that created the DataWriter or by another DDS implementation.”

Status: done — InstanceHandleImpl.bytesOf nimmt einen InstanceHandle einer anderen Implementierung an: nil über isNil() gleich 16 Nullbytes, sonst die ersten 16 Bytes von SHA-256 über Klassenname und Java-Serialisierung (Ersatz toString()); gleiche Fremdwerte ergeben gleiche Bytes, equals und compareTo sind total. ModifiableTimeImpl.copyFrom und die Writer-Operationen nehmen Fremdwerte an (Time und Duration über getTime/getDuration). DataWriterImpl.resolve und checkHandle prüfen die Nil-Eigenschaft über isNil(), ein Fremdhandle ohne Instanz ergibt IllegalArgumentException (DDS 1.4 §2.2.2.4.2.11: ungültiger Handle, BAD_PARAMETER; aForeignHandleThatNamesNoInstanceOfTheWriterIsABadParameter), ein Handle einer anderen Instanz als der des Samples PreconditionNotMetException. Die Fremdklassen im Test sind gegen die abstrakten Klassen der OMG-API geschrieben. (Commit 4c28bc52254) ### §7.2.2 Samples eines fremden DataReader mit dem eigenen DataWriter schreiben

Spec: §7.2.2, S. 15 — “It shall be possible to read or take samples from a DataReader provided by one DDS implementation and immediately write them using a DataWriter provided by another DDS implementation, provided that the samples are of a DDS type compatible with that DataWriter.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.write)

Status: done — CoreForeignValuesTest implementiert ein Sample und ein ModifiableInstanceHandle einer anderen Implementierung und übergibt getData(), getSourceTimestamp() und getInstanceHandle() an write, dispose und unregisterInstance eines ZeroDDS-DataWriter. Der Reader sieht den Zeitstempel in Millisekunden aus dem Fremdwert (1 700 000 000 123 ms aus 1 700 000 000 123 000 000 ns), dispose ergibt NOT_ALIVE_DISPOSED. Ein Fremdhandle, das keine Instanz des Writers benennt, ergibt PreconditionNotMetException. (Commit 26684105d79) ### §7.2.2 Kopieren beim Übergeben zwischen Implementierungen

Spec: §7.2.2, S. 15 — “Note that passing an object from one implementation to another may incur a performance cost, as the “receiving” implementation may have to copy the object in question before operating on it.”

Repo: —

Tests: —

Status: n/a (informative) — Hinweis. ### §7.2.2 Fremde konkrete Typen: Ausnahme oder undefiniertes Verhalten erlaubt

Spec: §7.2.2, S. 16 — “Otherwise, unless elsewhere noted in this specification, a Service implementation may raise an exception or behave in an undefined way if it encounters a concrete type defined by another party.”

Repo: —

Tests: —

Status: n/a (informative) — Erlaubnis. ZeroDDS macht davon Gebrauch: PublisherImpl.codecOf wirft UnsupportedOperationException für ein TypeSupport einer anderen Implementierung, InstanceHandleImpl.bytesOf wirft IllegalArgumentException. ### §7.2.3 Typen ohne Factory im PIM: abstrakte Klasse mit statischen Factory-Methoden new<ClassName>

Spec: §7.2.3, S. 16 — “These latter types—those without PIM-defined factory construction methods—serve as their own factories. Each is represented as an abstract class with one or more static factory methods. These methods are named according to the convention new in order to resemble constructor invocations and are amenable to use with the Java 5 static import facility.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionIsFalseAtFirstAndTheWaitSetKnowsWhatIsAttached, crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theQueryConditionOfTheReaderTriggersOnAMatchingSample, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::theStaticFactoryMethodsOfTheAbstractValueTypesGoThroughTheSpi, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aNewInstanceHandleIsNilAndIsFilledByCopyFrom, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aTypeSupportIsRegisteredUnderTheFullyQualifiedNameOfTheType, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::keyedStringAndKeyedBytesMutatorsReturnTheObject, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aQosProviderOfAnUnsupportedUriSchemeIsRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::aNegativeInstantInAnyUnitIsInvalid

Status: done — Die statischen Fabrikmethoden gehen über den SPI: Time.newTime, Duration.newDuration, InstanceHandle.newInstanceHandle, QosProvider.newQosProvider, TypeSupport.newTypeSupport, KeyedString.newKeyedString und KeyedBytes.newKeyedBytes; CoreSpiTest und CoreValuesTest rufen jede auf und prüfen Wert und Umgebung. TypeSupport.newTypeSupport(Class, env) in org/omg/dds/type/TypeSupport.java registrierte den Typ unter type.getClass().getName() (java.lang.Class); der Fehler stand in der OMG-Quelle, die Datei verwendet jetzt type.getName() (PSM §7.5.1). (Commit 7431a7d599c) ### §7.2.3 Löschoperationen des PIM als close am Produkt

Spec: §7.2.3, S. 16 — “This PSM maps the factory deletion methods of the DDS PIM (e.g., DomainParticipant.delete_publisher) to close methods on the “product” interfaces themselves (e.g., Publisher.close).”

Status: done — ContentFilteredTopicImpl.close und MultiTopicImpl.close merken sich den geschlossenen Zustand (isClosed); SubscriberImpl.createDataReader verweigert eine geschlossene Beschreibung mit AlreadyClosedException. Eine ContentFilteredTopic einer anderen Implementierung ergibt jetzt UnsupportedOperationException (vorher AlreadyClosedException). (Commit 0eb300902f5) ### §7.2.3 Schließen schließt die enthaltenen Objekte

Spec: §7.2.3, S. 16 — “Closing an Entity implicitly closes all of its contained objects, if any. For example, closing a Publisher also closes all of its contained DataWriters.”

Status: done — CoreCloseTest schließt einen Subscriber und einen DomainParticipant und prüft mit Qos.isClosed, dass ihre DataReader (und der DataWriter) geschlossen sind; ContentFilteredTopic.close und MultiTopic.close wirken über das Geschlossen-Merkmal. (Commit 0eb300902f5) ### §7.2.3 Begründung: Muster close

Spec: §7.2.3, S. 16 — “Design Rationale (non-normative) The close destruction design pattern is intended to be familiar to those developers who have used java.io stream APIs and/or [JMS] […]”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ. ### §7.2.3 Empfehlung, close aufzurufen

Spec: §7.2.3, S. 16 — “Users of this PSM are recommended to call close once they are finished using such heavyweight objects.”

Repo: —

Tests: —

Status: n/a (informative) — Empfehlung an Anwendungen. ### §7.2.3 Automatisches Schließen nicht mehr benutzter Objekte erlaubt

Spec: §7.2.3, S. 16 — “In addition, implementations may automatically close objects that the JRE deems to be no longer in use—for example, they may call close() in an Object.finalize() override—subject to the following restrictions:”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.retain), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.retain)

Tests: —

Status: n/a (informative) — Erlaubnis. ZeroDDS schließt nichts automatisch: unter crates/java-omgdds/java/src/main/java gibt es weder finalize noch Cleaner (Textsuche; der einzige Treffer für WeakReference ist GuardConditionImpl, die damit nichts schließt). Ein DataReader, den die Anwendung ohne close() fallen lässt, bleibt am InProcessBus angemeldet (aus dem Code gelesen, nicht gemessen). (Commit 166d5873d4a) ### §7.2.3 Direkt referenziertes Objekt bleibt in Gebrauch

Spec: §7.2.3, S. 16 — “• Any object to which the application has a direct reference is still in use.”

Repo: —

Tests: —

Status: n/a (informative) — Einschränkung des automatischen Schließens, das ZeroDDS nicht ausführt (Item davor). ### §7.2.3 Entität mit Listener bleibt in Gebrauch

Spec: §7.2.3, S. 16 — “• Any entity with a non-null listener is still in use.”

Repo: —

Tests: —

Status: n/a (informative) — Einschränkung des automatischen Schließens, das ZeroDDS nicht ausführt. ### §7.2.3 Ausdrücklich gehaltenes Objekt bleibt in Gebrauch

Spec: §7.2.3, S. 16 — “• Any object that has been explicitly retained is still in use.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity.retain), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.retain)

Tests: —

Status: n/a (informative) — Einschränkung des automatischen Schließens, das ZeroDDS nicht ausführt. Entity.retain() ist vorhanden; EntityBase.retain hat keine Wirkung, weil nichts automatisch geschlossen wird. (Commit 166d5873d4a) ### §7.2.3 Ersteller eines benutzten Objekts bleibt in Gebrauch

Spec: §7.2.3, S. 16 — “• The creator of any object that is still in use is itself still in use.”

Repo: —

Tests: —

Status: n/a (informative) — Einschränkung des automatischen Schließens, das ZeroDDS nicht ausführt. ### §7.2.4 Operationen von DataReader und DataWriter reentrant

Spec: §7.2.4, S. 16 — “All DataReader and DataWriter operations shall be reentrant.”

Status: done — CoreConcurrencyTest ruft write, registerInstance, take und close aus mehreren Threads an einem DataWriter und DataReader auf: vier Writer-Threads zu je 50 Samples, zwei Registrierungs-Threads, ein take-Thread; die Summe der entnommenen Samples ist 200. Ein zweiter Test schließt den Writer, während vier Threads schreiben und ein Thread take aufruft; es bleibt nur AlreadyClosedException. Der Code ist unverändert (das qos-Feld ist volatile). (Commit ac048fe0dc7) ### §7.2.4 Operationen von Topic, Publisher, Subscriber und DomainParticipant reentrant, außer close

Spec: §7.2.4, S. 16 — “All Topic (and other TopicDescription extension interfaces), Publisher, Subscriber, and DomainParticipant operations shall be reentrant with the exception that close may not be called on a given object concurrently with any other call of any method on that object or on any contained object.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreConcurrencyTest.java::severalThreadsCreateEntitiesAndSetTheQosOfOnePublisherAndSubscriber

Status: done — Das Feld qos von PublisherImpl, SubscriberImpl, TopicImpl, DataWriterImpl und DataReaderImpl ist volatile. CoreConcurrencyTest erzeugt aus acht Threads je zehnmal Writer, Reader und Topic an einem Publisher, Subscriber und Participant und setzt dabei das QoS von Publisher und Subscriber; alle 240 Objekte sind verschieden, das übrig gebliebene QoS ist das eines der Threads. (Commit ac048fe0dc7) ### §7.2.4 Operationen von ServiceEnvironment und DomainParticipantFactory reentrant, außer DomainParticipantFactory.close

Spec: §7.2.4, S. 16 — “All ServiceEnvironment and DomainParticipantFactory operations shall be reentrant with the exception that DomainParticipantFactory.close may not be called on a given object concurrently with any other call of any method on that object or on any contained object.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::severalThreadsGetOneParticipantFactoryOfAnEnvironment

Status: done — ServiceEnvironmentImpl.ZeroSPI.getParticipantFactory legt die Factory mit double-checked locking an (volatile-Feld, synchronized). CoreSpiTest ruft DomainParticipantFactory.getInstance(env) in 20 Runden aus je acht gleichzeitig gestarteten Threads auf und prüft, dass genau eine Instanz zurückkommt. (Commit 7431a7d599c) ### §7.2.4 Operationen von WaitSet und Condition reentrant

Spec: §7.2.4, S. 16 — “All WaitSet and Condition (including Condition extension interfaces) operations shall be reentrant with the exception that their close methods may not be called on a given object concurrently with any other call of any method on that object.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionSetFromAnotherThreadEndsABlockedWaitAndIsReported, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aSecondThreadWaitingOnTheSameWaitSetIsRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aStatusConditionTriggersOnTheStatusItIsEnabledForAndHasItsEntityAsParent, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aReadConditionFollowsTheStatesOfTheSamplesAndWakesTheWaitSet, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreConcurrencyTest.java::conditionsAreAttachedAndDetachedWhileAThreadWaits

Status: done — CoreConcurrencyTest hängt Conditions an und ab, ruft getConditions und StatusCondition.setEnabledStatuses in 100 Runden auf, während ein anderer Thread in waitForConditions wartet; danach löst GuardCondition.setTriggerValue(true) das Warten aus und die aktive Menge enthält die Condition. Der Code ist unverändert. (Commit fc054ce9926) ### §7.2.4 Im Listener nur die auslösende Entität aufrufen

Spec: §7.2.4, S. 17 — “Code within a DDS listener callback may not safely call any method on any DDS Entity but the one on which the status change occurred.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.fireDataAvailable)

Tests: —

Status: n/a (informative) — Einschränkung für den Code der Anwendung im Callback; die Spec verlangt hier nichts von der Implementierung. ZeroDDS ruft die Callbacks ohne Monitor des Readers oder Writers auf (DataReaderImpl.fireDataAvailable), sodass Aufrufe aus dem Callback zulässig bleiben; ReentrancyTest.aCallbackDoesNotHoldTheReaderMonitor prüft das für close() aus einem anderen Thread. (Commit 166d5873d4a) ### §7.2.4 Methoden von Werttypen dürfen nicht reentrant sein

Spec: §7.2.4, S. 17 — “Any method of any value type may be non-reentrant.”

Repo: —

Tests: —

Status: n/a (informative) — Erlaubnis. ### §7.2.4 Stärkere Zusagen erlaubt

Spec: §7.2.4, S. 17 — “A vendor may choose to provide stronger guarantees than the rules above, but if so, those guarantees are unspecified.”

Repo: —

Tests: —

Status: n/a (informative) — Erlaubnis. ### §7.2.4 Begründung: close und Listener

Spec: §7.2.4, S. 17 — “Design Rationale (non-normative) • Objects that are likely to “own” mutexes within their implementation need not permit close invocations currently with other method invocations. […]”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ. ### §7.2.5 Namen in camelCase

Spec: §7.2.5, S. 17 — “This PSM maps the underscore-formatted names of the DDS PIM and IDL PSM (such as get_qos) into conventional Java “camel-case” names (such as getQos).”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::registerAndLookupInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::requestedDeadlineMissedIsRaised, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::statusIsReadableWithoutAListener

Status: done — Die Operationen unter org/omg/dds tragen die PIM-Namen in camelCase; eine Suche nach Methodennamen mit Unterstrich findet keine. Die Tests rufen registerInstance, lookupInstance, getRequestedDeadlineMissedStatus, getSubscriptionMatchedStatus, getPublicationMatchedStatus und createParticipant auf. (Commit c060b572340) ### §7.2.5 Mutatoren set<PropertyName> geben das Objekt zurück

Spec: §7.2.5, S. 17 — “Properties defined by the DDS PIM are expressed as sets of accessor and mutator methods. […] Mutators are named set (for example, the mutator for a property “Foo” would be named setFoo.) They take a single argument—the new value of the property—and return the enclosing object in order to facilitate method chaining.”

Status: done — CoreSpiTest verkettet KeyedString.setKey(..).setValue(..) und KeyedBytes.setKey(..).setValue(..) (beide liefern das Objekt zurück) und prüft Kopie- und copyFrom-Verhalten. Die void-Mutatoren folgen der OMG-Quelle (Annex B), die vom Text des §7.2.5 abweicht. (Commit 5041698cee3) ### §7.2.5 Accessor get<PropertyName>() für unveränderliche Werte und Verweise

Spec: §7.2.5, S. 17 — “Accessors for properties that are either of unmodifiable objects (such as those of primitive types, primitive box types, or strings) or pointers to the internal state of an object are named get. (For example, the accessor for an integer property “Foo” would be named getFoo.) They take no arguments.”

Status: done — Die Accessoren für Zeichenketten, Zahlen und Verweise heißen get<PropertyName> und nehmen kein Argument (DomainParticipant.getDomainId, Topic.getName, DataReader.getListener, Sample.getData; Deklarationen gelesen). ListenerTest.readerListenerFiresOnMatchAndOnEverySample ruft getListener, getCurrentCount und getTotalCount, QuickstartApiTest.byteArrayQuickstartRoundTrip getData. (Commit 5041698cee3) ### §7.2.5 Accessor get<PropertyName>() für Policies, Status, Zeit und Samples

Spec: §7.2.5, S. 17 — “Accessors for properties that are either of unmodifiable objects […] are named get.”

Status: done — Policies, Status, Time, Duration, InstanceHandle und Sample haben Accessoren get<PropertyName> (History.getKind, getDepth, SubscriptionMatchedStatus.getTotalCount, getCurrentCountChange, Time.getTime, Sample.getSampleState, getViewState, getInstanceState, getInstanceHandle, getSourceTimestamp). Die Tests rufen diese Accessoren auf und prüfen die Werte. (Commit 5041698cee3) ### §7.2.5 Accessor für veränderliche Eigenschaften mit vorab angelegtem Objekt

Spec: §7.2.5, S. 17 — “Accessors for properties that are of mutable types, and that may change asynchronously after they are retrieved, are named get. They take a pre-allocated object of the property type as their first argument, the contents of which shall be overwritten by the method. To facilitate method chaining, these methods also return a reference to this argument. […] An Entity’s status is an example of a property of this kind.”

Status: done — DataWriterImpl.getKeyValue(T, InstanceHandle) und DataReaderImpl.getKeyValue(T, InstanceHandle) überschreiben nur die Schlüsselfelder von keyHolder und geben ihn zurück (TopicTypeSupport.copyKey, Standard KeyFields.copy über @Key; ohne @Key-Feld werden alle Felder kopiert; KeyedString/KeyedBytes kopieren key). Der Reader merkt sich je Instanz das erste Sample mit Daten (Instance.keySample). Ein Handle ohne Instanz ergibt IllegalArgumentException. lookupInstance(ModifiableInstanceHandle, T) füllt das übergebene Handle, auch ein fremdes. (Commit f8e64a1ab3d) ### §7.2.6 Erweiterungen über eigene Schnittstellen aus den Factory-Methoden erlaubt

Spec: §7.2.6, S. 17 — “Implementation-specific extensions to the types specified by this PSM are by definition unspecified. However, implementations may provide such a capability by providing extended implementation-specific interfaces and returning instances of these interfaces from the specified factory methods.”

Repo: —

Tests: —

Status: n/a (informative) — Erlaubnis. ZeroDDS liefert aus den Factory-Methoden Klassen unter org.zerodds (z. B. DomainParticipantImpl), ohne eigene öffentliche Zusatzschnittstellen. ### §7.2.6 Keine Erweiterungen in org.omg.dds oder Unterpaketen

Spec: §7.2.6, S. 17 — “Implementations shall not place their extensions, if any, in any interface or class in the package org.omg.dds or in any other package whose name begins with that prefix.”

Status: done — Die Dateien unter crates/java-omgdds/java/src/main/java/org/omg/dds sind die Dateien der OMG-Quelle, ohne Ausnahme; CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource prüft die Menge der Dateien und ihren SHA-256 bei jedem Lauf, ohne dass die Quelle im Arbeitsbaum liegen muss. Die Bindung legt keine eigene Klasse in org.omg.dds ab. Die Implementierungsklassen von DDS-RPC (RequesterImpl, ReplierImpl, ServerImpl, ClientParamsImpl, ServiceParamsImpl, RequesterParamsImpl, ReplierParamsImpl, Matching, ZeroDdsParticipant, RawTypeSupport) liegen in org.zerodds.ddsrpc (runtime/java/src/main/java/org/zerodds/ddsrpc); der Name org.zerodds.rpc gehört der IDL-Java-Laufzeit. Die Schnittstellen und Fabrikmethoden in org.omg.dds.rpc (RequesterParams.create, RPCRuntime) rufen sie auf; der RPC-Codegenerator schreibt extends org.zerodds.ddsrpc.RequesterImpl<…> (interface_java.rs, RPC_IMPL). Die Tests der RPC-Bereiche (java_rpc_runtime, java_enhanced_codec, type_pair_java, interface_bindings, java_psm_mapping) lesen die Klassen aus dem neuen Pfad. (Commit ed38a660164)

§7.3 Infrastructure Module

§7.3 Zwei Pakete `org.omg.dds.core` und `org.omg.dds.core.policy`

Spec: §7.3, S. 18 — “This PSM realizes the Infrastructure Module from the DDS specification with two packages: org.omg.dds.core and org.omg.dds.core.policy. The latter contains all QoS policy classes, since a given QoS policy may apply to multiple DDS Entity types. The former contains all other Infrastructure types, including for example Entity and Condition base interfaces.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/, crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/

Status: done — org.omg.dds.core enthält DDSObject, Entity, ServiceEnvironment, InstanceHandle, Time, Duration, Condition, WaitSet, GuardCondition, StatusCondition, EntityQos, QosProvider und die Ausnahmen; org.omg.dds.core.policy die Policies mit PolicyFactory. Die Status liegen in org.omg.dds.core.status, die Ereignisse in org.omg.dds.core.event, wie in den OMG-Quellen. Die Tests importieren und benutzen die Typen aus diesen Paketen; RpcInheritanceTest prüft den Paketnamen von DDSObject. (Commit 5041698cee3) ### §7.3 Begründung: zwei Pakete, Name „core“

Spec: §7.3, S. 18 — “Design Rationale (non-normative) These two packages have been made distinct from one another for two reasons: […]”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ. ### §7.3.1 ServiceEnvironment als Wurzel aller Objekte, Erzeugen über ein internes SPI

Spec: §7.3.1, S. 18 — “A ServiceEnvironment object represents an instantiation of a Service implementation within a JVM. It is the “root” for all other DDS objects and assists in their creation by means of an internal service-provider interface.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.getSPI), crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.ServiceProviderInterface), crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipantFactory.java (DomainParticipantFactory.getInstance), crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.getEnvironment)

Status: done — CoreSpiTest ruft newInstanceHandle, invalidTime, newQosProvider, newTypeSupport, newKeyedString und newKeyedBytes des SPI auf und prüft mit assertSame(env, x.getEnvironment()) Participant, Publisher, Subscriber, Topic, Writer, Reader, Status-Condition, Zeit und Sample einer von new ServiceEnvironmentImpl() erzeugten Umgebung. DataWriterImpl und DataReaderImpl übernehmen die Umgebung ihres Parent (vorher Values.getDefaultEnvironment()). (Commit 26684105d79) ### §7.3.1 Alle zustandsbehafteten Typen implementieren DDSObject (getEnvironment)

Spec: §7.3.1, S. 18 — “All stateful types in this PSM implement an interface DDSObject, through a getServiceEnvironment method on which they can provide access to the ServiceEnvironment from which they are ultimately derived.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/DDSObject.java (DDSObject.getEnvironment)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/rpc/RpcInheritanceTest.java::ddsObjectCarriesTheOneOperationTheClauseNames

Status: done — Die Operation heißt in den OMG-Quellen getEnvironment. DDSObject hat genau diese eine Operation; der Test prüft Name, Rückgabetyp ServiceEnvironment, Parameterzahl 0 und das Paket org.omg.dds.core. Welche Typen die Schnittstelle erweitern, behandelt das Item „§7.3.1 Entitäten, Factory und Werttypen implementieren DDSObject“. (Commit 5041698cee3) ### §7.3.1 Entitäten, Factory und Werttypen implementieren DDSObject

Spec: §7.3.1, S. 18 — “All stateful types in this PSM implement an interface DDSObject […]”

Status: done — DDSException hat implements DDSObject wie die OMG-Quelle; die konkreten Ausnahmen in org.zerodds.core liefern über getEnvironment() die beim Erzeugen übergebene oder die Standard-Umgebung. CoreSpiTest prüft assertSame(env, x.getEnvironment()) für Participant, Publisher, Subscriber, Topic, Writer und Reader; CoreExceptionsTest prüft es für die Ausnahmen. (Commit b1b698778d6) ### §7.3.1 ServiceEnvironment implementiert DDSObject und gibt this zurück

Spec: §7.3.1, S. 18 — “(ServiceEnvironment itself implements this interface; a ServiceEnvironment always returns this from its getServiceEnvironment operation.)”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment.getEnvironment)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/rpc/RpcInheritanceTest.java::aServiceEnvironmentReturnsItself

Status: done — ServiceEnvironment implements DDSObject, getEnvironment() ist final und gibt this zurück. Der Test prüft die Zuweisbarkeit an DDSObject und dass eine Unterklasse (RPCRuntime) sich selbst zurückgibt. (Commit 5041698cee3) ### §7.3.1 Ohne statischen Zustand möglich, mehrere Implementierungen nebeneinander

Spec: §7.3.1, S. 18 — “The ServiceEnvironment class allows implementations to avoid the presence of static state, if desired. It also allows multiple DDS implementations—or multiple versions of the “same” implementation—to potentially coexist within the same Java run-time environment.”

Repo: —

Tests: —

Status: n/a (informative) — Erlaubnis und Zweck. ZeroDDS hält statischen Zustand: ServiceEnvironmentImpl.DEFAULT, InProcessBus.INSTANCE, DurabilityService.INSTANCE, RtpsParticipant.BY_DOMAIN, ReflectionTypeSupport.CACHE. Zwei ServiceEnvironment im selben JVM teilen damit Bus und Durability-Daten (aus dem Code gelesen, nicht gemessen). DomainParticipantFactory ist dagegen je Umgebung getrennt (Item „§7.3.1 ServiceEnvironment als Wurzel aller Objekte“). ### §7.3.1 Erster Schritt der Anwendung: ein ServiceEnvironment anlegen

Spec: §7.3.1, S. 18 — “A DDS application’s first step is to instantiate a ServiceEnvironment, which represents the DDS implementation that it will use. From there, it can create all of its additional DDS objects.”

Repo: —

Tests: —

Status: n/a (informative) — Beschreibt den Ablauf einer Anwendung. Bei ZeroDDS ist der Schritt nötig: DomainParticipantFactory.getInstance(ServiceEnvironment) hat in den OMG-Quellen kein Gegenstück ohne Argument und wirft bei null eine NullPointerException (QuickstartApiTest.getInstanceRejectsNullEnvironment). ### §7.3.1 ServiceEnvironment ist abstrakt

Spec: §7.3.1, S. 18 — “The ServiceEnvironment class is abstract.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/ServiceEnvironment.java (ServiceEnvironment)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::theServiceEnvironmentIsAbstract

Status: done — CoreSpiTest prüft Modifier.isAbstract(ServiceEnvironment.class.getModifiers()), dass getSPI abstrakt ist und dass ServiceEnvironmentImpl eine konkrete Unterklasse ist. (Commit 5041698cee3) ### §7.3.1 createInstance sucht die Unterklasse über eine Systemeigenschaft

Spec: §7.3.1, S. 18 — “To avoid compile-time dependencies on concrete ServiceEnvironment implementations, an application can instantiate a ServiceEnvironment by means of a static createInstance method on the ServiceEnvironment class. This method looks up a concrete ServiceEnvironment subclass using a Java system property containing the name of that subclass.”

Status: done — createInstance(ClassLoader) liest die Systemeigenschaft org.omg.dds.serviceClassName; createInstance(String, Map, ClassLoader) liest eine frei benannte Eigenschaft und wirft ServiceConfigurationException, wenn sie fehlt oder die Klasse nicht ladbar ist. Die Datei ist byte-gleich zur OMG-Quelle. Der erste Test setzt die Eigenschaft auf org.zerodds.ServiceEnvironmentImpl und erhält eine nutzbare Umgebung, der zweite prüft die unbekannte Klasse; den Fall einer fehlenden Eigenschaft prüft kein Test. (Commit 5041698cee3) ### §7.3.1 Unterklasse mit eigenem Namen von der Implementierung

Spec: §7.3.1, S. 18 — “This subclass must be provided by implementers and will therefore have an implementation-specific name.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentBootstrapBySystemProperty

Status: done — org.zerodds.ServiceEnvironmentImpl extends ServiceEnvironment hat einen öffentlichen Konstruktor ohne Argument und einen mit Map. Der Test lädt die Klasse über diesen Namen mit createInstance und benutzt das Ergebnis; er prüft den Laufzeittyp nicht ausdrücklich. (Commit 7d991374fd4) ### §7.3.1 Factory-Methode für DynamicTypeFactory

Spec: §7.3.1, S. 18 — “ServiceEnvironment provides factory methods for the following objects: DynamicTypeFactory, WaitSet, GuardCondition, TypeSupport, Time, Duration, and InstanceHandle.”

Status: done — ServiceProviderInterface.getTypeFactory liefert die DynamicTypeFactoryImpl der Umgebung, DynamicTypeFactory.getInstance(env) ruft sie. Der erste Test ruft getTypeFactory().getPrimitiveType(INT_32_TYPE), der zweite legt über DynamicTypeFactory.getInstance(ENV) einen Sequenztyp an. (Commit 7d991374fd4) ### §7.3.1 Factory-Methode für WaitSet

Spec: §7.3.1, S. 18 — “ServiceEnvironment provides factory methods for the following objects: […] WaitSet […]”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/WaitSet.java (WaitSet.newWaitSet), crates/java-omgdds/java/src/main/java/org/zerodds/ServiceEnvironmentImpl.java (ServiceEnvironmentImpl.ZeroSPI.newWaitSet), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl)

Status: done — ServiceProviderInterface.newWaitSet und WaitSet.newWaitSet(env) liefern ein WaitSetImpl. Der erste Test prüft, dass newWaitSet() ein Objekt liefert; WaitSetTest benutzt WaitSet.newWaitSet(ENV) und prüft Anhängen, Abhängen, Warten mit Zeitgrenze (TimeoutException) und Aufwecken durch eine Bedingung. (Commit fc054ce9926) ### §7.3.1 Factory-Methode für GuardCondition

Spec: §7.3.1, S. 18 — “ServiceEnvironment provides factory methods for the following objects: […] GuardCondition […]”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionIsFalseAtFirstAndTheWaitSetKnowsWhatIsAttached, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aGuardConditionSetFromAnotherThreadEndsABlockedWaitAndIsReported

Status: done — ServiceEnvironment.ServiceProviderInterface.newGuardCondition liefert ein GuardConditionImpl; GuardCondition.newGuardCondition(env) delegiert dorthin. Die Tests prüfen, dass die Fabrik ein Objekt liefert, dass die Bedingung zunächst false ist und dass ein Setzen aus einem anderen Thread einen blockierten WaitSet beendet. (Commit fc054ce9926) ### §7.3.1 Factory-Methode für TypeSupport

Spec: §7.3.1, S. 18 — “ServiceEnvironment provides factory methods for the following objects: […] TypeSupport […]”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aTypeSupportIsRegisteredUnderTheFullyQualifiedNameOfTheType

Status: done — org/omg/dds/type/TypeSupport.newTypeSupport(Class, ServiceEnvironment) ruft die Quelle mit type.getClass().getName() auf, das ist „java.lang.Class“ für jeden Typ; ServiceEnvironmentImpl.newTypeSupport liest diesen Namen als „kein Name angegeben“ und registriert den Typ unter type.getName(). CoreSpiTest erzeugt ein TypeSupport über TypeSupport.newTypeSupport und ServiceProviderInterface.newTypeSupport und prüft den Namen ([B für byte[], der angegebene Name sonst). Die Datei ist die der OMG-Quelle (CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource). (Commit 7431a7d599c) ### §7.3.1 Factory-Methode für Time

Spec: §7.3.1, S. 18 — “ServiceEnvironment provides factory methods for the following objects: […] Time […]”

Status: done — TimeImpl.split liefert für jeden negativen Wert in jeder Einheit den ungültigen Zeitpunkt (Sekunden -1, Nanosekunden 0); ModifiableTimeImpl.add/subtract rechnen über TimeImpl.shift mit Normalisierung und Ergebnis ungültig vor der Epoche. Tests: newTime(-5, u) für alle TimeUnit-Werte ungültig, invalidTime() ungültig, newTime(0, NANOSECONDS) gültig. (Commit 4c28bc52254) ### §7.3.1 Factory-Methode für Duration

Spec: §7.3.1, S. 18 — “ServiceEnvironment provides factory methods for the following objects: […] Duration […]”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::timeAndDurationKeepTheirValueAndGetAnEnvironment, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::durationInfiniteRecognized

Status: done — newDuration(long, TimeUnit), infiniteDuration() und zeroDuration() liefern DurationImpl der Umgebung; DurationImpl.of setzt die Größe Long.MAX_VALUE auf unendlich. Die Tests prüfen newDuration(7, SECONDS) nach Serialisierung, isInfinite() und isZero() der beiden Fabriken sowie getDuration(SECONDS) == Long.MAX_VALUE für unendlich. (Commit 819bfcb46cb) ### §7.3.1 Factory-Methode für InstanceHandle

Spec: §7.3.1, S. 18 — “ServiceEnvironment provides factory methods for the following objects: […] and InstanceHandle.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::instanceHandleNilDetected, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreSpiTest.java::aNewInstanceHandleIsNilAndIsFilledByCopyFrom

Status: done — CoreSpiTest erzeugt über newInstanceHandle() ein ModifiableInstanceHandle, prüft isNil(), füllt es mit copyFrom (Wert 42 im vierten Byte) und prüft Gleichheit, Nicht-Nil und verschiedene Objekte je Aufruf. (Commit 819bfcb46cb) ### §7.3.1 Hilfsfunktionen allStatusKinds und noStatusKinds

Spec: §7.3.1, S. 18 — “It also provides helper functions allStatuses and noStatuses to create special instances of Status objects.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories

Status: done — Die Hilfsfunktionen heißen allStatusKinds() und noStatusKinds() und liegen im ServiceProviderInterface. allStatusKinds enthält die 13 Statusklassen (ServiceEnvironmentImpl.allStatusKinds), noStatusKinds ist leer. Der Test prüft Größe 13 und die leere Menge; die Zugehörigkeit der einzelnen Klassen prüft er nicht. (Commit 7d991374fd4) ### §7.3.2 ReturnCode_t als Java-Ausnahmen

Spec: §7.3.2, S. 18 — “The PSM maps the ReturnCode_t type from the DDS PIM into a combination of standard Java exceptions (where their semantics match those expressed in the PIM) and new exception classes defined by this PSM.”

Status: done — Die Zuordnung der Tabelle 7.1 über Ausnahmeklassen (org.omg.dds.core.*Exception, konkrete Klassen in org.zerodds.core) ist für alle Zeilen mit einem Test belegt: ERROR, UNSUPPORTED, IMMUTABLE_POLICY, INCONSISTENT_POLICY, OUT_OF_RESOURCES, PRECONDITION_NOT_MET, ALREADY_DELETED, NOT_ENABLED, BAD_PARAMETER. ILLEGAL_OPERATION hat die Klasse und den Reflexionstest, aber keine Operation, die sie auslöst (DDS 1.4 nennt keine). TIMEOUT: siehe Item „RETCODE_TIMEOUT“ (partial). (Commit b1b698778d6) ### §7.3.2 Alle Ausnahmen ungeprüft außer TimeoutException

Spec: §7.3.2, S. 18 — “With the exception of java.util.concurrent.TimeoutException, all exceptions are unchecked (that is, they extend java.lang.RuntimeException directly or indirectly).”

Status: done — CoreExceptionsTest prüft für alle sieben Klassen der Tabelle 7.1, DDSException, ServiceConfigurationException und ServiceInitializationException, dass sie RuntimeException erweitern, und dass TimeoutException (java.util.concurrent) geprüft ist und von WaitSet.waitForConditions, DataWriter.write und DomainParticipant.findTopic deklariert wird. (Commit 7f18142b5e1) ### §7.3.2 Eigene Ausnahmen mit Basis DDSException in org.omg.dds.core, abstrakt

Spec: §7.3.2, S. 19 — “The exception classes defined by this PSM extend the base class DDSException. All of the PSM-defined exception classes are defined in the package org.omg.dds.core. All of these classes are abstract so as not to specify the representation of state; implementations shall provide concrete implementations.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::everyPsmExceptionIsAnUncheckedDdsException, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::everyTable71ExceptionIsAnAbstractDdsExceptionOfOrgOmgDdsCore, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::theExceptionsKeepTheSerialVersionUidOfTheOmgSource

Status: done — CoreExceptionsTest prüft per Reflexion, dass die sieben Klassen der Tabelle 7.1 abstrakt sind, in org.omg.dds.core liegen und DDSException direkt erweitern, dass DDSException abstrakt ist und dass org.zerodds.core zu jeder eine konkrete Klasse hat. Die serialVersionUID aller Ausnahmen der OMG-API entspricht jetzt der OMG-Quelle (vorher -1L bis -5L an fünf Klassen und ein anderer Wert an ServiceInitializationException). (Commit b1b698778d6) ### §7.3.2 Table 7.1: RETCODE_OK

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_OK | Normal return; no exception.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — DataWriter.write ist void; ein erfolgreicher Aufruf kehrt ohne Ausnahme zurück. Der Test schreibt zwei Samples ohne Ausnahme und nimmt beide am Reader. (Commit f31b6fa11b5) ### §7.3.2 Table 7.1: RETCODE_NO_DATA

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_NO_DATA | An informational state (e.g., a Boolean result) attached to a normal return; no exception.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::volatileDoesNotReplayToLateJoiner

Status: done — Ohne Samples liefert take(List) eine leere Liste ohne Ausnahme; es gibt kein ReturnCode.NO_DATA. Der Test nimmt an einem laufenden Reader ohne Daten und prüft Länge 0. (Commit f31b6fa11b5) ### §7.3.2 Table 7.1: RETCODE_ERROR

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_ERROR | DDSException”

Status: done — org.zerodds.core.ErrorException ist die konkrete Klasse zu DDSException (RETCODE_ERROR). DataWriterImpl.serialize meldet einen Encoder, der das Sample ablehnt (XcdrException), als ErrorException mit der Ursache. Die Tests: Klasse konkret mit Oberklasse DDSException; ein Writer mit einem solchen Typ-Support wirft ErrorException und bleibt benutzbar. (Commit 26684105d79) ### §7.3.2 Table 7.1: RETCODE_BAD_PARAMETER

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_BAD_PARAMETER | java.lang.IllegalArgumentException”

Status: done — Eine negative History-Tiefe, ein Handle falscher Länge und ein null-Handle bei getMatchedSubscriptionData werfen IllegalArgumentException. Die drei Tests prüfen genau diese Ausnahme; weitere Tests prüfen sie für ungültige Filterausdrücke, Typdeskriptoren und MultiTopic-Ausdrücke (ContentFilterTest, DynamicTypeReflectionTest, MultiTopicTest). (Commit f31b6fa11b5) ### §7.3.2 Table 7.1: RETCODE_BAD_PARAMETER bei null

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_BAD_PARAMETER | java.lang.IllegalArgumentException”

Status: done — getMatchedSubscriptionData(null) und getMatchedPublicationData(null) werfen IllegalArgumentException. DomainParticipantFactory.getInstance(null) wirft NullPointerException (Quelle der OMG-API: env.getSPI()); QuickstartApiTest.getInstanceRejectsNullEnvironment legt das fest. Ein Handle, der keine Instanz des Writers benennt, ist IllegalArgumentException (CoreForeignValuesTest::aForeignHandleThatNamesNoInstanceOfTheWriterIsABadParameter, DDS 1.4 §2.2.2.4.2.11). Jede Operation von DomainParticipant, Publisher, Subscriber, Topic, DataWriter und DataReader mit einem Objektargument wirft bei null IllegalArgumentException (Table 7.1: RETCODE_BAD_PARAMETER) und keine NullPointerException (org.zerodds.core.Args.require am Eingang der Operationen: Namen, Typen, QoS, Topics, Handles, Zeitstempel, Einheiten, Bedingungen, Samples). null behält eine Bedeutung, wo DDS oder die PSM sie vergibt: Listener und Statusmenge „keine“, ein Schlüsselhalter oder eine Liste, die neu angelegt werden, der Nil-Handle bei write, dispose und unregisterInstance, null als Selektor von read und take. NullArgumentTest ruft über Reflection jede Operation dieser sechs Schnittstellen je Parameter mit null auf (109 Aufrufe) und verlangt IllegalArgumentException. (Commit eb7377e1f7e) ### §7.3.2 Table 7.1: RETCODE_TIMEOUT

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_TIMEOUT | java.util.concurrent.TimeoutException”

Status: done — java.util.concurrent.TimeoutException wird geworfen von WaitSetImpl.waitForConditions(Duration), DomainParticipantImpl.findTopic, DataWriterImpl.waitForAcknowledgments und PublisherImpl.waitForAcknowledgments (Reader in anderen Prozessen quittieren per ACKNACK), DataReaderImpl.waitForHistoricalData (RTPS-Zweig) und von write, wenn RESOURCE_LIMITS erreicht sind und max_blocking_time abläuft: bei einem TRANSIENT_LOCAL-Writer an den behaltenen Samples, bei einem zuverlässigen KEEP_ALL-Writer mit max_samples an den Samples, die Reader in anderen Prozessen noch nicht quittiert haben (WireWriter.awaitHistorySpace). Ein BEST_EFFORT-Writer wartet nicht und meldet OutOfResourcesException. (Commit 1d0691890fa) ### §7.3.2 Table 7.1: RETCODE_UNSUPPORTED

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_UNSUPPORTED | java.lang.UnsupportedOperationException”

Status: done — UnsupportedOperationException ist für ein anderes URI-Schema als file (QosProviderImpl), für ein Topic und für eine TopicDescription einer anderen Implementierung (PublisherImpl.codecOf, SubscriberImpl.codecOf) und für eine ContentFilteredTopic einer anderen Implementierung getestet. SubscriberImpl.createDataReader warf für Letztere AlreadyClosedException; es ist jetzt UnsupportedOperationException. (Commit b315020c678) ### §7.3.2 Table 7.1: RETCODE_ALREADY_DELETED

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_ALREADY_DELETED | AlreadyClosedException”

Status: done — Nach close() werfen write, read, take, createDataWriter, createDataReader, createPublisher und createTopic AlreadyClosedException (Unterklasse von org.omg.dds.core.AlreadyClosedException). Die Tests prüfen die Ausnahme für geschlossene Writer, Reader, Publisher, Subscriber und Participants. (Commit f31b6fa11b5) ### §7.3.2 Table 7.1: RETCODE_ILLEGAL_OPERATION

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_ILLEGAL_OPERATION | IllegalOperationException”

Status: done — Nach DDS 1.4 §2.2.2.4.1.9, §2.2.2.4.1.11 und §2.2.2.5.2.9 sind resume_publications ohne suspend_publications, end_coherent_changes ohne begin_coherent_changes und end_access ohne begin_access PRECONDITION_NOT_MET, und suspend_publications wie begin_coherent_changes lassen sich schachteln; der Code warf IllegalOperationException. PublisherImpl zählt jetzt die Tiefe und wirft PreconditionNotMetException, SubscriberImpl.endAccess ebenso. ILLEGAL_OPERATION: Klasse org.zerodds.core.IllegalOperationException und Zuordnung sind vorhanden und per Reflexion getestet; keine Operation des Bindings löst sie aus, DDS 1.4 nennt keine. (Commit b315020c678) ### §7.3.2 Table 7.1: RETCODE_NOT_ENABLED

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_NOT_ENABLED | NotEnabledException”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl.write), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.ensureEnabled), crates/java-omgdds/java/src/main/java/org/zerodds/core/NotEnabledException.java (NotEnabledException)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aNotEnabledWriterRefusesToWrite

Status: done — Ein nicht aktivierter DataWriter wirft bei write, dispose und unregisterInstance NotEnabledException, ein nicht aktivierter DataReader bei read und take (DataReaderImpl.ensureEnabled). Der Test prüft write an einem Writer ohne enable. dispose, unregisterInstance und der Reader sind nicht getestet. (Commit f31b6fa11b5) ### §7.3.2 Table 7.1: RETCODE_PRECONDITION_NOT_MET

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_PRECONDITION_NOT_MET | PreconditionNotMetException”

Status: done — PreconditionNotMetException wird geworfen, wenn eine Bedingung vom WaitSet gelöst wird, an dem sie nicht hängt, bei getDiscoveredParticipantData mit unbekanntem Handle und bei getKeyValue an einem Typ ohne Schlüssel. Die zwei Tests prüfen die ersten beiden Fälle. (Commit 7f18142b5e1) ### §7.3.2 Table 7.1: RETCODE_IMMUTABLE_POLICY

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_IMMUTABLE_POLICY | ImmutablePolicyException”

Status: done — QosRules.checkChange prüft bei DataWriterImpl.setQos, DataReaderImpl.setQos und TopicImpl.setQos eines aktivierten Objekts nur die Policies mit Changeable = No (DDS 1.4 §2.2.3; dazu DATA_REPRESENTATION und TYPE_CONSISTENCY_ENFORCEMENT nach XTypes 1.3): DURABILITY, DURABILITY_SERVICE, PRESENTATION, OWNERSHIP, LIVELINESS, RELIABILITY, DESTINATION_ORDER, HISTORY, RESOURCE_LIMITS. Eine Änderung von TRANSPORT_PRIORITY, USER_DATA oder TIME_BASED_FILTER wird übernommen. Ein nicht aktiviertes Objekt nimmt jede Änderung an. PublisherImpl.setQos, SubscriberImpl.setQos und DomainParticipantImpl.setQos prüfen ebenfalls mit QosRules.checkChange. (Commit a9c313e5fcb) ### §7.3.2 Table 7.1: RETCODE_INCONSISTENT_POLICY

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_INCONSISTENT_POLICY | InconsistentPolicyException”

Status: done — QosRules.checkConsistent wird beim Erzeugen (Konstruktor von TopicImpl, DataWriterImpl, DataReaderImpl) und in setQos aufgerufen und wirft InconsistentPolicyException bei History-KEEP_LAST-Tiefe über max_samples_per_instance, max_samples unter max_samples_per_instance und minimum_separation über der Deadline-Periode. Ein Grenzwert LENGTH_UNLIMITED und eine unendliche Deadline-Periode werden nicht verglichen. Publisher-, Subscriber- und Participant-QoS enthalten keine dieser Policies. Der Test prüft je Regel Erzeugen und setQos, dass das abgelehnte QoS das alte nicht ersetzt, und den Grenzfall der Gleichheit. (Commit a9c313e5fcb) ### §7.3.2 Table 7.1: RETCODE_OUT_OF_RESOURCES

Spec: §7.3.2, S. 19, Table 7.1 — “RETCODE_OUT_OF_RESOURCES | OutOfResourcesException”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreExceptionsTest.java::anEncodingBeyondTheLimitFailsWithOutOfResources

Status: done — DataWriterImpl.serialize(support, data, maxBytes) wächst den Puffer bis MAX_SAMPLE_BYTES (256 MiB) und wirft darüber OutOfResourcesException mit der BufferOverflowException als Ursache. Der Test setzt die Grenze auf 1024 Bytes: 1000 Bytes passen (Ergebnislänge 1000), 2000 Bytes ergeben die Ausnahme. (Commit 26684105d79) ### §7.3.2 Ausnahmen statt nil bei Operationen, die ein Objekt liefern

Spec: §7.3.2, S. 19 — “In addition, this PSM permits implementations to throw exceptions to indicate errors in operations that in the PIM return an object reference.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ExceptionMappingTest.java::aClosedEntityRefusesToCreateContainedEntities

Status: n/a (informative) — Erlaubnis, keine Pflicht. ZeroDDS macht davon Gebrauch: create* wirft AlreadyClosedException an einem geschlossenen Ersteller (ExceptionMappingTest.aClosedEntityRefusesToCreateContainedEntities) und IllegalArgumentException bei ungültigen Angaben. (Commit f31b6fa11b5) ### §7.3.2 Begründung: Fehler und Kontingenz

Spec: §7.3.2, S. 19 — “Design Rationale (non-normative) • This PSM uses checked and unchecked exceptions according to the following rationale: […]”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ. ### §7.3.3 Werttypen implementieren org.omg.dds.core.Value

Spec: §7.3.3, S. 20 — “All DDS types with value semantics implement the interface org.omg.dds.core.Value. These include QoS, QoS policy, status, time, and other types.”

Repo: —

Status: done — Das normative Archiv omgdds_src.zip enthält kein org.omg.dds.core.Value (die Dateien von org/omg/dds/core sind in Annex B aufgeführt); nach §2 gilt bei einem Widerspruch zwischen Text und Quellen die Quelle, und ein neuer Typ in org.omg.dds wäre eine Erweiterung nach §7.2.6. Die Typen mit Wertsemantik (Time, Duration, InstanceHandle, QoS, QoS-Policy, Status) haben die Eigenschaften, die §7.3.3 dem Interface zuschreibt: sie sind Serializable und Cloneable (clone() liefert eine Kopie nach Wert), equals und hashCode folgen dem Zustand, und copyFrom überschreibt bei den Modifiable-Typen den Zustand des Ziels (ValueCopyTest, CoreValuesTest). (Commit 265da1a816c) ### §7.3.3 Value erweitert Cloneable und Serializable

Spec: §7.3.3, S. 20 — “The Value interface extends the standard Java SE interfaces java.lang.Cloneable and java.io.Serializable, allowing objects of implementing types to be copied by value as well as serialized and deserialized using built-in Java mechanisms.”

Status: done — Time, Duration, InstanceHandle, QosPolicy, Status und EntityQos sind Serializable (die Tests serialisieren Zeit, Dauer, Policies und einen Status und vergleichen den Wert nach der Rückkehr) und ihre Klassen in org.zerodds sind Cloneable mit öffentlichem clone(): ValueCopyTest kopiert Zeit, Dauer, Handle, jede Policy der PolicyFactory, die QoS-Klassen und Status von Entitäten und prüft, dass die Kopie gleich, aber ein anderes Objekt ist und dass die Kopie einer ModifiableTime den späteren Änderungen der Quelle nicht folgt. Die Schnittstellen der OMG-Quelle selbst erweitern Cloneable nicht (kein Value, siehe das Item davor). (Commit 265da1a816c) ### §7.3.3 copyFrom überschreibt den Zustand des Ziels

Spec: §7.3.3, S. 20 — “It defines a method copyFrom that accepts a source object of the same type as the object itself. This method overwrites the state of the target object (“this”) with the state of the argument object. It is similar to clone but does not require allocating a new object.”

Status: done — ModifiableTimeImpl.copyFrom kopiert eine ungültige Quelle als ungültige Zeit und lehnt null mit IllegalArgumentException ab; ModifiableInstanceHandleImpl.copyFrom nimmt Fremdwerte an. copyFrom der vier Built-in-Topic-Datentypen überschreibt den ganzen Zustand des Ziels, auch das, was nur diese Implementierung hält (TypeInformation und TypeObject-Oktette, die bei einer fremden Quelle gelöscht werden); BuiltinDataCopyFromTest vergleicht Ziel und Quelle nach der Serialisierung als Built-in-Daten. Getestet sind außerdem ModifiableTime (gültig, ungültig, fremd), ModifiableInstanceHandle, BuiltinTopicKey und KeyedString. (Commit ecd51bcff6a) ### §7.3.3 equals und hashCode an Zeit, Handle, Policies und QoS

Spec: §7.3.3, S. 20 — “Value implementers are also expected to override their inherited implementations of Object.equals and Object.hashCode in order to enforce value semantics.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::timeAndDurationKeepTheirValueAndGetAnEnvironment, crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::policiesKeepTheirValue, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::factoryQosAndDefaultParticipantQos, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::equalTimesHaveEqualHashCodeAndCompareAsEqual, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::equalDurationsHaveEqualHashCodeAndOrderByLength, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreValuesTest.java::handlesWithTheSameOctetsAreEqualAndHaveTheSameHashCode, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::equalPoliciesHaveEqualHashCodes, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::equalQosHaveEqualHashCodes

Status: done — CoreValuesTest und CoreStatusPolicyTest prüfen, dass gleiche Time-, Duration-, InstanceHandle-, Policy- und Entity-QoS-Objekte gleiche hashCode haben (alle Fabrikmethoden von PolicyFactory je zweimal erzeugt, gleich und gleicher Hash). equals über Implementierungsgrenzen (Fremd-Time, -Duration, -Handle) ist ebenfalls getestet. Die Status-Klassen sind im Item „equals und hashCode an Status“ abgedeckt. (Commit 819bfcb46cb) ### §7.3.3 equals und hashCode an Status

Spec: §7.3.3, S. 20 — “Value implementers are also expected to override their inherited implementations of Object.equals and Object.hashCode in order to enforce value semantics.”

Status: done — Alle 13 Status-Klassen in org.zerodds.core.status überschreiben equals und hashCode über Zähler, Handles, Policy-Klasse und Policy-Mengen; getPolicies() der beiden Incompatible-QoS-Status liefert eine nicht änderbare Menge. CoreStatusPolicyTest vergleicht je Klasse gleiche Werte (gleich, gleicher Hash) und einen abweichenden Wert (ungleich); Handle-Objekte verschiedener Identität mit gleichen Bytes ergeben gleiche Status. (Commit 12325622fcf) ### §7.3.3 QoS-Policies unveränderlich

Spec: §7.3.3, S. 20 — “QoS policy objects are immutable. New policy objects can be created from existing policy objects by using the QoS DSL described in sub clause 7.3.5.3.”

Status: done — UserDataImpl, TopicDataImpl und GroupDataImpl kopieren das Array im Konstruktor und in getValue; PartitionImpl.getName liefert eine nicht änderbare Sicht. CoreStatusPolicyTest prüft, dass ein verändertes Quell- oder Rückgabe-Array den Wert nicht ändert, dass withValue/withName/withPolicy das Original unverändert lassen und dass Partition.getName().add eine UnsupportedOperationException ergibt. (Commit 12325622fcf) ### §7.3.3 Begriff Werttyp

Spec: §7.3.3, S. 20, Fußnote 2 — “The term “value type” refers to any data type for which object identity is considered to be established solely based on the state of the objects of that type.”

Repo: —

Tests: —

Status: n/a (informative) — Begriff. ### §7.3.4 Time_t und Duration_t als Werttypen Time und Duration

Spec: §7.3.4, S. 20 — “This PSM maps the DDS Time_t and Duration_t types into the value types Time and Duration respectively.”

Status: done — Time und Duration sind Klassen in org.omg.dds.core mit Sekunden und Nanosekunden, Wertsemantik (equals, hashCode, Comparable, Serializable) und den Umsetzungen TimeImpl und DurationImpl. Die Tests prüfen die Umrechnung aus Millisekunden, die unendliche Dauer und den Wertvergleich nach Serialisierung. Die gemeinsame Basis Value betrifft das Item „§7.3.3 Werttypen implementieren org.omg.dds.core.Value“. (Commit 819bfcb46cb) ### §7.3.4 Größe in Einheiten von TimeUnit

Spec: §7.3.4, S. 20 — “These classes can provide their magnitude using a variety of units (expressed using java.util.concurrent.TimeUnit).”

Status: done — Time.getTime(TimeUnit), Time.getRemainder(TimeUnit, TimeUnit) und Duration.getDuration(TimeUnit) geben die Größe in der gewählten Einheit zurück. Der Test prüft getTime in Sekunden und Millisekunden und getRemainder in Nanosekunden; ein zweiter prüft getDuration(SECONDS) an zwei Policies (5 und 7). (Commit 819bfcb46cb) ### §7.3.4 Begründung: Namen ohne _t

Spec: §7.3.4, S. 20 — “Design Rationale (non-normative) The names of these types omit the underscore and ‘t’ characters from the ends of their names.”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ. ### §7.3.5 Policies mit Basis org.omg.dds.core.policy.QosPolicy

Spec: §7.3.5, S. 20 — “This PSM represents the former with the base interface org.omg.dds.core.policy.QosPolicy and the latter with the base interface org.omg.dds.core.EntityQos.”

Status: done — org.omg.dds.core.policy.QosPolicy ist die Basis aller Policy-Schnittstellen (Reliability, History, UserData …), mit den Markerschnittstellen ForDataReader, ForDataWriter usw. Die Tests übersetzen und benutzen die Policies über EntityQos<P extends QosPolicy> (get(Reliability.class), withPolicy). (Commit 5041698cee3) ### §7.3.5 QoS einer Entität mit Basis org.omg.dds.core.EntityQos

Spec: §7.3.5, S. 20 — “[…] and the latter with the base interface org.omg.dds.core.EntityQos.”

Status: done — org.omg.dds.core.EntityQos ist die Basis von DomainParticipantQos, PublisherQos, SubscriberQos, TopicQos, DataWriterQos und DataReaderQos; QosProfile gibt es nicht mehr. Die Tests lesen Policies mit get(Class) aus Reader-, Topic- und Writer-QoS und vergleichen QoS-Objekte mit assertEquals. (Commit 7d991374fd4) ### §7.3.5.1 Table 7.2: Policy als Schnittstelle mit Eigenschaften nach Java Beans

Spec: §7.3.5.1, S. 21, Table 7.2 — “QoS policy structure containing the state of an instance of that policy. | QoS policy interface extending org.omg.dds.core.policy.QosPolicy. Each policy provides Java Bean-style properties.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::reliabilityAndHistoryQosDefaults

Status: done — Die Policies sind Schnittstellen, die QosPolicy erweitern, mit Eigenschaften nach Java Beans (getKind, getDepth, getMaxBlockingTime, withKind, …); Durability ist eine Schnittstelle mit getKind und der Enum Durability.Kind. Der Test liest getKind und getDepth an Reader-, Topic- und Writer-QoS. (Commit 5041698cee3) ### §7.3.5.1 Table 7.2: ID einer Policy als Class<? extends QosPolicy>

Spec: §7.3.5.1, S. 21, Table 7.2 — “Unique QoS policy ID, represented by an instance of the enumeration QosPolicyId_t. | Java platform provides “Class object,” which uniquely identifies a QoS policy. The id will be represented by an object of Class<? extends QosPolicy> (for example, Class).”

Status: done — Die ID einer Policy ist ihr Class-Objekt: EntityQos ist eine Map<Class<? extends P>, P> mit get(Class), QosCompatibility.incompatiblePolicyWith liefert die ablehnende Policy als Klasse. Die Tests lesen get(Reliability.class) und prüfen Reliability.class als Ergebnis von incompatiblePolicyWith. (Commit c060b572340) ### §7.3.5.1 Table 7.2: Name einer Policy über Reflection

Spec: §7.3.5.1, S. 21, Table 7.2 — “Unique QoS policy name, represented by a string property QosPolicy.name. | Java reflection provides the necessary capability to obtain name of a QoSPolicy class.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/QosPolicy.java (QosPolicy)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreStatusPolicyTest.java::thePolicyNameIsTheSimpleNameOfItsClass

Status: done — CoreStatusPolicyTest prüft für 22 Policy-Namen (UserData, TopicData, GroupData, TransportPriority, Lifespan, Durability, Presentation, Deadline, LatencyBudget, Ownership, OwnershipStrength, Liveliness, TimeBasedFilter, Partition, Reliability, DestinationOrder, History, ResourceLimits, EntityFactory, WriterDataLifecycle, ReaderDataLifecycle, DurabilityService), dass Class.getSimpleName() dem Namen entspricht, die Klasse eine QosPolicy-Schnittstelle ist und die Methode gleichen Namens in PolicyFactory (außer TopicData, Presentation: dort ohne Fabrikmethode) diesen Typ liefert. (Commit 5041698cee3) ### §7.3.5.1 PolicyFactory erzeugt neue Policies

Spec: §7.3.5.1, S. 21 — “The org.omg.dds.core.policy.PolicyFactory interface allows creation of new default-initiated policy objects.”

Status: done — org.omg.dds.core.policy.PolicyFactory erzeugt je Policy ein Objekt mit Vorgabewerten (Reliability(), History(), UserData() …); PolicyFactoryImpl setzt es um, ServiceProviderInterface.getPolicyFactory und EntityQos.getPolicyFactory liefern die Fabrik. Der Test prüft, dass die Fabrik Reliability() liefert; die QoS-Tests erzeugen alle Policies darüber. (Commit 5041698cee3) ### §7.3.5.1 Vorgaben der PolicyFactory nicht festgelegt

Spec: §7.3.5.1, S. 21 — “The default state of the newly created policy objects via the PolicyFactory interface is unspecified.”

Repo: —

Tests: —

Status: n/a (informative) — Keine Anforderung an die Werte. ### §7.3.5.1 Begründung: Policies ausdrücklich setzen

Spec: §7.3.5.1, S. 21 — “Design Rationale (non-normative) In general, to ensure portability, programmers are encouraged to explicitly specify policy parameters using the QoS DSL.”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ. ### §7.3.5.1 USER_DATA

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 109 (dds-1.2.pdf) — “USER_DATA | A sequence of octets: “value” | […] The default value is an empty (zero-sized) sequence.”

Status: done — UserData ist eine Policy mit getValue() (Oktettfolge) und withValue(byte[], int, int); sie gehört zu DomainParticipant-, DataWriter- und DataReader-QoS und ist standardmäßig leer. Die Tests prüfen die Länge 0 beim Participant und dass die Werte {1,2,3} des Writers und {4} des Readers an die Gegenseite gemeldet werden. (Commit 7d991374fd4) ### §7.3.5.1 TOPIC_DATA

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 110 (dds-1.2.pdf) — “TOPIC_DATA | A sequence of octets: “value” | […] The default value is an empty (zero-sized) sequence.”

Status: done — TopicData ist eine Policy mit getValue() und withValue(byte[], int, int) in der Topic-QoS; PolicyFactoryImpl.TopicData und TopicQosImpl.defaults liefern eine leere Folge. Der Test in BuiltinTopicQosTest setzt {5,6,7,8,9} und prüft die Ankunft in den Built-in-Topic-Daten über SEDP; QosTypesTest::theDefaultsOfTopicPublisherAndSubscriberQos prüft die Vorgabe „leer“, QosProviderTest liest TOPIC_DATA aus base64. ### §7.3.5.1 GROUP_DATA

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 110 (dds-1.2.pdf) — “GROUP_DATA | A sequence of octets: “value” | […] The default value is an empty (zero-sized) sequence.”

Status: done — GroupData ist eine Policy mit getValue() und withValue(byte[], int, int) in Publisher- und Subscriber-QoS; PolicyFactoryImpl.GroupData liefert eine leere Folge. BuiltinTopicQosTest setzt {9,8} am Publisher und prüft die Ankunft in den Built-in-Topic-Daten und die SEDP-Hin- und Rückumwandlung; QosTypesTest::theDefaultsOfTopicPublisherAndSubscriberQos prüft die Vorgabe „leer“ an Publisher- und Subscriber-QoS, QosTypesTest::thePublisherAndSubscriberQosAnswerPresentationEntityFactoryAndGroupData den gesetzten Wert an beiden. ### §7.3.5.1 DURABILITY

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 110 (dds-1.2.pdf) — “DURABILITY | A “kind”: VOLATILE, TRANSIENT_LOCAL, TRANSIENT, or PERSISTENT”

Status: done — Durability ist eine Policy-Schnittstelle mit Durability.Kind (VOLATILE, TRANSIENT_LOCAL, TRANSIENT, PERSISTENT). Die Tests prüfen: TRANSIENT_LOCAL liefert einem später erzeugten Reader nach, VOLATILE nicht, TRANSIENT überlebt den Writer und endet mit dem Participant, PERSISTENT überlebt Writer und Participant. Die Ordnung beim Abgleich (QosCompatibility, angeboten >= gefordert) prüft QosRequestedOfferedTest::durabilityOfferedMustBeAtLeastRequestedInTheOrderVolatileToPersistent für alle 16 Paare, und aTransientLocalReaderIsRefusedByAVolatileWriter den Verbindungsabbruch mit REQUESTED_INCOMPATIBLE_QOS. PERSISTENT hat dauerhaften Speicher, wenn die Systemeigenschaft zerodds.durability.dir ein Verzeichnis nennt: org.zerodds.internal.DurabilityJournal schreibt je (Domäne, Topic, Typ) ein Journal, DurabilityService spielt es beim ersten Zugriff auf das Topic ein, geprüft in QosPersistentStoreTest (Neustart über DurabilityService.reset, Verlaufstiefe, entsorgte Instanz mit und ohne Verzögerung, abgeschnittener letzter Eintrag, TRANSIENT wird nicht geschrieben). Ohne die Eigenschaft liegt PERSISTENT im Arbeitsspeicher des Prozesses wie TRANSIENT. (Commit d0fb00b1341) ### §7.3.5.1 DURABILITY_SERVICE

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 111 (dds-1.2.pdf) — “DURABILITY_SERVICE | A duration”service_cleanup_delay”, a HistoryQosPolicyKind “history_kind”, and three integers: history_depth, max_samples, max_instances, max_samples_per_instance”

Status: done — DurabilityService ist eine Policy mit getServiceCleanupDelay, getHistoryKind, getHistoryDepth, getMaxSamples, getMaxInstances, getMaxSamplesPerInstance und den with…-Methoden in Topic- und DataWriter-QoS. Die Vorgaben der Fabrik sind jetzt Verzögerung 0, KEEP_LAST Tiefe 1 und LENGTH_UNLIMITED für die drei Grenzen (QosTypesTest::theDefaultsOfTheDataWriterQos). DataWriterImpl.retainForDurability übergibt Writer-Kennung, Policy und Zeitstempel an org.zerodds.internal.DurabilityService: Verlaufstiefe und Grenzen des Speichers kommen aus dieser Policy, nicht aus der HISTORY des Writers; ein Sample über einer Grenze löst OutOfResourcesException aus, bevor es zugestellt wird. service_cleanup_delay bestimmt, wann der Speicher eine Instanz vergisst: nach dispose, wenn kein Writer sie mehr schreibt und die Verzögerung seit beidem abgelaufen ist (DDS 1.4 §2.2.3.4); bis dahin meldet er einem späteren Reader die Instanz als NOT_ALIVE_DISPOSED. Die Uhr ist in den Tests ersetzbar (DurabilityService.useClock). Getestet in QosDurabilityServiceTest. (Commit 3389cd624cf) ### §7.3.5.1 PRESENTATION

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 111–112 (dds-1.2.pdf) — “PRESENTATION | An “access_scope”: INSTANCE, TOPIC, GROUP And two booleans: “coherent_access” “ordered_access””

Status: done — Presentation hat getAccessScope (INSTANCE, TOPIC, GROUP), isCoherentAccess und isOrderedAccess; Vorgabe INSTANCE/false/false (PolicyFactoryImpl.Presentation). Die Verträglichkeit wird abgeglichen: PresentationImpl.requestedOfferedContract verlangt angebotenen Umfang >= geforderter und bei geforderter coherent_access oder ordered_access die angebotene gleiche Eigenschaft; QosCompatibility nimmt die PRESENTATION von Publisher und Subscriber der beiden Endpunkte in den Abgleich (withPresentation), die Verletzung steht in REQUESTED_/OFFERED_INCOMPATIBLE_QOS (QosRequestedOfferedTest, alle neun Umfangspaare, coherent, ordered). coherent_access wirkt: die Mengen zwischen begin_coherent_changes und end_coherent_changes erreichen einen Reader in einem anderen Thread als Ganzes und, über RTPS, mit PID_COHERENT_SET. ordered_access mit access_scope TOPIC ordnet die Samples aller Instanzen eines Readers in einer Reihenfolge (orderedAccessWithScopeTopicReturnsTheSamplesOfAllInstancesInOneOrder). Mit access_scope GROUP ist get_datareaders bei ordered_access eine Liste, in der jeder Reader so oft vorkommt, wie er Samples hält, in der Reihenfolge des Schreibens (Quellzeitstempel bei BY_SOURCE_TIMESTAMP, sonst Ankunft über alle Reader des Prozesses), und read und take liefern höchstens ein Sample (DDS 1.4 §2.2.2.5.2.10, §2.2.2.5.3.8). Über RTPS trägt jedes Sample eines Writers eines Publishers mit GROUP PID_GROUP_SEQ_NUM (fortlaufend über alle Writer des Publishers), PID_WRITER_GROUP_INFO (GroupDigest_t: die ersten vier Oktette des MD5 über die CDR-Big-Endian-Folge der Entity-Ids der Writer, sortiert nach dem Wert als Little-Endian-Integer, GroupDigest.of) und in einem Satz PID_GROUP_COHERENT_SET; jeder Writer sendet am Ende des Satzes das End-Coherent-Set-DATA (DDSI-RTPS 2.5 §8.7.5, §8.7.6, §9.3.2.5, §9.6.4.3 bis §9.6.4.5). Die Writer eines Publishers mit GROUP senden HEARTBEATs mit dem GroupInfoFlag (0x08): currentGSN (größte vergebene Gruppennummer), firstGSN und lastGSN des Writers sowie writerSet und secureWriterSet (RtpsMessage.Builder.heartbeatGroup, DDSI-RTPS 2.5 §8.3.7.5, §9.4.5.7, §9.4.2.19); ein Writer ohne Sample sendet sie ebenfalls (leerer Bereich). Die Option zerodds.rtps.omit-heartbeat-group-digests (Rust: wire.omit_heartbeat_group_digests, Vorgabe aus) lässt writerSet und secureWriterSet weg. Ein Reader eines Subscribers mit GROUP gibt die Samples der Writer eines entfernten Publishers in der Reihenfolge der Gruppennummer weiter und einen Gruppensatz zusammen, wenn sein Ende da ist (GroupOrder). Fehlt die Nummer n, gilt sie nach §8.7.5 als nicht vorhanden, wenn ein HEARTBEAT currentGSN >= n meldet und jeder gezählte Writer (zugeordnet, RELIABLE, der Gruppe nach writerSet) sie nicht als seine ausweist: er hat ein Sample mit größerer Gruppennummer geliefert, oder sein HEARTBEAT mit currentGSN >= n hat einen Bereich [firstGSN, lastGSN], der n nicht enthält; ein Writer, von dem noch nichts gehört wurde, hält die Reihenfolge an. Ein Satz mit einer so aufgegebenen Nummer wird nicht zugestellt (§8.7.6). Die Zeitregel ist eine benannte Option, aus in der Vorgabe: zerodds.rtps.group-timeout-millis (eine Nummer, die in dieser Zeit nicht eintrifft, wird übersprungen). Tests: GroupOrderTest (Regel, Zeitoption aus und an, Satz) und GroupAccessTest (zwei Writer über RTPS: Nummer 11 gehört einem Writer ohne zugeordneten Reader und wird durch die HEARTBEATs der beiden zugeordneten Writer aufgegeben; ohne HEARTBEAT des zweiten Writers bleibt sie fehlend). Die Gruppennummer wird vergeben und das Sample in die Historie des Writers eingetragen unter einer Sperre (PublisherImpl.stampAndWrite); das HEARTBEAT liest currentGSN unter derselben Sperre (currentGroupStamp) und meldet damit nur Nummern, deren Änderung eingetragen ist (GroupHeartbeatLockTest). Erwartung gegenüber Cyclone DDS, Fast DDS und OpenDDS: sie lesen PID_GROUP_SEQ_NUM, PID_GROUP_COHERENT_SET und PID_WRITER_GROUP_INFO nach §8.7.5; gemessen ist nur die Gegenstelle in ZeroDDS. (Commits 95d9d5eee83, 1a2d89d1696, 56280b5d10c, 5d99860e61a) ### §7.3.5.1 DEADLINE

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 112 (dds-1.2.pdf) — “DEADLINE | A duration “period””

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::requestedDeadlineMissedIsRaised, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::infiniteDeadlineNeverMisses, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::rxoDeadlineCompatibility, crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::requestedDeadlineMissedFiresWithoutPolling, crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::offeredDeadlineMissedFiresWithoutPolling, crates/java-omgdds/java/src/test/java/org/omg/dds/QosRequestedOfferedTest.java::deadlineOfferedPeriodMustNotExceedRequested

Status: done — Deadline.getPeriod mit Vorgabe unendlich (PolicyFactoryImpl.Deadline). Reader und Writer zählen Versäumnisse (DataReaderImpl.evaluateDeadline, DataWriterImpl.evaluateOfferedDeadline); die Tests prüfen REQUESTED_DEADLINE_MISSED mit 50 ms, dass unendlich nie versäumt, OFFERED_DEADLINE_MISSED und die Listener-Meldung ohne Abfrage sowie die Verträglichkeit (angeboten <= gefordert) in rxoDeadlineCompatibility. QosRequestedOfferedTest::deadlineOfferedPeriodMustNotExceedRequested prüft die Verträglichkeit an Paaren mit unendlicher Vorgabe. ### §7.3.5.1 LATENCY_BUDGET

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 113 (dds-1.2.pdf) — “LATENCY_BUDGET | A duration “duration” | […] The default value of the duration is zero”

Status: done — LatencyBudget.getDuration mit Vorgabe 0 (PolicyFactoryImpl.LatencyBudget, geprüft in QosTypesTest::theDefaultsOfTheDataWriterQos); der Wert 2 s wird auf PID_LATENCY_BUDGET geschrieben und im Rundlauf gelesen. QosCompatibility.incompatiblePolicies prüft LATENCY_BUDGET (angeboten <= gefordert, LatencyBudgetImpl.requestedOfferedContract); QosRequestedOfferedTest::latencyBudgetOfferedMustNotExceedRequested prüft länger, gleich, kürzer und die Vorgabe. Die Policy ist nach DDS 1.4 §2.2.3.7 ein Hinweis; auf die Zustellung wirkt sie nicht. (Commit df63a3a7869) ### §7.3.5.1 OWNERSHIP

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 113 (dds-1.2.pdf) — “OWNERSHIP | A “kind” SHARED EXCLUSIVE”

Status: done — Ownership.getKind (SHARED, EXCLUSIVE); der Reader arbitriert nur, wenn Reader und Writer EXCLUSIVE sind (DataReaderImpl.onWrite). DDS 1.4 §2.2.3.9 verlangt dieselbe Art: OwnershipImpl.requestedOfferedContract liefert 0 bei gleicher und 1 bei verschiedener Art, QosCompatibility meldet OWNERSHIP in beiden Richtungen als unverträglich. Getestet: QosRequestedOfferedTest::ownershipKindsMustBeEqualInBothDirections über QosCompatibility.isCompatible, aSharedReaderAndAnExclusiveWriterDoNotMatchAndBothSideRecordIt mit Reader und Writer (kein Sample, REQUESTED_ und OFFERED_INCOMPATIBLE_QOS mit Ownership), QosLifecycleTest::ownershipKindMustMatch. (Commit df63a3a7869) ### §7.3.5.1 OWNERSHIP_STRENGTH

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 113 (dds-1.2.pdf) — “OWNERSHIP_ STRENGTH | An integer “value””

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::exclusiveOwnershipArbitratesToHighestStrength, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::aBuiltinReaderSeesTheQosOfTheAnnouncedWriter, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataWriterQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultOwnershipStrengthAndDurabilityServiceOfTheFactoryAreTheTableValues

Status: done — OwnershipStrength.getValue; der Reader nimmt bei EXCLUSIVE nur Samples des Writers mit der höchsten Stärke an (1 gegen 10), der Wert 7 läuft über Built-in-Topic-Daten. PolicyFactoryImpl.OwnershipStrength() erzeugt jetzt den Wert 0 (DDS 1.4 §2.2.3, Tabelle der Policies); DataWriterQosImpl.defaults übernimmt die 0. Geprüft in QosTypesTest::theDefaultsOfTheDataWriterQos und theDefaultOwnershipStrengthAndDurabilityServiceOfTheFactoryAreTheTableValues. (Commit df63a3a7869) ### §7.3.5.1 LIVELINESS

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 114 (dds-1.2.pdf) — “LIVELINESS | A “kind”: AUTOMATIC, MANUAL_BY_PARTICIPANT, MANUAL_BY_TOPIC and a duration “lease_duration””

Status: done — Liveliness mit Art und lease_duration; Vorgabe AUTOMATIC/unendlich (PolicyFactoryImpl.Liveliness, geprüft in QosLivelinessTest::theDefaultLivelinessIsAutomaticWithAnInfiniteLease). Die Lease wird überwacht: der Writer meldet LIVELINESS_LOST, der Reader LIVELINESS_CHANGED, jeweils ohne Statusabfrage (LeaseTest). Verträglichkeit: angebotene Art >= geforderte (AUTOMATIC < MANUAL_BY_PARTICIPANT < MANUAL_BY_TOPIC) und angebotene Lease <= geforderte (QosRequestedOfferedTest::livelinessOfferedKindMustBeAtLeastRequestedAndTheLeaseNotLonger); die Leitungsseite QosParameters.incompatibility verglich die Art umgekehrt und ist korrigiert (theWireSideRefusesAnOfferedLivelinessKindBelowTheRequestedOne). DomainParticipantImpl.assertLiveliness erneuert jetzt alle DataWriter des Participants mit MANUAL_BY_PARTICIPANT; ebenso erneuert jedes Schreiben und jedes assert_liveliness eines Writers des Participants diese Writer (DDS 1.4 §2.2.3.11); ein MANUAL_BY_TOPIC-Writer und die Writer eines anderen Participants bleiben unberührt (QosLivelinessTest). (Commit 6fa88c2bd3b) ### §7.3.5.1 TIME_BASED_FILTER

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 115 (dds-1.2.pdf) — “TIME_BASED_ FILTER | A duration”minimum_ separation” | […] default minimum_separation=0”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosReaderEffectsTest.java::aReaderWithMinimumSeparationTakesOneSamplePerInstanceInThatTime, crates/java-omgdds/java/src/test/java/org/omg/dds/QosReaderEffectsTest.java::theNewestSampleHeldBackIsDeliveredWhenTheSeparationHasPassed, crates/java-omgdds/java/src/test/java/org/omg/dds/QosReaderEffectsTest.java::withoutMinimumSeparationEverySampleIsDelivered, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataReaderQos

Status: done — TimeBasedFilter.getMinimumSeparation mit Vorgabe 0; der Wert 1 s läuft im Rundlauf der Built-in-Subscription-Daten. DataReaderImpl.onWrite wertet minimum_separation je Instanz aus (org.zerodds.internal.TimeBasedFilterState): das erste Sample einer Instanz wird angenommen, ein weiteres innerhalb der Trennung wird zurückgehalten, und das jüngste zurückgehaltene Sample wird nach Ablauf der Trennung zugestellt (beim Zugriff und durch den Sweep des Readers), sodass die letzte Änderung den Reader erreicht (DDS 1.4 §2.2.3.12). Die Zeit ist die Empfangszeit am Reader. DEADLINE < minimum_separation ist InconsistentPolicyException (QosSetQosTest::aDeadlineShorterThanTheMinimumSeparationIsInconsistent). Getestet in QosReaderEffectsTest (eine Instanz, mehrere Instanzen, Nachlieferung des letzten Samples, Vorgabe 0). (Commit 3389cd624cf) ### §7.3.5.1 PARTITION

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 115 (dds-1.2.pdf) — “PARTITION | A list of strings “name””

Status: done — Partition.getName (Menge von Namen, Vorgabe "") steht in PublisherQos und SubscriberQos. Die Tests prüfen Trennung bei A gegen B, Zustellung bei Überschneidung (A,X gegen X), Platzhalter (sensor.* gegen sensor.temp) und die Meldung ohne Match im Listener. ### §7.3.5.1 RELIABILITY

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 115–116 (dds-1.2.pdf) — “RELIABILITY | A “kind”: RELIABLE, BEST_EFFORT and a duration “max_blocking_time” | […] The default max_blocking_time=100ms.”

Status: done — Art (BEST_EFFORT, RELIABLE) und max_blocking_time (Vorgabe 100 ms, QosTypesTest::theDefaultsOfTheDataWriterQos). ReliabilityImpl.requestedOfferedContract vergleicht nur die Art (DDS 1.4 §2.2.3.14): ein RELIABLE-Reader mit längerer max_blocking_time als der Writer bleibt verträglich (QosRequestedOfferedTest::reliabilityIsComparedByKindAndNotByMaxBlockingTime); RELIABLE-Reader gegen BEST_EFFORT-Writer wird nicht verbunden (CoreTypesTest, QosCompatibilityTest, ReaderStatusTest). DataWriterImpl.write wartet bei erreichter Grenze von RESOURCE_LIMITS (nicht freie Instanz, Verlauf für TRANSIENT_LOCAL) höchstens max_blocking_time und löst dann TimeoutException aus; ein BEST_EFFORT-Writer wartet nicht und löst OutOfResourcesException aus (QosResourceLimitsTest). Ein Writer ohne Grenze wartet nie. (Commit 3389cd624cf) ### §7.3.5.1 TRANSPORT_PRIORITY

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 116 (dds-1.2.pdf) — “TRANSPORT_ PRIORITY | An integer “value””

Status: done — TransportPriority.getValue (int, Vorgabe 0) in TopicQos und DataWriterQos; der Test setzt 3 an einem TopicQos und liest ihn nach dem Rundlauf der Built-in-Topic-Daten wieder. DDS 1.2 §7.1.3.15 nennt die Policy einen Hinweis; ein Einfluss auf den Transport ist nicht vorhanden (im Code nur in QosParameters und den Built-in-Daten gelesen). ### §7.3.5.1 LIFESPAN

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 116 (dds-1.2.pdf) — “LIFESPAN | A duration “duration””

Status: done — Lifespan.getDuration (Vorgabe unendlich); 30 s werden auf PID_LIFESPAN geschrieben und im Rundlauf gelesen. Der Writer trägt seine Gültigkeitsdauer in jede Nachricht (InProcessBus.Message.lifespanMillis); DataReaderImpl verwirft ein Sample, dessen Quellzeitstempel plus Dauer beim Eintreffen vorbei ist, und entfernt abgelaufene Samples vor jedem Zugriff. DataWriterImpl.replayTo stellt abgelaufene Samples einem späten Reader nicht zu und gibt beim Nachliefern den ursprünglichen Quellzeitstempel mit; das gilt ebenso für TRANSIENT und PERSISTENT über org.zerodds.internal.DurabilityService. Getestet in QosReaderEffectsTest und QosDurabilityServiceTest. (Commit 3389cd624cf) ### §7.3.5.1 DESTINATION_ORDER

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 116 (dds-1.2.pdf) — “DESTINATION_ ORDER | A “kind”: BY_ RECEPTION_ TIMESTAMP, BY_SOURCE_ TIMESTAMP”

Status: done — DestinationOrder.getKind (BY_RECEPTION_TIMESTAMP, BY_SOURCE_TIMESTAMP; Vorgabe BY_RECEPTION_TIMESTAMP); BY_SOURCE_TIMESTAMP wird auf PID_DESTINATION_ORDER geschrieben und im Rundlauf gelesen. Bei BY_SOURCE_TIMESTAMP ordnet DataReaderImpl ein Sample einer Instanz, dessen Quellzeitstempel kleiner ist als der jüngste der Instanz, vor die jüngeren ein (DDS 1.4 §2.2.2.5.3.8: die Samples einer Instanz erscheinen in der Reihenfolge der Quellzeitstempel, kleinere zuerst); keines geht verloren, gleiche Zeitstempel bleiben in Ankunftsreihenfolge, andere Instanzen sind unberührt, bei BY_RECEPTION_TIMESTAMP entscheidet der Quellzeitstempel nicht. QosCompatibility.incompatiblePolicies prüft DESTINATION_ORDER (angeboten >= gefordert, BY_RECEPTION_TIMESTAMP < BY_SOURCE_TIMESTAMP). Getestet in QosReaderEffectsTest und QosRequestedOfferedTest::destinationOrderOfferedMustBeAtLeastRequested. (Commit 3389cd624cf) ### §7.3.5.1 HISTORY

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 117–118 (dds-1.2.pdf) — “HISTORY | A “kind”: KEEP_LAST, KEEP_ALL And an optional integer “depth” | […] KEEP_LAST is the default kind. The default value of depth is 1.”

Status: done — Art (KEEP_LAST, KEEP_ALL) und Tiefe; Vorgabe KEEP_LAST/1. Die Tests prüfen die Kappung je Instanz im Reader, dass die Tiefe nicht global gilt, die Wiedergabe des Writers (KEEP_LAST 1, TRANSIENT_LOCAL), die Vorgabe und die Ablehnung negativer Tiefe; KEEP_ALL wird über readerKeepAll genutzt. Die Regel depth <= max_samples_per_instance (DDS 1.4 §2.2.3.18) und die zwei Regeln der RESOURCE_LIMITS und von DURABILITY_SERVICE prüft QosRules.checkConsistent beim Erzeugen von Writer, Reader und Topic, bei setQos und bei setDefault…Qos; ein Verstoß ist InconsistentPolicyException. Die Grenzfälle (Tiefe gleich Grenze, KEEP_ALL ohne Tiefenvergleich, LENGTH_UNLIMITED) sind gültig. Getestet in QosSetQosTest, QosDefaultQosTest. (Commit 8bc25e5d19b) ### §7.3.5.1 Vorgaben von RELIABILITY und HISTORY

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 116–118 (dds-1.2.pdf) — “RELIABLE […] This is the default value for DataWriters. BEST_EFFORT […] This is the default value for DataReaders and Topics.”; “KEEP_LAST is the default kind. The default value of depth is 1.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::reliabilityAndHistoryQosDefaults, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataWriterQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataReaderQos

Status: done — Vorgaben heute: RELIABILITY RELIABLE für DataWriterQosImpl.defaults, BEST_EFFORT für DataReaderQosImpl.defaults und TopicQosImpl.defaults, HISTORY KEEP_LAST mit Tiefe 1. reliabilityAndHistoryQosDefaults prüft diese Werte an Reader-, Topic- und Writer-QoS; SubscriberImpl und PublisherImpl nehmen diese Defaults für Entitäten ohne eigene QoS. ### §7.3.5.1 RESOURCE_LIMITS

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 118–119 (dds-1.2.pdf) — “RESOURCE_ LIMITS | Three integers: max_samples, max_instances, max_samples_per_instance | […] By default, LENGTH_UNLIMITED.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aSampleBeyondMaxSamplesIsRejectedAndReportedToTheListener, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aReaderRejectsAnInstanceBeyondMaxInstances, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aKeepAllReaderRejectsASampleBeyondMaxSamplesPerInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::theDefaultLimitsAreUnlimitedAndRejectNothing, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aWriteToANewInstanceBeyondMaxInstancesTimesOutUntilAnInstanceIsUnregistered, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aBlockedWriteContinuesWhenAnotherThreadFreesTheInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::aBestEffortWriterDoesNotWaitAndIsOutOfResources, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::keepAllWithMaxSamplesPerInstanceTimesOutForTransientLocal, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::maxSamplesBoundsTheHistoryOfAllInstancesTogether, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::keepLastReplacesTheOldestSampleOfTheInstanceAndNeedsNoNewResource, crates/java-omgdds/java/src/test/java/org/omg/dds/QosResourceLimitsTest.java::withNoLimitAWriterNeverWaits

Status: done — ResourceLimits mit max_samples, max_instances, max_samples_per_instance, Vorgabe LENGTH_UNLIMITED. Der Reader lehnt Samples über den drei Grenzen ab (DataReaderImpl.rejectedByLimits, SAMPLE_REJECTED): geprüft für max_samples (REJECTED_BY_SAMPLES_LIMIT), max_instances (REJECTED_BY_INSTANCES_LIMIT), max_samples_per_instance (REJECTED_BY_SAMPLES_PER_INSTANCE_LIMIT, KEEP_ALL) und die Vorgabe. Der Writer wartet bei RELIABLE bis max_blocking_time und löst dann TimeoutException aus (BEST_EFFORT: sofort OutOfResourcesException), wenn ein Sample eine neue Instanz über max_instances oder den für TRANSIENT_LOCAL behaltenen Verlauf über max_samples oder max_samples_per_instance brächte (DataWriterImpl.awaitResources); unregister und dispose geben die Mittel frei und wecken den wartenden Schreiber. Bei KEEP_LAST ersetzt das neue Sample das älteste der Instanz und braucht kein neues Mittel. Ein VOLATILE-Writer behält keine Samples, nur seine Instanzen werden begrenzt. Die Regeln gegen HISTORY stehen unter HISTORY (QosRules). (Commit 3389cd624cf) ### §7.3.5.1 ENTITY_FACTORY

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 119 (dds-1.2.pdf) — “ENTITY_ FACTORY | A boolean: “autoenable_ created_ entities” | […] By default, TRUE.”

Status: done — EntityFactory.isAutoEnableCreatedEntities, Vorgabe true. Publisher und Subscriber lesen entity_factory ihrer QoS: PublisherImpl.createDataWriter und SubscriberImpl.createDataReader aktivieren die neue Entität nur, wenn der Publisher beziehungsweise Subscriber selbst aktiviert ist und die Policy true sagt (DDS 1.4 §2.2.3.20, §2.2.2.1.1.7). enable am Publisher oder Subscriber aktiviert die bis dahin deaktivierten Kinder, wenn die Policy es sagt; enable an einem Writer oder Reader, dessen Publisher oder Subscriber nicht aktiviert ist, löst PreconditionNotMetException aus. Eine Änderung der Policy wirkt nur auf später erzeugte Entitäten. Beim Participant gilt die Policy seines Factory-QoS (DomainParticipantFactoryImpl.autoEnable), bei Publisher, Subscriber und Topic die des Participants (enableIfFactorySays). Getestet in QosEntityFactoryTest. (Commit 8bc25e5d19b) ### §7.3.5.1 WRITER_DATA_LIFECYCLE

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 119–120 (dds-1.2.pdf) — “WRITER_DATA_ LIFECYCLE | A boolean: “autodispose_ unregistered_ instances” | […] By default, TRUE.”

Status: done — WriterDataLifecycle (isAutDisposeUnregisteredInstances, Vorgabe true) in der DataWriter-QoS. DataWriterImpl.unregisterKey (von unregisterInstance, dem Handle-Pfad und close() benutzt) veröffentlicht bei true zuerst DISPOSE und dann UNREGISTER, als hätte die Anwendung vor dem Abmelden dispose gerufen (DDS 1.4 §2.2.3.21); bei false nur UNREGISTER. Der Reader lässt eine als NOT_ALIVE_DISPOSED markierte Instanz beim Abmelden des letzten Writers in diesem Zustand. Mit der Vorgabe ist das Ergebnis eines Unregister also NOT_ALIVE_DISPOSED, mit false NOT_ALIVE_NO_WRITERS; QosLifecycleTest::unregisterMarksInstanceNotAliveNoWriters und closingOneWriterDoesNotMarkNoWritersWhileAnotherWrites verwenden jetzt false, DurabilityServiceTest und MultiTopicJoinTest ebenso, wo sie NO_WRITERS beziehungsweise überlebende Daten erwarten. Die eingebauten Topics (Builtin.writer) verwenden false und melden weiter NOT_ALIVE_NO_WRITERS. Getestet in QosWriterDataLifecycleTest. (Commit 3389cd624cf) ### §7.3.5.1 READER_DATA_LIFECYCLE

Spec: §7.3.5.1, S. 21; [DDS] 1.2 §7.1.3, S. 120 (dds-1.2.pdf) — “READER_DATA_ LIFECYCLE | Two durations “autopurge_ nowriter_ samples_delay” and “autopurge_ disposed_ samples_delay” | […] By default, infinite.”

Status: done — ReaderDataLifecycle (getAutoPurgeNoWriterSamplesDelay, getAutoPurgeDisposedSamplesDelay, Vorgabe unendlich) in der DataReader-QoS. DataReaderImpl.purgeLocked läuft vor jedem Zugriff und im Sweep des Readers: nach autopurge_nowriter_samples_delay seit NOT_ALIVE_NO_WRITERS entfernt es die Instanz mit allen ungenommenen Samples, nach autopurge_disposed_samples_delay seit NOT_ALIVE_DISPOSED alle Samples der Instanz (DDS 1.4 §2.2.3.22). Unendlich löscht nie; die Verzögerung des einen Zustands wirkt nicht auf den anderen. Getestet in QosReaderEffectsTest (Vorgabe, Verzögerung 0 für beide Zustände, Verzögerung des anderen Zustands, endliche Verzögerung ohne Zugriff). (Commit 3389cd624cf) ### §7.3.5.2 Entity-QoS als Schnittstelle mit Basis EntityQos, direkter Zugriff auf die Policies

Spec: §7.3.5.2, S. 21 — “Each Entity QoS (e.g., DataReaderQos) is an interface extending org.omg.dds.core.EntityQos. These sub-interfaces provide direct access to their policies as in the IDL PSM.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::reliabilityAndHistoryQosDefaults, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::defaultQosIsTheQosOfWhatIsCreatedNext, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theDefaultsOfTheDataWriterQos

Status: done — Sieben Schnittstellen (DomainParticipantFactoryQos, DomainParticipantQos, TopicQos, PublisherQos, SubscriberQos, DataWriterQos, DataReaderQos) erweitern EntityQos<...> und haben je Policy einen Zugriff (getReliability, getHistory, getPartition, …). Die Tests lesen Policies direkt (DataReaderQos.getHistory, TopicQos.getReliability, DataWriterQos.getReliability, PublisherQos.getPartition). QosProfile gibt es nicht mehr. ### §7.3.5.2 DomainParticipantFactoryQos

Spec: §7.3.5.2, S. 21; [DDS] 1.2 IDL, S. 167 (dds-1.2.pdf) — “struct DomainParticipantFactoryQos { EntityFactoryQosPolicy entity_factory; };”

Status: done — DomainParticipantFactoryQos hat getEntityFactory; DomainParticipantFactoryImpl.autoEnable liest den Wert bei create_participant. QosEntityFactoryTest::theParticipantFactoryDecidesWhetherTheParticipantsItCreatesAreEnabled setzt eine Factory-QoS mit ENTITY_FACTORY false, liest getEntityFactory() zurück, prüft dass ein erzeugter Participant nicht aktiviert ist (DomainParticipantImpl.isEnabled), dass enable ihn aktiviert, und stellt die QoS wieder her. DomainParticipantFactoryImpl.setQos prüft die QoS wie jedes setQos. ### §7.3.5.2 DomainParticipantQos

Spec: §7.3.5.2, S. 21; [DDS] 1.2 IDL, S. 167 (dds-1.2.pdf) — “struct DomainParticipantQos { UserDataQosPolicy user_data; EntityFactoryQosPolicy entity_factory; };”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::factoryQosAndDefaultParticipantQos, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::entityFactoryDecidesWhetherWhatIsCreatedIsEnabled, crates/java-omgdds/java/src/test/java/org/omg/dds/QosSetQosTest.java::aParticipantAndTheFactoryTakeNewUserDataAndEntityFactory

Status: done — DomainParticipantQos hat getUserData und getEntityFactory; ein Participant liefert seine QoS über getQos. factoryQosAndDefaultParticipantQos setzt USER_DATA mine als Default und prüft, dass createParticipant(...).getQos() gleich der gesetzten QoS ist; entityFactoryDecidesWhetherWhatIsCreatedIsEnabled prüft die Wirkung von ENTITY_FACTORY false. ### §7.3.5.2 TopicQos

Spec: §7.3.5.2, S. 21; [DDS] 1.2 IDL, S. 167–168 (dds-1.2.pdf) — “struct TopicQos { topic_data; durability; durability_service; deadline; latency_budget; liveliness; reliability; destination_order; history; resource_limits; transport_priority; lifespan; ownership; };”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicQos.java (TopicQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/TopicQosImpl.java (TopicQosImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CoreTypesTest.java::reliabilityAndHistoryQosDefaults, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::theTopicQosAnswersWhatItWasGivenForEveryPolicyOfTable72

Status: done — TopicQos hat die 13 Policies der IDL (topic_data bis ownership) und dazu getRepresentation und getTypeConsistency; TopicQosImpl.defaults setzt alle. Getestet werden Reliability, Durability, History, ResourceLimits, TransportPriority, Deadline, DurabilityService und TopicData (Vorgaben und Rundlauf der Built-in-Topic-Daten) sowie LatencyBudget, Liveliness, DestinationOrder, Lifespan und Ownership mit Vorgabe und geändertem Wert in QosTypesTest::theTopicQosAnswersWhatItWasGivenForEveryPolicyOfTable72. ### §7.3.5.2 PublisherQos

Spec: §7.3.5.2, S. 21; [DDS] 1.2 IDL, S. 168 (dds-1.2.pdf) — “struct PublisherQos { PresentationQosPolicy presentation; PartitionQosPolicy partition; GroupDataQosPolicy group_data; EntityFactoryQosPolicy entity_factory; };”

Status: done — PublisherQos hat getPresentation, getPartition, getGroupData, getEntityFactory. PARTITION wirkt auf das Matching (QosLifecycleTest), GROUP_DATA und PRESENTATION laufen über Built-in-Topic-Daten und die Leitung. ENTITY_FACTORY am Publisher bestimmt, ob createDataWriter den Writer aktiviert (QosEntityFactoryTest); PRESENTATION geht in das Matching der Endpunkte ein (QosRequestedOfferedTest), die Wirkung von coherent_access und ordered_access auf die Zustellung fehlt (Item zu PRESENTATION). Die Zugriffe mit gesetzten Werten prüft QosTypesTest::thePublisherAndSubscriberQosAnswerPresentationEntityFactoryAndGroupData. (Commit 8bc25e5d19b) ### §7.3.5.2 SubscriberQos

Spec: §7.3.5.2, S. 21; [DDS] 1.2 IDL, S. 169 (dds-1.2.pdf) — “struct SubscriberQos { PresentationQosPolicy presentation; PartitionQosPolicy partition; GroupDataQosPolicy group_data; EntityFactoryQosPolicy entity_factory; };”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::partitionIsolatesNonOverlappingEndpoints, crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::partitionWildcardMatches, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::nonOverlappingPartitionIsNotAMatch, crates/java-omgdds/java/src/test/java/org/omg/dds/BuiltinTopicQosTest.java::everyBuiltinDataTypeRoundTripsItsQos, crates/java-omgdds/java/src/test/java/org/omg/dds/QosTypesTest.java::thePublisherAndSubscriberQosAnswerPresentationEntityFactoryAndGroupData, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityFactoryTest.java::aSubscriberWithAutoEnableFalseCreatesDisabledReaders

Status: done — SubscriberQos hat getPresentation, getPartition, getGroupData, getEntityFactory. PARTITION ist getestet (Trennung, Platzhalter, kein Match im Listener, Rundlauf der Subscription-Daten). PRESENTATION, GROUP_DATA und ENTITY_FACTORY am Subscriber prüft QosTypesTest::thePublisherAndSubscriberQosAnswerPresentationEntityFactoryAndGroupData; SubscriberImpl.createDataReader aktiviert den Reader nur, wenn entity_factory es sagt (QosEntityFactoryTest). (Commit 8bc25e5d19b) ### §7.3.5.2 DataWriterQos

Spec: §7.3.5.2, S. 21; [DDS] 1.2 IDL, S. 168 (dds-1.2.pdf) — “struct DataWriterQos { durability; durability_service; deadline; latency_budget; liveliness; reliability; destination_order; history; resource_limits; transport_priority; lifespan; user_data; ownership; ownership_strength; writer_data_lifecycle; };”

Status: done — DataWriterQos hat die 15 Policies der IDL und dazu getRepresentation und getTypeConsistency; DataWriterQosImpl.defaults setzt alle. Getestet sind Durability, Deadline, LatencyBudget, Liveliness, Reliability, DestinationOrder, History, Lifespan, UserData, Ownership und OwnershipStrength sowie ResourceLimits, TransportPriority, DurabilityService und WriterDataLifecycle (QosTypesTest::theDataWriterQosAnswersWhatItWasGivenForTheRemainingPolicies, Vorgaben in theDefaultsOfTheDataWriterQos). WRITER_DATA_LIFECYCLE wirkt auf unregister und close (QosWriterDataLifecycleTest). ### §7.3.5.2 DataReaderQos

Spec: §7.3.5.2, S. 21; [DDS] 1.2 IDL, S. 168–169 (dds-1.2.pdf) — “struct DataReaderQos { durability; deadline; latency_budget; liveliness; reliability; destination_order; history; resource_limits; user_data; ownership; time_based_filter; reader_data_lifecycle; };”

Status: done — DataReaderQos hat die 12 Policies der IDL (durability bis reader_data_lifecycle) und dazu getRepresentation und getTypeConsistency; DataReaderQosImpl.defaults setzt alle. Getestet sind Durability, Deadline, Liveliness, Reliability, History, ResourceLimits, Ownership, UserData und TimeBasedFilter sowie LatencyBudget, DestinationOrder und ReaderDataLifecycle (QosTypesTest::theDataReaderQosAnswersWhatItWasGivenForTheRemainingPolicies, Vorgaben in theDefaultsOfTheDataReaderQos). OwnershipStrength und Partition gehören nicht zur QoS des Readers. ### §7.3.5.2 Zugriff auf die Policies über java.util.Map

Spec: §7.3.5.2, S. 21 — “However, the base interface also provides for generic access using the java.util.Map interface. This interface allows applications to look up policies by ID and to iterate over them in a generic way, including vendor-specific extension policies, without introducing compile-time dependencies on vendor-specific APIs.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/EntityQos.java (EntityQos), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos.get), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/AbstractEntityQos.java (AbstractEntityQos.entrySet), crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosCompatibility.java (QosCompatibility.policiesOf)

Status: done — EntityQos<P> erweitert java.util.Map<Class<? extends P>, P> mit get(Class<POLICY>); AbstractEntityQos liefert get und eine nicht änderbare entrySet. reliabilityAndHistoryQosDefaults sucht per reader.get(Reliability.class); rxoDeadlineCompatibility läuft über QosCompatibility.policiesOf durch alle Einträge der QoS. ### §7.3.5.2 QoS nicht direkt erzeugbar, nur aus getQos oder QosProvider

Spec: §7.3.5.2, S. 21 — “QoS objects cannot be created directly. They can be either retrieved from an entity (e.g., DataReader) using the getQoS method or looked up using a string identifier using the QoSProvider interface. QoS objects can be cloned from pre-existing state maintained by the Service implementation.”

Status: done — In der OMG-API haben die QoS-Schnittstellen keinen Konstruktor; die Konstruktoren der *QosImpl sind privat. QoS aus Entitäten und Fabriken (getQos, getDefaultPublisherQos, getDefaultParticipantQos), das Ableiten per withPolicy und der Weg über QosProvider sind getestet (QosProviderTest::entitiesAreCreatedFromTheQosOfAProvider, QosDefaultQosTest). Die statische Methode *QosImpl.defaults(environment) ist öffentlich, damit die Tests (Qos.writer(), Qos.reader()) und QosProviderImpl Vorgabe-QoS anlegen; sie ist keine Methode der OMG-API. ### §7.3.5.2 QoS aus Entitäten und QosProvider unveränderlich, Ändern über die QoS-DSL

Spec: §7.3.5.2, S. 21 — “QoS objects as returned by Entities and QoSProvider shall be immutable; applications shall never observe them to change. Applications that wish to modify QoS values must use the “QoS DSL” supported by the QoS and Policy classes.”

Status: done — AbstractEntityQos kopiert die Policies in eine eigene Map, entrySet ist nicht änderbar, AbstractMap.put, remove, clear, putAll, keySet().remove, values().clear und der Iterator-remove lösen UnsupportedOperationException aus; die Policies haben final-Felder, withPolicy erzeugt ein neues Objekt. Getestet für alle sieben QoS-Arten in QosTypesTest::theMapOfAQosCannotBeChanged; dass die QoS einer Entität nach withPolicy unverändert bleibt und das Original dasselbe Objekt ist, prüfen withPolicyReturnsAnotherQosAndLeavesTheSourceAsItWas und aQosFromAnEntityIsNotChangedByDerivingFromIt. ### §7.3.5.3 Ändern verboten, neue QoS und Policies über eine fluent DSL

Spec: §7.3.5.3, S. 21 — “Modifying QoS objects and their constituent policies is disallowed but a QoS DSL shall support creation of new QoS objects and policies from the existing objects using Java fluent interface design.”

Status: done — Die DSL ist vorhanden: QoS (withPolicy, withPolicies) und Policies (withKeepLast, withManualByTopic().withLeaseDuration(...)) liefern ein neues Objekt und lassen sich verketten; die Werte wirken im Verhalten (transientLocalReplaysToLateJoiner, livelinessChangedReflectsWriterPresence). Dass das Original unverändert bleibt und ein anderes Objekt zurückkommt, prüfen QosTypesTest::withPolicyReturnsAnotherQosAndLeavesTheSourceAsItWas, everyWithOfAPolicyReturnsANewObjectAndLeavesTheSource und withPoliciesAppliesSeveralPoliciesAtOnce. ### §7.3.5.3 QoS-Klassen mit withPolicy und withPolicies

Spec: §7.3.5.3, S. 21 — “QoS classes shall provide withPolicy and withPolicies methods that accept one or more policy objects to create a new QoS object.”

Status: done — EntityQos.withPolicy(P) und withPolicies(P...) sind in EntityQos und AbstractEntityQos vorhanden; withPolicy wird in vielen Tests benutzt. QosTypesTest::withPoliciesAppliesSeveralPoliciesAtOnce prüft withPolicies mit mehreren Policies und ohne; aPolicyThatIsNoPolicyOfTheQosIsRefused prüft die IllegalArgumentException von AbstractEntityQos.policyKey für eine Policy, die sich nur als Policy für Reader ausweist und keine der Policies aus Tabelle 7.2 ist. ### §7.3.5.3 Policy-Klassen mit with-Methoden

Spec: §7.3.5.3, S. 21 — “Policy classes shall provide with methods to specify policy parameters and to create new policy objects from the existing ones.”

Status: done — Alle Policy-Schnittstellen haben with*-Methoden für ihre Parameter (Liveliness.withKind/withLeaseDuration, Reliability.withMaxBlockingTime, History.withDepth, ResourceLimits.withMaxSamples …). thePublicationWireFormCarriesTheQosOnTheParameterIdsOfTable913 erzeugt Policies so und prüft die Werte byteweise auf der Leitung; historyDepthMustBeNonNegative prüft die Wertprüfung in withDepth. ### §7.3.5.3 Jedes with erzeugt ein neues Objekt, Verkettung

Spec: §7.3.5.3, S. 21 — “Each with method call will create a new policy object because the target object of the method call is immutable. The with methods shall support method chaining (QoS DSL).”

Status: done — Verkettung ist getestet (zwei withPolicy hintereinander; Liveliness().withManualByTopic().withLeaseDuration(...)), und die verketteten Werte wirken. Dass jedes with ein neues Objekt erzeugt und das Ziel unverändert lässt, prüfen QosTypesTest::withPolicyReturnsAnotherQosAndLeavesTheSourceAsItWas (assertNotSame, Quelle behält den alten Wert) und everyWithOfAPolicyReturnsANewObjectAndLeavesTheSource für Reliability, History, ResourceLimits, Deadline, Partition, UserData, Presentation und Durability; withCallsChainOnePolicyIntoTheNext die Verkettung. ### §7.3.5.3 Beispiel pf.ResourceLimits().withMaxSamples(P).withMaxInstances(Q)

Spec: §7.3.5.3, S. 22 — “Example (non-normative) PolicyFactory pf = … // object policy factory reference ResourceLimits rl = pf.ResourceLimits().withMaxSamples(P).withMaxInstances(Q);”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/policy/PolicyFactory.java (PolicyFactory.ResourceLimits)

Status: n/a (informative) — Beispiel (nicht normativ). Der Aufbau ist mit der heutigen API möglich: PolicyFactory.ResourceLimits().withMaxSamples(..).withMaxInstances(..); everyBuiltinDataTypeRoundTripsItsQos ruft ihn auf. Die Methode heißt ResourceLimits() wie in den OMG-Quellen. Die Verkettung prüft QosTypesTest::withCallsChainOnePolicyIntoTheNext mit den Werten 20, 6 und LENGTH_UNLIMITED. ### §7.3.5.3 Begründung: getQos ohne Kopie

Spec: §7.3.5.3, S. 22 — “Design Rationale (non-normative) • The getQos operation can operate maximally efficiently: it need not allocate any memory or perform any copies. […]”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/EntityBase.java (EntityBase.getQos)

Tests: —

Status: n/a (informative) — Begründung (nicht normativ). getQos gibt das gespeicherte, unveränderliche Objekt ohne Kopie zurück; DomainParticipantOperationsTest::factoryQosAndDefaultParticipantQos prüft per assertSame, dass getQos das gesetzte Objekt liefert. ### §7.3.5.4 org.omg.dds.core.QosProvider liefert QoS aus Bibliothek und Profil

Spec: §7.3.5.4, S. 22 — “The org.omg.dds.core.QosProvider interface allows Entity’s Qos to be obtained from the names of QoS library and profile.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::theQosOfEveryEntityKindCarriesTheValuesOfTheDocument, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::theWriterAndReaderQosCarryTheValuesOfTheDocumentAndKeepTheDefaultsOfWhatItLeavesOut, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::aProfileWithoutAnElementOfAKindHasNoQosOfThatKind, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::theFactoryQosHasItsOwnElement, crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::anIdCanNameAnotherProfileOrAnElementOfIt

Status: done — QosProvider (abstrakte Klasse) hat getDomainParticipantFactoryQos, getDomainParticipantQos, getTopicQos, getSubscriberQos, getPublisherQos, getDataReaderQos, getDataWriterQos jeweils ohne und mit id; QosProviderImpl liest die XML-Bibliothek. QosProviderTest schreibt eine Bibliothek in eine Datei, lädt sie über QosProvider.newQosProvider(uri, profile, env) und liest die QoS jeder Entity-Art (ohne und mit id), mit den Werten des Dokuments und den Vorgaben für Ausgelassenes. Eine id ist der name des Elements, Bibliothek::Profil oder Bibliothek::Profil::name; ein Profil ohne Element der Art oder eine unbekannte id ist IllegalArgumentException. (Commit a68b0889e7a) ### §7.3.5.4 Quelle als URI, Präfix file:// Pflicht

Spec: §7.3.5.4, S. 22 — “The Qos library source is provided as a uniform resource identifier (URI). Conforming implementation must support “file://” prefix. For instance, “file:///path/to/qos/library.””

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/core/qos/QosProviderImpl.java (QosProviderImpl.read)

Status: done — QosProviderImpl.read akzeptiert das Schema file (Paths.get(URI)) und löst für jedes andere Schema, auch ohne Schema, UnsupportedOperationException aus. QosProviderTest::aFileUriIsReadAndTheProviderIsObtainedFromTheEnvironment lädt eine file:///…-URI, anotherSchemeIsUnsupported prüft http, ftp und data. (Commit a68b0889e7a) ### §7.3.5.4 QosProvider aus ServiceEnvironment.newQosProvider(uri, profile)

Spec: §7.3.5.4, S. 22 — “An instance of QosProvider is obtained from the ServiceEnvironment. For example, serviceEnv.newQosProvider(String uri, String profile);”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosProviderTest.java::aFileUriIsReadAndTheProviderIsObtainedFromTheEnvironment

Status: done — Der Aufruf serviceEnv.newQosProvider(uri, profile) des Beispiels gibt es als QosProvider.newQosProvider(uri, profile, env), das an env.getSPI().newQosProvider(uri, profile) delegiert (ServiceProviderInterface, Umsetzung in ServiceEnvironmentImpl); ServiceEnvironment selbst hat keine solche Methode (wie in den OMG-Quellen). QosProviderTest::aFileUriIsReadAndTheProviderIsObtainedFromTheEnvironment ruft beide Wege auf und vergleicht die QoS. ### §7.3.5.4 uri in Standardsyntax, profile eindeutig im Dokument

Spec: §7.3.5.4, S. 22 — “The uri parameter uses the standard uri syntax. The profile parameter identifies a uniquely identified profile in the document referred by the uri.”

Status: done — QosProviderImpl bildet new URI(uri) (Fehler: IllegalArgumentException) und wählt das Profil als Bibliothek::Profil, als in der Datei eindeutigen Namen oder, bei null, das erste. Ein unbekanntes Profil ist IllegalArgumentException; ein Name, den zwei Profile tragen, ebenso, und zwei gleichnamige Profile in einer Bibliothek weist schon das Lesen zurück. Getestet in QosProviderTest::aUriThatIsNoUriAndAFileThatIsNotThereAreRefused, aProfileIsSelectedByQualifiedNameByUniqueNameOrAsTheFirst, aProfileNameThatTwoProfilesShareIsNotUnique. (Commit a68b0889e7a) ### §7.3.5.4 Factories erzeugen Entitäten und setzen Vorgaben aus QoS-Objekten oder QosProvider

Spec: §7.3.5.4, S. 22 — “Each Entity factory interface DomainParticipantFactory, DomainParticipant, Publisher, and Subscriber provides methods to create new “product” Entities and to set their default QoS based on QoS objects created programmatically or obtained through QosProvider.”

Status: done — Die Fabriken DomainParticipantFactory, DomainParticipant, Publisher und Subscriber erzeugen Entitäten mit einer QoS und haben setDefault…Qos/getDefault…Qos; die Vorgabe wird auf Verträglichkeit geprüft. Getestet in QosDefaultQosTest: setDefaultTopicQos, setDefaultSubscriberQos, setDefaultPublisherQos, Publisher.setDefaultDataWriterQos, Subscriber.setDefaultDataReaderQos, DomainParticipantFactory.setDefaultParticipantQos und die Ablehnung einer widersprüchlichen Vorgabe; QosProviderTest::entitiesAreCreatedFromTheQosOfAProvider erzeugt Entitäten aus Provider-QoS. (Commit 8bc25e5d19b) ### §7.3.6 Alle Entitäten erweitern Entity

Spec: §7.3.6, S. 22 — “As in the DDS PIM, all Entity interfaces extend—directly or indirectly—the interface Entity.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/CloseCascadeTest.java::publisherCloseClosesItsWriters, crates/java-omgdds/java/src/test/java/org/omg/dds/DomainParticipantOperationsTest.java::closeContainedEntitiesClosesThemWithoutClosingTheParticipant, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityBasicsTest.java::everyEntityExtendsEntityAndEveryOneButTheParticipantExtendsDomainEntity

Status: done — DomainParticipant erweitert Entity; Publisher, Subscriber, DataWriter, DataReader und Topic erweitern DomainEntity, das Entity erweitert (gelesen). Der Test benutzt Qos.isClosed(Entity<?, ?>) mit DomainParticipant, Publisher und DataWriter, was nur übersetzt, wenn diese Entity sind; die Vererbung der anderen drei prüft kein Test. Es ist eine reine Signaturforderung. QosEntityBasicsTest::everyEntityExtendsEntityAndEveryOneButTheParticipantExtendsDomainEntity prüft die Vererbung aller sechs Typen mit isAssignableFrom. ### §7.3.6 Entity generisch über QoS- und Listener-Typ

Spec: §7.3.6, S. 22 — “In this PSM, this interface is generic; it is parameterized by the Entity’s QoS and listener types. These parameters allow applications to call common operations like getQos or getListener in a type-safe way while still working with Entities polymorphically.”

Status: done — Entity<LISTENER extends EventListener, QOS extends EntityQos<?>> mit getQos() und getListener(); die Unterschnittstellen binden die Typen (Publisher extends DomainEntity<PublisherListener, PublisherQos>). defaultQosIsTheQosOfWhatIsCreatedNext liest createPublisher().getQos() als PublisherQos, clearingTheListenerStopsDelivery liest getListener() eines DataReader; beide übersetzen nur mit den Typparametern. ### §7.3.6 Entity erweitert java.io.Closeable

Spec: §7.3.6, S. 22 — “The Entity interface extends java.io.Closeable interface to support specific new language constructs (e.g., Java 7 try-with-resources) for dealing with all Entities polymorphically.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/Entity.java (Entity)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityBasicsTest.java::entityExtendsCloseable

Status: done — Entity extends Closeable, DDSObject (Entity.java). QosEntityBasicsTest::entityExtendsCloseable prüft Closeable.class.isAssignableFrom(Entity.class) und hält Publisher, Subscriber, Topic, DataWriter und DataReader als java.io.Closeable, schließt sie darüber und prüft den Zustand mit Qos.isClosed. ### §7.3.6 Entitäten außer DomainParticipant erweitern DomainEntity mit getParent

Spec: §7.3.6, S. 22 — “Also as in the DDS PIM, Entities other than DomainParticipant extend the interface DomainEntity. These Entities provide operations to get the creating parent Entity; in this PSM, this operation is the polymorphic DomainEntity.getParent.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityBasicsTest.java::theParentOfAnEntityIsTheEntityThatCreatedIt

Status: done — DomainEntity.getParent existiert; Publisher, Subscriber und Topic liefern den Participant, DataWriter den Publisher, DataReader den Subscriber. QosEntityBasicsTest::theParentOfAnEntityIsTheEntityThatCreatedIt prüft mit assertSame alle fünf Beziehungen. ### §7.3.7 Status, Listener, Bedingungen und WaitSets

Spec: §7.3.7, S. 22 — “This sub clause describes the objects pertaining to the status changes of DDS Entities: the Status types themselves, listeners, conditions, and wait sets.”

Repo: —

Tests: —

Status: n/a (informative) — Einleitung ohne eigene Anforderung. ### §7.3.7.1 Jeder Status als abstrakte Klasse mit Basis org.omg.dds.core.Status, die EventObject erweitert

Spec: §7.3.7.1, S. 23 — “This PSM represents each status identified by the DDS PIM as an abstract class extending org.omg.dds.core.Status, which in turn extends java.util.EventObject.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/SerializationTest.java::aStatusKeepsItsCounts, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityBasicsTest.java::theThirteenStatusKindsAreClassesOfTheStatusBase, crates/java-omgdds/java/src/test/java/org/omg/dds/QosEntityBasicsTest.java::theEventThatCarriesAStatusIsAnEventObjectWithTheEntityAsSource, crates/java-omgdds/java/src/test/java/org/omg/dds/CoreApiShapeTest.java::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource

Status: done — Alle 13 Status sind abstrakte Klassen mit Basis org.omg.dds.core.status.Status (QosEntityBasicsTest::theThirteenStatusKindsAreClassesOfTheStatusBase, auch Serializable). Der Text sagt, Status erweitere EventObject; die Quelle omgdds_src.zip, die nach §2 bei einem Widerspruch gilt, erklärt Status als abstract class Status implements Serializable, DDSObject ohne EventObject, und org/omg/dds bleibt gleich der Quelle (CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource). Das java.util.EventObject trägt StatusChangedEvent: es hat getSource() (die Entität) und getStatus(); QosEntityBasicsTest::theEventThatCarriesAStatusIsAnEventObjectWithTheEntityAsSource prüft das an einem PublicationMatchedEvent. (Commit 72b36ae5db2) ### §7.3.7.1 Statusarten als Class-Objekte, Masken als Set

Spec: §7.3.7.1, S. 23 — “This PSM represents status kinds using the java.lang.Class instances of the corresponding status classes and status masks as java.util.Sets of such status classes.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aStatusIsResetWhenItIsReadAndDataAvailableWhenTheSamplesAreTaken, crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aStatusConditionTriggersOnTheStatusItIsEnabledForAndHasItsEntityAsParent, crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentCreatesTheStatusAndConditionFactories

Status: done — Statusarten sind Class<? extends Status>, Masken Set/Collection davon: Entity.getStatusChanges, setListener(listener, statuses), StatusCondition.setEnabledStatuses, allStatusKinds/noStatusKinds. Die Tests lesen getStatusChanges().contains(DataAvailableStatus.class), setzen und lesen die aktivierten Status einer StatusCondition und prüfen allStatusKinds().size() == 13 und noStatusKinds().isEmpty(). ### §7.3.7.1 Status in Callbacks wiederverwendbar, Anwendungen kopieren

Spec: §7.3.7.1, S. 23 — “Status objects passed to listeners in callbacks may be pooled and reused by the implementation. Therefore, applications that wish to retain these objects—or any objects found within them, such as instance handles—for later use outside of the callback are responsible for copying them.”

Repo: —

Tests: —

Status: n/a (informative) — Erlaubnis für die Umsetzung und Pflicht der Anwendung; eine erfüllbare Anforderung an den Code besteht nicht. ZeroDDS erzeugt je Callback ein neues Statusobjekt (DataReaderImpl: new RequestedDeadlineMissedStatusImpl(...) u. a., gelesen). ### §7.3.7.1 InconsistentTopicStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 132, IDL S. 159 (dds-1.2.pdf) — “struct InconsistentTopicStatus { long total_count; long total_count_change; };”

Status: done — Zwei Topics gleichen Namens mit verschiedenem Typnamen in einer Domain zählen INCONSISTENT_TOPIC (TopicImpl.onInconsistentTopic) und rufen den TopicListener; der Test legt beides fest. ### §7.3.7.1 SampleLostStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133, IDL S. 159 (dds-1.2.pdf) — “struct SampleLostStatus { long total_count; long total_count_change; };”

Status: done — DataReaderImpl.noteSequence zählt Lücken in den Sequenznummern je Writer; SampleLostStatus meldet getTotalCount und getTotalCountChange (Rücksetzen beim Lesen), onSampleLost das Ereignis. Beide Tests liefern Samples über deliverWire. (Commit e1b55167947) ### §7.3.7.1 SampleRejectedStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133, IDL S. 159 (dds-1.2.pdf) — “struct SampleRejectedStatus { long total_count; long total_count_change; SampleRejectedStatusKind last_reason; InstanceHandle_t last_instance_handle; };”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aSampleBeyondMaxSamplesIsRejectedAndReportedToTheListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderLimitsTest.java::aSampleOfANewInstanceBeyondMaxInstancesIsRejectedWithThatReasonAndInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderLimitsTest.java::aSampleBeyondMaxSamplesPerInstanceIsRejectedWithThatReasonAndInstance

Status: done — ReaderLimitsTest prüft die Gründe REJECTED_BY_INSTANCES_LIMIT und REJECTED_BY_SAMPLES_PER_INSTANCE_LIMIT mit getLastInstanceHandle (von Hand aus dem Schlüssel abgeleitet) und den Änderungswert; ReaderStatusTest prüft REJECTED_BY_SAMPLES_LIMIT und den Listener. (Commit e1b55167947) ### §7.3.7.1 LivelinessLostStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133, IDL S. 159 (dds-1.2.pdf) — “struct LivelinessLostStatus { long total_count; long total_count_change; };”

Status: done — DataWriterImpl.getLivelinessLostStatus zählt den Verlust einmal und setzt die Änderung beim Lesen zurück; der Test prüft Zähler, Änderung und Listener. ### §7.3.7.1 LivelinessChangedStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133, IDL S. 159–160 (dds-1.2.pdf) — “struct LivelinessChangedStatus { long alive_count; long not_alive_count; long alive_count_change; long not_alive_count_change; InstanceHandle_t last_publication_handle; };”

Status: done — DataReaderImpl.getLivelinessChangedStatus und der Listener-Pfad setzen lastPublicationHandle auf den Handle des Writers, dessen Lebendigkeit sich zuletzt geändert hat. ReaderStatusDetailTest prüft getLastPublicationHandle, getAliveCountChange (+1, dann -1) und getNotAliveCountChange (+1). (Commit e1b55167947) ### §7.3.7.1 OfferedDeadlineMissedStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133, IDL S. 160 (dds-1.2.pdf) — “struct OfferedDeadlineMissedStatus { long total_count; long total_count_change; InstanceHandle_t last_instance_handle; };”

Status: done — DataWriterImpl.getOfferedDeadlineMissedStatus liefert total_count, total_count_change und last_instance_handle; der Test prüft alle drei und den Listener. ### §7.3.7.1 RequestedDeadlineMissedStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133, IDL S. 160 (dds-1.2.pdf) — “struct RequestedDeadlineMissedStatus { long total_count; long total_count_change; InstanceHandle_t last_instance_handle; };”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QosLifecycleTest.java::requestedDeadlineMissedIsRaised, crates/java-omgdds/java/src/test/java/org/omg/dds/LeaseTest.java::requestedDeadlineMissedFiresWithoutPolling, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::requestedDeadlineMissedNamesTheInstanceThatMissedLast, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::theChangeOfRequestedDeadlineMissedStartsAgainWhenTheStatusIsRead

Status: done — ReaderStatusDetailTest prüft getLastInstanceHandle bei zwei Instanzen und den Änderungswert 0 beim zweiten Lesen. (Commit e1b55167947) ### §7.3.7.1 OfferedIncompatibleQosStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133, IDL S. 160 (dds-1.2.pdf) — “struct OfferedIncompatibleQosStatus { long total_count; long total_count_change; QosPolicyId_t last_policy_id; QosPolicyCountSeq policies; };”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::anIncompatibleReaderIsCountedWithTheRefusedPolicy

Status: done — DataWriterImpl.getOfferedIncompatibleQosStatus zählt den abgelehnten Reader mit last_policy_id und der Policy-Liste und ruft onOfferedIncompatibleQos; der Test prüft Zähler, Policy und Listener. ### §7.3.7.1 RequestedIncompatibleQosStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133, IDL S. 160 (dds-1.2.pdf) — “struct RequestedIncompatibleQosStatus { long total_count; long total_count_change; QosPolicyId_t last_policy_id; QosPolicyCountSeq policies; };”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aWriterThatOffersLessThanRequestedIsReportedToTheListener, crates/java-omgdds/java/src/test/java/org/omg/dds/QosCompatibilityTest.java::incompatibleReliabilityDoesNotConnect, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::requestedIncompatibleQosCountsTheRefusingPolicyAndResetsItsChange, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::everyPolicyThatRefusesTheConnectionIsCountedAndOneConnectionIsOneInTotal, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::thePresentationOfTheSubscriberMustBeOfferedByThePublisher

Status: done — ReaderStatusDetailTest prüft getPolicies (ein QosPolicyCount je verweigernder Policy mit Zähler 1), getTotalCountChange und getLastPolicyClass; ReaderStatusTest das Ereignis. (Commit d17c5f0c379) ### §7.3.7.1 PublicationMatchedStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133, IDL S. 160 (dds-1.2.pdf) — “struct PublicationMatchedStatus { long total_count; long total_count_change; long current_count; long current_count_change; InstanceHandle_t last_subscription_handle; };”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterStatusTest.java::thePublicationMatchedStatusCountsAndNamesTheLastSubscription

Status: done — DataWriterImpl.readPublicationMatchedStatusLocked liefert last_subscription_handle des zuletzt verbundenen Readers; der Test vergleicht ihn mit getMatchedSubscriptions. ### §7.3.7.1 SubscriptionMatchedStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133, IDL S. 160–161 (dds-1.2.pdf) — “struct SubscriptionMatchedStatus { long total_count; long total_count_change; long current_count; long current_count_change; InstanceHandle_t last_publication_handle; };”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::statusIsReadableWithoutAListener, crates/java-omgdds/java/src/test/java/org/omg/dds/ListenerTest.java::readerListenerFiresOnMatchAndOnEverySample, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusTest.java::aStatusIsResetWhenItIsReadAndDataAvailableWhenTheSamplesAreTaken, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderStatusDetailTest.java::subscriptionMatchedNamesTheWriterThatConnectedOrLeftLast

Status: done — DataReaderImpl.getSubscriptionMatchedStatus und der Listener-Pfad setzen lastPublicationHandle; ReaderStatusDetailTest prüft den Handle sowie getTotalCountChange und getCurrentCountChange (auch -1 nach dem Schließen eines Writers). (Commit e1b55167947) ### §7.3.7.1 DataAvailableStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133 (dds-1.2.pdf) — “DataReader | DATA_AVAILABLE | New information is available.”

Status: done — DataAvailableStatus ist heute eine Klasse; DataReaderListener.onDataAvailable erhält ein DataAvailableEvent mit getStatus() und getSource(). ListenerTest prüft einen Aufruf je Sample mit dem eigenen Reader als Quelle; ReaderStatusTest prüft, dass getStatusChanges() DataAvailableStatus nach dem Schreiben enthält und nach take() nicht mehr. (Commit 28e25c198d1) ### §7.3.7.1 DataOnReadersStatus

Spec: §7.3.7.1, S. 23; [DDS] 1.2 §7.1.4.1, S. 133 (dds-1.2.pdf) — “Subscriber | DATA_ON_READERS | New information is available.”

Status: done — DataReaderImpl.fireDataAvailable setzt das Flag DATA_ON_READERS am Subscriber (SubscriberImpl.dataOnReadersChanged) und ruft SubscriberListener.onDataOnReaders mit einem DataOnReadersEvent. Ohne Listener bleibt das Flag in getStatusChanges(), bis ein Reader des Subscribers gelesen oder genommen wird; mit Listener ist es nach dem Aufruf zurückgesetzt. (Commit e1b55167947) ### §7.3.7.2 Listener erweitern java.util.EventListener

Spec: §7.3.7.2, S. 23 — “This PSM maps the Listener interface from the DDS PIM to the empty marker interface java.util.EventListener interface defined by the Java SE standard library.”

Status: done — TopicListener, PublisherListener, SubscriberListener und DomainParticipantListener werden aufgerufen und geben nicht übernommene Status nach oben weiter; die drei Tests prüfen Publisher, Subscriber (auch DATA_ON_READERS), Participant und Topic. ### §7.3.7.2 Adapter-Klassen mit leeren Methoden, Name mit „Adapter“

Spec: §7.3.7.2, S. 23 — “For each listener sub-interface (e.g., DataWriterListener), this PSM provides a concrete implementation of that interface in which all methods have empty implementations. These concrete classes are named like the listener interfaces they implement, but with the word “Listener” replaced by “Adapter.””

Status: done — Sechs Adapter-Klassen (DataReaderAdapter, DataWriterAdapter, TopicAdapter, PublisherAdapter, SubscriberAdapter, DomainParticipantAdapter) implementieren ihr Listener-Interface mit leeren Methoden. Die Tests überschreiben einzelne Methoden: TopicAdapter (TopicOperationsTest), PublisherAdapter (ParticipantEntityTest, PublisherOperationsTest), SubscriberAdapter (ParticipantEntityTest, ListenerPropagationTest), DomainParticipantAdapter (ParticipantEntityTest, TopicOperationsTest, PublisherOperationsTest), DataReaderAdapter und DataWriterAdapter (ListenerTest, ParticipantSubscriberTest). (Commit d23eff980f3) ### §7.3.7.2 Callback ohne Entität, Quelle über den Status

Spec: §7.3.7.2, S. 23 — “In the DDS PIM, each listener callback receives two arguments: the Entity, the status of which has changed, and the new value of that status. In this PSM, the former is unnecessary and is omitted: it is available through the read-only Source property of the status object.”

Status: done — Jeder Callback hat genau ein Argument, ein StatusChangedEvent (erweitert java.util.EventObject) mit getSource() und getStatus(). Die Tests lesen die Entität über status.getSource() und prüfen assertSame auf den eigenen Reader bzw. Writer. Die Quelle liegt am Event, nicht an der Status-Klasse. (Commit d23eff980f3) ### §7.3.7.2 Begründung: Listener und Adapter

Spec: §7.3.7.2, S. 23 — “Design Rationale (non-normative) The listener + adapter design pattern is consistent with that used in the standard AWT and Swing UI libraries and elsewhere.”

Repo: —

Tests: —

Status: n/a (informative) — Begründung (nicht normativ); keine erfüllbare Anforderung. ### §7.3.7.2 Niedere Listener generisch: TopicListener, DataReaderListener, DataWriterListener

Spec: §7.3.7.2, S. 23 — “The former category includes TopicListener, DataReaderListener, and DataWriterListener. These classes are generic; their type parameters match that of the Entities on which they are set. This convention allows applications to read and write data within the context of a callback in a statically type-safe way.”

Status: done — DataReaderListener, DataWriterListener und TopicListener sind über den Datentyp parametrisiert; die Events tragen denselben Parameter. TopicImpl ruft onInconsistentTopic (TopicImpl.onInconsistentTopic). Tests: TopicOperationsTest::aTopicOfTheSameNameAndAnotherTypeInTheDomainIsInconsistentAndTellsTheTopicListener (TopicAdapter, getSource() als Topic ohne Umwandlung), ListenerTest::readerListenerFiresOnMatchAndOnEverySample, ::writerListenerFiresOnPublicationMatched. (Commit cd8f3d67ea9) ### §7.3.7.2 Höhere Listener mit Platzhalter ?, ohne Vererbung zu den niederen

Spec: §7.3.7.2, S. 23 — “The latter category includes PublisherListener, SubscriberListener, and DomainParticipantListener. The Topics, DataReaders, and DataWriters passed to these listeners’ callbacks are parameterized with the generic wildcard ‘?’. Because of this difference between these listeners and those in the former category, there are no inheritance relationships between these categories, unlike in the PIM.”

Status: done — PublisherListener, SubscriberListener und DomainParticipantListener nehmen Events mit Platzhalter (z. B. PublicationMatchedEvent<?>); DomainParticipantListener erweitert PublisherListener und SubscriberListener. Die Klassen PublisherImpl, SubscriberImpl und DomainParticipantImpl speichern den Listener in EntityBase, und DataWriterImpl, DataReaderImpl und TopicImpl rufen ihn über ListenerUp auf. Tests: PublisherAdapter mit onPublicationMatched und onOfferedIncompatibleQos (ParticipantEntityTest::createPublisherWithAListenerSeesTheMatchOfAWriterCreatedLater, PublisherOperationsTest::aWriterWithoutListenerPassesOfferedIncompatibleQosToThePublisher), SubscriberAdapter mit onSubscriptionMatched (ParticipantEntityTest::createSubscriberWithAListenerSeesTheMatchOfAReaderCreatedLater) und onDataOnReaders (ListenerPropagationTest), DomainParticipantAdapter mit onPublicationMatched, onOfferedIncompatibleQos und onInconsistentTopic (ParticipantEntityTest, PublisherOperationsTest, TopicOperationsTest). (Commit f31b6fa11b5) ### §7.3.7.3 Bedingungen mit Basis org.omg.dds.core.Condition

Spec: §7.3.7.3, S. 23 — “Conditions extend the base interface org.omg.dds.core.Condition.”

Status: done — org.omg.dds.core.Condition mit getTriggerValue; GuardCondition, StatusCondition und ReadCondition erweitern sie. Die Tests hängen alle drei Arten über attachCondition(Condition) an ein WaitSet und lesen getTriggerValue und die Liste der aktiven Conditions. (Commit 5041698cee3) ### §7.3.7.3 StatusCondition generisch mit getParent

Spec: §7.3.7.3, S. 23 — “The interface StatusCondition, which extends Condition, is a generic interface with a type parameter that is the type of the Entity to which it belongs. This type parameter allows its getParent method to be both polymorphic and type safe.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WaitSetTest.java::aStatusConditionTriggersOnTheStatusItIsEnabledForAndHasItsEntityAsParent

Status: done — StatusCondition<ENTITY extends Entity<?, ?>> erweitert Condition und hat ENTITY getParent(). Der Test typisiert StatusCondition<DataReader<byte[]>> ohne Umwandlung und prüft assertSame(reader, condition.getParent()). Er prüft außerdem Auslösen durch SUBSCRIPTION_MATCHED und Abschalten über setEnabledStatuses. (Commit d23eff980f3) ### §7.3.7.4 WaitSet mit Basis org.omg.dds.core.WaitSet

Spec: §7.3.7.4, S. 23 — “Wait sets extend the base interface org.omg.dds.core.WaitSet.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/core/WaitSet.java (WaitSet), crates/java-omgdds/java/src/main/java/org/zerodds/core/condition/WaitSetImpl.java (WaitSetImpl)

Status: done — org.omg.dds.core.WaitSet ist eine abstrakte Klasse mit newWaitSet(ServiceEnvironment), attachCondition, detachCondition, getConditions und waitForConditions. Die Tests prüfen Anhängen (doppeltes Anhängen ohne Wirkung), Abhängen (PreconditionNotMetException bei nicht angehängter Condition) und die Zurückweisung eines zweiten wartenden Threads. (Commit 5041698cee3) ### §7.3.7.4 wait als waitForConditions

Spec: §7.3.7.4, S. 24 — “Therefore, this PSM maps the DDS PIM wait operation to the more explicit method name waitForConditions.”

Status: done — WaitSet hat sechs Überladungen waitForConditions (ohne Argumente, mit Liste aktiver Conditions, mit Timeout als Duration oder long/TimeUnit); eine Methode wait gibt es nicht. Die Tests prüfen TimeoutException nach 30 ms, das Blockieren ohne Timeout bis zum Setzen einer GuardCondition und die Rückgabe der ausgelösten Condition in der übergebenen Liste. (Commit 5041698cee3)

§7.4 Domain Module

§7.4 Paket `org.omg.dds.domain`

Spec: §7.4, S. 24 — “This PSM realizes the Domain Module from the DDS specification with the package org.omg.dds.domain. This package contains DomainParticipant, DomainParticipantFactory, and so forth.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — Das Paket org.omg.dds.domain enthält DomainParticipant, DomainParticipantFactory, DomainParticipantListener, DomainParticipantAdapter, DomainParticipantQos und DomainParticipantFactoryQos. Der Test erzeugt über DomainParticipantFactory einen DomainParticipant und führt damit Schreiben und Lesen aus. (Commit 0840f9ed436) ### §7.4.1 DomainParticipantFactory je ServiceEnvironment ein Singleton

Spec: §7.4.1, S. 24 — “The DomainParticipantFactory is a per-ServiceEnvironment singleton. An instance of this interface can be obtained by passing that ServiceEnvironment to the factory’s getInstance method.”

Status: done — getInstance(ServiceEnvironment) liefert env.getSPI().getParticipantFactory(); ZeroSPI hält je Umgebung eine DomainParticipantFactoryImpl, die beim ersten Zugriff unter Sperre angelegt wird. Tests: QuickstartApiTest::serviceEnvironmentBootstrapBySystemProperty (assertSame für dieselbe Umgebung, assertNotSame gegen die Factory einer anderen), ::getInstanceRejectsNullEnvironment, ParticipantFactoryEnvironmentTest::threadsThatAskForTheFactoryOfANewEnvironmentTogetherGetTheSameOne (acht Threads, 25 Runden). (Commit 36e8fd3f496) ### §7.4.1 Eigene Factory je ServiceEnvironment

Spec: §7.4.1, S. 24 — “The DomainParticipantFactory is a per-ServiceEnvironment singleton.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::serviceEnvironmentBootstrapBySystemProperty, crates/java-omgdds/java/src/test/java/org/omg/dds/ParticipantFactoryEnvironmentTest.java::everyEnvironmentHasItsOwnFactoryAndItsOwnParticipantTable

Status: done — DomainParticipantFactoryImpl wird mit ihrer ServiceEnvironment angelegt (getEnvironment), führt eine eigene Tabelle der Participants (lookupParticipant) und eigene Default-QoS. Tests: QuickstartApiTest::serviceEnvironmentBootstrapBySystemProperty (assertNotSame zwischen den Factories zweier Umgebungen), ParticipantFactoryEnvironmentTest::everyEnvironmentHasItsOwnFactoryAndItsOwnParticipantTable (lookupParticipant der anderen Factory liefert null). Der InProcessBus ist ein gemeinsamer Singleton: die Participants beider Umgebungen in einer Domain entdecken sich (derselbe Test). (Commit 2e0b194caf5) ### §7.4.2 DomainParticipant als Schnittstelle org.omg.dds.domain.DomainParticipant

Spec: §7.4.2, S. 24 — “This PSM represents the DomainParticipant classifier from the DDS PIM with the interface org.omg.dds.domain.DomainParticipant.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant)

Status: done — org.omg.dds.domain.DomainParticipant ist heute eine Schnittstelle (extends Entity); die Implementierung ist org.zerodds.domain.DomainParticipantImpl. Die Tests verwenden DomainParticipant nur als Schnittstellentyp, den die Factory liefert. (Commit 0840f9ed436)

§7.5 Topic Module

§7.5 Pakete `org.omg.dds.type` und `org.omg.dds.topic`

Spec: §7.5, S. 24 — “This PSM realizes the Topic Module from the DDS specification with the packages org.omg.dds.type and org.omg.dds.topic.”

Status: done — Beide Pakete existieren: org.omg.dds.topic (Topic, TopicDescription, ContentFilteredTopic, MultiTopic, Listener, Adapter, Built-in-Daten) und org.omg.dds.type (TypeSupport, Annotationen wie Key, TypeKind, dynamic.*). PubSubLoopbackTest verwendet Topic; DynamicTopicTest verwendet org.omg.dds.type.Key, TypeKind und die Typen aus org.omg.dds.type.dynamic. (Commit 9267b77a38a) ### §7.5.1 Je Typ eine Klasse mit Basis org.omg.dds.type.TypeSupport

Spec: §7.5.1, S. 24 — “As in the DDS PIM, each type to be published or subscribed with DDS is represented by a class extending org.omg.dds.type.TypeSupport.”

Status: done — org.omg.dds.type.TypeSupport ist eine abstrakte Klasse (newData, getType, getTypeName); TypeSupportImpl erweitert sie, und TopicImpl hält eine Instanz (getTypeSupport). TopicOperationsTest::aTopicMadeFromAClassHasATypeSupportOfThatClass prüft das für ein Topic aus einer Klasse. Die von tools/idlc/src/java_support.rs erzeugten Support_<tag> in ZdTypeSupports.java erweitern org.omg.dds.type.TypeSupport<…> (mit getEnvironment, newData, getType) und implementieren weiter org.zerodds.cdr.TopicTypeSupport; java_typesupport_base erzeugt das Java für XCDR1 und XCDR2, übersetzt es mit javac -Xlint:all -Werror gegen die Quellen der Bindung und führt ein Programm aus, das die Klasse über die Basisklasse benutzt (Lauf auf dem Linux-Testhost mit JDK). (Commit 8aecff4864f) ### §7.5.1 Statische Operation newTypeSupport mit Klasse und optionalem Namen

Spec: §7.5.1, S. 24 — “Applications obtain instances of these interfaces by calling the static base class operation newTypeSupport, passing this method the Java Class object of the type they wish to support and optionally a name under which that type should be registered.”

Status: done — TypeSupport.newTypeSupport(Class, ServiceEnvironment) und newTypeSupport(Class, String, ServiceEnvironment) führen über env.getSPI().newTypeSupport zu einem TypeSupportImpl. Tests: TopicOperationsTest::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass (getType, getTypeName, newData, ein Topic daraus, Austausch eines Samples), ::aTypeSupportRegisteredUnderANameGivesTheTopicItsWritersAndItsAnnouncementThatName (Form mit Namen). (Commit 36e8fd3f496) ### §7.5.1 Ohne Namen unter dem voll qualifizierten Namen der Klasse

Spec: §7.5.1, S. 24 — “If no such name is provided, the type shall be registered under the fully qualified name of the provided Class.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass

Status: done — newTypeSupport(Class, ServiceEnvironment) übergibt in der OMG-Quelle type.getClass().getName() („java.lang.Class“) als Namen; org/omg/dds bleibt unverändert, weil die OMG-Quelle normativ ist. ZeroSPI.newTypeSupport (ServiceEnvironmentImpl) behandelt „java.lang.Class“ für einen anderen Typ als Class selbst als „kein Name angegeben“ und registriert unter type.getName(), dem voll qualifizierten Namen der Klasse (§7.5.1). Ein Typ, den eine Anwendung ausdrücklich unter „java.lang.Class“ anmeldet, ist damit nicht möglich. Test: TopicOperationsTest::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass (getTypeName = String.class.getName(), auch am Topic). (Commit 36e8fd3f496) ### §7.5.1 TypeSupport an createTopic statt register_type

Spec: §7.5.1, S. 24 — “This PSM instead asks applications to instantiate each TypeSupport object with a name and then provide that TypeSupport itself to the create_topic method.”

Status: done — DomainParticipant.createTopic(String, TypeSupport) und die Form mit QoS, Listener und Statusmenge erzeugen ein TopicImpl, das das TypeSupport hält (DomainParticipantImpl.newTopic); es gibt keine register_type-Operation. Tests: TopicOperationsTest::newTypeSupportWithoutANameRegistersUnderTheNameOfTheClass (getTypeName und getTypeSupport des Topics sind die des TypeSupport, Writer und Reader tauschen ein Sample), ::aTypeSupportRegisteredUnderANameGivesTheTopicItsWritersAndItsAnnouncementThatName. (Commit cd8f3d67ea9) ### §7.5.1 Begründung: statische Typsicherheit

Spec: §7.5.1, S. 24 — “Design Rationale (non-normative) By requiring the application to pass an instance of the generic TypeSupport interface to the createTopic method, this PSM maintains unbroken static type safety all the way from type registration to data publication or reception.”

Repo: —

Tests: —

Status: n/a (informative) — Begründung (nicht normativ); keine erfüllbare Anforderung. ### §7.5.2 Topic fügt nur den Zugriff auf INCONSISTENT_TOPIC hinzu

Spec: §7.5.2, S. 24 — “The Topic interface adds only a single operation to the set of those it inherits from its TopicDescription and DomainEntity super-types: an accessor for the inconsistent topic status.”

Status: done — Topic erweitert TopicDescription und DomainEntity und fügt getInconsistentTopicStatus hinzu; TopicImpl.onInconsistentTopic wird von DomainParticipantImpl.checkTopicConsistency und remoteEndpointSeen gerufen. Tests: TopicOperationsTest::aTopicOfTheSameNameAndAnotherTypeInTheDomainIsInconsistentAndTellsTheTopicListener (getInconsistentTopicStatus: total_count 1, Änderung 1 beim ersten und 0 beim zweiten Aufruf), ::topicsOfTheSameTypeOrInAnotherDomainAreConsistent, ParticipantWireDiscoveryTest::aTopicOfAnotherProcessIsDiscoveredAndATypeThatDiffersIsInconsistent. (Commit cd8f3d67ea9) ### §7.5.2 Topic generisch über den Datentyp

Spec: §7.5.2, S. 24–25 — “Topic—like all TopicDescriptions, and like DataReader and DataWriter—is a generic interface with a type parameter that identifies the type of the data with which it is associated.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/topic/Topic.java (Topic), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/TopicDescription.java (TopicDescription)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — Topic und TopicDescription sind über den Datentyp parametrisiert, wie DataReader und DataWriter. Der Test verwendet Topic, um DataWriter und DataReader zu erzeugen. (Commit 9267b77a38a) ### §7.5.2 Typsicherheit von der Erzeugung bis zu Schreiben und Lesen

Spec: §7.5.2, S. 25 — “Although Topic provides no type-specific operations, its type parameter preserves type safety from Topic creation (actually all the way from type registration) through data publication and/or subscription.”

Status: done — createTopic(String, Class) liefert Topic; Publisher.createDataWriter(Topic) liefert DataWriter; Subscriber.createDataReader(TopicDescription) liefert DataReader. QuickstartApiTest.singleArgFactoryReflectsTypedBean schreibt ein Temperature-Objekt und liest über Sample.getData().getCelsius() ohne Umwandlung. (Commit a91e0f632bb) ### §7.5.2 TopicDescription erweitert java.io.Closeable

Spec: §7.5.2, S. 25 — “TopicDescription interface extends java.io.Closeable to support specific new language constructs (e.g., Java try-with-resources) for dealing with this interface.”

Status: done — TopicDescription erweitert Closeable und DDSObject; ContentFilteredTopic und MultiTopic schließen sich selbst (Eintrag aus der Liste des Participants, Freigabe der gehaltenen Topics). Tests: TopicOperationsTest::aTopicDescriptionIsCloseableAndLeavesTheParticipantWhenTheResourceEnds (try-with-resources für eine ContentFilteredTopic und ein MultiTopic, danach lookupTopicDescription null), ::closingAContentFilteredTopicNeedsItsReadersGoneAndRemovesItFromTheParticipant, ::closingAMultiTopicNeedsItsReadersGoneAndFreesTheTopicsOfItsFromClause, CloseCascadeTest::participantCloseClosesContainedEntities. (Commit 36e8fd3f496) ### §7.5.3 ContentFilteredTopic und MultiTopic generisch

Spec: §7.5.3, S. 25 — “ContentFilteredTopic and MultiTopic are generic interfaces with type parameters that identify the types of the data with which they are associated.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theContentFilteredTopicOfTheParticipantFiltersTheSamples, crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicTest.java::theMultiTopicCarriesItsExpression

Status: done — ContentFilteredTopic und MultiTopic sind Schnittstellen mit Typparameter (beide erweitern TopicDescription). ContentFilterTest verwendet ContentFilteredTopic und prüft, dass ein Reader darauf nur das Sample mit value > 50 erhält; MultiTopicTest verwendet MultiTopic mit Ausdruck und Parametern. (Commit 9267b77a38a) ### §7.5.3 Typparameter der ContentFilteredTopic darf ein Obertyp sein

Spec: §7.5.3, S. 25 — “Note that the type parameter of a ContentFilteredTopic does not need to match that of its related Topic exactly; it can be any supertype. For example, if the user-defined type Bar extends the user-defined type Foo, a ContentFilteredTopic can wrap a Topic.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/domain/DomainParticipant.java (DomainParticipant.createContentFilteredTopic), crates/java-omgdds/java/src/main/java/org/omg/dds/topic/ContentFilteredTopic.java (ContentFilteredTopic.getRelatedTopic), crates/java-omgdds/java/src/main/java/org/zerodds/domain/DomainParticipantImpl.java (DomainParticipantImpl.createContentFilteredTopic)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TopicOperationsTest.java::aContentFilteredTopicOfASupertypeFiltersTheSamplesOfTheSubtypeByTheSupertypeFields

Status: done — createContentFilteredTopic nimmt Topic<? extends TYPE>, getRelatedTopic liefert Topic<? extends TYPE>; der Filter wertet die Felder des Obertyps an Samples des Untertyps aus (ContentFilter nutzt die Klasse des Samples). Test: TopicOperationsTest::aContentFilteredTopicOfASupertypeFiltersTheSamplesOfTheSubtypeByTheSupertypeFields (ContentFilteredTopic über Topic, Bar extends Foo; der Reader erhält nur das Bar mit level > 5, als Bar mit dem Feld label). (Commit 9267b77a38a) ### §7.5.4 Datentypen der eingebauten Topics in org.omg.dds.topic, nur Accessoren

Spec: §7.5.4, S. 25 — “The data types pertaining to the DDS built-in discovery topics are contained in the package org.omg.dds.topic as well. These types provide only accessors for their state, not mutators, to reflect the read-only (from an application’s point of view) nature of discovery.”

Status: done — Die vier Schnittstellen und BuiltinTopicKey in org.omg.dds.topic haben Getter für ihren Zustand und, wie die OMG-Quelle, copyFrom(src). DDS-Java-PSM 1.0 Klausel 2 macht die OMG-Quelldateien neben dem PDF normativ und bei Widerspruch maßgeblich; die Schnittstellen sind die Dateien der OMG-Quelle (CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource, SHA-256 je Datei), copyFrom gehört damit zur normativen API. Setter gibt es nur in den Klassen unter org.zerodds.topic. Die Tests lesen die Daten als Samples der eingebauten Reader. (Commit 7f102b80f83)

§7.6 Publication Module

§7.6 Paket `org.omg.dds.pub`

Spec: §7.6, S. 25 — “This PSM realizes the Publication Module from the DDS specification with the package org.omg.dds.pub.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — Das Paket org.omg.dds.pub enthält Publisher, DataWriter, PublisherListener, DataWriterListener, PublisherAdapter, DataWriterAdapter, PublisherQos und DataWriterQos. Der Test verwendet Publisher und DataWriter aus diesem Paket. (Commit a91e0f632bb) ### §7.6 Begründung: Name „pub“

Spec: §7.6, S. 25 — “Design Rationale (non-normative) The term “pub” has been preferred to the longer “publication” for the sake of brevity […]”

Repo: —

Tests: —

Status: n/a (informative) — Begründung (nicht normativ); keine erfüllbare Anforderung. ### §7.6.1 Publisher als Schnittstelle org.omg.dds.pub.Publisher

Spec: §7.6.1, S. 25 — “Publishers are represented by instances of the org.omg.dds.pub.Publisher interface.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/Publisher.java (Publisher), crates/java-omgdds/java/src/main/java/org/zerodds/pub/PublisherImpl.java (PublisherImpl)

Status: done — org.omg.dds.pub.Publisher ist eine Schnittstelle (extends DomainEntity<PublisherListener, PublisherQos>); PublisherImpl implementiert sie. Die Tests halten das Ergebnis von DomainParticipant.createPublisher als Publisher und verwenden createDataWriter darauf. (Commit a91e0f632bb) ### §7.6.1 Überladung lookupDataWriter(Topic)

Spec: §7.6.1, S. 25 — “In addition to the methods defined for this interface by [DDS], it additionally provides a lookupDataWriter overload that acts on the basis of a Topic object rather than solely on the topic’s name.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PublisherOperationsTest.java::lookupDataWriterFindsByNameAndByTopicAndForgetsClosedWriters

Status: done — Publisher hat lookupDataWriter(String topicName) und lookupDataWriter(Topic); PublisherImpl liefert den ersten Writer mit dem Topicnamen oder null (die Topic-Überladung vergleicht den Namen). Test: PublisherOperationsTest::lookupDataWriterFindsByNameAndByTopicAndForgetsClosedWriters (beide Überladungen für ein vorhandenes und ein fehlendes Topic, null nach close). (Commit a91e0f632bb) ### §7.6.2 DataWriter als generische Schnittstelle org.omg.dds.pub.DataWriter

Spec: §7.6.2, S. 25 — “DataWriters are represented by instances of the org.omg.dds.pub.DataWriter interface. This is a generic interface, parameterized by the type of the data samples to be written by a given writer.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/pub/DataWriter.java (DataWriter), crates/java-omgdds/java/src/main/java/org/zerodds/pub/DataWriterImpl.java (DataWriterImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — org.omg.dds.pub.DataWriter ist heute eine Schnittstelle (extends DomainEntity<DataWriterListener, DataWriterQos>), parametrisiert über den Datentyp; DataWriterImpl implementiert sie. Der Test verwendet DataWriter zum Schreiben. (Commit 5eb3cb8ca5b) ### §7.6.2 Kein FooDataWriter, alle typspezifischen Operationen an DataWriter

Spec: §7.6.2, S. 25 — “This PSM makes no such distinction: Java’s generic wildcard syntax (DataWriter<?>) makes it possible to express all type-specific DataWriter operations on the DataWriter interface itself; there is no FooDataWriter.”

Status: done — write, registerInstance, unregisterInstance, dispose, getKeyValue und lookupInstance stehen an DataWriter; es gibt keinen FooDataWriter. tools/idlc/src/java_support.rs erzeugt nur ZdTypeSupports, keinen Writer je Typ (gelesen, nicht durch Test belegt). Die Tests schreiben über DataWriter und prüfen registerInstance und lookupInstance (Handle ungleich nil, nil für unbekannten Schlüssel). (Commit 5eb3cb8ca5b) ### §7.6.2 Zeitstempel und Handles als Überladungen

Spec: §7.6.2, S. 25–26 — “Java does; therefore, the provision of timestamps and/or instance handles is optional and is handled by means of method overloads. For example, the write method provides the following overloads: one accepting a data sample only, another accepting a sample and an instance handle, and another accepting both of these as well as a timestamp.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::everyWriteOverloadCarriesItsSourceTimestampToTheSample, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::registerInstanceTakesATimestampAndLookupInstanceFindsTheInstanceByItsKey, crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed

Status: done — DataWriter hat write, registerInstance, unregisterInstance und dispose je mit den Überladungen Sample, Sample mit Time oder long/TimeUnit, Sample mit InstanceHandle, Sample mit InstanceHandle und Zeitstempel. DataWriterImpl verwendet den Zeitstempel in Millisekunden als Source-Zeitstempel und prüft den Handle gegen die Instanz des Samples. Tests: WriterHandleTest::everyWriteOverloadCarriesItsSourceTimestampToTheSample (Zeitstempel und Instanz-Handle am Sample des Readers für fünf Formen), ::registerInstanceTakesATimestampAndLookupInstanceFindsTheInstanceByItsKey, ::disposeByHandleOrBySampleMakesTheReaderSeeTheInstanceDisposed (Formen mit Time und long/TimeUnit). (Commit d70d1f69c5d) ### §7.6.2 Bei ungeschlüsselten Typen ein nil-Handle

Spec: §7.6.2, S. 26 — “Users of DataWriters of unkeyed types may choose to call the overloads that accept instance handle arguments; if they do, the handle argument must be a nil handle (as explained in the DDS PIM).”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/WriterHandleTest.java::anUnkeyedTypeIsWrittenWithTheNilHandle

Status: done — Die Überladungen mit InstanceHandle (write, registerInstance, dispose, unregisterInstance) sind vorhanden; DataWriterImpl.write(T, InstanceHandle, …) lässt HANDLE_NIL zu und leitet die Instanz aus dem Schlüssel ab (für einen Typ ohne Schlüssel die eine Instanz). Test: WriterHandleTest::anUnkeyedTypeIsWrittenWithTheNilHandle (byte[]-Topic, drei Formen mit Nil-Handle, alle drei Samples beim Reader, Zeitstempel der Formen mit Time und long/TimeUnit). (Commit d70d1f69c5d)

§7.7 Subscription Module

§7.7 Paket `org.omg.dds.sub`

Spec: §7.7, S. 26 — “This PSM realizes the Subscription Module from the DDS specification with the package org.omg.dds.sub.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — Das Paket org.omg.dds.sub enthält Subscriber, DataReader, Sample, SubscriberListener, DataReaderListener, ReadCondition und QueryCondition. Der Test benutzt Subscriber, DataReader und Sample aus diesem Paket. Die Angabe im alten Text, SubscriberListener und die Bedingungen fehlten, trifft nicht mehr zu. (Commit a91e0f632bb) ### §7.7 Begründung: Name „sub“

Spec: §7.7, S. 26 — “Design Rationale (non-normative) The term “sub” has been preferred to the longer “subscription” for the sake of brevity […]”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ (Begründung für den Paketnamen). ### §7.7.1 Subscriber als Schnittstelle org.omg.dds.sub.Subscriber

Spec: §7.7.1, S. 26 — “Subscribers are represented by instances of the org.omg.dds.sub.Subscriber interface.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Subscriber.java (Subscriber), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SubscriberImpl.java (SubscriberImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — Subscriber ist public interface Subscriber; SubscriberImpl implementiert sie. Der Test hält das Ergebnis von participant.createSubscriber() in einer Variablen vom Typ Subscriber und erzeugt darüber den Reader. Die Angabe im alten Text (finale Klasse mit öffentlichem Konstruktor) trifft nicht mehr zu. (Commit a91e0f632bb) ### §7.7.1 Überladung lookupDataReader(TopicDescription)

Spec: §7.7.1, S. 26 — “In addition to the methods defined for this interface by [DDS], it additionally provides a lookupDataReader overload that acts on the basis of a TopicDescription object rather than solely on the topic description’s name.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSubscriberTest.java::lookupDataReaderFindsTheReaderByTopicNameAndByTopicDescription

Status: done — lookupDataReader(String) und lookupDataReader(TopicDescription) finden den Reader nach Name und nach Beschreibung, liefern null für ein unbekanntes Topic und nach dem Schließen des Readers; null als Beschreibung ergibt IllegalArgumentException. (Commit a91e0f632bb) ### §7.7.2 Sample als ein Objekt aus Daten und Metadaten, Schnittstelle org.omg.dds.sub.Sample

Spec: §7.7.2, S. 26 — “This PSM follows the guidance of the DDS PIM rather than of the IDL PSM: it represents data samples as single objects that incorporate both data and metadata. Each sample is represented by an instance of the org.omg.dds.sub.Sample interface.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/rpc/RpcInheritanceTest.java::thePsmSampleIsAnInterface, crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — Sample<TYPE> ist eine Schnittstelle mit getData und den Metadaten (getSampleState, getViewState, getInstanceState u. a.) in einem Objekt; SampleImpl implementiert sie. thePsmSampleIsAnInterface prüft Sample.class.isInterface() und dass sie nicht final ist. Der zweite Test liest Daten aus den von take gelieferten Samples. (Commit 9267b77a38a) ### §7.7.2 getData liefert die Daten

Spec: §7.7.2, S. 26 — “It provides its data via a getData method […]”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/Sample.java (Sample.getData), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleImpl.java (SampleImpl.getData)

Status: done — byteArrayQuickstartRoundTrip schreibt "hello".getBytes() und liest sie über Sample.getData() zurück; readReturnsAFreshCopyNotTheReadersObject prüft den Wert getData().value == 42. QuickstartApiTest.getDataAliasesData vergleicht getData() mit sich selbst und belegt nichts. (Commit 9267b77a38a) ### §7.7.2 getData liefert null ohne gültige Daten

Spec: §7.7.2, S. 26 — “if there is no valid data (corresponding to a false value for SampleInfo.valid_data in the IDL PSM), this operation returns null.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/MultiTopicJoinTest.java::disposingAConstituentDisposesTheResultInstance

Status: done — DataReaderImpl.markState legt für NOT_ALIVE_DISPOSED und NOT_ALIVE_NO_WRITERS ein Sample mit null als Daten an. Der Test löst über ein Dispose eines Teil-Topics ein solches Sample im Reader des MultiTopic aus und prüft assertNull(getData()) und NOT_ALIVE_DISPOSED. Für einen Reader eines gewöhnlichen Topics prüft kein Test getData() == null, ebenso nicht für NOT_ALIVE_NO_WRITERS. (Commit f31b6fa11b5) ### §7.7.2 Metadaten als nur lesbare Eigenschaften nach Java Beans

Spec: §7.7.2, S. 26 — “It provides its metadata (corresponding to the other SampleInfo properties in the IDL PSM) as read-only Java-Bean-style properties.”

Status: done — DataReaderImpl.toSample und SampleImpl.of liefern disposed_generation_count, no_writers_generation_count, sample_rank, generation_rank und absolute_generation_rank aus den Zählern und der Sammlung (statt der Konstanten 0 und -1), dazu source_timestamp und publication_handle. Die Tests in ReaderSampleInfoTest prüfen alle sieben Werte. (Commit e1b55167947) ### §7.7.2 Sample.Iterator erweitert ListIterator, nur lesend

Spec: §7.7.2, S. 26 — “The Sample interface also defines a nested interface: Sample.Iterator, an iterator that extends java.util.ListIterator. An iterator of this type provides read-only access to an ordered series of samples of a single type; such iterators are used by the DataReader read and take methods (see below).”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderIteratorTest.java::theIteratorIsReadOnly

Status: done — SampleIterator.remove, set und add werfen UnsupportedOperationException (DDS-Java-PSM 1.0 §7.7.2). Der Test ruft alle drei an einem Iterator von DataReader.read() auf und prüft, dass die Sammlung unverändert bleibt. (Commit e0f89cfd194) ### §7.7.3 DataReader als generische Schnittstelle org.omg.dds.sub.DataReader

Spec: §7.7.3, S. 26 — “DataReaders are represented by instances of the org.omg.dds.sub.DataReader interface. This is a generic interface, parameterized by the type of the data samples to be read by a given reader.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::singleWriterSingleReaderRoundTrip

Status: done — DataReader<TYPE> ist public interface DataReader<TYPE>; DataReaderImpl implementiert sie. Der Test benutzt DataReader<Reading> und liest Sample<Reading> mit dem Datentyp Reading. Die Angabe im alten Text (finale Klasse) trifft nicht mehr zu. (Commit 5eb3cb8ca5b) ### §7.7.3 Kein FooDataReader, alle typspezifischen Operationen an DataReader

Spec: §7.7.3, S. 26 — “This PSM makes no such distinction: Java’s generic wildcard syntax (DataReader<?>) makes it possible to express all type-specific DataReader operations on the DataReader interface itself; there is no FooDataReader.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/PubSubLoopbackTest.java::readReturnsSamplesWithoutRemoving, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderKeyTest.java::getKeyValueReturnsASampleOfTheInstanceThatHasTheKey, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderKeyTest.java::lookupInstanceIsNilBeforeTheInstanceIsKnownAndTheHandleOfTheSampleAfterwards, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::readNextSampleReturnsTheNextSampleNotYetReadAndTakeNextSampleRemovesIt

Status: done — Alle typspezifischen Operationen (read, take, lookupInstance, getKeyValue, readNextSample, takeNextSample) stehen an DataReader; getKeyValue setzt die Schlüsselfelder (siehe das Item zu get_key_value) und alle sind getestet. (Commit e1b55167947) ### §7.7.3 Zwei Arten von read und take: Loan mit Sample.Iterator, Kopie in eine List der Anwendung

Spec: §7.7.3, S. 26 — “The DataReader interface provides a number of read and take method overloads. In addition to the distinction between read vs. take semantics (as defined in the DDS PIM), these operations come in two “flavors.” One that loans samples from a Service pool and returns a Sample.Iterator and another that deeply copies into an application-provided java.util.List”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.read), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.take), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.toSample), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SampleIterator.java (SampleIterator)

Status: done — read(), take(), read(int), take(Selector) liefern einen Sample.Iterator: Inhalt und Reihenfolge, Richtungswechsel, READ nach read, Entfernen nach take sind getestet. (Commit e1b55167947) ### §7.7.3 returnLoan am Iterator, Iterator ist Closeable

Spec: §7.7.3, S. 27 — “Applications that read or take loans must eventually return those loans; this PSM maps the return_loan operation from the DDS PIM to an operation returnLoan on the Sample.Iterator. Moreover, the iterator implements the Java.io.Closeable interface so that try-with-resources construct can be used in Java 7.”

Status: done — SampleIterator.close wirft beim zweiten Aufruf nichts mehr (Closeable, Sample.Iterator: close ohne Leihgabe ist ohne Wirkung); try-with-resources über read() und take() ist getestet. Die OMG-API nennt die Operation close; der Name returnLoan des PSM-Texts ist dort nicht vorhanden (org.omg.dds wird nicht geändert). (Commit e0f89cfd194) ### §7.7.3 Kopie: Liste mit beliebig vielen Samples, danach die angeforderte Zahl

Spec: §7.7.3, S. 27 — “Applications that read or take copies may provide to the Service destination Lists with any number of Samples already in them (including empty Lists). Regardless of the number of Samples already in the list when the method is called, when it returns, the List shall contain the number of Samples requested by the application (or fewer, if fewer were available).”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.read), crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.take), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.read), crates/java-omgdds/java/src/main/java/org/zerodds/sub/DataReaderImpl.java (DataReaderImpl.take)

Status: done — read(List), take(List), read(List, Selector), take(List, Selector) und Selector.read(List)/take(List) ersetzen den Inhalt der Liste durch die gelieferten Samples (zu lange Listen werden gekürzt, kurze erweitert); null ergibt eine neue Liste. Die Zahl ist maxSamples des Selectors (DDS-Java-PSM §7.7.3: die angeforderte Zahl), nicht die Länge der Liste. (Commit e1b55167947) ### §7.7.3 Kopie darf übergebene Samples überschreiben

Spec: §7.7.3, S. 27 — “The Service implementation may—for example, in order to avoid object allocations—elect to overwrite the contents of any Samples that are passed into it by invocations of these methods.”

Repo: —

Tests: —

Status: n/a (informative) — Erlaubnis für die Implementierung (“may”); die Anforderung fordert nichts. DataReaderImpl.toSample überschreibt keine übergebenen Samples, sondern legt neue an. ### §7.7.3 DataReader.Selector kapselt die Auswahlkriterien

Spec: §7.7.3, S. 27 — “Instead of overloading several operation variants that accept large numbers of infrequently used parameters, a DataReader.Selector is provided to encapsulate various selection criteria (for example, sets of sample, instance, and view states).”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/sub/DataReader.java (DataReader.Selector), crates/java-omgdds/java/src/main/java/org/zerodds/sub/SelectorImpl.java (SelectorImpl)

Status: done — Selector.instance, nextInstance, dataState, Content und maxSamples sind über read(Selector)/take(Selector) getestet; nextInstance liefert die nächste Instanz nach Handle (auch zusammen mit instance(h)). (Commit e1b55167947) ### §7.7.3 DataReader.select liefert einen Selector mit den Vorgaben

Spec: §7.7.3, S. 27 — “DataReader.select method returns a Selector object, which encapsulates the default selection criteria.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theSelectorOfReadAndTakeCarriesTheExpression

Status: done — DataReaderImpl.select gibt ein SelectorImpl zurück, das an den Reader gebunden ist. Der Test ruft reader.select().Content(...) auf und liest über selector.read(got) aus demselben Reader. Die einzelnen Vorgaben des Selector stehen in den folgenden Items. (Commit 5eb3cb8ca5b) ### §7.7.3 Vorgabe des Selector: instanceHandle=null

Spec: §7.7.3, S. 27 — “For portability, the default state of the Selector object is defined as instanceHandle=null, […]”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything

Status: done — select().getInstance() ist null; read() mit dem Standard-Selector liefert die Samples aller Instanzen (drei Instanzen, sechs Samples). (Commit e1b55167947) ### §7.7.3 Vorgabe des Selector: nextInstance=false

Spec: §7.7.3, S. 27 — “[…] nextInstance=false, […]”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything

Status: done — select().retrieveNextInstance() ist false. (Commit e1b55167947) ### §7.7.3 Vorgabe des Selector: dataState=any

Spec: §7.7.3, S. 27 — “[…] dataState=any, […]”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything

Status: done — SelectorImpl.getDataState() liefert ohne Setzen DataStateImpl.any(environment) (alle Sample-, View- und Instanzzustände); der Test vergleicht mit assertEquals. (Commit e0f89cfd194) ### §7.7.3 Vorgabe des Selector: queryExpression=null

Spec: §7.7.3, S. 27 — “[…] queryExpression=null, […]”

Status: done — select().getQueryExpression() ist null und read() ohne Ausdruck liefert alle Samples; mit Content(...) filtert collectLocked. (Commit e1b55167947) ### §7.7.3 Vorgabe des Selector: maxSamples=unlimited

Spec: §7.7.3, S. 27 — “[…] and maxSamples=unlimited.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::maxSamplesLimitsReadAndTakeAndUnlimitedIsAcceptedAsAValue

Status: done — SelectorImpl.maxSamples akzeptiert ResourceLimits.LENGTH_UNLIMITED und Werte ab 0, andere negative Werte ergeben IllegalArgumentException; getMaxSamples() liefert standardmäßig LENGTH_UNLIMITED. read(Selector)/take(Selector) begrenzen auf die Zahl. (Commit e0f89cfd194) ### §7.7.3 Selector als fluent Schnittstelle mit eigenem read und take

Spec: §7.7.3, S. 27 — “Selector provides fluent interface to modify the default selection parameters. For convenience, Selector provides read and take methods.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/ContentFilterTest.java::theSelectorOfReadAndTakeCarriesTheExpression, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theDefaultSelectorSelectsEverything, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::anInstanceHandleLimitsReadAndTakeToThatInstance, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::nextInstanceWalksTheInstancesInTheOrderOfTheirHandles, crates/java-omgdds/java/src/test/java/org/omg/dds/ReaderSelectorTest.java::theCopyFlavourReplacesWhatTheListHeldAndAllocatesAListForNull

Status: done — Der Selector ist fluent (instance, nextInstance, dataState, Content, maxSamples liefern ihn zurück) und hat read(), read(List), take(), take(List); verkettete Aufrufe sind getestet. (Commit e1b55167947)

§7.8 Extensible and Dynamic Topic Types Module

§7.8 Typen der TypeObject-Darstellung in `org.omg.dds.type.typeobject`

Spec: §7.8, S. 27 — “Types pertaining to TypeObject Type Representations are defined in the package org.omg.dds.type.typeobject.”

Status: done — Das Paket org.omg.dds.type.typeobject stimmt dateiweise mit der OMG-Quelle überein und ist umgesetzt. Die Schnittstellen bilden die TypeObject-Bibliothek von DDS-XTypes 1.1 Anhang B ab (formal/2012-11-10, im Spec-Cache .agent/spec/dds-xtypes-1.1.txt); idl/typeobject/dds_xtypes_11_typeobject.idl übernimmt das IDL des Anhangs in der Annotationssyntax von IDL 4 (@extensibility statt @Extensibility(...), @id(<Wert>), @external statt @Shared, bitmask statt @BitSet-Aufzählung) mit vier Änderungen, die keinen Wert und keine Kennung betreffen: der Typ _TypeId heißt in Java TypeId; das Member annotation heißt _annotation, weil annotation in IDL 4 ein Schlüsselwort ist; Bound heißt CollectionBound, weil bound und Bound in IDL ein Bezeichner sind; MapType, SequenceType und StringType sind @mutable wie ihre Basis CollectionType (der Anhang schreibt EXTENSIBLE, die Member haben aber Kennungen). Der Anhang vergibt dem Enumerator MODULE_ELEMENT den Wert 22, den auch STRUCTURE_TYPE_ELEMENT hat; hier ist es 24. Aus dem IDL erzeugt scripts/generate-typeobject.sh mit idlc (XCDR1) Datentypen und Codec (org/zerodds/typeobject/generated). Die TypeId eines konstruierten Typs ist die niederwertige Hälfte des MD5 der Big-Endian-Serialisierung des Typs (§7.3.4.1.2; der Anhang lässt offen, was die eigene type_id beim Hashen trägt: hier NO_TYPE). TypeObjectBuilder schreibt das TypeObject eines DynamicType (Art, Name, Extensibility, Basistyp, Member mit Kennung, Key, Optional, Union-Etiketten, Enumerationskonstanten, Grenzen), TypeObjectModel setzt die Schnittstellen des Pakets auf ein gelesenes TypeObject, TypeObjectToDynamic bildet den DynamicType zurück. Die Schnittstellen haben ganze Zahlen als Typkennung; die Abbildung steht in TypeObjectModel: primitive Typen haben die TypeId-Konstante der PSM, konstruierte 0x10000 plus Index in der Bibliothek. Ein Annotationsgebrauch wird gelesen, aber nicht geschrieben (die Liste der Gebrauche ist leer); eine Bitmenge nennt keine Bits; eine Union kennt keinen Diskriminator-Typ (der Anhang hat kein Member dafür). (Commit b4bf3fa978e) ### §7.8 Dynamic Language Binding in org.omg.dds.type.dynamic

Spec: §7.8, S. 27 — “Types pertaining to the Dynamic Language Binding are defined in the package org.omg.dds.type.dynamic.”

Status: done — Das Paket org.omg.dds.type.dynamic enthält DynamicType, DynamicTypeMember, DynamicData, beide Factories und die drei Deskriptoren (dateiweise gleich den OMG-Quellen). DynamicTopicTest erzeugt Typ und Daten über diese Schnittstellen und bewegt DynamicData durch Writer und Reader; DynamicTypeReflectionTest liest DynamicType aus Klassen. Die Angabe im alten Text (Paket fehlt, org.zerodds.cdr.DynamicType außerhalb) trifft nicht mehr zu. (Commit 5041698cee3) ### §7.8 TypeKind in org.omg.dds.type

Spec: §7.8, S. 27 — “The TypeKind enumeration, which pertains to both of the above, is defined in the package org.omg.dds.type.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/TypeKind.java (TypeKind)

Status: done — org.omg.dds.type.TypeKind ist vorhanden (gleich der OMG-Quelle) mit den Arten von NO_TYPE bis ANNOTATION_TYPE, darunter die vorzeichenlosen Typen, CHAR_32_TYPE, FLOAT_128_TYPE, Aufzählung, Bitmenge, Union und Array. Die Tests vergleichen DynamicType.getKind() mit Werten dieses Enums. Der alte Text (DynamicType.Kind mit zwölf Werten) beschreibt den Altbestand org.zerodds.cdr.DynamicType. (Commit 5041698cee3) ### §7.8 Eingebaute Typen in org.omg.dds.type.builtin

Spec: §7.8, S. 27 — “The built-in types are defined in the package org.omg.dds.type.builtin.”

Status: done — Das Paket org.omg.dds.type.builtin ist vorhanden mit KeyedString und KeyedBytes; BuiltinTypes enthält KeyedStringImpl und KeyedBytesImpl, ServiceEnvironment.getSPI().newKeyedString()/newKeyedBytes() erzeugen sie. TypesBuiltinTest prüft setKey/setValue (Rückgabe des Objekts, Kopie des Byte-Arrays beim Setzen und Lesen, Bereichsform von setValue), copyFrom, clone, equals/hashCode und die Java-Serialisierung, dazu je einen Writer und Reader auf einem Topic des Typs. Die TypeSupports der Typen stehen in BuiltinTypeSupports (Items zu DDS::KeyedString und DDS::KeyedBytes). (Commit ec44921ff1d) ### §7.8 Erweiterungen von [DDS-XTypes] in den Datentypen der eingebauten Topics

Spec: §7.8, S. 27 — “Extensions by [DDS-XTypes] to types defined by [DDS] (such as the built-in topic data types) are contained within those types.”

Status: done — Die Datentypen der eingebauten Topics (PublicationBuiltinTopicData, SubscriptionBuiltinTopicData, TopicBuiltinTopicData) tragen getEquivalentTypeName, getBaseTypeName, getType, getRepresentation und getTypeConsistency. Getestet sind equivalentTypeName, baseTypeName und die Type-Information-Oktette über Wire und SEDP (BuiltinTopicQosTest) sowie getRepresentation und getTypeConsistency aus der QoS lokaler Entities, auf den Parameter-IDs 0x0073 und 0x0074 in der Serialisierung der Built-in-Topic-Daten, nach dem Rücklesen und aus einer SEDP-Ankündigung (TypesBuiltinTopicDataTest); EXACT_TYPE, EXACT_NAME werden als DISALLOW_TYPE_COERCION (0), ASSIGNABLE und DECLARED als ALLOW_TYPE_COERCION (1) geschrieben. getType() liefert das TypeObject nach XTypes 1.1 (PID 0x0072, @id(0x0072) type): für lokale Entitäten aus dem DynamicType des TypeSupport (TypeObjects.announce in BuiltinData.describeType), für entfernte aus den angekündigten Oktetten (TypeObjects.decodeOrNull); Oktette, die kein TypeObject sind, geben null, und getTypeObjectBytes() behält sie. Die Abbildung zwischen den Fassungen: auf dem Draht gilt XTypes 1.3 (TypeInformation 0x0075 bleibt die Angabe, die die Peers lesen), der Parameter 0x0072 trägt das TypeObject der Fassung 1.1 nach Anhang B, das die Java-PSM-Schnittstellen abbilden. (Commit b4bf3fa978e) ### §7.8.1 Bestandteile des Dynamic Language Binding

Spec: §7.8.1, S. 27 — “The Dynamic Language Binding, as defined by [DDS-XTypes], consists of DynamicType, DynamicTypeMember, DynamicData, their respective factories, and several “descriptor” value types.”

Repo: —

Tests: —

Status: n/a (informative) — Aufzählung der Bestandteile; die Anforderungen stehen in §7.8.1.1 bis §7.8.1.5. ### §7.8.1.1 DynamicTypeFactory je ServiceEnvironment ein Singleton (DynamicTypeFactory.getInstance(env))

Spec: §7.8.1.1, S. 27 — “This abstract factory is a per-ServiceEnvironment singleton.”

Status: done — DynamicTypeFactory.getInstance(env) liefert env.getSPI().getTypeFactory(); ServiceEnvironmentImpl.getSPI legt je Environment genau einen SPI mit einer DynamicTypeFactoryImpl an. theFactoryIsASingletonPerServiceEnvironment prüft, dass zwei Aufrufe dasselbe Objekt liefern, dass es das der SPI ist, dass ein zweites ServiceEnvironmentImpl eine andere Factory hat (mit anderen Primitivtypen) und dass diese ihrerseits stabil ist. (Commit a25948e911c) ### §7.8.1.1 Kein delete_instance an DynamicTypeFactory, der Service verwaltet die Lebensdauer

Spec: §7.8.1.1, S. 27 — “The static delete_instance operations defined in [DDS-XTypes] have been omitted in this PSM; the Service shall manage the life cycles of the factory.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicTypeTest.java::thereIsNoDeleteInstanceAndTheServiceManagesTheLifeCycle

Status: done — org.omg.dds.type.dynamic.DynamicTypeFactory und DynamicTypeFactoryImpl haben keine Operation deleteInstance oder ähnliche; die Lebensdauer richtet sich nach dem ServiceEnvironment. thereIsNoDeleteInstanceAndTheServiceManagesTheLifeCycle prüft per Reflection beide Klassen auf Methoden mit delete im Namen und dass getInstance die einzige statische Methode der abstrakten Factory ist. (Commit a25948e911c) ### §7.8.1.2 DynamicTypeSupport entfällt

Spec: §7.8.1.2, S. 27 — “The interface DynamicTypeSupport defined by [DDS-XTypes] does not provide any capability beyond what the generic TypeSupport interface provided by this PSM already provides. Therefore, it has been omitted from this PSM.”

Repo: —

Tests: —

Status: n/a (informative) — Die Spec beschreibt, dass DynamicTypeSupport in dieser PSM entfällt; org.omg.dds.type und org.omg.dds.type.dynamic enthalten keine solche Schnittstelle (Verzeichnisliste gelesen). Die Stelle verlangt nichts Erfüllbares. ### §7.8.1.3 DynamicType und DynamicTypeMember als Schnittstellen nach den Regeln dieses Dokuments

Spec: §7.8.1.3, S. 28 — “These interfaces are expressed in this PSM according to the mapping rules expressed elsewhere in this document.”

Status: done — DynamicType und DynamicTypeMember sind Schnittstellen in org.omg.dds.type.dynamic mit getDescriptor, getName, getKind, getMember, getAllMembers, den Annotationsoperationen und addMember; DynamicTypeImpl und DynamicTypeMemberImpl setzen sie um. TypesDynamicTypeTest prüft getMember(int)/getMember(String) (auch unbekannte), getAllMembers(), getAllMembers(int...), getAllMembers(String...), addMembers, getAnnotation(int)/getAnnotation(String), getAllAnnotations, getAnnotations(int...)/getAnnotations(String...), setAnnotation(s) und an DynamicTypeMember getId, getName, getDescriptor, getAnnotations. equals und clone stehen im Item zu §7.8.1.3 equals/clone. Der Altbestand org.zerodds.cdr.DynamicType ist daneben noch vorhanden. (Commit a25948e911c) ### §7.8.1.3 Ergebnis direkt als Rückgabewert statt über in-out-Parameter und ReturnCode_t

Spec: §7.8.1.3, S. 28 — “Operations that provide their result as an in-out value in their first parameter and return DDS::ReturnCode_t have been changed such that they instead return their results directly.”

Status: done — Die Operationen von DynamicType, DynamicTypeMember und der Factory liefern ihr Ergebnis als Rückgabewert (getDescriptor(), getMember(...), createType(...), getPrimitiveType(...)); es gibt keinen in-out-Parameter und kein ReturnCode_t. Die Tests verketten diese Aufrufe, z. B. type.getMember(name).getDescriptor().getType().getKind(). (Commit 5041698cee3) ### §7.8.1.3 equals und clone als Object.equals und Object.clone

Spec: §7.8.1.3, S. 28 — “The equals and clone operations on these types have been mapped to overrides of the Java-standard Object.equals and Object.clone, respectively.”

Status: done — DynamicTypeImpl.equals/hashCode vergleichen nach XTypes 1.3 §7.5.2.8.4 (Table 54) Deskriptor, Mitglieder (nach Id) und Annotationen; DynamicTypeMemberImpl.equals nach §7.5.2.6.3 Deskriptor, Annotationen und den Deskriptor des Typs, zu dem das Mitglied gehört; die Deskriptoren vergleichen alle Eigenschaften der Tabellen 50 und 53 und §7.5.2.3.2. DynamicTypeImpl.clone() liefert einen gleichen Typ ohne gemeinsame Mitglieder (Änderungen an Kopie oder Original wirken nicht auf das andere). Die PSM hat an DynamicTypeMember kein clone. Getestet in TypesDynamicTypeTest. (Commit a25948e911c) ### §7.8.1.3 DynamicTypeMember als Referenztyp aus DynamicType.addMember

Spec: §7.8.1.3, S. 28 — “DynamicTypeMember is a reference type, and instances of it are obtained from DynamicType.addMember. This change avoids the need to provide an additional factory method for DynamicTypeMember instances.”

Status: done — DynamicTypeImpl.addMember(MemberDescriptor) legt das DynamicTypeMember im Typ an und gibt dasselbe Objekt zurück; DynamicTypeFactory hat keine Factory-Methode für Mitglieder (nur newMemberDescriptor). In theKeyAnnotationMakesTheTopicKeyed setzt der Test setAnnotation(Key) auf dem von addMember gelieferten Mitglied, und der Codec des Typs ist danach verschlüsselt (isKeyed). Das beweist, dass der Rückgabewert das Mitglied des Typs ist. (Commit 7d991374fd4) ### §7.8.1.3 getAnnotations statt get_annotation_count und get_annotation, Liste nicht änderbar

Spec: §7.8.1.3, S. 28 — “On each type, the operations get_annotation_count and get_annotation (by index) have been unified into a single getAnnotations method that returns a list of annotations. The lists returned from these methods shall not be modifiable.”

Status: done — DynamicTypeMember.getAnnotations() liefert eine nicht änderbare Liste (Collections.unmodifiableList über eine Kopie); DynamicType.getAllAnnotations(), getAnnotations(int...) und getAnnotations(String...) liefern nicht änderbare Maps. theListsAndMapsOfAnnotationsCannotBeModified prüft add/clear/remove/put auf UnsupportedOperationException und dass der Typ danach unverändert ist. DynamicType hat statt einer einzelnen Listenmethode getAllAnnotations() und die beiden getAnnotations-Formen. Die Maps von getAllMembers bleiben änderbare Kopien (die Spec nennt nur die Annotationslisten). (Commit a25948e911c) ### §7.8.1.3 Zusätzliche Factory-Methode createType(Class<?>) nach §8

Spec: §7.8.1.3, S. 28 — “In addition to the methods specified by [DDS-XTypes], DynamicTypeFactory provides one additional factory method: createType(Class<?>). This method shall inspect the given type reflectively in accordance with the Java Type Representation (see Clause 8) and instantiate an equivalent DynamicType object.”

Status: done — DynamicTypeFactoryImpl.createType(Class<?>) bildet eine Klasse nach der Java Type Representation (Tabelle 8.1, Aufzählung, Struktur, Union, Sammlungen, Map, Annotationen, Oberklasse als Basistyp, nur die Felder, die java.io.Serializable zuweist) auf einen DynamicType ab und weist Klassen ohne Art mit IllegalArgumentException zurück; DynamicTypeReflectionTest und TypesDynamicTypeTest prüfen das. Die Methode steht nicht in org.omg.dds.type.dynamic.DynamicTypeFactory: die Quelle omgdds_src.zip, die nach §2 bei einem Widerspruch gilt, hat sie nicht, und org/omg/dds bleibt gleich der Quelle (CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource). Zugang: DynamicTypeFactoryImpl.getInstance(env) liefert dieselbe Factory wie DynamicTypeFactory.getInstance(env) mit dem Typ der Implementierung (createTypeIsReachedThroughTheImplementationOfTheFactory). Der Altbestand org.zerodds.cdr.DynamicTypeFactory.createType liefert den alten org.zerodds.cdr.DynamicType. (Commit 72b36ae5db2) ### §7.8.1.4 DynamicData als Schnittstelle nach den Regeln dieses Dokuments

Spec: §7.8.1.4, S. 28 — “This interface is expressed in this PSM according to the mapping rules expressed elsewhere in this document.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aWriterAndAReaderOnTheTopicOfADynamicTypeMoveDynamicData, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aStructureWithANestedStructureAndAnArray, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTopicTest.java::aUnionIsItsDiscriminatorAndTheSelectedMember, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::everyPrimitiveKindIsReadBackWhatWasSet, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aSmallerSignedKindIsPromotedToTheLargerAccessor, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aValueOutsideTheRangeOfTheMemberIsRefused, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::descriptorsAndMemberIdsFollowTheType, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::membersByNameAreTheMembersById, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::clearingANonOptionalMemberSetsItToItsDefault, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::clearingAnOptionalMemberRemovesIt, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::clearAllValuesClearsEveryMemberAndClearNonkeyValuesKeepsTheKey, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aLoanedStructureIsTheNestedValueAndChangesToItAreChangesToTheSample, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::theLoanIsReturnedOnlyOnceAndOnlyBySampleItCameFrom, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aValueThatDoesNotExistIsNotLoaned, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::aLoanedPrimitiveIsWrittenBackOnReturn, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesDynamicDataTest.java::cloneIsAnEqualSampleThatSharesNoValue

Status: done — DynamicData ist eine Schnittstelle in org.omg.dds.type.dynamic; DynamicDataImpl setzt sie um, DynamicDataFactory.newDynamicData erzeugt sie. TypesDynamicDataTest prüft die Zugriffe für Int16, Int32, Int64, Float32, Float64, Char, Byte, Boolean und String (direkt und nach Kodieren/Dekodieren), die Hochstufung auf den größeren Zugriff, getDescriptors, getMemberIdByName, getMemberIdAtIndex, clearValue (nicht optional: Vorgabewert; optional: entfernt), clearAllValues, clearNonkeyValues (Schlüsselwerte bleiben), loanValue/returnLoanedValue (nach XTypes 1.3 §7.5.2.11.7: ohne Kopie, eine Leihe zugleich, null für fehlende Werte, PreconditionNotMetException bei fremder Rückgabe; Primitive unter MEMBER_ID_INVALID mit Rückschreiben) und clone. Die Zugriffe über Writer, Reader und Codec prüfen DynamicTopicTest. (Commit a25948e911c) ### §7.8.1.4 Ergebnis direkt statt über einen in-out-Parameter

Spec: §7.8.1.4, S. 28 — “Operations that provide their result as an in-out value in their first parameter and return DDS::ReturnCode_t have been changed such that they instead return their results directly.”

Status: done — Die Lesezugriffe von DynamicData geben den Wert zurück (getInt32Value als int, getStringValue als String, getComplexValue als DynamicData); die Feldformen füllen das übergebene Array und geben die Anzahl zurück. Die Tests lesen so Werte aus dem gelesenen Sample und vergleichen sie. Ein ReturnCode_t und ein in-out-Parameter für das Ergebnis kommen nicht vor. (Commit d2ca428c7b8) ### §7.8.1.4 equals und clone als Object.equals und Object.clone

Spec: §7.8.1.4, S. 28 — “The equals and clone operations on these types have been mapped to overrides of the Java-standard Object.equals and Object.clone, respectively.”

Status: done — DynamicDataImpl.clone() kopiert die Werte tief (verschachtelte DynamicData, Arrays, Listen und Maps); equals/hashCode vergleichen nach XTypes 1.3 §7.5.2.11.5 die Typen (gleich nach Wert) und die Werte ohne Rücksicht auf die Reihenfolge der Mitglieder; ein nicht optionales Mitglied, das ein Muster auslässt, ist gleich dem Vorgabewert im anderen; BigDecimal wird nach Wert verglichen (1.5 gleich 1.50). Getestet in TypesDynamicDataTest. (Commit a25948e911c) ### §7.8.1.4 Keine Methoden für vorzeichenlose Typen, Zugriff über gleich große oder nächstgrößere Typen

Spec: §7.8.1.4, S. 28 — “Methods dealing with unsigned integer types have been omitted. Applications may access unsigned data using the signed type of the same size (e.g., UInt32 becomes Int32), which preserves bitwise representation but not logical value, or by using the signed type one size up (e.g., UInt32 becomes Int64), which preserves logical value but not representation […]. In the case of UInt64, the “type one size up” is java.math.BigInteger.”

Status: done — DynamicData hat keine Methoden für vorzeichenlose Typen. DynamicDataTypeSupport hält UINT_16 als Short, UINT_32 als Integer, UINT_64 als Long (Bitmuster). Die Zugriffe richten sich nach der Art des Mitglieds: gleich große Zugriffe (getInt16Value, getInt32Value, getInt64Value) geben das Bitmuster, der nächstgrößere Zugriff den logischen Wert (UInt16 als int, UInt32 als long, UInt64 als getBigIntegerValue). Die Setzer nehmen bei gleicher Größe das Bitmuster, bei größerem Zugriff den logischen Wert mit Bereichsprüfung (IllegalArgumentException). getBigIntegerValues/setBigIntegerValues behandeln UINT_64-Folgen. TypesDynamicDataTest prüft dies und das Kodieren/Dekodieren von UINT_16, UINT_32 und UINT_64 (20 Oktette, 10 00 00 00 FF FF 00 00 FF FF FF FF FF…). Folgen von UINT_16 und UINT_32 sind über getInt32Values/getInt64Values nur als Bitmuster der gleichen Größe lesbar. (Commit a25948e911c) ### §7.8.1.4 Float128 als java.math.BigDecimal

Spec: §7.8.1.4, S. 28 — “The 128-bit Float128 type has been represented using java.math.BigDecimal.”

Status: done — DynamicData hat getBigDecimalValue/setBigDecimalValue und ...Values mit List<BigDecimal>; DynamicDataTypeSupport schreibt und liest FLOAT_128_TYPE über Float128.fromBigDecimal und toBigDecimal. TypesDynamicDataTest setzt ein FLOAT_128-Mitglied (1.5: Oktette 10 00 00 00 und 00…00 80 FF 3F Little-Endian; 2^100+1, das ein double nicht hält; 0; −0.25), kodiert, dekodiert und liest es zurück. Der Codegen bildet long double weiter auf org.zerodds.wire.Float128 ab (crates/lang-rules/src/adapter/java.rs), unabhängig von DynamicData. (Commit a25948e911c) ### §7.8.1.5 Deskriptoren unveränderlich, neue aus bestehenden

Spec: §7.8.1.5, S. 28 — “This specification defines three descriptor interfaces. The instances of descriptor interfaces are immutable and therefore, provide methods to create new descriptor objects from the existing ones.”

Status: done — Die with...-Methoden aller drei Deskriptoren kopieren und ändern die Kopie. TypeDescriptorImpl.getBound und MemberDescriptorImpl.getLabel geben nicht änderbare Listen zurück; AnnotationDescriptorImpl.getAllValue gibt eine Kopie. TypesDynamicTypeTest prüft je Deskriptor, dass with... das Original unverändert lässt, dass die Listen nicht änderbar sind und dass die Deskriptoren nach allen Eigenschaften gleich sind (equals/hashCode). (Commit a25948e911c) ### §7.8.1.5 AnnotationDescriptor

Spec: §7.8.1.5, S. 28 — “• AnnotationDescriptor”

Status: done — AnnotationDescriptor ist als Schnittstelle vorhanden, DynamicTypeFactory.newAnnotationDescriptor erzeugt sie. Die Tests bauen damit Key und Extensibility (withType, withValue) und prüfen deren Wirkung auf den Codec. (Commit 7d991374fd4) ### §7.8.1.5 MemberDescriptor

Spec: §7.8.1.5, S. 28 — “• MemberDescriptor”

Status: done — MemberDescriptor ist als Schnittstelle vorhanden, DynamicTypeFactory.newMemberDescriptor erzeugt sie. Die Tests setzen withName, withId, withType und withLabel und legen damit Mitglieder von Struktur und Union an, die der Codec kodiert und dekodiert. (Commit 7d991374fd4) ### §7.8.1.5 TypeDescriptor

Spec: §7.8.1.5, S. 28 — “• TypeDescriptor”

Status: done — TypeDescriptor ist als Schnittstelle vorhanden, DynamicTypeFactory.newTypeDescriptor erzeugt sie. aTypeDescriptorCarriesTheTypesItNames prüft getKind und getElementType nach einer Serialisierung; der Union-Test setzt withKind, withName und withDiscriminatorType. (Commit 7d991374fd4) ### §7.8.2 Vier eingebaute Typen von [DDS-XTypes]

Spec: §7.8.2, S. 29 — “[DDS-XTypes] specifies four built-in types: DDS::String, DDS::Bytes, DDS::KeyedString, and DDS::KeyedBytes.”

Repo: —

Tests: —

Status: n/a (informative) — Aufzählung der vier eingebauten Typen von [DDS-XTypes]; die Abbildungen stehen in den folgenden Items. ### §7.8.2 DDS::String als java.lang.String

Spec: §7.8.2, S. 29 — “• DDS::String is mapped to java.lang.String.”

Status: done — TypeSupportResolver.resolve(String.class) liefert BuiltinTypeSupports.StringTypeSupport: Typname DDS::String, APPENDABLE (XTypes 1.3 Annex E: struct _String { string value; }), unverändert für String als Feld einer Struktur. Ein Beispiel: "hi" ist 07 00 00 00 03 00 00 00 68 69 00 (DHEADER 7, Länge 3, Zeichen, NUL), in Big-Endian mit umgekehrten Wörtern; die Zeichenkette folgt der Einstellung des Item zu schmalen Zeichen (Kürzung als Vorgabe, UTF-8 als benannte Einstellung). TypesBuiltinTest prüft Typname, Oktette in beiden Byte-Reihenfolgen, die leere Zeichenkette, die Ablehnung abgeschnittener Daten und null, und schreibt und liest ein String-Muster über ein Topic. DomainParticipantOperationsTest::lookupTopicDescriptionFindsOnlyWhatWasCreated erwartet jetzt DDS::String statt java::lang::String. (Commit ec44921ff1d) ### §7.8.2 DDS::Bytes als byte[]

Spec: §7.8.2, S. 29 — “• DDS::Bytes is mapped to byte[].”

Status: done — TypeSupportResolver.resolve(byte[].class) liefert ByteArrayTypeSupport mit Typname DDS::Bytes und APPENDABLE-Rahmen (DHEADER, Länge, Oktette). typeNameIsDdsBytes und encodeFramesTheBytes prüfen Namen und Oktette (07 00 00 00 03 00 00 00 01 02 03); die beiden Quickstart-Tests schreiben und lesen 5 und 4096 Bytes über ein Topic<byte[]>. (Commit 5041698cee3) ### §7.8.2 byte[]-Topics als DDS::Bytes: Typname und Darstellung

Spec: §7.8.2, S. 29 — “[DDS-XTypes] specifies four built-in types: DDS::String, DDS::Bytes, DDS::KeyedString, and DDS::KeyedBytes. […] • DDS::Bytes is mapped to byte[].”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::typeNameIsDdsBytes, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::encodeFramesTheBytes, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::decodeUnframesTheBytes, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::bigEndianFramingFollowsTheChosenByteOrder, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ByteArrayTypeSupportTest.java::truncatedOrInconsistentFramingIsRefused

Status: done — getTypeName() gibt DDS::Bytes zurück, getExtensibility() APPENDABLE; encode schreibt DHEADER (Länge + 4), Folgenlänge und Oktette, decode prüft beides und wirft XcdrException bei Abweichung. Das entspricht XTypes 1.3 Annex E (@extensibility(APPENDABLE) struct Bytes { ByteSeq value; }). Die Tests prüfen Namen, Oktette in Little- und Big-Endian und die Ablehnung von abgeschnittenem oder inkonsistentem Rahmen. (Commit 5041698cee3) ### §7.8.2 DDS::KeyedString als änderbarer Werttyp

Spec: §7.8.2, S. 29 — “• DDS::KeyedString and DDS::KeyedBytes are mapped to modifiable value type interfaces.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedStringIsAModifiableValueType, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedStringCopyFromCloneAndEquals, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedStringSurvivesJavaSerialization, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::keyedStringIsTheBuiltInTypeDdsKeyedString, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::theKeyHashOfAKeyedStringIsTheMd5OfItsKeyInBigEndian, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aKeyedStringTopicHasOneInstancePerKey, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aKeyedStringTopicSampleIsANewValueObject, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesBuiltinTest.java::aTruncatedKeyedStringIsRefused

Status: done — KeyedString und KeyedStringImpl sind ein änderbarer Werttyp (setKey/setValue geben das Objekt zurück, copyFrom, clone, equals, hashCode, Java-Serialisierung ohne Environment). TypeSupportResolver.resolve liefert für KeyedString und jede Unterklasse BuiltinTypeSupports.KeyedStringTypeSupport: Typname DDS::KeyedString, APPENDABLE, key als Schlüssel. Beispiel: Schlüssel k, Wert vv sind 0F 00 00 00 02 00 00 00 6B 00 00 00 03 00 00 00 76 76 00 (die Länge des zweiten Strings ist auf 4 ausgerichtet). Der KeyHash ist der MD5 der Big-Endian-Serialisierung des Schlüssels (ein unbegrenzter String hat keine größte Größe ≤ 16 Oktette; XTypes 1.3 §7.6.8, DDSI-RTPS 2.5 §9.6.3.8): 302cf0a69dae0d4732bd21ea86fec48d für k. TypeSupportImpl.newData erzeugt das Muster über die SPI. Getestet in TypesBuiltinTest, einschließlich eines Writers und Readers mit einer Instanz je Schlüssel. (Commit ec44921ff1d) ### §7.8.2 DDS::KeyedBytes als änderbarer Werttyp

Spec: §7.8.2, S. 29 — “• DDS::KeyedString and DDS::KeyedBytes are mapped to modifiable value type interfaces.”

Status: done — KeyedBytes und KeyedBytesImpl sind ein änderbarer Werttyp (setValue(byte[]) und setValue(byte[], int, int) kopieren, getValue gibt eine Kopie, copyFrom, clone, equals, hashCode, Java-Serialisierung). TypeSupportResolver.resolve liefert für KeyedBytes BuiltinTypeSupports.KeyedBytesTypeSupport: Typname DDS::KeyedBytes, APPENDABLE, key als Schlüssel. Beispiel: Schlüssel k, Wert 01 02 03 sind 0F 00 00 00 02 00 00 00 6B 00 00 00 03 00 00 00 01 02 03. Der KeyHash ist der MD5 des Schlüssels wie bei KeyedString. Getestet in TypesBuiltinTest, einschließlich eines Writers und Readers mit einer Instanz je Schlüssel. (Commit ec44921ff1d) ### §7.8.2 DataReader und DataWriter für die eingebauten Typen

Spec: §7.8.2, S. 29 — “The generic DataReader and DataWriter interfaces are applicable to the built-in types.”

Status: done — Je ein DataWriter und DataReader auf einem Topic von byte[] (DDS::Bytes, ByteArrayTypeSupport), String (DDS::String), KeyedString und KeyedBytes schreiben und lesen Muster: byteArrayQuickstartRoundTrip und die Tests aStringTopicIsDdsStringAndMovesSamples, aKeyedStringTopicHasOneInstancePerKey, aKeyedBytesTopicHasOneInstancePerKey in TypesBuiltinTest. (Commit ec44921ff1d) ### §7.8.2 Generisches createDataReader und createDataWriter für die eingebauten Typen

Spec: §7.8.2, S. 29 — “Subscriber and Publisher provide generic createDataReader and createDataWriter methods to create datareader and datawriter for the built-in types, respectively.”

Status: done — Publisher.createDataWriter(Topic<TYPE>) und Subscriber.createDataReader(TopicDescription<TYPE>) sind generisch; der TypeSupport kommt aus dem Topic, das TypeSupportResolver.resolve für byte[], String, KeyedString und KeyedBytes mit dem eingebauten TypeSupport füllt. Die Tests benutzen die Überladungen mit nur dem Topic (byteArrayQuickstartRoundTrip, TypesBuiltinTest). (Commit ec44921ff1d) ### §7.8.3 Typen von TypeObject als Werttypen nach den Regeln dieses Dokuments

Spec: §7.8.3, S. 29 — “The types in this package are expressed as modifiable value types according to the mapping rules expressed elsewhere in this document.”

Status: done — Die Schnittstellen in org.omg.dds.type.typeobject der OMG-Quelle haben nur Lese-Methoden (die Javadoc von TypeObject und Member nennt die Objekte unveränderlich); die Quelle gilt nach §2, und org/omg/dds bleibt gleich ihr. Die Objekte, die TypeObjectModel liefert, sind Werttypen nach §7.3.3: Serializable, mit equals und hashCode nach dem Zustand (TypeObjectModelTest::equalStateIsEqualObjects); verändert wird ein TypeObject über die veränderlichen Datenklassen des Codecs (ZdTypes.DDS.*: öffentliche Felder, TypeObjectCodec.encode/decode) und TypeObjectModel.of. Die Änderungen der Abbildung aus §7.8.3 (Konstanten in Schnittstellen, MemberId-Klassen) sind getestet (TypesTypeObjectConstantsTest). (Commit b4bf3fa978e) ### §7.8.3 Konstanten der obersten Ebene in Schnittstellen, z. B. Member.MEMBER_ID_INVALID

Spec: §7.8.3, S. 29 — “• Top-level constants are moved into related interfaces, for example: Member.MEMBER_ID_INVALID.”

Repo: crates/java-omgdds/java/src/main/java/org/omg/dds/type/typeobject/Member.java (Member.MEMBER_ID_INVALID)

Status: done — Member.MEMBER_ID_INVALID ist als int-Konstante 0x0FFFFFFF in der Schnittstelle Member deklariert; der Wert ist der größte Wert des 28-Bit-Bereichs der Member-IDs (XTypes 1.3 §7.2.2.4.4.4.4) und gleich MEMBER_ID_INVALID in crates/types/src/dynamic/descriptor.rs. Weitere Konstanten in Schnittstellen: CollectionType.UNBOUNDED_COLLECTION (0) und die Typ-IDs in TypeId (gleich den TypeKind.Values). TypesTypeObjectConstantsTest liest sie. (Commit ffbb2d554ca) ### §7.8.3 Member-IDs als verschachtelte finale Klassen mit int-Konstanten

Spec: §7.8.3, S. 29 — “Enumerations of member ID values are nested final classes within the interfaces for which they provide the member’s IDs. These classes have constant integer fields, for example: MapType.MemberId.BOUND_MAPTYPE_MEMBER_ID.”

Status: done — Die Schnittstellen in org.omg.dds.type.typeobject tragen je eine verschachtelte finale Klasse MemberId mit privatem Konstruktor und int-Konstanten, z. B. MapType.MemberId.BOUND_MAPTYPE_MEMBER_ID = 201. TypesTypeObjectConstantsTest prüft für 15 Schnittstellen Namen und Werte der Konstanten gegen die OMG-Quelle, dass die Klasse final, öffentlich und statisch ist, keinen öffentlichen Konstruktor hat, und dass die Werte genau die @ID-Werte der Getter derselben Schnittstelle sind. TypeObjectTest::theMemberIdsAreThoseOfAnnexBOfXTypes11 vergleicht die Werte mit den Aufzählungen von DDS-XTypes 1.1 Anhang B (TypeMemberId 0, 1; StructureTypeMemberId 100, 101; MapTypeMemberId 200, 201; …), die jetzt im Spec-Cache liegen; die Werte stimmen. Die Quelle hat in CollectionType.MemberId nur ELEMENT_TYPE_COLLECTIONTYPE_MEMBER_ID; die Konstante ELEMENT_SHARED_COLLECTIONTYPE_MEMBER_ID (101) des Anhangs fehlt dort, und org/omg/dds bleibt gleich der Quelle. (Commit b4bf3fa978e)

§8.1 General

§8.1 Java-Objekte ohne Codegenerierung und ohne Dynamic Language Binding veröffentlichen

Spec: §8.1, S. 31 — “The Java Type Representation defined in this clause provides a means for Java developers to publish and subscribe to DDS topics typed by plain Java objects without resorting to code generation or the reflective style of the Dynamic Language Binding.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::singleArgFactoryReflectsTypedBean, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::pointMatchesV2, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — TypeSupportResolver.resolve fällt für eine Klasse ohne erzeugten TypeSupport auf ReflectionTypeSupport zurück. singleArgFactoryReflectsTypedBean schreibt und liest ein Bean mit int- und String-Feld über createDataWriter(Topic)/createDataReader(Topic) ohne IDL und ohne Dynamic Language Binding; pointMatchesV2 und mixedIsByteIdenticalToTypedPath prüfen die Oktette gegen den erzeugten Pfad. (Commit 819bfcb46cb) ### §8.1 Zugleich ein Language Binding, für die Laufzeit gedacht

Spec: §8.1, S. 31 — “By its very nature as an expression of the Java programming language, this Type Representation implicitly and simultaneously defines a Language Binding for DDS types. […] Therefore, this Type Representation is intended for the run-time use of implementations of this PSM. While this specification does not preclude Service implementations from using this Type Representation for other purposes […] such uses are non-normative and unspecified.”

Repo: —

Tests: —

Status: n/a (informative) — Einordnung der Typdarstellung als Language Binding für die Laufzeit; die Spec verlangt hier nichts Prüfbares. ### §8.1 Jeder Serializable-Typ lässt sich veröffentlichen

Spec: §8.1, S. 31 — “Any Java type that implements Serializable (directly or indirectly) shall be available for publishing and/or subscribing over DDS as defined below.”

Status: done — ReflectionTypeSupport nimmt jede Klasse an und prüft Serializable nicht; serialVersionUID ist statisch und kein Mitglied. Eine Serializable-Klasse der Anwendung wird veröffentlicht (aSerializableClassOfTheApplicationIsATopicType: Oktette 04 00 00 00 03 00 00 00 61 62 00), mit den Regeln der Java Type Representation einschließlich der Einschränkung von java.io.Serializable für Oberklassen. Die Serializable-Klassen des JDK ohne Eintrag in Table 8.1 sind veröffentlichbar, als Typ eines Topics, eines Felds, eines Folgenelements oder einer Array-Komponente: java.util.Date (int64 Millisekunden), UUID (zwei int64), URI, Locale und Currency (je ein String) und java.time.Instant, Duration, Period, LocalDate, LocalTime, LocalDateTime, OffsetDateTime, ZonedDateTime, ZoneOffset, Year, YearMonth, MonthDay als Struktur aus Typen der Table 8.1 (JdkValueTypes, die Felder in der Javadoc der Klasse); jede andere konkrete Serializable-Klasse des JDK (etwa java.util.BitSet) als ihre Java-Serialisierung, eine sequence<octet> (JdkSerializedValues; nur Java-Programme lesen sie). Beim Lesen entsteht nie eine andere Klasse: der Strom darf nur die deklarierte Klasse und Klassen aus java.lang nennen und höchstens 1 MiB lang sein, sonst XcdrException (theOctetsOfAJdkValueNeverMakeAnotherClass); ein Wert, den die Klasse ablehnt (Monat 13), ebenso. Eine Klasse des JDK, die nicht Serializable oder nicht konkret ist, wird beim Anlegen des Typs mit einer XcdrException abgelehnt, die Klasse, Feld, Table 8.1 und einen Ausweg nennt. Ein DynamicType (createType) und ein TypeObject kennen diese JDK-Klassen nicht; ein Typ mit einem solchen Feld kündigt kein TypeObject an. (Commit bf27136ca70) ### §8.1 DDS-Serialisierung nicht gleich der Serialisierung der JRE

Spec: §8.1, S. 31 — “Note that the DDS serialization of a type will not generally be the same as the JRE serialization of the same type, even if the type designer’s specification of which data to serialize can be shared between these two mechanisms.”

Repo: —

Tests: —

Status: n/a (informative) — Hinweis, dass die DDS-Serialisierung von der JRE-Serialisierung abweicht. ReflectionTypeSupport schreibt XCDR2 über org.zerodds.wire.Writer und beachtet writeObject, readObject und serialPersistentFields nicht.

§8.2 Default Mappings

§8.2 Table 8.1: `int`, `java.lang.Integer` → INT32

Spec: §8.2, S. 31, Table 8.1 — “INT, JAVA.LANG.INTEGER | INT32”

Status: done — int wird INT32 (Mixed.i gegen den Writer-Pfad im ersten Test, Oktette 01 00 00 00 … in pointMatchesV2); Integer als Element von List<Integer> im zweiten Test. Ein Feld des Hüllklassen-Typs mit null ohne @Optional wirft XcdrException (ReflectionTypeSupport.encodeMember); die Hüllklasse selbst hat keinen eigenen Test (aus dem Code gelesen, nicht gemessen). (Commit 819bfcb46cb) ### §8.2 Table 8.1: short, java.lang.Short → INT16

Spec: §8.2, S. 31, Table 8.1 — “SHORT, JAVA.LANG.SHORT | INT16”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — mixedIsByteIdenticalToTypedPath prüft short als INT16 gegen den Writer-Pfad; Short geht denselben Zweig in encodeValue/decodeValue und hat keinen eigenen Test. (Commit 819bfcb46cb) ### §8.2 Table 8.1: long, java.lang.Long → INT64

Spec: §8.2, S. 31, Table 8.1 — “LONG, JAVA.LANG.LONG | INT64”

Status: done — Beide Tests prüfen long als INT64 (Oktette gegen den Writer-Pfad, Rundlauf mit negativem Wert in einem MUTABLE-Typ); Long geht denselben Zweig und hat keinen eigenen Test. (Commit 819bfcb46cb) ### §8.2 Table 8.1: float, java.lang.Float → FLOAT32

Spec: §8.2, S. 31, Table 8.1 — “FLOAT, JAVA.LANG.FLOAT | FLOAT32”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — mixedIsByteIdenticalToTypedPath prüft float (2.5f) als FLOAT32 gegen den Writer-Pfad; Float geht denselben Zweig und hat keinen eigenen Test. (Commit 819bfcb46cb) ### §8.2 Table 8.1: double, java.lang.Double → FLOAT64

Spec: §8.2, S. 31, Table 8.1 — “DOUBLE, JAVA.LANG.DOUBLE | FLOAT64”

Status: done — Beide Tests prüfen double als FLOAT64; sensorMatchesV8 vergleicht die Oktette 1F 85 EB 51 B8 1E 09 40 für 3,14. Double geht denselben Zweig und hat keinen eigenen Test. (Commit 819bfcb46cb) ### §8.2 Table 8.1: char, java.lang.Character → CHAR8

Spec: §8.2, S. 31, Table 8.1 — “CHAR, JAVA.LANG.CHARACTER | CHAR8”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — mixedIsByteIdenticalToTypedPath prüft 'Z' als CHAR8 gegen den Writer-Pfad. Character geht denselben Zweig. Ein Zeichen über U+00FF wirft WireException.OutOfRange (Writer.writeChar; ohne @SerializeAs wird die Ausnahme nicht in XcdrException umgewandelt) (aus dem Code gelesen, nicht gemessen). (Commit 819bfcb46cb) ### §8.2 Table 8.1: byte, java.lang.Byte → BYTE

Spec: §8.2, S. 31, Table 8.1 — “BYTE, JAVA.LANG.BYTE | BYTE”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — mixedIsByteIdenticalToTypedPath prüft (byte) 0xAB als BYTE; Byte geht denselben Zweig und hat keinen eigenen Test. (Commit 819bfcb46cb) ### §8.2 Table 8.1: boolean, java.lang.Boolean → BOOLEAN

Spec: §8.2, S. 31, Table 8.1 — “BOOLEAN, JAVA.LANG.BOOLEAN | BOOLEAN”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — mixedIsByteIdenticalToTypedPath prüft true als BOOLEAN; Boolean geht denselben Zweig und hat keinen eigenen Test. (Commit 819bfcb46cb) ### §8.2 Table 8.1: java.lang.String → STRING

Spec: §8.2, S. 31, Table 8.1 — “JAVA.LANG.STRING | STRING”

Status: done — stringMatchesV4 prüft die Oktette von "hello" (06 00 00 00 68 65 6C 6C 6F 00), aNarrowStringIsTruncatedToItsLowOctetByDefault die von "été" und "AŁ" (je Zeichen ein Oktett, Länge einschließlich Terminator). Die Vorgabe für Zeichen über U+007F ist die Kürzung nach §8.5.1, UTF-8 die benannte Einstellung zerodds.java.narrow-string=utf8; siehe das Item „§8.5.1 Schmale Zeichen: jedes Java-Zeichen auf das niederwertige Byte gekürzt“. (Commit 819bfcb46cb) ### §8.2 Table 8.1: java.util.Map → map

Spec: §8.2, S. 31, Table 8.1 — “java.util.Map | map”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mapRoundtrips, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aMapIsADheaderACountAndTheEntries, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aMapIsReadIntoTheMapClassTheFieldDeclares

Status: done — mapRoundtrips: Map<String, Integer> geht hin und zurück, die Reihenfolge bleibt erhalten. aMapIsADheaderACountAndTheEntries prüft die Oktette (DHEADER, Anzahl, Schlüssel/Wert-Paare: 10 00 00 00 01 00 00 00 02 00 00 00 61 00 00 00 01 00 00 00). Das Feld muss mit Typargumenten deklariert sein, sonst wirft elementClass eine XcdrException. (Commit 4aa407a112d) ### §8.2 Table 8.1: java.lang.Collection und Array → sequence

Spec: §8.2, S. 31, Table 8.1 — “java.lang.Collection, array | sequence”

Status: done — List, Set, Queue, Deque, SortedSet, NavigableSet, EnumSet und Arrays werden Folgen; die Tests prüfen Oktette (V-5, V-6) und Rundläufe. Beim Lesen baut ReflectionTypeSupport.collection die Klasse des Feldes: für eine Schnittstelle oder abstrakte Klasse die erste von ArrayList, LinkedHashSet, TreeSet, ArrayDeque, LinkedBlockingDeque, die sie ist (Collection/List ArrayList, Set LinkedHashSet, SortedSet/NavigableSet TreeSet, Queue/Deque ArrayDeque); EnumSet über die Elementklasse; eine konkrete Klasse über ihren Konstruktor ohne Argumente. Ein Feldtyp, den keine Standardklasse füllt, ist eine XcdrException, keine andere Sammlung. TypesJavaRepresentationTest::aSequenceIsReadIntoTheCollectionTheFieldDeclares prüft Klasse und Reihenfolge für zehn Feldtypen. (Commit f0649c27acc) ### §8.2 Table 8.1: java.lang.Object → Structure

Spec: §8.2, S. 31, Table 8.1 — “java.lang.Object | Structure”

Status: done — Eine Klasse wird eine Struktur, verschachtelte Klassen werden verschachtelte Strukturen; pointMatchesV2 und nestedFinalInline prüfen die Oktette (FINAL ohne DHEADER, 16 Bytes für zwei Point). (Commit 819bfcb46cb) ### §8.2 @SerializeAs ändert die Vorgaben je Typ und je Feld, value() vom Typ TypeKind

Spec: §8.2, S. 32 — “A type designer may modify these defaults on a type-by-type and/or field-by-field basis by applying the annotation org.omg.dds.type.SerializeAs: public @interface SerializeAs { public TypeKind value(); … }”

Status: done — org.omg.dds.type.SerializeAs hat TypeKind value() (dazu collectionElementKind, mapKeyElementKind, bound). An einem Feld ändert sie die Vorgabe (JavaRepresentation.ofField; die Tests prüfen UInt32, eine nach Table 8.2 unzulässige Kombination und eine breite Zeichenkette); an einer Klasse gilt STRUCTURE_TYPE oder UNION_TYPE (introspectUnion; aUnionIsItsDiscriminatorAndTheSelectedMember prüft die Oktette), andere Arten an einer Klasse lehnt introspectUnion mit XcdrException ab (aKindOtherThanStructureOrUnionOnAClassIsRefused). Die Annotation an Methoden bleibt ohne Wirkung. (Commit 4aa407a112d)

§8.3 Metadata

§8.3 Metadaten der IDL als gleichwertige Java-Annotationen

Spec: §8.3, S. 32 — “The type system metadata represented with built-in annotations in the IDL Type Representation (such as @Key, @ID) shall be represented by equivalent Java annotations unless otherwise noted.”

Status: done — @Key (sensorMatchesV8, theTypeSystemAnnotationsAreRead) und @Extensibility (anAnnotationOverridesTheDefault) aus org.omg.dds.type werden gelesen, fremde Annotationen gleichen Namens nicht. ReflectionTypeSupport.annotation vergleicht den einfachen Namen ohne Beachtung der Groß-/Kleinschreibung, so dass org.omg.dds.type.ID als Id gilt. theIdOfAMemberIsItsIdOnTheWireAndAnAbsentOptionalMemberHasNone prüft an einer MUTABLE-Klasse mit @ID(5), @Optional @ID(9) und @MustUnderstand @ID(12) die Oktette: DHEADER, je EMHEADER 0x40000005, 0x40000009 und 0xC000000C (M-Flag bei @MustUnderstand) mit NEXTINT, kein EMHEADER für ein fehlendes optionales Mitglied; theAnnotationsAreMembersOfTheDynamicTypeToo die Annotationen in createType. @Shared, @Nested, @Verbatim und @Value haben keine Wirkung auf die Wire-Form. (Commit f0649c27acc) ### §8.3 Annotationen im Paket org.omg.dds.type

Spec: §8.3, S. 32 — “These annotations are in the package org.omg.dds.type.”

Status: done — Das Paket org.omg.dds.type enthält Key, ID, Optional, MustUnderstand, Extensibility, Shared, Nested, Verbatim, Value, BitBound, BitSet, SerializeAs, UnionDiscriminator, UnionMember. Die Tests importieren und benutzen Key, ID, Extensibility und SerializeAs aus diesem Paket (Namensforderung). ReflectionTypeSupport.annotation liest sie aus org.omg.dds.type und aus org.zerodds.types. (Commit 5041698cee3) ### §8.3 Annotationen an Klassen und Feldern, an Schnittstellen und Methoden ohne festgelegtes Verhalten

Spec: §8.3, S. 32 — “The annotations in this package logically govern the behavior of concrete classes, not of polymorphic interfaces. As such, they may be applied to classes or to their fields, as appropriate. Interface designers wishing to document the DDS serialization of a type may additionally apply them to interfaces or to property accessor and/or mutator methods; however, they have no specified behavior in such cases.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.introspect)

Status: done — introspect liest Annotationen der Klasse (@Extensibility, anAnnotationOverridesTheDefault) und ihrer Felder (@Key, sensorMatchesV8). Annotationen an Methoden werden nicht ausgewertet, wie die Spec es für diesen Fall offen lässt („no specified behavior“). (Commit 819bfcb46cb)

§8.4 Primitive Types

§8.4 Vorgaben nach Table 8.2, Änderung über `@SerializeAs`

Spec: §8.4, S. 32 — “By default, Java primitive types are mapped to DDS primitive types as defined in Table 8.2. The @SerializeAs annotation may be used to modify these mappings as follows.”

Status: done — Die Vorgaben von Table 8.2 gelten ohne Annotation (mixedIsByteIdenticalToTypedPath). @SerializeAs ändert sie je Feld (uint32HeldInALongKeepsTheLogicalValue), und JavaRepresentation.check lehnt Kombinationen ab, die Table 8.2 nicht aufführt (aKindTable82DoesNotListForTheTypeIsRefused). (Commit 874bc5ac9fe) ### §8.4 Table 8.2: Int32 aus int, Integer

Spec: §8.4, S. 32, Table 8.2 — “Int32 | int, java.lang.Integer”

Status: done — int und Integer sind die Vorgabe für Int32 (mixedIsByteIdenticalToTypedPath für int, Integer als Listenelement in seqPrimitiveMatchesV5); @SerializeAs(INT_32_TYPE) an einem long wird abgelehnt (aKindTable82DoesNotListForTheTypeIsRefused). (Commit 874bc5ac9fe) ### §8.4 Table 8.2: UInt32 aus int, long, Integer, Long

Spec: §8.4, S. 32, Table 8.2 — “UInt32 | int, long, java.lang.Integer, java.lang.Long”

Status: done — @SerializeAs(UINT_32_TYPE) an long behält den logischen Wert (4 000 000 000 wird 00 28 6B EE, 2^32 und −1 sind XcdrException); an int bleibt das Bitmuster (−1 wird FF FF FF FF). Integer und Long erlaubt check, ohne eigenen Test. (Commit 874bc5ac9fe) ### §8.4 Table 8.2: Int16 aus short, Short

Spec: §8.4, S. 32, Table 8.2 — “Int16 | short, java.lang.Short”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — Vorgabe; mixedIsByteIdenticalToTypedPath prüft short als Int16 gegen den Writer-Pfad. (Commit 819bfcb46cb) ### §8.4 Table 8.2: UInt16 aus short, int, Short, Integer

Spec: §8.4, S. 32, Table 8.2 — “UInt16 | short, int, java.lang.Short, java.lang.Integer”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint16IntKeepsTheValueAndShortTheBitPattern

Status: done — @SerializeAs(UINT_16_TYPE): an int bleibt der Wert (65535 wird FF FF, 65536 ist XcdrException), an short das Bitmuster (−2 wird FE FF). Der Test prüft die Oktette und den Rundlauf; Short und Integer erlaubt check, ohne eigenen Test. (Commit 874bc5ac9fe) ### §8.4 Table 8.2: Int64 aus long, Long

Spec: §8.4, S. 32, Table 8.2 — “Int64 | long, java.lang.Long”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Status: done — Vorgabe; mutableLongRoundtrips und mixedIsByteIdenticalToTypedPath prüfen long als Int64. (Commit 819bfcb46cb) ### §8.4 Table 8.2: UInt64 aus long, Long, BigInteger

Spec: §8.4, S. 32, Table 8.2 — “UInt64 | long, java.lang.Long, java.math.BigInteger”

Status: done — @SerializeAs(UINT_64_TYPE) nimmt BigInteger (2^64−1 wird acht FF, 2^64 ist XcdrException) oder long (Bitmuster); ohne Annotation ist BigInteger UInt64. Im Vorgabezweig ReflectionTypeSupport.encodeValue wird ein BigInteger außerhalb 0 bis 2^64−1 mit XcdrException abgelehnt und nicht über longValue() gekürzt. aBigIntegerWithoutAnnotationIsUInt64AndIsRangeChecked prüft 2^64−1 (acht FF), 0, 2^63 (00…80), −1, 2^64 und 2^100. (Commit f0649c27acc) ### §8.4 Table 8.2: Float32 aus float, Float

Spec: §8.4, S. 32, Table 8.2 — “Float32 | float, java.lang.Float”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — Vorgabe; mixedIsByteIdenticalToTypedPath prüft float als Float32 gegen den Writer-Pfad. (Commit 819bfcb46cb) ### §8.4 Table 8.2: Float64 aus double, Double

Spec: §8.4, S. 32, Table 8.2 — “Float64 | double, java.lang.Double”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Status: done — Vorgabe; sensorMatchesV8 und mixedIsByteIdenticalToTypedPath prüfen double als Float64. (Commit 819bfcb46cb) ### §8.4 Table 8.2: Float128 aus double, Double, BigDecimal

Spec: §8.4, S. 32, Table 8.2 — “Float128 | double, java.lang.Double, java.math.BigDecimal”

Status: done — @SerializeAs(FLOAT_128_TYPE) an double: float128HeldInADouble prüft die 16 Oktette für 1,0 (Exponent 3FFF) und den Rundlauf. BigDecimal ist ohne Annotation Float128; theKindsOfTable81RoundTrip prüft den Rundlauf von 1,25 (Zahlenwert, nicht Skala), keine Oktette. Double erlaubt check, ohne eigenen Test. (Commit 874bc5ac9fe) ### §8.4 Table 8.2: Byte aus byte, Byte

Spec: §8.4, S. 32, Table 8.2 — “Byte | byte, java.lang.Byte”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — Vorgabe; mixedIsByteIdenticalToTypedPath prüft byte als Byte. (Commit 819bfcb46cb) ### §8.4 Table 8.2: Boolean aus boolean, Boolean

Spec: §8.4, S. 32, Table 8.2 — “Boolean | boolean, java.lang.Boolean”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — Vorgabe; mixedIsByteIdenticalToTypedPath prüft boolean als Boolean. (Commit 819bfcb46cb) ### §8.4 Table 8.2: Char8 aus char, Character

Spec: §8.4, S. 32, Table 8.2 — “Char8 | char, java.lang.Character”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath

Status: done — Vorgabe; mixedIsByteIdenticalToTypedPath prüft char als Char8. (Commit 819bfcb46cb) ### §8.4 Table 8.2: Char32 aus char, int, Character, Integer

Spec: §8.4, S. 32, Table 8.2 — “Char32 | char, int, java.lang.Character, java.lang.Integer”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.encodeKind)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::char32IsAFourOctetCodePoint

Status: done — @SerializeAs(CHAR_32_TYPE) an int: Codepunkt U+1F600 wird 00 F6 01 00, Rundlauf. char, Character und Integer erlaubt check, ohne eigenen Test; ein Wert über U+10FFFF ist XcdrException. (Commit 874bc5ac9fe) ### §8.4 Vorzeichenlose Werte: Darstellung oder logischer Wert erhalten

Spec: §8.4, S. 33 — “The DDS Type System ([DDS-XTypes]) defines unsigned integer types; the Java type system does not. As a result, this Type Representation must map unsigned values to “equivalent” signed types. Type designers have two choices, reflected in the table above: • Preserve representation […] • Preserve logical value […]”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/JavaRepresentation.java (JavaRepresentation.encodeKind)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint32HeldInALongKeepsTheLogicalValue, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint32HeldInAnIntKeepsTheBitPattern, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint16IntKeepsTheValueAndShortTheBitPattern, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::uint64TakesABigIntegerOrALong

Status: done — Beide Wahlmöglichkeiten sind umgesetzt und geprüft: gleich große Java-Typen behalten das Bitmuster (int für UInt32, short für UInt16, long für UInt64), größere Java-Typen den logischen Wert (long, int, BigInteger), mit XcdrException außerhalb des Bereichs. (Commit 874bc5ac9fe)

§8.5 Collections

§8.5 Drei Arten von Sammlungen

Spec: §8.5, S. 33 — “[DDS-XTypes] recognizes three categories of collections: strings (variable-length lists of narrow or wide characters), sequences (variable-length lists of any single element type), and maps (homogeneously typed key-value mappings).”

Repo: —

Tests: —

Status: n/a (informative) — Einordnung der drei Sammlungsarten von XTypes; die Spec verlangt hier nichts Prüfbares. ### §8.5.1 DDS-Strings als Java-String

Spec: §8.5.1, S. 33 — “DDS strings, whether of narrow or wide characters, are represented by Java String objects.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::stringMatchesV4, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::seqStringMatchesV6, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/SerializeAsTest.java::aWideStringIsMarkedWithSerializeAs

Status: done — Ein Feld String wird eine schmale Zeichenkette und zurück (stringMatchesV4, seqStringMatchesV6); mit @SerializeAs(STRING_TYPE, collectionElementKind = CHAR_32_TYPE) eine breite (aWideStringIsMarkedWithSerializeAs: 06 00 00 00 E9 00 74 00 E9 00). (Commit 819bfcb46cb) ### §8.5.1 Schmale Zeichen: jedes Java-Zeichen auf das niederwertige Byte gekürzt

Spec: §8.5.1, S. 33 — “• If a string is to be of narrow characters (the default), each Java character shall be truncated to its least-significant byte.”

Status: done — Die Vorgabe ist die Form der Klausel: jedes Zeichen auf das niederwertige Byte gekürzt (aNarrowStringIsTruncatedToItsLowOctetByDefault: "AŁ" wird 41 41, "été" wird E9 74 E9), gelesen kommt ein Zeichen je Oktett zurück. Die Systemeigenschaft zerodds.java.narrow-string=utf8 wählt die UTF-8-Form von XTypes 1.3 (§7.2.2.2.1.2.4, §7.4.1.1.2; theUtf8SettingWritesTheFormOfXTypes13: "é" wird C3 A9, wie im Interop-Korpus); beim Lesen werden ein fehlendes NUL und ungültiges UTF-8 abgelehnt. bothFormsOfANarrowStringAreWrittenByTheSameTypeSupport schreibt dieselbe Instanz von ReflectionTypeSupport nacheinander in beiden Formen (E9 und C3 A9). Beide Formen sind für Zeichen bis U+007F gleich. Peers, die die Strings als UTF-8 lesen (Cyclone DDS, Fast DDS, OpenDDS), brauchen die Einstellung utf8, sobald ein Zeichen über U+007F vorkommt; dasselbe gilt für die eingebauten Typen DDS::String und DDS::KeyedString. Die Einstellung gilt je Java-Prozess. (Commit b1e7b4d0338) ### §8.5.1 Breite Zeichen mit @SerializeAs, je Code Point ein DDS-Zeichen

Spec: §8.5.1, S. 33 — “• If a string is to be of wide characters (in which case it must be so marked with @SerializeAs), each Java code point shall become a single DDS wide character.”

Status: done — Ein String mit @SerializeAs(STRING_TYPE, collectionElementKind = CHAR_32_TYPE) ist ein String aus 32-Bit-Zeichen, ein Zeichen je Code Point (WideStrings): die Länge in Oktetten (4n), dann n vorzeichenlose 32-Bit-Werte ohne Abschlusszeichen (aWideStringIsMarkedWithSerializeAs: "été" ist 0C 00 00 00 E9 00 00 00 74 00 00 00 E9 00 00 00). aCodePointAboveU10000OfAWideStringIsOneCharacter prüft "a𝄞" (U+1D11E, zwei char): 08 00 00 00 61 00 00 00 1E D1 01 00; ein Code Point über U+FFFF ist ein Zeichen und kein Surrogatpaar. Ein Wert, der kein Code Point ist, wird beim Lesen abgelehnt. Die Systemeigenschaft zerodds.java.wide-string=utf16 wählt den wstring von XTypes 1.3 §7.4.1.1.2, eine Folge von UTF-16-Einheiten, in der ein solcher Code Point zwei Einheiten ist (theUtf16SettingWritesTheWstringOfXTypes13: 06 00 00 00 61 00 34 D8 1E DD; Interop-Korpus string-adjacent-widths); Gegenstellen, die einen wstring lesen, brauchen diese Einstellung. Ohne die Annotation ist der String schmal (siehe das Item davor). (Commit b1e7b4d0338) ### §8.5.2 Jede java.util.Map als DDS-Map, außer mit @SerializeAs

Spec: §8.5.2, S. 33 — “Any object whose class implements the interface java.util.Map shall be considered a DDS map unless marked otherwise with @SerializeAs.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mapRoundtrips, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::enumerationsStructuresCollectionsAndMapsFollowTable81, crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::nestedGenericsAreFollowed, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aMapIsReadIntoTheMapClassTheFieldDeclares, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aMapMarkedAsAMapKeepsItsBound, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aMapIsADheaderACountAndTheEntries

Status: done — Ein Feld, dessen deklarierter Typ Map implementiert, wird eine DDS-Map (ReflectionTypeSupport.encodeValue); JavaRepresentation.check lässt für MAP_TYPE nur Map zu und verweigert jede andere Art auf einer Map mit XcdrException. Beim Lesen baut ReflectionTypeSupport.map (auch für JavaRepresentation.decodeMap) die deklarierte Klasse: Map ein LinkedHashMap, SortedMap/NavigableMap ein TreeMap, ConcurrentMap ein ConcurrentHashMap, EnumMap über die Schlüsselklasse, eine konkrete Klasse über ihren Konstruktor. aMapIsReadIntoTheMapClassTheFieldDeclares prüft sieben Feldtypen, darunter ein Feld mit @SerializeAs(MAP_TYPE); aMapMarkedAsAMapKeepsItsBound die Grenze. (Commit f0649c27acc) ### §8.5.3 Jede java.util.Collection als DDS-Folge

Spec: §8.5.3, S. 33 — “Any object whose class implements the interface java.util.Collection shall be considered DDS sequences unless marked otherwise with @SerializeAs.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.decodeValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.collection), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.typeOfClass)

Status: done — Jede Collection wird eine Folge (encodeValue, Zweig Collection.class.isAssignableFrom); beim Lesen baut ReflectionTypeSupport.collection die deklarierte Klasse (siehe das Item zu Table 8.1 Collection): ArrayList, LinkedHashSet, TreeSet, ArrayDeque, EnumSet, oder die konkrete Klasse. aSequenceIsReadIntoTheCollectionTheFieldDeclares prüft je ein Feld von Queue, Deque, SortedSet, NavigableSet, TreeSet, EnumSet, LinkedList, Collection, Set und List. createType liefert für Collection<String> SEQUENCE_TYPE. (Commit f0649c27acc) ### §8.5.3 Bei List die Reihenfolge der Liste

Spec: §8.5.3, S. 33 — “If the class implements java.util.List, the order of the elements in the sequence shall correspond exactly to the order of the elements in the list.”

Status: done — asList übernimmt die Elemente einer List in ihrer Reihenfolge, encodeSequence schreibt sie so. seqPrimitiveMatchesV5 vergleicht die Bytes für [1,2,3], seqStringMatchesV6 für [“a”,“bc”], beide prüfen auch die gelesene Liste. (Commit 819bfcb46cb) ### §8.5.3 Sonst die Reihenfolge des Iterators

Spec: §8.5.3, S. 33 — “Otherwise, the order of the elements in the sequence shall correspond to that returned by the collection’s iterator.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aSetIsWrittenInTheOrderOfItsIterator

Status: done — asList kopiert eine Collection mit new ArrayList<>(collection), also in der Reihenfolge ihres Iterators. aSetIsWrittenInTheOrderOfItsIterator schreibt ein LinkedHashSet (“b”, “a”) und ein TreeSet mit denselben Elementen und vergleicht alle 46 Oktette: das erste Set schreibt b vor a, das zweite a vor b. (Commit f0649c27acc) ### §8.5.3 Arrays als DDS-Folgen

Spec: §8.5.3, S. 33 — “Objects of array types shall be considered DDS sequences unless marked otherwise with @SerializeAs.”

Status: done — Ein Array-Typ geht in encodeValue über encodeSequence (Länge, Elemente) und kommt über listToArray als Array zurück. arrayRoundtrips schreibt und liest ein int[]; anArrayOfPrimitivesIsASequenceWithoutAnElementDheader prüft die Oktette von {1, 2} (02 00 00 00 01 00 00 00 02 00 00 00); createType liefert für double[] SEQUENCE_TYPE mit FLOAT_64_TYPE als Element. (Commit 4aa407a112d) ### §8.5.3 Collection oder Array als DDS-Array mit @SerializeAs

Spec: §8.5.3, S. 33 — “Any Java collection or array may be designated as a DDS array with @SerializeAs.”

Status: done — @SerializeAs(ARRAY_TYPE, bound = ...) auf einem Java-Array ist getestet: int[3] und int[2][3] werden ohne Länge zeilenweise geschrieben, eine falsche Elementzahl wird mit XcdrException abgelehnt, createType liefert ARRAY_TYPE mit den Grenzen. Auf einer Collection prüft aCollectionMarkedAsAnArrayHasAFixedLengthAndNoLengthWord eine List<Integer> mit bound = {3}: Oktette 01 00 00 00 02 00 00 00 03 00 00 00 ohne Länge, eine Liste mit zwei oder vier Elementen wird abgelehnt, gelesen wird eine ArrayList. (Commit 4aa407a112d) ### §8.5.3 Begründung: Arrays sind Verweise

Spec: §8.5.3, S. 33 — “Design Rationale (non-normative) Objects of array types must receive special care, because a Java array—like any Java object—is stored by reference only. […]”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ.

§8.6 Aggregated Types

§8.6 Zwei Arten: Strukturen und Unions

Spec: §8.6, S. 34 — “[DDS-XTypes] recognizes two kinds of aggregated types: structures and unions.”

Repo: —

Tests: —

Status: n/a (informative) — Einordnung der Spec. ### §8.6 Konstruktor ohne Argumente für nicht verschachtelte Typen, auch nicht öffentlich

Spec: §8.6, S. 34 — “Any DDS type that is not a nested type (in the sense of that word defined by [DDS-XTypes], as indicated in this Type Representation by the annotation @Nested) must define a no-argument constructor for use by the Service implementation. Service implementations shall have the capability to invoke this constructor reflectively, even if it is not public.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::pointMatchesV2, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::fieldsAndTheConstructorAreReachedWhateverTheirVisibility

Status: done — instantiate ruft getDeclaredConstructor() mit setAccessible(true) auf. In pointMatchesV2 hat Point einen Konstruktor ohne Argumente, der nur im Paket sichtbar ist, und wird gelesen. Fehlt der Konstruktor, nimmt instantiateCanonical den kanonischen Konstruktor (Record Mixed in mixedIsByteIdenticalToTypedPath). @Nested wird in ReflectionTypeSupport nicht ausgewertet. (Commit 4aa407a112d) ### §8.6 Felder der Klasse in der Reihenfolge von getDeclaredFields

Spec: §8.6, S. 34 — “The fields in the DDS structured type shall correspond to those of the Java class. Their order shall be that returned by the method java.lang.reflect.Class.getDeclaredFields.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::mixedIsByteIdenticalToTypedPath, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::pointMatchesV2, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theMembersOfTheBaseClassComeFirst

Status: done — fieldsOf liefert je Klasse die Felder in der Reihenfolge von getDeclaredFields(), die Felder der Oberklassen vor den eigenen (Item zu §8.6.1.1). mixedIsByteIdenticalToTypedPath vergleicht acht Felder mit der festen Reihenfolge des Writers, pointMatchesV2 zwei Felder mit den Bytes des Referenzvektors. (Commit 819bfcb46cb) ### §8.6 Statische und transiente Felder weggelassen

Spec: §8.6, S. 34 — “Static and/or transient fields shall be omitted.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.fieldsOf)

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::staticAndTransientFieldsCarryNoMember

Status: done — fieldsOf überspringt statische, transiente und synthetische Felder. staticAndTransientFieldsCarryNoMember prüft eine Klasse mit einem statischen, einem transienten und einem normalen Feld: die Oktette enthalten nur das normale (05 00 00 00), beim Lesen behält das transiente Feld den Wert des Konstruktors, createType listet nur das normale Mitglied. (Commit f0649c27acc) ### §8.6 Felder unabhängig von der Sichtbarkeit lesen und setzen

Spec: §8.6, S. 34 — “Service implementations shall have the capability to get and set the values of fields reflectively regardless of their declared access level (e.g., public, protected, private).”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::singleArgFactoryReflectsTypedBean, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::pointMatchesV2, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::theKindsOfTable81RoundTrip, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::fieldsAndTheConstructorAreReachedWhateverTheirVisibility

Status: done — fieldsOf ruft setAccessible(true) je Feld auf; get und instantiate lesen und setzen über Field. singleArgFactoryReflectsTypedBean schreibt und liest eine Klasse mit private-Feldern über ein Topic, pointMatchesV2 eine mit Feldern ohne Modifikator, theKindsOfTable81RoundTrip eine mit public-Feldern, fieldsAndTheConstructorAreReachedWhateverTheirVisibility eine mit private, protected, Paket- und public-Feld. (Commit 4aa407a112d) ### §8.6 Nicht verlangt: SecurityManager verhindert den Zugriff

Spec: §8.6, S. 34 — “Service implementations need not address the following cases: • A Java Security Manager (java.lang.SecurityManager) prevents privileged access to a non-public field or constructor.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.fieldsOf)

Tests: —

Status: n/a (informative) — Ausnahme von der Pflicht. fieldsOf wandelt eine SecurityException oder InaccessibleObjectException beim Zugriff in eine XcdrException mit dem Feldnamen. ### §8.6 Nicht verlangt: finale Felder

Spec: §8.6, S. 34 — “• A field that is neither static nor transient is declared final, preventing its value from being modified.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.instantiate)

Tests: —

Status: n/a (informative) — Ausnahme von der Pflicht. instantiate setzt Felder über Field.set nach setAccessible; für einen Record ohne Konstruktor ohne Argumente nimmt es den kanonischen Konstruktor (mixedIsByteIdenticalToTypedPath liest einen Record). ### §8.6 Nicht verlangt: Zyklen von Verweisen

Spec: §8.6, S. 34 — “• Object references form a cycle. (Cycles are not permitted by the DDS Type System.)”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.reflect)

Tests: —

Status: n/a (informative) — Ausnahme von der Pflicht. DynamicTypeFactoryImpl.reflect meldet eine Klasse, die sich über ihre Felder selbst enthält, als IllegalArgumentException; kein Test. Ein Objektgraph mit Zyklus führt in encodeStruct zu unbegrenzter Rekursion (aus dem Code gelesen, nicht gemessen). ### §8.6.1 Jede Klasse, die keine Collection und keine Map ist, als Struktur

Spec: §8.6.1, S. 34 — “Every Java class that is not a collection or map shall be considered a structure by default.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::nestedFinalInline

Status: done — Eine Klasse, die in encodeValue und decodeValue weder primitiv, String, Aufzählung, Array, Collection noch Map ist, geht über infoOf und encodeStruct als Struktur. nestedFinalInline schreibt und liest eine Line aus zwei verschachtelten Point inline (16 Bytes, ohne DHEADER). (Commit 819bfcb46cb) ### §8.6.1.1 Ableitung als Vererbung von Strukturen

Spec: §8.6.1.1, S. 34 — “Java class extension shall map to structure inheritance in the DDS Type System [DDS-XTypes], subject to the restrictions documented by the java.io.Serializable interface, such as those pertaining to non-Serializable base types.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.fieldsOf), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.baseTypeNames), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.reflect)

Status: done — fieldsOf stellt die Felder der Oberklassen vor die eigenen; theMembersOfTheBaseClassComeFirst liest und schreibt eine abgeleitete Klasse mit den Basisfeldern zuerst (12 Bytes: DHEADER der EXTENSIBLE-Klasse, zwei int32). baseTypeNames liefert die Namen der Oberklassen, aLocalWriterDescribesTheBaseTypesOfItsType prüft sie in den Built-in-Topic-Daten. DynamicTypeFactoryImpl.reflect setzt die Oberklasse (unterhalb von Object) als Basistyp und listet nur die eigenen Mitglieder (aDerivedClassIsAStructureWithTheSuperclassAsBaseType); theBytesOfADerivedDynamicTypeAreThoseOfTheClass vergleicht die Oktette von DynamicData mit denen der Klasse. Die Einschränkung von java.io.Serializable gilt: bei einer Serializable-Klasse haben die Felder einer Oberklasse, die nicht Serializable ist, kein Mitglied und keinen Basistyp (ReflectionTypeSupport.serializesFieldsOf); die Oberklasse wird beim Lesen durch ihren eigenen Konstruktor belegt. Eine Klasse, die nicht Serializable ist, behält alle Felder. (Commit 2de26533680) ### §8.6.1.2 FINAL bei direkter Ableitung von Object und final, oder ausdrücklich

Spec: §8.6.1.2, S. 34 — “• FINAL: If the class extends java.lang.Object directly and is final, or if explicitly indicated.”

Status: done — defaultExtensibility liefert FINAL für eine finale Klasse, die direkt von Object erbt. extensibilityFollowsTheClassShape prüft das und dass eine nicht finale oder abgeleitete Klasse nicht FINAL ist; pointMatchesV2 prüft die Bytes ohne DHEADER. Ausdrückliches @Extensibility(FINAL_EXTENSIBILITY) auf einer nicht finalen Klasse bildet mapExtensibility auf FINAL ab; finalCanBeSaidOnAClassThatIsNotFinal prüft getExtensibility(), die Oktette ohne DHEADER (01 00 00 00 02 00 00 00) und die Extensibility-Annotation in createType. (Commit f0649c27acc) ### §8.6.1.2 EXTENSIBLE als Vorgabe in allen anderen Fällen

Spec: §8.6.1.2, S. 34 — “• EXTENSIBLE: In all other cases, by default, or if explicitly indicated.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/JavaTypeRepresentationTest.java::extensibilityFollowsTheClassShape, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/TypesJavaRepresentationTest.java::aClassThatIsNotFinalIsWrittenWithADheader, crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::extensibleIsAppendable

Status: done — defaultExtensibility liefert für jede Klasse, die nicht final ist oder nicht direkt von Object erbt, ExtensibilityKind.APPENDABLE (EXTENSIBLE von §8.6.1.2; XTypes 1.3 nennt die Art APPENDABLE, XCDR2 schreibt sie mit DHEADER). extensibilityFollowsTheClassShape prüft OpenType und DerivedType; aClassThatIsNotFinalIsWrittenWithADheader die Oktette 08 00 00 00 01 00 00 00 02 00 00 00. (Commit f0649c27acc) ### §8.6.1.2 EXTENSIBLE ausdrücklich

Spec: §8.6.1.2, S. 34 — “• EXTENSIBLE: […] or if explicitly indicated.”

Tests: crates/java-omgdds/java/src/test/java/org/zerodds/cdr/ReflectionTypeSupportTest.java::extensibleIsAppendable

Status: done — mapExtensibility bildet EXTENSIBLE_EXTENSIBILITY auf ExtensibilityKind.APPENDABLE ab. extensibleIsAppendable setzt @Extensibility(EXTENSIBLE_EXTENSIBILITY), prüft getExtensibility() und die Bytes (DHEADER 8, zwei int) und liest sie zurück. (Commit f0649c27acc) ### §8.6.1.2 MUTABLE nur ausdrücklich

Spec: §8.6.1.2, S. 34 — “• MUTABLE: Only if explicitly indicated.”

Status: done — defaultExtensibility liefert nie MUTABLE; mapExtensibility liefert es für @Extensibility(MUTABLE_EXTENSIBILITY). anAnnotationOverridesTheDefault prüft MUTABLE mit der Annotation, extensibilityFollowsTheClassShape dass die Vorgabe es nicht ergibt; mutableRoundtrips und mutableLongRoundtrips schreiben und lesen (DHEADER und EMHEADER je Mitglied). (Commit 819bfcb46cb) ### §8.6.2 Union über @SerializeAs

Spec: §8.6.2, S. 34 — “Any class may be annotated as a union with @SerializeAs.”

Status: done — Eine Klasse mit @SerializeAs(UNION_TYPE) wird eine Union: Diskriminator, dann das gewählte Mitglied. aUnionIsItsDiscriminatorAndTheSelectedMember prüft die Bytes und das Lesen, aMutableUnionCarriesItsDiscriminatorAsMemberZero die MUTABLE-Form, aUnionHasItsDiscriminatorTypeAndLabels die UNION_TYPE-Beschreibung aus createType. (Commit 819bfcb46cb) ### §8.6.2 Genau ein Feld mit @UnionDiscriminator

Spec: §8.6.2, S. 34 — “• Such a class must annotate exactly one field to be the discriminator with @UnionDiscriminator.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.introspectUnion)

Status: done — introspectUnion verlangt genau ein Feld mit @UnionDiscriminator; ohne eines oder mit zweien wirft es XcdrException. aMisplacedUnionAnnotationIsRefused prüft die Klassen NoDiscriminator und TwoDiscriminators (und NotAUnion, UnmarkedMember, DuplicateLabel). (Commit 819bfcb46cb) ### §8.6.2 Übrige Felder mit @UnionMember und dem Wert des Diskriminators

Spec: §8.6.2, S. 34 — “• All other fields that are not transient or static must be annotated with @UnionMember, which shall identify the discriminator value associated with that field.”

Status: done — introspectUnion verlangt @UnionMember(discriminatorValue = ...) an jedem Feld außer dem Diskriminator (statische und transiente Felder sind schon vorher ausgeschieden) und weist doppelte Werte ab. aMisplacedUnionAnnotationIsRefused prüft UnmarkedMember und DuplicateLabel; aUnionIsItsDiscriminatorAndTheSelectedMember wählt das Mitglied über den Wert, aDiscriminatorThatSelectsNoMemberIsWrittenAlone einen Wert ohne Mitglied. (Commit 819bfcb46cb)

§8.7 Enumerations and Bit Sets

§8.7 Java-`enum` als DDS-Aufzählung

Spec: §8.7, S. 35 — “By default, any Java enumeration class will be considered to be a DDS enumeration.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.encodeValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.decodeValue), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/ReflectionTypeSupport.java (ReflectionTypeSupport.enumConstant), crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.enumeration)

Status: done — Eine Java-enum wird als Aufzählung geschrieben (Ordinalwert als int32) und über enumConstant gelesen; ein Wert außerhalb der Konstanten ist eine XcdrException. theKindsOfTable81RoundTrip schreibt und liest Colour.BLUE; createType liefert ENUMERATION_TYPE mit drei Mitgliedern. Die Bytes der Aufzählung prüft kein Test. (Commit 819bfcb46cb) ### §8.7 Aufzählung als Bitmenge annotierbar, die Objekte ebenfalls annotiert

Spec: §8.7, S. 35 — “As in IDL, a type that is syntactically an enumeration may be annotated as a bit set type. In this case, objects of these types must also be annotated in order to be serialized correctly.”

Status: done — Eine Aufzählung mit @BitSet (und @BitBound, Vorgabe 32) ist ein Bitset-Typ; ofField verlangt @BitSet auch am Mitglied und verweigert ein Mitglied vom Bitset-Typ ohne die Annotation mit XcdrException. theDefaultBitBoundIs32AndABitSetFieldNamesItsEnumeration schreibt ein Mitglied Wide one (vier Oktette, Bit der Konstante C), aMisplacedBitSetAnnotationIsRefused prüft UnannotatedBitSetMember. (Commit 874bc5ac9fe) ### §8.7 EnumSet und java.util.BitSet mit @BitSet als Bitmenge

Spec: §8.7, S. 35 — “A type member of type java.util.EnumSet or java.util.BitSet will be serialized as a bit set if marked with @BitSet.”

Status: done — Ein Mitglied vom Typ EnumSet oder java.util.BitSet mit @BitSet wird als Bitset geschrieben. anEnumSetMarkedBitSetIsAMaskWithTheBitBoundOfItsEnumeration prüft ein Oktett 0x05 für READ und EXEC, theDefaultBitBoundIs32AndABitSetFieldNamesItsEnumeration ein java.util.BitSet mit elementType (0x0a in vier Oktetten), aBitWithoutAConstantIsRefusedOnDecode Bits ohne Konstante. Mehr als 64 Bits verweigert bits mit XcdrException. (Commit 874bc5ac9fe)

§8.8 Modules

§8.8 Segmente des Paketnamens als Module

Spec: §8.8, S. 35 — “Each segment of a Java type’s package name shall correspond to a module in the DDS Type System [DDS-XTypes]. For example, a class com.acme.project.TheClass would be in the nested modules com::acme::project.”

Status: done — introspect bildet den Typnamen aus dem Klassennamen mit :: statt . und $. thePackageOfAClassIsTheModulesOfTheTypeName prüft com::acme::project::TypesTheClass für eine Klasse im Paket com.acme.project (als Topic und am TypeSupport) und org::zerodds::cdr::TypesJavaRepresentationTest::Skipped für eine verschachtelte Klasse; aLocalWriterDescribesTheBaseTypesOfItsType den Namen einer verschachtelten Oberklasse in getBaseTypeName. String hat den Namen DDS::String (Item zu DDS::String). (Commit f0649c27acc)

§8.9 Annotations

§8.9 Java-Annotationstypen werden standardmäßig nicht abgebildet

Spec: §8.9, S. 35 — “This Type Representation ignores Java annotation types by default.”

Status: done — annotation erkennt nur Annotationen aus org.omg.dds.type (und org.zerodds.types); fremde Annotationen mit gleichem einfachen Namen zählen nicht. onlyTheTypeSystemAnnotationsCount verwendet ForeignKey und ForeignId; die neuen Tests verwenden Annotationen Key, ID, Optional, MustUnderstand und Extensibility aus dem Paket org.zerodds.cdr.foreign, mit denselben einfachen Namen: Ein fremdes Key macht den Typ nicht keyed, ein fremdes Extensibility("MUTABLE") die Klasse nicht MUTABLE, ein fremdes ID(77) ändert die Member-ID nicht, ein fremdes MustUnderstand setzt das M-Flag nicht, ein fremdes Optional macht ein Mitglied nicht optional. anAnnotationTypeIsRepresentedOnlyWhenMarked prüft, dass createType einen nicht markierten Annotationstyp ablehnt. (Commit f0649c27acc) ### §8.9 Annotationen im Typsystem nur mit @SerializeAs

Spec: §8.9, S. 35 — “Java annotations that are intended to be represented explicitly within the DDS Type System must be so annotated with @SerializeAs.”

Repo: crates/java-omgdds/java/src/main/java/org/zerodds/cdr/DynamicTypeFactoryImpl.java (DynamicTypeFactoryImpl.reflectAnnotationType)

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/DynamicTypeReflectionTest.java::anAnnotationTypeIsRepresentedOnlyWhenMarked

Status: done — reflectAnnotationType bildet einen Annotationstyp nur mit @SerializeAs(ANNOTATION_TYPE) ab, mit einem Mitglied je Element und dessen Vorgabewert. Der Test prüft ANNOTATION_TYPE, die Mitgliedsarten STRING_TYPE und INT_32_TYPE, den Vorgabewert “none” und die Ablehnung des nicht markierten Typs. (Commit 36094b9d871)

§9.1 Type Mapping

§9.1 Typsystem nach [DDS-XTypes], übrige Aspekte nach dessen Plain Language Binding

Spec: §9.1, S. 37 — “The type system for DDS topic types is defined by the Extensible and Dynamic Topic Types for DDS specification [DDS-XTypes]. This sub clause defines the set of rules to be used in order to map abstract DDS topic types into Java types that can be used by application programmers. Those aspects of the DDS Type System that are not addressed below are as specified in the Plain Language Binding as defined by [DDS- XTypes] (which in turn is defined in terms of an IDL-to-Java mapping [Java-MAP]).”

Repo: crates/lang-rules/src/adapter/java.rs (JavaMapping)

Tests: —

Status: n/a (informative) — Nennt die Quellen der Regeln. Der Java-Generator hat zwei Abbildungen: --java-mapping psm (Vorgabe, Clause 9) und --java-mapping omg (IDL to Java, öffentliche Felder); siehe die Items zu §9.1.1 und §9.1.2. (Commit 5e078003c16) ### §9.1.1 Aggregattypen als finale Java-Klasse

Spec: §9.1.1, S. 37 — “DDS aggregation types shall be mapped to a final Java class.”

Repo: crates/lang-rules/src/adapter/java.rs (data_class), crates/lang-rules/src/adapter/java.rs (encapsulate)

Status: done — Beide Abbildungen erzeugen public static final class je Struktur. Der Test prüft unter JavaMapping::Psm public static final class Point { und Track { im erzeugten Text; the_psm_types_and_codec_compile_without_a_warning übersetzt die Ausgabe mit javac. Die Vorgabe von idlc generate --lang java ist psm, Clause 9 (the_java_mapping_defaults_to_psm_and_omg_is_selectable); --java-mapping omg wählt IDL to Java. (Commit 5e078003c16) ### §9.1.1 Attribute gekapselt

Spec: §9.1.1, S. 37 — “Contained attributes shall be encapsulated.”

Repo: crates/lang-rules/src/adapter/java.rs (encapsulate), crates/lang-rules/src/adapter/java.rs (field)

Status: done — Unter JavaMapping::Psm ist jedes Mitglied ein private-Feld mit Zugriffen. Der erste Test prüft private int x; und dass public int x; fehlt; der zweite, dass der Codec über getX()/setX(...) zugreift und kein direkter Feldzugriff bleibt. Unter omg (--java-mapping omg) bleiben die Felder öffentlich. (Commit 5e078003c16) ### §9.1.1 Zugriffe nach Java Beans

Spec: §9.1.1, S. 37 — “Java Bean style accessors shall be provided.”

Status: done — Unter JavaMapping::Psm erzeugt der Generator getX() und setX(int v), bei boolean zusätzlich isOn(), und für eine Union getDiscriminator()/setDiscriminator. Die Tests prüfen den erzeugten Text; the_psm_types_and_codec_compile_without_a_warning übersetzt ihn. Unter omg gibt es keine Zugriffe. (Commit 5e078003c16) ### §9.1.1 Sonderregeln für boolean-Eigenschaften erlaubt

Spec: §9.1.1, S. 37 — “Special mapping rules for boolean properties are allowed.”

Repo: crates/lang-rules/src/adapter/java.rs (boolean_getter_name)

Tests: crates/lang-rules/tests/java_psm_mapping.rs::an_aggregate_is_a_final_class_with_private_state_and_bean_accessors

Status: n/a (informative) — Erlaubnis. Der Generator macht davon Gebrauch: isOn() und getOn() für ein boolean-Mitglied, geprüft im Test zu §9.1.1. (Commit 5e078003c16) ### §9.1.1 Innerer Zustand privat

Spec: §9.1.1, S. 37 — “The representation of internal state shall be private.”

Repo: crates/lang-rules/src/adapter/java.rs (encapsulate), crates/lang-rules/src/adapter/java.rs (field)

Status: done — Unter JavaMapping::Psm sind Felder und der Diskriminator einer Union private (private int x;, private int _d;); die Tests prüfen den Text, und dass public int x; fehlt. (Commit 5e078003c16) ### §9.1.2 Unbegrenzte Folgen als Collection<E>, gekapselt, mit Zugriffen nach Java Beans

Spec: §9.1.2, S. 37 — “Unbounded DDS sequences are mapped to Collection interface. The state is encapsulated and getters/setters are provided through bean style property accessors.”

Repo: crates/lang-rules/src/adapter/java.rs (type_at), crates/lang-rules/src/adapter/java.rs (encapsulate)

Status: done — Unter JavaMapping::Psm wird sequence<long> ein private java.util.Collection<java.lang.Integer> mit getSamples() und setSamples(...); geschachtelte Folgen sind Collection<Collection<String>>. Der Test prüft den Text, der zweite Test den Codec über Sequences; omg (--java-mapping omg) bildet unverändert auf T[] ab. (Commit 5e078003c16) ### §9.1.2 Begrenzte Folgen als Java-Arrays

Spec: §9.1.2, S. 37 — “Bounded sequences and arrays are mapped to Java arrays.”

Repo: crates/lang-rules/src/adapter/java.rs (type_at)

Status: done — Unter JavaMapping::Psm bleibt sequence<long, 4> ein private int[] bounded;; type_at wählt Collection nur für Bound::Unbounded. Der Test prüft den Text, der Codec kürzt mit Sequences.first(v, 4). (Commit 5e078003c16) ### §9.1.2 Arrays als Java-Arrays

Spec: §9.1.2, S. 37 — “Bounded sequences and arrays are mapped to Java arrays.”

Repo: crates/lang-rules/src/adapter/java.rs (type_at)

Status: done — type_at, Zweig TypeKind::Array: long a[3] wird int[], long g[2][3] wird int[][]. a_sequence_and_an_array_are_both_java_arrays prüft das unter omg; unter psm prüft der zweite Test private ZdTypes.demo.Point[] vicinity; und ein Array von Folgen als Collection<Integer>[]. (Commit 5e078003c16)

§9.2 Example

§9.2 Beispiel `Point` und `RadarTrack`

Spec: §9.2, S. 38–39 — “Example (non-normative) […] public final class Point { Point(); Point(int x, int y, java.lang.Integer z); int getX(); void setX(int32 v); […] }; public class final RadarTrack { […] java.util.Collection getPlot(); […] };”

Repo: —

Tests: —

Status: n/a (informative) — Beispiel. Es ist kein übersetzbares Java (int32, public class final, Collection<byte>, };). idlc generate --lang java --java-mapping psm erzeugt für IDL finale Klassen mit privaten Feldern, Bean-Zugriffen und Collection<E> für unbegrenzte Folgen. (Commit 5e078003c16)

Annex A Java JAR Library File

Annex A JAR `omgdds.jar` mit allen Klassen der PSM

Spec: Annex A, S. 41 — “In addition to this document, this specification includes a Java Archive (JAR) library, omgdds.jar. This library contains compiled Java *.class files for all of the classes and interfaces specified by this PSM.”

Repo: —

Tests: —

Status: n/a (informative) — Beschreibt das Artefakt der OMG. crates/java-omgdds/java/pom.xml baut die JAR org.zerodds:omgdds mit den Klassen unter org/omg/dds, deren Quellen bis auf 11 von 184 Dateien den OMG-Quellen entsprechen (siehe Items zu Annex A und B). ### Annex A Übersetzen gegen omgdds.jar, Ausführen gegen jede Implementierung

Spec: Annex A, S. 41 — “This library comprises the compile-time portion of this specification: users shall be able to compile their PSM-compliant code against this library and then deploy the result against any conformant implementation.”

Tests: crates/java-omgdds/java/src/test/java/org/omg/dds/QuickstartApiTest.java::singleArgFactoryReflectsTypedBean, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesPsmApiTest.java::ddsExceptionIsADdsObjectAsInTheOmgSource, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesPsmApiTest.java::noClassOfTheApiPackageRefersToTheImplementation, crates/java-omgdds/java/src/test/java/org/omg/dds/TypesPsmApiTest.java::theExceptionsAreAbstractAndHaveTheSerialVersionUidOfTheOmgSource

Status: done — org/omg/dds/core/DDSException.java implementiert wie die OMG-Quelle DDSObject; die sieben Ausnahmeklassen in org.zerodds.core antworten mit getEnvironment() (das Standard-Environment der Implementierung). Ein Vergleich der Dateien unter org/omg/dds mit .agent/omg-java/srcJava ergibt nach Bytes gleiche Dateien bis auf EntityQos (zusätzlich @SuppressWarnings und ein Kommentar) und drei Dateien mit anderen Zeilenenden (DomainParticipantFactory, DataWriter, DataReader). TypesPsmApiTest prüft DDSObject an DDSException, die serialVersionUID-Werte und abstrakte Klassen der zehn Ausnahmen und dass keine Klasse in org.omg.dds (ohne rpc) auf org/zerodds verweist, also gegen eine andere Implementierung laufen kann. Die Tests des Moduls sind selbst Clients der Klassen von org.omg.dds. (Commit 63098240e0c) ### Annex A omgdds neben der Implementierung oder in einer gemeinsamen Bibliothek

Spec: Annex A, S. 41 — “Distributors of binary implementations of this PSM may elect to distribute the omgdds library alongside their implementation libraries or to package both the contents of omgdds.jar and their implementation into a single library.”

Repo: crates/java-omgdds/java/pom.xml

Tests: —

Status: n/a (informative) — Erlaubnis für den Verteiler. ZeroDDS packt die Klassen von org/omg/dds und die Implementierung in eine JAR (org.zerodds:omgdds, crates/java-omgdds/java/pom.xml). (Commit 5536e2abcac)

Annex B Java Source Code

Annex B Quellen in `omgdds_src.zip`, normativ für Schnittstellen und Kommentare

Spec: Annex B, S. 43 — “In addition to this document, this specification includes the Java source code to all of the classes and interfaces specified by this PSM in the zip archive omgdds_src.zip. This source code, in the directory srcJava within the archive, corresponds to the binary distribution found in the library omgdds.jar and is also normative with respect to both its programming interfaces and its embedded documentation comments.”

Status: done — Die zehn Ausnahmeklassen unter org/omg/dds/core sind die Dateien der OMG-Quellen (Kommentare, serialVersionUID, DDSException implements DDSObject). Alle 184 Dateien unter org/omg/dds stimmen nach Zeichen mit der Quelle überein (Zeilenenden als LF gelesen), einschließlich der Kommentare: type/TypeSupport.java und core/EntityQos.java sind die Dateien der Quelle (die Abbildung des Namens java.lang.Class auf den Namen der Klasse steht in ServiceEnvironmentImpl.newTypeSupport; die Warnung „possible heap pollution“ an EntityQos.withPolicies(P...) ist durch die Übersetzungsoptionen des Moduls ausgeschaltet: -Xlint:all,-unchecked,-options -Werror für die Hauptquellen in pom.xml). CoreApiShapeTest::theFilesOfOrgOmgDdsHaveTheDigestsOfTheOmgSource vergleicht die Dateien bei jedem Lauf mit den SHA-256 der Quelle (src/test/resources/omgdds-srcjava.sha256, aus omgdds_src.zip) und verlangt, dass keine abweicht. TypesPsmApiTest prüft die serialVersionUID-Werte und, dass ServiceConfigurationException und ServiceInitializationException in der Quelle einfache RuntimeExceptions sind. (Commit 53910e766ac) ### Annex B Beispiele, build.xml und Projektdateien nicht normativ

Spec: Annex B, S. 43 — “For the convenience of both implementers and application developers, the archive contains additional files that are neither API source code nor documentation. These file are non-normative and include: […]”

Repo: —

Tests: —

Status: n/a (informative) — Nicht normativ.

Audit-Status

447 done / 0 partial / 0 open / 0 blocked / 79 n/a (informative).

Offene Punkte: keine.

DDS-Java 1.0 (Java 5 Language PSM for DDS) — Spec Coverage

§1 Scope

§1 PSM for DCPS only, without DLRL

§2 Conformance

§2 PDF, JAR and source files normative, JAR and sources prevail in a conflict

§2 Programming interfaces of [DDS] 1.2: Entity

§2 Entity: set_qos and get_qos

§2 Programming interfaces of [DDS] 1.2: DomainParticipantFactory

§2 DomainParticipantFactory: create_participant

§2 Programming interfaces of [DDS] 1.2: DomainParticipant

§2 DomainParticipant: create_publisher and delete_publisher

§2 Programming interfaces of [DDS] 1.2: topic classes

§2 TopicDescription: get_participant

§2 Programming interfaces of [DDS] 1.2: Publisher

§2 Publisher: create_datawriter and delete_datawriter

§2 Programming interfaces of [DDS] 1.2: DataWriter

§2 DataWriter: register_instance and register_instance_w_timestamp

§2 Programming interfaces of [DDS] 1.2: DataWriterListener

§2 DataWriterListener: on_liveliness_lost

§2 Programming interfaces of [DDS] 1.2: Subscriber

§2 Subscriber: create_datareader and delete_datareader

§2 Programming interfaces of [DDS] 1.2: DataReader

§2 DataReader: read

§2 Programming interfaces of [DDS] 1.2: SampleInfo

§2 SampleInfo: sample_state

§2 Programming interfaces of [DDS] 1.2: DataReaderListener

§2 DataReaderListener: on_data_available

§2 Programming interfaces of [DDS] 1.2: conditions and WaitSet

§2 Condition: get_trigger_value

§2 Programming interfaces of [DDS] 1.2: built-in topics

§2 Built-in topics: DCPSParticipant

§3 References

§3.1 [DDS] version 1.2

§4 Terms and Definitions

§4 Data-Centric Publish-Subscribe (DCPS)

§5 Symbols

§5 No symbols

§6 Additional Information

§6.1 No change to other OMG specs

§7.1 Specification Organization

§7.1 Organized by the modules of [DDS]

§7.2 General Concerns and Conventions

§7.2 Cross-cutting definitions

§7.3 Infrastructure Module

§7.3 Two packages org.omg.dds.core and org.omg.dds.core.policy

§7.4 Domain Module

§7.4 Package org.omg.dds.domain

§7.5 Topic Module

§7.5 Packages org.omg.dds.type and org.omg.dds.topic

§7.6 Publication Module

§7.6 Package org.omg.dds.pub

§7.7 Subscription Module

§7.7 Package org.omg.dds.sub

§7.8 Extensible and Dynamic Topic Types Module

§7.8 Types of the TypeObject representation in org.omg.dds.type.typeobject

§8.1 General

§8.1 Publish Java objects without code generation and without the Dynamic Language Binding

§8.2 Default Mappings

§8.2 Table 8.1: int, java.lang.Integer → INT32

§8.3 Metadata

§8.3 IDL metadata as equivalent Java annotations

§8.4 Primitive Types

§8.4 Defaults by Table 8.2, changes through @SerializeAs

§8.5 Collections

§8.5 Three kinds of collections

§8.6 Aggregated Types

§8.6 Two kinds: structures and unions

§8.7 Enumerations and Bit Sets

§8.7 Java enum as a DDS enumeration

§8.8 Modules

§8.8 Segments of the package name as modules

§8.9 Annotations

§8.9 Java annotation types not mapped by default

§9.1 Type Mapping

§9.1 Type system by [DDS-XTypes], other aspects by its Plain Language Binding

§9.2 Example

§9.2 Example Point and RadarTrack

Annex A Java JAR Library File

Annex A JAR omgdds.jar with all classes of the PSM

Annex B Java Source Code

§7.3 Two packages `org.omg.dds.core` and `org.omg.dds.core.policy`

§7.4 Package `org.omg.dds.domain`

§7.5 Packages `org.omg.dds.type` and `org.omg.dds.topic`

§7.6 Package `org.omg.dds.pub`

§7.7 Package `org.omg.dds.sub`

§7.8 Types of the TypeObject representation in `org.omg.dds.type.typeobject`

§8.2 Table 8.1: `int`, `java.lang.Integer` → INT32

§8.4 Defaults by Table 8.2, changes through `@SerializeAs`

§8.7 Java `enum` as a DDS enumeration

§9.2 Example `Point` and `RadarTrack`

Annex A JAR `omgdds.jar` with all classes of the PSM

Annex B Sources in `omgdds_src.zip`, normative for interfaces and comments

§7.3 Zwei Pakete `org.omg.dds.core` und `org.omg.dds.core.policy`

§7.4 Paket `org.omg.dds.domain`

§7.5 Pakete `org.omg.dds.type` und `org.omg.dds.topic`

§7.6 Paket `org.omg.dds.pub`

§7.7 Paket `org.omg.dds.sub`

§7.8 Typen der TypeObject-Darstellung in `org.omg.dds.type.typeobject`

§8.2 Table 8.1: `int`, `java.lang.Integer` → INT32

§8.4 Vorgaben nach Table 8.2, Änderung über `@SerializeAs`